[PATCH 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index c0e1e83796..b8b1093b61 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -587

[PATCH 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or zero-plain) For unallocated clusters we can safely fix the entry

[PATCH 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved

Split checking for reserved bits out of aligned offset check. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 + block/qcow2-refcount.c | 10 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index 58fd7f1678..fd48

[PATCH 08/10] qcow2-refcount: improve style of check_refcounts_l1()

- use g_autofree for l1_table - better name for size in bytes variable - reduce code blocks nesting - whitespaces, braces, newlines Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 97 +- 1 file changed, 49 insertions(+), 48 del

[PATCH 02/10] qcow2: compressed read: simplify cluster descriptor passing

Let's pass the whole L2 entry and not bother with L2E_COMPRESSED_OFFSET_SIZE_MASK. It also helps further refactoring that adds generic qcow2_parse_compressed_l2_entry() helper. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 - block/qcow2-cluster.c | 5 ++--- block/

[PATCH 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits

Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h | 1 + block/qcow2-refcount.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/block/qcow2.h b/block/qcow2.h index b8b1093b61..58fd7f1678 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -586,6 +586,7 @@ typedef enu

Re: remove the nvlink2 pci_vfio subdriver v2

On Tue, 4 May 2021 16:11:31 +0200 Greg Kurz wrote: > On Tue, 4 May 2021 15:30:15 +0200 > Greg Kroah-Hartman wrote: > > > On Tue, May 04, 2021 at 03:20:34PM +0200, Greg Kurz wrote: > > > On Tue, 4 May 2021 14:59:07 +0200 > > > Greg Kroah-Hartman wrote: > > > > > > > On Tue, May 04, 2021 at

Re: [PATCH v3 04/26] DAX: libvhost-user: Route slave message payload

On Wed, Apr 28, 2021 at 12:00:38PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Route the uint64 payload from message replies on the slave back up > through vu_process_message_reply and to the callers. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: S

Re: [PATCH v3 03/26] DAX: vhost-user: Rework slave return values

On Wed, Apr 28, 2021 at 12:00:37PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > All the current slave handlers on the qemu side generate an 'int' > return value that's squashed down to a bool (!!ret) and stuffed into > a uint64_t (field of a union) to be returne

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Tue, May 04, 2021 at 03:32:55PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 29, 2021 at 02:03:52PM -0400, Eduardo Habkost wrote: > > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > > Live migrating old guests from an old QEMU with the SCSI feature bit > > > enabled will fail

Re: [PATCH v11 1/6] arm64: mte: Sync tags for pages where PTE is untagged

On Thu, Apr 29, 2021 at 05:06:05PM +0100, Steven Price wrote: > On 27/04/2021 18:43, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:04PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/asm/pgtable.h > > > b/arch/arm64/include/asm/pgtable.h > > > index e17b96d0e4b5..cf4b5

[PATCH] vfio/pci: Revert nvlink removal uAPI breakage

Revert the uAPI changes from the below commit with notice that these regions and capabilities are no longer provided. Fixes: b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") Reported-by: Greg Kurz Signed-off-by: Alex Williamson --- Greg (Kurz), please double check this resolves the issue. Th

[Bug 1828867] Re: QEmu translation is incorrect when using REX in combination with LAHF/SAHF

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/130 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [RFC PATCH v2 0/2] hw/ppc: code motion to compile without TCG

Thanks, it will be quite helpful. Also, I agree with Bruno including this information somewhere would be quite good in my opinion. From: Fabiano Rosas Sent: Monday, May 3, 2021 7:21 PM To: Lucas Mateus Martins Araujo e Castro ; qemu-devel@nongnu.org ; qemu-...@n

Re: [PATCH v4 2/5] target/ppc: renamed SPR registration functions

On 5/4/21 7:01 AM, Bruno Larsen (billionai) wrote: Renamed all gen_spr_* and gen_* functions specifically related to registering SPRs to register_*_sprs and register_*, to avoid future confusion with other TCG related code. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/translate_init.

Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest

Hi Wainer, On 5/4/21 12:43 AM, Wainer dos Santos Moschetta wrote: > The Sun4uMachine class inherit from LinuxKernelTest to effectively only use > the KERNEL_COMMON_COMMAND_LINE attribute. This change remove that unneeded > dependency, making Sun4uMachine self-content. It is odd because the test b

Re: [PULL 0/5] bsd-user: minor cleanup patches

On Fri, 30 Apr 2021 at 18:46, Warner Losh wrote: > > The following changes since commit ffa090bc56e73e287a63261e70ac02c0970be61a: > > target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for > writeability (2021-04-23 14:10:56 +0100) > > are available in the Git repository at: > > http

Re: [PATCH] vfio/pci: Revert nvlink removal uAPI breakage

On Tue, 04 May 2021 09:52:02 -0600 Alex Williamson wrote: > Revert the uAPI changes from the below commit with notice that these > regions and capabilities are no longer provided. > > Fixes: b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") > Reported-by: Greg Kurz > Signed-off-by: Alex Willia

Re: [PATCH] vfio/pci: Revert nvlink removal uAPI breakage

On Tue, 04 May 2021 09:52:02 -0600 Alex Williamson wrote: > Revert the uAPI changes from the below commit with notice that these > regions and capabilities are no longer provided. > > Fixes: b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") > Reported-by: Greg Kurz > Signed-off-by: Alex Willia

[PATCH] qcow2: set bdi->is_dirty

Set bdi->is_dirty, so that qemu-img info could show dirty flag. After this commit the following check will show '"dirty-flag": true': ./build/qemu-img create -f qcow2 -o lazy_refcounts=on x 1M ./build/qemu-io x qemu-io> write 0 1M After "write" command success, kill the qemu-io process: kill -

Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator

On 5/3/21 11:19 PM, Eric Blake wrote: > On 5/3/21 4:10 PM, Philippe Mathieu-Daudé wrote: >> Now than we can probe if the TCG accelerator is available > > that Oops. I'll wait for Igor review before respinning. > >> at runtime with a QMP command, do it once at the beginning >> and only register

Re: [PATCH v4 3/5] target/ppc: move SPR R/W callbacks to translate.c

On 5/4/21 7:01 AM, Bruno Larsen (billionai) wrote: Moved all read and write callbacks for SPRs away from translate_init.c.inc and into translate.c; these functions are TCG only, so this motion is required to enable building with the flag disable-tcg Signed-off-by: Bruno Larsen (billionai) Rev

Re: [RESEND PATCH 05/32] vl: Add "sgx-epc" option to expose SGX EPC sections to guest

On Tue, May 04, 2021, Paolo Bonzini wrote: > On 04/05/21 02:09, Sean Christopherson wrote: > > Is there a way to process "-device sgx-epc..." before vCPUs are realized? > > The > > ordering problem was the only reason I added a dedicated option. > > If it's just CPUID, one possibility could be t

Re: [PATCH] qcow2: set bdi->is_dirty

On 5/4/21 11:06 AM, Vladimir Sementsov-Ogievskiy wrote: > Set bdi->is_dirty, so that qemu-img info could show dirty flag. > > After this commit the following check will show '"dirty-flag": true': > > ./build/qemu-img create -f qcow2 -o lazy_refcounts=on x 1M > ./build/qemu-io x > qemu-io> write 0

[PATCH 0/3] Add support for PMBus in QEMU

Hello, This patch series adds an interface to start supporting PMBus devices in QEMU. I’ve included two PMBus devices: MAX34451 and ADM1272. PMBus is a variant of SMBus meant for digital management of power supplies. PMBus adds to the SMBus standard by defining a number of constants and commands

[PATCH 1/3] hw/i2c: add support for PMBus

QEMU has support for SMBus devices, and PMBus is a more specific implementation of SMBus. The additions made in this commit makes it easier to add new PMBus devices to QEMU. https://pmbus.org/specification-archives/ Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig

Re: remove the nvlink2 pci_vfio subdriver v2

On Tue, May 04, 2021 at 12:53:27PM -0300, Jason Gunthorpe wrote: > On Tue, May 04, 2021 at 04:23:40PM +0200, Daniel Vetter wrote: > > > Just my 2cents from drm (where we deprecate old gunk uapi quite often): > > Imo it's best to keep the uapi headers as-is, but exchange the > > documentation with

Re: remove the nvlink2 pci_vfio subdriver v2

On Tue, May 04, 2021 at 04:23:40PM +0200, Daniel Vetter wrote: > Just my 2cents from drm (where we deprecate old gunk uapi quite often): > Imo it's best to keep the uapi headers as-is, but exchange the > documentation with a big "this is removed, never use again" warning: We in RDMA have been doi

[PATCH 2/2] QOMify sifive_uart model

Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 6 +-- hw/char/sifive_uart.c | 72 ++- 2 files changed, 65 insertions(+), 13 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h index 3e962be659..45d66b1d

[PATCH 3/3] hw/misc: add MAX34451 device

The MAX34451 is a Maxim power-supply system manager that can monitor up to 16 voltage rails or currents. It also contains a temperature sensor and supports up to four external temperature sensors. This commit adds support for interfacing with it, and setting limits on the supported sensors. Re

[PATCH 2/3] hw/misc: add ADM1272 device

The ADM1272 is a PMBus compliant Hot Swap Controller and Digital Power Monitor by Analog Devices. This commit adds support for interfacing with it, and support for setting and monitoring sensor limits. Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1272.pdf Re

[PATCH 0/2] QOMify Sifive UART model

Hello, This patch QOMifies the Sifive UART model. It is split into two commits. The first commit makes the sifive uart read and write function names more consistent. The second commit QOMifies the model. Looking forward to hear from you, Lukas Lukas Jünger (2): Consistent function names for si

Re: [RESEND PATCH 05/32] vl: Add "sgx-epc" option to expose SGX EPC sections to guest

On 04/05/21 18:20, Sean Christopherson wrote: If it's just CPUID, one possibility could be to mark the EPC sections specially in KVM_SET_USER_MEMORY_REGION and synthesize the leaves within KVM; or even look inside the VMA structs and detect EPC regions that way. I experimented with those option

Re: [PATCH v4 4/5] target/ppc: turned SPR R/W callbacks not static

On 5/4/21 7:01 AM, Bruno Larsen (billionai) wrote: To be able to compile translate_init.c.inc as a standalone file, we have to make the callbacks accessible outside of translate.c; This patch does exactly that Signed-off-by: Bruno Larsen (billionai) --- target/ppc/spr_tcg.h | 134 +++

[PATCH 1/2] Consistent function names for sifive uart read and write function

Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 3a00ba7f00..cb70374ead 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -65,7 +65,7 @@ stat

Re: [PATCH] qcow2: set bdi->is_dirty

On 04.05.2021 19:06, Vladimir Sementsov-Ogievskiy wrote: > Set bdi->is_dirty, so that qemu-img info could show dirty flag. > > After this commit the following check will show '"dirty-flag": true': > > ./build/qemu-img create -f qcow2 -o lazy_refcounts=on x 1M > ./build/qemu-io x > qemu-io> write

[PATCH] migration: do not restart VM after successful snapshot-load

The HMP loadvm code is calling load_snapshot rather than qmp_snapshot_load, in order to bypass the job infrastructure. The code around it is almost the same, with one difference: hmp_loadvm is restarting the VM if load_snapshot fails, qmp_snapshot_load is doing so if load_snapshot succeeds. Fix t

Re: [PATCH] migration: do not restart VM after successful snapshot-load

On 5/4/21 11:58 AM, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapshot_l

[Bug 1857226] Re: 'set_link net0 off' not working with e1000e driver

Still reproducible on Fedora 34 with QEMU 5.2.0. ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1857226 Title: 'set_link net0 off' not working w

Re: [PATCH] migration: do not restart VM after successful snapshot-load

On Tue, May 04, 2021 at 12:58:26PM -0400, Paolo Bonzini wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

On Thu, Apr 29, 2021 at 05:06:41PM +0100, Steven Price wrote: > On 28/04/2021 18:07, Catalin Marinas wrote: > > I probably asked already but is the only way to map a standard RAM page > > (not device) in stage 2 via the fault handler? One case I had in mind > > was something like get_user_pages() b

Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

On Thu, Apr 29, 2021 at 05:06:07PM +0100, Steven Price wrote: > On 27/04/2021 18:58, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/uapi/asm/kvm.h > > > b/arch/arm64/include/uapi/asm/kvm.h > > > index 24223adae150..2b8

Re: [RFC PATCH v2 2/2] hw/ppc: Moved TCG code to spapr_hcall_tcg

On 03/05/2021 01:34, David Gibson wrote: On Fri, Apr 30, 2021 at 03:40:47PM -0300, Lucas Mateus Castro (alqotel) wrote: Moved h_enter, remove_hpte, h_remove, h_bulk_remove,h_protect and h_read to spapr_hcall_tcg.c, added h_tcg_only to be used in a !TCG environment in spapr_hcall.c and changed b

Gitlab Issue Tracker - Proposed Workflow

I'm seeking feedback on our Gitlab issue handling workflow. (There's a TLDR at the bottom of the mail.) # Background: Last KVM Forum, I started experimenting with the Gitlab issue tracker: https://gitlab.com/qemu-project/qemu/-/issues At the time, I hastily added some labels to roughly approxi

Re: Gitlab Issue Tracker - Proposed Workflow

On Tue, May 04, 2021 at 02:33:58PM -0400, John Snow wrote: > I'm seeking feedback on our Gitlab issue handling workflow. > (There's a TLDR at the bottom of the mail.) > > > # Background: > > Last KVM Forum, I started experimenting with the Gitlab issue tracker: > https://gitlab.com/qemu-project/

Re: [PATCH] migration: do not restart VM after successful snapshot-load

* Paolo Bonzini (pbonz...@redhat.com) wrote: > The HMP loadvm code is calling load_snapshot rather than > qmp_snapshot_load, in order to bypass the job infrastructure. The code > around it is almost the same, with one difference: hmp_loadvm is > restarting the VM if load_snapshot fails, qmp_snapsh

Re: [PATCH 01/10] qcow2-refcount: improve style of check_refcounts_l2()

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > - don't use same name for size in bytes and in entries > - use g_autofree for l2_table > - add whitespace > - fix block comment style > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-refcount.c | 47

Re: [PATCH 02/10] qcow2: compressed read: simplify cluster descriptor passing

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Let's pass the whole L2 entry and not bother with > L2E_COMPRESSED_OFFSET_SIZE_MASK. > > It also helps further refactoring that adds generic > qcow2_parse_compressed_l2_entry() helper. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > ---

[Bug 1868116] Re: QEMU monitor no longer works

Looking at the comments, it seems to me that this was an issue in VTE that got fixed. Is there still anything left to do for upstream QEMU here? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [PATCH 03/10] qcow2: introduce qcow2_parse_compressed_l2_entry() helper

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Add helper to parse compressed l2_entry and use it everywhere instead > of opencoding. open-coding > > Note, that in most places we move to precise coffset/csize instead of > sector-aligned. Still it should work good enough for updating >

[Bug 1658141] Re: QEMU's default msrs handling causes Windows 10 64 bit to crash

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/131 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH 04/10] qcow2-refcount: introduce fix_l2_entry_by_zero()

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Split fix_l2_entry_by_zero() out of check_refcounts_l2() to be > reused in further patch. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-refcount.c | 87 +- > 1 file changed, 60

[Bug 1861404] Re: AVX instruction VMOVDQU implementation error for YMM registers

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/132 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [RFC PATCH 07/27] virtio-snd: Add properties for class init

On Tue, 4 May 2021 at 19:02, Laurent Vivier wrote: > There is nothing specific to PCI in that code, why do you prevent the use > of virtio-snd as a MMIO > device? > > I am sorry I do not understand your question completely. If by preventing the use of virtio-snd, you mean why did I add the PCI de

Re: [PATCH 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > We'll reuse the function to fix wrong L2 entry bitmap. Support it now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-refcount.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --

Re: [PATCH 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Check subcluster bitmap of the l2 entry for different types of > clusters: > > - for compressed it must be zero > - for allocated check consistency of two parts of the bitmap > - for unallocated all subclusters should be unallocated >

[Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/133 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h | 1 + > block/qcow2-refcount.c | 12 +++- > 2 files changed, 12 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Softw

[Bug 1892081] Re: Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/134 ** Changed in: qemu Status: In Progress => Expired ** C

Re: [PATCH 08/10] qcow2-refcount: improve style of check_refcounts_l1()

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > - use g_autofree for l1_table > - better name for size in bytes variable > - reduce code blocks nesting > - whitespaces, braces, newlines > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-refcount.c | 97

Re: [PATCH 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h | 1 + > block/qcow2-refcount.c | 6 ++ > 2 files changed, 7 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc

Re: [PATCH 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved

On 5/4/21 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Split checking for reserved bits out of aligned offset check. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h | 1 + > block/qcow2-refcount.c | 10 +- > 2 files changed, 10 insertions(+), 1 deletion

Re: Gitlab Issue Tracker - Proposed Workflow

On Tue, 4 May 2021 at 19:34, John Snow wrote: > # Some concerns on the above scheme: > > - "In Progress" is not likely to be used faithfully and will fall out of > sync often. It's not clear if there should be a difference between a bug > having an assignee and a bug labeled "In Progress". I don't

Re: [RFC PATCH 07/27] virtio-snd: Add properties for class init

Hi Shreyansh, First of all, thank you for your work, I was expecting a virtio sound device for some time... Le 04/05/2021 à 21:35, Shreyansh Chouhan a écrit : > On Tue, 4 May 2021 at 19:02, Laurent Vivier > wrote: > > There is nothing specific to PCI in that code,

Re: [PATCH v4 0/5] target/ppc: Untangle CPU init from translation

"Bruno Larsen (billionai)" writes: > Based-on: ppc-for-6.1 tree > > This patch series aims to remove the logic of initializing CPU from > the file related to TCG translation. To achieve this, we have to make > it so registering SPRs isn't directly tied to TCG, and move code only > related to tran

Re: [PATCH 1/3] hw/i2c: add support for PMBus

Hi Titus, On 5/4/21 6:28 PM, Titus Rwantare wrote: > QEMU has support for SMBus devices, and PMBus is a more specific > implementation of SMBus. The additions made in this commit makes it easier to > add new PMBus devices to QEMU. > > https://pmbus.org/specification-archives/ > > Reviewed-by: Ha

Re: [RFC PATCH 07/27] virtio-snd: Add properties for class init

On Wed, 5 May 2021 at 02:00, Laurent Vivier wrote: > Hi Shreyansh, > > First of all, thank you for your work, I was expecting a virtio sound > device for some time... > > You're welcome :) > Le 04/05/2021 à 21:35, Shreyansh Chouhan a écrit : > > On Tue, 4 May 2021 at 19:02, Laurent Vivier laur.

Re: [PATCH v3 0/6] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs

On 03/05/2021 18:12, Philippe Mathieu-Daudé wrote: Missing review: 6 Hi Mark, This series QOM'ify the sun4m machines. I need it for a further memory maxsize check. It is mostly code movement (and the diff-stat is good). Since v2: - use static const variable for hwdef (Richard) - added Richard

Re: [PATCH v2 0/4] hw/sparc: Kconfig fixes to build with/without the leon3 machine

On 28/04/2021 15:16, Philippe Mathieu-Daudé wrote: Missing review: 2-4 Since v1: - move cpu_check_irqs() to target/sparc/ (rth) This series fixes link failure when building either the leon3 machine or the sun4m ones. The problem is we have hardware specific code in the architectural translati

Re: Gitlab Issue Tracker - Proposed Workflow

On 5/4/21 2:52 PM, Daniel P. Berrangé wrote: On Tue, May 04, 2021 at 02:33:58PM -0400, John Snow wrote: I'm seeking feedback on our Gitlab issue handling workflow. (There's a TLDR at the bottom of the mail.) - In Progress: For issues that a developer is actively working on. The intent was to

Re: Gitlab Issue Tracker - Proposed Workflow

On 5/4/21 4:24 PM, Peter Maydell wrote: On Tue, 4 May 2021 at 19:34, John Snow wrote: # Some concerns on the above scheme: - "In Progress" is not likely to be used faithfully and will fall out of sync often. It's not clear if there should be a difference between a bug having an assignee and a

Re: [PATCH 1/3] hw/i2c: add support for PMBus

Hi Phil, It looks big but the bulk of it is simple switch statements and definitions. Unless you mean you'd like it split despite that. Regards, Titus On Tue, 4 May 2021 at 16:49, Philippe Mathieu-Daudé wrote: > > Hi Titus, > > On 5/4/21 6:28 PM, Titus Rwantare wrote: > > QEMU has support for

[PATCH v3 0/2] cocoa: keyboard quality of life

From: Gustavo Noronha Silva v3 removes a rogue ; that made its way into v2 and makes the swap-option-command parameter off by default, so existing behaviour is maintained, as suggested by BALATON Zoltan. - This series adds two new options to the cocoa display: - full-grab causes it to use

[PATCH v3 2/2] ui/cocoa: add option to swap Option and Command, enable by default

From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, disabled by default. Ack

[PATCH v3 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH 1/2] hw/ppc/spapr.c: Extract MMU mode error reporting into a function

A following patch will make use of it. Signed-off-by: Fabiano Rosas --- hw/ppc/spapr.c | 16 hw/ppc/spapr_hcall.c | 14 ++ include/hw/ppc/spapr.h | 1 + 3 files changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index

[PATCH 2/2] hw/ppc/spapr.c: Make sure the host supports the selected MMU mode

Starting with Linux kernel v5.12 we dropped support[1] in KVM for hosts that can't have their threads running in different MMU modes (POWER9 < DD2.2). In these hosts, KVM will no longer report the KVM_CAP_PPC_MMU_HASH_V3 capability[2] when the host is running Radix. For guests that support both MM

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

On Tue, May 4, 2021 at 2:03 AM Aneesh Kumar K.V wrote: > > On 5/4/21 11:13 AM, Pankaj Gupta wrote: > > > >> > >> What this patch series did was to express that property via a device > >> tree node and guest driver enables a hypercall based flush mechanism to > >> ensure persistence. > > > > W

[PATCH 0/2] Fix for compat mode in P9 < 2.2

We dropped support in KVM for mixing MMU modes in machines that have old POWER9 processors which don't support mixing. As usual I forgot that compat mode exists: $ lscpu | grep pvr Model: 2.1 (pvr 004e 1201) $ ~/qemu-system-ppc64 -machine pseries,accel=kvm,max-cpu-compat=power

Re: [PATCH 1/3] hw/i2c: add support for PMBus

On Tue, 4 May 2021 at 16:30, Titus Rwantare wrote: > > QEMU has support for SMBus devices, and PMBus is a more specific > implementation of SMBus. The additions made in this commit makes it easier to > add new PMBus devices to QEMU. > > https://pmbus.org/specification-archives/ I'm not a pmbus ex

[PATCH v8 0/4] aarch64: add support for FEAT_TLBIRANGE and FEAT_TLBIOS

Improved readability and fixed a bug in tlb_flush_page_range_bits_by_mmuidx_async_0. Rebecca Cran (4): accel/tcg: Add TLB invalidation support for ranges of addresses target/arm: Add support for FEAT_TLBIRANGE target/arm: Add support for FEAT_TLBIOS target/arm: set ID_AA64ISAR0.TLB to 2 fo

[PATCH v8 2/4] target/arm: Add support for FEAT_TLBIRANGE

ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI maintenance instructions that apply to a range of input addresses. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 5 + target/arm/helper.c | 296 2 files changed, 301 insertions(+) diff --git a/target/arm/

[PATCH v8 3/4] target/arm: Add support for FEAT_TLBIOS

ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI maintenance instructions that extend to the Outer Shareable domain. Signed-off-by: Rebecca Cran --- target/arm/cpu.h| 5 ++ target/arm/helper.c | 75 2 files changed, 80 insertions(+) diff --git a/target/arm/cpu.

[PATCH v8 1/4] accel/tcg: Add TLB invalidation support for ranges of addresses

Add functions to support the FEAT_TLBIRANGE ARMv8.4 feature that adds TLB invalidation instructions to invalidate ranges of addresses. Signed-off-by: Rebecca Cran --- accel/tcg/cputlb.c | 128 +++- include/exec/exec-all.h | 46 +++ 2 files changed, 171 insertions(+), 3

[PATCH v8 4/4] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

Indicate support for FEAT_TLBIOS and FEAT_TLBIRANGE by setting ID_AA64ISAR0.TLB to 2 for the max AARCH64 CPU type. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index

Re: [PATCH 0/2] Fix for compat mode in P9 < 2.2

On Tue, May 04, 2021 at 09:11:28PM -0300, Fabiano Rosas wrote: > We dropped support in KVM for mixing MMU modes in machines that have > old POWER9 processors which don't support mixing. As usual I forgot > that compat mode exists: > > $ lscpu | grep pvr > Model: 2.1 (pvr 004e 120

Re: [PATCH v4 2/5] target/ppc: renamed SPR registration functions

On Tue, May 04, 2021 at 11:01:54AM -0300, Bruno Larsen (billionai) wrote: > Renamed all gen_spr_* and gen_* functions specifically related to > registering SPRs to register_*_sprs and register_*, to avoid future > confusion with other TCG related code. > > Signed-off-by: Bruno Larsen (billionai) >

Re: [PATCH v4 3/5] target/ppc: move SPR R/W callbacks to translate.c

On Tue, May 04, 2021 at 11:01:55AM -0300, Bruno Larsen (billionai) wrote: > Moved all read and write callbacks for SPRs away from > translate_init.c.inc and into translate.c; these functions are > TCG only, so this motion is required to enable building with > the flag disable-tcg > > Signed-off-by

Re: [PATCH v4 1/5] target/ppc: Fold gen_*_xer into their callers

On Tue, May 04, 2021 at 11:01:53AM -0300, Bruno Larsen (billionai) wrote: > folded gen_{read,write}_xer into their only callers, spr_{read,write}_xer > > Signed-off-by: Bruno Larsen (billionai) > Reviewed-by: Richard Henderson Good cleanup on its own. Applied to ppc-for-6.1. > --- > target/p

Re: [PATCH] target/ppc/spapr: Update H_GET_CPU_CHARACTERISTICS bits

On Tue, May 04, 2021 at 06:50:54PM +1000, Nicholas Piggin wrote: > Excerpts from David Gibson's message of May 4, 2021 10:41 am: > > On Mon, May 03, 2021 at 10:58:33PM +1000, Nicholas Piggin wrote: > >> There are several new bits added to the hcall which reflect new issues > >> found and new hardwa

Re: [RFC PATCH v2 2/2] hw/ppc: Moved TCG code to spapr_hcall_tcg

On Tue, May 04, 2021 at 03:14:17PM -0300, Lucas Mateus Martins Araujo e Castro wrote: > > On 03/05/2021 01:34, David Gibson wrote: > > On Fri, Apr 30, 2021 at 03:40:47PM -0300, Lucas Mateus Castro (alqotel) > > wrote: > > > Moved h_enter, remove_hpte, h_remove, h_bulk_remove,h_protect and > > >

Re: [RFC PATCH v2 0/2] hw/ppc: code motion to compile without TCG

On Mon, May 03, 2021 at 07:21:11PM -0300, Fabiano Rosas wrote: > "Lucas Mateus Castro (alqotel)" writes: > > > After the feedback from v1 I reworked the patch with suggested ideas and > > this version has less duplicated code and is overall simpler. > > > > This patch series is still a WIP, there

Re: [PATCH] target/ppc: Do not check for LPCR[HAIL] on power10_v1.0 CPUs

On Tue, May 04, 2021 at 01:54:39PM +0200, Cédric Le Goater wrote: > On 5/4/21 12:49 PM, Nicholas Piggin wrote: > > Excerpts from Cédric Le Goater's message of May 4, 2021 7:59 pm: > >> The LPCR[HAIL] bit only applies to POWER10 DD2 CPUs. On POWER10 DD1, > >> the ail value should be extracted using

[PATCH 2/7] vhost-user-gpu: fix resource leak in 'vg_resource_create_2d'

Call 'vugbm_buffer_destroy' in error path to avoid resource leak. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-user-gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index f73f292c9f..b5e153d0d

[PATCH 5/7] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref'

The 'res->iov' will be leaked if the guest trigger following sequences: virgl_cmd_create_resource_2d virgl_resource_attach_backing virgl_cmd_resource_unref This patch fixes this. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 7 +++ 1 file changed, 7 i

[PATCH 1/7] vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info

Otherwise some of the 'resp' will be leaked to guest. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c index 9e6660c7ab..6a332d601f 100644 --- a/contrib/vhost-user-gpu/vi

[PATCH 7/7] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset'

If 'virgl_cmd_get_capset' set 'max_size' to 0, the 'virgl_renderer_fill_caps' will write the data after the 'resp'. This patch avoid this by checking the returned 'max_size'. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 4 1 file changed, 4 insertions(+) diff --git a/contri

[PATCH 3/7] vhost-user-gpu: fix memory leak in vg_resource_attach_backing

Check whether the 'res' has already been attach_backing to avoid memory leak. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-user-gpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index b5e1

[PATCH 6/7] vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing'

If 'virgl_renderer_resource_attach_iov' failed, the 'res_iovs' will be leaked. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c index c669d73a1d..a16a

[PATCH 4/7] vhost-user-gpu: fix memory link while calling 'vg_resource_unref'

If the guest trigger following sequences, the attach_backing will be leaked: vg_resource_create_2d vg_resource_attach_backing vg_resource_unref This patch fix this by freeing 'res->iov' in vg_resource_destroy. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-use

  1   2   3   4   >