Hi Phil, It looks big but the bulk of it is simple switch statements and definitions. Unless you mean you'd like it split despite that.
Regards, Titus On Tue, 4 May 2021 at 16:49, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Hi Titus, > > On 5/4/21 6:28 PM, Titus Rwantare wrote: > > QEMU has support for SMBus devices, and PMBus is a more specific > > implementation of SMBus. The additions made in this commit makes it easier > > to > > add new PMBus devices to QEMU. > > > > https://pmbus.org/specification-archives/ > > > > Reviewed-by: Hao Wu <wuhao...@google.com> > > Signed-off-by: Titus Rwantare <tit...@google.com> > > --- > > hw/arm/Kconfig | 1 + > > hw/i2c/Kconfig | 4 + > > hw/i2c/meson.build | 1 + > > hw/i2c/pmbus_device.c | 1611 +++++++++++++++++++++++++++++++++ > > include/hw/i2c/pmbus_device.h | 520 +++++++++++ > > 5 files changed, 2137 insertions(+) > > TBH this is quite a big patch to digest. > > Any chance you could split it? > > Thanks, > > Phil.
