Re: [PATCH v3 03/15] docs/devel/testing: add debug section to the QEMU iotests chapter

On 30/04/21 13:23, Max Reitz wrote: +--- +QEMU iotests offers some options to debug a failing test, that can be +given as options to the ``check`` script: -, Even better: "The following options to the ``check`` script can be useful when debugging a failing test:". Pao

Re: [PATCH 3/3] hw/pcmcia: Do not register PCMCIA type if not required

Le 25/04/2021 à 00:20, Philippe Mathieu-Daudé a écrit : > If the Kconfig 'PCMCIA' value is not selected, it is pointless > to build the PCMCIA core components. > > (Currently only one machine of the ARM targets requires this). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pcmcia/meson.bu

[PATCH v2 06/13] target/arm: Move vfp_{load, store}_reg{32, 64} to translate-vfp.c.inc

The functions vfp_load_reg32(), vfp_load_reg64(), vfp_store_reg32() and vfp_store_reg64() are used only in translate-vfp.c.inc. Move them to that file. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/translate.c | 20 --

[PATCH v2 00/13] target/arm: Split translate-*.c.inc into separate compilation units

When we first converted the A32/T32 frontends to use decodetree, we put the trans* functions for VFP and Neon into their own separate files, but used the preprocessor to just #include those files into translate.c. This was a pragmatic arrangement to avoid having to also rearrange translate.c which

[PATCH v2 02/13] target/arm: Share unallocated_encoding() and gen_exception_insn()

The unallocated_encoding() function is the same in both translate-a64.c and translate.c; make the translate.c function global and drop the translate-a64.c version. To do this we need to also share gen_exception_insn(), which currently exists in two slightly different versions for A32 and A64: merg

[PATCH v2 07/13] target/arm: Make functions used by translate-vfp global

Make the remaining functions which are needed by translate-vfp.c.inc global. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2: made gen_set_cpsr and gen_set_condexec not inline at rth's suggestion --- target/arm/translate-a32.h | 18 +++

[PATCH v2 10/13] target/arm: Delete unused typedef

The VFPGenFixPointFn typedef is unused; delete it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 095b5c509e1..58cb3e8aafe 100644 --- a/target/arm/t

Re: [PATCH v3 25/30] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

On 4/30/21 4:23 AM, Luis Fernando Fujita Pires wrote: I think we should reconsider using the same .decode file for both 32- and 64-bit instructions, to avoid duplicating argument set definitions, and to keep the prefixed instructions close to their non-prefixed counterparts. varinsnwidth assumes

[PATCH v2 08/13] target/arm: Make translate-vfp.c.inc its own compilation unit

Switch translate-vfp.c.inc from being #included into translate.c to being its own compilation unit. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/translate-a32.h | 2 ++ target/arm/{translate-vfp.c.inc =

[PATCH v2 13/13] target/arm: Make translate-neon.c.inc its own compilation unit

Switch translate-neon.c.inc from being #included into translate.c to being its own compilation unit. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/arm/translate-a32.h | 3 +++ .../arm/{translate-neon.c.inc

Re: [PATCH v3 25/30] target/ppc: Move ADDI, ADDIS to decodetree, implement PADDI

On 4/30/21 7:05 AM, Matheus K. Ferst wrote: +ADDI    01 10 0--.-- .. \ +    001110 . . @PLS_D I'm not sure about this. It's a bit surprising to find ADDI here, and the comment that explains why is likely to be ignored aft

[PATCH v3 0/7] tests/acceptance: Handle tests with "cpu" tag

Currently the acceptance tests tagged with "machine" have the "-M TYPE" automatically added to the list of arguments of the QEMUMachine object. In other words, that option is passed to the launched QEMU. On this series it is implemented the same feature but instead for tests marked with "cpu". The

Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic

On 30/04/2021 01:25, Richard Henderson wrote: On 4/29/21 9:21 AM, Bruno Larsen (billionai) wrote: @@ -49,7 +54,12 @@ static inline void vscr_init(CPUPPCState *env, uint32_t val)   {   /* Altivec always uses round-to-nearest */   set_float_rounding_mode(float_round_nearest_even, &env->

[PATCH v3 4/7] tests/acceptance: Tagging tests with "cpu:VALUE"

The existing tests which are passing "-cpu VALUE" argument to the vm object are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to handle that automatically. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta --- tests/accep

Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

"Gustavo Noronha Silva" writes: > Hey, > > On Fri, Apr 30, 2021, at 7:58 AM, Markus Armbruster wrote: >> > I did not add a Since: here because I wasn't sure how that is handled. >> > Should I add something or is that taken care of at the time of release >> > somehow? >> >> You should add (sinc

[PATCH 1/2] [RESEND] sev: use explicit indices for mapping firmware error codes to strings

This can help lower any margin for error when making future additions to the list, especially if they're made out of order. While doing so, make capitalization of ASID consistent with its usage in the SEV firmware spec (Asid -> ASID). Signed-off-by: Connor Kuehl Reviewed-by: Philippe Mathieu-Dau

Re: [PATCH v3 3/4] hw/arm: sabrelite: Connect the Ethernet PHY at address 6

Hi, On Wed, Jan 06, 2021 at 02:35:03PM +0800, Bin Meng wrote: > From: Bin Meng > > At present, when booting U-Boot on QEMU sabrelite, we see: > > Net: Board Net Initialization Failed > No ethernet found. > > U-Boot scans PHY at address 4/5/6/7 (see board_eth_init() in the > U-Boot source

Re: [PATCH v2] Document qemu-img options data_file and data_file_raw

On 30.04.21 15:34, Connor Kuehl wrote: The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original wording

[PATCH] coverity-scan: list components, move model to scripts/coverity-scan

Place all files that can be useful to rebuild the Coverity configuration in scripts/coverity-scan: the existing model file, and the components setup. The Markdown syntax was tested with Pandoc (but in any case is meant more as a human-readable reference than as a part of documentation). Suggested

Re: [PATCH] coverity-scan: list components, move model to scripts/coverity-scan

On Fri, 30 Apr 2021 at 15:52, Paolo Bonzini wrote: > > Place all files that can be useful to rebuild the Coverity > configuration in scripts/coverity-scan: the existing model > file, and the components setup. > > The Markdown syntax was tested with Pandoc (but in any case > is meant more as a huma

[Bug 1843711] Re: qemu-xhci device should detect if libusb host supports streams

This is a suggestion that would really help anyone using trying to use xhci passthrough on a platform without streams. ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [PULL 00/39] Block layer patches

On Fri, 30 Apr 2021 at 11:51, Kevin Wolf wrote: > > The following changes since commit ccdf06c1db192152ac70a1dd974c624f566cb7d4: > > Open 6.1 development tree (2021-04-30 11:15:40 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for y

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

I agree with this implementation. Though WFI seems make no sense for a userspace program, we should not have assumption that the userspace program will not use this instruction. It seems ARM manual does not defined the implementation of function EnterLowPowerState(); However, before executing thi

[Bug 1828608] Re: Chardev websocket might not support pasting more than a few chars

The bug is still present. ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1828608 Title: Chardev websocket might not support pasting more than a

[PATCH v2] Fix typo in CFI build documentation

Signed-off-by: Serge Guelton Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/control-flow-integrity.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst index d89d707..e6b73a4 100644 --- a/do

Re: [PATCH v4 0/3] nvdimm: Enable sync-dax property for nvdimm

On Fri, Apr 30, 2021 at 02:27:18PM +1000, David Gibson wrote: > On Thu, Apr 29, 2021 at 10:02:23PM +0530, Aneesh Kumar K.V wrote: > > On 4/29/21 9:25 PM, Stefan Hajnoczi wrote: > > > On Wed, Apr 28, 2021 at 11:48:21PM -0400, Shivaprasad G Bhat wrote: > > > > The nvdimm devices are expected to ensur

[Bug 1926759] Re: WFI instruction results in unhandled CPU exception

We do implement those traps, but only in the system mode emulator, because it makes no sense to trap to EL2 in the usermode emulator where EL2 doesn't exist. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

[Bug 1926782] [NEW] configure script --extra-cflags not passed to config-meson.cross

Public bug reported: Since qemu 5.2, when building, the configure would not finish, but would return this error instead: qemu ../meson.build:852:2: ERROR: C header 'sasl/sasl.h' not found This is for a cross build, and I invoke qemu with the --extra-cflags and --extra-ldflags containing all t

Re: [PATCH v2 00/16] virtio-gpu: split into two devices.

Hi On Fri, Apr 30, 2021 at 4:23 PM Gerd Hoffmann wrote: > Currently we have one virtio-gpu device. Problem with this approach is > that if you compile a full-featured qemu you'll get a virtio-gpu device > which depends on opengl and virgl, so these dependencies must be > installed and the libra

Re: [PATCH v4 08/12] qtest/bios-tables-test: Make test build-independent from accelerator

Philippe Mathieu-Daudé writes: > Now than we can probe if the TCG accelerator is available > at runtime with a QMP command, do it once at the beginning > and only register the tests we can run. > We can then replace the #ifdef'ry by an assertion. > > Reviewed-by: Eric Blake > Signed-off-by: Ph

Re: [PATCH v2 05/13] target/arm: Move gen_aa32 functions to translate-a32.h

On 4/30/21 3:27 PM, Peter Maydell wrote: > Move the various gen_aa32* functions and macros out of translate.c > and into translate-a32.h. > > Signed-off-by: Peter Maydell > --- > target/arm/translate-a32.h | 53 ++ > target/arm/translate.c | 51 +++

Re: [PATCH v4 09/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64

Philippe Mathieu-Daudé writes: > We might have a s390x/ppc64 QEMU binary built without the KVM > accelerator (configured with --disable-kvm). > Checking for /dev/kvm accessibility isn't enough, also check for the > accelerator in the binary. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc

Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator

On 4/30/21 8:13 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: >> On 4/29/21 3:22 PM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >> Now than we can probe if the TCG accelerator is available >> at runtime with a QMP command, do it once at the beginning >

[PATCH v2] ui: Fix memory leak in qemu_xkeymap_mapping_table()

Refactor qemu_xkeymap_mapping_table() to have a single exit point, so we can easily free the memory allocated by XGetAtomName(). This fixes when running a binary configured with --enable-sanitizers: Direct leak of 22 byte(s) in 1 object(s) allocated from: #0 0x561344a7473f in malloc (qemu

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 05:51:16PM +0200, Kevin Wolf wrote: > Am 29.04.2021 um 16:05 hat Stefan Hajnoczi geschrieben: > > Hi, > > A preview release of libblkio, a library for high-performance block I/O, > > is now available: > > > > https://gitlab.com/libblkio/libblkio/-/tree/v0.1.0 > > > > App

Re: [PATCH v2 1/8] hw/intc: GICv3 ITS initial framework

Have taken care of it.please ignore PIDR2 changes in the current patchset ,will update the latest changes in the next patchset version Thanks Shashi On Apr 30 2021, at 6:09 am, Peter Maydell wrote: > On Fri, 30 Apr 2021 at 00:36, wrote: > > > > On Fri, 2021-04-16 at 18:21 +0100, Peter Maydell

Re: [PATCH 2/4] Do not include hw/boards.h if it's not really necessary

Le 16/04/2021 à 19:13, Thomas Huth a écrit : > Stop including hw/boards.h in files that don't need it. > > Signed-off-by: Thomas Huth > --- > accel/tcg/tcg-accel-ops-icount.c | 1 - > accel/tcg/tcg-accel-ops-rr.c | 1 - > accel/tcg/tcg-accel-ops.c| 1 - > hw/acpi/cpu.c

Re: [PATCH 3/4] Do not include cpu.h if it's not really necessary

Le 16/04/2021 à 19:13, Thomas Huth a écrit : > Stop including cpu.h in files that don't need it. > > Signed-off-by: Thomas Huth > --- > accel/stubs/kvm-stub.c| 1 - > accel/stubs/tcg-stub.c| 1 - > accel/tcg/cpu-exec-common.c | 1 - > accel/tcg/cpu-exec.c

Re: [PATCH 1/4] Do not include sysemu/sysemu.h if it's not really necessary

Le 16/04/2021 à 19:13, Thomas Huth a écrit : > Stop including sysemu/sysemu.h in files that don't need it. > > Signed-off-by: Thomas Huth > --- > accel/kvm/kvm-all.c | 1 - > accel/tcg/user-exec-stub.c | 1 - > backends/hostmem-file.c | 1 - > backends/hostmem-memfd.c | 1 - >

[Bug 1926782] Re: configure script --extra-cflags not passed to config-meson.cross

Here is my full invocation of the configure script: CFLAGS=" -isystem /home/anisse/dev/qemu-cross/build/usr/include" \ LDFLAGS="-Wl,--gc-sections -Wl,-Y/home/anisse/dev/qemu-cross/build/lib -Wl,-Y/home/anisse/dev/qemu-cross/build/usr/lib -Wl,-rpath-link,/home/anisse/dev/qemu-cross/build/lib -Wl

Re: [PATCH 4/4] Do not include exec/address-spaces.h if it's not really necessary

Le 16/04/2021 à 19:13, Thomas Huth a écrit : > Stop including exec/address-spaces.h in files that don't need it. > > Signed-off-by: Thomas Huth > --- > accel/kvm/kvm-all.c | 1 - > accel/tcg/cputlb.c| 1 - > hw/acpi/generic_event_device.c| 1 - > hw/acpi/ich9.c

[Bug 1926782] Re: configure script --extra-cflags not passed to config-meson.cross

Sorry, this is the "fixed" version, but you get the idea of how I invoke it. sasl.h is present in /home/anisse/dev/qemu-cross/build/usr/include/sasl/sasl.h ; this path is passed through -isystem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

[PATCH] Remove the deprecated moxie target

There are no known users of this CPU anymore, and there are no binaries available online which could be used for regression tests, so the code has likely completly bit-rotten already. It's been marked as deprecated since two releases now and nobody spoke up that there is still a need to keep it, th

Re: [PATCH v2] Fix typo in CFI build documentation

Le 30/04/2021 à 17:07, Serge Guelton a écrit : > Signed-off-by: Serge Guelton > Reviewed-by: Philippe Mathieu-Daudé > --- > docs/devel/control-flow-integrity.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/devel/control-flow-integrity.rst > b/docs/devel/co

Re: [PATCH] vmstate: Constify some VMStateDescriptions

Le 08/04/2021 à 16:07, Keqian Zhu a écrit : > Constify vmstate_ecc_state and vmstate_x86_cpu. > > Signed-off-by: Keqian Zhu > --- > hw/block/ecc.c | 2 +- > include/hw/block/flash.h | 2 +- > target/i386/cpu.h| 2 +- > target/i386/machine.c| 2 +- > 4 files changed, 4 inser

Re: [PATCH v2] ui: Fix memory leak in qemu_xkeymap_mapping_table()

Le 30/04/2021 à 17:50, Philippe Mathieu-Daudé a écrit : > Refactor qemu_xkeymap_mapping_table() to have a single exit point, > so we can easily free the memory allocated by XGetAtomName(). > > This fixes when running a binary configured with --enable-sanitizers: > > Direct leak of 22 byte(s) in

Re: [PATCH 1/3] hw/arm: Constify VMStateDescription

Le 13/03/2021 à 18:11, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/highbank.c | 2 +- > hw/arm/pxa2xx_pic.c | 2 +- > hw/arm/spitz.c | 4 ++-- > hw/arm/strongarm.c | 2 +- > hw/arm/z2.c | 4 ++-- > hw/dma/pxa2xx_dma.c | 4 ++-- > hw/misc

[Bug 1895895] Re: Attaching SD-Card to specific SD-Bus Sabrelite (ARM)

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/54 ** Changed in: qemu Status: In Progress => Expired ** Ch

Re: [ANNOUNCE] libblkio v0.1.0 preview release

On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote: > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote: > > > This is where I get confused about what this library actually does. > > > It's not jus

Re: [PATCH 2/3] hw/display/qxl: Constify VMStateDescription

Le 13/03/2021 à 18:11, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/qxl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index 93907e82a33..2ba75637ec3 100644 > --- a/hw/display

Re: [PATCH v2] ui: Fix memory leak in qemu_xkeymap_mapping_table()

Le 30/04/2021 à 17:50, Philippe Mathieu-Daudé a écrit : > Refactor qemu_xkeymap_mapping_table() to have a single exit point, > so we can easily free the memory allocated by XGetAtomName(). > > This fixes when running a binary configured with --enable-sanitizers: > > Direct leak of 22 byte(s) in

Re: [PATCH 3/3] hw/usb: Constify VMStateDescription

Le 13/03/2021 à 18:11, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/usb/ccid-card-passthru.c | 2 +- > hw/usb/dev-smartcard-reader.c | 8 > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/cci

[PATCH 3/4] block/vvfat: Fix leak of mapping_t::path

read_directory() keeps pointers to alloc'ed data in path ...: 743 static int read_directory(BDRVVVFATState* s, int mapping_index) 744 { ... 792 buffer = g_malloc(length); ... 828 /* create mapping for this file */ 829 if(!is_dot && !is_dotdot && (S_ISDIR(st.st_mode)

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

Le 27/03/2021 à 09:28, Thomas Huth a écrit : > Many files include hw/sysbus.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/cubieboard.c | 1 - > hw/arm/orangepi.c | 1 - > hw/char/riscv_htif.c| 1 - > hw/

Re: [PATCH v2 11/13] target/arm: Move NeonGenThreeOpEnvFn typedef to translate.h

On 4/30/21 3:27 PM, Peter Maydell wrote: > Move the NeonGenThreeOpEnvFn typedef to translate.h together > with the other similar typedefs. > > Signed-off-by: Peter Maydell > Reviewed-by: Richard Henderson > --- > target/arm/translate.h | 2 ++ > target/arm/translate.c | 3 --- > 2 files changed

[PATCH] target/arm: Make WFI a NOP for userspace emulators

The WFI insn is not system-mode only, though it doesn't usually make a huge amount of sense for userspace code to execute it. Currently if you try it in qemu-arm then the helper function will raise an EXCP_HLT exception, which is not covered by the switch in cpu_loop() and results in an abort: qe

[PATCH 1/4] block/vvfat: Fix leak of BDRVVVFATState::qcow_filename

qcow_filename is allocated in enable_write_target(), called by vvfat_open(), but never free'd. Free it in vvfat_close(). This fixes (QEMU built with --enable-sanitizers): Direct leak of 4096 byte(s) in 1 object(s) allocated from: #0 0x55d7a363773f in malloc (/mnt/scratch/qemu/sanitizer/q

Re: [PATCH v2 10/13] target/arm: Delete unused typedef

On 4/30/21 3:27 PM, Peter Maydell wrote: > The VFPGenFixPointFn typedef is unused; delete it. > > Signed-off-by: Peter Maydell > Reviewed-by: Richard Henderson > --- > target/arm/translate.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw: Do not include qemu/log.h if it is not necessary

Le 28/03/2021 à 07:48, Thomas Huth a écrit : > Many files include qemu/log.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/aspeed.c | 1 - > hw/arm/aspeed_ast2600.c | 1 - > hw/arm/aspeed_soc.c

[PATCH 0/4] block/vvfat: Fix leaks and out of bounds writes

The first 3 patches are trivial leak fixes, the last one is a RFC since I have no clue about this code. Johannes, you wrote this 18 years ago, do you still remember? =) Philippe Mathieu-Daudé (4): block/vvfat: Fix leak of BDRVVVFATState::qcow_filename block/vvfat: Fix leak of BDRVVVFATState::

Re: [PATCH] hw: Do not include hw/irq.h if it is not necessary

Le 27/03/2021 à 06:02, Thomas Huth a écrit : > Many files include hw/irq.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/msf2-soc.c | 1 - > hw/i386/kvm/ioapic.c| 1 - > hw/i386/xen/xen_platform.c | 1 - > hw/m68

[PATCH 4/4] block/vvfat: Avoid out of bounds write in create_long_filename()

The direntry_t::name holds 11 bytes: typedef struct direntry_t { uint8_t name[8 + 3]; ... However create_long_filename() writes up to 31 bytes into it: 421 for(i=0;i<26*number_of_entries;i++) { 422 int offset=(i%26); 423 if(offset<10) offset=1+offset; 424

[PULL 06/18] hw: Model ASPEED's Hash and Crypto Engine

From: Joel Stanley The HACE (Hash and Crypto Engine) is a device that offloads MD5, SHA1, SHA2, RSA and other cryptographic algorithms. This initial model implements a subset of the device's functionality; currently only MD5/SHA hashing, and on the ast2600's scatter gather engine. Co-developed-

[PATCH 2/4] block/vvfat: Fix leak of BDRVVVFATState::used_clusters

used_clusters is allocated in enable_write_target(), called by vvfat_open(), but never free'd. Allocate it using GLib API, and free it in vvfat_close(). This fixes (QEMU built with --enable-sanitizers): Direct leak of 64508 byte(s) in 1 object(s) allocated from: #0 0x55d7a36378f7 in callo

[PULL 00/18] aspeed queue

The following changes since commit 609d7596524ab204ccd71ef42c9eee4c7c338ea4: Update version for v6.0.0 release (2021-04-29 18:05:29 +0100) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20210430 for you to fetch changes up to

[PULL 09/18] tests/acceptance: Test ast2400 and ast2500 machines

From: Joel Stanley Test MTD images from the OpenBMC project on AST2400 and AST2500 SoCs from ASPEED, by booting Palmetto and Romulus BMC machines. The images are fetched from OpenBMC's release directory on github. Cc: Cleber Rosa Cc: Wainer dos Santos Moschetta Co-developed-by: Cédric Le Goat

Re: [PATCH v2 05/13] target/arm: Move gen_aa32 functions to translate-a32.h

On 4/30/21 6:27 AM, Peter Maydell wrote: Move the various gen_aa32* functions and macros out of translate.c and into translate-a32.h. Signed-off-by: Peter Maydell --- target/arm/translate-a32.h | 53 ++ target/arm/translate.c | 51 --

Re: [PATCH] hw: Remove superfluous includes of hw/hw.h

Le 26/03/2021 à 16:18, Thomas Huth a écrit : > The include/hw/hw.h header only has a prototype for hw_error(), > so it does not make sense to include this in files that do not > use this function. > > Signed-off-by: Thomas Huth > --- > hw/arm/musicpal.c | 1 - > hw/char/sifive_u

[PULL 08/18] tests/qtest: Add test for Aspeed HACE

From: Joel Stanley This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests the currently implemented behavior of the hash functionality. The tests are similar, but are cut/pasted instead of broken out into a common function so the assert machinery produces useful output when a te

[PULL 05/18] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

From: Philippe Mathieu-Daudé The flash mmio region is exposed as an AddressSpace. AddressSpaces must not be sysbus-mapped, therefore map the region using an alias. Signed-off-by: Philippe Mathieu-Daudé [ clg : Fix DMA_FLASH_ADDR() ] Signed-off-by: Cédric Le Goater Message-Id: <20210312182851.1

Re: [PATCH] Remove the deprecated moxie target

On Fri, 30 Apr 2021 at 17:18, Thomas Huth wrote: > > There are no known users of this CPU anymore, and there are no > binaries available online which could be used for regression tests, > so the code has likely completly bit-rotten already. It's been > marked as deprecated since two releases now a

Re: [PATCH v2 05/12] mc146818rtc: put it into the 'misc' category

Le 24/03/2021 à 18:23, Philippe Mathieu-Daudé a écrit : > On 12/21/20 12:53 PM, Thomas Huth wrote: >> On 30/11/2020 09.36, Gan Qixin wrote: >>> The category of the mc146818rtc device is not set, put it into the 'misc' >>> category. >>> >>> Signed-off-by: Gan Qixin >>> --- >>> Cc: Michael S. Tsirki

[PULL 03/18] aspeed/i2c: Fix DMA address mask

The RAM memory region is now used for DMAs accesses instead of the memory address space region. Mask off the top bits of the DMA address to reflect this change. Cc: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Message-Id: <20210407171637.43-4-...@kaod.org> Signed-off-by: Cédric Le

[PULL 02/18] aspeed/smc: Remove unused "sdram-base" property

Cc: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210407171637.43-3-...@kaod.org> Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 3 --- hw/arm/aspeed_ast2600.c | 4 hw/arm/aspeed_soc.c | 4

[Bug 1827005] Re: hvf: ubuntu iso boot menu issue

The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[PULL 04/18] aspeed/i2c: Rename DMA address space

It improves 'info mtree' output. Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210407171637.43-5-...@kaod.org> Signed-off-by: Cédric Le Goater --- hw/i2c/aspeed_i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2

[PULL 07/18] aspeed: Integrate HACE

From: Joel Stanley Add the hash and crypto engine model to the Aspeed socs. Reviewed-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Klaus Heinrich Kiwi Signed-off-by: Joel Stanley Message-Id: <20210409000253.1475587-3-j...@jms.id.au> Signed

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

Philippe Mathieu-Daudé writes: > From: Philippe Mathieu-Daudé > > The previous attempt (commit f77147cd4de) doesn't work as > expected, as we still have CONFIG_TCG=1 when using: > > configure --disable-system --disable-user > > Now than we have removed the use of CONFIG_TCG from target-depen

[PULL 01/18] aspeed/smc: Use the RAM memory region for DMAs

Instead of passing the memory address space region, simply use the RAM memory region instead. This simplifies RAM accesses. This patch breaks migration compatibility. Fixes: c4e1f0b48322 ("aspeed/smc: Add support for DMAs") Cc: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-o

[PATCH] xen-block: Use specific blockdev driver

From: Anthony PERARD ... when a xen-block backend instance is created via xenstore. Following 8d17adf34f50 ("block: remove support for using "file" driver with block/char devices"), using the "file" blockdev driver for everything doesn't work anymore, we need to use the "host_device" driver when

[PATCH] xen: Free xenforeignmemory_resource at exit

From: Anthony PERARD Because Coverity complains about it and this is one leak that Valgrind reports. Signed-off-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 9 ++--- include/hw/xen/xen_common.h | 6 ++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/i386/xen/

[Bug 1793635] Re: Using pflash with u-boot, when CONFIG_SYS_FLASH_USE_BUFFER_WRITE were defined, envirment args won't be able to save correctly

No update from the reporter after 5 months, so closing the bug. ** Changed in: qemu Assignee: Philippe Mathieu-Daudé (philmd) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/179363

Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons

Le 15/03/2021 à 10:43, Philippe Mathieu-Daudé a écrit : > On 3/15/21 5:55 AM, Taylor Simpson wrote: >> Address feedback from Richard Henderson < >> > > Reported-by: Richard Henderson > Reviewed-by: Philippe Mathieu-Daudé > >> Signed-off-by: Taylor Simpson >> --- >> target/hexagon/gen_tcg.h |

[PULL 11/18] hw/misc/aspeed_xdma: Add AST2600 support

When we introduced support for the AST2600 SoC, the XDMA controller was forgotten. It went unnoticed because it's not used under emulation. But the register layout being different, the reset procedure is bogus and this breaks kexec. Add a AspeedXDMAClass to take into account the register differenc

[Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/56 ** Changed in: qemu Status: Incomplete => Expired ** Cha

Re: [PATCH v1] scripts: fix generation update-binfmts templates

Le 23/03/2021 à 13:34, Silvano Cirujano Cuesta a écrit : > This patch fixes the update-binfmts templates being used in the script > scripts/qemu-binfmt-conf.sh when the option --debian is used. > > Fixed issues are: > - Typo in flag 'credentials' (previously 'credential'). > - Missing flags 'prese

Re: [PATCH] Hexagon (target/hexagon) fix typo in comment

Le 15/03/2021 à 10:28, Philippe Mathieu-Daudé a écrit : > On 3/15/21 5:55 AM, Taylor Simpson wrote: >> Signed-of-by: Taylor Simpson > > 'git-commit -s' flag add the S-o-b line automatically ;) > > Otherwise: > Reviewed-by: Philippe Mathieu-Daudé > >> --- >> target/hexagon/op_helper.c | 2 +- >

Re: [PATCH] baum: Fix crash when Braille output is not available

Le 10/03/2021 à 18:23, Thomas Huth a écrit : > On 10/03/2021 17.08, Samuel Thibault wrote: >> When Braille output is not available, the backend properly reports being >> unable to be created, but 5f8e93c3e262 ("util/qemu-timer: Make timer_free() >> imply timer_del()") made the timer_free() call now

[PULL 12/18] aspeed/smc: Add a 'features' attribute to the object class

It will simplify extensions of the SMC model. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Message-Id: <20210407171637.43-15-...@kaod.org> Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 2 +- hw/ssi/aspeed_smc.c | 44 +---

Re: [PATCH] net/slirp: Fix incorrect permissions on samba >= 2.0.5

CC: +Samuel Le 23/02/2021 à 03:41, Niklas Hambüchen a écrit : > As the added commend and `man smb.conf` explain, starting > with that samba version, `force user` must be configured > in `[global]` in order to access the configured `smb_dir`. > > This broke `-net user,smb=/path/to/folder`: > > Th

[Bug 1622582] Re: Can't install Windows 7 with q35 (SATA)

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/55 ** Changed in: qemu Status: Confirmed => Expired ** Chan

Re: [PULL 00/18] aspeed queue

oater/qemu/ tags/pull-aspeed-20210430 > > for you to fetch changes up to 1401dcd8aac9039797b995bfab078877a820c9c5: > > aspeed: Add support for the quanta-q7l1-bmc board (2021-04-30 10:30:42 > +0200) > > > As

[PULL 18/18] aspeed: Add support for the quanta-q7l1-bmc board

From: Patrick Venture The Quanta-Q71l BMC board is a board supported by OpenBMC. Tested: Booted quanta-q71l firmware. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Cédric Le Goater Message-Id: <20210416162426.3217033-1-vent...@google.com> Signed-off-by: Cédric Le Goater ---

[PULL 17/18] hw/block: m25p80: Add support for mt25ql02g and mt25qu02g

The Micron mt25ql02g is a 3V 2Gb serial NOR flash memory supporting dual I/O and quad I/O, 4KB, 32KB, 64KB sector erase. It also supports 4B opcodes. The mt25qu02g operates at 1.8V. https://4donline.ihs.com/images/VipMasterIC/IC/MICT/MICT-S-A0008500026/MICT-S-A0008511423-1.pdf?hkey=52A5661711E4

Re: [PATCH] net/slirp: Fix incorrect permissions on samba >= 2.0.5

Laurent Vivier, le ven. 30 avril 2021 18:48:29 +0200, a ecrit: > CC: +Samuel I don't know the smb code at all. > Le 23/02/2021 à 03:41, Niklas Hambüchen a écrit : > > As the added commend and `man smb.conf` explain, starting > > with that samba version, `force user` must be configured > > in `[gl

[Bug 1777315] Re: IDE short PRDT abort

This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/57 ** Changed in: qemu Status: In Progress => Expired ** Ch

[PULL 14/18] tests/qtest: Rename m25p80 test in aspeed_smc test

The m25p80 test depends on the Aspeed SMC controller to test our SPI-NOR flash support. Reflect this dependency by changing the name. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Message-Id: <20210407171637.43-17-...@kaod.org> Signed-off-by: Cédric Le Goater --- tests/qtest/{m

[PULL 15/18] aspeed: Deprecate the swift-bmc machine

The SWIFT machine never came out of the lab and we already have enough AST2500 based OpenPower machines. Cc: Adriana Kobylak Signed-off-by: Cédric Le Goater --- docs/system/deprecated.rst | 7 +++ hw/arm/aspeed.c| 3 +++ 2 files changed, 10 insertions(+) diff --git a/docs/syste

Re: [PATCH] baum: Fix crash when Braille output is not available

Le 30/04/2021 à 19:01, Laurent Vivier a écrit : > Le 10/03/2021 à 18:23, Thomas Huth a écrit : >> On 10/03/2021 17.08, Samuel Thibault wrote: >>> When Braille output is not available, the backend properly reports being >>> unable to be created, but 5f8e93c3e262 ("util/qemu-timer: Make timer_free()

[PULL 10/18] tests/acceptance: Test ast2600 machine

From: Joel Stanley This tests a Debian multi-soc arm32 Linux kernel on the AST2600 based Tacoma BMC machine. There is no root file system so the test terminates when boot reaches the stage where it attempts and fails to mount something. Cc: Cleber Rosa Cc: Wainer dos Santos Moschetta Signed-o

<    1   2   3   4   5   6   >