Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

On 4/28/21 5:06 PM, Peter Maydell wrote: > On Wed, 28 Apr 2021 at 15:55, Philippe Mathieu-Daudé > wrote: > > (cc'ing Paolo for a meson.build question below...) > >> When not explicitly select a sysemu target and building virtiofsd, >> the seccomp/cap-ng libraries are not resolved, leading to th

Re: [PATCH v2 15/15] target/ppc: Check cpu flags for prefixed insn support

On 4/27/21 10:16 AM, Luis Pires wrote: Prefixed instructions were introduced in Power ISA 3.1 Signed-off-by: Luis Pires --- target/ppc/translate.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 7422ea4e13..f4802a

Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

On 4/28/21 1:45 AM, Dr. David Alan Gilbert wrote: > * Dongli Zhang (dongli.zh...@oracle.com) wrote: >> Hi Jason, >> >> On 4/27/21 7:31 PM, Jason Wang wrote: >>> >>> 在 2021/4/27 下午4:53, Dr. David Alan Gilbert 写道: * Dongli Zhang (dongli.zh...@oracle.com) wrote: > > On 4/22/21 11:01 PM

RE: [PATCH v3 09/12] target/hexagon: import lexer for idef-parser

>From: Paolo Montesel >Sent: Wednesday, April 28, 2021 5:41 AM >To: Taylor Simpson >Cc: Alessandro Di Federico ; qemu-devel@nongnu.org; Brian >Cain ; ni...@rev.ng; >phi...@redhat.com; >richard.hender...@linaro.org; Alessandro Di Federico >Subject: Re: [PATCH v3 09/12] target/hexagon: import

Re: [PATCH v4 00/36] block: update graph permissions update

Patchew URL: https://patchew.org/QEMU/20210428151804.439460-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428151804.439460-1-vsement...@virtuozzo.com Subject: [PATCH v4 00/36] block: u

Re: [PATCH] accel: kvm: clarify that extra exit data is hexadecimal

On 4/28/21 4:24 PM, David Edmondson wrote: > When dumping the extra exit data provided by KVM, make it clear that > the data is hexadecimal. > > At the same time, zero-pad the output. > > Signed-off-by: David Edmondson > --- > accel/kvm/kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 1/7] stubs: Restrict fw_cfg stubs to sysemu

On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > User emulation or tools don't use / require the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > stubs/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/stubs/meson.build b/stubs/meson.build >

Re: [PATCH 4/7] hw/acpi/vmgenid: Make ACPI_VMGENID depends on FW_CFG Kconfig

On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > The TYPE_VMGENID device depends on fw_cfg: > > $ git grep \ fw_cfg hw/acpi/vmgenid.c > hw/acpi/vmgenid.c:128:fw_cfg_add_file(s, VMGENID_GUID_FW_CFG_FILE, > guid->data, > hw/acpi/vmgenid.c:131:fw_cfg_add_file_callback(s, > VMGENID_A

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

On Tue, Apr 27, 2021 at 04:48:48PM -0400, Eduardo Habkost wrote: > On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > > It is not safe to pretend that emulated NVDIMM supports > > persistence while backend actually failed to enable it > > and used non-persistent mapping as fall back.

Re: [PATCH] cirrus.yml: Fix the MSYS2 task

Thomas Huth writes: > The MSYS2 task in the Cirrus-CI is currently failing with error messages > like this: > > warning: database file for 'ucrt64' does not exist (use '-Sy' to download) > :: Starting core system upgrade... > there is nothing to do > :: Starting full system upgrade... > e

Re: [PATCH 5/7] hw: Have machines Kconfig-select FW_CFG

On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > Beside the loongson3-virt machine (MIPS), the following machines > also use the fw_cfg device: > > - ARM: virt & sbsa-ref > - HPPA: generic machine > - X86: ACPI based (pc & microvm) It's correct, but the way this is formulated is confusing, for

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: seccomp = not_found -if not get_option('seccomp').auto() or have_system or have_tools +if not get_option('seccomp').auto() or have_system or have_tools or not get_option('virtiofsd').auto() seccomp = dependency('libseccomp', version: '>=2.3

Re: [PATCH v6 00/15] RAM_NORESERVE, MAP_NORESERVE and hostmem "reserve" property

On Fri, Apr 23, 2021 at 12:35:35PM +0200, David Hildenbrand wrote: > On 21.04.21 23:06, Eduardo Habkost wrote: > > On Wed, Apr 21, 2021 at 02:26:09PM +0200, David Hildenbrand wrote: > > > Based-on: 20210406080126.24010-1-da...@redhat.com > > > > > > Some cleanups previously sent in other context (

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

Alex, Richard, do you mind reviewing this one please? On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The previous attempt (commit f77147cd4de) doesn't work as > expected, as we still have CONFIG_TCG=1 when using: > > configure --disable-system --disable-u

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: diff --git a/util/meson.build b/util/meson.build index 510765cde46..c2eda2d1374 100644 --- a/util/meson.build +++ b/util/meson.build @@ -59,12 +59,10 @@ util_ss.add(files('aiocb.c', 'async.c', 'aio-wait.c')) util_ss.add(files('base64.c'))

Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator

Hi Thomas, Markus, do you mind reviewing this one please? On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote: > Now than we can probe if the TCG accelerator is available > at runtime with a QMP command, do it once at the beginning > and only register the tests we can run. > We can then replace the #

Re: [PATCH 6/7] hw/{arm,hppa,riscv}: Add fw_cfg arch-specific stub

On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > The ARM, HPPA and RISC-V architectures don't declare any fw_cfg > specific key. To simplify the buildsys machinery and allow building > QEMU without the fw_cfg device (in the next commit), first add a > per-architecture empty stub defining the fw_c

[PATCH v7 1/7] net/tap: Added TUNSETSTEERINGEBPF code.

Additional code that will be used for eBPF setting steering routine. Signed-off-by: Andrew Melnychenko --- net/tap-linux.h | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d100fc..1d06fe0de6 100644 --- a/net/tap-linux.h +++ b/net/tap-linux.h @@ -31,

[PATCH v7 0/7] eBPF RSS support for virtio-net.

This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage of RSS with vhost The eBPF works on kernels 5.

[PATCH v7 5/7] virtio-net: Added eBPF RSS to virtio-net.

When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or when hash population request

[PATCH v7 2/7] net: Added SetSteeringEBPF method for NetClientState.

For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-solaris.c | 5 + net/tap-stub.c| 5 + net/tap.c

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

Given what you've shown with the use-after-free, I agree the changes need to be reverted. I'm a little uneasy about removing the reconnect logic from the device realization completely though. On Thu, Apr 22, 2021 at 07:02:17PM +0200, Kevin Wolf wrote: > This is a partial revert of commits 77542d43

[PATCH v7 3/7] ebpf: Added eBPF RSS program.

RSS program and Makefile to build it. The bpftool used to generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to regenerate rss.bpf.skeleton.h. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew

[PATCH v7 6/7] docs: Added eBPF documentation.

Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- docs/devel/ebpf_rss.rst | 125 docs/devel/index.rst| 1 + 2 files changed, 126 insertions(+) create mode 100644 docs/devel/ebpf_rss.rst diff --git a/docs/devel/ebpf_rss.rst b/do

[PATCH v7 7/7] MAINTAINERS: Added eBPF maintainers information.

Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36055f14c5..c7e9a57cd9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3312,6 +3312,14 @@ F: include/hw/remote/proxy-memory

[PATCH v7 4/7] ebpf: Added eBPF RSS loader.

Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-off-by: Yuri Benditovich S

Re: [PATCH v4 00/36] block: update graph permissions update

Am 28.04.2021 um 17:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > And here is v4. Thanks, applied to the block branch. Though the error message shown by the test in patch 18 does need some improvement on top. We should probably name both conflicting users and who blocks whom in

[PATCH v4 01/30] target/mips: Simplify meson TCG rules

We already have the mips_tcg_ss source set for TCG-specific files, use it for mxu_translate.c and tx79_translate.c to simplify a bit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH v4 03/30] target/mips: Move msa_reset() to new source file

mips_cpu_reset() is used by all accelerators, and calls msa_reset(), which is defined in msa_helper.c. Beside msa_reset(), the rest of msa_helper.c is only useful to the TCG accelerator. To be able to restrict this helper file to TCG, we need to move msa_reset() out of it. Reviewed-by: Richard He

[PATCH v4 00/30] target/mips: Re-org to allow KVM-only builds

TL;DR: This series restrict TCG-specific objects by moving them to the tcg/ subdir. Code is moved around to satisfy 3 cases: { generic sysemu / tcg sysemu / tcg user}. Missing review: 8 Since v3: - Addressed Richard's v2 comments Since v2: - Merge do_translate_address into cpu_mips_translate_ad

[PATCH v4 10/30] target/mips: Extract load/store helpers to ldst_helper.c

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/ldst_helper.c | 288 ++ target/mips/op_helper.c | 259 -- target/mips/meson.build | 1 + 3 files changed, 289 insertions(+), 259 deletion

Re: [PATCH 0/2] virtiofsd: Meson build fixes

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 28 Apr 2021 at 15:53, Philippe Mathieu-Daudé > wrote: > > > > A pair of fixes to allow building virtiofsd without sysemu/tools. > > > > Should this configuration be tested in CI? > > Does the configuration make sense to support? I thoug

[PATCH v4 05/30] target/mips: Optimize CPU/FPU regnames[] arrays

Since all entries are no more than 4 bytes (including nul terminator), can save space and pie runtime relocations by declaring regnames[] as array of 4 const char. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h |

[PATCH v4 06/30] target/mips: Restrict mips_cpu_dump_state() to cpu.c

As mips_cpu_dump_state() is only used once to initialize the CPUClass::dump_state handler, we can move it to cpu.c to keep it symbol local. Beside, this handler is used by all accelerators, while the translate.c file targets TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud

[PATCH v4 17/30] target/mips: Move physical addressing code to sysemu/physaddr.c

Declare get_physical_address() with local scope and move it along with mips_cpu_get_phys_page_debug() to sysemu/physaddr.c new file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 25 +++- target/mips/sysemu/physaddr.c | 257 +

[PATCH v4 02/30] target/mips: Move IEEE rounding mode array to new source file

restore_msa_fp_status() is declared inlined in fpu_helper.h, and uses the ieee_rm[] array. Therefore any code calling restore_msa_fp_status() must have access to this ieee_rm[] array. kvm_mips_get_fpu_registers(), which is in target/mips/kvm.c, calls restore_msa_fp_status. Except this tiny array,

[PATCH v4 09/30] target/mips: Merge do_translate_address into cpu_mips_translate_address

Currently cpu_mips_translate_address() calls raise_mmu_exception(), and do_translate_address() calls cpu_loop_exit_restore(). This API split is dangerous, we could call cpu_mips_translate_address without returning to the main loop. As there is only one caller, it is trivial (and safer) to merge d

[PATCH v4 07/30] target/mips: Turn printfpr() macro into a proper function

Turn printfpr() macro into a proper function: fpu_dump_fpr(). Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v4: int -> bool is_fpu64 (rth) --- target/mips/cpu.c | 50 ++- 1 file changed, 23 i

[PATCH v4 04/30] target/mips: Make CPU/FPU regnames[] arrays global

The CPU/FPU regnames[] arrays is used in mips_tcg_init() and mips_cpu_dump_state(), which while being in translate.c is not specific to TCG. To be able to move mips_cpu_dump_state() to cpu.c, which is compiled for all accelerator, we need to make the regnames[] arrays global to target/mips/ by dec

[PATCH v4 18/30] target/mips: Restrict cpu_mips_get_random() / update_pagemask() to TCG

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 4 target/mips/tcg/tcg-internal.h | 9 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index be32102a2ac..6bac8e

[PATCH v4 13/30] target/mips: Add simple user-mode mips_cpu_do_interrupt()

The #ifdef'ry hides that the user-mode implementation of mips_cpu_do_interrupt() simply sets exception_index = EXCP_NONE. Add this simple implementation to tcg/user/tlb_helper.c, and the corresponding Meson machinery to build this file when user emulation is configured. Reviewed-by: Richard Hende

[PATCH v4 08/30] target/mips: Declare mips_env_set_pc() inlined in "internal.h"

Rename set_pc() as mips_env_set_pc(), declare it inlined and use it in cpu.c and op_helper.c. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v4: mips_cpu_set_error_pc -> mips_env_set_pc (rth) --- target/mips/internal.h | 10 ++ target/mips/cpu.c | 8 +--

[PATCH v4 11/30] meson: Introduce meson_user_arch source set for arch-specific user-mode

Similarly to the 'target_softmmu_arch' source set which allows to restrict target-specific sources to system emulation, add the equivalent 'target_user_arch' set for user emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 6 ++ 1 file changed,

[PATCH v4 22/30] target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope

The 3 map_address() handlers are local to tlb_helper.c, no need to have their prototype declared publically. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 6 -- target/mips/tcg/sysemu/tlb_helper.c | 13 +++-- 2 files

[PATCH v4 16/30] target/mips: Move sysemu specific files under sysemu/ subfolder

Move sysemu-specific files under the new sysemu/ subfolder and adapt the Meson machinery. Update the KVM MIPS entry in MAINTAINERS. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/{ => sysemu}/addr.c | 0 target/mips/{ => sysemu}/cp0_timer.c | 0 targ

[PATCH v4 15/30] target/mips: Move cpu_signal_handler definition around

We have 2 blocks guarded with #ifdef for sysemu, which are simply separated by the cpu_signal_handler definition. To simplify the following commits which involve various changes in internal.h, first join the sysemu-guarded blocks. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Da

[PATCH v4 12/30] target/mips: Introduce tcg-internal.h for TCG specific declarations

We will gradually move TCG-specific declarations to a new local header: "tcg-internal.h". To keep review simple, first add this header with 2 TCG prototypes, which we are going to move in the next 2 commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/in

[PATCH v4 27/30] target/mips: Move CP0 helpers to sysemu/cp0.c

Opcodes accessing Coprocessor 0 are privileged. Move the CP0 helpers to sysemu/ and simplify the #ifdef'ry. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 9 +-- target/mips/cpu.c | 103 --- target

[PATCH v4 24/30] target/mips: Move helper_cache() to tcg/sysemu/special_helper.c

Move helper_cache() to tcg/sysemu/special_helper.c. The CACHE opcode is privileged and is not accessible in user emulation. However we get a link failure when restricting the symbol to sysemu. For now, add a stub helper to satisfy linking, which abort if ever called. Reviewed-by: Richard Henderso

[PATCH v4 20/30] target/mips: Restrict mmu_init() to TCG

mmu_init() is only required by TCG accelerator. Restrict its declaration and call to TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 3 --- target/mips/tcg/tcg-internal.h | 2 ++ target/mips/cpu.c | 2 +- 3 files change

[PATCH v4 14/30] target/mips: Add simple user-mode mips_cpu_tlb_fill()

tlb_helper.c's #ifdef'ry hides a quite simple user-mode implementation of mips_cpu_tlb_fill(). Copy the user-mode implementation (without #ifdef'ry) to tcg/user/helper.c and simplify tlb_helper.c's #ifdef'ry. This will allow us to restrict tlb_helper.c to sysemu. Reviewed-by: Richard Henderson

[PATCH v4 21/30] target/mips: Move tlb_helper.c to tcg/sysemu/

Move tlb_helper.c to the tcg/sysemu/ subdir, along with the following 3 declarations to tcg-internal.h: - cpu_mips_tlb_flush() - cpu_mips_translate_address() - r4k_invalidate_tlb() Simplify tlb_helper.c #ifdef'ry because files in tcg/sysemu/ are only build when sysemu mode is configured. Reviewed

[PATCH v4 19/30] target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder

Move cp0_helper.c and mips-semi.c to the new tcg/sysemu/ folder, adapting the Meson machinery. Move the opcode definitions to tcg/sysemu_helper.h.inc. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.h | 166 +

[PATCH v4 30/30] gitlab-ci: Add KVM mips64el cross-build jobs

Add a new job to cross-build the mips64el target without the TCG accelerator (IOW: only KVM accelerator enabled). Only build the mips64el target which is known to work and has users. Reviewed-by: Richard Henderson Acked-by: Thomas Huth Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Math

Re: [PATCH 6/7] hw/{arm,hppa,riscv}: Add fw_cfg arch-specific stub

On 4/28/21 6:44 PM, Laszlo Ersek wrote: > On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: >> The ARM, HPPA and RISC-V architectures don't declare any fw_cfg >> specific key. To simplify the buildsys machinery and allow building >> QEMU without the fw_cfg device (in the next commit), first add a >>

[PATCH v4 28/30] target/mips: Move TCG source files under tcg/ sub directory

To ease maintenance, move all TCG specific files under the tcg/ sub-directory. Adapt the Meson machinery. The following prototypes: - mips_tcg_init() - mips_cpu_do_unaligned_access() - mips_cpu_do_transaction_failed() can now be restricted to the "tcg-internal.h" header. Reviewed-by: Richard Hend

[PATCH v4 23/30] target/mips: Move Special opcodes to tcg/sysemu/special_helper.c

Move the Special opcodes helpers to tcg/sysemu/special_helper.c. Since mips_io_recompile_replay_branch() is set as CPUClass::io_recompile_replay_branch handler in cpu.c, we need to declare its prototype in "tcg-internal.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --

Re: [PATCH v4 00/30] target/mips: Re-org to allow KVM-only builds

Patchew URL: https://patchew.org/QEMU/20210428170410.479308-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428170410.479308-1-f4...@amsat.org Subject: [PATCH v4 00/30] target/mips: Re-org to allo

Re: [PATCH v11 2/6] arm64: kvm: Introduce MTE VM feature

On Fri, Apr 16, 2021 at 04:43:05PM +0100, Steven Price wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 77cb2d28f2a4..5f8e165ea053 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -879,6 +879,26 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, > phy

[PATCH v4 25/30] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c

Move TLB management helpers to tcg/sysemu/tlb_helper.c. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.h| 10 - target/mips/internal.h | 7 - target/mips/tcg/sysemu_helper.h.inc | 9 + target/mips/op_helper.c

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

On 4/28/21 7:06 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> Alex, Richard, do you mind reviewing this one please? > > Isn't it already merged (with my r-b tag no less ;-) > > f77147cd4de8c726f89b2702f7a9d0c9711d8875 See ... > Author: Philippe Mathieu-Daudé > Author

Re: [PATCH v2] vfio-ccw: Attempt to clean up all IRQs on error

On Wed, 28 Apr 2021 16:36:52 +0200 Eric Farman wrote: > The vfio_ccw_unrealize() routine makes an unconditional attempt to > unregister every IRQ notifier, though they may not have been registered > in the first place (when running on an older kernel, for example). > > Let's mirror this behavior

[PATCH v4 26/30] target/mips: Move exception management code to exception.c

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 13 --- target/mips/tcg/tcg-internal.h | 14 +++ target/mips/cpu.c | 113 -- target/mips/exception.c| 167 + target

Re: [PATCH v2 1/7] tests/acceptance: Automatic set -cpu to the test vm

Hi, On 4/21/21 5:16 PM, Cleber Rosa wrote: On Thu, Apr 08, 2021 at 04:52:31PM -0300, Wainer dos Santos Moschetta wrote: This introduces a new feature to the functional tests: automatic setting of the '-cpu VALUE' option to the created vm if the test is tagged with 'cpu:VALUE'. The 'cpu' propert

Re: [PATCH v7 0/7] eBPF RSS support for virtio-net.

Patchew URL: https://patchew.org/QEMU/20210428164733.56547-1-and...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210428164733.56547-1-and...@daynix.com Subject: [PATCH v7 0/7] eBPF RSS support for virtio

[PATCH v4 29/30] hw/mips: Restrict non-virtualized machines to TCG

Only the malta and loongson3-virt machines support KVM. Restrict the other machines to TCG: - mipssim - magnum - pica61 - fuloong2e - boston Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/meson.build | 11 +++ 1 file changed, 7 insertions(+), 4 d

Re: [PATCH] tests/migration: fix unix socket migration

Cleber, Maybe you could review then queue this one? - Wainer On 4/20/21 10:16 PM, Hyman Huang wrote: 在 2021/3/10 0:55, Philippe Mathieu-Daudé 写道: On 3/9/21 5:00 PM, huang...@chinatelecom.cn wrote: From: Hyman The test aborts and error message as the following be throwed: "No such file or

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

Philippe Mathieu-Daudé writes: > Alex, Richard, do you mind reviewing this one please? Isn't it already merged (with my r-b tag no less ;-) f77147cd4de8c726f89b2702f7a9d0c9711d8875 Author: Philippe Mathieu-Daudé AuthorDate: Fri Jan 22 21:44:31 2021 +0100 Commit: Paolo Bonzini

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

Am 28.04.2021 um 18:52 hat Raphael Norwitz geschrieben: > Given what you've shown with the use-after-free, I agree the changes > need to be reverted. I'm a little uneasy about removing the reconnect > logic from the device realization completely though. > > On Thu, Apr 22, 2021 at 07:02:17PM +0200

Re: [PATCH 7/7] hw/nvram: Do not build FW_CFG if not required

On 4/26/21 9:35 PM, Philippe Mathieu-Daudé wrote: > If the Kconfig 'FW_CFG' symbol is not selected, it is pointless > to build the fw_cfg device. Update the stubs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > stubs/fw_cfg.c | 49 ++-- > hw/nvram

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

On 4/28/21 6:38 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >> diff --git a/util/meson.build b/util/meson.build >> index 510765cde46..c2eda2d1374 100644 >> --- a/util/meson.build >> +++ b/util/meson.build >> @@ -59,12 +59,10 @@ >>     util_ss.add(files('aiocb.c'

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

On 4/28/21 6:34 PM, Richard Henderson wrote: > On 4/28/21 7:48 AM, Philippe Mathieu-Daudé wrote: >>   seccomp = not_found >> -if not get_option('seccomp').auto() or have_system or have_tools >> +if not get_option('seccomp').auto() or have_system or have_tools or >> not get_option('virtiofsd').auto(

Re: [PATCH 2/5] vhost-user-blk: Use Error more consistently

Code looks ok - question about the commit message. Acked-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:18PM +0200, Kevin Wolf wrote: > Now that vhost_user_blk_connect() is not called from an event handler > any more, but directly from vhost_user_blk_device_realize(), we don't > have to resor

Re: [RFC] AVR watchdog

Hi Fred. How can I reproduce it? Thank you. Michael Rolnik Sent from my cell phone, please ignore typos On Wed, Apr 28, 2021, 5:17 PM Fred Konrad wrote: > Hi, > > I fall on a segfault while running the wdr instruction on AVR: > > (gdb) bt > #0 0xadd0b23a in gdb_get_cpu_pid (cpu=

Re: [PATCH 1/5] vhost-user-blk: Don't reconnect during initialisation

On Wed, Apr 28, 2021 at 07:31:13PM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 18:52 hat Raphael Norwitz geschrieben: > > Given what you've shown with the use-after-free, I agree the changes > > need to be reverted. I'm a little uneasy about removing the reconnect > > logic from the device realizat

Re: [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled

On Wed, 28 Apr 2021 at 19:02, Philippe Mathieu-Daudé wrote: > On 4/28/21 6:34 PM, Richard Henderson wrote: > > I think the test should have been > > > > if (have_system or have_tools) and > > Yes but virtiofsd is not a tool... It is a standalone binary. This is not a distinction that our build/

Re: [RFC] AVR watchdog

Le 4/28/21 à 8:17 PM, Michael Rolnik a écrit : Hi Fred. How can I reproduce it? Thank you. Michael Rolnik Hi Michael, First sorry for the patchew noise, I didn't meant to sent a patch just an inlined diff. For the reproducer, that's pretty straight-forward with v6.0.0-rc5: $ cat > foo.S

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

On Wed, Apr 28, 2021 at 04:18:17PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Apr 27, 2021 at 02:02:27PM -0400, John Snow wrote: > >> On 4/27/21 1:54 PM, Philippe Mathieu-Daudé wrote: > >> > On 4/27/21 7:16 PM, John Snow wrote: > >> > > On 4/27/21 9:54 AM, Stefan Hajn

Re: [PATCH 3/5] vhost-user-blk: Get more feature flags from vhost devicey

Acked-by: Raphael Norwitz On Thu, Apr 22, 2021 at 07:02:19PM +0200, Kevin Wolf wrote: > VIRTIO_F_RING_PACKED and VIRTIO_F_IOMMU_PLATFORM need to be supported by > the vhost device, otherwise advertising it to the guest doesn't result > in a working configuration. They are currently not supported

Re: [PATCH 5/7] hw: Have machines Kconfig-select FW_CFG

On Mon, Apr 26, 2021 at 09:35:18PM +0200, Philippe Mathieu-Daudé wrote: > Beside the loongson3-virt machine (MIPS), the following machines > also use the fw_cfg device: > > - ARM: virt & sbsa-ref > - HPPA: generic machine > - X86: ACPI based (pc & microvm) > - PPC64: various > - SPARC: sun4m & sun

Re: [PATCH] i386: Document when features can be added to kvm_default_props

On Fri, Sep 25, 2020 at 05:10:21PM -0400, Eduardo Habkost wrote: > It's very easy to mistakenly extend kvm_default_props to include > features that require a kernel version that's too recent. Add a > comment warning about that, pointing to the documentation file > where the minimum kernel version

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

Philippe Mathieu-Daudé writes: > On 4/28/21 7:06 PM, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> Alex, Richard, do you mind reviewing this one please? >> >> Isn't it already merged (with my r-b tag no less ;-) >> >> f77147cd4de8c726f89b2702f7a9d0c9711d8875 > > See ... > >>

Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

On 4/28/21 9:04 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> On 4/28/21 7:06 PM, Alex Bennée wrote: >>> Philippe Mathieu-Daudé writes: >>> Alex, Richard, do you mind reviewing this one please? >>> >>> Isn't it already merged (with my r-b tag no less ;-) >>> >>> f77147cd

[PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

According to the as documentation: (https://sourceware.org/binutils/docs-2.36/as/AVR-Options.html) "Instruction set avr51 is for the enhanced AVR core with exactly 128K program memory space (MCU types: atmega128, atmega128a, atmega1280, atmega1281, atmega1284, atmega1284p, atmega128rfa1, atmega

Re: [PATCH] hw/avr/atmega.c: use the avr51 cpu for atmega1280

Cc'ing Joaquín. On 4/28/21 9:15 PM, Frederic Konrad wrote: > According to the as documentation: > (https://sourceware.org/binutils/docs-2.36/as/AVR-Options.html) > > "Instruction set avr51 is for the enhanced AVR core with exactly 128K > program memory space (MCU types: atmega128, atmega128a, a

Re: [PATCH] make vfio and DAX cache work together

* Dev Audsin (dev.devaq...@gmail.com) wrote: > Thanks Dave for your explanation. > Any suggestions on how to make VFIO not attempt to map into the > unaccessible and unallocated RAM. I'm not sure;: static bool vfio_listener_skipped_section(MemoryRegionSection *section) { return (!memory_regio

Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd

On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote: Are you suggesting to remove the 'if have_block' check? This makes build a the files pointlessly for user-mode-only builds... But since the objects are not included in the binary, I don't care. The build system is already too complex, and buil

Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > Commit 2943b53f6 (' virtio: force VIRTIO_F_IOMMU_PLATFORM') made sure > that vhost can't just reject VIRTIO_F_IOMMU_PLATFORM when it was > requested. However, just adding it back to the negotiated flags isn't > right either because it pr

Re: [PATCH v4] target/ppc: code motion from translate_init.c.inc to gdbstub.c

This is a test. Please disregard

[PATCH v2 01/15] linux-user/s390x: Fix sigframe types

Noticed via gitlab clang-user job: TESTsignals on s390x ../linux-user/s390x/signal.c:258:9: runtime error: \ 1.84467e+19 is outside the range of representable values of \ type 'unsigned long' Which points to the fact that we were performing a double-to-uint64_t conversion while storing

[PATCH v2 06/15] linux-user/s390x: Fix sigcontext sregs value

Using the host address of &frame->sregs is incorrect. We need the guest address. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index dcc6f7bc02..f8515dd332 1

[PATCH v2 12/15] linux-user/s390x: Fix frame_addr corruption in setup_frame

The original value of frame_addr is still required for its use in the call to unlock_user_struct below. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index b

[PATCH v2 02/15] linux-user/s390x: Use uint16_t for signal retcode

Using the right type simplifies the frame setup. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 707fb603d7..fece8ab97b 100644 --- a/linux-user/

[PATCH v2 14/15] linux-user/s390x: Clean up signal.c

Reorder the function bodies to correspond to the kernel source. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 67 --- 1 file changed, 41 insertions(+), 26 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index

[Bug 1926497] [NEW] dp83932 stops working after a short while

Public bug reported: Following the instructions here https://wiki.qemu.org/Documentation/Platforms/m68k I was able to successfully install debian. However, running apt-get update stalls after the first 1-2MB. root@debian:~# apt-get update Get:1 http://ftp.ports.debian.org/debian-ports sid InRelea

[PATCH v2 00/15] linux-user/s390x: some signal fixes

Version 2 splits lazy do-it-all patch. Patch 1 has an additional fix, so I dropped the r-b. r~ Richard Henderson (15): linux-user/s390x: Fix sigframe types linux-user/s390x: Use uint16_t for signal retcode linux-user/s390x: Remove PSW_ADDR_AMODE linux-user/s390x: Remove restore_sigregs re

[PATCH v2 04/15] linux-user/s390x: Remove restore_sigregs return value

The function cannot fail. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 1dfca71fa9..e455a9818d 100644 --- a/linux-user/s390x/signal.c +

[Bug 1926497] Re: dp83932 stops working after a short while

I also see the same problem with version 4.2.1 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926497 Title: dp83932 stops working after a short while Status in QEMU: New Bug description: Foll

[Bug 1926497] Re: dp83932 stops working after a short while

** Tags added: m68k q800 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1926497 Title: dp83932 stops working after a short while Status in QEMU: New Bug description: Following the instructions

[PATCH v2 03/15] linux-user/s390x: Remove PSW_ADDR_AMODE

This is an unnecessary complication since we only support 64-bit mode. Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index fece8ab97b..1df

<    1   2   3   4   >