On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > The TYPE_VMGENID device depends on fw_cfg: > > $ git grep \ fw_cfg hw/acpi/vmgenid.c > hw/acpi/vmgenid.c:128: fw_cfg_add_file(s, VMGENID_GUID_FW_CFG_FILE, > guid->data, > hw/acpi/vmgenid.c:131: fw_cfg_add_file_callback(s, > VMGENID_ADDR_FW_CFG_FILE, NULL, NULL, NULL, > > Add the proper Kconfig dependency. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/acpi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig > index 1932f66af8d..b9dc932d2a7 100644 > --- a/hw/acpi/Kconfig > +++ b/hw/acpi/Kconfig > @@ -40,5 +40,6 @@ config ACPI_VMGENID > bool > default y > depends on PC > + select FW_CFG > > config ACPI_HW_REDUCED >
The intent is certainly correct and the implementation looks plausible. Reviewed-by: Laszlo Ersek <ler...@redhat.com>
