[PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-04-15 Thread Cleber Rosa
The test contains methods for the proper log of test related information. Let's use that and remove the print and the unused logging import. Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_qu

[PATCH 1/8] Acceptance Jobs: preserve the cache for pip on GitLab CI

2021-04-15 Thread Cleber Rosa
The acceptance jobs (via `make check-venv`) will setup a virtual environment, and after that install packages defined in tests/requirements.txt via pip. Let's enable pip's default cache directory, so that we can save a bit on time/bandwidth. Signed-off-by: Cleber Rosa --- .gitlab-ci.yml | 1 +

[PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported

2021-04-15 Thread Cleber Rosa
FIXME: check if there's a way to query migration support before actually requesting migration. Some targets/machines contain devices that do not support migration. Let's acknowledge that and cancel the test as early as possible. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 6 +

[PATCH 7/8] tests/acceptance/migration.py: cancel test on s390x

2021-04-15 Thread Cleber Rosa
Because s390x targets it can not currently migrate without a guest running. Future work may provide a proper guest, but for now, it's safer to cancel the test. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/acceptance

[PATCH 6/8] Acceptance tests: prevent shutdown on non-specific target tests

2021-04-15 Thread Cleber Rosa
When running tests that are not target specific with various target binaries, some specific behavior appears. For s390x, when there's no guest code running, it will produce GUEST_PANICKED events as the firmware will shutdown the machine. With this change, no GUEST_PANICKED *event* will be generat

[PATCH 8/8] Tests: add custom test jobs

2021-04-15 Thread Cleber Rosa
Different users (or even companies) have different interests, and may want to run a reduced set of tests during development, or a larger set of tests during QE. To cover these use cases, some example (but functional) jobs are introduced here: 1) acceptance-all-targets.py: runs all arch agnostic t

Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array

2021-04-15 Thread Richard Henderson
On 4/15/21 11:23 AM, Peter Maydell wrote: SSE-300 currently shares the SSE-200 Property array. This is bad principally because the default values of the CPU0_FPU and CPU0_DSP properties disable the FPU and DSP on the CPU. That is correct for the SSE-300 but not the SSE-200. Give the SSE-300 its o

[RFC PATCH 2/3] tests/tcg/ppc64le: load 33-bits constant with paddi

2021-04-15 Thread matheus . ferst
From: Matheus Ferst This test checks that we can correctly load a 33-bit constant and its two's complement. At least until version 1.1-0, POWER10 Functional Simulation fails this test, processing the immediate as if it were 32-bits instead of 34, so it's probably something to keep an eye on. Sig

[RFC PATCH 3/3] tests/tcg/ppc64le: R=1 test for paddi

2021-04-15 Thread matheus . ferst
From: Matheus Ferst This test exercise the R=1 path of paddi implementation using the extended mnemonic "pla". Signed-off-by: Matheus Ferst --- tests/tcg/ppc64/Makefile.target | 3 ++- tests/tcg/ppc64le/Makefile.target | 3 ++- tests/tcg/ppc64le/pla.c | 26 +++

[RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests

2021-04-15 Thread matheus . ferst
From: Matheus Ferst Based-on: <20210413211129.457272-1-luis.pi...@eldorado.org.br> This series adds gcc-10 based images to enable the build of tests with Power10 instructions. Then two tests for paddi are added: - The first one checks a weird behavior observed on POWER10 Functional Simulator 1

[RFC PATCH 1/3] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-15 Thread matheus . ferst
From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, new '-test-cross' images are created for ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support is added to verify that the toolchain in use has '-mpower10'.

Re: [PATCH v2 2/2] hw/elf_ops: clear uninitialized segment space

2021-04-15 Thread Richard Henderson
On 4/15/21 3:04 AM, Philippe Mathieu-Daudé wrote: From: Laurent Vivier When the mem_size of the segment is bigger than the file_size, and if this space doesn't overlap another segment, it needs to be cleared. This bug is very similar to the one we had for linux-user, 22d113b52f41 ("linux-user:

Re: [PATCH] target/xtensa: don't generate extra EXCP_DEBUG on exception

2021-04-15 Thread Richard Henderson
On 4/15/21 1:55 PM, Max Filippov wrote: target/xtensa used to generate an extra EXCP_DEBUG exception before the first instruction executed after an interrupt or an exception is taken to allow single-stepping that instruction in the debugger. This is no longer needed after the following commits: a

Re: [PATCH] docs: Add documentation for shakti_c machine

2021-04-15 Thread Alistair Francis
On Tue, Apr 13, 2021 at 3:44 AM Vijai Kumar K wrote: > > Add documentation for Shakti C reference platform. > > Signed-off-by: Vijai Kumar K Thanks! Applied to riscv-to-apply.next Alistair > --- > docs/system/riscv/shakti-c.rst | 82 ++ > 1 file changed, 82 in

Re: [PATCH v2 1/2] exec/memory: Extract address_space_set() from dma_memory_set()

2021-04-15 Thread Richard Henderson
On 4/15/21 3:04 AM, Philippe Mathieu-Daudé wrote: dma_memory_set() does a DMA barrier, set the address space with a constant value. The constant value filling code is not specific to DMA and can be used for AddressSpace. Extract it as a new helper: address_space_set(). Signed-off-by: Philippe Ma

Re: [RFC PATCH 0/9] migration/snap-tool: External snapshot utility

2021-04-15 Thread Peter Xu
On Wed, Mar 17, 2021 at 07:32:13PM +0300, Andrey Gruzdev wrote: > This series is a kind of PoC for asynchronous snapshot reverting. This is > about external snapshots only and doesn't involve block devices. Thus, it's > mainly intended to be used with the new 'background-snapshot' migration > capab

RE: [PATCH V4 4/7] hmp-commands: Add new HMP command for COLO passthrough

2021-04-15 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, March 24, 2021 6:40 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Markus Armbruster > ; Li Zhijian ; Zhang Chen > ; Lukas Straub > Subject: Re: [PATCH V4 4/7] hmp-commands: Add n

Re: [PATCH v2] hw/block/nvme: align with existing style

2021-04-15 Thread Gollu Appalanaidu
On Thu, Apr 15, 2021 at 07:18:50PM +0200, Klaus Jensen wrote: On Apr 15 15:13, Philippe Mathieu-Daudé wrote: On 4/15/21 2:00 PM, Gollu Appalanaidu wrote: Make uniform hexadecimal numbers format. Signed-off-by: Gollu Appalanaidu --- -v2: Address review comments (Klaus) use lower case hexa form

[PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump

2021-04-15 Thread Robert Hoo
Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), CPUX86State.xmm_regs[] has already been extended to 512bit to support AVX512. Also, other qemu level supports for AVX512 registers are there for years. But in x86_cpu_dump_state(), still only dump XMM registers no matter YMM/ZMM

[Bug 1924669] [NEW] VFP code cannot see CPACR write in the same TB

2021-04-15 Thread Hansni Bu
Public bug reported: If FPU is enabled by writing to CPACR, and the code is in the same translation block as the following VFP code, qemu generates "v7M NOCP UsageFault". This can be reproduced with git HEAD (commit 8fe9f1f891eff4e37f82622b7480ee748bf4af74). The target binary is attached. The qe

Re: [PATCH 1/8] Acceptance Jobs: preserve the cache for pip on GitLab CI

2021-04-15 Thread Thomas Huth
On 15/04/2021 23.51, Cleber Rosa wrote: The acceptance jobs (via `make check-venv`) will setup a virtual environment, and after that install packages defined in tests/requirements.txt via pip. Let's enable pip's default cache directory, so that we can save a bit on time/bandwidth. Signed-off-by

Re: [RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:41:35PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Based-on: <20210413211129.457272-1-luis.pi...@eldorado.org.br> First things first: it's unclear to me if this is testing stuff that's already merged, or it's speculative tests for the in-prog

Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-15 Thread David Gibson
On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote: > On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote: > > All the code related to gdb has been moved from translate_init.c.inc > > file to the gdbstub.c file, where it makes more sense. > > > > This new version puts the prototypes

Re: [RFC PATCH 1/3] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:41:36PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > A newer compiler is needed to build tests for Power10 instructions. As > done for arm64 on c729a99d2701, new '-test-cross' images are created for > ppc64 and ppc64le. As done on 936fda4d771f,

[PATCH v3] hw/block/nvme: align with existing style

2021-04-15 Thread Gollu Appalanaidu
Use lower case hexadecimal format for the constants and in comments use the same format as used in Spec. ("h") Signed-off-by: Gollu Appalanaidu --- -v3: Add Suggestions (Philippe) Describe the NVMe subsystem style in nvme.c header -v2: Address review comments (Klaus) use lower case hex

Re: [PATCH v2 1/4] target/ppc: Fix POWER9 radix guest HV interrupt AIL behaviour

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 09:12:21AM -0300, Fabiano Rosas wrote: > Nicholas Piggin writes: > > > ISA v3.0 radix guest execution has a quirk in AIL behaviour such that > > the LPCR[AIL] value can apply to hypervisor interrupts. > > > > This affects machines that emulate HV=1 mode (i.e., powernv9). >

Re: [PATCH v2 3/4] target/ppc: Rework AIL logic in interrupt delivery

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 03:42:26PM +1000, Nicholas Piggin wrote: > The AIL logic is becoming unmanageable spread all over powerpc_excp(), > and it is slated to get even worse with POWER10 support. > > Move it all to a new helper function. > > Reviewed-by: Cédric Le Goater > Tested-by: Cédric Le

Re: [PATCH v2 4/4] target/ppc: Add POWER10 exception model

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 03:42:27PM +1000, Nicholas Piggin wrote: > POWER10 adds a new bit that modifies interrupt behaviour, LPCR[HAIL], > and it removes support for the LPCR[AIL]=0b10 mode. > > Reviewed-by: Cédric Le Goater > Tested-by: Cédric Le Goater > Signed-off-by: Nicholas Piggin > --- >

Re: [EXTERNAL] [PATCH v2 2/4] target/ppc: POWER10 supports scv

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 09:43:23AM +0200, Cédric Le Goater wrote: > On 4/15/21 7:42 AM, Nicholas Piggin wrote: > > This must have slipped through the cracks between adding POWER10 support > > and scv support. > > > > Signed-off-by: Nicholas Piggin > > Reviewed-by: Cédric Le Goater Applied to p

Re: [PATCH v4 09/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:33:01PM +0200, Philippe Mathieu-Daudé wrote: > We might have a s390x/ppc64 QEMU binary built without the KVM > accelerator (configured with --disable-kvm). > Checking for /dev/kvm accessibility isn't enough, also check for the > accelerator in the binary. > > Signed-off-

Re: [RFC PATCH v2 1/6] device_tree: Add qemu_fdt_add_path

2021-04-15 Thread David Gibson
On Tue, Apr 13, 2021 at 04:07:40PM +0800, Yanan Wang wrote: > From: Andrew Jones > > qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except > it also adds any missing subnodes in the path. We also tweak > an error message of qemu_fdt_add_subnode(). > > We'll make use of this new function

Re: [PATCH] target/riscv: fix wfi exception behavior

2021-04-15 Thread Alistair Francis
On Sun, Apr 11, 2021 at 5:41 AM Jose Martins wrote: > > The wfi exception trigger behavior was not taking into account the fact > that user mode is not allowed to execute wfi instructions or the effect > of the hstatus.vtw bit. It was also always generating virtual instruction > exceptions when th

Re: [PING^2] [PATCH] [NFC] Mark locally used symbols as static.

2021-04-15 Thread Philippe Mathieu-Daudé
Hi Yuri, On 4/15/21 7:27 PM, Yuri Gribov wrote: > Hi all, > > This patch makes locally used symbols static to enable more compiler > optimizations on them. Some of the symbols turned out to not be used > at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if > they were ok to delete).

Re: [PATCH 2/8] Acceptance tests: do not try to reuse packages from the system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > The premise behind the original behavior is that it would save people > from downloading Avocado (and other dependencies) if already installed > on the system. To be honest, I think it's extremely rare that the > same versions described as dependencies wil

Re: [PING^2] [PATCH] [NFC] Mark locally used symbols as static.

2021-04-15 Thread Palmer Dabbelt
On Thu, 15 Apr 2021 10:27:42 PDT (-0700), tetra2...@gmail.com wrote: Hi all, This patch makes locally used symbols static to enable more compiler optimizations on them. Some of the symbols turned out to not be used at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if they were ok t

Re: [PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > FIXME: check if there's a way to query migration support before > actually requesting migration. > > Some targets/machines contain devices that do not support migration. > Let's acknowledge that and cancel the test as early as possible. > > Signed-off-by:

Re: [PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > The test contains methods for the proper log of test related "The Test class ..."? > information. Let's use that and remove the print and the unused > logging import. > > Reference: > https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.ht

Re: [PATCH 8/8] Tests: add custom test jobs

2021-04-15 Thread Philippe Mathieu-Daudé
Hi Cleber, On 4/15/21 11:51 PM, Cleber Rosa wrote: > Different users (or even companies) have different interests, and > may want to run a reduced set of tests during development, or a > larger set of tests during QE. > > To cover these use cases, some example (but functional) jobs are > introduc

[PATCH] block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS

2021-04-15 Thread Thomas Huth
A customer reported that running qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2 fails for them with the following error message when the images are stored on a GPFS file system: qemu-img: error while writing sector 0: Invalid argument After analyzing the strace output, it

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > These tests' setUp do not do anything beyong what their base class do. > And while they do decorate the setUp() we can decorate the classes > instead, so no functionality is lost here. This is what I did first when adding this test, but it was not working,

Re: [PATCH v3] hw/block/nvme: align with existing style

2021-04-15 Thread Klaus Jensen
On Apr 16 09:22, Gollu Appalanaidu wrote: Use lower case hexadecimal format for the constants and in comments use the same format as used in Spec. ("h") Signed-off-by: Gollu Appalanaidu --- -v3: Add Suggestions (Philippe) Describe the NVMe subsystem style in nvme.c header -v2: Address

Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

2021-04-15 Thread Philippe Mathieu-Daudé
On 3/17/21 7:46 PM, Cédric Le Goater wrote: > On 3/13/21 1:05 PM, Philippe Mathieu-Daudé wrote: >> Incorrect subject prefix, should be "hw/ssi/aspeed_smc" > > Is this just good practice or something that was agreed upon ? Not sure, maybe "good practice"? Anyway here I only meant to correct my ow

RE: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition

2021-04-15 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Thursday, April 15, 2021 11:15 PM > To: Zhang, Chen > Cc: Dr. David Alan Gilbert ; Lukas Straub > ; Li Zhijian ; Jason Wang > ; qemu-dev ; Zhang > Chen > Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition > > "

Re: [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-04-15 Thread Markus Armbruster
John Snow writes: > On 4/15/21 2:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Rename QAPIError to QAPISourceError, and then create a new QAPIError >>> class that serves as the basis for all of our other custom exceptions. >> >> Isn't the existing QAPIError such a base class alre

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-15 Thread Markus Armbruster
John Snow writes: > On 4/15/21 3:00 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 3/30/21 1:18 PM, John Snow wrote: >>> >>> Realizing now that this commit topic is wrong :) >>> >>> A prior version modified the assertion, I decided it was less churn to >>> simply add one. >>> >>> I

Re: [PATCH 3/5] hw/pci-host/prep: Remove unuseful memory region mapping

2021-04-15 Thread Philippe Mathieu-Daudé
On 3/22/21 5:09 AM, David Gibson wrote: > On Fri, Mar 12, 2021 at 03:38:21PM -0500, Peter Xu wrote: >> On Fri, Mar 12, 2021 at 07:28:49PM +0100, Philippe Mathieu-Daudé wrote: >>> The pci_io_non_contiguous region is mapped on top of pci_io >>> with higher priority, but simply dispatch into this regi

RE: [PATCH 00/11] Add support for Blob resources feature

2021-04-15 Thread Kasireddy, Vivek
Hi Gerd, > > I do understand that adding a new purely Wayland backend would make it > > redundant given that GTK, SDL, Spice, etc already support Wayland; > > however, I do not see any good options available for eliminating that blit. > > Well, one idea is using dbus (discovery/setup) and pipewir

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Thu, 15 Apr 2021 21:07:33 +0200 Philippe Mathieu-Daudé wrote: > On 4/15/21 6:56 PM, Greg Kurz wrote: > > On Thu, 15 Apr 2021 18:45:45 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> On 4/15/21 3:30 PM, Greg Kurz wrote: > >>> On Thu, 15 Apr 2021 14:39:55 +0200 > >>> Philippe Mathieu-Daudé w

Re: [PATCH] plugins/syscall: Added a table-like summary output

2021-04-15 Thread Mahmoud Mandour
On Thu, Apr 15, 2021 at 5:20 PM Mahmoud Mandour wrote: > Added a table-like output which contains the total number of calls > for each used syscall along with the number of errors that occurred. > > Per-call tracing is still available through supplying the argument > ``print`` to the plugin. > >

<    1   2   3