Hi Yuri, On 4/15/21 7:27 PM, Yuri Gribov wrote: > Hi all, > > This patch makes locally used symbols static to enable more compiler > optimizations on them. Some of the symbols turned out to not be used > at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if > they were ok to delete).
It would be easier to integrate your work if your split it in multiple patches, and send them as a series, and add the Reviewed-by/Acked-by tags to the corresponding ones (these could be queued via the qemu-trival tree already). See below. > The symbols have been identified with a pet project of mine: > https://github.com/yugr/Localizer > > Link to patch: > https://patchew.org/QEMU/cajotw+5ddmsr8qjqxaa1oht79rpmjcrwkybuartynr_ngux...@mail.gmail.com/ > > From 4e790fd06becfbbf6fb106ac52ae1e4515f1ac73 Mon Sep 17 00:00:00 2001 > From: Yury Gribov <tetra2...@gmail.com> > Date: Sat, 20 Mar 2021 23:39:15 +0300 > Subject: [PATCH] Mark locally used symbols as static. > > Signed-off-by: Yury Gribov <tetra2...@gmail.com> > Acked-by: Max Filippov <jcmvb...@gmail.com> (xtensa) > Acked-by: David Gibson <da...@gibson.dropbear.id.au> (ppc) > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> (tracetool) > Reviewed-by: Taylor Simpson <tsimp...@quicinc.com> (hexagon) > --- > disas/alpha.c | 16 ++-- > disas/m68k.c | 78 ++++++++--------- > disas/mips.c | 14 ++-- > disas/nios2.c | 84 +++++++++---------- > disas/ppc.c | 26 +++--- > disas/riscv.c | 2 +- patch #1, "disas: Mark locally used symbols as static" > pc-bios/optionrom/linuxboot_dma.c | 4 +- patch #2, "pc-bios/optionrom: Mark locally used symbols as static" > scripts/tracetool/format/c.py | 2 +- patch #3, "scripts/tracetool: Mark locally used symbols as static" > target/hexagon/gen_dectree_import.c | 2 +- > target/hexagon/opcodes.c | 2 +- patch #4, "target/hexagon: Mark locally used symbols as static" > target/i386/cpu.c | 2 +- patch #5, "target/i386: Mark locally used symbols as static" > target/s390x/cpu_models.c | 2 +- patch #6, "target/s390x: Mark locally used symbols as static" > .../xtensa/core-dc232b/xtensa-modules.c.inc | 2 +- > .../xtensa/core-dc233c/xtensa-modules.c.inc | 2 +- > target/xtensa/core-de212/xtensa-modules.c.inc | 2 +- > .../core-de233_fpu/xtensa-modules.c.inc | 2 +- > .../xtensa/core-dsp3400/xtensa-modules.c.inc | 2 +- > target/xtensa/core-fsf/xtensa-modules.c.inc | 2 +- > .../xtensa-modules.c.inc | 2 +- > .../core-test_kc705_be/xtensa-modules.c.inc | 2 +- > .../core-test_mmuhifi_c3/xtensa-modules.c.inc | 2 +- patch #7, "target/xtensa: Mark locally used symbols as static" > 21 files changed, 125 insertions(+), 127 deletions(-) Regards, Phil.
