Re: [PATCH for-6.0 v2 4/8] hw/block/nvme: fix controller namespaces array indexing

2021-04-06 Thread Philippe Mathieu-Daudé
On 4/5/21 7:54 PM, Klaus Jensen wrote: > From: Klaus Jensen > > The controller namespaces array being 0-indexed requires 'nsid - 1' > everywhere. Something that is easy to miss. Align the controller > namespaces array with the subsystem namespaces array such that both are > 1-indexed. TBH I don'

Re: [PATCH] hw/misc: Add an iBT device model

2021-04-06 Thread Cédric Le Goater
Hello, On 4/5/21 6:54 PM, Hao Wu wrote: > Hi, Cedric and Corey > > When I'm implementing KCS device for nuvoton BMC boards, one of the feedback > Corey gave me was to refactor the existing device like ipmi-bmc-extern so > that we can reuse some of the common stuff there. I'm in the process of d

Re: [PATCH for-6.0 v2 6/8] hw/block/nvme: update dmsrl limit on namespace detachment

2021-04-06 Thread Philippe Mathieu-Daudé
On 4/5/21 7:54 PM, Klaus Jensen wrote: > From: Klaus Jensen > > The Non-MDTS DMSRL limit must be recomputed when namespaces are > detached. > > Fixes: 645ce1a70cb6 ("hw/block/nvme: support namespace attachment command") > Signed-off-by: Klaus Jensen > Reviewed-by: Gollu Appalanaidu > --- > hw

Re: [PATCH] i386/cpu: Expose AVX_VNNI instruction to guset

2021-04-06 Thread Philippe Mathieu-Daudé
Typo "guest" in subject. On 4/6/21 3:57 AM, Yang Zhong wrote: > Expose AVX (VEX-encoded) versions of the Vector Neural Network > Instructions to guest.> > The bit definition: > CPUID.(EAX=7,ECX=1):EAX[bit 4] AVX_VNNI > > The following instructions are available when this feature is > present in t

Re: [PATCH for-6.0 v2 3/8] hw/block/nvme: fix the nsid 'invalid' value

2021-04-06 Thread Klaus Jensen
On Apr 6 08:53, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > On 4/5/21 7:54 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The `nvme_nsid()` function returns '-1' (h) when the given > > namespace is NULL. Since h is actually a valid namespace > > identifier (the "broadc

Re: [PATCH] i386/cpu: Expose AVX_VNNI instruction to guset

2021-04-06 Thread Yang Zhong
On Tue, Apr 06, 2021 at 09:15:44AM +0200, Philippe Mathieu-Daudé wrote: > Typo "guest" in subject. > Philippe, thanks for your comments! It's my fault, let me change it and if there is no any other issue , i will send new version tomorrow. thanks! Yang > On 4/6/21 3:57 AM, Yang Zhong wrot

Re: [PATCH for-6.0 v2 6/8] hw/block/nvme: update dmsrl limit on namespace detachment

2021-04-06 Thread Klaus Jensen
On Apr 6 09:10, Philippe Mathieu-Daudé wrote: > On 4/5/21 7:54 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The Non-MDTS DMSRL limit must be recomputed when namespaces are > > detached. > > > > Fixes: 645ce1a70cb6 ("hw/block/nvme: support namespace attachment command") > > Signed-off-

Re: [PATCH for-6.0 v2 4/8] hw/block/nvme: fix controller namespaces array indexing

2021-04-06 Thread Klaus Jensen
On Apr 6 09:01, Philippe Mathieu-Daudé wrote: > On 4/5/21 7:54 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The controller namespaces array being 0-indexed requires 'nsid - 1' > > everywhere. Something that is easy to miss. Align the controller > > namespaces array with the subsystem n

[Bug 1922611] Re: Acceptance Tests: migration fails on sparc target

2021-04-06 Thread Philippe Mathieu-Daudé
6cc88d6bf932a905ce36e933dc078eeb6b54ac92 is the first bad commit: commit 6cc88d6bf932a905ce36e933dc078eeb6b54ac92 Author: Mark Cave-Ayland Date: Thu Mar 4 22:10:34 2021 + esp: remove dma_left from ESPState -- You received this bug notification because you are a member of qemu- devel-

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-06 Thread Andrew Jones
On Thu, Apr 01, 2021 at 11:32:25PM +0200, Igor Mammedov wrote: > On Thu, 01 Apr 2021 23:07:06 +0200 > Vincent Bernat wrote: > > > ❦ 1 avril 2021 22:58 +02, Igor Mammedov: > > > > >> This can be invoked with: > > >> > > >> $QEMU -netdev user,id=internet > > >> -device > > >> vir

[PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-06 Thread Pierre Morel
ccw_dstream_read/write functions returned values are sometime not taking into account and reported back to the upper level of interpretation of CCW instructions. It follows that accessing an invalid address does not trigger a subchannel status program check to the guest as it should. Let's test t

[PATCH v1 0/1] s390x: css: report errors from ccw_dstream_read/write

2021-04-06 Thread Pierre Morel
By checking the results of errors on SSCH in the kvm-unit-tests We noticed that no error was reported when a SSCH is started to access addresses not existing in the guest. For exemple accessing 3G on a guest with 1G memory. If we look at QEMU ccw_dstream_write/write functions we see that they are

[Bug 1922391] Re: qemu-system-ppc assertion "!mr->container" failed

2021-04-06 Thread Philippe Mathieu-Daudé
If the machine can not support more than 2GB, QEMU should report an error when the user tries to assign too many memory, not crash and let it figure out. Setting the bug status to confirmed. ** Changed in: qemu Status: Invalid => Confirmed -- You received this bug notification because yo

Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough

2021-04-06 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Qemu-devel > bounces+chen.zhang=intel@nongnu.org> On Behalf Of Markus >> Armbruster >> Sent: Tuesday, March 23, 2021 5:58 PM >> To: Zhang, Chen >> Cc: Lukas Straub ; Li Zhijian >> ; Jason Wang ; qemu- >> dev ; Dr. David Alan Gilber

[PATCH for-6.0 v1 0/3] softmmu/physmem: shared anonymous memory fixes

2021-04-06 Thread David Hildenbrand
Fixes related to shared anonymous memory, previously sent as part of https://lore.kernel.org/r/20210319101230.21531-1-da...@redhat.com Cc: Paolo Bonzini Cc: Peter Xu Cc: Dr. David Alan Gilbert Cc: Igor Kotrasinski Cc: Richard Henderson David Hildenbrand (3): softmmu/physmem: Mark share

[PATCH for-6.0 v1 1/3] softmmu/physmem: Mark shared anonymous memory RAM_SHARED

2021-04-06 Thread David Hildenbrand
Let's drop the "shared" parameter from ram_block_add() and properly store it in the flags of the ram block instead, such that qemu_ram_is_shared() properly succeeds on all ram blocks that were mapped MAP_SHARED. We'll use this information next to fix some cases with shared anonymous memory. Revie

[PATCH for-6.0 v1 3/3] softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory

2021-04-06 Thread David Hildenbrand
RAM_SHARED now also properly indicates shared anonymous memory. Let's check that flag for anonymous memory as well, to restore the proper mapping. Fixes: 06329ccecfa0 ("mem: add share parameter to memory-backend-ram") Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand --- softmmu/physmem.c

[PATCH for-6.0 v1 2/3] softmmu/physmem: Fix ram_block_discard_range() to handle shared anonymous memory

2021-04-06 Thread David Hildenbrand
We can create shared anonymous memory via "-object memory-backend-ram,share=on,..." which is, for example, required by PVRDMA for mremap() to work. Shared anonymous memory is weird, though. Instead of MADV_DONTNEED, we have to use MADV_REMOVE: MADV_DONTNEED will only remove / zap all relevant

[for-6.0 PATCH 0/3] ppc: e500: Bump ppce500 u-boot to v2021.04

2021-04-06 Thread Bin Meng
This series bumps the u-boot.e500 to v2021.04, which fixed a long overdue broken pci issue caused by QEMU changes since Nov 2014. While we are here, add a reST documentation for the ppce500 machine. Please pull the full contents (binary) from https://github.com/lbmeng/qemu/ ppc branch. Bin Meng

[for-6.0 PATCH 1/3] roms/Makefile: Update ppce500 u-boot build directory name

2021-04-06 Thread Bin Meng
Currently building ppce500 u-boot image results in modified: roms/u-boot (untracked content) As roms/u-boot/.gitignore indicates, update the build directory name to build-e500 to eliminate this message. Signed-off-by: Bin Meng --- roms/Makefile | 8 1 file changed, 4 insertions(+

[for-6.0 PATCH 2/3] roms/u-boot: Bump ppce500 u-boot to v2021.04 to fix broken pci support

2021-04-06 Thread Bin Meng
When QEMU originally supported the ppce500 machine back in Jan 2014, it was created with a 1:1 mapping of PCI bus address. Things seemed to change rapidly that in Nov 2014 with the following QEMU commits: commit e6b4e5f4795b ("PPC: e500: Move CCSR and MMIO space to upper end of address space") a

[for-6.0 PATCH 3/3] docs/system: ppc: Add documentation for ppce500 machine

2021-04-06 Thread Bin Meng
This adds detailed documentation for PowerPC `ppce500` machine, including the following information: - Supported devices - Hardware configuration information - Boot options - Running Linux kernel - Running U-Boot Signed-off-by: Bin Meng --- docs/system/ppc/ppce500.rst | 156 ++

Re: [PATCH 1/2] block/rbd: fix memory leak in qemu_rbd_connect()

2021-04-06 Thread Markus Armbruster
Stefano Garzarella writes: > In qemu_rbd_connect(), 'mon_host' is allocated by qemu_rbd_mon_host() > using g_strjoinv(), but it's only freed in the error path, leaking > memory in the success path as reported by valgrind: > > 80 bytes in 4 blocks are definitely lost in loss record 5,028 of 6,51

Re: [PATCH 2/2] block/rbd: fix memory leak in qemu_rbd_co_create_opts()

2021-04-06 Thread Markus Armbruster
Stefano Garzarella writes: > When we allocate 'q_namespace', we forgot to set 'has_q_namespace' > to true. This can cause several issues, including a memory leak, > since qapi_free_BlockdevCreateOptions() does not deallocate that > memory, as reported by valgrind: > > 13 bytes in 1 blocks are d

[PATCH 0/1] libbpf dependecy for docker containers.

2021-04-06 Thread Andrew Melnychenko
For eBPF RSS steering, qemu required to be built with libbpf. (https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html) So, for few docker containers there was added libbpf. Some docker containers doesn't have that library, g.e. Ubuntu 20.04. On some systems, like Centos7 or Debian, lib

[PATCH 1/1] tests/docker: Added libbpf library to the docker files.

2021-04-06 Thread Andrew Melnychenko
The series of patches for eBPF RSS adds libbpf dependency for qemu. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html With this patch, libbpf added: Alpine - added libbpf-dev Centos 8 - added libbpf-devel Fedora - added libbpf-devel Signed-off-by: Andrew Melnychenko ---

Re: [PATCH v1 1/1] hw/opentitan: Update the interrupt layout

2021-04-06 Thread Bin Meng
On Wed, Mar 31, 2021 at 11:02 PM Alistair Francis wrote: > > Update the OpenTitan interrupt layout to match the latest OpenTitan > bitstreams. This involves changing the Ibex PLIC memory layout and the > UART interrupts. > > Signed-off-by: Alistair Francis > --- > include/hw/riscv/opentitan.h |

Re: [PATCH v2 2/5] target/riscv: Use the RISCVException enum for CSR predicates

2021-04-06 Thread Bin Meng
On Thu, Apr 1, 2021 at 11:19 PM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu.h | 3 +- > target/riscv/csr.c | 80 +- > 2 files changed, 46 insertions(+), 37 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 3/5] target/riscv: Fix 32-bit HS mode access permissions

2021-04-06 Thread Bin Meng
On Thu, Apr 1, 2021 at 11:19 PM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/csr.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 5/5] target/riscv: Use RISCVException enum for CSR access

2021-04-06 Thread Bin Meng
On Thu, Apr 1, 2021 at 11:19 PM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu.h | 11 +++ > target/riscv/csr.c | 37 ++--- > target/riscv/gdbstub.c | 8 > target/riscv/op_helper.c | 18

Re: [PATCH v2 4/5] target/riscv: Use the RISCVException enum for CSR operations

2021-04-06 Thread Bin Meng
On Thu, Apr 1, 2021 at 11:20 PM Alistair Francis wrote: > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu.h | 14 +- > target/riscv/csr.c | 643 +++-- > 2 files changed, 390 insertions(+), 267 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine

2021-04-06 Thread Bin Meng
On Fri, Apr 2, 2021 at 8:44 PM Alistair Francis wrote: > typo in the commit title: Enalbe -> Enable > imply VIRTIO_VGA for the virt machine, this fixes the following error > when specifying `-vga virtio` as a command line argument: > > qemu-system-riscv64: Virtio VGA not available > > Signed-off

Re: [PATCH 0/6] Add debug interface to kick/call on purpose

2021-04-06 Thread Dongli Zhang
On 4/5/21 6:55 PM, Jason Wang wrote: > > 在 2021/4/6 上午4:00, Dongli Zhang 写道: >> >> On 4/1/21 8:47 PM, Jason Wang wrote: >>> 在 2021/3/30 下午3:29, Dongli Zhang 写道: On 3/28/21 8:56 PM, Jason Wang wrote: > 在 2021/3/27 上午5:16, Dongli Zhang 写道: >> Hi Jason, >> >> On 3/26/21 12:24

Re: [PATCH v4 00/22] ppc: qemu: Add eTSEC support

2021-04-06 Thread Bin Meng
Hi Priyanka, On Sun, Mar 14, 2021 at 8:15 PM Bin Meng wrote: > > QEMU ppce500 machine can dynamically instantiate an eTSEC device > if "-device eTSEC" is given to QEMU. > > This series updates the fixed-link ethernet PHY driver as well as > the Freescale eTSEC driver to support the QEMU ppce500 b

[PATCH-for-6.0] hw/ppc/mac_newworld: Restrict RAM to 2 GiB

2021-04-06 Thread Philippe Mathieu-Daudé
On Mac99 and newer machines, the Uninorth PCI host bridge maps the PCI hole region at 2GiB, so the RAM area beside 2GiB is not accessible by the CPU. Restrict the memory to 2GiB to avoid problems such the one reported in the buglink. Buglink: https://bugs.launchpad.net/qemu/+bug/1922391 Reported-b

Re: [PATCH] nsis: Install *.elf images

2021-04-06 Thread Bin Meng
On Fri, Mar 26, 2021 at 2:22 PM Bin Meng wrote: > > As of today, the QEMU Windows installer does not include the > following two RISC-V BIOS images: > > - opensbi-riscv64-generic-fw_dynamic.elf > - opensbi-riscv32-generic-fw_dynamic.elf > > Update the installer script to include them. > > Signed-o

Re: [PATCH] nsis: Install *.elf images

2021-04-06 Thread Stefan Weil
Am 06.04.21 um 11:04 schrieb Bin Meng: On Fri, Mar 26, 2021 at 2:22 PM Bin Meng wrote: As of today, the QEMU Windows installer does not include the following two RISC-V BIOS images: - opensbi-riscv64-generic-fw_dynamic.elf - opensbi-riscv32-generic-fw_dynamic.elf Update the installer script

Re: [PATCH v8 26/35] Hexagon (target/hexagon) TCG generation

2021-04-06 Thread Alex Bennée
Taylor Simpson writes: >> -Original Message- >> From: Philippe Mathieu-Daudé On >> Behalf Of Philippe Mathieu-Daudé >> Sent: Thursday, February 11, 2021 6:23 PM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; >> laur...@vivier.

Re: [PULL for-6.0 0/2] emulated nvme fixes

2021-04-06 Thread Peter Maydell
On Mon, 5 Apr 2021 at 18:34, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit 25d75c99b2e5941c67049ee776efdb226414f4c6: > > Merge remote-tracking branch 'remotes/xtensa/tags/20210403-xtensa' into > staging (2021-04-04 21:48:45 +0100) > > are avail

Re: [PATCH V2] virtio-pci: compat page aligned ATS

2021-04-06 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > Commit 4c70875372b8 ("pci: advertise a page aligned ATS") advertises > the page aligned via ATS capability (RO) to unbrek recent Linux IOMMU > drivers since 5.2. But it forgot the compat the capability which > breaks the migration from old machine type: >

Remove myself as i.mx31 maintainer

2021-04-06 Thread Chubb, Peter (Data61, Eveleigh)
Remove Peter Chubb as i/MX31 maintainer. I'm leaving my current job and will no longer have access to the hardware to test or maintain this port. Signed-off-by: Peter Chubb --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 69003cdc3c..58f342108

[Bug 1922617] Re: qemu-aarch64-static "Illegal instruction" with debootstrap

2021-04-06 Thread Peter Maydell
This won't be the cause of the crash, but: don't run ninja directly. The build instructions (documented in README.rst) haven't changed: run configure, and then run make. The makefile still does some things and is not a pure does-absolutely-nothing wrapper around ninja in all cases. -- You receive

Re: [PATCH v2 07/11] tests/tcg: relax the next step precision of the gdb sha1 test

2021-04-06 Thread Alex Bennée
Richard Henderson writes: > On 4/1/21 3:25 AM, Alex Bennée wrote: >> check_break("SHA1Init") >> -# check step and inspect values >> +# Check step and inspect values. We do a double next after the >> +# breakpoint as depending on the version of gdb we may step the >> +# p

Re: [PATCH v2 04/11] tests/tcg/configure.sh: make sure we pick up x86_64 cross compilers

2021-04-06 Thread Alex Bennée
Richard Henderson writes: > On 4/1/21 3:25 AM, Alex Bennée wrote: >> While it's hard to find cross compilers packaged for arches other than >> x86_64 the same cannot be said for the x86_64 compiler which is >> available on Debians i386, arm64 and ppc64el release architectures. >> Signed-off-by:

Re: [PATCH 2/6] pci: introduce apci-index property for PCI device

2021-04-06 Thread Daniel P . Berrangé
On Mon, Mar 15, 2021 at 02:00:58PM -0400, Igor Mammedov wrote: > In x86/ACPI world, linux distros are using predictable > network interface naming since systemd v197. Which on > QEMU based VMs results into path based naming scheme, > that names network interfaces based on PCI topology. > > With it

Re: [PATCH] hw/arm/smmuv3: Emulate CFGI_STE_RANGE for an aligned range of StreamIDs

2021-04-06 Thread Auger Eric
Hi Zenghui, On 4/2/21 12:04 PM, Zenghui Yu wrote: > In emulation of the CFGI_STE_RANGE command, we now take StreamID as the > start of the invalidation range, regardless of whatever the Range is, > whilst the spec clearly states that > > - "Invalidation is performed for an *aligned* range of 2^(

Re: [PATCH] hw/virtio: enable ioeventfd configuring for mmio

2021-04-06 Thread Michael S. Tsirkin
i tagged it for 6.1 pls remind me after release so it's not lost On Mon, Apr 05, 2021 at 08:50:31AM +0300, Pavel Dovgalyuk wrote: > ping > > On 29.03.2021 10:43, Pavel Dovgalyuk wrote: > > This patch adds ioeventfd flag for virtio-mmio configuration. > > It allows switching ioeventfd on and off.

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-06 Thread Auger Eric
Hi Zenghui, On 4/2/21 10:47 AM, Zenghui Yu wrote: > The GSIV values in SMMUv3 IORT node are not correct as they don't match > the SMMUIrq enumeration, which describes the IRQ<->PIN mapping used by > our emulated vSMMU. > > Fixes: a703b4f6c1ee ("hw/arm/virt-acpi-build: Add smmuv3 node in IORT tabl

[Bug 1922391] Re: qemu-system-ppc assertion "!mr->container" failed

2021-04-06 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg00570.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1922391 Title: qemu-system-ppc assertion "!mr->container" failed Sta

Re: [PATCH v2 01/11] tests/tcg: update the defaults for x86 compilers

2021-04-06 Thread Philippe Mathieu-Daudé
On 4/1/21 12:25 PM, Alex Bennée wrote: > You don't usually notice this is broken on developer system on x86 as > we use the normal host compiler. However on other systems the -pc was > extraneous. Also for 32 bit only i686 packages exist now so we should > use those when available. > > Signed-off-

[Bug 1922617] Re: qemu-aarch64-static "Illegal instruction" with debootstrap

2021-04-06 Thread Laurent Vivier
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1922617 Title: qemu-aarch64-static "Illegal instruction" with debootstrap Status in QEMU: New Bug description: This is

Re: [PATCH v3 00/15] tests/tcg: Add TriCore tests

2021-04-06 Thread Bastian Koppelmann
On Fri, Mar 05, 2021 at 06:00:30PM +0100, Bastian Koppelmann wrote: > Hi Alex, > > after a long while and thanks to Thomas reminder, I finally came back to this > series. I addressed most of your comments except for the timeout --foreground > problem (see > https://lists.gnu.org/archive/html/qemu

Re: [PATCH-for-6.0] hw/ppc/mac_newworld: Restrict RAM to 2 GiB

2021-04-06 Thread BALATON Zoltan
On Tue, 6 Apr 2021, Philippe Mathieu-Daudé wrote: On Mac99 and newer machines, the Uninorth PCI host bridge maps the PCI hole region at 2GiB, so the RAM area beside 2GiB is not accessible by the CPU. Restrict the memory to 2GiB to avoid problems such the one reported in the buglink. Buglink: htt

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-06 Thread Peter Maydell
On Tue, 6 Apr 2021 at 11:10, Auger Eric wrote: > > Hi Zenghui, > > On 4/2/21 10:47 AM, Zenghui Yu wrote: > > The GSIV values in SMMUv3 IORT node are not correct as they don't match > > the SMMUIrq enumeration, which describes the IRQ<->PIN mapping used by > > our emulated vSMMU. > > > > Fixes: a70

Re: Remove myself as i.mx31 maintainer

2021-04-06 Thread Peter Maydell
On Tue, 6 Apr 2021 at 10:42, Chubb, Peter (Data61, Eveleigh) wrote: > > > Remove Peter Chubb as i/MX31 maintainer. > > I'm leaving my current job and will no longer have access to the > hardware to test or maintain this port. > > Signed-off-by: Peter Chubb Applied to target-arm.next. Thanks for

[Bug 1922617] Re: qemu-aarch64-static "Illegal instruction" with debootstrap

2021-04-06 Thread Laurent Vivier
I'm able to reproduce a coredump o("Illegal Instruction", but of host type) during a debootstrap process. The coredump is for a grep process, I'm trying to bisect. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

[PULL 0/2] pc,virtio: last minute bugfixes

2021-04-06 Thread Michael S. Tsirkin
The following changes since commit 11577d85b1a6939380bd16ed9a861653194de044: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-04-02 11:53:19 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream fo

[PULL 2/2] virtio-pci: compat page aligned ATS

2021-04-06 Thread Michael S. Tsirkin
From: Jason Wang Commit 4c70875372b8 ("pci: advertise a page aligned ATS") advertises the page aligned via ATS capability (RO) to unbrek recent Linux IOMMU drivers since 5.2. But it forgot the compat the capability which breaks the migration from old machine type: (qemu) qemu-kvm: get_pci_config

[PULL 1/2] x86: rename oem-id and oem-table-id properties

2021-04-06 Thread Michael S. Tsirkin
From: Paolo Bonzini After introducing non-scalar machine properties, it would be preferrable to have a single acpitable property which includes both generic information (such as the OEM ids) and custom tables currently passed via -acpitable. Do not saddle ourselves with legacy oem-id and oem-tab

Re: [PATCH v2 03/11] tests/tcg: add concept of container_hosts

2021-04-06 Thread Philippe Mathieu-Daudé
On 4/1/21 12:25 PM, Alex Bennée wrote: > While docker is nominally multarch these days it doesn't mean our Typo "multiarch" > distros actually package all cross compilers for all architectures. > The upcoming Debian bullseye release will improve things further. At > least for now we can get thing

Re: [PATCH 0/2] i386: Fix interrupt based Async PF enablement

2021-04-06 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 01/04/21 17:19, Vitaly Kuznetsov wrote: >> I noticed two issues with 'kvm-asyncpf-int' enablement: >> 1) We forgot to add to to kvm_default_props[] so it doesn't get enabled >> automatically (unless '-cpu host' is used or the feature is enabled >> manually on the co

Re: [Virtio-fs] [PATCH] virtiofsd: Fix security.capability comparison

2021-04-06 Thread Dr. David Alan Gilbert
* Connor Kuehl (cku...@redhat.com) wrote: > On 4/1/21 9:58 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > My security fix for the security.capability remap has a silly early > > segfault in a simple case where there is an xattrmapping but it doesn't > > remap t

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-06 Thread Auger Eric
Hi Peter, On 4/6/21 12:44 PM, Peter Maydell wrote: > On Tue, 6 Apr 2021 at 11:10, Auger Eric wrote: >> >> Hi Zenghui, >> >> On 4/2/21 10:47 AM, Zenghui Yu wrote: >>> The GSIV values in SMMUv3 IORT node are not correct as they don't match >>> the SMMUIrq enumeration, which describes the IRQ<->PIN

Re: [PATCH for-6.0 v1 1/4] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-04-06 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > Added missing qemu_fflush() on buffer file holding precopy device state. > Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. > Typical configurations often require >200KB for device state and VMDESC. > > Fixes: 851827

[PULL 3/6] hw/arm/virt: Only try to add valid dynamic sysbus devices to platform bus

2021-04-06 Thread Peter Maydell
The virt machine device plug callback currently calls platform_bus_link_device() for any sysbus device. This is overly broad, because platform_bus_link_device() will unconditionally grab the IRQs and MMIOs of the device it is passed, whether it was intended for the platform bus or not. Restrict h

[PULL 5/6] Revert "target/arm: Make number of counters in PMCR follow the CPU"

2021-04-06 Thread Peter Maydell
This reverts commit f7fb73b8cdd3f77e26f9fcff8cf24ff1b58d200f. This change turned out to be a bit half-baked, and doesn't work with KVM, which fails with the error: "qemu-system-aarch64: Failed to retrieve host CPU features" because KVM does not allow accessing of the PMCR_EL0 value in the scra

[PULL 2/6] machine: Provide a function to check the dynamic sysbus allowlist

2021-04-06 Thread Peter Maydell
Provide a new function dynamic_sysbus_dev_allowed() which checks the per-machine list of permitted dynamic sysbus devices and returns a boolean result indicating whether the device is allowed. We can use this in the implementation of validate_sysbus_device(), but we will also need it so that machi

[PULL 1/6] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev()

2021-04-06 Thread Peter Maydell
The function machine_class_allow_dynamic_sysbus_dev() is currently undocumented; add a doc comment. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Mark Cave-Ayland Reviewed-by: Eric Auger Message-id: 20210325153310.9131-2-peter.mayd...@linaro.org --- include/hw/board

Re: [PATCH 0/4] add in-tree 9pfs developers documentation

2021-04-06 Thread Christian Schoenebeck
On Dienstag, 23. März 2021 20:40:20 CEST Christian Schoenebeck wrote: > The original source for the QEMU 9p developers documentation is: > > https://wiki.qemu.org/Documentation/9p > > This patch set adds it as in-tree .rst file along with its pictures to the > QEMU source tree. The 9p.rst file

[PULL 0/6] target-arm queue

2021-04-06 Thread Peter Maydell
: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210406 for you to fetch changes up to 49bc76550c37f4a2b92a05cb3e6989a739d56ac9: Remove myself as i.mx31 maintainer (2021-04-06 11:49:15 +0100) target-arm que

[PULL 4/6] hw/ppc/e500plat: Only try to add valid dynamic sysbus devices to platform bus

2021-04-06 Thread Peter Maydell
The e500plat machine device plug callback currently calls platform_bus_link_device() for any sysbus device. This is overly broad, because platform_bus_link_device() will unconditionally grab the IRQs and MMIOs of the device it is passed, whether it was intended for the platform bus or not. Restri

[PULL 6/6] Remove myself as i.mx31 maintainer

2021-04-06 Thread Peter Maydell
From: "Chubb, Peter (Data61, Eveleigh)" Remove Peter Chubb as i/MX31 maintainer. I'm leaving my current job and will no longer have access to the hardware to test or maintain this port. Signed-off-by: Peter Chubb Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 -

Re: [PATCH for-6.0 v1 1/4] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-04-06 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > Added missing qemu_fflush() on buffer file holding precopy device state. > Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. > Typical configurations often require >200KB for device state and VMDESC. > > Fixes: 851827

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-06 Thread Peter Maydell
On Tue, 6 Apr 2021 at 13:23, Auger Eric wrote: > > Hi Peter, > > On 4/6/21 12:44 PM, Peter Maydell wrote: > > On Tue, 6 Apr 2021 at 11:10, Auger Eric wrote: > >> > >> Hi Zenghui, > >> > >> On 4/2/21 10:47 AM, Zenghui Yu wrote: > >>> The GSIV values in SMMUv3 IORT node are not correct as they don'

Re: [PATCH for-6.0 v1 4/4] migration: Rename 'bs' to 'block' in background snapshot code

2021-04-06 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > Rename 'bs' to commonly used 'block' in migration/ram.c background > snapshot code. > > Signed-off-by: Andrey Gruzdev > Reported-by: David Hildenbrand Thanks, Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 86 +

Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts

2021-04-06 Thread Auger Eric
Hi Peter, On 4/6/21 2:31 PM, Peter Maydell wrote: > On Tue, 6 Apr 2021 at 13:23, Auger Eric wrote: >> >> Hi Peter, >> >> On 4/6/21 12:44 PM, Peter Maydell wrote: >>> On Tue, 6 Apr 2021 at 11:10, Auger Eric wrote: Hi Zenghui, On 4/2/21 10:47 AM, Zenghui Yu wrote: > The GSI

[Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-04-06 Thread David Ober
/usr/bin/qemu-system-x86_64 kvm pc-i440fx-hirsute x86_64 efi /usr/share/OVMF/OVMF_CODE_4M.fd rom pflash yes no no EPYC-Rome AMD

[PATCH] riscv: don't look at SUM when accessing memory from a debugger context

2021-04-06 Thread Jade Fink
Previously the qemu monitor and gdbstub looked at SUM and refused to perform accesses to user memory if it is off, which was an impediment to debugging. Signed-off-by: Jade Fink --- target/riscv/cpu_helper.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

Re: Bug: fstenv is wrongly implemented

2021-04-06 Thread Ziqiao Kong
Hi! I checked that bug and list discussion and it indeed was the bug I referred to. It seems that the patch should be quite straightforward but no idea why the review of the patch was stalled at that time. I would try to draft an updated patch these days. Ziqiao On Fri, Apr 2, 2021 at 6:49 PM Pe

Re: [PATCH v4 0/2] Some modification about ram_save_host_page()

2021-04-06 Thread Kunkun Jiang
Kindly ping, Hi David Alan Gilbert, Will this series be picked up soon, or is there any other work for me to do? Best Regards, Kunkun Jiang On 2021/3/16 20:57, Kunkun Jiang wrote: Hi all, This series include patches as below: Patch 1: - reduce unnecessary rate limiting in ram_save_host_page()

Could we document exact steps for loongson3-virt in the manual?

2021-04-06 Thread Alex Bennée
Hi, I was trying to bootstrap a Loongson3 Debian image but ran into some roadblocks. Philippe pointed me at: https://www.mail-archive.com/qemu-devel@nongnu.org/msg768848.html which gives a bit of detail but elides over details such as how to handle block devices. AFAICT it should support virti

Re: [PULL 09/16] memory: add a sparse memory device for fuzzing

2021-04-06 Thread Philippe Mathieu-Daudé
On 3/16/21 10:15 PM, Paolo Bonzini wrote: > From: Alexander Bulekov > > For testing, it can be useful to simulate an enormous amount of memory > (e.g. 2^64 RAM). This adds an MMIO device that acts as sparse memory. > When something writes a nonzero value to a sparse-mem address, we > allocate a b

Re: docs/qemu-qmp-ref.7 markup messed up

2021-04-06 Thread Markus Armbruster
John Snow writes: > On 3/26/21 10:19 AM, Markus Armbruster wrote: >> When I look at docs/qemu-qmp-ref.7 with less -R, I see >> ReplicationMode (Enum) >> An enumeration of replication modes. >> Values >> primary >>Primary mode, the vm's state will be sent to

Re: [PATCH for-6.0 v1 1/4] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-04-06 Thread Andrey Gruzdev
On 06.04.2021 15:29, Dr. David Alan Gilbert wrote: * Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: Added missing qemu_fflush() on buffer file holding precopy device state. Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. Typical configurations often require >200KB

[PATCH-for-6.0] hw/mem/meson: Fix linking sparse-mem device with fuzzer

2021-04-06 Thread Philippe Mathieu-Daudé
sparse-mem.c is added to the 'mem_ss' source set, which itself is conditionally added to softmmu_ss if CONFIG_MEM_DEVICE is selected. But if CONFIG_MEM_DEVICE isn't selected, we get a link failure even if CONFIG_FUZZ is selected: /usr/bin/ld: tests_qtest_fuzz_generic_fuzz.c.o: in function `gene

Re: [PATCH-for-6.0] hw/mem/meson: Fix linking sparse-mem device with fuzzer

2021-04-06 Thread Philippe Mathieu-Daudé
+Alex On 4/6/21 3:39 PM, Philippe Mathieu-Daudé wrote: > sparse-mem.c is added to the 'mem_ss' source set, which itself > is conditionally added to softmmu_ss if CONFIG_MEM_DEVICE is > selected. > But if CONFIG_MEM_DEVICE isn't selected, we get a link failure > even if CONFIG_FUZZ is selected: >

Mac OS real USB device support issue

2021-04-06 Thread Programmingkid
Hi Gerd, I was wondering if you had access to a Mac OS 10 or Mac OS 11 machine to test USB support. I am on Mac OS 11.1 and cannot make USB devices work with any of my guests. So far these are the guests I have tested with: - Windows 7 - Mac OS 9.2 - Windows 2000 I have tried using USB flash d

Re: [PATCH v2 06/11] tests/tcg/i386: force -fno-pie for test-i386

2021-04-06 Thread Alex Bennée
Richard Henderson writes: > On 4/1/21 3:25 AM, Alex Bennée wrote: >> +-Werror -fno-pie -no-pie -o $TMPE $TMPC; then > > What is -no-pie? That isn't a compiler option, afaik. No it's a c&p error from the main test in configure: # Check we support --no-pie first; we will need

Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*

2021-04-06 Thread Zenghui Yu
[+Stefan] On 2021/3/12 19:21, Zenghui Yu wrote: Quote docs/devel/style.rst (section "Automatic memory deallocation"): * Variables declared with g_auto* MUST always be initialized, otherwise the cleanup function will use uninitialized stack memory Initialize @name properly to get rid of the

Re: Mac OS real USB device support issue

2021-04-06 Thread Howard Spoelstra
On Tue, Apr 6, 2021 at 3:44 PM Programmingkid wrote: > > Hi Gerd, > > I was wondering if you had access to a Mac OS 10 or Mac OS 11 machine to test > USB support. I am on Mac OS 11.1 and cannot make USB devices work with any of > my guests. So far these are the guests I have tested with: > > - W

[PATCH] linux-user: strace now handles unshare syscall args correctly

2021-04-06 Thread Matus Kysel
Syscall unshare did not have custom print function for strace, but it's argument is same as flags in clone syscall, so it can be easily implemented. Signed-off-by: Matus Kysel --- linux-user/strace.c| 12 linux-user/strace.list | 2 +- 2 files changed, 13 insertions(+), 1 dele

[PATCH 0/1] sphinx: qapidoc: Wrap "If" section body in a paragraph node

2021-04-06 Thread John Snow
(See commit message.) John Snow (1): sphinx: qapidoc: Wrap "If" section body in a paragraph node docs/sphinx/qapidoc.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.30.2

[PATCH 1/1] sphinx: qapidoc: Wrap "If" section body in a paragraph node

2021-04-06 Thread John Snow
These sections need to be wrapped in a block-level element, such as Paragraph in order for them to be rendered into Texinfo correctly. Before (e.g.): If defined(CONFIG_REPLICATION) became: .SS If \fBdefined(CONFIG_REPLICATION)\fP.SS \fBBlockdevOptionsReplication\fP (Object) ... Af

Re: Mac OS real USB device support issue

2021-04-06 Thread BALATON Zoltan
On Tue, 6 Apr 2021, Howard Spoelstra wrote: On Tue, Apr 6, 2021 at 3:44 PM Programmingkid wrote: Hi Gerd, I was wondering if you had access to a Mac OS 10 or Mac OS 11 machine to test USB support. I am on Mac OS 11.1 and cannot make USB devices work with any of my guests. So far these are t

Re: [PATCH] linux-user: strace now handles unshare syscall args correctly

2021-04-06 Thread Laurent Vivier
Le 06/04/2021 à 16:11, Matus Kysel a écrit : > Syscall unshare did not have custom print function for strace, but it's > argument is same as flags in clone syscall, so it can be easily implemented. > > Signed-off-by: Matus Kysel > --- > linux-user/strace.c| 12 > linux-user/str

Re: [PATCH v2 2/2] block/rbd: Add an escape-aware strchr helper

2021-04-06 Thread Max Reitz
On 01.04.21 23:01, Connor Kuehl wrote: Sometimes the parser needs to further split a token it has collected from the token input stream. Right now, it does a cursory check to see if the relevant characters appear in the token to determine if it should break it down further. However, qemu_rbd_nex

Re: [PATCH-for-6.0 1/2] disas/arm-a64.cc: Fix build error

2021-04-06 Thread Philippe Mathieu-Daudé
Still worth 6.0 IMO. On 3/20/21 5:18 AM, Gavin Shan wrote: > This fixes the following build error with gcc v11.0.0: > > # gcc --version > gcc (GCC) 11.0.0 20210210 (Red Hat 11.0.0-0) > > [969/2604] Compiling C++ object libcommon.fa.p/disas_arm-a64.cc.o > FAILED: libcommon.fa.p/disas_arm-

Re: Mac OS real USB device support issue

2021-04-06 Thread Programmingkid
> On Apr 6, 2021, at 10:01 AM, Howard Spoelstra wrote: > > On Tue, Apr 6, 2021 at 3:44 PM Programmingkid > wrote: >> >> Hi Gerd, >> >> I was wondering if you had access to a Mac OS 10 or Mac OS 11 machine to >> test USB support. I am on Mac OS 11.1 and cannot make USB devices work with >

Re: Mac OS real USB device support issue

2021-04-06 Thread Programmingkid
> On Apr 6, 2021, at 10:20 AM, BALATON Zoltan wrote: > > On Tue, 6 Apr 2021, Howard Spoelstra wrote: >> On Tue, Apr 6, 2021 at 3:44 PM Programmingkid >> wrote: >>> >>> Hi Gerd, >>> >>> I was wondering if you had access to a Mac OS 10 or Mac OS 11 machine to >>> test USB support. I am on M

Re: [PATCH-for-6.0] hw/mem/meson: Fix linking sparse-mem device with fuzzer

2021-04-06 Thread Alexander Bulekov
On 210406 1539, Philippe Mathieu-Daudé wrote: > sparse-mem.c is added to the 'mem_ss' source set, which itself > is conditionally added to softmmu_ss if CONFIG_MEM_DEVICE is > selected. > But if CONFIG_MEM_DEVICE isn't selected, we get a link failure > even if CONFIG_FUZZ is selected: > > /usr/b

  1   2   3   >