Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 78aeb23eded2d0b765bf9145c71f80025b568acd.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/e1000.c | 11 +--
1 file chan
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/rtl8139.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/vmxnet3.c | 10 --
1 file cha
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/sungem.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/hw/net/sungem.c b/hw/net/sungem.c
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/ne2000.c | 12
1 file changed, 12 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
i
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/sunhme.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c
i
On 16/03/21 11:59, Peter Maydell wrote:
This kind of "breaks the build tree such that you can't
just 'git reset' back to master" bug is irritating. Doesn't
meson have an "is this the right version" check on the cached
data it's loading out of the build tree ?
It does, but it doesn't expect a Mo
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng
---
(no changes since v1)
hw/net/pcnet.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index f3f
On Mon, 15 Mar 2021 18:55:03 -0700
Isaku Yamahata wrote:
> On Mon, Mar 15, 2021 at 11:27:29PM +0100,
> Reinoud Zandijk wrote:
>
> > On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote:
> > > Windows 10 1607x64 boots fine when I test it with default machine.
> > >
> > > So
> > > 1
Also same issue observed with docker version 19.03. docker pull command
failing with an error "failed to register layer: Error processing tar
file(exit status 1):"
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad
On Tue, 16 Mar 2021, Laurent Vivier wrote:
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
On Sat, 13 Mar 2021, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
Hello,
I've started posting this series well in advance to get it into 6.0 and yet it
seems like it may
be missing
On Tue, 16 Mar 2021, Laurent Vivier wrote:
Le 16/03/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
On 3/16/21 10:01 AM, Laurent Vivier wrote:
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
On Sat, 13 Mar 2021, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
Hello,
I've st
On 15.03.21 15:40, Vladimir Sementsov-Ogievskiy wrote:
15.03.2021 12:58, Max Reitz wrote:
[...]
The question is whether it really makes sense to even have a
seqcache_read() path when in reality it’s probably never accessed. I
mean, besides the fact that it seems based purely on chance wheth
Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu
module, which provides the type virtio-gpu-device, packaging the
hw-display-virtio-gpu module as a separate package that may or may not
be installed along with the qemu package leads to problems. Namely if
the hw-display-virtio-gp
Le 16/03/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
> On 3/16/21 10:01 AM, Laurent Vivier wrote:
>> Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
>>> On Sat, 13 Mar 2021, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
> Hello,
I've started posting this ser
After some back-and-forth in [1] Daniel suggested that
we could/should make qemu modules per-target by introducing a
dedicated modules directory for each target, which can symlink the
modules that do work with and do make sense for the given target.
That way we can avoid trying to load modules we
On Mon, 15 Mar 2021 at 09:14, Jason Wang wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging
> (2021-03-14 17:47:49 +)
>
> are available in the git rep
This series explores Daniels idea he proposed in [1], and
is a successor to the v3.
I decided to go with the RFC tag because there are several
things I have doubts about, and I hope somebody more familiar
with the topic can help me out. I kept running into situations
where meson felt like somethin
On Mon, 15 Mar 2021 15:05:26 -0700
Isaku Yamahata wrote:
> On Mon, Mar 15, 2021 at 05:58:04PM +0100,
> Reinoud Zandijk wrote:
>
> > I think its better to revert this and fix Linux ;) or make it a selectable
> > feature as a workaround that's by default OFF :)
>
> Anyway here is a patch to fl
On Tue, Mar 16, 2021 at 01:33:54PM +0100, Igor Mammedov wrote:
> On Mon, 15 Mar 2021 15:05:26 -0700
> Isaku Yamahata wrote:
>
> > On Mon, Mar 15, 2021 at 05:58:04PM +0100,
> > Reinoud Zandijk wrote:
> >
> > > I think its better to revert this and fix Linux ;) or make it a selectable
> > > featu
Philippe Mathieu-Daudé writes:
> On 3/16/21 11:26 AM, Philippe Mathieu-Daudé wrote:
>> On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
>>> On 3/16/21 7:51 AM, Markus Armbruster wrote:
Eric Blake writes:
> On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wrote:
[...]
>> diff -
$TARGET-NAME/config-target.mak has been removed a while ago.
Remove it now from the documentation, too.
Fixes: fdb75aeff7 ("configure: remove target configuration")
Signed-off-by: Thomas Huth
---
docs/devel/build-system.rst | 8
1 file changed, 8 deletions(-)
diff --git a/docs/devel/bu
On 16/03/2021 13.41, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 3/16/21 11:26 AM, Philippe Mathieu-Daudé wrote:
On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
On 3/16/21 7:51 AM, Markus Armbruster wrote:
Eric Blake writes:
On 3/11/21 5:11 PM, Philippe Mathieu-Daudé wr
On 16/03/21 13:13, Igor Mammedov wrote:
Surprisingly without accelerator ie with tcg the default machine does seem to
get to the login prompt. Is the ACPI data tailored to indicate an
accelerator/VM or is it static? Could it be that the CPU reported by my
machine is causing the issue? With the NV
We are already poisoning CONFIG_KVM since this switch is not working
in common code. Do the same with the other accelerator switches, too
(except for CONFIG_TCG, which is special, since it is also defined in
config-host.h).
Signed-off-by: Thomas Huth
---
include/exec/poison.h | 4
include/s
On Mon, 15 Mar 2021 23:27:29 +0100
Reinoud Zandijk wrote:
> On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote:
> > Windows 10 1607x64 boots fine when I test it with default machine.
> >
> > So
> > 1) can you provide full QEMU command line used
> > 2) What Windows build do you use
Le 16/03/2021 à 13:24, BALATON Zoltan a écrit :
> On Tue, 16 Mar 2021, Laurent Vivier wrote:
>> Le 16/03/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
>>> On 3/16/21 10:01 AM, Laurent Vivier wrote:
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
> On Sat, 13 Mar 2021, BALATON Zoltan wrote
Hi all,
This series include patches as below:
Patch 1:
- reduce unnecessary rate limiting in ram_save_host_page()
Patch 2:
- optimized ram_save_host_page() by using migration_bitmap_find_dirty() to find
dirty pages
History:
v3 -> v4:
- Remove the modification to ram_save_host_page() comment [Pe
When the host page is a huge page and something is sent in the
current iteration, migration_rate_limit() should be executed.
If not, it can be omitted.
Signed-off-by: Keqian Zhu
Signed-off-by: Kunkun Jiang
Reviewed-by: David Edmondson
---
migration/ram.c | 9 +++--
1 file changed, 7 insert
Starting from pss->page, ram_save_host_page() will check every page
and send the dirty pages up to the end of the current host page or
the boundary of used_length of the block. If the host page size is
a huge page, the step "check" will take a lot of time.
It will improve performance to use migrat
On Tue, 16 Mar 2021 12:40:28 +
Daniel P. Berrangé wrote:
> On Tue, Mar 16, 2021 at 01:33:54PM +0100, Igor Mammedov wrote:
> > On Mon, 15 Mar 2021 15:05:26 -0700
> > Isaku Yamahata wrote:
> >
> > > On Mon, Mar 15, 2021 at 05:58:04PM +0100,
> > > Reinoud Zandijk wrote:
> > >
> > > > I t
On Tue, 16 Mar 2021, Laurent Vivier wrote:
Le 16/03/2021 à 13:24, BALATON Zoltan a écrit :
On Tue, 16 Mar 2021, Laurent Vivier wrote:
Le 16/03/2021 à 12:49, Philippe Mathieu-Daudé a écrit :
On 3/16/21 10:01 AM, Laurent Vivier wrote:
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
On Sat, 13
On Tue, 16 Mar 2021 at 12:54, Thomas Huth wrote:
>
> We are already poisoning CONFIG_KVM since this switch is not working
> in common code. Do the same with the other accelerator switches, too
> (except for CONFIG_TCG, which is special, since it is also defined in
> config-host.h).
>
> Signed-off-
On Tue, 16 Mar 2021 13:49:57 +0100
Paolo Bonzini wrote:
> On 16/03/21 13:13, Igor Mammedov wrote:
> >>> Surprisingly without accelerator ie with tcg the default machine does
> >>> seem to
> >>> get to the login prompt. Is the ACPI data tailored to indicate an
> >>> accelerator/VM or is it static
Coverity reported (CID 1450831) an array overrun in
gen_mxu_D16MAX_D16MIN():
1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
1112 if (opc == OPC_MXU_D16MAX) {
1113 tcg_gen_smax_i32(mxu_gpr[XRa - 1], t0, t1);
1114 } else {
1115 tcg_
On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging
> (2021-03-14 17:47:49 +)
>
> are available in the Git rep
On 3/16/21 8:22 AM, Eric Blake wrote:
> On 10/26/20 4:36 AM, Kirti Wankhede wrote:
Hmm, just now realizing this is an old thread...
>> Added amount of bytes transferred to the VM at destination by all VFIO
>> devices
>>
>> Signed-off-by: Kirti Wankhede
>> Reviewed-by: Dr. David Alan Gilbert
>>
On 10/26/20 4:36 AM, Kirti Wankhede wrote:
> Added amount of bytes transferred to the VM at destination by all VFIO
> devices
>
> Signed-off-by: Kirti Wankhede
> Reviewed-by: Dr. David Alan Gilbert
> ---
> +++ b/qapi/migration.json
> @@ -147,6 +147,18 @@
> 'active', 'postcopy-activ
Watch this:
$ mkdir bld-tools
$ cd bld-tools
$ ../configure --disable-system --disable-user --enable-tools
$ make check
[...]
make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper',
needed by 'check-block'. Stop.
On 3/12/21 4:23 AM, Vladimir Sementsov-Ogievskiy wrote:
> 11.03.2021 06:15, Mahmoud Mandour wrote:
>> Replaced various qemu_mutex_lock/qemu_mutex_unlock calls with
>> lock guard macros (QEMU_LOCK_GUARD() and WITH_QEMU_LOCK_GUARD).
>> This slightly simplifies the code by eliminating calls to
>> qemu
On Mon, Mar 15, 2021 at 02:46:37PM +0300, Konstantin Nazarov wrote:
> The timing generation is currently performed inside the function that
> fills in the DTD. The DisplayID generation needs it as well, so moving
> it out to a separate function.
>
> Based-on: <20210303152948.59943-2-akihiko.od...@
On 3/16/21 4:10 AM, Stefan Hajnoczi wrote:
> On Wed, Mar 10, 2021 at 05:30:04PM +, Stefan Hajnoczi wrote:
>> socket_get_fd() fails with the error "socket_get_fd: too many
>> connections" if the given listen backlog value is not 1.
>>
>> Not all callers set the backlog to 1. For example, commit
On 3/15/21 2:48 PM, Eugenio Pérez wrote:
> Command to enable shadow virtqueue looks like:
>
> { "execute": "x-vhost-enable-shadow-vq", "arguments": { "name": "dev0",
> "enable": true } }
>
> Signed-off-by: Eugenio Pérez
> ---
> qapi/net.json | 22 ++
> hw/virtio/vhost.c
Aaron Lindsay writes:
> On Mar 12 17:28, Alex Bennée wrote:
>> Also add a note to explain currently they are unused.
>>
>> Signed-off-by: Alex Bennée
>
> I'm personally interested in one clarification below, but don't think
> that affects my:
>
> Reviewed-by: Aaron Lindsay
>
>> ---
>> inclu
From: Marc-André Lureau
g_hash_table_add always retains ownership of the pointer passed in as
the key. Its return status merely indicates whether the added entry was
new, or replaced an existing entry. Thus key must never be freed after
this method returns.
Spotted by ASAN:
==2407186==ERROR: Ad
Aaron Lindsay writes:
> A few clarifications inline:
>
> On Mar 12 17:28, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée
>> ---
>> include/qemu/qemu-plugin.h | 52 --
>> 1 file changed, 50 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/qemu/qem
On 3/12/2021 8:43 AM, Tian, Kevin wrote:
From: Tarun Gupta
Sent: Thursday, March 11, 2021 3:20 AM
Document interfaces used for VFIO device migration. Added flow of state
changes
during live migration with VFIO device. Tested by building docs with the new
vfio-migration.rst file.
v2:
- Incl
Aaron Lindsay writes:
> On Mar 12 17:28, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée
>
> Small comment below, but otherwise:
>
> Reviewed-by: Aaron Lindsay
>
>> ---
>> include/qemu/qemu-plugin.h | 35 ---
>> 1 file changed, 28 insertions(+), 7 deletions(-
util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
their external symbols conflict. The linker happens to pick the
former. This links a bunch of unneeded code into the executables that
actually want the latter: qemu-io, qemu-img, qemu-nbd, and several
tests. Amazingly, none of t
I've based my work on Akihiko Odaki's previous patchset that introduced dynamic
refresh rate (see "Based-on" in the description).
Should I rebase it to master?
> On 16 Mar 2021, at 16:32, Gerd Hoffmann wrote:
>
> On Mon, Mar 15, 2021 at 02:46:37PM +0300, Konstantin Nazarov wrote:
>> The timing
On Mar 16 13:40, Alex Bennée wrote:
>
> Aaron Lindsay writes:
>
> > On Mar 12 17:28, Alex Bennée wrote:
> >> Also add a note to explain currently they are unused.
> >>
> >> Signed-off-by: Alex Bennée
> >
> > I'm personally interested in one clarification below, but don't think
> > that affects
On 3/16/21 8:59 AM, Markus Armbruster wrote:
> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
> their external symbols conflict. The linker happens to pick the
> former. This links a bunch of unneeded code into the executables that
> actually want the latter: qemu-io, qemu-im
On 3/16/21 8:59 AM, Markus Armbruster wrote:
> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
> their external symbols conflict. The linker happens to pick the
> former. This links a bunch of unneeded code into the executables that
> actually want the latter: qemu-io, qemu-im
On Mar 16 13:48, Alex Bennée wrote:
> Aaron Lindsay writes:
> > On Mar 12 17:28, Alex Bennée wrote:
> >> + * @insn: opaque instruction handle from qemu_plugin_tb_get_insn()
> >> + *
> >> + * Returns: hardware (physical) address of instruction
> >> + */
> >> void *qemu_plugin_insn_haddr(const stru
On Tue, 16 Mar 2021, Philippe Mathieu-Daudé wrote:
On 3/16/21 10:01 AM, Laurent Vivier wrote:
Le 15/03/2021 à 13:33, BALATON Zoltan a écrit :
On Sat, 13 Mar 2021, BALATON Zoltan wrote:
On Wed, 10 Mar 2021, BALATON Zoltan wrote:
Hello,
I've started posting this series well in advance to get
On Tue, Mar 16, 2021 at 05:01:50PM +0300, m...@knazarov.com wrote:
> I've based my work on Akihiko Odaki's previous patchset that introduced
> dynamic refresh rate (see "Based-on" in the description).
> Should I rebase it to master?
Not needed. Noticed that Based-on meanwhile, and applying in or
Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben:
> On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote:
> >
> > The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
> >
> > Merge remote-tracking branch
> > 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into stagi
Add helper function to find the next free desc block.
Needed when we start to use the dta descriptor entries.
Signed-off-by: Gerd Hoffmann
---
hw/display/edid-generate.c | 41 --
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/hw/display/edid-g
When the 4 descriptors in the base edid block are filled, jump to the
dta extension block. This allows for more than four descriptors.
Happens for example when generating an edid blob with a serial number
(qemu-edid -s $serial).
Signed-off-by: Gerd Hoffmann
---
hw/display/edid-generate.c | 8 ++
Initialize the "Established timings III" block earlier. Also move up
edid_fill_modes(). That'll make sure the offset for the additional
descriptors in the dta block don't move any more, which in turn makes it
easier to actually use them.
Signed-off-by: Gerd Hoffmann
---
hw/display/edid-generat
So we only write out that part of the edid blob
which has been filled with data.
Also use a larger buffer for the blob.
Signed-off-by: Gerd Hoffmann
---
qemu-edid.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qemu-edid.c b/qemu-edid.c
index 1cd6a9517238..c3a9fba10dc
Windows guests are not that happy with the edid blob we provide.
Tweak things a bit to make windows pick up more resolutions.
Also rebased all pending edid patches on top of that, so this
is the latest "all in one" patch series.
Akihiko Odaki (1):
edid: Make refresh rate configurable
Gerd Hoff
From: Akihiko Odaki
Signed-off-by: Akihiko Odaki
Signed-off-by: Gerd Hoffmann
---
include/hw/display/edid.h | 12 +++-
hw/display/edid-generate.c | 9 +
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
index
From: Konstantin Nazarov
The Detailed Timing Descriptor has only 12 bits to store the
resolution. This limits the guest to 4095 pixels.
This patch adds support for the DisplayID extension, that has 2 full
bytes for that purpose, thus allowing 5k resolutions and above.
Based-on: <20210303152948.
On Fri, Feb 12, 2021 at 10:32 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 11 +++
> target/riscv/insn32.decode | 11 +++
> target/riscv/insn_trans/trans_rvp.c.inc | 12 +++
> target/r
From: Konstantin Nazarov
Some of the EDID extensions like DisplayID do checksums of their
subsections. Currently checksums can be only applied to the whole
extension blocks which are 128 bytes.
This patch allows to checksum arbitrary parts of EDID, and not only
whole extension blocks.
Based-on:
On Fri, Feb 12, 2021 at 10:30 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 12 +++
> target/riscv/insn32.decode | 12 +++
> target/riscv/insn_trans/trans_rvp.c.inc | 13 +++
> target/r
Windows guests using the "Basic Display Adapter" don't parse the
"Established timings III" block. They also don't parse any edid
extension.
So prefer the "Standard Timings" block to store the display resolutions
in edid_fill_modes(). Also reorder the mode list, so more exotic
resolutions (specif
From: Konstantin Nazarov
The timing generation is currently performed inside the function that
fills in the DTD. The DisplayID generation needs it as well, so moving
it out to a separate function.
Based-on: <20210303152948.59943-2-akihiko.od...@gmail.com>
Signed-off-by: Konstantin Nazarov
Messa
On 3/15/21 1:06 AM, Roman Kagan wrote:
> The reconnection logic doesn't need to stop while in a drained section.
> Moreover it has to be active during the drained section, as the requests
> that were caught in-flight with the connection to the server broken can
> only usefully get drained if the co
Another arrempt to explain patch 1. This is the via-superio class that's a
subclass of ISA superio:
https://github.com/patchew-project/qemu/blob/ca5d88d2fee0016f939e91ae8b32c18e682064fa/hw/isa/vt82c686.c#L255
#define TYPE_VIA_SUPERIO "via-superio"
OBJECT_DECLARE_SIMPLE_TYPE(ViaSuperIOState, VIA
Hi Marc-André,
By looking into chardev and yank_register_function logic, this old chardev
is registered according to the chardev label.
So it's been in yank_instance_list. yank instance only has a chardev label,
and the new chardev's label is the same as the old chardev.
So it doesn't need to reg
On Fri, Feb 12, 2021 at 10:34 AM LIU Zhiwei wrote:
>
> Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/helper.h | 5 +++
> target/riscv/insn32.decode | 5 +++
> target/riscv/insn_trans/trans_rvp.c.inc | 9 +
> target/ri
Am 16.03.2021 um 15:35 hat Kevin Wolf geschrieben:
> Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben:
> > On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote:
> > >
> > > The following changes since commit
> > > 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
> > >
> > > Merge remote-tracking branch
On 3/15/21 5:37 PM, Roman Bolshakov wrote:
tcg_exec_init(s->tb_size * 1024 * 1024, s->splitwx_enabled);
mttcg_enabled = s->mttcg_enabled;
-
-/*
- * Initialize TCG regions only for softmmu.
- *
- * This needs to be done later for user mode, because the prologue
- *
When decode_insn16() fails, we fall back to decode_RV32_64C() for
further compressed instruction decoding. However, prior to this change,
we did not raise an illegal instruction exception, if decode_RV32_64C()
fails to decode the instruction. This means that we skipped illegal
compressed instructio
On 3/15/21 11:33 PM, Rebecca Cran wrote:
I noticed the following in tlbi_aa64_vae2is_write: it appears that when calling
tlbbits_for_regime the ARMMMUIdx values are swapped?
static void tlbi_aa64_vae2is_write(CPUARMState *env, const ARMCPRegInfo *ri,
uint64_t
On 3/16/21 1:04 PM, Bin Meng wrote:
> Add a helper to pad a short Ethernet frame to the minimum required
> length, which can be used by backend codes.
"backend codes" sounds odd but I'm not native English speaker.
I'd have used "backends' code" instead...
> Signed-off-by: Bin Meng
>
> ---
>
>
On 3/16/21 12:20 AM, Rebecca Cran wrote:
On 3/10/21 12:24 PM, Richard Henderson wrote:
On 3/9/21 6:29 PM, Rebecca Cran wrote:
+ uint64_t addr = (value & 0xFUL) << TARGET_PAGE_BITS;
The manual does not explicitly say, but I'm certain that this should be a
signed address, when reg
On 3/16/21 1:04 PM, Bin Meng wrote:
> The minimum Ethernet frame length is 60 bytes. For short frames with
> smaller length like ARP packets (only 42 bytes), on a real world NIC
> it can choose either padding its length to the minimum required 60
> bytes, or sending it out directly to the wire. Suc
On Tue, Mar 16, 2021 at 8:50 AM Jason Wang wrote:
>
>
> 在 2021/3/16 上午3:48, Eugenio Pérez 写道:
> > It reports the shadow virtqueue address from qemu virtual address space
>
>
> Note that to be used by vDPA, we can't use qemu VA directly here.
>
Right, I'm planning to use a different virtual addres
On 3/16/21 1:48 PM, Thomas Huth wrote:
> On 16/03/2021 13.41, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 3/16/21 11:26 AM, Philippe Mathieu-Daudé wrote:
On 3/16/21 10:02 AM, Philippe Mathieu-Daudé wrote:
> On 3/16/21 7:51 AM, Markus Armbruster wrote:
>> Eric
On 3/16/21 4:51 AM, Peter Maydell wrote:
On Mon, 15 Mar 2021 at 22:39, Philippe Mathieu-Daudé wrote:
Coverity reported (CID 1450831) an array overrun in
gen_mxu_D16MAX_D16MIN():
1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
1112 if (opc == OPC_MXU_D16MAX) {
Hi
On Tue, Mar 16, 2021 at 6:46 PM Li Zhang wrote:
> Hi Marc-André,
>
> By looking into chardev and yank_register_function logic, this old
> chardev is registered according to the chardev label.
> So it's been in yank_instance_list. yank instance only has a chardev
> label, and the new chardev'
Hi Peter,
On 3/16/21 1:03 PM, Philippe Mathieu-Daudé wrote:
> On 3/16/21 11:51 AM, Peter Maydell wrote:
>> On Mon, 15 Mar 2021 at 22:39, Philippe Mathieu-Daudé wrote:
>>>
>>> Coverity reported (CID 1450831) an array overrun in
>>> gen_mxu_D16MAX_D16MIN():
>>>
>>> 1103 } else if (unlikely((X
On Mon, Mar 15, 2021 at 06:40:12PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 15.03.2021 09:06, Roman Kagan wrote:
> > When the NBD connection is being torn down, the connection thread gets
> > canceled and "detached", meaning it is about to get freed.
> >
> > If this happens while the connectio
Hi Marc-André,
Hi Marc-André,
Ah, you are right. For some scenarios, it is not registered and registered
for some scenarios.
If the previous chardev is not socket, it won't be registered either.
There are still problems.
On Tue, Mar 16, 2021 at 4:25 PM Marc-André Lureau <
marcandre.lur...@gmail
Eric Blake writes:
> On 3/16/21 8:59 AM, Markus Armbruster wrote:
>> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
>> their external symbols conflict. The linker happens to pick the
>> former. This links a bunch of unneeded code into the executables that
>> actually want t
Eric Blake writes:
> On 3/16/21 8:59 AM, Markus Armbruster wrote:
>> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
>> their external symbols conflict. The linker happens to pick the
>> former. This links a bunch of unneeded code into the executables that
>> actually want t
+Craig
On 3/16/21 2:13 PM, Peter Maydell wrote:
> Coverity reported (CID 1450831) an array overrun in
> gen_mxu_D16MAX_D16MIN():
>
> 1103 } else if (unlikely((XRb == 0) || (XRa == 0))) {
>
> 1112 if (opc == OPC_MXU_D16MAX) {
> 1113 tcg_gen_smax_i32(mxu_gpr[XRa
(+Peter, comment below)
On 03/15/21 00:29, Philippe Mathieu-Daudé wrote:
> Restrict CPU I/O instructions to architectures providing
> I/O bus.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qtest/libqos/fw_cfg.h | 3 +++
> tests/qtest/libqos/fw_cfg.c | 2 ++
> 2 files changed, 5 insert
On 3/16/21 9:37 AM, Laszlo Ersek wrote:
(+Peter, comment below)
On 03/15/21 00:29, Philippe Mathieu-Daudé wrote:
Restrict CPU I/O instructions to architectures providing
I/O bus.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/libqos/fw_cfg.h | 3 +++
tests/qtest/libqos/fw_cfg.c | 2
Patchew URL:
https://patchew.org/QEMU/20210316143812.2363588-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210316143812.2363588-1-kra...@redhat.com
Subject: [PATCH 0/9] edid: windows fixes
===
* Tian, Kevin (kevin.t...@intel.com) wrote:
> > From: Qemu-devel
> > On Behalf Of Dr. David Alan Gilbert
> >
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > On Thu, Mar 11, 2021 at 12:50:09AM +0530, Tarun Gupta wrote:
> > > > Document interfaces used for VFIO device migration. Added f
ARMv8.4 adds the mandatory FEAT_TLBIRANGE. It provides TLBI
maintenance instructions that apply to a range of input addresses.
Signed-off-by: Rebecca Cran
---
accel/tcg/cputlb.c | 135 +
include/exec/exec-all.h | 45 +++
target/arm/cpu.h| 5 +
target/arm/helper.c | 31
Indicate support for FEAT_TLBIOS and FEAT_TLBIRANGE by setting
ID_AA64ISAR0.TLB to 2 for the max AARCH64 CPU type.
Signed-off-by: Rebecca Cran
Reviewed-by: Richard Henderson
---
target/arm/cpu64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index
ARMv8.4 adds the mandatory FEAT_TLBIOS. It provides TLBI
maintenance instructions that extend to the Outer Shareable domain.
Signed-off-by: Rebecca Cran
---
target/arm/cpu.h| 5 ++
target/arm/helper.c | 75
2 files changed, 80 insertions(+)
diff --git a/target/arm/cpu.
ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE.
They provides TLBI maintenance instructions that extend to the Outer
Shareable domain and that apply to a range of input addresses.
Changes from v3 to v4:
o Adapted code from the existing flush_page_bits_* functions to support
flushing
On 3/16/21 9:09 AM, Richard Henderson wrote:
On 3/16/21 12:20 AM, Rebecca Cran wrote:
On 3/10/21 12:24 PM, Richard Henderson wrote:
On 3/9/21 6:29 PM, Rebecca Cran wrote:
+ uint64_t addr = (value & 0xFUL) << TARGET_PAGE_BITS;
The manual does not explicitly say, but I'm certain t
On Mon, Mar 15, 2021 at 10:45:39PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 15.03.2021 09:06, Roman Kagan wrote:
> > The reconnection logic doesn't need to stop while in a drained section.
> > Moreover it has to be active during the drained section, as the requests
> > that were caught in-fligh
101 - 200 of 590 matches
Mail list logo