Re: [PATCH] qom: Support JSON in user_creatable_parse_str()

Recommend qom: Support JSON in HMP object_add and tools --object to put the most interesting bit right in "git-log --oneline". Kevin Wolf writes: > Support JSON for --object in all tools and in HMP object_add in the same > way as it is supported in qobject_input_visitor_new_str(). > > Sign

Re: [PATCH v3 22/30] qom: Factor out user_creatable_process_cmdline()

Kevin Wolf writes: > The implementation for --object can be shared between > qemu-storage-daemon and other binaries, so move it into a function in > qom/object_interfaces.c that is accessible from everywhere. > > This also requires moving the implementation of qmp_object_add() into a > new user_c

Re: [PATCH v3 22/30] qom: Factor out user_creatable_process_cmdline()

On 13/03/21 09:41, Markus Armbruster wrote: Observation, not objection: 1. QMP core parses JSON text into QObject, passes to generated marshaller. 2. Marshaller converts QObject to ObjectOptions with the QObject input visitor, passes to qmp_object_add(). 3. qmp_object_add() wraps aroun

Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

Paolo Bonzini writes: > Emulators are currently using OptsVisitor (via user_creatable_add_opts) > to parse the -object command line option. This has one extra feature, > compared to keyval, which is automatic conversion of integers to lists > as well as support for lists as repeated options: > >

Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

On 13/03/21 10:35, Markus Armbruster wrote: +object_option_foreach_add(object_create_late, &error_fatal); Likewise. Before and after the patch, object_create_late(opt) == !object_create_early(opt). Your patch provides us with an opportunity to assert this: object_opts must be empty now. S

Re: [PATCH 3/3] vl: allow passing JSON to -object

Paolo Bonzini writes: > Extend the ObjectOption code that was added in the previous patch to > enable passing JSON to -object. Even though we cannot yet add > non-scalar properties with the human-friendly comma-separated syntax, > they can now be added as JSON. > > Signed-off-by: Paolo Bonzini

[PULL 0/5] Linux user for 6.0 patches

x-user-for-6.0-pull-request for you to fetch changes up to 0266e8e3b3981b492e82be20bb97e8ed9792ed00: linux-user/elfload: fix address calculation in fallback scenario (2021-03-1= 3 10:45:11 +0100) linux-user pull request 20210313 - f

[PULL 4/5] linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support

From: Vincent Fazio Previously, pgd_find_hole_fallback assumed that if the build host's libc had MAP_FIXED_NOREPLACE defined that the address returned by mmap would match the requested address. This is not a safe assumption for Linux kernels prior to 4.17 Now, we always compare mmap's resultant

[PULL 3/5] linux-user/elfload: munmap proper address in pgd_find_hole_fallback

From: Vincent Fazio Previously, if the build host's libc did not define MAP_FIXED_NOREPLACE or if the running kernel didn't support that flag, it was possible for pgd_find_hole_fallback to munmap an incorrect address which could lead to SIGSEGV if the range happened to overlap with the mapped add

[PULL 5/5] linux-user/elfload: fix address calculation in fallback scenario

From: Vincent Fazio Previously, guest_loaddr was not taken into account when returning an address from pgb_find_hole when /proc/self/maps was unavailable which caused an improper guest_base address to be calculated. This could cause a SIGSEGV later in load_elf_image -> target_mmap for ET_EXEC ty

[PULL 2/5] linux-user: manage binfmt-misc preserve-arg[0] flag

Add --preserve-argv0 in qemu-binfmt-conf.sh to configure the preserve-argv0 flag. This patch allows to use new flag in AT_FLAGS to detect if preserve-argv0 is configured for this interpreter: argv[0] (the full pathname provided by binfmt-misc) is removed and replaced by argv[1] (the original argv[

[PULL 1/5] linux-user: Fix executable page of /proc/self/maps

From: Nicolas Surbayrole The guest binary and libraries are not always map with the executable bit in the host process. The guest may read a /proc/self/maps with no executable address range. The perm fields should be based on the guest permission inside Qemu. Signed-off-by: Nicolas Surbayrole R

Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

One more little thing... Paolo Bonzini writes: > Emulators are currently using OptsVisitor (via user_creatable_add_opts) > to parse the -object command line option. This has one extra feature, > compared to keyval, which is automatic conversion of integers to lists > as well as support for list

Re: [PULL 0/5] Linux user for 6.0 patches

Patchew URL: https://patchew.org/QEMU/20210313094747.2966948-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210313094747.2966948-1-laur...@vivier.eu Subject: [PULL 0/5] Linux user for 6.0 patches

Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

I will use ObjectOptionsQueue like the typedef just above. Paolo Il sab 13 mar 2021, 10:57 Markus Armbruster ha scritto: > One more little thing... > > Paolo Bonzini writes: > > > Emulators are currently using OptsVisitor (via user_creatable_add_opts) > > to parse the -object command line opt

Re: [PATCH v8 0/5] m68k: add Virtual M68k Machine

On 3/12/21 10:41 PM, Laurent Vivier wrote: > The Quadra 800 machine is very limited to run linux, it manages > only 1 GiB of memory and only some specific interfaces. > > The Virtual M68k Machine is based on Goldfish interfaces defined by Google > for Android simulator. It uses Goldfish-rtc (timer

Re: [PATCH 5/5] memory: Make sure root MR won't be added as subregion

Hi Peter, On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: > From: Peter Xu > > Add a bool for MR to mark whether this MR is a root MR of an AS. We bail out > asap if this MR is added as a subregion of another MR. > > Signed-off-by: Peter Xu > --- > include/exec/memory.h | 1 + > softmmu/me

Re: gitlab outage?

On 3/13/21 12:59 AM, Brian Cain wrote: > https://gitlab.com/qemu-project/ asks > for sign in and if I do sign in, I get a 404.  Is this expected? Confirmed: $ git clone https://gitlab.com/qemu-project/qemu.git Cloning into 'qemu'... Username for 'https://gitlab.

Re: gitlab outage?

The site works for me when logged in, and the members of the project are alright, but I also cannot clone or fetch. Paolo Il sab 13 mar 2021, 12:23 Philippe Mathieu-Daudé ha scritto: > On 3/13/21 12:59 AM, Brian Cain wrote: > > https://gitlab.com/qemu-project/

[Bug 1919021] [NEW] Confuse error message in virtio_init_region_cache()

Public bug reported: The error message added in commit e45da653223 to virtio_init_region_cache() are somehow confuse: qemu-system-i386: Cannot map used It would be helpful to more explicit string, including "virtio" prefix. ** Affects: qemu Importance: Undecided Status: New --

Re: gitlab outage?

On 3/13/21 12:35 PM, Paolo Bonzini wrote: > The site works for me when logged in, and the members of the project are > alright, but I also cannot clone or fetch. I don't think we want to update all automated scripts to use credentials and enforce all users to have a Gitlab account ;) Can we go ba

Re: gitlab outage?

I wasn't saying it was intentional. It's fixed now. Paolo Il sab 13 mar 2021, 12:58 Philippe Mathieu-Daudé ha scritto: > On 3/13/21 12:35 PM, Paolo Bonzini wrote: > > The site works for me when logged in, and the members of the project are > > alright, but I also cannot clone or fetch. > > I do

Re: [PATCH] edid: add support for DisplayID extension (5k resolution)

The logic looks good to me. I have a few style nitpicks. 2021年3月13日(土) 19:45 Konstantin Nazarov : > +struct timings { > +uint32_t xfront; > +uint32_t xsync; > +uint32_t xblank; > + > +uint32_t yfront; > +uint32_t ysync; > +uint32_t yblank; > + > +uint64_t clock; > +};

Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

Incorrect subject prefix, should be "hw/ssi/aspeed_smc" On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote: > The flash mmio region is exposed as an AddressSpace. > AddressSpaces must not be sysbus-mapped, therefore map > the region using an alias. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: gitlab outage?

On 3/13/21 1:02 PM, Paolo Bonzini wrote: > I wasn't saying it was intentional. It's fixed now. Yes, thank you. > > Paolo > > Il sab 13 mar 2021, 12:58 Philippe Mathieu-Daudé > ha scritto: > > On 3/13/21 12:35 PM, Paolo Bonzini wrote: > > The site works for me w

Re: [PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

Paolo Bonzini writes: > On 13/03/21 08:40, Markus Armbruster wrote: >>> +if (!user_creatable_add_from_str(optarg, &local_err)) { >>> +if (local_err) { >>> +error_report_err(local_err); >>> +exit(2); >>> +

Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it

Paolo Bonzini writes: > On 13/03/21 10:35, Markus Armbruster wrote: >>> +object_option_foreach_add(object_create_late, &error_fatal); >> Likewise. >> >> Before and after the patch, object_create_late(opt) == >> !object_create_early(opt). Your patch provides us with an opportunity >> to asse

[PATCH] edid: add support for DisplayID extension (5k resolution)

The Detailed Timing Descriptor has only 12 bits to store the resolution. This limits the guest to 4095 pixels. This patch adds support for the DisplayID extension, that has 2 full bytes for that purpose, thus allowing 5k resolutions and above. Based-on: <20210303152948.59943-2-akihiko.od...@gmail

Re: [PATCH v7 0/8] Pegasos2 emulation

On Wed, 10 Mar 2021, BALATON Zoltan wrote: Hello, I've started posting this series well in advance to get it into 6.0 and yet it seems like it may be missing it due to organisational issues (no real complaints were found with patches but Philippe seems to like more review that does not seem

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

Kevin Wolf writes: > This switches the HMP command object_add from a QemuOpts-based parser to > user_creatable_add_from_str() which uses a keyval parser and enforces > the QAPI schema. > > Apart from being a cleanup, this makes non-scalar properties and help > accessible. In order for help to be

Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

Markus Armbruster writes: > Paolo Bonzini writes: > >> On 11/03/21 15:08, Markus Armbruster wrote: I would rather keep the OptsVisitor here. Do the same check for JSON syntax that you have in qobject_input_visitor_new_str, and whenever you need to walk all -object arguments, use

Re: [RFC PATCH v2 10/22] target/mips/tx79: Introduce PSUB* opcodes (Parallel Subtract)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Introduce the 'Parallel Subtract' opcodes: - PSUBB (Parallel Subtract Byte) - PSUBH (Parallel Subtract Halfword) - PSUBW (Parallel Subtract Word) Signed-off-by: Philippe Mathieu-Daudé --- v2: Uses tcg_gen_vec_sub{8,16,32}_i64 from tcg/tcg-o

Re: [RFC PATCH v2 11/22] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Introduce the PEXTUW opcode (Parallel Extend Upper from Word). Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH V2] block: increased maximum size of vvfat devices

On Tue, Sep 11, 2018 at 7:22 PM аркадий иванов wrote: > > Ping? I'm afraid your patch has fallen through the cracks... Can you rebase and repost? > > Thu, 23 Aug. 2018 at 16:37, Arkasha : > > > This fixes the problem of the impossibility to create > > FAT16 disks larger than 504 mb: > > The chan

Re: [RFC PATCH v2 12/22] target/mips/tx79: Introduce PEXTL[BHW] opcodes (Parallel Extend Lower)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Introduce the 'Parallel Extend Lower' opcodes: - PEXTLB (Parallel Extend Upper from Byte) - PEXTLH (Parallel Extend Upper from Halfword) - PEXTLW (Parallel Extend Upper from Word) Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Ric

Re: [RFC PATCH v2 13/22] target/mips/tx79: Introduce PCEQ* opcodes (Parallel Compare for Equal)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Introduce the 'Parallel Compare for Equal' opcodes: - PCEQB (Parallel Compare for Equal Byte) - PCEQH (Parallel Compare for Equal Halfword) - PCEQW (Parallel Compare for Equal Word) Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: R

Re: [RFC PATCH v2 14/22] target/mips/tx79: Introduce PCGT* (Parallel Compare for Greater Than)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Introduce the 'Parallel Compare for Greater Than' opcodes: - PCGTB (Parallel Compare for Greater Than Byte) - PCGTH (Parallel Compare for Greater Than Halfword) - PCGTW (Parallel Compare for Greater Than Word) Signed-off-by: Philippe Mathie

Re: [RFC PATCH v2 16/22] target/mips/tx79: Introduce PINTEH (Parallel Interleave Even Halfword)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: +tcg_gen_shli_i64(x, a, 8); +tcg_gen_and_i64(x, x, mask); I think these two lines need switching? +tcg_gen_and_i64(y, b, mask); +tcg_gen_or_i64(d, x, y); r~

Re: [RFC PATCH v2 17/22] target/mips/tx79: Introduce PEXE[HW] opcodes (Parallel Exchange Even)

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: +tcg_gen_mov_i64(ax, cpu_gpr[a->rt]); +if (a->rd != a->rt) { +tcg_gen_mov_i64(cpu_gpr[a->rd], cpu_gpr[a->rt]); +} tcg_gen_mov will perform this test. +if (a->rt == 0) { +tcg_gen_movi_i64(cpu_gpr[a->rd], 0); +

Re: [PATCH v3 27/30] hmp: QAPIfy object_add

On 13/03/21 14:28, Markus Armbruster wrote: Kevin Wolf writes: This switches the HMP command object_add from a QemuOpts-based parser to user_creatable_add_from_str() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties and help

Re: [PATCH 3/3] avr/arduino: Add D13 LED

On 3/11/21 2:55 PM, G S Niteesh Babu wrote: > Signed-off-by: G S Niteesh Babu > --- > hw/avr/Kconfig | 1 + > hw/avr/arduino.c | 15 +++ > 2 files changed, 16 insertions(+) > > diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig > index 16a57ced11..e0d4fc5537 100644 > --- a/hw/avr/Kconfi

Re: [RFC PATCH v2 21/22] target/mips/tx79: Move RDHWR usermode kludge to trans_SQ()

On 3/9/21 8:56 AM, Philippe Mathieu-Daudé wrote: Now than SQ is properly implemented, we can move the RDHWR kludge required to have usermode working with recent glibc. Signed-off-by: Philippe Mathieu-Daudé --- v2: { RDHWR_user } (rth) --- target/mips/tx79.decode | 5 +++- target/mips/tr

Re: [PATCH 2/3] hw/gpio/avr_gpio.c: add tracing for read and writes

On 3/11/21 2:55 PM, G S Niteesh Babu wrote: > Added tracing for gpio read, write, and update output irq. > > 1) trace_avr_gpio_update_ouput_irq > 2) trace_avr_gpio_read > 3) trace_avr_gpio_write > > Signed-off-by: G S Niteesh Babu > --- > hw/gpio/avr_gpio.c | 16 > hw/gpio/tr

Re: [PATCH 16/26] tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h

On 3/10/21 6:42 PM, BALATON Zoltan wrote: -/* Minimum size of the code gen buffer.  This number is randomly chosen, -   but not so small that we can't have a fair number of TB's live.  */ +/* + * Minimum size of the code gen buffer.  This number is randomly chosen, + * but not so small that we ca

[PATCH 0/9] Replacing malloc and the like with GLib's variants

Inspired by the task in the Bite-sized tasks page, I've tried to change some of the occurrences of malloc(), calloc(), and realloc() calls and their respective free() calls. I also included some minor style improvements that caused errors and warnings when supplied to the checkpatch.pl script. At

[PATCH 1/9] bsd-user/elfload.c: Replaced calls to malloc/free with GLib variants

Replaced the calls to malloc(), realloc(), and free() to their equivalents in GLib's allocation functions in various places. Signed-off-by: Mahmoud Mandour --- bsd-user/elfload.c | 74 +++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/

[PATCH 8/9] tools/virtiofsd/fuse_opt.c: Replaced a malloc with GLib's g_try_malloc

Replaced a malloc() call and its respective free() with GLib's g_try_malloc() and g_free() calls. Signed-off-by: Mahmoud Mandour --- tools/virtiofsd/fuse_opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/fuse_opt.c b/tools/virtiofsd/fuse_opt.c index f0

[PATCH 2/9] hw/audio/fmopl.c: Fixing some style errors.

Fixed style errors on the relevant lines in which I will introduce changes. Signed-off-by: Mahmoud Mandour --- hw/audio/fmopl.c | 52 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 8a71a56

[PATCH 6/9] util/compatfd.c: Replaced a malloc with GLib's g_try_malloc

Replaced a malloc() call and its respective free() call with GLib's g_try_malloc() and g_free(). Also, did slight styling changes that were producing errors using the checkpatch.pl script. Signed-off-by: Mahmoud Mandour --- util/compatfd.c | 10 +- 1 file changed, 5 insertions(+), 5 dele

[PATCH 3/9] hw/audio/fmopl.c: Replaced calls to malloc with GLib's variants

Replaced calls to malloc(), and free() to their equivalent allocation functions from GLib. Also added checking for null after ENV_CURVE allocation following the same pattern of checking on preceeding table allocations. Signed-off-by: Mahmoud Mandour --- hw/audio/fmopl.c | 41 +++

[PATCH 7/9] tools/virtiofsd/buffer.c: replaced a calloc call with GLib's g_try_new0

Replaced a call to calloc() and its respective free() call with GLib's g_try_new0() and g_free() calls. Signed-off-by: Mahmoud Mandour --- tools/virtiofsd/buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/buffer.c b/tools/virtiofsd/buffer.c index 87

[PATCH 4/9] pc-bios/s390-ccw/netmain.c: Changed a malloc/free to GLib's variants

Changed a call to malloc() and its respective calls free() with GLib's allocation and deallocation functions. Signed-off-by: Mahmoud Mandour --- pc-bios/s390-ccw/netmain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netm

[PATCH 5/9] target/xtensa: Replaced malloc/free with GLib's variants.

Replaced the calls to malloc() and their respective calls to free() with GLib's allocation and deallocation functions. Signed-off-by: Mahmoud Mandour --- target/xtensa/xtensa-isa.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/xtensa/xt

[PATCH 9/9] tools/virtiofsd: Replacing malloc-like calls with GLib's variants

Changed calls to malloc(), calloc(), and realloc() with their equivalent allocation functions in GLib, and replaced their respective free() calls with g_free(). Allocation and deallocation of fuse_req structs, fuse_pollhandle structs, fuse_session structs and many local variables are now establish

[PATCH 00/11] AVR patch queue for QEMU 6.0

Hi, This series contains all the AVR patches I could find on the list. Niteesh, I fixed minor issues. Do you mind reviewing on top? Pull request planned for Monday if no problem arises. Thanks, Phil. G S Niteesh Babu (2): hw/gpio/avr_gpio: Add tracing for reads and writes hw/avr/arduino:

[PATCH 01/11] hw/misc/led: Add yellow LED

Add the yellow "lime" LED. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/led.h | 1 + hw/misc/led.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/hw/misc/led.h b/include/hw/misc/led.h index aa359b87c20..29c08795708 100644 --- a/include/hw/misc/led.h +++ b/incl

[PATCH 09/11] hw/avr/arduino: Replace magic number by gpio_port_index() call

The '1' magic value means 'Port B'. Introduce and use the gpio_port_index() helper to explicit the port name. Signed-off-by: Philippe Mathieu-Daudé --- hw/avr/arduino.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/avr/arduino.c b/hw/avr/arduino.c index 73563a35d0

[PATCH 02/11] hw/avr/arduino: List board schematic links

Signed-off-by: Philippe Mathieu-Daudé --- hw/avr/arduino.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/avr/arduino.c b/hw/avr/arduino.c index 3c8388490d6..3ff31492fa6 100644 --- a/hw/avr/arduino.c +++ b/hw/avr/arduino.c @@ -75,7 +75,10 @@ static vo

Re: [PATCH 0/9] Replacing malloc and the like with GLib's variants

Patchew URL: https://patchew.org/QEMU/20210313163653.37089-1-ma.mando...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210313163653.37089-1-ma.mando...@gmail.com Subject: [PATCH 0/9] Replacing malloc and

[PATCH 10/11] target/avr: Fix some comment spelling errors

From: Lichang Zhao I found that there are many spelling errors in the comments of qemu/target/avr. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: Lichang Zhao Reviewed-by: David Edmondson Reviewed-by: Philippe Mathieu-Daude Message-Id: <2020

[PATCH 07/11] hw/gpio/avr_gpio: Add tracing for reads and writes

From: G S Niteesh Babu Added tracing for gpio read, write, and update output irq. 1) trace_avr_gpio_update_ouput_irq 2) trace_avr_gpio_read 3) trace_avr_gpio_write Signed-off-by: G S Niteesh Babu Reviewed-by: Michael Rolnik Message-Id: <20210311135539.10206-3-niteesh...@gmail.com> [PMD: Added

[PATCH 03/11] hw/avr: Add limited support for avr gpio registers

From: Heecheol Yang Add some of these features for AVR GPIO: - GPIO I/O : PORTx registers - Data Direction : DDRx registers - DDRx toggling : PINx registers Following things are not supported yet: - MCUR registers Signed-off-by: Heecheol Yang Reviewed-by: Michael Rolnik Message-Id:

[PATCH 11/11] target/avr: Fix interrupt execution

From: Ivanov Arkasha Only one interrupt is in progress at the moment. It is only necessary to set to reset interrupt_request after all interrupts have been executed. Signed-off-by: Ivanov Arkasha Message-Id: <20210312164754.18437-1-arkaisp2...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé -

[PATCH 04/11] hw/gpio/avr_gpio: Add migration VMstate

Signed-off-by: Philippe Mathieu-Daudé --- hw/gpio/avr_gpio.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/gpio/avr_gpio.c b/hw/gpio/avr_gpio.c index cdb574ef0d8..da34009daea 100644 --- a/hw/gpio/avr_gpio.c +++ b/hw/gpio/avr_gpio.c @@ -25,6 +25,7 @@ #include "hw/irq.h"

Re: [PATCH 08/11] hw/avr/arduino: Add D13 LED

Hii Phil, Just a few mins earlier than me :) Thanks, Niteesh On Sat, Mar 13, 2021 at 10:25 PM Philippe Mathieu-Daudé wrote: > From: G S Niteesh Babu > > Signed-off-by: G S Niteesh Babu > Reviewed-by: Michael Rolnik > Message-Id: <20210311135539.10206-4-niteesh...@gmail.com> > [PMD: Added Ar

[PATCH 05/11] hw/gpio/avr_gpio: Add 'id' field in AVRGPIOState

AVR MCU have various GPIO ports. Add an 'id' property to distinct all instances. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/gpio/avr_gpio.h | 1 + hw/avr/atmega.c| 1 + hw/gpio/avr_gpio.c | 14 -- 3 files changed, 14 insertions(+), 2 deletions(-) diff

[PATCH 06/11] hw/gpio/avr_gpio: Simplify avr_gpio_write_port using extract32()

Signed-off-by: Philippe Mathieu-Daudé --- hw/gpio/avr_gpio.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/gpio/avr_gpio.c b/hw/gpio/avr_gpio.c index 3db55bfa77f..e4c7122e62c 100644 --- a/hw/gpio/avr_gpio.c +++ b/hw/gpio/avr_gpio.c @@ -39,20 +39,15 @@ static v

[PATCH 1/3] hw/arm: Constify VMStateDescription

Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/highbank.c | 2 +- hw/arm/pxa2xx_pic.c | 2 +- hw/arm/spitz.c | 4 ++-- hw/arm/strongarm.c | 2 +- hw/arm/z2.c | 4 ++-- hw/dma/pxa2xx_dma.c | 4 ++-- hw/misc/mst_fpga.c | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) d

[PATCH 0/3] hw: Constify VMStateDescription

VMStateDescription isn't supposed to be modified. Philippe Mathieu-Daudé (3): hw/arm: Constify VMStateDescription hw/display/qxl: Constify VMStateDescription hw/usb: Constify VMStateDescription hw/arm/highbank.c | 2 +- hw/arm/pxa2xx_pic.c | 2 +- hw/arm/spitz.c

[PATCH 2/3] hw/display/qxl: Constify VMStateDescription

Signed-off-by: Philippe Mathieu-Daudé --- hw/display/qxl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 93907e82a33..2ba75637ec3 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -2384,7 +2384,7 @@ static bool qxl_moni

[PATCH 08/11] hw/avr/arduino: Add D13 LED

From: G S Niteesh Babu Signed-off-by: G S Niteesh Babu Reviewed-by: Michael Rolnik Message-Id: <20210311135539.10206-4-niteesh...@gmail.com> [PMD: Added ArduinoMachineClass::d13_led_portb_bit] Signed-off-by: Philippe Mathieu-Daudé --- hw/avr/arduino.c | 18 ++ hw/avr/Kconfig

[PATCH 3/3] hw/usb: Constify VMStateDescription

Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/dev-smartcard-reader.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c index c1a90fcc7a5..7212d0d7fb5 100644 --- a/hw/usb/c

Re: [PATCH 0/2] MAINTAINERS: Mark Renesas hardware emulation orphan

On 3/12/21 9:55 AM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (2): MAINTAINERS: Mark RX hardware emulation orphan MAINTAINERS: Mark SH-4 hardware emulation orphan Acked-by: Richard Henderson r~

Re: [PATCH 07/11] hw/gpio/avr_gpio: Add tracing for reads and writes

Reviewed-by: Niteesh G S On Sat, Mar 13, 2021 at 10:25 PM Philippe Mathieu-Daudé wrote: > From: G S Niteesh Babu > > Added tracing for gpio read, write, and update output irq. > > 1) trace_avr_gpio_update_ouput_irq > 2) trace_avr_gpio_read > 3) trace_avr_gpio_write > > Signed-off-by: G S Nitee

[PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize()

When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/bcm2835_fb.c | 2

Re: [PATCH 0/3] hw: Constify VMStateDescription

On 3/13/21 11:11 AM, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (3): hw/arm: Constify VMStateDescription hw/display/qxl: Constify VMStateDescription hw/usb: Constify VMStateDescription Reviewed-by: Richard Henderson r~

Re: [PATCH 08/11] hw/avr/arduino: Add D13 LED

Reviewed-by: Niteesh G S On Sat, Mar 13, 2021 at 10:32 PM Niteesh G. S. wrote: > Hii Phil, > > Just a few mins earlier than me :) > > Thanks, > Niteesh > > On Sat, Mar 13, 2021 at 10:25 PM Philippe Mathieu-Daudé > wrote: > >> From: G S Niteesh Babu >> >> Signed-off-by: G S Niteesh Babu >> Re

[Bug 1919035] [NEW] Assertion failure in fifo8_pop_buf() through am53c974

Public bug reported: Hello, Using hypervisor fuzzer, hyfuzz, I found an assertion failure through am53c974 emulator. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master, 3f8d1885e4)

Re: [PATCH 02/26] meson: Move disas/tci.c to disas/meson.build

On 3/11/21 1:21 AM, Richard Henderson wrote: > There's no reason to do this in the main meson.build. > > Signed-off-by: Richard Henderson > --- > meson.build | 1 - > disas/meson.build | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 01/26] meson: Split out tcg/meson.build

On 3/11/21 1:21 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > meson.build | 9 ++--- > tcg/meson.build | 13 + > 2 files changed, 15 insertions(+), 7 deletions(-) > create mode 100644 tcg/meson.build Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 05/26] tcg: Remove error return from tcg_region_initial_alloc__locked

On 3/11/21 1:21 AM, Richard Henderson wrote: > All callers immediately assert on error, so move the assert > into the function itself. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 19 ++- > 1 file changed, 6 insertions(+), 13 deletions(-) Reviewed-by: Philippe Mathie

Re: [PATCH 09/26] accel/tcg: Inline cpu_gen_init

On 3/11/21 1:21 AM, Richard Henderson wrote: > It consists of one function call and has only one caller. > > Signed-off-by: Richard Henderson > --- > accel/tcg/translate-all.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 03/26] meson: Split out fpu/meson.build

On 3/11/21 1:21 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > meson.build | 4 +--- > fpu/meson.build | 1 + > 2 files changed, 2 insertions(+), 3 deletions(-) > create mode 100644 fpu/meson.build Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/26] accel/tcg: Rename tcg_init to tcg_init_machine

On 3/11/21 1:21 AM, Richard Henderson wrote: > We shortly want to use tcg_init for something else. > Since the hook is called init_machine, match that. > > Signed-off-by: Richard Henderson > --- > accel/tcg/tcg-all.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Phili

Re: [PATCH 14/26] accel/tcg: Pass down max_cpus to tcg_init

On 3/11/21 1:21 AM, Richard Henderson wrote: > Start removing the include of hw/boards.h from tcg/. > Pass down the max_cpus value from tcg_init_machine, > where we have the MachineState already. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 2 +- > tcg/internal.h | 2

Re: [PATCH 15/26] tcg: Introduce tcg_max_ctxs

On 3/11/21 1:21 AM, Richard Henderson wrote: > Finish the divorce of tcg/ from hw/, and do not take > the max cpu value from MachineState; just rememver what Typo "remember" > we were passed in tcg_init. > > Signed-off-by: Richard Henderson > --- > tcg/internal.h | 3 ++- > tcg/region.c |

Re: [PATCH 24/26] util/osdep: Add qemu_mprotect_rw

On 3/11/21 1:21 AM, Richard Henderson wrote: > For --enable-tcg-interpreter on Windows, we will need this. > > Signed-off-by: Richard Henderson > --- > include/qemu/osdep.h | 1 + > util/osdep.c | 9 + > 2 files changed, 10 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[Bug 1919036] [NEW] Assertion failure in fifo8_push_all() through am53c974

Public bug reported: Hello, Using hypervisor fuzzer, hyfuzz, I found an assertion failure through am53c974 emulator. A malicious guest user/process could use this flaw to abort the QEMU process on the host, resulting in a denial of service. This was found in version 5.2.0 (master, 3f8d1885e4)

KVM guest physical address and its corresponding host virtual address

Hi all, I'm a student and I'm new to QEMU and virtualization. I would like to locate the Interrupt Descriptor Table of the guest from the host and so I want to obtain a host virtual address pointing to it. I don't know if I've found the right way to do that, but till now I'm doing like this from t

[Bug 1846816] Re: Booting error on AIX 6.1 "Illegal Trap Instruction Interrupt in Kernel""

I saw comments about support for virtio devices on AIX 7.2, was it not available on AIX 7.1? With AIX 7.1 also, I am getting similar issue as faced by other users with AIX 6.1. qemu-system-ppc64 -cpu POWER8 -machine pseries -m 2048 -d unimp -serial stdio -drive file=disk.img,if=none,id=drive-v

Re: [PATCH 02/26] meson: Move disas/tci.c to disas/meson.build

On 3/10/21 6:21 PM, Richard Henderson wrote: There's no reason to do this in the main meson.build. Signed-off-by: Richard Henderson --- meson.build | 1 - disas/meson.build | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) I'm going to drop this one because it conflicts with th

Re: [PATCH 10/26] accel/tcg: Move alloc_code_gen_buffer to tcg/region.c

On 3/10/21 6:21 PM, Richard Henderson wrote: Buffer management is integral to tcg. Do not leave the allocation to code outside of tcg/. This is code movement, with further cleanups to follow. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 2 +- accel/tcg/translate-all.c

Re: [PATCH 4/9] pc-bios/s390-ccw/netmain.c: Changed a malloc/free to GLib's variants

On 13.03.21 17:36, Mahmoud Mandour wrote: Changed a call to malloc() and its respective calls free() with GLib's allocation and deallocation functions. Signed-off-by: Mahmoud Mandour Nack. This is BIOS code and it does not have glib. --- pc-bios/s390-ccw/netmain.c | 6 +++--- 1 file ch

Re: [PATCH for-6.0 2/2] target/arm: Make M-profile VTOR loads on reset handle memory aliasing

On 3/12/21 2:17 PM, Philippe Mathieu-Daudé wrote: +static int find_rom_cb(Int128 start, Int128 len, const MemoryRegion *mr, + hwaddr offset_in_region, void *opaque) Return bool maybe? Yes, it might be worth changing with the first patch, while we're changing all (one) u

Re: [PATCH for-6.0 0/2] arm: Make M-profile VTOR loads on reset handle memory aliasing

On 3/12/21 12:59 PM, Peter Maydell wrote: On Fri, 12 Mar 2021 at 17:29, Peter Maydell wrote: This series handles the possibility of aliasing by iterating through the whole FlatView of the CPU's address space checking for other mappings of the MemoryRegion corresponding to the location of the ve

Re: [PATCH 12/26] tcg: Create tcg_init

On 3/11/21 1:21 AM, Richard Henderson wrote: > Perform both tcg_context_init and tcg_region_init. > Do not leave this split to the caller. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 3 +-- > tcg/internal.h| 1 + > accel/tcg/translate-all.c | 3 +-- > tcg

Re: [PATCH for-6.0 0/2] arm: Make M-profile VTOR loads on reset handle memory aliasing

On Sat, 13 Mar 2021 at 19:05, Richard Henderson wrote: > > On 3/12/21 12:59 PM, Peter Maydell wrote: > > On Fri, 12 Mar 2021 at 17:29, Peter Maydell > > wrote: > >> This series handles the possibility of aliasing by iterating through > >> the whole FlatView of the CPU's address space checking fo

Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize()

On 3/13/21 11:01 AM, Philippe Mathieu-Daudé wrote: When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Phil

Re: [PATCH 12/26] tcg: Create tcg_init

On 3/13/21 1:27 PM, Philippe Mathieu-Daudé wrote: On 3/11/21 1:21 AM, Richard Henderson wrote: Perform both tcg_context_init and tcg_region_init. Do not leave this split to the caller. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 3 +-- tcg/internal.h| 1 +

[PULL 03/27] hw/mips/gt64xxx: Fix typos in qemu_log_mask() formats

Fix the following typos: - GT_PCI1_CFGDATA is not a timer register but a PCI one, - zero-padding flag is out of the format Fixes: 641ca2bfcd5 ("hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Message-Id: <202

  1   2   >