Re: [PATCH v4] ui/cocoa: Use kCGColorSpaceSRGB

On Fri, Mar 05, 2021 at 09:13:04PM +0900, Akihiko Odaki wrote: > kCGColorSpaceGenericRGB | Apple Developer Documentation > https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb > > Deprecated > > Use kCGColorSpaceSRGB instead. > > This change also removes the legacy color

Re: [PATCH v2 2/4] block: check for sys/disk.h

On Tue, 9 Mar 2021 at 00:31, Joelle van Dyne wrote: > > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

On Tue, 9 Mar 2021 at 00:30, Joelle van Dyne wrote: > > iOS hosts do not have these defined so we fallback to the > default behaviour. > > Co-authored-by: Warner Losh > Signed-off-by: Joelle van Dyne > --- > block/file-posix.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 delet

[PULL v2 02/38] hw/block/nvme: support to map controller to a subsystem

From: Minwoo Im nvme controller(nvme) can be mapped to a NVMe subsystem(nvme-subsys). This patch maps a controller to a subsystem by adding a parameter 'subsys' to the nvme device. To map a controller to a subsystem, we need to put nvme-subsys first and then maps the subsystem to the controller:

[PULL v2 03/38] hw/block/nvme: add CMIC enum value for Identify Controller

From: Minwoo Im Added Controller Multi-path I/O and Namespace Sharing Capabilities (CMIC) field to support multi-controller in the following patches. This field is in Identify Controller data structure in [76]. Signed-off-by: Minwoo Im Tested-by: Klaus Jensen Reviewed-by: Klaus Jensen Review

[PULL v2 06/38] hw/block/nvme: support for shared namespace in subsystem

From: Minwoo Im nvme-ns device is registered to a nvme controller device during the initialization in nvme_register_namespace() in case that 'bus' property is given which means it's mapped to a single controller. This patch introduced a new property 'subsys' just like the controller device insta

[PULL v2 01/38] hw/block/nvme: introduce nvme-subsys device

From: Minwoo Im To support multi-path in QEMU NVMe device model, We need to have NVMe subsystem hierarchy to map controllers and namespaces to a NVMe subsystem. This patch introduced a simple nvme-subsys device model. The subsystem will be prepared with subsystem NQN with provided in nvme-subs

[PULL v2 07/38] hw/block/nvme: remove unused parameter in check zone write

From: Klaus Jensen Remove the unused NvmeCtrl parameter in nvme_check_zone_write. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 5e0819fd9e1c..f39be1961

[PULL v2 00/38] emulated nvme device updates

From: Klaus Jensen The following changes since commit 229a834518b950d56fd1bc94923276504d0ee9d4: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20210306' into staging (2021-03-08 15:45:48 +) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git

[PULL v2 08/38] hw/block/nvme: refactor zone resource management

From: Klaus Jensen Zone transition handling and resource management is open coded (and semi-duplicated in the case of open, close and finish). In preparation for Simple Copy command support (which also needs to open zones for writing), consolidate into a set of 'nvme_zrm' functions and in the pr

[PULL v2 09/38] hw/block/nvme: pull write pointer advancement to separate function

From: Klaus Jensen In preparation for Simple Copy, pull write pointer advancement into a separate function that is independent off an NvmeRequest. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

[PULL v2 04/38] hw/block/nvme: support for multi-controller in subsystem

From: Minwoo Im We have nvme-subsys and nvme devices mapped together. To support multi-controller scheme to this setup, controller identifier(id) has to be managed. Earlier, cntlid(controller id) used to be always 0 because we didn't have any subsystem scheme that controller id matters. This p

[PULL v2 05/38] hw/block/nvme: add NMIC enum value for Identify Namespace

From: Minwoo Im Added Namespace Multi-path I/O and Namespace Sharing Capabilities (NMIC) field to support shared namespace from controller(s). This field is in Identify Namespace data structure in [30]. Signed-off-by: Minwoo Im Tested-by: Klaus Jensen Reviewed-by: Klaus Jensen Reviewed-by: K

[PULL v2 10/38] nvme: updated shared header for copy command

From: Klaus Jensen Add new data structures and types for the Simple Copy command. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Acked-by: Stefan Hajnoczi Reviewed-by: Keith Busch --- include/block/nvme.h | 47 ++-- 1 file changed, 45 insertions(+

[PULL v2 16/38] hw/block/nvme: add broadcast nsid support flush command

From: Gollu Appalanaidu Add support for using the broadcast nsid to issue a flush on all namespaces through a single command. Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen Acked-by: Stefan Hajnoczi Acked-by: Keith Busch Signed-off-by: Klaus Jensen --- include/block/nvme.h |

[PULL v2 11/38] hw/block/nvme: add simple copy command

From: Klaus Jensen Add support for TP 4065a ("Simple Copy Command"), v2020.05.04 ("Ratified"). The implementation uses a bounce buffer to first read in the source logical blocks, then issue a write of that bounce buffer. The default maximum number of source logical blocks is 128, translating to

[PULL v2 12/38] hw/block/nvme: fix Close Zone

From: Dmitry Fomichev Implicitly and Explicitly Open zones can be closed by Close Zone management function. This got broken by a recent commit ("hw/block/nvme: refactor zone resource management") and now such commands fail with Invalid Zone State Transition status. Modify nvm_zrm_close() functio

[PULL v2 28/38] hw/block/nvme: try to deal with the iov/qsg duality

From: Klaus Jensen Introduce NvmeSg and try to deal with that pesky qsg/iov duality that haunts all the memory-related functions. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.h | 17 - hw/block/nvme.c | 191 ++-- 2 fil

[PULL v2 18/38] hw/block/nvme: deduplicate bad mdts trace event

From: Klaus Jensen If mdts is exceeded, trace it from a single place. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 6 +- hw/block/trace-events | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

[PULL v2 13/38] hw/block/nvme: add missing mor/mar constraint checks

From: Klaus Jensen Firstly, if zoned.max_active is non-zero, zoned.max_open must be less than or equal to zoned.max_active. Secondly, if only zones.max_active is set, we have to explicitly set zones.max_open or we end up with an invalid MAR/MOR configuration. This is an artifact of the parameter

[PULL v2 15/38] hw/block/nvme: use locally assigned QEMU IEEE OUI

From: Gollu Appalanaidu Commit 6eb7a071292a ("hw/block/nvme: change controller pci id") changed the controller to use a Red Hat assigned PCI Device and Vendor ID, but did not change the IEEE OUI away from the Intel IEEE OUI. Fix that and use the locally assigned QEMU IEEE OUI instead if the `use

[PULL v2 22/38] hw/block/nvme: fix potential compilation error

From: Gollu Appalanaidu assert may be compiled to a noop and we could end up returning an uninitialized status. Fix this by always returning Internal Device Error as a fallback. Note that, as pointed out by Philippe, per commit 262a69f4282 ("osdep.h: Prohibit disabling assert() in supported bui

[PULL v2 17/38] hw/block/nvme: document 'mdts' nvme device parameter

From: Klaus Jensen Document the 'mdts' nvme device parameter. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index db1a3aabd8e8..6921b1957d28 100644 --- a/hw/block/nvme.c +++

[PULL v2 19/38] hw/block/nvme: align zoned.zasl with mdts

From: Klaus Jensen ZASL (Zone Append Size Limit) is defined exactly like MDTS (Maximum Data Transfer Size), that is, it is a value in units of the minimum memory page size (CAP.MPSMIN) and is reported as a power of two. The 'mdts' nvme device parameter is specified as in the spec, but the 'zoned

[PULL v2 14/38] hw/block/nvme: improve invalid zasl value reporting

From: Klaus Jensen The Zone Append Size Limit (ZASL) must be at least 4096 bytes, so improve the user experience by adding an early parameter check in nvme_check_constraints. When ZASL is still too small due to the host configuring the device for an even larger page size, convert the trace point

[PULL v2 27/38] hw/block/nvme: fix strerror printing

From: Klaus Jensen Fix missing sign inversion. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Reviewed-by: Keith Busch --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 88e800898526..8f27fa745074 100644 --- a/h

[PULL v2 29/38] hw/block/nvme: remove the req dependency in map functions

From: Klaus Jensen The PRP and SGL mapping functions does not have any particular need for the entire NvmeRequest as a parameter. Clean it up. Signed-off-by: Klaus Jensen Reviewed-by: Keith Busch --- hw/block/nvme.c | 61 ++- hw/block/trace-events

[PULL v2 20/38] hw/block/nvme: remove unnecessary endian conversion

From: Gollu Appalanaidu Remove an unnecessary le_to_cpu conversion in Identify. Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index

[PULL v2 30/38] hw/block/nvme: refactor nvme_dma

From: Klaus Jensen The nvme_dma function doesn't just do DMA (QEMUSGList-based) memory transfers; it also handles QEMUIOVector copies. Introduce the NvmeTxDirection enum and rename to nvme_tx. Remove mapping of PRPs/SGLs from nvme_tx and instead assert that they have been mapped previously. This

[PULL v2 38/38] hw/block/nvme: support Identify NS Attached Controller List

From: Minwoo Im Support Identify command for Namespace attached controller list. This command handler will traverse the controller instances in the given subsystem to figure out whether the specified nsid is attached to the controllers or not. The 4096bytes Identify data will return with the fi

[PULL v2 21/38] hw/block/nvme: add identify trace event

From: Gollu Appalanaidu Add a trace event for the Identify command. Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im --- hw/block/nvme.c | 3 +++ hw/block/trace-events | 1 + 2 files changed, 4 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nv

[PULL v2 33/38] hw/block/nvme: fix allocated namespace list to 256

From: Minwoo Im Expand allocated namespace list (subsys->namespaces) to have 256 entries which is a value lager than at least NVME_MAX_NAMESPACES which is for attached namespace list in a controller. Allocated namespace list should at least larger than attached namespace list. n->num_na

[PULL v2 23/38] hw/block/nvme: add trace event for zone read check

From: Gollu Appalanaidu Add a trace event for the offline zone condition when checking zone read. Signed-off-by: Gollu Appalanaidu [k.jensen: split commit] Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c ind

[PULL v2 31/38] hw/block/nvme: support namespace detach

From: Minwoo Im Given that now we have nvme-subsys device supported, we can manage namespace allocated, but not attached: detached. This patch introduced a parameter for nvme-ns device named 'detached'. This parameter indicates whether the given namespace device is detached from a entire NVMe s

[PULL v2 26/38] hw/block/nvme: remove block accounting for write zeroes

From: Klaus Jensen A Write Zeroes commands should not be counted in either the 'Data Units Written' or in 'Host Write Commands' SMART/Health Information Log page. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Reviewed-by: Keith Busch --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion

[PULL v2 24/38] hw/block/nvme: report non-mdts command size limit for dsm

From: Gollu Appalanaidu Dataset Management is not subject to MDTS, but exceeded a certain size per range causes internal looping. Report this limit (DMRSL) in the NVM command set specific identify controller data structure. Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-

[PULL v2 32/38] hw/block/nvme: fix namespaces array to 1-based

From: Minwoo Im subsys->namespaces array used to be sized to NVME_SUBSYS_MAX_NAMESPACES. But subsys->namespaces are being accessed with 1-based namespace id which means the very first array entry will always be empty(NULL). Signed-off-by: Minwoo Im Reviewed-by: Keith Busch Reviewed-by: Klaus J

[PULL v2 25/38] hw/block/nvme: remove redundant len member in compare context

From: Klaus Jensen The 'len' member of the nvme_compare_ctx struct is redundant since the same information is available in the 'iov' member. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Reviewed-by: Keith Busch --- hw/block/nvme.c | 10 -- 1 file changed, 4 insertions(+), 6 del

Re: [PATCH v2 2/4] block: check for sys/disk.h

On 3/9/21 1:27 AM, Joelle van Dyne wrote: > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > meson.build | 1 + > block.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 0e53876f69..ba0db9fa1f

[PATCH] storage-daemon: Call job_cancel_sync_all() on shutdown

bdrv_close_all() asserts that no jobs are running any more, so we need to cancel all jobs first to avoid failing the assertion. Fixes: b55a3c8860b763b62b2cc2f4a6f55379977bbde5 Reported-by: Nini Gu Signed-off-by: Kevin Wolf --- storage-daemon/qemu-storage-daemon.c | 1 + tests/qemu-iotests/tes

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

Thomas Huth writes: > The status of the gitlab-CI files is currently somewhat confusing, and > it is often not quite clear whether a patch should go via my tree or > via the testing tree of Alex. That situation has grown historically... > Initially, I was the only one using the gitlab-CI, just

[PULL v2 34/38] hw/block/nvme: support allocated namespace type

From: Minwoo Im >From NVMe spec 1.4b "6.1.5. NSID and Namespace Relationships" defines valid namespace types: - Unallocated: Not exists in the NVMe subsystem - Allocated: Exists in the NVMe subsystem - Inactive: Not attached to the controller - Active: Attached to

Re: [PATCH v3 3/3] migration/ram: Optimize ram_save_host_page()

Hi, On 2021/3/9 5:36, Peter Xu wrote: On Mon, Mar 08, 2021 at 09:58:02PM +0800, Kunkun Jiang wrote: Hi, On 2021/3/5 22:30, Peter Xu wrote: On Fri, Mar 05, 2021 at 03:50:35PM +0800, Kunkun Jiang wrote: Starting from pss->page, ram_save_host_page() will check every page and send the dirty page

[PULL v2 37/38] hw/block/nvme: support changed namespace asynchronous event

From: Minwoo Im If namespace inventory is changed due to some reasons (e.g., namespace attachment/detachment), controller can send out event notifier to the host to manage namespaces. This patch sends out the AEN to the host after either attach or detach namespaces from controllers. To support

[PULL v2 35/38] hw/block/nvme: refactor nvme_select_ns_iocs

From: Minwoo Im This patch has no functional changes. This patch just refactored nvme_select_ns_iocs() to iterate the attached namespaces of the controlller and make it invoke __nvme_select_ns_iocs(). Signed-off-by: Minwoo Im Reviewed-by: Keith Busch Reviewed-by: Klaus Jensen Tested-by: Klau

Re: [PATCH v3] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

On 3/9/21 12:23 PM, Thomas Huth wrote: > The status of the gitlab-CI files is currently somewhat confusing, and > it is often not quite clear whether a patch should go via my tree or > via the testing tree of Alex. That situation has grown historically... > Initially, I was the only one using the g

[PULL v2 36/38] hw/block/nvme: support namespace attachment command

From: Minwoo Im This patch supports Namespace Attachment command for the pre-defined nvme-ns device nodes. Of course, attach/detach namespace should only be supported in case 'subsys' is given. This is because if we detach a namespace from a controller, somebody needs to manage the detached, bu

Re: [RFC PATCH 4/4] coroutine/rwlock: Wake writers in preference to readers

On Tuesday, 2021-03-09 at 12:06:22 +01, Paolo Bonzini wrote: > On 09/03/21 11:21, David Edmondson wrote: >> -/* The critical section started in qemu_co_rwlock_wrlock. */ >> -qemu_co_queue_restart_all(&lock->queue); >> +/* The critical section started in qemu_co_rwlock_wrlo

Re: [RFC PATCH 1/4] block/vdi: When writing new bmap entry fails, don't leak the buffer

On 3/9/21 12:58 PM, David Edmondson wrote: > On Tuesday, 2021-03-09 at 12:09:55 +01, Philippe Mathieu-Daudé wrote: > >> On 3/9/21 11:21 AM, David Edmondson wrote: >>> If a new bitmap entry is allocated, requiring the entire block to be >>> written, avoiding leaking the buffer allocated for the blo

Re: [RFC PATCH 1/4] block/vdi: When writing new bmap entry fails, don't leak the buffer

On Tuesday, 2021-03-09 at 12:09:55 +01, Philippe Mathieu-Daudé wrote: > On 3/9/21 11:21 AM, David Edmondson wrote: >> If a new bitmap entry is allocated, requiring the entire block to be >> written, avoiding leaking the buffer allocated for the block should >> the write fail. >> >> Signed-off-by:

Re: [PATCH v2 4/4] slirp: feature detection for smbd

On 3/9/21 1:27 AM, Joelle van Dyne wrote: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 26 +

[PATCH 1/2] ui/cocoa: Show QEMU icon in the about window

Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 0ef5fdf3b7a..d8eacea6d22 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -39,6 +39,7 @@ #include "qapi/qapi-commands-misc.h" #include "sysemu/

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Tue, Mar 9, 2021 at 8:30 PM Yan Vugenfirer wrote: > > > > On 9 Mar 2021, at 12:13 PM, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > > Hi Jason, > > On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > > > Hi Jason, > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:

[PATCH 2/2] ui/cocoa: Do not rely on the first argument

The first argument of the executable was used to get its path, but it is not reliable because the executer can specify any arbitrary string. Use the interfaces provided by QEMU and the platform to get those paths. Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 29 +++-- 1

Re: [PATCH v3 1/3] migration/ram: Modify the code comment of ram_save_host_page()

Hi, On 2021/3/9 5:03, Peter Xu wrote: On Mon, Mar 08, 2021 at 06:33:56PM +0800, Kunkun Jiang wrote: Hi, Peter On 2021/3/5 21:59, Peter Xu wrote: On Fri, Mar 05, 2021 at 03:50:33PM +0800, Kunkun Jiang wrote: The ram_save_host_page() has been modified several times since its birth. But the com

Re:Re: [PATCH] virtio-gpu: Add spaces around operator

At 2021-03-09 17:08:08, "Philippe Mathieu-Daudé" wrote: >(Cc'ing qemu-trivial@) > >On 3/9/21 8:42 AM, lijiejun wrote: >> Fix code style. Operator needs spaces forend sides, and delete line space. > >"forend"? done with: Fix code style. Operator needs align with eight spaces,

[PATCH 1/2] curl: Store BDRVCURLState pointer in CURLSocket

A socket does not really belong to any specific state. We do not need to store a pointer to "its" state in it, a pointer to the common BDRVCURLState is sufficient. Signed-off-by: Max Reitz --- block/curl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/curl.c

[PATCH] virtio-gpu: Adjust code space style

Fix code style. Operator needs align with eight spaces, and delete line space. Signed-off-by: lijiejun --- hw/display/virtio-gpu-3d.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 9eb4890..d989648 100644 --- a/

Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument

On Tue, 9 Mar 2021, Akihiko Odaki wrote: The first argument of the executable was used to get its path, but it is not reliable because the executer can specify any arbitrary string. Use the interfaces provided by QEMU and the platform to get those paths. Signed-off-by: Akihiko Odaki --- ui/coco

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

> On 9 Mar 2021, at 12:13 PM, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng > wrote: >> >> Hi Jason, >> >> On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: >>> >>> Hi Jason, >>> >>> On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: >>>

[PATCH 2/2] curl: Disconnect sockets from CURLState

When a curl transfer is finished, that does not mean that CURL lets go of all the sockets it used for it. We therefore must not free a CURLSocket object before CURL has invoked curl_sock_cb() to tell us to remove it. Otherwise, we may get a use-after-free, as described in this bug report: https:/

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

On Fri, Mar 05, 2021 at 04:46:03PM -0500, Eduardo Habkost wrote: > On Tue, Mar 02, 2021 at 06:35:44PM +0100, Halil Pasic wrote: > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > module, which provides the type virtio-gpu-device, packaging the > > hw-display-virtio-gpu mod

Re: [PATCH 1/3] hw/avr: Add limited support for avr gpio registers

Hello, Ping. It has been 7days since the patch has been posted. Please review. Thanks, Niteesh On Tue, Mar 2, 2021 at 10:59 PM G S Niteesh Babu wrote: > From: Heecheol Yang > > Add some of these features for AVR GPIO: > > - GPIO I/O : PORTx registers > - Data Direction : DDRx registers >

[PATCH 0/2] block/curl: Disconnect sockets from CURLState

Hi, There’s been a bug report concerning our curl driver on Launchpad: https://bugs.launchpad.net/qemu/+bug/1916501 When downloading an image from a certain URL, it crashes. (https://download.cirros-cloud.net/0.4.0/cirros-0.4.0-x86_64-disk.img) The crash is a use-after-free: A CURLState (which

[PULL 1/7] arm/ast2600: Fix SMP booting with -kernel

From: Joel Stanley The ast2600 machines do not have PSCI firmware, so this property should have never been set. Removing this node fixes SMP booting Linux kernels that have PSCI enabled, as Linux fails to find PSCI in the device tree and falls back to the soc-specific method for enabling secondar

[PULL 7/7] hw/misc: Model KCS devices in the Aspeed LPC controller

From: Andrew Jeffery Keyboard-Controller-Style devices for IPMI purposes are exposed via LPC IO cycles from the BMC to the host. Expose support on the BMC side by implementing the usual MMIO behaviours, and expose the ability to inspect the KCS registers in "host" style by accessing QOM properti

Re: [RFC PATCH 1/4] block/vdi: When writing new bmap entry fails, don't leak the buffer

On 09/03/21 13:06, Philippe Mathieu-Daudé wrote: Newfangled witchy magic! I'm happy to change it if you think it beneficial. I then saw the next patch which keeps modifying the same function, so this might not be a great improvement after all. Yeah I was also going to suggest it but consider

Re: [PATCH V2 trivial] Various spelling fixes

On 3/9/21 12:15 PM, Michael Tokarev wrote: > An assorted set of spelling fixes in various places. > > Signed-off-by: Michael Tokarev > Reviewed-by: Stefan Weil > --- > V1: https://lists.nongnu.org/archive/html/qemu-devel/2020-12/msg05959.html > Changes: incorporated suggestions by Stefan Weil an

[PULL 3/7] hw/arm: ast2600: Force a multiple of 32 of IRQs for the GIC

From: Andrew Jeffery This appears to be a requirement of the GIC model. The AST2600 allocates 197 GIC IRQs, which we will adjust shortly. Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Message-Id: <20210302014317.915120-2-and...@aj.id.au> Signed-off-by: Cédric Le Goater --- hw/a

[PULL 4/7] hw/arm: ast2600: Set AST2600_MAX_IRQ to value from datasheet

From: Andrew Jeffery The datasheet says we have 197 IRQs allocated, and we need more than 128 to describe IRQs from LPC devices. Raise the value now to allow modelling of the LPC devices. Signed-off-by: Andrew Jeffery Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-I

Re: [PATCH 1/2] curl: Store BDRVCURLState pointer in CURLSocket

On 3/9/21 2:05 PM, Max Reitz wrote: > A socket does not really belong to any specific state. We do not need > to store a pointer to "its" state in it, a pointer to the common > BDRVCURLState is sufficient. > > Signed-off-by: Max Reitz > --- > block/curl.c | 8 > 1 file changed, 4 inser

[PULL 5/7] hw/arm: ast2600: Correct the iBT interrupt ID

From: Andrew Jeffery The AST2600 allocates distinct GIC IRQs for the LPC subdevices such as the iBT device. Previously on the AST2400 and AST2500 the LPC subdevices shared a single LPC IRQ. Signed-off-by: Andrew Jeffery Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message

[PULL 0/7] aspeed queue

ull-aspeed-20210309 for you to fetch changes up to c59f781e3bcca4a80aef5d229488fd45dbfdbd9a: hw/misc: Model KCS devices in the Aspeed LPC controller (2021-03-09 12:01:28 +0100) Aspeed patches : * New model for the Aspeed LPC control

[PULL 2/7] hw/arm/aspeed: Fix location of firmware images in documentation

Firmware images can be found on the OpenBMC jenkins site and on the OpenBMC GitHub release page. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Message-Id: <20210303072743.1551329-1-...@kaod.org> Signed-off-by: Cédric Le Goater --- docs/system/arm/aspeed.rst | 14 +- 1 f

[Bug 1916501] Re: qemu-img convert segfaults with specific URL

I think I’ve come to kind of understood what might be wrong: qemu frees CURLSocket objects when “their” transfer is done, but libcurl’s documentation actually doesn’t note any long-lasting relationship between a socket and some transfer (i.e., a CURL object), so we probably shouldn’t free CURLSocke

Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw

On Tue, Mar 09, 2021 at 01:45:12PM +0100, Gerd Hoffmann wrote: > On Fri, Mar 05, 2021 at 04:46:03PM -0500, Eduardo Habkost wrote: > > On Tue, Mar 02, 2021 at 06:35:44PM +0100, Halil Pasic wrote: > > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > > module, which provides

[PULL 6/7] hw/misc: Add a basic Aspeed LPC controller model

This is a very minimal framework to access registers which are used to configure the AHB memory mapping of the flash chips on the LPC HC Firmware address space. Signed-off-by: Cédric Le Goater Signed-off-by: Andrew Jeffery Message-Id: <20210302014317.915120-5-and...@aj.id.au> Signed-off-by: Cédr

Re: [PATCH] virtio-gpu: Adjust code space style

On 3/9/21 1:14 PM, lijiejun wrote: > Fix code style. Operator needs align with eight spaces, and delete line space. > > Signed-off-by: lijiejun > --- > hw/display/virtio-gpu-3d.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2

On Sun, Mar 07, 2021 at 10:47:06PM -0800, Joelle van Dyne wrote: > On Wed, Feb 10, 2021 at 2:55 AM Roman Bolshakov wrote: > > > > There's a change in mprotect() behaviour [1] in the latest macOS on M1 > > and it's not yet clear if it's going to be fixed by Apple. For now we > > can avoid unsupport

Re: [PATCH V2 trivial] Various spelling fixes

On Tue, 9 Mar 2021 at 11:23, Michael Tokarev wrote: > > An assorted set of spelling fixes in various places. > > Signed-off-by: Michael Tokarev > Reviewed-by: Stefan Weil > --- > V1: https://lists.nongnu.org/archive/html/qemu-devel/2020-12/msg05959.html > Changes: incorporated suggestions by Ste

Re: [PATCH v2 1/3] target/arm: Restrict v8M IDAU to TCG

On 2/21/21 11:26 PM, Philippe Mathieu-Daudé wrote: > IDAU is specific to M-profile. KVM only supports A-profile. > Restrict this interface to TCG, as it is pointless (and > confusing) on a KVM-only build. > > Reviewed-by: Richard Henderson > Reviewed-by: Peter Maydell > Signed-off-by: Philippe M

[PATCH] Revert "accel: kvm: Add aligment assert for kvm_log_clear_one_slot"

This reverts commit 3920552846e881bafa9f9aad0bb1a6eef874d7fb. Thomas Huth reported a failure with CentOS 6 guests: ../../devel/qemu/accel/kvm/kvm-all.c:690: kvm_log_clear_one_slot: Assertion `QEMU_IS_ALIGNED(start | size, psize)' failed. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 7

Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot

On 17/12/2020 02.49, Keqian Zhu wrote: The parameters start and size are transfered from QEMU memory emulation layer. It can promise that they are TARGET_PAGE_SIZE aligned. However, KVM needs they are qemu_real_page_size aligned. Though no caller breaks this aligned requirement currently, we'd b

Re: [PULL 0/3] Hexagon patch queue

On Sun, 7 Mar 2021 at 01:39, Richard Henderson wrote: > > The following changes since commit 91e92cad67caca3bc4b8e920ddb5c8ca64aac9e1: > > Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210305' > into staging (2021-03-05 19:04:47 +) > > are available in the Git repository

[PATCH] scsi: fix sense code for EREMOTEIO

SENSE_CODE(LUN_COMM_FAILURE) has an ABORTED COMMAND sense key, so it results in a retry in Linux. To ensure that EREMOTEIO is forwarded to the guest, use a HARDWARE ERROR sense key instead. Note that the code before commit d7a84021d was incorrect because it used HARDWARE_ERROR as a SCSI status, n

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

On Tue, 9 Mar 2021, Alexey Kardashevskiy wrote: On 09/03/2021 16:29, David Gibson wrote: +struct ClientArchitectureSupportClass { +InterfaceClass parent; +target_ulong (*cas)(CPUState *cs, target_ulong vec); +void (*quiesce)(void); Is there actually any real connection of quiesce b

Re: [PATCH 4/4] virtiofsd: Release vu_dispatch_lock when stopping queue

On Mon, Mar 08, 2021 at 01:31:41PM +0100, Greg Kurz wrote: > QEMU can stop a virtqueue by sending a VHOST_USER_GET_VRING_BASE request > to virtiofsd. As with all other vhost-user protocol messages, the thread > that runs the main event loop in virtiofsd takes the vu_dispatch lock in > write mode. T

Re: [PATCH] util/osdep: Avoid mprotect() RWX->NONE on Big Sur 11.2

On 2/10/21 2:55 AM, Roman Bolshakov wrote: There's a change in mprotect() behaviour [1] in the latest macOS on M1 and it's not yet clear if it's going to be fixed by Apple. For now we can avoid unsupported mprotect() calls. QEMU and qtests work fine without it. 1.https://gist.github.com/hikalium

Re: [PATCH v2 2/2] accel: kvm: Add aligment assert for kvm_log_clear_one_slot

On 2021/3/9 21:48, Thomas Huth wrote: > On 17/12/2020 02.49, Keqian Zhu wrote: >> The parameters start and size are transfered from QEMU memory >> emulation layer. It can promise that they are TARGET_PAGE_SIZE >> aligned. However, KVM needs they are qemu_real_page_size aligned. >> >> Though no c

Re: [PATCH 0/6] hw/mips/gt64120: Minor fixes

On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 3/5/21 5:21 PM, Philippe Mathieu-Daudé wrote: Trivial fixes extracted from another series which became too big, so I prefer to send them in a previous step. I just realized I meant to Cc you on this series but forgot :/ As this m

Re: [PATCH v2] linux-user: Fix executable page of /proc/self/maps

On 3/8/21 2:47 AM, Laurent Vivier wrote: Should we move this directly in read_self_maps() to have the guest values in MapInfo? No, because we also need read_self_maps() to create the guest in the first place. r~

Re: [PATCH v2] linux-user: Fix executable page of /proc/self/maps

On 3/8/21 1:19 AM, Nicolas Surbayrole wrote: The guest binary and libraries are not always map with the executable bit in the host process. The guest may read a /proc/self/maps with no executable address range. The perm fields should be based on the guest permission inside Qemu. Signed-off-by: N

Re: [PATCH 01/38] target/riscv: implementation-defined constant parameters

On Fri, Feb 12, 2021 at 10:05 AM LIU Zhiwei wrote: > > ext_p64 is whether to support Zp64 extension in RV32, default value is true. > pext_ver is the packed specification version, default value is v0.9.2. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/ris

Re: [PATCH v2 4/4] slirp: feature detection for smbd

Hi Joelle, On 3/9/21 1:27 AM, Joelle van Dyne wrote: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- > configure | 26 +++--- > meson.build |

Re: [PATCH] target/mips: Use gen_load_gpr[_hi]() when possible

On 3/8/21 5:16 AM, Philippe Mathieu-Daudé wrote: Use gen_load_gpr[_hi]() instead of open coding it. Patch generated using the following spatch script: @gen_load_gpr@ identifier reg_idx; expression tcg_reg; @@ -if (reg_idx == 0) { -tcg_gen_movi_tl(tcg_reg, 0); -} else {

Re: [PATCH 02/38] target/riscv: Hoist vector functions

On Fri, Feb 12, 2021 at 10:07 AM LIU Zhiwei wrote: > > The saturate functions about add,subtract and shift functions can > be used in packed extension.Therefore hoist them up. A better title might be: target/riscv: Make the vector helper functions public Otherwise: Reviewed-by: Alistair Franci

Re: [PATCH 03/38] target/riscv: Fixup saturate subtract function

On Fri, Feb 12, 2021 at 10:10 AM LIU Zhiwei wrote: > > The overflow predication ((a - b) ^ a) & (a ^ b) & INT64_MIN is right. > However, when the predication is ture and a is 0, it should return maximum. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/risc

Re: [PATCH] scsi: fix sense code for EREMOTEIO

On 3/9/21 2:57 PM, Paolo Bonzini wrote: > SENSE_CODE(LUN_COMM_FAILURE) has an ABORTED COMMAND sense key, > so it results in a retry in Linux. To ensure that EREMOTEIO > is forwarded to the guest, use a HARDWARE ERROR sense key > instead. Note that the code before commit d7a84021d was incorrect >

[PATCH v2 0/4] semihosting/next (SYS_HEAPINFO fix)

Hi, OK I took another tilt at fixing the SYS_HEAPINFO bug with a lot less code motion and also expanding the tcg tests. Currently based on my in-flight PR: pull-testing-docs-xen-updates-080321-1 which already moves the semihosting code out of hw/. Please review: - tests/tcg: add HeapInfo che

[PATCH v2 1/4] semihosting: move semihosting tests to multiarch

It may be arm-compat-semihosting but more than one architecture uses it so lets move the tests into the multiarch area. We gate it on the feature and split the semicall.h header between the arches. Also clean-up a bit of the Makefile messing about to one common set of runners. Signed-off-by: Alex

<    1   2   3   4   5   6   7   >