RE: [PATCH] virtio-iommu: Default to bypass during boot

2021-03-04 Thread Tian, Kevin
> From: Jean-Philippe Brucker > Sent: Friday, February 26, 2021 9:01 PM > > On Fri, Feb 26, 2021 at 08:11:41AM +, Tian, Kevin wrote: > > > From: Qemu-devel bounces+kevin.tian=intel@nongnu.org> > > > On Behalf Of Jean-Philippe Brucker > > > > > > On Sun, Feb 21, 2021 at 06:45:18AM -0500,

[Bug 1916394] Re: [git] Cannot build qemu: FAILED: target/hexagon/semantics_generated.pyinc

2021-03-04 Thread Frederic Bezies
I tried something else, and build process went right: building qemu in a clean-chroot: https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroot Well, something is broken on my real installation, or it could be a bug in a package as I'm using testing. Anyway, this bug can be c

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-04 Thread David Hildenbrand
On 03.03.21 22:36, Richard Henderson wrote: On 3/3/21 1:22 PM, David Hildenbrand wrote: Am 03.03.2021 um 22:19 schrieb Richard Henderson : On 3/3/21 1:11 PM, David Hildenbrand wrote: MMIO on s390x? :) hw/s390x/s390-pci-bus.c, memory_region_init_io*(). ... part of system address space w

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-04 Thread David Hildenbrand
On 03.03.21 16:03, Laszlo Ersek wrote: On 03/02/21 19:43, David Hildenbrand wrote: We are dealing with different blobs here (tables_blob vs. cmd_blob). OK, thanks -- this was the important bit I was missing. Over time I've lost track of the actual set of fw_cfg blobs that QEMU exposes, for th

Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit

2021-03-04 Thread Cornelia Huck
On Thu, 4 Mar 2021 09:10:44 +0100 David Hildenbrand wrote: > On 03.03.21 22:36, Richard Henderson wrote: > > On 3/3/21 1:22 PM, David Hildenbrand wrote: > >> > >>> Am 03.03.2021 um 22:19 schrieb Richard Henderson > >>> : > >>> > >>> On 3/3/21 1:11 PM, David Hildenbrand wrote: > MMIO

Re: [PATCH v1 2/2] hw/arm: versal: Add support for the XRAMs

2021-03-04 Thread Luc Michel
On 3/2/21 12:09 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Connect the support for the Versal Accelerator RAMs (XRAMs). Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel --- docs/system/arm/xlnx-versal-virt.rst | 1 + include/hw/arm/xlnx-versal.h | 13 +

Re: [PATCH v1 1/2] hw/misc: versal: Add a model of the XRAM controller

2021-03-04 Thread Luc Michel
On 3/2/21 12:09 PM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add a model of the Xilinx Versal Accelerator RAM (XRAM). This is mainly a stub to make firmware happy. The size of the RAMs can be probed. The interrupt mask logic is modelled but none of the interrups will ever be raised un

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: Hi Jason, as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD writing data is very slow compared to a raw file. Comparing raw vs QCOW2 image creation wi

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 10:26:12PM +0100, Peter Lieven wrote: Am 03.03.21 um 19:47 schrieb Jason Dillaman: On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: Hi Jason, as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD writing data is very slow compared to a raw file

Re: [RFC PATCH 00/26] Confidential guest live migration

2021-03-04 Thread Paolo Bonzini
On 02/03/21 21:47, Dov Murik wrote: In order to allow OVMF to run the migration helper in parallel to the guest OS, we introduce the notion of auxiliary vcpus, which are usable for OVMF but are hidden from the guest OS. These might have other future uses for in-guest operations/agents. Hi Dov,

Re: [RFC v8 03/28] header update against 5.11-rc2 and IOMMU/VFIO nested stage APIs

2021-03-04 Thread Kunkun Jiang
On 2021/2/25 18:52, Eric Auger wrote: Signed-off-by: Eric Auger --- .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- linux-headers/linux/iommu.h | 395 ++ linux-headers/linux/vfio.h| 141 ++- 3 files changed, 542 insertions(+)

Re: [PATCH v1] vhost-vdpa: Set discarding of RAM broken when initializing the backend

2021-03-04 Thread Jason Wang
On 2021/3/3 6:26 下午, David Hildenbrand wrote: On 03.03.21 03:53, Jason Wang wrote: On 2021/3/3 12:21 上午, David Hildenbrand wrote: Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory that used to be discarded will get re-populated and if we discard+re-access memory after m

Re: [PATCH v1] vhost-vdpa: Set discarding of RAM broken when initializing the backend

2021-03-04 Thread David Hildenbrand
On 04.03.21 10:32, Jason Wang wrote: On 2021/3/3 6:26 下午, David Hildenbrand wrote: On 03.03.21 03:53, Jason Wang wrote: On 2021/3/3 12:21 上午, David Hildenbrand wrote: Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory that used to be discarded will get re-populated and i

Re: [PATCH v1] vhost-vdpa: Set discarding of RAM broken when initializing the backend

2021-03-04 Thread Jason Wang
On 2021/3/4 5:34 下午, David Hildenbrand wrote: On 04.03.21 10:32, Jason Wang wrote: On 2021/3/3 6:26 下午, David Hildenbrand wrote: On 03.03.21 03:53, Jason Wang wrote: On 2021/3/3 12:21 上午, David Hildenbrand wrote: Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory tha

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-04 Thread David Hildenbrand
On 03.03.21 17:09, Igor Mammedov wrote: On Wed, 3 Mar 2021 16:03:36 +0100 Laszlo Ersek wrote: On 03/02/21 19:43, David Hildenbrand wrote: We are dealing with different blobs here (tables_blob vs. cmd_blob). OK, thanks -- this was the important bit I was missing. Over time I've lost track o

[PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add new parallels-ext.c and myself as co-maintainer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..92ba1fce5e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3117,9 +3117,11 @@ F: block

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Denis V. Lunev
On 3/4/21 12:51 PM, Vladimir Sementsov-Ogievskiy wrote: > Add new parallels-ext.c and myself as co-maintainer. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9b2aa18e1f..92ba1fce5e 10

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
04.03.2021 12:51, Vladimir Sementsov-Ogievskiy wrote: Add new parallels-ext.c and myself as co-maintainer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..92ba1fce5e 100644 --- a/MAI

[PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Markus Armbruster
Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate configuring floppies with -global isa-fdc" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 26 -- docs/system/removed-features.rst | 26 ++ hw/block/fdc.c | 54 +-- tests/qemu-iot

[PATCH v2 0/3] Drop deprecated floppy config & bogus -drive if=T

2021-03-04 Thread Markus Armbruster
v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common

[PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-03-04 Thread Markus Armbruster
The previous commit rendered the name fdctrl_connect_drives() somewhat misleading. Get rid of it by inlining the (now pretty simple) function into its only caller. Signed-off-by: Markus Armbruster --- hw/block/fdc.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-)

[PATCH v2 3/3] blockdev: Drop deprecated bogus -drive interface type

2021-03-04 Thread Markus Armbruster
Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate -drive with bogus interface type" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 7 -- docs/system/removed-features.rst | 7 ++ include/sysemu/blockdev.h| 1 - blockdev.c

Re: [PATCH] KVM: x86: do not fail if software breakpoint has already been removed

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 02:07:24PM +0200, Maxim Levitsky wrote: On Tue, 2021-03-02 at 15:52 +0100, Stefano Garzarella wrote: On Mon, Mar 01, 2021 at 02:56:40PM +0200, Maxim Levitsky wrote: > On Mon, 2021-03-01 at 12:17 +0100, Paolo Bonzini wrote: > > If kvm_arch_remove_sw_breakpoint finds that a

[PATCH v2 6/8] simplebench/bench-backup: support qcow2 source files

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add support for qcow2 source. New option says to use test-source.qcow2 instead of test-source. Of course, test-source.qcow2 should be precreated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 5 + scripts/simplebench/bench_block_job.py | 7 ++-

[PATCH v2 0/8] simplebench improvements

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here are some improvements to simplebench lib, to support my "qcow2: compressed write cache" series. v1 was inside "[PATCH 0/7] qcow2: compressed write cache" <20210129165030.640169-1-vsement...@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07795.html https

[PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Sometimes one of cells in a testing table runs too slow. And we really don't want to wait so long. Limit number of runs in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 29 + 1 file changed, 25 insertions(+), 4 deletio

[PATCH v2 3/8] simplebench/bench-backup: add --compressed option

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Allow bench compressed backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 55 ++ scripts/simplebench/bench_block_job.py | 23 +++ 2 files changed, 62 insertions(+), 16 deletions(-) diff --git a/scripts/simplebench/ben

[PATCH v2 4/8] simplebench/bench-backup: add target-cache argument

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Allow benchmark with different kinds of target cache. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 33 -- scripts/simplebench/bench_block_job.py | 10 +--- 2 files changed, 33 insertions(+), 10 deletions(-) diff --git a/scr

[PATCH v2 5/8] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
We should not report success if there is an error in final event. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 4 1 file changed, 4 insertions(+) diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py index

[PATCH v2 7/8] simplebench/bench-backup: add --count and --no-initial-run

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add arguments to set number of test runs per table cell and to disable initial run that is not counted in results. It's convenient to set --count 1 --no-initial-run to fast run test onece, and to set --count to some large enough number for good precision of the results. Signed-off-by: Vladimir Se

[PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
It probably may improve reliability of results when testing in cached mode. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.p

[PATCH v2 2/8] simplebench: bench_one(): support count=1

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
statistics.stdev raises if sequence length is less than two. Support that case by hand. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/simplebench/simplebench.py b/scripts/simpleb

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Denis V. Lunev
On 3/4/21 12:58 PM, Vladimir Sementsov-Ogievskiy wrote: > 04.03.2021 12:51, Vladimir Sementsov-Ogievskiy wrote: >> Add new parallels-ext.c and myself as co-maintainer. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   MAINTAINERS | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff -

[PATCH] virtiofs: drop remapped security.capability xattr as needed

2021-03-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" On Linux, the 'security.capability' xattr holds a set of capabilities that can change when an executable is run, giving a limited form of privilege escalation to those programs that the writer of the file deemed worthy. Any write causes the 'security.capability' xa

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: > On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > > On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella > > wrote: > > > > > > Hi Jason, > > > as reported in this BZ [1], when qemu-img creates a QCOW2 image on R

[PATCH] qemu-option: do not suggest using the delay option

2021-03-04 Thread Paolo Bonzini
The "delay" option was a hack that was introduced to allow writing "nodelay". We are adding a "nodelay" option to be used as "nodelay=on", so recommend it instead of "delay". Signed-off-by: Paolo Bonzini --- This is quite ugly, so I am posting it as RFC in case others have better

Re: [PATCH v2] libqos/qgraph: format qgraph comments for sphinx documentation

2021-03-04 Thread Emanuele Giuseppe Esposito
On 03/03/2021 17:43, Thomas Huth wrote: On 25/02/2021 13.22, Emanuele Giuseppe Esposito wrote: Change documentation style and fix minor typos in tests/qtest/libqos/qgraph.h to automatically generate sphinx documentation in docs/devel/qgraph.rst The mechanism explanation that once was in qgr

[PATCH] MAINTAINERS: add Vladimir as co-maintainer of NBD

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- I have good knowledge of the subsystem and I'm an author of large part of it :) MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 92ba1fce5e..58994bfafc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH] meson: Stop if cfi is enabled with system slirp

2021-03-04 Thread Daniel P . Berrangé
On Wed, Mar 03, 2021 at 09:59:38PM -0500, Daniele Buono wrote: > For CFI, we need to compile slirp as a static library together with qemu. > This is because we register slirp functions as callbacks for QEMU Timers. > When using a system-wide shared libslirp, the type information for the > callback

Re: [PATCH v3 1/2] gitlab-ci.yml: Allow custom # of parallel linkers

2021-03-04 Thread Daniel P . Berrangé
On Wed, Mar 03, 2021 at 10:09:47PM -0500, Daniele Buono wrote: > Define a new variable LD_JOBS, that can be used to select > the maximum number of linking jobs to be executed in parallel. > If the variable is not defined, maintain the default given by > make -j > > Currently, make parallelism at b

[PULL 0/1] virtiofs queue (minor security)

2021-03-04 Thread Dr. David Alan Gilbert (git)
/dagrh/qemu.git tags/pull-virtiofs-20210304 for you to fetch changes up to e586edcb410543768ef009eaa22a2d9dd4a53846: virtiofs: drop remapped security.capability xattr as needed (2021-03-04 10:26:16 +) virtiofs minor security

[PULL 1/1] virtiofs: drop remapped security.capability xattr as needed

2021-03-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" On Linux, the 'security.capability' xattr holds a set of capabilities that can change when an executable is run, giving a limited form of privilege escalation to those programs that the writer of the file deemed worthy. Any write causes the 'security.capability' xa

Re: [PATCH v3 2/2] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-04 Thread Daniel P . Berrangé
On Wed, Mar 03, 2021 at 10:09:48PM -0500, Daniele Buono wrote: > QEMU has had options to enable control-flow integrity features > for a few months now. Add two sets of build/check/acceptance > jobs to ensure the binary produced is working fine. > > The three sets allow testing of x86_64 binaries f

Re: [PATCH] virtiofsd: Add qemu version and copyright info

2021-03-04 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Option "-V" currently displays the fuse protocol version virtiofsd is > using. For example, I see this. > > $ ./virtiofsd -V > "using FUSE kernel interface version 7.33" > > People also want to know software version of virtiofsd so that they can > figure

[PATCH v2 9/8] MAINTAINERS: update Benchmark util: add git tree

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..642c1c8a46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2484,6 +2484,7 @@ Benchmark util M: Vladimir Sementsov-Ogievskiy S: Maintained

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: > Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate > configuring floppies with -global isa-fdc" (v5.1.0). > > Signed-off-by: Markus Armbruster > --- > docs/system/deprecated.rst | 26 -- > docs/system/remove

Re: [PATCH] qemu-option: do not suggest using the delay option

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 11:28:27AM +0100, Paolo Bonzini wrote: > The "delay" option was a hack that was introduced to allow writing "nodelay". > We are adding a "nodelay" option to be used as "nodelay=on", so recommend it > instead of "delay". > > Signed-off-by: Paolo Bonzini > --- > This

[PATCH v3 0/4] acpi: Set proper maximum size for "etc/table-loader" blob

2021-03-04 Thread David Hildenbrand
Fix and cleanup initializing the maximum size of mutable ACPI blobs. v1/v2 -> v3: - 'acpi: Set proper maximum size for "etc/table-loader" blob' -- Move "etc/table-loader" change to separate patch -- Extend description -- Fixup maximum size (now really use 64k) - Add some patches to cleanup/refacto

[PATCH v3 3/4] acpi: Move maximum size logic into acpi_add_rom_blob()

2021-03-04 Thread David Hildenbrand
We want to have safety margins for all tables based on the table type. Let's move the maximum size logic into acpi_add_rom_blob() and make it dependent on the table name, so we don't have to replicate for each and every instance that creates such tables. Suggested-by: Laszlo Ersek Cc: Alistair Fr

[PATCH v3 2/4] microvm: Don't open-code "etc/table-loader"

2021-03-04 Thread David Hildenbrand
Let's just reuse ACPI_BUILD_LOADER_FILE. Cc: Alistair Francis Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Peter Maydell Cc: Shannon Zhao Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Laszlo Ersek Signed-off-by: David Hildenbrand --- hw/i386/acpi-

Re: [PATCH] meson: Stop if cfi is enabled with system slirp

2021-03-04 Thread Paolo Bonzini
On 04/03/21 11:37, Daniel P. Berrangé wrote: On Wed, Mar 03, 2021 at 09:59:38PM -0500, Daniele Buono wrote: For CFI, we need to compile slirp as a static library together with qemu. This is because we register slirp functions as callbacks for QEMU Timers. When using a system-wide shared libslirp

[PATCH v3 1/4] acpi: Set proper maximum size for "etc/table-loader" blob

2021-03-04 Thread David Hildenbrand
The resizeable memory region / RAMBlock that is created for the cmd blob has a maximum size of whole host pages (e.g., 4k), because RAMBlocks work on full host pages. In addition, in i386 ACPI code: acpi_align_size(tables->linker->cmd_blob, ACPI_BUILD_ALIGN_SIZE); makes sure to align to multiples

[PATCH v3 4/4] acpi: Set proper maximum size for "etc/acpi/rsdp" blob

2021-03-04 Thread David Hildenbrand
Let's also set a maximum size for "etc/acpi/rsdp", so the maximum size doesn't get implicitly set based on the initial table size. In my experiments, the table size was in the range of 22 bytes, so a single page (== what we used until now) seems to be good enough. Now that we have defined maximum

Re: [PATCH v2] vhost-user.rst: add clarifying language about protocol negotiation

2021-03-04 Thread Alex Bennée
Michael S. Tsirkin writes: > On Wed, Mar 03, 2021 at 02:50:11PM +, Alex Bennée wrote: >> Make the language about feature negotiation explicitly clear about the >> handling of the VHOST_USER_F_PROTOCOL_FEATURES feature bit. Try and >> avoid the sort of bug introduced in vhost.rs REPLY_ACK pr

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Thu, Mar 04, 2021 at 10:25:33AM +, Daniel P. Berrangé wrote: On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: > > > > Hi Jason, > > as reported

Re: [PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

2021-03-04 Thread Claudio Fontana
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: > Yet again bugfixes and cleanup patches noticed while > rebasing my "Support disabling TCG on ARM (part 2)" series. > > Sending them independently as they aren't directly dependent > of it so don't have to be delayed by other unanswered questions

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 12:12:51PM +0100, Stefano Garzarella wrote: > On Thu, Mar 04, 2021 at 10:25:33AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: > > > On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > > > > On Wed, Mar

[PATCH v2] qemu-option: do not suggest using the delay option

2021-03-04 Thread Paolo Bonzini
The "delay" option was a hack that was introduced to allow writing "nodelay". We are adding a "nodelay" option to be used as "nodelay=on", so recommend it instead of "delay". This is quite ugly, but a proper deprecation of "delay" cannot be done if QEMU starts suggesting it. Since it's the only c

Re: [PATCH v3 2/2] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-04 Thread Thomas Huth
On 04/03/2021 11.39, Daniel P. Berrangé wrote: On Wed, Mar 03, 2021 at 10:09:48PM -0500, Daniele Buono wrote: QEMU has had options to enable control-flow integrity features for a few months now. Add two sets of build/check/acceptance jobs to ensure the binary produced is working fine. The three

Re: [PATCH v2] qemu-option: do not suggest using the delay option

2021-03-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210304111743.118752-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210304111743.118752-1-pbonz...@redhat.com Subject: [PATCH v2] qemu-option: do not sugg

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Christian Schoenebeck
On Mittwoch, 3. März 2021 08:13:06 CET Gerd Hoffmann wrote: > Hi, > > > JACK clients with consumer purpose often auto connect to system ports by > > default because their users mostly use JACK just as a consumer desktop > > sound server. And I assume this applies to José as well. > > Hmm, ok.

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

2021-03-04 Thread Claudio Fontana
Hi Peter, what do you think of the following patch? We messaged yesterday about cortex-a15 being the default cpu for virt, this patch would need also changing the default CPU for virt under KVM I would think. Or, we could change the virt default cpu to "max"? Thanks, Claudio On 2/5/21 4:19

Re: [PATCH 1/4] docker: Add Hexagon image

2021-03-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Alessandro Di Federico > > Signed-off-by: Alessandro Di Federico > [PMD: Base on qemu/debian10, add missing EXTRA_FILES, remove X86] > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 2 + > .../dockerfile

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

2021-03-04 Thread Peter Maydell
On Fri, 5 Feb 2021 at 14:44, Philippe Mathieu-Daudé wrote: > > Support for ARMv7 has been dropped in commit 82bf7ae84ce > ("target/arm: Remove KVM support for 32-bit Arm hosts"). > Restrict the 32-bit CPUs to --enable-tcg builds. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c |

Re: [PATCH v6 03/11] target/arm: Restrict ARMv4 cpus to TCG accel

2021-03-04 Thread Claudio Fontana
Hi, I am trying to take these patches, in the hope that they help with some of the test issues I am having with the kvm-only build, but they fail with: target/arm/Kconfig: does not exist in index so I guess I need the "target/arm/Kconfig" series right, how can I find that one? Thanks, Claud

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 12:24:44PM +0100, Christian Schoenebeck wrote: > On Mittwoch, 3. März 2021 08:13:06 CET Gerd Hoffmann wrote: > > Hi, > > > > > JACK clients with consumer purpose often auto connect to system ports by > > > default because their users mostly use JACK just as a consumer des

Re: [PATCH v3 2/2] gitlab-ci.yml: Add jobs to test CFI flags

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 12:21:16PM +0100, Thomas Huth wrote: > On 04/03/2021 11.39, Daniel P. Berrangé wrote: > > On Wed, Mar 03, 2021 at 10:09:48PM -0500, Daniele Buono wrote: > > > QEMU has had options to enable control-flow integrity features > > > for a few months now. Add two sets of build/che

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Kevin Wolf
Am 03.03.2021 um 18:40 hat Stefano Garzarella geschrieben: > Hi Jason, > as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD > writing data is very slow compared to a raw file. > > Comparing raw vs QCOW2 image creation with RBD I found that we use a > different object size, for

Re: [PATCH v2] vfio-ccw: Do not read region ret_code after write

2021-03-04 Thread Cornelia Huck
On Wed, 3 Mar 2021 17:07:39 +0100 Eric Farman wrote: > A pwrite() call returns the number of bytes written (or -1 on error), > and vfio-ccw compares this number with the size of the region to > determine if an error had occurred or not. > > If they are not equal, this is a failure and the errno

Re: [PATCH 3/4] gitlab-ci: Build Hexagon cross-toolchain

2021-03-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Add a job to build the Debian based Hexagon cross-toolchain image. > > This image requires a lot of compute time, too much for the common > shared runners. To avoid having the job to timeout, it has to be > built with custom unlimited runner. For this reason we

Re: [PATCH] nbd: server: Report holes for raw images

2021-03-04 Thread Kevin Wolf
Am 25.02.2021 um 19:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.02.2021 19:58, Eric Blake wrote: > > On 2/19/21 10:42 AM, Eric Blake wrote: > > > > > > To me, data=false looks compatible with NBD_STATE_HOLE. From user point > > > > of view, getting same results from qemu-nbd and qemu-img

Re: [PATCH 7/7] ui/gtk: add clipboard support

2021-03-04 Thread Gerd Hoffmann
Hi, > > Well, I want gtk deal with the compatibility stuff like all the > > different target names we have for text ("STRING", "text/plain", ...), > > and using gtk_clipboard_set_text() seems to be the only way to do that. > > > > I'm open to better ideas. > Basically implement an async version

[PATCH v2 2/2] tests/acceptance: Test ast2600 machine

2021-03-04 Thread Joel Stanley
This tests a Debian multi-soc arm32 Linux kernel on the AST2600 based Tacoma BMC machine. There is no root file system so the test terminates when boot reaches the stage where it attempts and fails to mount something. Signed-off-by: Joel Stanley --- v2: Update expected strings so test passes ---

[PATCH v2 0/2] tests/acceptance: Test Aspeed ARM machines

2021-03-04 Thread Joel Stanley
v2: Fix ast2600 test, thanks Cédric for the review. This adds tests for the Aspeed ARM SoCs. The AST2400 and AST2500 tests use OpenBMC images from that project, fetched from github releases. The AST2600 test uses a Debian arm32 kernel. Note that the ast2600 test will fail if [1] is not applied. I

[PATCH v2 1/2] tests/acceptance: Test ast2400 and ast2500 machines

2021-03-04 Thread Joel Stanley
Test MTD images from the OpenBMC project on AST2400 and AST2500 SoCs from ASPEED, by booting Palmetto and Romulus BMC machines. The images are fetched from OpenBMC's release directory on github. Co-developed-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-

[PULL 6/8] ui/console: Add placeholder flag to message surface

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki The surfaces created with former qemu_create_message_surface did not display the content from the guest and always contained simple messages describing the reason. A display backend may want to hide the window showing such a surface. This change renames the function to qemu_c

[PULL 1/8] ui/cocoa: Remove the uses of full screen APIs

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki The detections of [NSView -enterFullScreen:] and [NSView -exitFullScreen:] were wrong. A detection is coded as: [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] but it should be: [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)]

[PATCH] aspeed: Emulate the AST2600A3

2021-03-04 Thread Joel Stanley
This is the latest revision of the ASPEED 2600 SoC. Reset values are taken from v8 of the datasheet. Signed-off-by: Joel Stanley --- include/hw/misc/aspeed_scu.h | 2 ++ hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_scu.c | 32 +--- 3 files changed, 2

[PULL 0/8] Ui 20210304 patches

2021-03-04 Thread Gerd Hoffmann
The following changes since commit cbcf09872a936ccefef6a34298046d3b9aefc148: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-updates-240= 221-1' into staging (2021-02-25 19:07:58 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-202

[PULL 5/8] ui/cocoa: Replace fprintf with error_report

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210223131106.21166-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index

[PULL 7/8] ui/console: Pass placeholder surface to displays

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki ui/console used to accept NULL as graphic console surface, but its semantics was inconsistent among displays: - cocoa and gtk-egl perform NULL dereference. - egl-headless, spice and spice-egl do nothing. - gtk releases underlying resources. - sdl2-2d and sdl2-gl destroys the w

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-04 Thread Gerd Hoffmann
On Wed, Mar 03, 2021 at 06:27:27PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 3, 2021 at 4:13 PM Gerd Hoffmann wrote: > > > Hi, > > > > > > +case Z_BUF_ERROR: > > > > +out_len <<= 1; > > > > +if (out_len > (1 << 20)) { > > > > > > > > > > 1Mb isn't tha

[PULL 8/8] virtio-gpu: Do not distinguish the primary console

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki In the past, virtio-gpu set NULL as the surface for the secondary consoles to hide its window. The distinction is now handled in ui/console and the display backends and virtio-gpu does no longer have to do that. Signed-off-by: Akihiko Odaki Message-Id: <20210225101316.83940-

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-03-04 Thread Gerd Hoffmann
Hi, > > I don't see the > > agent doing the same (I might be missing something). > > Hmm, ok. Guess I should better be prepared to receive messages larger > than VD_AGENT_MAX_DATA_SIZE ... Confirmed. Cut+paste large text blocks in the guest -> hangs qemu vdagent implementation, because the m

Re: [PULL 0/1] virtiofs queue (minor security)

2021-03-04 Thread Peter Maydell
staging > (2021-03-03 16:55:15 +) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210304 > > for you to fetch changes up to e586edcb410543768ef009eaa22a2d9dd4a53846: > > virtiofs: drop remapped

[PULL 2/8] ui/gtk: vte: fix sending multiple characeters

2021-03-04 Thread Gerd Hoffmann
From: Zack Marvel When using the GTK UI with libvte, multicharacter keystrokes are not sent correctly (such as arrow keys). gd_vc_in should check the CharBackend's can_receive instead of assuming multiple characters can be received. This is not an issue for e.g. the SDL UI because qemu_chr_be_wri

[PULL 3/8] ui/cocoa: Fix stride resolution of pixman image

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki A display can receive an image which its stride is greater than its width. In fact, when a guest requests virtio-gpu to scan out a smaller part of an image, virtio-gpu passes it to a display as an image which its width represents the one of the part and its stride equals to th

[PULL 4/8] configure: Improve OpenGL dependency detections

2021-03-04 Thread Gerd Hoffmann
From: Akihiko Odaki This has the following visible changes: - GBM is required only for OpenGL dma-buf. - X11 is explicitly required by gtk-egl. - EGL is now mandatory for the OpenGL displays. The last one needs some detailed description. Before this change, EGL was tested only for OpenGL dma-bu

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Gerd Hoffmann
> I'd suggest a "auto-connect-ports" boolean option, which defaults to > enabled. > > - auto-connect-ports == true, connect-ports= > > => use the proposed default regex for connect ports > > - auto-connect-ports == true, connect-ports = regex > > => use the connect-ports regex > >

Re: [PATCH 04/19] cpu: Croup accelerator-specific fields altogether

2021-03-04 Thread Philippe Mathieu-Daudé
On 3/3/21 7:22 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) Typo in patch subject "Group" ;) > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > index

Re: [PATCH 1/2] tests/acceptance: Test ast2400 and ast2500 machines

2021-03-04 Thread Philippe Mathieu-Daudé
On 3/3/21 12:19 PM, Joel Stanley wrote: > On Wed, 3 Mar 2021 at 10:19, Philippe Mathieu-Daudé wrote: >> >> On 3/3/21 2:22 AM, Joel Stanley wrote: >>> Test MTD images from the OpenBMC project on AST2400 and AST2500 SoCs >>> from ASPEED, by booting Palmetto and Romulus BMC machines. >>> >>> The imag

Re: [PATCH] aspeed: Emulate the AST2600A3

2021-03-04 Thread Philippe Mathieu-Daudé
On 3/4/21 1:43 PM, Joel Stanley wrote: > This is the latest revision of the ASPEED 2600 SoC. > > Reset values are taken from v8 of the datasheet. > > Signed-off-by: Joel Stanley > --- > include/hw/misc/aspeed_scu.h | 2 ++ > hw/arm/aspeed_ast2600.c | 2 +- > hw/misc/aspeed_scu.c

[PATCH] vfio: Support host translation granule size

2021-03-04 Thread Kunkun Jiang
The cpu_physical_memory_set_dirty_lebitmap() can quickly deal with the dirty pages of memory by bitmap-traveling, regardless of whether the bitmap is aligned correctly or not. cpu_physical_memory_set_dirty_lebitmap() supports pages in bitmap of host page size. So it'd better to set bitmap_pgsize t

Re: [PATCH v1 0/2] Get rid of legacy_s390_alloc() and phys_mem_set_alloc()

2021-03-04 Thread Cornelia Huck
On Wed, 3 Mar 2021 14:09:14 +0100 David Hildenbrand wrote: > Let's finally get rid of the alternative allocation function. Outcome of > a discussion in: > https://lkml.kernel.org/r/20210303123517.04729c1e.coh...@redhat.com > > David Hildenbrand (2): > s390x/kvm: Get rid of legacy_s390_all

Re: [PATCH 0/4] hexagon: Add Docker image & testing to gitlab-ci

2021-03-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi, > > This series is a rework of the 'Add Dockerfile for hexagon' patch > from Alessandro/Brian that Taylor sent in v8: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg780330.html > but adapted to mainstream. Queued patches 1 and 2 to testing/next, th

Re: [PATCH] hw/sh4/sh7750_regs: Replace link to license by its full content

2021-03-04 Thread Philippe Mathieu-Daudé
ping? On 2/22/21 7:56 PM, Philippe Mathieu-Daudé wrote: > This file is borrowed from the RTEMS source code, which comes > with a GPL-2.0-or-later license with a header exception. > > Expand the GPL-2.0-or-later license in place to not be dependent > on a 3rd party website. This also fix the misle

[Bug 1523811] Re: USB assert failure on dev-storage.c

2021-03-04 Thread Cheolwoo,Myung
** Description changed: On executing the attached python script in the guest OS, QEMU dies with assert failure: [run python script in guest root shell] # python a.py [host message] qemu-system-x86_64: hw/usb/dev-storage.c:445: usb_msd_handle_data: Assertion `le32_to_cpu(s->csw.r

Re: [PATCH] arm: bump amount of PMU counters to pass SBSA ACS

2021-03-04 Thread Leif Lindholm
On Wed, Mar 03, 2021 at 18:06:46 +, Peter Maydell wrote: > On Wed, 3 Mar 2021 at 17:48, Leif Lindholm wrote: > > It would be good if we could get 6.0 closer to SBSA compliance. > > How far away are we at the moment ? > > > Would it be worth the effort to make this controllable per cpu model?

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 02:12:52PM +0100, Gerd Hoffmann wrote: > > I'd suggest a "auto-connect-ports" boolean option, which defaults to > > enabled. > > > > - auto-connect-ports == true, connect-ports= > > > > => use the proposed default regex for connect ports > > > > - auto-connect-por

Re: [RFC PATCH 00/19] accel: Introduce AccelvCPUState opaque structure

2021-03-04 Thread Paolo Bonzini
On 03/03/21 19:22, Philippe Mathieu-Daudé wrote: Series is organized as: - preliminary trivial cleanups - introduce AccelvCPUState - move WHPX fields (build-tested) - move HAX fields (not tested) - move KVM fields (build-tested) - move HVF fields (not tested) This approach prevents adding a TCG

  1   2   3   4   >