From: Daniel P. Berrangé
The standard is to use 2 space indent, not 3.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210216132954.295906-4-berra...@redhat.com>
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 16
1 file changed, 8 insert
From: Philippe Mathieu-Daudé
Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs
of failed acceptances") we display the log content of failing tests
(Avocado "FAIL" event).
Since we are also interested in tests timeouting, update our global
Avocado config to display log content fo
From: Daniel P. Berrangé
This allows the build jobs to start running as soon as their respective
container image is ready, instead of waiting for all container builds
to finish.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210216132954.295906-3-berra...@
The s390-ccw bios code panics if it can not boot successfully. In
this case, it does not make sense that we wait the full 600 seconds
for the boot sector test to finish and can signal the failure
immediately, thus let's check the status of the guest with the
"query-status" QMP command here, too.
R
There were recently some patches on the list which had their "From:"
line mangled like this:
From: qemu_oss--- via
Since our test in the checkpatch.pl script did not trigger here, the
patches finally also ended up in a pull request, with the wrong author
set. So let's improve the regular expres
Even though the host machines that run the Travis CI jobs have
quite a lot of CPUs (e.g. nproc in an aarch64 job reports 32), the
containers on Travis are still limited to 2 vCPUs according to:
https://docs.travis-ci.com/user/reference/overview/#approx-boot-time
So we do not gain much when compi
It's now possible to also run the non-x86 TCG tests with TCI.
Message-Id: <20210127055903.40148-1-th...@redhat.com>
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c06c20be6c..8b6d495288
From: Philippe Mathieu-Daudé
Commit 299e6f19b3e ("vhost-net: revamp configure logic") added
the --enable-vhost-kernel option.
Disable it in the build-disable job.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Wainer dos Santos Moschetta
Message-Id: <20210131104621.221602-1-f4...@amsat.org
Am 19.02.21 um 07:11 schrieb P J P:
Hello Alex, Stefan, all
+-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+
| Maybe the infinite loop mentioned in the commit message is actually a DMA
| recursion issue? I'm providing a reproducer for a DMA re-entracy issue
| below. With this patch appli
Am 19.02.21 um 09:08 schrieb Stefan Weil:
Okay, I can confirm the infinite recursion now.
The test case triggers memory writes by the hardware which cause new
actions of the same hardware and so on.
I don't know how the real hardware would handle that case.
For QEMU we can extend the curren
From: Marc-André Lureau
qmp_disable_command() now takes an optional error string to return a
more explicit error message.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1928806
Signed-off-by: Marc-André Lureau
---
v3:
- back to passing an error string, but appended to the error message.
Hi,
> I'm not against cleaning up the includes for virtio-ccw devices, but I
> tend to see that as a separate, less pressing issue.
Well, it would allow to build virtio-ccw as common code (i.e. move from
specific_ss to softmmu_ss).
> > Alternatively add support for
> > target-specific modules
There is no need of dynamic allocation as dcl is a small singleton.
Static allocation reduces code size and makes hacking with ui/cocoa a
bit easier.
Signed-off-by: Akihiko Odaki
---
ui/cocoa.m | 65 ++
1 file changed, 31 insertions(+), 34 dele
kCGColorSpaceGenericRGB | Apple Developer Documentation
https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> Deprecated
> Use kCGColorSpaceSRGB instead.
Signed-off-by: Akihiko Odaki
---
ui/cocoa.m | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/
Hi,
> I don't see way around target-specific modules. With the modifications
> suggested by Thomas and Connie, I was able to get the new module to
> compile regardless of the target,
Cool (should have checked all mails before sending replies ...).
> but that "fixes" s390x at the expense
> of b
ui/cocoa used to call exit immediately after calling
qemu_system_shutdown_request, which prevents QEMU from actually
perfoming system shutdown. Just sleep forever, and wait QEMU to call
exit and kill the Cocoa thread.
Signed-off-by: Akihiko Odaki
---
ui/cocoa.m | 2 +-
1 file changed, 1 insertio
This commit introduces "punch hole" operation and optimizes transfer
block size for macOS.
This commit introduces two additional members,
discard_granularity and opt_io to BlockSizes type in
include/block/block.h. Also, the members of the type are now
optional. Set -1 to discard_granularity and 0
Patchew URL:
https://patchew.org/QEMU/20210219085148.90545-1-akihiko.od...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210219085148.90545-1-akihiko.od...@gmail.com
Subject: [PATCH] block/file-posix: Opt
+-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+
| Is this a DMA re-entracy/stack-overflow issue? IIRC the plan was to have
| some sort of wider fix for these issues. There are bunch of these reports
| floating around at this point, I believe.
* It is similar to the eepro100 one.
Thank you.
Kevin Wolf writes:
> Am 18.02.2021 um 14:39 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 17.02.2021 um 16:32 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf writes:
>> >>
>> >> > When looking for an object in a struct in the external representation,
>> >> > check no
I think this could go via qemu-trivial.
Markus Armbruster writes:
> Markus Armbruster (2):
> backends/dbus-vmstate: Fix short read error handling
> vhost_user_gpu: Drop dead check for g_malloc() failure
>
> backends/dbus-vmstate.c | 5 -
> hw/display/vhost-user-gpu.c | 1 -
> 2 file
Hi Richard,
I think this commit is the cause of CID 1446711.
There is no concistancy between the various declarations of unlock_user():
bsd-user/qemu.h
static inline void unlock_user(void *host_ptr, abi_ulong guest_addr,
long len)
include/exec/softmmu-semi.h
sta
Hello Stefan,
+-- On Fri, 19 Feb 2021, Stefan Weil wrote --+
| If there are no recursions in normal use, the following patch should work:
|
| diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
| index 16e95ef9cc..2474cf3dc2 100644
| --- a/hw/net/eepro100.c
| +++ b/hw/net/eepro100.c
| @@ -279,6
On Thu, Feb 18, 2021 at 09:55:25PM +0200, Yuri Benditovich wrote:
> On Thu, Feb 18, 2021 at 11:35 AM Daniel P. Berrangé
> wrote:
>
> > On Wed, Feb 10, 2021 at 02:19:59PM +0800, Jason Wang wrote:
> > >
> > > On 2021/2/9 下午11:04, Michael S. Tsirkin wrote:
> > > > On Tue, Feb 09, 2021 at 02:51:05PM
On Thu, Feb 18, 2021 at 12:15:35PM -0800, Doug Evans wrote:
FWIW, normally when QEMU updates libslirp, the commit message is
set to contain the "git shortlog old..new" output
> Signed-off-by: Doug Evans
> ---
>
> Changes from v3:
> - pick up latest libslirp patch to reject ipv6 addr-any for gue
2021年2月17日(水) 22:09 Gerd Hoffmann :
>
> On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote:
> > The detections of full screen APIs were wrong. A detection is coded as:
> > [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)]
> > but it should be:
> > [NSView
> > instanc
On Fri, 19 Feb 2021 09:45:45 +0100
Gerd Hoffmann wrote:
> > but that "fixes" s390x at the expense
> > of breaking all the other targets. For example:
> > ./qemu-system-x86_64 -device help
> > Type 'virtio-gpu-ccw' is missing its parent 'virtio-ccw-device'
> > Aborted
>
> Hmm, this is a new fai
In nested mode, we call the set_pasid_table() callback on each STE
update to pass the guest stage 1 configuration to the host and
apply it at physical level.
In the case of live migration, we need to manual call the
set_pasid_table() to load the guest stage 1 configurations to the
host. If this op
Hello folks,
These are the machine lists that included cortex-a72 when I gave
qemu-system-aarch64 --machine xxx --cpu help.
(I replaced xxx with all the machine I got from qemu-system-aarch64
--machine help. Of course I used simple script for that. And I remove 'virt'
from the list.)
akita
Hi all,
Since the SMMUv3's nested translation stages[1] has been introduced by Eric, we
need to pay attention to the migration of VFIO PCI devices in SMMUv3 nested
stage
mode. At present, it is not yet supported in QEMU. There are two problems in the
existing framework.
First, the current way to
Extract part of the code from vfio_sync_dirty_bitmap to form a
new helper, which allows to mark dirty pages of a RAM section.
This helper will be called for nested stage.
Signed-off-by: Kunkun Jiang
---
hw/vfio/common.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-
On Intel, the DMA mapped through the host single stage. Instead
we set up the stage 2 and stage 1 separately in nested mode as there
is no "Caching Mode".
Legacy vfio_listener_log_sync cannot be used in nested stage as we
don't need to pay close attention to stage 1 mapping. This patch adds
vfio_p
It is not used, and it is unlikely that a new use case will emerge
anytime soon because the scope of OpenGL contexts are limited due to
the nature of the frontend, VirGL, processing simple commands from the
guest.
Remove the function and ease implementing a new OpenGL backend a little.
Signed-off
OpenGL ES does not support conversion from the given data format
to the internal format with glTexImage2D.
Use the given data format as the internal format, and ignore
the given alpha channels with GL_TEXTURE_SWIZZLE_A in case the
format contains alpha channels.
Signed-off-by: Akihiko Odaki
---
Am 19.02.21 um 10:26 schrieb P J P:
Hello Stefan,
+-- On Fri, 19 Feb 2021, Stefan Weil wrote --+
| If there are no recursions in normal use, the following patch should work:
|
| diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
| index 16e95ef9cc..2474cf3dc2 100644
| --- a/hw/net/eepro100.c
On Thu, 18 Feb 2021 15:53:29 -0500
Matthew Rosato wrote:
> Some CLP response data was accidentally dropped when fixing endianness
> issues with the Query PCI Function CLP response. All of these values are
> sent as 0s to the guest for emulated devices, so the impact is only
> observed on passthr
From: Frank Chang
TB_FLAGS mem_idx bits was extended from 2 bits to 3 bits in
commit: c445593, but other TB_FLAGS bits for rvv and rvh were
not shift as well so these bits may overlap with each other when
rvv is enabled.
Signed-off-by: Frank Chang
---
target/riscv/cpu.h | 11 ++-
1 fil
On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote:
> The parsing is moved into new function inet_parse_host_and_port.
> This is done in preparation for using the function in net/slirp.c.
>
> Signed-off-by: Doug Evans
> ---
>
> Changes from v3:
> - this patch is new in v4
> - provides
On Fri, 19 Feb 2021 at 08:05, wrote:
> These are the machine lists that included cortex-a72 when I gave
> qemu-system-aarch64 --machine xxx --cpu help.
Adding '--machine whatever' to your command line does not change
the output of '--cpu help'. As Philippe says, it happens that
QEMU processes --c
Hi,
Any comment?
This fix is really needed to fix a bug that prevents to use virtio-net failover
on recent
kernel.
Thanks,
Laurent
On 12/02/2021 14:52, Laurent Vivier wrote:
> When the pcie slot is initialized, by default PCI_EXP_LNKSTA_DLLLA
> (Data Link Layer Link Active) is set in PCI_EXP_L
ui/console used to accept NULL as graphic console surface, but its
semantics was inconsistent among displays:
- cocoa and gtk-egl perform NULL dereference.
- egl-headless, spice and spice-egl do nothing.
- gtk releases underlying resources.
- sdl2-2d and sdl2-gl destroys the window.
- vnc shows a m
Signed-off-by: Akihiko Odaki
---
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index bac2d6fa2b2..692fd17b0e0 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -965,7 +965,7 @@ static void vi
Hi Peter Maydell,
Thanks, that made it clearer to me.(actually I was reading the page you
mentioned)
Chan Kim
> -Original Message-
> From: Peter Maydell
> Sent: Friday, February 19, 2021 7:04 PM
> To: Chan Kim
> Cc: Philippe Mathieu-Daudé ; qemu-discuss disc...@nongnu.org>; Paolo Bon
On Fri, 19 Feb 2021 at 08:46, Akihiko Odaki wrote:
>
> ui/cocoa used to call exit immediately after calling
> qemu_system_shutdown_request, which prevents QEMU from actually
> perfoming system shutdown. Just sleep forever, and wait QEMU to call
> exit and kill the Cocoa thread.
>
> Signed-off-by:
On Fri, 19 Feb 2021, Akihiko Odaki wrote:
2021年2月17日(水) 22:09 Gerd Hoffmann :
On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote:
The detections of full screen APIs were wrong. A detection is coded as:
[NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)]
but it shou
On Fri, 19 Feb 2021 at 08:45, Akihiko Odaki wrote:
>
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> Signed-off-by: Akihiko Odaki
> ---
> ui/cocoa.m |
On Fri, 19 Feb 2021 at 03:06, Alexander Bulekov wrote:
>
> On 210210 2022, P J P wrote:
> > From: Prasad J Pandit
> >
> > While processing transmit (tx) descriptors in process_tx_desc()
> > various descriptor fields are not checked properly. This may lead
> > to infinite loop like issue. Add chec
> On 18 Feb 2021, at 21:26, Philippe Mathieu-Daudé wrote:
>
> On 2/18/21 9:10 PM, Stefan Sandström wrote:
>>> On 18 Feb 2021, at 20:59, Philippe Mathieu-Daudé wrote:
>>>
>>> Hi Stefan,
>>>
On 2/18/21 7:43 PM, Stefan Sandström wrote:
From: Stefan Sandstrom
Add and fix d
On 2021/2/18 22:42, Kirti Wankhede wrote:
>
>
> On 12/9/2020 1:39 PM, Shenming Lu wrote:
>> On ARM64 the VFIO SET_IRQS ioctl is dependent on the VM interrupt
>> setup, if the restoring of the VFIO PCI device config space is
>> before the VGIC, an error might occur in the kernel.
>>
>> So we move
Hi,
It looks like the build has been broken on Cirrus since at least 7b2c4c:
https://cirrus-ci.com/github/qemu/qemu
I did attempt to have a look but "vm-build-freebsd" seems to be failing
with a different error:
10:31:47 [alex.bennee@hackbox2:~/l/q/b/all] master|✔ + make vm-build-freebsd
On Fri, 19 Feb 2021 at 10:39, Alex Bennée wrote:
>
>
> Hi,
>
> It looks like the build has been broken on Cirrus since at least 7b2c4c:
>
> https://cirrus-ci.com/github/qemu/qemu
>
> I did attempt to have a look but "vm-build-freebsd" seems to be failing
> with a different error
FWIW the vm-bui
On Fri, Feb 19, 2021 at 10:29:50AM +, Alex Bennée wrote:
>
> Hi,
>
> It looks like the build has been broken on Cirrus since at least 7b2c4c:
>
> https://cirrus-ci.com/github/qemu/qemu
>
> I did attempt to have a look but "vm-build-freebsd" seems to be failing
> with a different error:
>
From: Stefan Sandstrom
Add and fix deallocation of temporary TCG registers in CRIS code
generation.
Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
---
target/cris/translate.c | 127 +++-
target/cris/translate_v10.c.inc | 70 --
2 files
Patchew URL: https://patchew.org/QEMU/20210219104548.4675-1-stef...@axis.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210219104548.4675-1-stef...@axis.com
Subject: [PATCH v3] Correct CRIS TCG register lifetime
On Thu, 18 Feb 2021 at 16:29, Richard Henderson
wrote:
>
> Initial commit for the Qualcomm Hexagon processor.
>
>
Hi; Coverity Scan reports a pile of new issues in the
From: Stefan Sandstrom
Add and fix deallocation of temporary TCG registers in CRIS code
generation.
Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
Signed-off-by: Stefan Sandström
---
target/cris/translate.c | 127 +++-
target/cris/translate_v10.c.inc |
Peter Maydell writes:
> On Fri, 19 Feb 2021 at 10:39, Alex Bennée wrote:
>>
>>
>> Hi,
>>
>> It looks like the build has been broken on Cirrus since at least 7b2c4c:
>>
>> https://cirrus-ci.com/github/qemu/qemu
>>
>> I did attempt to have a look but "vm-build-freebsd" seems to be failing
>> w
2021年2月19日(金) 19:24 BALATON Zoltan :
>
> On Fri, 19 Feb 2021, Akihiko Odaki wrote:
> > 2021年2月17日(水) 22:09 Gerd Hoffmann :
> >>
> >> On Fri, Feb 12, 2021 at 09:05:40AM +0900, Akihiko Odaki wrote:
> >>> The detections of full screen APIs were wrong. A detection is coded as:
> >>> [NSView respondsToS
This patch allows cloudinit images download when ssh
key is not specified.
Signed-off-by: Pavel Dovgalyuk
---
tests/acceptance/avocado_qemu/__init__.py |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avoca
On 13.02.21 22:54, Fam Zheng wrote:
On 2021-02-11 15:26, Philippe Mathieu-Daudé wrote:
The null-co driver doesn't zeroize buffer in its default config,
because it is designed for testing and tests want to run fast.
However this confuses security researchers (access to uninit
buffers).
I'm a li
We're building a lot of containers in the gitlab-CI that we never use.
This takes away network bandwidth and CPU time from other jobs for no
use, so let's remove them for now. The individual containers could be
re-added later when we really need them.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/
ui/cocoa used to call exit immediately after calling
qemu_system_shutdown_request, which prevents QEMU from actually
perfoming system shutdown. Just sleep forever, and wait QEMU to call
exit and kill the Cocoa thread.
Signed-off-by: Akihiko Odaki
---
ui/cocoa.m | 8 +++-
1 file changed, 7 in
On Fri, Feb 19, 2021 at 11:53:48AM +0100, Stefan Sandström wrote:
> From: Stefan Sandstrom
>
> Add and fix deallocation of temporary TCG registers in CRIS code
> generation.
Thanks Stefan,
There's still a couple of minor stylistic issues.
The Subject/Summary should be prefixed with the code ar
On Tue, 16 Feb 2021 12:18:30 +0100
Cornelia Huck wrote:
> The virtio standard specifies that any non-transitional device must
> reject commands prior to revision setting (which we do) and else
> assume revision 0 (legacy) if the driver sends a non-revision-setting
> command first. We neglected to
kCGColorSpaceGenericRGB | Apple Developer Documentation
https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> Deprecated
> Use kCGColorSpaceSRGB instead.
This change also removes the legacy color space specification for
PowerPC.
Signed-off-by: Akihiko Odaki
---
ui/coc
Signed-off-by: Akihiko Odaki
---
configure| 11 +--
include/ui/egl-helpers.h | 2 ++
ui/meson.build | 1 +
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index 9f016b06b54..bd96929d7b4 100755
--- a/configure
+++ b/configure
On Fri, Feb 19, 2021 at 12:09:50PM +0100, Thomas Huth wrote:
> We're building a lot of containers in the gitlab-CI that we never use.
> This takes away network bandwidth and CPU time from other jobs for no
> use, so let's remove them for now. The individual containers could be
> re-added later when
On Fri, 19 Feb 2021 at 11:28, Akihiko Odaki wrote:
>
> kCGColorSpaceGenericRGB | Apple Developer Documentation
> https://developer.apple.com/documentation/coregraphics/kcgcolorspacegenericrgb
> > Deprecated
> > Use kCGColorSpaceSRGB instead.
>
> This change also removes the legacy color space spec
Hi,
This series aims to improve user experience by providing
a better error message when the user tries to enable KVM
on machines not supporting it.
Regards,
Phil.
Philippe Mathieu-Daudé (7):
accel/kvm: Check MachineClass kvm_type() return value
hw/boards: Introduce 'kvm_supported' field to
MachineClass::kvm_type() can return -1 on failure.
Document it, and add a check in kvm_init().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/boards.h | 3 ++-
accel/kvm/kvm-all.c | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/hw/boards.h b/include/hw/boa
Introduce the 'kvm_supported' field to express whether
a machine supports KVM acceleration or not.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/boards.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 68d3d10f6b0..0959aa743ee 100644
The following PowerPC machines support KVM:
- 40p
- bamboo
- g3beige
- mac99
- mpc8544ds
- ppce500
- pseries
- sam460ex
- virtex-ml507
Signed-off-by: Philippe Mathieu-Daudé
---
RFC: I'm surprise by this list, but this is the result of
auditing calls to kvm_enabled() checks.
---
hw/ppc/e500p
The following ARM machines support KVM:
- virt
- sbsa-ref
- xlnx-versal-virt
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/sbsa-ref.c | 1 +
hw/arm/virt.c | 1 +
hw/arm/xlnx-versal-virt.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa
Now that we added the 'kvm_supported' field to MachineClass
and all our machines able to use KVM have this field set,
we can check it in kvm_init() and exit gracefully with
a friendly error message.
Before:
$ qemu-system-aarch64 -M raspi3b -enable-kvm
qemu-system-aarch64: /build/qemu-ETIdrs/q
On 2/16/21 7:45 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/parallels.h | 6 +-
> block/parallels-ext.c | 286 ++
> block/parallels.c | 18 +++
> block/meson.build | 3 +-
> 4 files ch
Vivek Goyal writes:
> Hi,
>
> This is V2 of the patches. Changes since v1 are.
>
> - Rebased on top of latest master.
> - Took care of Miklos's comments to block acl xattrs if user
> explicitly disabled posix acl.
>
> Luis Henriques reported that fstest generic/099 fails with virtiofs.
> Little
The following MIPS machines support KVM:
- malta
- loongson3-virt
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/loongson3_virt.c | 1 +
hw/mips/malta.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c
index d4a82fa5367..c5ef44
We hint the 'has_rpu' property is no longer required since commit
6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
option") which was released in QEMU v2.11.0.
3 years later we feel safe enough to remove it without using the
usual deprecation policy.
Signed-off-by: Philippe Mathie
All s390-ccw-virtio machines support KVM.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/s390-virtio-ccw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 2972b607f36..259b4b4397e 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/
On Fri, 19 Feb 2021 at 11:44, Philippe Mathieu-Daudé wrote:
> This series aims to improve user experience by providing
> a better error message when the user tries to enable KVM
> on machines not supporting it.
Thanks for having a look at this; fixing the ugly assertion
failure if you try to enab
On 2/16/21 7:45 PM, Vladimir Sementsov-Ogievskiy wrote:
> Test support for reading bitmap from parallels image format.
> parallels-with-bitmap.bz2 is generated on Virtuozzo by
> parallels-with-bitmap.sh
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> .../sample_images/parallels-with-bitma
On Fri, Feb 19, 2021 at 12:44:23PM +0100, Philippe Mathieu-Daudé wrote:
> Introduce the 'kvm_supported' field to express whether
> a machine supports KVM acceleration or not.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/boards.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> dif
On Fri, 19 Feb 2021 at 11:51, Philippe Mathieu-Daudé wrote:
>
> We hint the 'has_rpu' property is no longer required since commit
> 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
> option") which was released in QEMU v2.11.0.
>
> 3 years later we feel safe enough to remove it wit
On 16.02.21 18:16, Alberto Garcia wrote:
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/087 | 8 ++--
tests/qemu-iotests/184 | 18 ++
tests/qemu-iotests/218 | 2 +-
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/245 | 4 ++--
tests/qemu
On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series aims to improve user experience by providing
> a better error message when the user tries to enable KVM
> on machines not supporting it.
Improved error message is good, but it is better if the mgmt apps
On 2/19/21 12:09 PM, Thomas Huth wrote:
> We're building a lot of containers in the gitlab-CI that we never use.
> This takes away network bandwidth and CPU time from other jobs for no
> use, so let's remove them for now. The individual containers could be
> re-added later when we really need them.
From: John Snow
Trivial; make the error message just a pinch more explicit in case we
trip this by accident in the future.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-12-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/qapi/introsp
The following changes since commit 91416a4254015e1e3f602f2b241b9ddb7879c10b:
Merge remote-tracking branch
'remotes/stsquad/tags/pull-plugin-updates-180221-1' into staging (2021-02-18
13:27:03 +)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-202
From: John Snow
It does happen to be a list (as of now), but we can describe it in more
general terms with no loss in accuracy to allow tuples and other
constructs.
In the future, we can write "ifcond: Sequence[str] = ()" as a default
parameter, which we could not do safely with a Mutable type l
From: John Snow
At present, we open-code this in _make_tree itself; but if the structure
of the tree changes, this is brittle. Use an explicit recursive call to
_make_tree when appropriate to help keep the interior node typing
consistent.
A consequence of doing this is that the 'ifcond' key of t
From: John Snow
We don't need to create an empty, mutable list to pass to _gen_tree;
since it is now typed as a Sequence, we can use the empty tuple as a
default and omit the argument.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-19-js...@redhat.com>
Reviewed-by: Markus Armbruste
From: John Snow
This mimics how a typed object works, where 'if' and 'comment' are
always set, regardless of if they have a value set or not.
It is safe to do this because of the way that _tree_to_qlit processes
these values (using dict.get with a default of None), resulting in no
change of outp
From: John Snow
The introspect visitor is stateful, but expects that it will have a
schema to refer to. Add assertions that state this.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-3-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/
From: John Snow
This is only used to pass in a dictionary with a comment already set, so
skip the runaround and just accept the (optional) comment.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-8-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
-
From: John Snow
NB: The type aliases (SchemaInfo et al) declare intent for some of the
"dictly-typed" objects we pass around in introspect.py. They do not
enforce the shape of those objects, and cannot, until Python 3.7 or
later. (And even then, it may not be "worth it".)
Annotations are also ad
From: John Snow
Subjective, but I find getting rid of the comprehensions helps. Also,
divide the sections into scalar and non-scalar sections, and remove
old-style string formatting.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-13-js...@redhat.com>
Reviewed-by: Markus Armbruster
From: John Snow
_tree_to_qlit is called recursively on dict values (isolated from their
keys); at such a point in generating output it is too late to apply an
ifcond. Similarly, comments do not necessarily have a "tidy" place they
can be printed in such a circumstance.
Forbid this usage by renam
On 2/19/21 12:55 PM, Peter Maydell wrote:
> On Fri, 19 Feb 2021 at 11:44, Philippe Mathieu-Daudé
> wrote:
>> This series aims to improve user experience by providing
>> a better error message when the user tries to enable KVM
>> on machines not supporting it.
>
> Thanks for having a look at this
On 2/19/21 1:00 PM, Daniel P. Berrangé wrote:
> On Fri, Feb 19, 2021 at 12:44:21PM +0100, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> This series aims to improve user experience by providing
>> a better error message when the user tries to enable KVM
>> on machines not supporting it.
>
> Improved e
From: John Snow
To reflect the work that went into strictly typing introspect.py,
punish myself by claiming credit.
Signed-off-by: John Snow
Message-Id: <20210216021809.134886-17-js...@redhat.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/qapi/introspect.py
1 - 100 of 395 matches
Mail list logo
