[PATCH v2 16/20] ui: add egl dmabuf import to gtkglarea

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau GtkGLArea is used on wayland, where EGL is usually available. Signed-off-by: Marc-André Lureau --- include/ui/gtk.h | 2 ++ ui/gtk-gl-area.c | 18 ++ ui/gtk.c | 22 ++ 3 files changed, 42 insertions(+) diff --git a/include/u

[PATCH v2 07/20] ui: add gd_gl_area_scanout_disable

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Require the callback, drop the fallback path. Signed-off-by: Marc-André Lureau --- include/ui/gtk.h | 1 + ui/console.c | 7 +-- ui/gtk-gl-area.c | 7 +++ ui/gtk.c | 1 + 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/include/ui/gtk.

[PATCH v2 19/20] chardev: check if the chardev is registered for yanking

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Not all chardevs are created via qmp_chardev_open_socket(), and those should not call the yank function registration, as this will eventually assert() not being registered. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 53 +++--

[PATCH v2 20/20] tests: add some virtio-gpu & vhost-user-gpu acceptance test

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau This will check virtio/vhost-user-vga & virgl are correctly initialized by the Linux kernel on an egl-headless display. Signed-off-by: Marc-André Lureau --- tests/acceptance/virtio-gpu.py | 161 + 1 file changed, 161 insertions(+) create

[PATCH v2 09/20] ui: remove console_has_gl_dmabuf()

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau This check is currently limited. It only is used by vhost-user-gpu (not by vfio-display), and will print an error repeatedly during run-time. We are going to dissociate the GL context from the DisplayChangeListener, and listeners may come and go. The following patches wil

Re: [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:40PM -0500, Cleber Rosa wrote: > Tests are supposed to be non-interactive, and ssh-keygen is asking for > a password when creating a key. Let's set an empty key, which prevents > ssh-keygen for asking for a password. > > Signed-off-by: Cleber Rosa > --- > tests/acc

[PATCH v2 18/20] display/ui: add a callback to indicate GL state is flushed

2021-02-04 Thread marcandre . lureau
From: Marc-André Lureau Displaying rendered resources requires blocking qemu GPU to avoid extra framebuffer copies. For an external display, via Spice currently, there is a callback to block/unblock the rendering in the same thread. But with the vhost-user-gpu backend, the qemu process doesn't h

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:42PM -0500, Cleber Rosa wrote: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra > arguments will not be set. >

Re: [PATCH 05/22] tests/acceptance/virtiofs_submounts.py: do not ask for ssh key password

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > Tests are supposed to be non-interactive, and ssh-keygen is asking for > a password when creating a key. Let's set an empty key, which prevents > ssh-keygen for asking for a password. We are not generating an empty key, just one that isn't protected by a passphrase. So:

Re: [PATCH 08/22] tests/acceptance/virtiofs_submounts.py: standardize port as integer

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:43PM -0500, Cleber Rosa wrote: > Instead of having to cast it whenever it's going to be used, let's > standardize it as an integer, which is the data type that will be > used most often. > > Given that the regex will only match digits, it's safe that we'll > end up ge

Re: [PATCH v15 04/23] cpu: Move synchronize_from_tb() to tcg_ops

2021-02-04 Thread Claudio Fontana
On 2/3/21 1:31 PM, Claudio Fontana wrote: > On 2/3/21 11:11 AM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> From: Eduardo Habkost >>> >>> Signed-off-by: Eduardo Habkost >>> >>> [claudio: wrapped target code in CONFIG_TCG] >>> Signed-off-by: Claudio Fontana >>> --- >>> include/hw/co

Re: [PATCH v4 2/3] virtiofsd: optionally return inode pointer from lo_do_lookup()

2021-02-04 Thread Greg Kurz
On Thu, 4 Feb 2021 09:45:37 + Stefan Hajnoczi wrote: > On Thu, Feb 04, 2021 at 09:25:28AM +0100, Greg Kurz wrote: > > On Wed, 3 Feb 2021 17:00:06 + > > Stefan Hajnoczi wrote: > > > > > On Wed, Feb 03, 2021 at 03:20:14PM +0100, Greg Kurz wrote: > > > > On Wed, 3 Feb 2021 11:37:18 +

Re: [PATCH 16/22] Acceptance Tests: introduce method for requiring an accelerator

2021-02-04 Thread Beraldo Leal
On Wed, Feb 03, 2021 at 12:23:51PM -0500, Cleber Rosa wrote: > Some tests explicitly require a QEMU accelerator to be available. > Given that this depends on some runtime aspects not known before > the test is started, such as the currently set QEMU binary, it's > left to be checked also at runtime

Re: [PATCH v2 03/20] vhost-user-gpu: use an extandable state enum for commands

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 11:52 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Introduce a pending state for commands which aren't finished yet, but > are being handled. See following patch. > > Signed-off-by: Marc-André Lureau > --- > contrib/vhost-user-gpu/vugpu.h | 8 +++-

Re: [PATCH v4 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-02-04 Thread Thomas Huth
On 03/02/2021 22.06, Cleber Rosa wrote: On Thu, Jan 28, 2021 at 12:51:20PM +0100, Thomas Huth wrote: [...] Could you elaborate on what's left to do to get the s390x and aarch64 runners enabled, and rebase your patches if necessary Basically what's needed is to enable the jobs, meaning committ

Re: [PATCH v2 25/36] block: introduce bdrv_drop_filter()

2021-02-04 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Using bdrv_replace_node() for removing filter is not good enough: it > keeps child reference of the filter, which may conflict with original > top node during permission update. > > Instead let's create new interface, which wil

Re: [PATCH v15 04/23] cpu: Move synchronize_from_tb() to tcg_ops

2021-02-04 Thread Alex Bennée
Claudio Fontana writes: > On 2/3/21 1:31 PM, Claudio Fontana wrote: >> On 2/3/21 11:11 AM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped target code in CONFIG_TCG] Signed-off-by: Cla

Re: [PATCH v2 23/36] block: adapt bdrv_append() for inserting filters

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 12:05, Kevin Wolf wrote: Am 04.02.2021 um 09:30 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.02.2021 00:33, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: int bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top,

Re: [RFC PATCH 6/9] virtiofsd: Add two new options for crash reconnection

2021-02-04 Thread Dr. David Alan Gilbert
* Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > We add two options for virtiofsd crash reconnection: reconnect | > no_reconnect(default) and > > User of virtiofsd should set "-o reconnect" for crash reconnection. Note > that, when "-o reconnect" is set, some options will not be suppor

Re: [RFC PATCH 9/9] virtiofsd: (work around) Comment qsort in inflight I/O tracking

2021-02-04 Thread Dr. David Alan Gilbert
* Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > This is a work around. The qsort function will malloc memory instead of use > stack memory when the resubmit_num is larger than 64 (total size larger than > 1024 Bytes). This will cause seccomp kill virtiofsd, so we comment qsort. > This

Re: [RFC 08/10] vhost: Add x-vhost-enable-shadow-vq qmp

2021-02-04 Thread Markus Armbruster
Eugenio Perez Martin writes: > On Tue, Feb 2, 2021 at 4:38 PM Eric Blake wrote: >> >> On 1/29/21 2:54 PM, Eugenio Pérez wrote: [...] >> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c >> > index 040f68ff2e..42836e45f3 100644 >> > --- a/hw/virtio/vhost.c >> > +++ b/hw/virtio/vhost.c >> > @@

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-02-04 Thread Michal Privoznik
On 1/21/21 5:15 PM, Igor Mammedov wrote: > Ping, please? Is there anything I can help with to get this merged? Libvirt's migration is broken without this patch [1] and thus I'd like to have this merged sooner rather than later. 1: There's a libvirt patch required but depends on this one. Tha

Re: [PATCH v2 25/36] block: introduce bdrv_drop_filter()

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 14:31, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Using bdrv_replace_node() for removing filter is not good enough: it keeps child reference of the filter, which may conflict with original top node during permission update. Instead let's cr

Re: [PATCH v2 26/36] block/backup-top: drop .active

2021-02-04 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > We don't need this workaround anymore: bdrv_append is already smart > enough and we can use new bdrv_drop_filter(). > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup-top.c | 38 +

Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist'

2021-02-04 Thread Michal Suchánek
On Thu, Feb 04, 2021 at 10:45:45AM +0100, Michal Suchánek wrote: > Hello, > > On Tue, Feb 02, 2021 at 09:58:14PM +0100, Philippe Mathieu-Daudé wrote: > > Follow the inclusive terminology from the "Conscious Language in your > > Open Source Projects" guidelines [*] and replace the word "blacklist"

Re: [PATCH v2 26/36] block/backup-top: drop .active

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 15:26, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: We don't need this workaround anymore: bdrv_append is already smart enough and we can use new bdrv_drop_filter(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup-top.c

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-02-04 Thread Jiaxun Yang
在 2021/2/2 上午4:04, BALATON Zoltan 写道: On Sun, 10 Jan 2021, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: +PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 1/9/21 9:16 PM, BALATON Zoltan wrote:

[PATCH v11 00/12] migration: bring improved savevm/loadvm/delvm to QMP

2021-02-04 Thread Daniel P . Berrangé
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html v5: ht

[PATCH v11 01/12] block: push error reporting into bdrv_all_*_snapshot functions

2021-02-04 Thread Daniel P . Berrangé
The bdrv_all_*_snapshot functions return a BlockDriverState pointer for the invalid backend, which the callers then use to report an error message. In some cases multiple callers are reporting the same error message, but with slightly different text. In the future there will be more error scenarios

[PATCH v11 06/12] block: rename and alter bdrv_all_find_snapshot semantics

2021-02-04 Thread Daniel P . Berrangé
Currently bdrv_all_find_snapshot() will return 0 if it finds a snapshot, -1 if an error occurs, or if it fails to find a snapshot. New callers to be added want to distinguish between the error scenario and failing to find a snapshot. Rename it to bdrv_all_has_snapshot and make it return -1 on erro

[PATCH v11 09/12] migration: introduce a delete_snapshot wrapper

2021-02-04 Thread Daniel P . Berrangé
Make snapshot deletion consistent with the snapshot save and load commands by using a wrapper around the blockdev layer. The main difference is that we get upfront validation of the passed in device list (if any). Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- include/migration/s

[PATCH v11 02/12] migration: Make save_snapshot() return bool, not 0/-1

2021-02-04 Thread Daniel P . Berrangé
From: Philippe Mathieu-Daudé Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Reviewed-by: Dr. David Alan Gilbert Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe

[PATCH v11 03/12] migration: stop returning errno from load_snapshot()

2021-02-04 Thread Daniel P . Berrangé
None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns a boolean value. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé [PMD: Return false/true instead of -1/0, docu

[PATCH v11 08/12] migration: wire up support for snapshot device selection

2021-02-04 Thread Daniel P . Berrangé
Modify load_snapshot/save_snapshot to accept the device list and vmstate node name parameters previously added to the block layer. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 18 -- migration/savevm.c | 30 ++

[PATCH v11 04/12] block: add ability to specify list of blockdevs during snapshot

2021-02-04 Thread Daniel P . Berrangé
When running snapshot operations, there are various rules for which blockdevs are included/excluded. While this provides reasonable default behaviour, there are scenarios that are not well handled by the default logic. Some of the conditions do not have a single correct answer. Thus there needs to

[PATCH v11 11/12] iotests: fix loading of common.config from tests/ subdir

2021-02-04 Thread Daniel P . Berrangé
common.rc assumes it is being sourced from the same directory and so also tries to source common.config from the current working directory. With the ability to now have named tests in the tests/ subdir we need to check two locations for common.config. Reviewed-by: Vladimir Sementsov-Ogievskiy Rev

[PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Daniel P . Berrangé
savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downside, however, libvirt and ap

[PATCH v11 05/12] block: allow specifying name of block device for vmstate storage

2021-02-04 Thread Daniel P . Berrangé
Currently the vmstate will be stored in the first block device that supports snapshots. Historically this would have usually been the root device, but with UEFI it might be the variable store. There needs to be a way to override the choice of block device to store the state in. Reviewed-by: Eric B

[PATCH v11 07/12] migration: control whether snapshots are ovewritten

2021-02-04 Thread Daniel P . Berrangé
The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- include/migrati

[PATCH v11 10/12] iotests: add support for capturing and matching QMP events

2021-02-04 Thread Daniel P . Berrangé
When using the _launch_qemu and _send_qemu_cmd functions from common.qemu, any QMP events get mixed in with the output from the commands and responses. This makes it difficult to write a test case as the ordering of events in the output is not stable. This introduces a variable 'capture_events' w

Re: [PATCH 1/3] tests/acceptance: Move the pseries test to a separate file

2021-02-04 Thread Thomas Huth
On 04/02/2021 09.52, Philippe Mathieu-Daudé wrote: Hi Thomas, On 1/13/21 6:30 AM, Thomas Huth wrote: On 12/01/2021 19.50, Wainer dos Santos Moschetta wrote: Hi, On 1/12/21 1:40 PM, Thomas Huth wrote: Let's gather the POWER-related tests in a separate file. Did you consider having others p

Re: [PATCH] MAINTAINERS: Fix the location of virtiofsd.rst

2021-02-04 Thread Wainer dos Santos Moschetta
Hi, On 2/4/21 4:53 AM, Philippe Mathieu-Daudé wrote: On 2/3/21 10:19 PM, Wainer dos Santos Moschetta wrote: The virtiofsd.rst file was moved to docs/tools, so this update MAINTAINERS accordingly. Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools manual") Thanks, but why not directl

Re: [PATCH] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 03.02.21 10:44, Thomas Huth wrote: > According to the "ELF-64 Object File Format" specification: > > "The first word in the entry, namesz, identifies the length, in > bytes, of a name identifying the entry’s owner or originator. The name field > contains a null-terminated string, with padd

Re: [PATCH] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Thomas Huth
On 04/02/2021 14.01, Christian Borntraeger wrote: On 03.02.21 10:44, Thomas Huth wrote: According to the "ELF-64 Object File Format" specification: "The first word in the entry, namesz, identifies the length, in bytes, of a name identifying the entry’s owner or originator. The name field

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-02-04 Thread BALATON Zoltan
On Thu, 4 Feb 2021, Jiaxun Yang wrote: 在 2021/2/2 上午4:04, BALATON Zoltan 写道: On Sun, 10 Jan 2021, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: +PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On

Re: [PATCH 06/22] tests/acceptance/virtiofs_submounts.py: use a virtio-net device instead

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > In a virtiofs based tests, it seems safe to assume that the guest will > be capable of a virtio-net device. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 26/36] block/backup-top: drop .active

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 13:33 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2021 15:26, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > We don't need this workaround anymore: bdrv_append is already smart > > > enough and we can use new bdrv_drop_fil

Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length

2021-02-04 Thread Alex Bennée
Cleber Rosa writes: > If the vmlinuz variable is set to anything that evaluates to True, > then the respective arguments should be set. If the variable contains > an empty string, than it will evaluate to False, and the extra > arguments will not be set. > > This keeps the same logic, but impr

Re: [PATCH] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 04.02.21 14:09, Thomas Huth wrote: > On 04/02/2021 14.01, Christian Borntraeger wrote: >> >> >> On 03.02.21 10:44, Thomas Huth wrote: >>> According to the "ELF-64 Object File Format" specification: >>> >>> "The first word in the entry, namesz, identifies the length, in >>>   bytes, of a name

Re: [PATCH v15 21/23] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 11:23 AM, Claudio Fontana wrote: > On 2/3/21 5:51 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> move the call to qemu_init_vcpu inside cpu_common_realizefn, >>> so it does not need to be done explicitly in each target cpu. >>> >>> Despite this, the way cpu realize is done c

Re: [PATCH v2 03/20] vhost-user-gpu: use an extandable state enum for commands

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 12:26 PM, Philippe Mathieu-Daudé wrote: > On 2/4/21 11:52 AM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Introduce a pending state for commands which aren't finished yet, but >> are being handled. See following patch. >> >> Signed-off-by: Marc-André Lureau >> --

Re: [PATCH v2 26/36] block/backup-top: drop .active

2021-02-04 Thread Vladimir Sementsov-Ogievskiy
04.02.2021 16:25, Kevin Wolf wrote: Am 04.02.2021 um 13:33 hat Vladimir Sementsov-Ogievskiy geschrieben: 04.02.2021 15:26, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: We don't need this workaround anymore: bdrv_append is already smart enough and we ca

[PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-02-04 Thread Wainer dos Santos Moschetta
The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS accordingly. Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools manual") Signed-off-by: Wainer dos Santos Moschetta --- v1: was "M

Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: > The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, > and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS > accordingly. > > Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools man

[PULL 0/9] QMP patches patches for 2021-02-04

2021-02-04 Thread Markus Armbruster
The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' into staging (2021-02-03 19:35:57 +) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qmp-2021-02-04 f

[PULL 5/9] qobject: braces {} are necessary for all arms of this statement

2021-02-04 Thread Markus Armbruster
From: Zhang Han Add braces {} for arms of if/for statement Signed-off-by: Zhang Han Message-Id: <20201228071129.24563-5-zhangha...@huawei.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qobject/qdict.c | 6 -- 1 file changed,

[PULL 4/9] qobject: spaces required around that operators

2021-02-04 Thread Markus Armbruster
From: Zhang Han Add spaces around operators. Signed-off-by: Zhang Han Message-Id: <20201228071129.24563-4-zhangha...@huawei.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qobject/qdict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qobject

[PULL 8/9] qmp: Add more tracepoints

2021-02-04 Thread Markus Armbruster
Add tracepoints for in-band request enqueue and dequeue, processing of queued in-band errors, and responses. Signed-off-by: Markus Armbruster Message-Id: <20210201161504.1976989-3-arm...@redhat.com> Reviewed-by: Kevin Wolf --- monitor/qmp.c| 7 +++ monitor/trace-events | 4 2 f

[PULL 2/9] qobject: open brace '{' following struct go on the same line

2021-02-04 Thread Markus Armbruster
From: Zhang Han Put open brace '{' on the same line of struct. Signed-off-by: Zhang Han Message-Id: <20201228071129.24563-2-zhangha...@huawei.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qobject/json-parser.c | 3 +-- qobject/q

[PULL 1/9] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-02-04 Thread Markus Armbruster
From: Peter Maydell The qmp-cmds.c file currently includes ui/vnc.h, which (being located in the ui/ directory rather than include) is really supposed to be for use only by the ui subsystem. In fact the function prototypes we need (vnc_display_password(), etc) are all declared in include/ui/cons

[PULL 3/9] qobject: code indent should never use tabs

2021-02-04 Thread Markus Armbruster
From: Zhang Han Transfer tabs to spaces. Signed-off-by: Zhang Han Message-Id: <20201228071129.24563-3-zhangha...@huawei.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qobject/qdict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qobject/qdi

[PULL 9/9] qmp: Resume OOB-enabled monitor before processing the request

2021-02-04 Thread Markus Armbruster
monitor_qmp_dispatcher_co() needs to resume the monitor if handle_qmp_command() suspended it. Two cases: 1. OOB enabled: suspended if mon->qmp_requests has no more space 2. OOB disabled: suspended always We resume only after we processed the request. Which can take a long time. Resume the mon

[PULL 6/9] docs/interop/qmp-spec: Document the request queue limit

2021-02-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20210127144734.2367693-1-arm...@redhat.com> Reviewed-by: John Snow --- docs/interop/qmp-spec.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt index cdf5842555..b0e83

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

2021-02-04 Thread Eric Blake
On 1/7/21 6:20 AM, Richard W.M. Jones wrote: >> Actually that's not the only problem. It appears that we're unable to >> read or write the last sector of this disk: >> >> $ nbdkit memory $(( 2**63 - 2**30 )) --run 'build/qemu-io -r -f raw "$uri" >> -c "r -v $(( 2**63 - 2**30 - 512 )) 512" ' >>

Re: [PATCH] README: Add Documentation blurb

2021-02-04 Thread Thomas Huth
On 04/11/2020 20.30, John Snow wrote: Add it in a prominent place: Right after figuring out what QEMU is, users may wish to know how to use it more than they want to know how to build their own version of it. Signed-off-by: John Snow --- README.rst | 11 +++ 1 file changed, 11 insert

[PULL 7/9] qmp: Fix up comments after commit 9ce44e2ce2

2021-02-04 Thread Markus Armbruster
Commit 9ce44e2ce2 "qmp: Move dispatcher to a coroutine" replaced monitor_qmp_bh_dispatcher() by monitor_qmp_dispatcher_co(), but neglected to update comments. Do that now. Signed-off-by: Markus Armbruster Message-Id: <20210201161504.1976989-2-arm...@redhat.com> Reviewed-by: Kevin Wolf --- moni

Re: [PATCH 0/3] Acceptance tests for mpc8544ds & virtex-ml507 ppc machines

2021-02-04 Thread Philippe Mathieu-Daudé
On 1/12/21 5:40 PM, Thomas Huth wrote: > Let's use the two new images from the QEMU advent calendar 2020 to test > the mpc8544ds & virtex-ml507 ppc machines. > > Thomas Huth (3): > tests/acceptance: Move the pseries test to a separate file > tests/acceptance: Test the mpc8544ds machine > tes

Re: [RFC 08/10] vhost: Add x-vhost-enable-shadow-vq qmp

2021-02-04 Thread Eugenio Perez Martin
On Thu, Feb 4, 2021 at 1:16 PM Markus Armbruster wrote: > > Eugenio Perez Martin writes: > > > On Tue, Feb 2, 2021 at 4:38 PM Eric Blake wrote: > >> > >> On 1/29/21 2:54 PM, Eugenio Pérez wrote: > [...] > >> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > >> > index 040f68ff2e..42836e45f3

Re: [External] Re: [RFC PATCH 6/9] virtiofsd: Add two new options for crash reconnection

2021-02-04 Thread Jiachen Zhang
On Thu, Feb 4, 2021 at 8:09 PM Dr. David Alan Gilbert wrote: > * Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > > We add two options for virtiofsd crash reconnection: reconnect | > > no_reconnect(default) and > > > > User of virtiofsd should set "-o reconnect" for crash reconnection.

Re: [PATCH v15 21/23] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

2021-02-04 Thread Claudio Fontana
On 2/4/21 2:41 PM, Philippe Mathieu-Daudé wrote: > On 2/4/21 11:23 AM, Claudio Fontana wrote: >> On 2/3/21 5:51 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> move the call to qemu_init_vcpu inside cpu_common_realizefn, so it does not need to be done explicitly in each target

Re: [External] Re: [RFC PATCH 9/9] virtiofsd: (work around) Comment qsort in inflight I/O tracking

2021-02-04 Thread Jiachen Zhang
On Thu, Feb 4, 2021 at 8:16 PM Dr. David Alan Gilbert wrote: > * Jiachen Zhang (zhangjiachen.jay...@bytedance.com) wrote: > > This is a work around. The qsort function will malloc memory instead of > use > > stack memory when the resubmit_num is larger than 64 (total size larger > than > > 1024 B

[RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Wainer dos Santos Moschetta
On 2/4/21 10:59 AM, Philippe Mathieu-Daudé wrote: On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS accordingly. Fixes: a08b4a9fe6c

Re: [PATCH v15 21/23] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:18, Claudio Fontana wrote: > If we could consistently move not only qemu_vcpu_init, but also reset in the > common code in cpu_common_realizefn, > and force the sequence: qemu_vcpu_init(); cpu_reset(); in there, > > and this actually works for all targets, maybe this coul

Re: [PATCH v3 0/3] Fix memory leak of some device state in migration

2021-02-04 Thread Dr. David Alan Gilbert
* Jinhao Gao (gaojin...@huawei.com) wrote: > For some device state having some fields of VMS_ALLOC flag, they > don't free memory allocated for the fields in vmstate_save_state > and vmstate_load_state. We add funcs or sentences of free memory > before and after VM saves or loads device state to av

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta wrote: > Unrelated too, but allow me to ask: > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > tools directory (virtiofsd seems to feel alone there)? I think that would be a good thing, yes (things documented in docs

Re: [PATCH v2 26/36] block/backup-top: drop .active

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 14:46 hat Vladimir Sementsov-Ogievskiy geschrieben: > 04.02.2021 16:25, Kevin Wolf wrote: > > Am 04.02.2021 um 13:33 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 04.02.2021 15:26, Kevin Wolf wrote: > > > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben:

Re: [PATCH v7 1/3] arm64: kvm: Save/restore MTE registers

2021-02-04 Thread Steven Price
On 02/02/2021 15:36, Marc Zyngier wrote: On 2021-01-15 15:28, Steven Price wrote: Define the new system registers that MTE introduces and context switch them. The MTE feature is still hidden from the ID register as it isn't supported in a VM yet. Signed-off-by: Steven Price ---  arch/arm64/inc

Re: [PATCH v7 2/3] arm64: kvm: Introduce MTE VCPU feature

2021-02-04 Thread Steven Price
On 02/02/2021 17:12, Marc Zyngier wrote: On 2021-01-15 15:28, Steven Price wrote: Add a new VM feature 'KVM_ARM_CAP_MTE' which enables memory tagging for a VM. This exposes the feature to the guest and automatically tags memory pages touched by the VM as PG_mte_tagged (and clears the tags storag

Re: [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible

2021-02-04 Thread Edgar E. Iglesias
On Wed, Feb 03, 2021 at 04:45:50PM -1000, Richard Henderson wrote: > On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote: > > Replace the 0/1/2 magic values by the corresponding MMUAccessType. > > We can remove a comment as enum names are self explicit. > > > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] migration/qemu-file: Fix maybe uninitialized on qemu_get_buffer_in_place()

2021-02-04 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Wainer dos Santos Moschetta (waine...@redhat.com) wrote: > > Fixed error when compiling migration/qemu-file.c with > > -Werror=maybe-uninitialized > > as shown here: > > > > ../migration/qemu-file.c: In function 'qemu_get_buffer_in_place':

Re: [PATCH 2/2] target/cris: Let cris_mmu_translate() use MMUAccessType access_type

2021-02-04 Thread Edgar E. Iglesias
On Wed, Feb 03, 2021 at 04:46:28PM -1000, Richard Henderson wrote: > On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote: > > All callers of cris_mmu_translate() provide a MMUAccessType > > type. Let the prototype use it as argument, as it is stricter > > than an integer. We can remove the documentati

Re: [PULL 00/27] Block patches

2021-02-04 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 10:02:25AM +, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 09:58, Stefan Hajnoczi wrote: > > > > The following changes since commit 77f3804ab7ed94b471a14acb260e5aeacf26193f: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into > > staging (2021

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > wrote: > > Unrelated too, but allow me to ask: > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > > tools directory (virtiofsd seems to feel alone there)? >

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst Unrelated, but Paolo once said helpers are not tools. I think helpers is not a good word. However, if an executable: - can be started directly by QEMU, or is

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:40, Kevin Wolf wrote: > > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > wrote: > > > Unrelated too, but allow me to ask: > > > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to th

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 03:40:06PM +0100, Kevin Wolf wrote: > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > wrote: > > > Unrelated too, but allow me to ask: > > > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > The distinction of contrib/ vs tools/ is supposed to be more a > reflection on the quality of the program. > > contrib/ should be considered demo-ware, no back compat guaranteed, > may or may not work, no testing guaranteed, no man pages. O

Re: [PATCH v21 00/20] Initial support for multi-process Qemu

2021-02-04 Thread elena
On Thu, Feb 04, 2021 at 09:51:45AM +, Daniel P. Berrangé wrote: > On Wed, Feb 03, 2021 at 12:02:05PM -0800, Elena Ufimtseva wrote: > > On Wed, Feb 03, 2021 at 04:11:50PM +, Stefan Hajnoczi wrote: > > > On Fri, Jan 29, 2021 at 11:46:01AM -0500, Jagannathan Raman wrote: > > > > This is the v2

Re: [PATCH v2 79/93] tcg/tci: Split out tcg_out_op_{rrm,rrrm,rrrrm}

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/tci/tcg-target.c.inc | 70 > ++-- Hmm duplicate patch tripped up my mail tools, did send-email have a brain fart at 79/93? -- Alex Bennée

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 15:47 hat Daniel P. Berrangé geschrieben: > On Thu, Feb 04, 2021 at 03:40:06PM +0100, Kevin Wolf wrote: > > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > > wrote: > > > > Unrelated too, but allow me to ask:

Re: [PATCH v7 1/3] arm64: kvm: Save/restore MTE registers

2021-02-04 Thread Marc Zyngier
On 2021-02-04 14:33, Steven Price wrote: On 02/02/2021 15:36, Marc Zyngier wrote: On 2021-01-15 15:28, Steven Price wrote: Define the new system registers that MTE introduces and context switch them. The MTE feature is still hidden from the ID register as it isn't supported in a VM yet. Sign

Re: [PATCH v15 21/23] hw/core/cpu: call qemu_init_vcpu in cpu_common_realizefn

2021-02-04 Thread Claudio Fontana
On 2/4/21 3:24 PM, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 14:18, Claudio Fontana wrote: >> If we could consistently move not only qemu_vcpu_init, but also reset in the >> common code in cpu_common_realizefn, >> and force the sequence: qemu_vcpu_init(); cpu_reset(); in there, >> >> and this

Re: [PATCH v14 0/5] UFFD write-tracking migration/snapshots

2021-02-04 Thread Dr. David Alan Gilbert
* Andrey Gruzdev (andrey.gruz...@virtuozzo.com) wrote: > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's > implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. > > Currently the only way to make (external) live VM snapshot is using existing > d

[PATCH v5 2/3] virtiofsd: optionally return inode pointer from lo_do_lookup()

2021-02-04 Thread Stefan Hajnoczi
lo_do_lookup() finds an existing inode or allocates a new one. It increments nlookup so that the inode stays alive until the client releases it. Existing callers don't need the struct lo_inode so the function doesn't return it. Extend the function to optionally return the inode. The next commit wi

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 15:50, Peter Maydell wrote: On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: The distinction of contrib/ vs tools/ is supposed to be more a reflection on the quality of the program. contrib/ should be considered demo-ware, no back compat guaranteed, may or may not work, no te

[PATCH v5 3/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Stefan Hajnoczi
A well-behaved FUSE client does not attempt to open special files with FUSE_OPEN because they are handled on the client side (e.g. device nodes are handled by client-side device drivers). The check to prevent virtiofsd from opening special files is missing in a few cases, most notably FUSE_OPEN. A

[PATCH v5 0/3] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-02-04 Thread Stefan Hajnoczi
v4: * Patch 1: Return positive errno if openat(2) fails in lo_do_open() [Greg] * Patch 3: Return -fd instead or -errno after lo_inode_open() in lo_do_open() [Greg] * Patch 3: Use De Morgan's Law to simplify the boolean expression in lo_create() [Vivek] * Patch 3: Add missing errno = -truncfd

[PATCH v5 1/3] virtiofsd: extract lo_do_open() from lo_open()

2021-02-04 Thread Stefan Hajnoczi
Both lo_open() and lo_create() have similar code to open a file. Extract a common lo_do_open() function from lo_open() that will be used by lo_create() in a later commit. Since lo_do_open() does not otherwise need fuse_req_t req, convert lo_add_fd_mapping() to use struct lo_data *lo instead. Sign

Re: [PATCH v2 04/93] tcg: Manage splitwx in tc_ptr_to_region_tree by hand

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > The use in tcg_tb_lookup is given a random pc that comes from the pc > of a signal handler. Do not assert that the pointer is already within > the code gen buffer at all, much less the writable mirror of it. Surely we are asserting that - or at least you can find a

Re: [PATCH v2 05/93] tcg/tci: Make tci_tb_ptr thread-local

2021-02-04 Thread Alex Bennée
Richard Henderson writes: > Each thread must have its own pc, even under TCI. > > Remove the GETPC ifdef, because GETPC is always available for > helpers, and thus is always required. Move the assignment > under INDEX_op_call, because the value is only visible when > we make a call to a helper

<    1   2   3   4   5   6   >