Am 04.02.2021 um 15:47 hat Daniel P. Berrangé geschrieben: > On Thu, Feb 04, 2021 at 03:40:06PM +0100, Kevin Wolf wrote: > > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > > <waine...@redhat.com> wrote: > > > > Unrelated too, but allow me to ask: > > > > > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > > > > tools directory (virtiofsd seems to feel alone there)? > > > > > > I think that would be a good thing, yes (things documented in docs/tools > > > should have their source code in tools). > > > > Maybe we should define then what a tool is. I think contrib/ has a few > > more things that could be considered tools. > > The distinction of contrib/ vs tools/ is supposed to be more a > reflection on the quality of the program. > > contrib/ should be considered demo-ware, no back compat guaranteed, > may or may not work, no testing guaranteed, no man pages. > > tools/ should be for any program that we intend end users to actively > use in real world, with an expectation of quality and stable CLI and > man pages.
Maybe the difference should be related to what we build by default then? Just checking what executables my build directory contains, I guess these are candidates for tools/: qemu-bridge-helper qemu-edid qemu-img qemu-io qemu-keymap qemu-nbd qemu-pr-helper Almost all of them are currently in the root directory today. Only qemu-pr-helper is in scsi/. And then there is qemu-storage-daemon which lives in storage-daemon/ today and whose executable ends up in a storage-daemon/ subdirectory of the build directory since the Meson conversion, which is inconsistent with all other tools. I haven't checked other subdirectories for more executables that might exist. Kevin
