Re: [PULL 29/31] qemu-option: clean up id vs. list->merge_lists

Too late but I will point it out in the commit that cleans up the iteration. Paolo Il lun 25 gen 2021, 08:42 Markus Armbruster ha scritto: > Paolo Bonzini writes: > > > Looking at all merge-lists QemuOptsList, here is how they access their > > QemuOpts: > > > > reopen_opts in qemu-io-cmds.c ("

[Bug 1913012] Re: Installed firmware descriptor files contain (invalid) relative paths

** Description changed: After building and installing QEMU, the resulting installed firmware descriptor files contain relative paths for their `mapping.filename` properties. These relative paths will not be accepted as valid by tools like `virt-install`, resulting in the inability to confi

Re: [PATCH v7 05/11] osdep: build with non-working system() function

On 23/01/21 14:45, Peter Maydell wrote: On Sat, 23 Jan 2021 at 03:18, Joelle van Dyne wrote: On Fri, Jan 22, 2021 at 3:17 PM Peter Maydell wrote: Can we do the "does system() exist?" check in meson.build ? config_host_data.set('HAVE_SYSTEM_FUNCTION', cc.has_function('system')) Unfortunat

[Bug 1913012] Re: Installed firmware descriptor files contain (invalid) relative paths

** Description changed: After building and installing QEMU, the resulting installed firmware descriptor files contain relative paths for their `mapping.filename` - properties. These relative paths will not be accepted as valid by tools - like `virt-install`, resulting in the inability to confi

[PATCH 0/3] hw/block/nvme: misc fixes

From: Klaus Jensen Misc fixes from Gollu. Gollu Appalanaidu (3): hw/block/nvme: fix set feature for error recovery hw/block/nvme: fix set feature save field check hw/block/nvme: align with existing style hw/block/nvme.c | 26 ++ 1 file changed, 14 insertions(+), 1

[PATCH 1/3] hw/block/nvme: fix set feature for error recovery

From: Gollu Appalanaidu Only enable DULBE if the namespace supports it. Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen --- hw/block/nvme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 21aec90637fa..e7983ff422f2 1006

[PATCH 2/3] hw/block/nvme: fix set feature save field check

From: Gollu Appalanaidu Currently, no features are saveable, so the current check is not wrong, but add a check against the feature capabilities to make sure this will not regress if saveable features are added later. Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen --- hw/block/nvm

[PATCH 3/3] hw/block/nvme: align with existing style

From: Gollu Appalanaidu Change status checks to align with the existing style and remove the explicit check against NVME_SUCCESS. Cc: Dmitry Fomichev Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen --- hw/block/nvme.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[Bug 1913012] Re: Installed firmware descriptor files contain (invalid) relative paths

Please disregard the `# Test a coworkaround` stuff in comment #1, bad copypasta, too late at night ;-) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1913012 Title: Installed firmware descriptor fil

Re: [PATCH v3 0/6] hw/sd: Support block write in SPI mode

On 1/24/21 9:28 PM, Philippe Mathieu-Daudé wrote: > These are Bin's SD patches from his v2, rebased on sd-next. > > v2: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg775712.html > > Based-on: <20210124201106.2602238-1-f4...@amsat.org> > > Bin Meng (6): > hw/sd: ssi-sd: Support multip

Re: [PATCH] spapr: Adjust firmware path of PCI devices

On Fri, Jan 22, 2021 at 06:01:57PM +0100, Greg Kurz wrote: > It is currently not possible to perform a strict boot from USB storage: > > $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ > -boot strict=on \ > -device qemu-xhci \ > -device usb-storage,drive=dis

Re: [RFC PATCH v3 5/6] virtio-net: Added eBPF RSS to virtio-net.

On 2021/1/24 下午4:24, Yuri Benditovich wrote: Hi Jason, I've prepared a POC of graceful switch to 'vhost off' if respective features are acked by the guest. Such a way we do not need to silently clear RSS and hash report features in case of 'vhost on'. Can you please review it and provide your

Re: [PATCH 08/25] hmp: replace "O" parser with keyval

Paolo Bonzini writes: > HMP is using QemuOpts to parse free-form commands device_add, > netdev_add and object_add. However, none of these need QemuOpts > for validation (these three QemuOptsLists are all of the catch-all > kind), and keyval is already able to parse into QDict. So use > keyval d

[Bug 1811862] Re: microcode version stays 0x1 even if -cpu host is used

This is fixed in 5.2. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811862 Title: microcode version stays 0x1 even if -cpu host is us

Re: [RFC PATCH v3 4/6] ebpf: Added eBPF RSS loader.

On 2021/1/19 下午10:53, Yuri Benditovich wrote: On Fri, Jan 15, 2021 at 9:02 AM Jason Wang wrote: On 2021/1/15 上午5:16, Andrew Melnychenko wrote: From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By defa

[PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object files as an artifact from the previous

Re: [RFC PATCH] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

On 24/01/2021 12.32, Paolo Bonzini wrote: check-block is not run by "meson test". Thanks! I've just send a v1 now which also runs the iotests again. Thomas Il dom 24 gen 2021, 08:58 Thomas Huth > ha scritto: Currently, our check-system-* jobs are recompiling

Re: [PATCH] tcg: Increase the static number of temporaries

Laurent Vivier writes: > Le 23/01/2021 à 17:19, Laurent Vivier a écrit : >> Le 21/01/2021 à 03:54, Richard Henderson a écrit : >>> This isn't a total or permanent solution to the problem of running >>> out of temporaries, but it puts off the issue for a bit. >>> >>> Make the assert in tcg_temp_

[Bug 1912224] Re: qemu may freeze during drive-mirroring on fragmented FS

Another test that confirm the perf drop after the revert, live-migration of disk of 51GB (raw written data, without hole) between two host with nvme disk, 10Gb/s connectivity: master qemu 1m14s (737 MB/s) master qemu with reverted patch 2m30s (353 MB/s) -- You received thi

Re: [PATCH v3 2/4] meson: Warn when TCI is selected but TCG backend is available

On Fri, Jan 22, 2021 at 02:30:02PM +0100, Philippe Mathieu-Daudé wrote: > Some new users get confused with 'TCG' and 'TCI', and enable TCI > support expecting to enable TCG. > > Emit a warning when native TCG backend is available on the > host architecture, mentioning this is a suboptimal configur

Re: [PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

On 25/01/21 10:03, Thomas Huth wrote: Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to use the "build" directory with the binaries and object

Re: [PULL v2 10/10] tcg: Restart code generation when we run out of temps

On Sun, Jan 24, 2021 at 08:11:22AM -1000, Richard Henderson wrote: > Some large translation blocks can generate so many unique > constants that we run out of temps to hold them. In this > case, longjmp back to the start of code generation and > restart with a smaller translation block. > > Buglin

Re: [PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

On Mon, Jan 25, 2021 at 10:51:04AM +0100, Paolo Bonzini wrote: > On 25/01/21 10:03, Thomas Huth wrote: > > Currently, our check-system-* jobs are recompiling the whole sources > > again. This happens due to the fact that the jobs are checking out > > the whole source tree and required submodules ag

Re: [PATCH] target/ppc: Fix truncation of env->hflags

Richard Henderson writes: > On 1/23/21 6:46 PM, David Gibson wrote: >> On Sat, Jan 23, 2021 at 05:24:22PM -1000, Richard Henderson wrote: >>> Use the cs_base field, because it happens to be the same >>> size as hflags (and MSR, from which hflags is derived). >>> >>> In translate, extract most b

Re: [PATCH] spapr: Adjust firmware path of PCI devices

On Sat, 23 Jan 2021 13:36:34 +1100 Alexey Kardashevskiy wrote: > > > On 23/01/2021 04:01, Greg Kurz wrote: > > It is currently not possible to perform a strict boot from USB storage: > > > > $ qemu-system-ppc64 -accel kvm -nodefaults -nographic -serial stdio \ > > -boot strict=on \ > >

Re: [PULL v2 00/10] tcg patch queue

On Sun, 24 Jan 2021 at 18:11, Richard Henderson wrote: > > > V2 replaces the tcg const temp overflow patch. > > > r~ > > > The following changes since commit 0e32462630687a18039464511bd0447ada5709c3: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into

Re: [PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

On 25/01/21 10:56, Daniel P. Berrangé wrote: When I suggested use of --no-rebuild, I was actally thinking that we would change the Makefile(s) to enable to pass the --no-rebuild arg to meson. eg make check MESON_ARGS=--no-rebuild is that, or something similar possible ? It would but "make

[PATCH v2 1/2] Revert "vnc: move initialization to framebuffer_update_request"

This reverts commit 9e1632ad07ca49de99da4bb231e9e2f22f2d8df5. Older gtk-vnc versions can't deal with non-incremental update requests sending pseudo-encodings, so trying to send full server state (including desktop size, cursor etc. which is done using pseudo-encodings) doesn't fly. Return to old

[PATCH v2 2/2] vnc: send extended desktop resize on update requests

Unlike other pseudo-encodings these don't break gtk-vnc because older versions don't suport the extended desktop resize extension in the first place. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 2622f82a5a9f..16bb3be77

Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied

On 25/01/21 08:10, Nathan Chancellor wrote: This patch as commit 5a140b255d ("x86/cpu: Use max host physical address if -cpu max option is applied") prevents me from using '-cpu host' while booting an i386_defconfig kernel. $ qemu-system-i386 \ -append console=ttyS0 \ -cpu host \ -display none \

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

* Bin Meng (bmeng...@gmail.com) wrote: > On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé > wrote: > > > > On 1/23/21 11:40 AM, Bin Meng wrote: > > > From: Bin Meng > > > > > > With all these fixes and improvements, there is no way for the > > > VMStateDescription to keep backward compati

[PATCH v2 0/2] vnc: unbreak older gtk-vnc

Gerd Hoffmann (2): Revert "vnc: move initialization to framebuffer_update_request" vnc: send extended desktop resize on update requests ui/vnc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.29.2

[Bug 1886793] Re: "go install" command fails while running inside s390x docker container on x86_64 host using qemu

I used the command "docker run --rm --privileged multiarch/qemu-user-static --reset -p yes". This pulls the latest one automatically. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886793 Title: "

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

On Mon, Jan 25, 2021 at 6:41 PM Dr. David Alan Gilbert wrote: > > * Bin Meng (bmeng...@gmail.com) wrote: > > On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 1/23/21 11:40 AM, Bin Meng wrote: > > > > From: Bin Meng > > > > > > > > With all these fixes and improv

Re: [RFC PATCH v3 4/6] ebpf: Added eBPF RSS loader.

On Mon, Jan 25, 2021 at 11:03 AM Jason Wang wrote: > > > On 2021/1/19 下午10:53, Yuri Benditovich wrote: > > On Fri, Jan 15, 2021 at 9:02 AM Jason Wang wrote: > >> > >> On 2021/1/15 上午5:16, Andrew Melnychenko wrote: > >>> From: Andrew > >>> > >>> Added function that loads RSS eBPF program. > >>> A

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

On 23.01.21 01:41, Laszlo Ersek wrote: On 01/22/21 22:26, Laszlo Ersek wrote: I'm drifting towards an overhaul of coroutine-sigaltstack, based on my personal understanding of POSIX, but given that I can absolutely not *test* coroutine-sigaltstack on the platforms where it actually matters, an "

[PATCH v2] target/mips: fetch code with translator_ld

Similarly to commits ae82adc8e29..7f93879e444, use the translator_ld*() API introduced in commit 409c1a0bf0f to fetch the code on the MIPS target. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- v2: Restrict to translator path =) --- target/mips/translate.c | 20 ++--

Re: [PATCH] tcg: Increase the static number of temporaries

Le 25/01/2021 à 10:31, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 23/01/2021 à 17:19, Laurent Vivier a écrit : >>> Le 21/01/2021 à 03:54, Richard Henderson a écrit : This isn't a total or permanent solution to the problem of running out of temporaries, but it puts off the

[PATCH] trace: add meson custom_target() depend_files for tracetool

Re-generate tracetool output when the tracetool source code changes. Use the same approach as qapi_gen_depends and introduce a tracetool_depends files list so meson is aware of the dependencies. Signed-off-by: Stefan Hajnoczi --- meson.build | 28 +++- trace/meson.b

Re: [PATCH] util/log: flush TB cache when log level changes

Pavel Dovgalyuk writes: > On 22.01.2021 14:42, Alex Bennée wrote: >> >> Pavel Dovgalyuk writes: >> >>> Sometimes we need to collect the translation logs starting >>> from some point of the execution. Some TB listings may >>> be missed in this case, when blocks were translated before. >>> Thi

Re: [PATCH v2 1/1] spapr_caps.c: check user input before warning about TCG only caps

On 1/22/21 10:46 PM, David Gibson wrote: On Wed, Jan 20, 2021 at 07:54:06AM -0300, Daniel Henrique Barboza wrote: Commit 006e9d361869 added warning messages for cap-cfpc, cap-ibs and cap-sbbc when enabled under TCG. Commit 8ff43ee404d3 did the same thing when introducing cap-ccf-assist. Thes

Re: [PATCH] trace: add meson custom_target() depend_files for tracetool

On 25/01/21 12:09, Stefan Hajnoczi wrote: Re-generate tracetool output when the tracetool source code changes. Use the same approach as qapi_gen_depends and introduce a tracetool_depends files list so meson is aware of the dependencies. Signed-off-by: Stefan Hajnoczi --- meson.build | 2

Re: Fwd: VirtioSound device emulation implementation

Shreyansh Chouhan writes: > Just a follow up. > Still working on device initialization. I am trying to understand the > relation between virtio-net and net device in qemu > in hopes of recreating something similar with the audio device. All QEMU devices have two parts, a frontend (which the gu

[PATCH 0/2] trace: make the 'log' backend timestamp configurable

Zoltan reminded me that the 'log' backend prints tids/timestamps and this can be unwanted in some cases. It's easier to look at trace output without them and in some cases parsing is also more convenient with them. Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp output.

[PATCH 2/2] trace: make the 'log' backend timestamp configurable

Timestamps in tracing output can be distracting. Make it possible to control tid/timestamp printing with -msg timestamp=on|off. The default is no tid/timestamps. Previously they were always printed. Suggested-by: BALATON Zoltan Signed-off-by: Stefan Hajnoczi --- docs/devel/tracing.txt

[PATCH 1/2] error: rename error_with_timestamp to message_with_timestamp

The -msg timestamp=on|off option controls whether a timestamp is printed with error_report() messages. The "-msg" name suggests that this option has a wider effect than just error_report(). The next patch extends it to the 'log' trace backend, so rename the variable from error_with_timestamp to mes

[PULL 0/5] 9p next patches

The following changes since commit fef80ea073c4862bc9eaddb6ddb0ed970b8ad7c4: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2021-01-20' into staging (2021-01-21 10:44:28 +) are available in the Git repository at: https://gitlab.com/gkurz/qemu.git tags/9p-next-pull-request fo

[PULL 5/5] 9pfs: Convert reclaim list to QSLIST

Use QSLIST instead of open-coding for a slightly improved readability. No behavioral change. Reviewed-by: Christian Schoenebeck Message-Id: <20210122143514.215780-1-gr...@kaod.org> Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 17 - hw/9pfs/9p.h | 2 +- 2 files changed, 9 insert

[PULL 1/5] 9pfs/proxy: Check return value of proxy_marshal()

This should always successfully write exactly two 32-bit integers. Make it clear with an assert(), like v9fs_receive_status() and v9fs_receive_response() already do when unmarshalling the same header. Fixes: Coverity CID 1438968 Reviewed-by: Christian Schoenebeck Message-Id: <161035859647.1221144

[PULL 4/5] 9pfs: Improve unreclaim loop

If a fid was actually re-opened by v9fs_reopen_fid(), we re-traverse the fid list from the head in case some other request created a fid that needs to be marked unreclaimable as well (i.e. the client opened a new handle on the path that is being unlinked). This is suboptimal since most if not all f

Re: [PATCH 15/25] vl: plumb keyval-based options into -set and -readconfig

Paolo Bonzini writes: > Add generic machinery to support parsing command line options with > keyval in -set and -readconfig, choosing between QDict and > QemuOpts as the underlying data structure. > > The keyval_merge function is slightly heavyweight as a way to > do qemu_set_option for QDict-bas

[PULL 2/5] 9pfs: Convert V9fsFidState::clunked to bool

This can only be 0 or 1. Reviewed-by: Christian Schoenebeck Message-Id: <20210118142300.801516-2-gr...@kaod.org> Signed-off-by: Greg Kurz --- hw/9pfs/9p.c | 4 ++-- hw/9pfs/9p.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 6026b51a1c04

Re: [PATCH 16/25] hw/arm/stellaris: Convert SSYS to QOM device

On Thu, 21 Jan 2021 at 22:13, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 1/21/21 8:06 PM, Peter Maydell wrote: > > Convert the SSYS code in the Stellaris boards (which encapsulates the > > system registers) to a proper QOM device. This will provide us with > > somewhere to put the output

[PULL 3/5] 9pfs: Convert V9fsFidState::fid_list to QSIMPLEQ

The fid_list is currently open-coded. This doesn't seem to serve any purpose that cannot be met with QEMU's generic lists. Let's go for a QSIMPLEQ : this will allow to add new fids at the end of the list and to improve the logic in v9fs_mark_fids_unreclaim(). Reviewed-by: Christian Schoenebeck Me

Re: [PATCH v2 4/7] m68k: add an interrupt controller

Le 24/01/2021 à 17:46, Philippe Mathieu-Daudé a écrit : > On 12/20/20 12:26 PM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> --- >> include/hw/intc/m68k_irqc.h | 28 + >> hw/intc/m68k_irqc.c | 120 > > Missing MAINTAINERS entries?

Re: [PATCH v7 10/11] iotests: rewrite check into python

Am 23.01.2021 um 16:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > 22.01.2021 19:08, Kevin Wolf wrote: > > Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Just use classes introduced in previous three commits. Behavior > > > difference is described in these three comm

[PATCH] coroutine-sigaltstack: Add SIGUSR2 mutex

Disposition (action) for any given signal is global for the process. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler to SIG_DFL, between the other thread (a) setting up coroutine_trampolin

Re: [PULL 18/21] hw/misc: Add a PWM module for NPCM7XX

On Wed, 13 Jan 2021 at 17:13, Hao Wu wrote: > On Wed, Jan 13, 2021 at 8:03 AM Peter Maydell > wrote: >> Hi; Coverity reports a possibly-overflowing arithmetic operation here >> (CID 1442342): >> >> > +static uint32_t npcm7xx_pwm_calculate_duty(NPCM7xxPWM *p) >> > +{ >> > +uint64_t duty; >> >

Re: [PATCH v2 05/12] meson: Restrict block subsystem processing

Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben: > Avoid generating module_block.h and block-gen.c if we are > not going to use them. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: qemu-bl...@nongnu.org > --- > meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 delet

Re: [PATCH] replay: fix replay of the interrupts

Paolo Bonzini writes: > In general I agree, but != means that rr disabled returns true. In general > it seems to me that rr disabled should work more or less the same as record > mode, because there is no replay log to provide the checkpoints. Is this not an argument to combine the mode and ch

[PATCH] Fix crash with IOthread when block commit after snapshot

From: Michael Qiu Currently, if guest has workloads, IO thread will acquire aio_context lock before do io_submit, it leads to segmentfault when do block commit after snapshot. Just like below: [Switching to thread 2 (Thread 0x7f046c312700 (LWP 108791))] #0 0x5573f57930db in bdrv_mirror_top_p

[RESEND PULL 1/4] net: Fix handling of id in netdev_add and netdev_del

From: Markus Armbruster CLI -netdev accumulates in option group "netdev". Before commit 08712fcb85 "net: Track netdevs in NetClientState rather than QemuOpt", netdev_add added to the option group, and netdev_del removed from it, both HMP and QMP. Thus, every netdev had a corresponding QemuOpts

[RESEND PULL 0/4] Net patches

The following changes since commit e81eb5e6d108008445821e4f891fb9563016c71b: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-01-23 22:34:21 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request f

[RESEND PULL 3/4] net: checksum: Add IP header checksum calculation

From: Guishan Qin At present net_checksum_calculate() only calculates TCP/UDP checksum in an IP packet, but assumes the IP header checksum to be provided by the software, e.g.: Linux kernel always calculates the IP header checksum. However this might not always be the case, e.g.: for an IP checks

[PATCH] Fix crash with IOthread when block commit after snapshot

From: Michael Qiu Currently, if guest has workloads, IO thread will acquire aio_context lock before do io_submit, it leads to segmentfault when do block commit after snapshot. Just like below: [Switching to thread 2 (Thread 0x7f046c312700 (LWP 108791))] #0 0x5573f57930db in bdrv_mirror_top_p

[RESEND PULL 2/4] net: checksum: Skip fragmented IP packets

From: Markus Carlstedt To calculate the TCP/UDP checksum we need the whole datagram. Unless the hardware has some logic to collect all fragments before sending the whole datagram first, it can only be done by the network stack, which is normally the case for the NICs we have seen so far. Skip th

[RESEND PULL 4/4] net: checksum: Introduce fine control over checksum type

From: Bin Meng At present net_checksum_calculate() blindly calculates all types of checksums (IP, TCP, UDP). Some NICs may have a per type setting in their BDs to control what checksum should be offloaded. To support such hardware behavior, introduce a 'csum_flag' parameter to the net_checksum_ca

Re: [PATCH v7 10/11] iotests: rewrite check into python

25.01.2021 15:02, Kevin Wolf wrote: Am 23.01.2021 um 16:08 hat Vladimir Sementsov-Ogievskiy geschrieben: 22.01.2021 19:08, Kevin Wolf wrote: Am 16.01.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Just use classes introduced in previous three commits. Behavior difference is descri

Re: [PATCH v8 2/5] iotests: add testenv.py

24.01.2021 00:04, Vladimir Sementsov-Ogievskiy wrote: Add TestEnv class, which will handle test environment in a new python iotests running framework. Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/testenv.py

Re: [PATCH] replay: fix replay of the interrupts

On 1/25/21 1:12 PM, Alex Bennée wrote: > > Paolo Bonzini writes: > >> In general I agree, but != means that rr disabled returns true. In general >> it seems to me that rr disabled should work more or less the same as record >> mode, because there is no replay log to provide the checkpoints. > >

Re: [PATCH 09/25] qom: use qemu_printf to print help for user-creatable objects

Paolo Bonzini writes: > This is needed when we add help support for object_add. > > Signed-off-by: Paolo Bonzini Reviewed-by: Markus Armbruster

Re: [PATCH 10/25] hmp: special case help options for object_add

Paolo Bonzini writes: > Fix "object_add help" and "object_add TYPE,help". > > Signed-off-by: Paolo Bonzini Standard question when I read "Fix $interface" in a commit message: how exactly is it broken?

Re: [PATCH 10/25] hmp: special case help options for object_add

On 25/01/21 13:48, Markus Armbruster wrote: Paolo Bonzini writes: Fix "object_add help" and "object_add TYPE,help". Signed-off-by: Paolo Bonzini Standard question when I read "Fix $interface" in a commit message: how exactly is it broken? It doesn't work at all ("Error: parameter 'id' is

[PATCH] s390x/cpu_model: disallow unpack for --only-migratable

secure execution (aka protected virtualization) guests cannot be migrated at the moment. Disallow the unpack facility if the user specifies --only-migratable. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_models.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/s390x

Re: [PATCH 11/25] remove -writeconfig

Paolo Bonzini writes: > Like -set and -readconfig, it would not really be too hard to > extend -writeconfig to parsing mechanisms other than QemuOpts. > However, the uses of -writeconfig are substantially more > limited, as it is generally easier to write the configuration > by hand in the first

Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable

On 25.01.21 13:53, Christian Borntraeger wrote: > secure execution (aka protected virtualization) guests cannot be > migrated at the moment. Disallow the unpack facility if the user > specifies --only-migratable. > > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_models.c | 6

Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable

On 25.01.21 13:57, David Hildenbrand wrote: > On 25.01.21 13:53, Christian Borntraeger wrote: >> secure execution (aka protected virtualization) guests cannot be >> migrated at the moment. Disallow the unpack facility if the user >> specifies --only-migratable. >> >> Signed-off-by: Christian Bor

Re: [PATCH] replay: fix replay of the interrupts

On 1/25/21 1:43 PM, Claudio Fontana wrote: > On 1/25/21 1:12 PM, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> In general I agree, but != means that rr disabled returns true. In general >>> it seems to me that rr disabled should work more or less the same as record >>> mode, because there

Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable

On 25.01.21 13:59, Christian Borntraeger wrote: > > > On 25.01.21 13:57, David Hildenbrand wrote: >> On 25.01.21 13:53, Christian Borntraeger wrote: >>> secure execution (aka protected virtualization) guests cannot be >>> migrated at the moment. Disallow the unpack facility if the user >>> specif

[PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

secure execution (aka protected virtualization) guests cannot be migrated at the moment. Disallow the unpack facility if the user specifies --only-migratable. Signed-off-by: Christian Borntraeger --- v1->v2: - add missing return - protect check with CONFIG_USER_ONLY for building non softmmu binar

[PATCH] error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"

Setting errp = NULL is wrong: the automatic error propagation still propagates the dangling pointer _auto_errp_prop.local_err. We need to set *errp = NULL to clear the dangling pointer. Signed-off-by: Markus Armbruster --- include/qapi/error.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] migration: Provide a test for migratability

* Eric Blake (ebl...@redhat.com) wrote: > On 1/21/21 12:51 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Provide a simple way to see if there's currently a migration blocker in > > operation: > > > > $ ./x86_64-softmmu/qemu-system-x86_64 -nographic -M pc,usb=

Re: [PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

On 25.01.21 14:22, Christian Borntraeger wrote: > secure execution (aka protected virtualization) guests cannot be > migrated at the moment. Disallow the unpack facility if the user > specifies --only-migratable. > > Signed-off-by: Christian Borntraeger > --- > v1->v2: > - add missing return > -

Re: [PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

Patchew URL: https://patchew.org/QEMU/20210125132238.179972-1-borntrae...@de.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210125132238.179972-1-borntrae...@de.ibm.com Subject: [PATCH v2] s390x/cpu_model: d

Re: [PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

On Mon, 25 Jan 2021 14:22:38 +0100 Christian Borntraeger wrote: > secure execution (aka protected virtualization) guests cannot be > migrated at the moment. Disallow the unpack facility if the user > specifies --only-migratable. Maybe make the explanation a bit more verbose? "Secure execution (

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

On Thursday, 2021-01-21 at 12:08:02 -05, Eduardo Habkost wrote: > On Thu, Jan 21, 2021 at 02:27:04PM +0100, Igor Mammedov wrote: >> On Wed, 20 Jan 2021 15:49:09 -0500 >> Eduardo Habkost wrote: >> >> > On Wed, Jan 20, 2021 at 08:08:32PM +0100, Igor Mammedov wrote: >> > > On Wed, 20 Jan 2021 15:38

Re: [PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

On 25.01.21 14:38, Cornelia Huck wrote: > On Mon, 25 Jan 2021 14:22:38 +0100 > Christian Borntraeger wrote: > >> secure execution (aka protected virtualization) guests cannot be >> migrated at the moment. Disallow the unpack facility if the user >> specifies --only-migratable. > > Maybe make

Re: [PULL 0/9] SD/MMC patches for 2021-01-24

On Sun, 24 Jan 2021 at 20:13, Philippe Mathieu-Daudé wrote: > > The following changes since commit e93c65a6c64fa18b0c61fb9338d364cbea32b6ef: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20210122-pull-request' into staging (2021-01-23 > 14:40:45 +) > > are available in the Gi

[PATCH v3] s390x/cpu_model: disallow unpack for --only-migratable

Secure execution (aka protected virtualization) guests cannot be migrated at the moment. If the unpack facility is provided in the cpu model, a guest may choose to transition to secure mode, making the guest unmigratable at that point in time. If the machine was explicitly started with --only-migra

Re: [PATCH] error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"

25.01.2021 16:26, Markus Armbruster wrote: Setting errp = NULL is wrong: the automatic error propagation still propagates the dangling pointer _auto_errp_prop.local_err. We need to set *errp = NULL to clear the dangling pointer. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementso

Re: [PATCH 12/25] qemu-config: add error propagation to qemu_config_parse

Paolo Bonzini writes: > This enables some simplification of vl.c via error_fatal. > > Signed-off-by: Paolo Bonzini > --- > block/blkdebug.c | 3 +-- > include/qemu/config-file.h | 4 ++-- > softmmu/vl.c | 30 -- > util/qemu-config.c

Re: [PATCH 11/25] remove -writeconfig

On 25/01/21 13:53, Markus Armbruster wrote: I love the "and how give me a config file for all that" idea, but I agree our -writeconfig is flawed. I hope we can bring it back in more useful shape. No deprecation grace period? That's a decision that we have to take overall once the whole serie

Re: [PATCH 15/25] vl: plumb keyval-based options into -set and -readconfig

On 25/01/21 12:48, Markus Armbruster wrote: Paolo Bonzini writes: Add generic machinery to support parsing command line options with keyval in -set and -readconfig, choosing between QDict and QemuOpts as the underlying data structure. The keyval_merge function is slightly heavyweight as a way

MIPS support for PIC32 and GPIOs

Hi I am using this fork of qemu that has pic32 support in it. https://github.com/sergev/qemu/ When I boot a firmware image I get these errors as I don’t think the gpios have been defined. /usr/local/qemu-mips/bin/qemu-system-mipsel -machine pic32mx7-max32 -nographic -serial file:serial1.log -se

Re: [PATCH 10/25] hmp: special case help options for object_add

Paolo Bonzini writes: > On 25/01/21 13:48, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Fix "object_add help" and "object_add TYPE,help". >>> >>> Signed-off-by: Paolo Bonzini >> Standard question when I read "Fix $interface" in a commit message: >> how >> exactly is it broken? > >

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

Hi Stefan, On 1/25/21 12:35 PM, Stefan Hajnoczi wrote: > Zoltan reminded me that the 'log' backend prints tids/timestamps and this can > be unwanted in some cases. It's easier to look at trace output without them > and > in some cases parsing is also more convenient with them. > > Extend -msg ti

Re: [PATCH 11/25] remove -writeconfig

On Mon, Jan 25, 2021 at 03:01:01PM +0100, Paolo Bonzini wrote: > On 25/01/21 13:53, Markus Armbruster wrote: > > I love the "and how give me a config file for all that" idea, but I > > agree our -writeconfig is flawed. I hope we can bring it back in more > > useful shape. > > > > No deprecation g

configure does not detect librados or librbd since the switch to meson

Hi, on Dedian / Ubuntu configure does no longer detect librbd / librados since the switch to meson. I need to add dirs: ['/usr/lib'] to the cc.find_library for librados and librbd. But I am not familiar with meson and can't say if thats the appropriate fix. I would be thankful for a hint. I

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

Hello, Any updates on this little patch? Please find below a reproducer for this bug (thanks Alexander): https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg02567.html Thank you, On Thu, Dec 24, 2020 at 6:55 PM Mauro Matteo Cascella wrote: > > Ensure that 'cmd->frame' is not NULL before

Re: configure does not detect librados or librbd since the switch to meson

Am 25.01.21 um 15:13 schrieb Peter Lieven: > Hi, > > > on Dedian / Ubuntu configure does no longer detect librbd / librados since > the switch to meson. > > I need to add dirs: ['/usr/lib'] to the cc.find_library for librados and > librbd. But I am not familiar with meson > > and can't say if tha

  1   2   3   4   >