Le 24/01/2021 à 17:46, Philippe Mathieu-Daudé a écrit : > On 12/20/20 12:26 PM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier <laur...@vivier.eu> >> --- >> include/hw/intc/m68k_irqc.h | 28 +++++++++ >> hw/intc/m68k_irqc.c | 120 ++++++++++++++++++++++++++++++++++++ > > Missing MAINTAINERS entries?
new devices are added in patch 7 (where I add the machine and the section in MAINTAINER), but I've missed this one. Thanks. > >> hw/intc/Kconfig | 3 + >> hw/intc/meson.build | 1 + >> 4 files changed, 152 insertions(+) >> create mode 100644 include/hw/intc/m68k_irqc.h >> create mode 100644 hw/intc/m68k_irqc.c >> >> diff --git a/include/hw/intc/m68k_irqc.h b/include/hw/intc/m68k_irqc.h >> new file mode 100644 >> index 000000000000..c40b1b4df8fa >> --- /dev/null >> +++ b/include/hw/intc/m68k_irqc.h >> @@ -0,0 +1,28 @@ >> +/* >> + * SPDX-License-Identifer: GPL-2.0-or-later >> + * >> + * QEMU Motorla 680x0 IRQ Controller > > Typo "Motorola". Thank you (there is another typo: "q800_irq_register_types" that must be renamed) > Are there any specs to refer at? > There is no specs. It's a (generic) copy of the GLUE device we already have for q800. I don't update Q800 because the GLUE device may disappear because Q800 uses actually djMEMC that is also a memory controller (I have that in my q800-dev branch, but for the moment it's only needed for the MacROM and Mark is working on that). Thanks, Laurent
