Ping: [PATCH v4 0/7] fuzz: improve crash case minimization

2021-01-05 Thread Qiuhao Li
Kindly ping :) Wondering if there is anything wrong with this patch? On Tue, 2020-12-29 at 12:39 +0800, Qiuhao Li wrote: > Extend and refine the crash case minimization process. > > Test input: > Bug 1909261 full_reproducer > 6500 QTest instructions (write mostly) > > Refined (-M1 minimizat

Re: [PATCH v3 04/15] target/mips/mips-defs: Introduce CPU_MIPS64 and cpu_type_is_64bit()

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 12:30 AM, Richard Henderson wrote: > On 1/4/21 12:11 PM, Philippe Mathieu-Daudé wrote: >> MIPS 64-bit ISA is introduced with MIPS3. >> >> Introduce the CPU_MIPS64 definition aliased to the MIPS3 ISA, >> and the cpu_type_is_64bit() method to check if a CPU supports >> this ISA (thus is 64-

Re: [PATCH, BUILD-FIX] linux-user: Conditionalize TUNSETVNETLE

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 12:44 AM, Richard Henderson wrote: > This fixes the build for older ppc64 kernel headers. > > Fixes: 6addf06a3c4 > Cc: Josh Kunz > Cc: Shu-Chun Weng > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > linux-user/ioctls.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewe

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 2:53 AM, Huacai Chen wrote: > Hi, Philippe and Peter, > > On Tue, Jan 5, 2021 at 2:30 AM Philippe Mathieu-Daudé wrote: >> >> On 1/4/21 7:24 PM, Philippe Mathieu-Daudé wrote: >>> On 1/4/21 6:39 PM, Philippe Mathieu-Daudé wrote: On 1/4/21 4:01 PM, Peter Maydell wrote: > On Mon, 4

Re: [PATCH v2 4/4] docs/system: arm: Add sabrelite board description

2021-01-05 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > This adds the target guide for SABRE Lite board, and documents how > to boot a Linux kernel and U-Boot bootloader. > > Signed-off-by: Bin Meng Awesome documentation 👏 Reviewed-by: Alex Bennée > > --- > > Changes in v2: > - new patch: add sabrelite tar

Re: [PATCH v2 2/4] hw/msic: imx6_ccm: Correct register value for silicon type

2021-01-05 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > Currently when U-Boot boots, it prints "??" for i.MX processor: > > CPU: Freescale i.MX?? rev1.0 at 792 MHz > > The register that was used to determine the silicon type is > undocumented in the latest IMX6DQRM (Rev. 6, 05/2020), but we > can refer to g

Re: [PATCH v2 1/4] hw/misc: imx6_ccm: Update PMU_MISC0 reset value

2021-01-05 Thread Alex Bennée
Bin Meng writes: > From: Bin Meng > > U-Boot expects PMU_MISC0 register bit 7 is set (see init_bandgap() > in arch/arm/mach-imx/mx6/soc.c) during boot. This bit indicates the > bandgap has stabilized. > > With this change, the latest upstream U-Boot (v2021.01-rc3) for imx6 > sabrelite board (m

Re: [PATCH v2 1/4] hw/misc: imx6_ccm: Update PMU_MISC0 reset value

2021-01-05 Thread Alex Bennée
Bin Meng writes: > On Wed, Dec 23, 2020 at 2:26 PM Bin Meng wrote: >> >> From: Bin Meng >> >> >> (no changes since v1) >> >> hw/misc/imx6_ccm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Ping? Looks good to me - Peter should be able to pull it into his tree soon. --

Re: [PATCH v2 1/4] hw/misc: imx6_ccm: Update PMU_MISC0 reset value

2021-01-05 Thread Bin Meng
Hi Alex, On Tue, Jan 5, 2021 at 5:25 PM Alex Bennée wrote: > > > Bin Meng writes: > > > On Wed, Dec 23, 2020 at 2:26 PM Bin Meng wrote: > >> > >> From: Bin Meng > >> > > >> > >> (no changes since v1) > >> > >> hw/misc/imx6_ccm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >>

Ping: [PATCH v4 0/7] block: Add retry for werror=/rerror= mechanism

2021-01-05 Thread Jiahui Cen
Hi Kevin, What do you think of these patches? Thanks, Jiahui On 2020/12/15 20:30, Jiahui Cen wrote: > A VM in the cloud environment may use a virutal disk as the backend storage, > and there are usually filesystems on the virtual block device. When backend > storage is temporarily down, any I/O

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/4/21 6:39 PM, Philippe Mathieu-Daudé wrote: > On 1/4/21 4:01 PM, Peter Maydell wrote: >> On Mon, 4 Jan 2021 at 13:59, Philippe Mathieu-Daudé wrote: >>> I don't have access to OSX host. I'll see to install an aarch32 chroot and >>> keep testing (not sure what can differ from an i386 guest). >>

[PULL v2 00/35] MIPS patches for 2021-01-04​

2021-01-05 Thread Philippe Mathieu-Daudé
The following changes since commit e551455f1e7a3d7eee9e11e2903e4050bc5511ae: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-01-04 15:02:53 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-20210104

[PULL v2 26/35] hw/mips: Add Loongson-3 machine support

2021-01-05 Thread Philippe Mathieu-Daudé
From: Huacai Chen Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-virt". It m

Re: [PATCH] qtest/libqtest.c: fix heap-buffer-overflow in qtest_cb_for_every_machine()

2021-01-05 Thread Thomas Huth
On 04/01/2021 15.10, Gan Qixin wrote: When the length of mname is less than 5, memcpy ("xenfv", mname, 5) will cause heap buffer overflow. Therefore, use strcmp to avoid this problem. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020f2f4 at pc 0x7f65d8cc

Re: [PATCH, BUILD-FIX] linux-user: Conditionalize TUNSETVNETLE

2021-01-05 Thread Laurent Vivier
Le 05/01/2021 à 00:44, Richard Henderson a écrit : > This fixes the build for older ppc64 kernel headers. > > Fixes: 6addf06a3c4 > Cc: Josh Kunz > Cc: Shu-Chun Weng > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > linux-user/ioctls.h | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v5 0/2] util/oslib: qemu_try_memalign() improvements

2021-01-05 Thread Paolo Bonzini
On 05/01/21 01:06, Richard Henderson wrote: On 12/16/20 9:24 AM, Richard Henderson wrote: On 10/21/20 12:38 PM, Philippe Mathieu-Daudé wrote: - Use _aligned_malloc for qemu_try_memalign on win32 - Assert qemu_try_memalign() alignment is a power of 2 Since v4: - Drop superfluous assert (Richard

[PATCH] tests/iotests: drop test 312 from auto group

2021-01-05 Thread Alex Bennée
The "auto" documentation states: That means they should run with every QEMU binary (also non-x86) which is not the case as the check-system-fedora build which only includes a rag tag group of rare and deprecated targets doesn't support the virtio device required. Signed-off-by: Alex Bennée --

Re: [PATCH v3 04/15] target/mips/mips-defs: Introduce CPU_MIPS64 and cpu_type_is_64bit()

2021-01-05 Thread Philippe Mathieu-Daudé
Hi Richard, On 1/5/21 9:34 AM, Philippe Mathieu-Daudé wrote: > On 1/5/21 12:30 AM, Richard Henderson wrote: >> On 1/4/21 12:11 PM, Philippe Mathieu-Daudé wrote: >>> MIPS 64-bit ISA is introduced with MIPS3. >>> >>> Introduce the CPU_MIPS64 definition aliased to the MIPS3 ISA, >>> and the cpu_type_

Re: [PATCH] tests/iotests: drop test 312 from auto group

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 11:04 AM, Alex Bennée wrote: > The "auto" documentation states: > > That means they should run with every QEMU binary (also non-x86) > > which is not the case as the check-system-fedora build which only > includes a rag tag group of rare and deprecated targets doesn't > support the vi

Re: [PATCH] arm-virt: add secure pl061 for reset/power down

2021-01-05 Thread Philippe Mathieu-Daudé
On 12/17/20 2:57 PM, Maxim Uvarov wrote: > Add secure pl061 for reset/power down machine from > the secure world (Arm Trusted Firmware). > Use the same gpio 3 and gpio 4 which were used by > non acpi variant of linux power control gpios. > > Signed-off-by: Maxim Uvarov > --- > This patch works t

Re: [PATCH v2 0/4] qemu-timer: Make timer_free() imply timer_del()

2021-01-05 Thread Philippe Mathieu-Daudé
On 12/15/20 4:41 PM, Peter Maydell wrote: > Currently timer_free() is a simple wrapper for g_free(). This means > that the timer being freed must not be currently active, as otherwise > QEMU might crash later when the active list is processed and still > has a pointer to freed memory on it. As a

Re: [PATCH] hw/arm/highbank: Drop dead KVM support code

2021-01-05 Thread Philippe Mathieu-Daudé
On 12/15/20 3:42 PM, Peter Maydell wrote: > Support for running KVM on 32-bit Arm hosts was removed in commit > 82bf7ae84ce739e. You can still run a 32-bit guest on a 64-bit Arm > host CPU, but because Arm KVM requires the host and guest CPU types > to match, it is not possible to run a guest that

Re: [EXTERNAL] Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-05 Thread Halil Pasic
On Mon, 4 Jan 2021 10:40:26 -0800 Ram Pai wrote: > On Mon, Jan 04, 2021 at 01:46:29PM +0100, Halil Pasic wrote: > > On Sun, 3 Jan 2021 23:15:50 -0800 > > Ram Pai wrote: > > > > > On Fri, Dec 18, 2020 at 12:41:11PM +0100, Cornelia Huck wrote: > > > > On Thu, 17 Dec 2020 15:15:30 +0100 > >

Re: [PATCH] tests/docker: Include 'ccache' in Debian base image

2021-01-05 Thread Philippe Mathieu-Daudé
Hi, On 12/14/20 2:39 PM, Philippe Mathieu-Daudé wrote: > On 12/14/20 6:44 AM, Thomas Huth wrote: >> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote: >>> Include the 'ccache' package to speed up compilation. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/docker/dockerfiles/debi

Re: [PATCH v2 3/3] hw/i386: expose a "smbios-ep" PC machine property

2021-01-05 Thread Michael S. Tsirkin
On Mon, Dec 14, 2020 at 03:50:29PM -0500, Eduardo Habkost wrote: > From: Daniel P. Berrangé > > The i440fx and Q35 machine types are both hardcoded to use the legacy > SMBIOS 2.1 entry point. This is a sensible conservative choice because > SeaBIOS only supports SMBIOS 2.1 > > EDK2, however, ca

Re: [PATCH] hw/virtio-pci: Replace error_report() by qemu_log_mask(GUEST_ERROR)

2021-01-05 Thread Philippe Mathieu-Daudé
ping? On 12/10/20 6:28 PM, Philippe Mathieu-Daudé wrote: > Replace I/O write error reported with error_report() by > qemu_log_mask(GUEST_ERROR) which allow filtering. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/virtio/virtio-pci.c | 6 -- > 1 file changed, 4 insertions(+), 2 deleti

Re: [PATCH] hw/timer/slavio_timer: Allow 64-bit accesses

2021-01-05 Thread Philippe Mathieu-Daudé
ping? On 12/5/20 4:09 PM, Philippe Mathieu-Daudé wrote: > Per the "NCR89C105 Chip Specification" referenced in the header: > > Chip-level Address Map > > -- > | 1D0 -> | Counter/Timers

Re: [PATCH v3 3/3] vmstate: Fix memory leak in vmstate_handle_alloc()

2021-01-05 Thread Dr. David Alan Gilbert
* Jinhao Gao (gaojin...@huawei.com) wrote: > Some memory allocated for fields having a flag of VMS_ALLOC in SaveState > may not free before VM load vmsd in migration. So we pre-free memory before > allocation in vmstate_handle_alloc() to avoid memleaks. > > Reported-by: Euler Robot > Signed-off-b

RE: [PATCH] qtest/libqtest.c: fix heap-buffer-overflow in qtest_cb_for_every_machine()

2021-01-05 Thread ganqixin
> From: Thomas Huth [mailto:th...@redhat.com] > Sent: Tuesday, January 5, 2021 5:47 PM > To: ganqixin ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org > Cc: Chenqun (kuhn) ; Zhanghailiang > ; Euler Robot > ; Laurent Vivier > Subject: Re: [PATCH] qtest/libqtest.c: fix heap-buffer-overflow in > qt

Re: [Qemu-devel] [PULL 1/1] ui/vnc: fix vmware VGA incompatiblities

2021-01-05 Thread Gerd Hoffmann
Hi, > > -#define SVGA_MAX_WIDTH 2360 > > +#define SVGA_MAX_WIDTH ROUND_UP(2360, > > VNC_DIRTY_PIXELS_PER_BIT) > Here we pull in the VNC header in order to get the definition > of the VNC_DIRTY_PIXELS_PER_BIT constant, but I don't understand > why. The hw/displ

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Mon, 04 Jan 2021 13:54:32 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> >> > >> >> > +/* Hyper-V features enabled with 'hyperv=on' */ >> >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | >> >> > +BIT(HYPERV_FEAT_VA

Re: [PATCH] tests/iotests: drop test 312 from auto group

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 11:12 AM, Philippe Mathieu-Daudé wrote: > On 1/5/21 11:04 AM, Alex Bennée wrote: >> The "auto" documentation states: >> >> That means they should run with every QEMU binary (also non-x86) >> >> which is not the case as the check-system-fedora build which only >> includes a rag tag group

[PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Alex Bennée
The read binary data as text via a PPM export of the frame buffer seems a bit sketchy and it did blow up in the real world when the assertion failed: https://gitlab.com/qemu-project/qemu/-/jobs/943183183 However short of cleaning up the test to be more binary focused at least limit the attempt

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Daniel P . Berrangé
On Tue, Jan 05, 2021 at 12:44:05PM +, Alex Bennée wrote: > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of

Re: [PATCH] tests/docker: Include 'ccache' in Debian base image

2021-01-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi, > > On 12/14/20 2:39 PM, Philippe Mathieu-Daudé wrote: >> On 12/14/20 6:44 AM, Thomas Huth wrote: >>> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote: Include the 'ccache' package to speed up compilation. Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH v2 2/3] sam460ex: Remove FDT_PPC dependency from KConfig

2021-01-05 Thread Paolo Bonzini
On 04/01/21 02:51, BALATON Zoltan wrote: On Thu, 31 Dec 2020, BALATON Zoltan via wrote: Dependency on FDT_PPC was added in commit b0048f76095 ("hw/ppc/Kconfig: Only select FDT helper for machines using it") but it does not seem to be really necessary so remove it again. Signed-off-by: BALATON Z

Re: [PATCH v15 09/13] stream: rework backing-file changing

2021-01-05 Thread Max Reitz
On 22.12.20 18:53, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 18:59, Max Reitz wrote: On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either b

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2021-01-05 Thread Max Reitz
On 22.12.20 19:00, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 19:07, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other word

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2021-01-05 Thread Max Reitz
On 22.12.20 19:07, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 19:20, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible

Re: [Bug 1906905] Re: [PATCH] hw/timer/slavio_timer: Allow 64-bit accesses

2021-01-05 Thread Mark Cave-Ayland
On 05/01/2021 11:06, Philippe Mathieu-Daudé wrote: ping? On 12/5/20 4:09 PM, Philippe Mathieu-Daudé wrote: Per the "NCR89C105 Chip Specification" referenced in the header: Chip-level Address Map -- | 1D0

Re: [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines

2021-01-05 Thread Mark Cave-Ayland
On 12/12/2020 14:41, Peter Maydell wrote: Currently the GRLIB_IRQMP device is used in one place (the leon3 board), but instead of the device providing inbound gpio lines for the board to wire up, the board code itself calls qemu_allocate_irqs() with the handler function being a set_irq function

Re: [PULL v2 00/53] Misc patches for 2020-12-21

2021-01-05 Thread Peter Maydell
On Mon, 4 Jan 2021 at 14:44, Paolo Bonzini wrote: > > The following changes since commit 41192db338588051f21501abc13743e62b0a5605: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 > 22:57:15 +) > > are available in the Git rep

Re: [PATCH 1/2] hw/sparc: Make grlib-irqmp device handle its own inbound IRQ lines

2021-01-05 Thread Fred Konrad
Hi Peter, Le 12/12/20 à 3:41 PM, Peter Maydell a écrit : Currently the GRLIB_IRQMP device is used in one place (the leon3 board), but instead of the device providing inbound gpio lines for the board to wire up, the board code itself calls qemu_allocate_irqs() with the handler function being a

Re: [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef

2021-01-05 Thread Fred Konrad
Le 12/12/20 à 3:41 PM, Peter Maydell a écrit : The grlib.h header defines a set_pil_in_fn typedef which is never used; remove it. Signed-off-by: Peter Maydell --- include/hw/sparc/grlib.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/sparc/grlib.h b/include/hw/sparc/grli

Re: [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines

2021-01-05 Thread Fred Konrad
Le 12/12/20 à 3:41 PM, Peter Maydell a écrit : Currently the GRLIB_IRQMP device is used in one place (the leon3 board), but instead of the device providing inbound gpio lines for the board to wire up, the board code itself calls qemu_allocate_irqs() with the handler function being a set_irq fu

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-05 Thread Peter Maydell
On Tue, 5 Jan 2021 at 09:36, Philippe Mathieu-Daudé wrote: > 4/ libatomic on 32-bit hosts (i386, riscv32? arm?) > > While compiling succeed, linking fails: > > [850/2216] Linking target tests/test-hbitmap > FAILED: tests/test-hbitmap > clang -o tests/test-hbitmap tests/test-hbitmap.p/test-hbitmap

Re: [PATCH 1/2] tcg/i386: Adjust TCG_TARGET_HAS_MEMORY_BSWAP

2021-01-05 Thread Philippe Mathieu-Daudé
On 12/11/20 2:14 AM, Richard Henderson wrote: > Always true when movbe is available, otherwise leave > this to generic code. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.h | 3 +- > tcg/i386/tcg-target.c.inc | 119 ++ > 2 files change

Re: [PATCH 2/2] tcg: Introduce INDEX_op_qemu_st8_i32

2021-01-05 Thread Philippe Mathieu-Daudé
On 12/11/20 2:14 AM, Richard Henderson wrote: > Enable this on i386 to restrict the set of input registers > for an 8-bit store, as required by the architecture. This > removes the last use of scratch registers for user-only mode. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg-opc

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Willian Rampazzo
On Tue, Jan 5, 2021 at 9:46 AM Alex Bennée wrote: > > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of cleaning

[Bug 1908266] Re: spice unnecessary forces nographic

2021-01-05 Thread Gerd Hoffmann
Yes, display devices show up on both UI and spice/vnc, and right now there is no way to contigure that. Using spice fot the vga and gtk for serial/monitor is rather unusual though. Any reason for this? I'd suggest to simply use the gtk ui instead. It works with opengl (-display gtk,gl=on). You a

Re: [RFC] Using gitlab for upstream qemu repo?

2021-01-05 Thread Peter Maydell
On Thu, 22 Oct 2020 at 17:48, Paolo Bonzini wrote: > now that Gitlab is the primary CI infrastructure for QEMU, and that all > QEMU git repositories (including mirrors) are available on Gitlab, I > would like to propose that committers use Gitlab when merging commits to > QEMU repositories. > - r

QEMU hosting

2021-01-05 Thread Stefan Hajnoczi
Hi Thomas, In November you emailed qemu-devel asking if the QEMU project was interested in exploring hosting with Fosshost.org. I think my reply may have gotten lost so I wanted to check if you have time to discuss this again. The main hosting need that QEMU has is for continuous integration syste

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Eduardo Habkost
On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > On Mon, 4 Jan 2021 13:29:06 -0500 > Eduardo Habkost wrote: > > > On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > > > Igor Mammedov writes: > > > > > > >> > > > > >> > +/* Hyper-V features enabled with '

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-05 Thread Roman Bolshakov
On Mon, Jan 04, 2021 at 09:50:32PM +0100, Paolo Bonzini wrote: > On 04/01/21 18:24, Roman Bolshakov wrote: > > Hi Paolo, > > > > I'm sorry I didn't reply earlier. As I showed in an example to Peter > > (https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg00085.html): > > https://github.com/me

Adding dedicated runners to Gitlab CI

2021-01-05 Thread Stefan Hajnoczi
Hi Cleber, I noticed there are already two dedicated runners registered in QEMU's Gitlab CI and you have documented gitlab-runner setup steps in a patch series on the mailing list. A few higher-level questions come to mind. Maybe you could document this when you send the next version of the CI pat

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Halil Pasic
On Tue, 5 Jan 2021 12:44:05 + Alex Bennée wrote: > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of clea

Re: Some performance numbers for virtiofs, DAX and virtio-9p

2021-01-05 Thread Miklos Szeredi
On Fri, Dec 11, 2020 at 8:25 PM Vivek Goyal wrote: > > On Fri, Dec 11, 2020 at 06:29:56PM +, Dr. David Alan Gilbert wrote: > > [..] > > > > > > > > Could we measure at what point does a large window size actually make > > > > performance worse? > > > > > > Will do. Will run tests with varying

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: >> >> documenting is good, but if it adds new semantics to how CPU features are >> handled >> users up the stack will need code it up as well and juggle with >> -machine + -cpu + -device cpu-foo >> not to

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-05 Thread Philippe Mathieu-Daudé
On 1/5/21 2:17 PM, Peter Maydell wrote: > On Tue, 5 Jan 2021 at 09:36, Philippe Mathieu-Daudé wrote: >> 4/ libatomic on 32-bit hosts (i386, riscv32? arm?) >> >> While compiling succeed, linking fails: >> >> [850/2216] Linking target tests/test-hbitmap >> FAILED: tests/test-hbitmap >> clang -o tes

Re: [PATCH v15 13/13] block: apply COR-filter to block-stream jobs

2021-01-05 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backing files during the block-stream job,

Re: Some performance numbers for virtiofs, DAX and virtio-9p

2021-01-05 Thread Vivek Goyal
On Tue, Jan 05, 2021 at 04:08:34PM +0100, Miklos Szeredi wrote: > On Fri, Dec 11, 2020 at 8:25 PM Vivek Goyal wrote: > > > > On Fri, Dec 11, 2020 at 06:29:56PM +, Dr. David Alan Gilbert wrote: > > > > [..] > > > > > > > > > > Could we measure at what point does a large window size actually mak

Re: [PATCH v3 04/15] target/mips/mips-defs: Introduce CPU_MIPS64 and cpu_type_is_64bit()

2021-01-05 Thread Richard Henderson
On 1/5/21 12:05 AM, Philippe Mathieu-Daudé wrote: > I'm not sure it is worth the effort, as I plan to check each ISA / > ASE bit from the CP0_ConfigX bits (similarly target/arm/ does), so > these definitions should disappear eventually. Excellent. > Might I keep your R-b tag for this patch (event

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 05 Jan 2021 12:50:05 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Mon, 04 Jan 2021 13:54:32 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> >> > > >> >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> >> > +x86mc->def

Re: [PATCH v15 00/13] Apply COR-filter to the block-stream permanently

2021-01-05 Thread Max Reitz
On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a new version of cor-filter in block-stream series. Main change is freezing the chain in cor-filter itself. Thanks, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block

[PATCH V2 03/22] oslib: qemu_clr_cloexec

2021-01-05 Thread Steve Sistare
Define qemu_clr_cloexec, analogous to qemu_set_cloexec. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Steve Sistare --- include/qemu/osdep.h | 1 + util/oslib-posix.c | 9 + util/oslib-win32.c | 4 3 files changed, 14 insertions(+) diff --git a/include/qemu/osdep.h b/incl

[PATCH V2 04/22] util: env var helpers

2021-01-05 Thread Steve Sistare
Add functions for saving fd's and other values in the environment via setenv, and for reading them back via getenv. Signed-off-by: Steve Sistare Signed-off-by: Mark Kanda --- include/qemu/env.h | 27 util/Makefile.objs | 2 +- util/env.c | 119 +++

[PATCH V2 00/22] Live Update

2021-01-05 Thread Steve Sistare
Provide the cprsave and cprload commands for live update. These save and restore VM state, with minimal guest pause time, so that qemu may be updated to a new version in between. cprsave stops the VM and saves vmstate to an ordinary file. It supports two modes: restart and reboot. For restart,

[PATCH V2 06/22] vl: add helper to request re-exec

2021-01-05 Thread Steve Sistare
Add a qemu_exec_requested() hook that causes the main loop to exit and re-exec qemu using the same initial arguments. If /usr/bin/qemu-exec exists, exec that instead. This is an optional site-specific trampoline that may alter the environment before exec'ing the qemu binary. Signed-off-by: Steve

[PATCH V2 17/22] chardev: socket accept subroutine

2021-01-05 Thread Steve Sistare
Factor out the post-accept actions into a subroutine that can be used in a subsequent patch. No functional change. Signed-off-by: Steve Sistare --- io/channel-socket.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/io/channel-so

[PATCH V2 05/22] vl: memfd-alloc option

2021-01-05 Thread Steve Sistare
Allocate anonymous memory using memfd_create if the memfd-alloc option is set. Signed-off-by: Steve Sistare --- exec.c | 38 ++ include/sysemu/sysemu.h | 1 + qemu-options.hx | 11 +++ softmmu/vl.c| 4 trace-

[PATCH V2 08/22] cpr: QMP interfaces

2021-01-05 Thread Steve Sistare
cprsave calls cprsave(). Syntax: { 'enum': 'CprMode', 'data': [ 'reboot', 'restart' ] } { 'command': 'cprsave', 'data': { 'file': 'str', 'mode': 'CprMode' } } cprload calls cprload(). Syntax: { 'command': 'cprload', 'data': { 'file': 'str' } } cprinfo returns a list of supported modes. S

[PATCH V2 14/22] chardev: cpr framework

2021-01-05 Thread Steve Sistare
Add QEMU_CHAR_FEATURE_CPR for devices that support cpr. Add the chardev close_on_cpr option for devices that can be closed on cpr and reopened after exec. cpr is allowed only if either QEMU_CHAR_FEATURE_CPR or close_on_cpr is set for all chardevs in the configuration. Signed-off-by: Steve Sistare

[PATCH V2 07/22] cpr

2021-01-05 Thread Steve Sistare
Provide the cprsave and cprload functions for live update. These save and restore VM state, with minimal guest pause time, so that qemu may be updated to a new version in between. cprsave stops the VM and saves vmstate to an ordinary file. It supports two modes: restart and reboot. For restart,

[PATCH V2 18/22] chardev: cpr for sockets

2021-01-05 Thread Steve Sistare
Define qio_channel_socket_reuse to initialize a channel based on an existing socket fd. Save accepted socket fds in the environment before cprsave, and look for fds in the environment after cprload. Reject cprsave if a socket enables the TLS or websocket option. Signed-off-by: Mark Kanda Signed

[PATCH V2 10/22] pci: export functions for cpr

2021-01-05 Thread Steve Sistare
Export msix_is_pending and msix_init_vector_notifiers for use by cpr. No functional change. Signed-off-by: Steve Sistare --- hw/pci/msix.c | 20 ++-- hw/pci/pci.c | 3 +-- include/hw/pci/msix.h | 5 + include/hw/pci/pci.h | 1 + 4 files changed, 21 insert

[PATCH V2 22/22] simplify savevm

2021-01-05 Thread Steve Sistare
Use qf_file_open to simplify a few functions in savevm.c. No functional change. Signed-off-by: Steve Sistare --- migration/savevm.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index a843d20..994ad1a 100644 --- a

[PATCH V2 21/22] cpr: maintainers

2021-01-05 Thread Steve Sistare
Add the maintainers for cpr related files. Signed-off-by: Steve Sistare --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0886eb3..93044e7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2631,6 +2631,17 @@ F: net/colo* F: net/filter-

[PATCH V2 09/22] cpr: HMP interfaces

2021-01-05 Thread Steve Sistare
cprsave Call cprsave(). Arguments: file : save vmstate to this file name mode: "reboot" or "restart" cprload Call cprload(). Arguments: file : load vmstate from this file name cprinfo Print to stdout a space-delimited list of modes supported by cprsave. Arguments: none

[PATCH V2 12/22] vfio-pci: cpr

2021-01-05 Thread Steve Sistare
Enable vfio-pci devices to be saved and restored across an exec restart of qemu. At vfio creation time, save the value of vfio container, group, and device descriptors in the environment. In cprsave, suspend the use of virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_SUSPEND, because gu

Re: [PULL 0/5] Tracing patches

2021-01-05 Thread Peter Maydell
On Mon, 4 Jan 2021 at 14:32, Stefan Hajnoczi wrote: > > The following changes since commit 41192db338588051f21501abc13743e62b0a5605: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 > 22:57:15 +) > > are available in the Git r

[PATCH V2 11/22] vfio-pci: refactor for cpr

2021-01-05 Thread Steve Sistare
Export vfio_address_spaces and vfio_listener_skipped_section. Add optional eventfd arg to vfio_add_kvm_msi_virq. Refactor vector use into a helper vfio_vector_init. All for use by cpr in a subsequent patch. No functional change. Signed-off-by: Steve Sistare --- hw/vfio/common.c |

[PATCH V2 16/22] chardev: cpr for pty

2021-01-05 Thread Steve Sistare
Save and restore pty descriptors across cprsave and cprload. Signed-off-by: Steve Sistare --- chardev/char-pty.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 1cc501a..0916f9e 100644 --- a/chardev/char-pty.c ++

[PATCH V2 19/22] monitor: cpr support

2021-01-05 Thread Steve Sistare
A monitor socket requires special treatment. Save and restore the qmp negotiation status. Stop the monitor's iothread in cpsave. Otherwise, the thread will detect the close of the monitor socket and call unsetenv_fd,which modifies environ and races with execv which uses environ. Signed-off-by:

[PATCH V2 15/22] chardev: cpr for simple devices

2021-01-05 Thread Steve Sistare
Set QEMU_CHAR_FEATURE_CPR for devices that trivially support cpr. char-stdio is slightly less trivial. Allow the gdb server by closing it on exec. Signed-off-by: Steve Sistare --- chardev/char-mux.c | 1 + chardev/char-null.c| 1 + chardev/char-serial.c | 1 + chardev/char-stdio.c |

[PATCH V2 20/22] cpr: only-cpr-capable option

2021-01-05 Thread Steve Sistare
Add the only-cpr-capable option, which causes qemu to exit with an error if any devices that are not capable of cpr are added. This guarantees that a cprsave operation will not fail with an unsupported device error. Signed-off-by: Steve Sistare --- chardev/char-socket.c | 1 + exec.c

[PATCH V2 02/22] qemu_ram_volatile

2021-01-05 Thread Steve Sistare
Add a function that returns true if any ram_list block represents volatile memory. Signed-off-by: Steve Sistare --- exec.c| 30 ++ include/exec/memory.h | 8 slirp | 2 +- 3 files changed, 39 insertions(+), 1 deletion(-) dif

[PATCH V2 01/22] as_flat_walk

2021-01-05 Thread Steve Sistare
Add an iterator over the sections of a flattened address space. Signed-off-by: Steve Sistare --- include/exec/memory.h | 3 +++ softmmu/memory.c | 17 + 2 files changed, 20 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 307e527..8dba065 1006

[PATCH V2 13/22] vhost: reset vhost devices upon cprsave

2021-01-05 Thread Steve Sistare
A vhost device is implicitly preserved across re-exec because its fd is not closed, and the value of the fd is specified on the command line for the new qemu to find. However, new qemu issues an VHOST_RESET_OWNER ioctl, which fails because the device already has an owner. To fix, reset the owner

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 5 Jan 2021 09:34:31 -0500 Eduardo Habkost wrote: > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > > On Mon, 4 Jan 2021 13:29:06 -0500 > > Eduardo Habkost wrote: > > > > > On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > > > > Igor Mammedov write

Re: [PATCH V2 18/22] chardev: cpr for sockets

2021-01-05 Thread Daniel P . Berrangé
On Tue, Jan 05, 2021 at 07:42:06AM -0800, Steve Sistare wrote: > Define qio_channel_socket_reuse to initialize a channel based on an existing > socket fd. Save accepted socket fds in the environment before cprsave, and > look for fds in the environment after cprload. Reject cprsave if a socket >

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 05 Jan 2021 12:50:05 +0100 > > I think there is a misunderstanding, idea was: > > cpu_initfn() { > //current set > cpu->default_hyperv_cpu_features = ACD > } > > compat_props_5.1 { >cpu.default_hyperv_cpu_features = AB > } > > compat_props_5.2 { >cp

Re: [PATCH V2 05/22] vl: memfd-alloc option

2021-01-05 Thread Daniel P . Berrangé
On Tue, Jan 05, 2021 at 07:41:53AM -0800, Steve Sistare wrote: > Allocate anonymous memory using memfd_create if the memfd-alloc option is > set. > > Signed-off-by: Steve Sistare > --- > exec.c | 38 ++ > include/sysemu/sysemu.h | 1 + > qemu

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-05 Thread Igor Mammedov
On Tue, 05 Jan 2021 16:10:36 +0100 Vitaly Kuznetsov wrote: > Eduardo Habkost writes: > > > On Tue, Jan 05, 2021 at 12:36:50AM +0100, Igor Mammedov wrote: > >> > >> documenting is good, but if it adds new semantics to how CPU features are > >> handled > >> users up the stack will need code i

Re: [PATCH V2 18/22] chardev: cpr for sockets

2021-01-05 Thread Steven Sistare
On 1/5/2021 11:22 AM, Daniel P. Berrangé wrote: > On Tue, Jan 05, 2021 at 07:42:06AM -0800, Steve Sistare wrote: >> Define qio_channel_socket_reuse to initialize a channel based on an existing >> socket fd. Save accepted socket fds in the environment before cprsave, and >> look for fds in the envi

[RFC PATCH v2 01/32] Temp: Add the PCI_EXT_ID_DVSEC definition to the qemu pci_regs.h copy.

2021-01-05 Thread Ben Widawsky
From: Jonathan Cameron This hasn't yet been added to the linux kernel tree, so for purposes of this RFC just add it locally. Signed-off-by: Jonathan Cameron Signed-off-by: Ben Widawsky --- include/standard-headers/linux/pci_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/st

[RFC PATCH v2 00/32] CXL 2.0 Support

2021-01-05 Thread Ben Widawsky
Fixes since v1 [1]: * Defer introducing some commands/registers not yet used (Ben) * Add stubbed device_reg_init_common() (Ben) * Improve assertions in DVSEC creation (Jonathan) * Use 'n' for HDM register offsets (Jonathan) * Correct revision ID for extensions (Jonathan) * Minor cleanups and

[RFC PATCH v2 02/32] hw/pci/cxl: Add a CXL component type (interface)

2021-01-05 Thread Ben Widawsky
A CXL component is a hardware entity that implements CXL component registers from the CXL 2.0 spec (8.2.3). Currently these represent 3 general types. 1. Host Bridge 2. Ports (root, upstream, downstream) 3. Devices (memory, other) A CXL component can be conceptually thought of as a PCIe device wit

[RFC PATCH v2 03/32] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2021-01-05 Thread Ben Widawsky
A CXL 2.0 component is any entity in the CXL topology. All components have a analogous function in PCIe. Except for the CXL host bridge, all have a PCIe config space that is accessible via the common PCIe mechanisms. CXL components are enumerated via DVSEC fields in the extended PCIe header space.

[RFC PATCH v2 05/32] hw/cxl/device: Implement the CAP array (8.2.8.1-2)

2021-01-05 Thread Ben Widawsky
This implements all device MMIO up to the first capability .That includes the CXL Device Capabilities Array Register, as well as all of the CXL Device Capability Header Registers. The latter are filled in as they are implemented in the following patches. v2: Break out register alignment checks (Jo

[RFC PATCH v2 04/32] hw/cxl/device: Introduce a CXL device (8.2.8)

2021-01-05 Thread Ben Widawsky
A CXL device is a type of CXL component. Conceptually, a CXL device would be a leaf node in a CXL topology. From an emulation perspective, CXL devices are the most complex and so the actual implementation is reserved for discrete commits. This new device type is specifically catered towards the ev

  1   2   3   >