Re: [PATCH 0/5] hw: Use PCI macros from 'hw/pci/pci.h'

2021-01-04 Thread Michael S. Tsirkin
On Sun, Jan 03, 2021 at 02:04:53PM +0100, Philippe Mathieu-Daudé wrote: > On 10/12/20 2:45 PM, Philippe Mathieu-Daudé wrote: > > Trivial patches using the generic PCI macros from "hw/pci/pci.h". > > > > Philippe Mathieu-Daudé (5): > > hw/pci-host/bonito: Make PCI_ADDR() macro more readable >

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Peter Maydell
On Sun, 3 Jan 2021 at 20:53, Philippe Mathieu-Daudé wrote: > > The following changes since commit 83734919c408ba02adb6ea616d68cd1a72837fbe: > > Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20201222' > into staging (2021-01-01 18:19:44 +) > > are available in the Git reposi

Re: [PATCH v2 2/3] sam460ex: Remove FDT_PPC dependency from KConfig

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 01:51, BALATON Zoltan wrote: > Something is still not right with this, I've noticed that a few other > boards also have this option selected but they don't need fdt.o that's > gated by this option in meson.build. That fdt.o is only needed by PSERIES > and POWERNV but removing

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 11:41, Peter Maydell wrote: > > On Sun, 3 Jan 2021 at 20:53, Philippe Mathieu-Daudé wrote: > > > > The following changes since commit 83734919c408ba02adb6ea616d68cd1a72837fbe: > > > > Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20201222' > > into stagin

Re: [Question] VNC CA certificate update live

2021-01-04 Thread Daniel P . Berrangé
On Mon, Dec 28, 2020 at 08:59:39PM +0800, zihao chang wrote: >Hi all: >The VNC of QEMU suppots TLS encryption. The client & server can use >arbitrary certificates from CA certificates the running VM loaded(user can >use new certificates immediately), but if the CA certificate is cha

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Daniel P . Berrangé
On Sat, Jan 02, 2021 at 01:25:07PM +, Peter Maydell wrote: > On Sat, 2 Jan 2021 at 12:54, Roman Bolshakov wrote: > > > > crypto/tlscreds.h includes GnuTLS headers if CONFIG_GNUTLS is set, but > > GNUTLS_CFLAGS, that describe include path, are not propagated > > transitively to all users of cry

Re: [PATCH] vnc: add qmp to support reload vnc tls certificates

2021-01-04 Thread Daniel P . Berrangé
On Mon, Jan 04, 2021 at 03:11:28PM +0800, Zihao Chang wrote: > QEMU loads vnc tls certificates only when vm is started. This patch > provides a new qmp command to reload vnc tls certificates without > restart vnc-server/VM. > > Signed-off-by: Zihao Chang > --- > include/ui/console.h | 1 + > mo

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Paolo Bonzini
On 04/01/21 13:21, Daniel P. Berrangé wrote: The actual usage of gnutls should be confined to the crypto/ code. The rest of QEMU should only ever be using QEMU's TLS abstractions and not directly be tied to GNUTLS. So ideally the gnutls flags should only ever be added in the crypto/meson.build,

Re: [EXTERNAL] Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-04 Thread Halil Pasic
On Sun, 3 Jan 2021 23:15:50 -0800 Ram Pai wrote: > On Fri, Dec 18, 2020 at 12:41:11PM +0100, Cornelia Huck wrote: > > On Thu, 17 Dec 2020 15:15:30 +0100 [..] > > > > > > > +int kvmppc_svm_init(SecurableGuestMemory *sgm, Error **errp) > > > > > > > { > > > > > > > if (!kvm_check_extension(kv

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Vitaly Kuznetsov
Igor Mammedov writes: >> > >> > +/* Hyper-V features enabled with 'hyperv=on' */ >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) | >> > +BIT(HYPERV_FEAT_CRASH) | BIT(HYPERV_FEAT_RESET) | >> > +

Re: [PATCH 0/3] Bypass specific network traffic in COLO

2021-01-04 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > Since the real user scenario does not need to monitor all traffic. Can you explain the type of real user case where they only need to compare some connections? Dave > This series give user ability to bypass kinds of network stre

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 12:22, Daniel P. Berrangé wrote: > > Question to Paolo -- it seems pretty fragile to have to explicitly > > list "these source files need these extra CFLAGS" in half a dozen > > meson.build files, because it's pretty non-obvious that adding > > eg '#include "block/nbd.h"' to

[PATCH] vhost-user-fs: add the "bootindex" property

2021-01-04 Thread Laszlo Ersek
virtio-fs qualifies as a bootable device minimally under OVMF, but currently the necessary "bootindex" property is missing (fw_cfg kernel boot notwithstanding). Add the property. For completeness, add it to the CCW device as well; other virtio-ccw devices seem to have "bootindex" properties too.

Re: Question: How to change backing file ?

2021-01-04 Thread Kashyap Chamarthy
[Cc: qemu-block] On Sun, Jan 03, 2021 at 11:35:49AM +0100, Kevin Nguetchouang wrote: > nobody then ? [No direct answer but a quick meta note ...] ... if you're looking for guidance on code internals, you might want to wait a little more time for the block developers to notice. Some regions of t

[Question] SR-IOV VF 'surprise removal' and vfio_reset behavior in pSeries

2021-01-04 Thread Daniel Henrique Barboza
Hi, This question came up while I was investigating a Libvirt bug [1], where an user is removing VFs from the host while Libvirt domains was using them, causing Libvirt to remain in an inconsistent state. I'm trying to alleviate the effects of this in Libvirt (see [2] if curious), but QEMU is

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Philippe Mathieu-Daudé
Hi Peter, On 1/4/21 12:50 PM, Peter Maydell wrote: > On Mon, 4 Jan 2021 at 11:41, Peter Maydell wrote: >> >> On Sun, 3 Jan 2021 at 20:53, Philippe Mathieu-Daudé wrote: >>> >>> The following changes since commit 83734919c408ba02adb6ea616d68cd1a72837fbe: >>> >>> Merge remote-tracking branch 'rem

Re: [PATCH v14 1/7] Introduce yank feature

2021-01-04 Thread Marc-André Lureau
Hi On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank' ou

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Philippe Mathieu-Daudé
On Mon, Jan 4, 2021 at 2:53 PM Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 1/4/21 12:50 PM, Peter Maydell wrote: > > On Mon, 4 Jan 2021 at 11:41, Peter Maydell wrote: > >> > >> On Sun, 3 Jan 2021 at 20:53, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> The following changes since commit

[PATCH] qtest/libqtest.c: fix heap-buffer-overflow in qtest_cb_for_every_machine()

2021-01-04 Thread Gan Qixin
When the length of mname is less than 5, memcpy ("xenfv", mname, 5) will cause heap buffer overflow. Therefore, use strcmp to avoid this problem. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020f2f4 at pc 0x7f65d8cc2225 bp 0x7ffe93cc5a60 sp 0x7ffe93cc5208

[PULL 0/1] Block patches

2021-01-04 Thread Stefan Hajnoczi
The following changes since commit 41192db338588051f21501abc13743e62b0a5605: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pu

[PULL 1/1] readline: Fix possible array index out of bounds in readline_hist_add()

2021-01-04 Thread Stefan Hajnoczi
From: Alex Chen When the 'cmdline' is the last entry in 'rs->history' array, there is no need to put this entry to the end of the array, partly because it is the last entry, and partly because the next operition will lead to array index out of bounds. Reported-by: Euler Robot Signed-off-by: Ale

[PULL 0/5] Tracing patches

2021-01-04 Thread Stefan Hajnoczi
The following changes since commit 41192db338588051f21501abc13743e62b0a5605: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-

[PULL 1/5] trace: Send "-d trace:help" output to stdout

2021-01-04 Thread Stefan Hajnoczi
From: Doug Evans ... for consistency with "-d help". Signed-off-by: Doug Evans Message-id: 20201125215245.3514695-1-...@google.com Signed-off-by: Stefan Hajnoczi --- trace/control.h | 3 ++- trace/control.c | 12 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tra

[PULL 2/5] tracetool: add output filename command-line argument

2021-01-04 Thread Stefan Hajnoczi
The tracetool.py script writes to stdout. This means the output filename is not available to the script. Add the output filename to the command-line so that the script has access to the filename. This also simplifies the tracetool.py invocation. It's no longer necessary to use meson's custom_build

[PULL 3/5] tracetool: add out_lineno and out_next_lineno to out()

2021-01-04 Thread Stefan Hajnoczi
Make the output file line number and next line number available to out(). A later patch will use this to improve error messages. Signed-off-by: Stefan Hajnoczi Reviewed-by: Peter Maydell Message-Id: <20200827142915.108730-3-stefa...@redhat.com> --- scripts/tracetool/__init__.py | 10 +-

[PULL 5/5] tracetool: show trace-events filename/lineno in fmt string errors

2021-01-04 Thread Stefan Hajnoczi
The compiler encounters trace event format strings in generated code. Format strings are error-prone and therefore clear compiler errors are important. Use the #line directive to show the trace-events filename and line number in format string errors: https://gcc.gnu.org/onlinedocs/gcc-10.2.0/cpp/L

[PULL 4/5] tracetool: add input filename and line number to Event

2021-01-04 Thread Stefan Hajnoczi
Store the input filename and line number in Event. A later patch will use this to improve error messages. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20200827142915.108730-4-stefa...@redhat.com> --- scripts/tracetool/__init__.py |

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Paolo Bonzini
On 04/01/21 14:21, Peter Maydell wrote: The rest of QEMU should only ever be using QEMU's TLS abstractions and not directly be tied to GNUTLS. So ideally the gnutls flags should only ever be added in the crypto/meson.build, and anything which depends on that should then get the flags indirectly.

[PULL v2 00/53] Misc patches for 2020-12-21

2021-01-04 Thread Paolo Bonzini
The following changes since commit 41192db338588051f21501abc13743e62b0a5605: Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstr

Re: [PULL 0/5] Tracing patches

2021-01-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210104143154.462212-1-stefa...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210104143154.462212-1-stefa...@redhat.com Subject: [PULL 0/5] Tracing patches === TES

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 13:59, Philippe Mathieu-Daudé wrote: > I don't have access to OSX host. I'll see to install an aarch32 chroot and > keep testing (not sure what can differ from an i386 guest). > If I can't find anything I'll resend the same series without the Loongson-3 > machine, which is th

Re: [PATCH v15 07/20] multi-process: add qio channel write function

2021-01-04 Thread Daniel P . Berrangé
Since this is independent of the multi-process code, it should have a subject prefix of "io:". I'd suggest io: add qio_channel_writev_full_all helper On Tue, Dec 22, 2020 at 10:14:42PM -0800, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Adds qio_channel_writev_full_all() to

Re: [PULL 1/5] trace: Send "-d trace:help" output to stdout

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 3:31 PM, Stefan Hajnoczi wrote: > From: Doug Evans > > ... for consistency with "-d help". Doh the request to make sense with this comment got lost :/ https://www.mail-archive.com/qemu-devel@nongnu.org/msg765789.html Not a big deal as the patch is trivial. > > Signed-off-by: Doug Ev

Re: [PATCH v15 08/20] multi-process: add qio channel read function

2021-01-04 Thread Daniel P . Berrangé
On Tue, Dec 22, 2020 at 10:14:43PM -0800, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Adds qio_channel_readv_full_all() to read both data and FDs. > Refactors existing code to use this function. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-b

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 14:40, Paolo Bonzini wrote: > > On 04/01/21 14:21, Peter Maydell wrote: > >> The rest of QEMU should only ever be using QEMU's TLS abstractions > >> and not directly be tied to GNUTLS. So ideally the gnutls flags > >> should only ever be added in the crypto/meson.build, and a

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-04 Thread Alex Bennée
Roman Bolshakov writes: > Pages can't be both write and executable at the same time on Apple > Silicon. macOS provides public API to switch write protection [1] for > JIT applications, like TCG. > > 1. > https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-04 Thread Alex Bennée
What's the application you are trying to start? Is it publicly available? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909921 Title: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside

Re: [PATCH v2 2/3] hostmem-file: add readonly=on|off option

2021-01-04 Thread Stefan Hajnoczi
On Mon, Dec 14, 2020 at 12:10:15PM +0100, Igor Mammedov wrote: > On Wed, 16 Sep 2020 10:51:49 +0100 > Stefan Hajnoczi wrote: > > > Let -object memory-backend-file work on read-only files when the > > readonly=on option is given. This can be used to share the contents of a > > file between multipl

Re: [PATCH v2 0/3] nvdimm: read-only file support

2021-01-04 Thread Stefan Hajnoczi
On Thu, Dec 10, 2020 at 04:48:57PM +, Liam Merwick wrote: > On 16/09/2020 10:51, Stefan Hajnoczi wrote: > > v2: > > * s/the the/the/ in documentation [Philippe] > > * Assign nvdimm->unarmed earlier [Philippe] > > > > There is currently no way to back an NVDIMM with a read-only file so it c

Re: [Qemu-devel] [PULL 1/1] ui/vnc: fix vmware VGA incompatiblities

2021-01-04 Thread Peter Maydell
On Tue, 18 Mar 2014 at 07:26, Gerd Hoffmann wrote: > > From: Peter Lieven > > this fixes invalid rectangle updates observed after commit 12b316d > with the vmware VGA driver. The issues occured because the server > and client surface update seems to be out of sync at some points > and the max wid

Re: [PATCH 01/22] hw/block: m25p80: Add ISSI SPI flash support

2021-01-04 Thread Francisco Iglesias
Hi Bin, On [2020 Dec 31] Thu 19:29:49, Bin Meng wrote: > From: Bin Meng > > This adds the ISSI SPI flash support. The number of dummy cycles in > fast read, fast read dual output and fast read quad output commands > is currently using the default 8. Per the datasheet [1], the number > of dummy c

Re: [PATCH v2 3/3] nvdimm: honor -object memory-backend-file, readonly=on option

2021-01-04 Thread Stefan Hajnoczi
On Mon, Dec 14, 2020 at 12:19:05PM +0100, Igor Mammedov wrote: > On Wed, 16 Sep 2020 10:51:50 +0100 > Stefan Hajnoczi wrote: > > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c > > index e1574bc07c..848cd65917 100644 > > --- a/hw/mem/nvdimm.c > > +++ b/hw/mem/nvdimm.c > > @@ -146,6 +146,10 @@ stati

[PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Peter Maydell
The qmp-cmds.c file currently includes ui/vnc.h, which (being located in the ui/ directory rather than include) is really supposed to be for use only by the ui subsystem. In fact the function prototypes we need (vnc_display_password(), etc) are all declared in include/ui/console.h, so we can switc

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 5:12 PM, Peter Maydell wrote: > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > in the ui/ directory rather than include) is really supposed to be > for use only by the ui subsystem. That makes me remember yet another cleanup series I started few months ago to rem

[PATCH v3 2/3] hostmem-file: add readonly=on|off option

2021-01-04 Thread Stefan Hajnoczi
Let -object memory-backend-file work on read-only files when the readonly=on option is given. This can be used to share the contents of a file between multiple guests while preventing them from consuming Copy-on-Write memory if guests dirty the pages, for example. Acked-by: Michael S. Tsirkin Rev

[PATCH v3 1/3] memory: add readonly support to memory_region_init_ram_from_file()

2021-01-04 Thread Stefan Hajnoczi
There is currently no way to open(O_RDONLY) and mmap(PROT_READ) when creating a memory region from a file. This functionality is needed since the underlying host file may not allow writing. Add a bool readonly argument to memory_region_init_ram_from_file() and the APIs it calls. Extend memory_reg

[PATCH v3 0/3] nvdimm: read-only file support

2021-01-04 Thread Stefan Hajnoczi
v3: * Produce an error when -device nvdimm,unarmed=off is used with -object memory-backend-file,readonly=on instead of silently switching on unarmed. [Igor] * Use Object *obj instead of Object *o [Igor] * Do not dereference MEMORY_BACKEND_FILE(o)->readonly directly, use a local variable

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 16:30, Philippe Mathieu-Daudé wrote: > > On 1/4/21 5:12 PM, Peter Maydell wrote: > > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > > in the ui/ directory rather than include) is really supposed to be > > for use only by the ui subsystem. > > That mak

[PATCH v3 3/3] nvdimm: check -object memory-backend-file, readonly=on option

2021-01-04 Thread Stefan Hajnoczi
Check that -device nvdimm,unarmed=on is used when -object memory-backend-file,readonly=on and document that -device nvdimm,unarmed=on|off controls whether the NVDIMM appears read-only to the guest. Acked-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Liam Merwick Signed

Re: [PULL 0/1] Block patches

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 14:23, Stefan Hajnoczi wrote: > > The following changes since commit 41192db338588051f21501abc13743e62b0a5605: > > Merge remote-tracking branch > 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 > 22:57:15 +) > > are available in the Git r

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Roman Bolshakov
On Sat, Jan 02, 2021 at 08:43:51PM +0100, Paolo Bonzini wrote: > On 02/01/21 14:25, Peter Maydell wrote: > > Question to Paolo -- it seems pretty fragile to have to explicitly > > list "these source files need these extra CFLAGS" in half a dozen > > meson.build files, because it's pretty non-obviou

[PULL 0/3] tcg patch queue

2021-01-04 Thread Richard Henderson
s/pull-tcg-20210104 for you to fetch changes up to a66424ba17d661007dc13d78c9e3014ccbaf0efb: tcg: Add tcg_gen_bswap_tl alias (2021-01-04 06:32:58 -1000) Fix vector clear issue. Fix riscv host shift issue. Add tcg_ge

[PULL 2/3] tcg/riscv: Fix illegal shift instructions

2021-01-04 Thread Richard Henderson
From: Zihao Yu Out-of-range shifts have undefined results, but must not trap. Mask off immediate shift counts to solve this problem. This bug can be reproduced by running the following guest instructions: xor %ecx,%ecx sar %cl,%eax cmovne %edi,%eax After optimization, the tcg opcodes of

[PULL 1/3] tcg: Use memset for large vector byte replication

2021-01-04 Thread Richard Henderson
In f47db80cc07, we handled odd-sized tail clearing for the case of hosts that have vector operations, but did not handle the case of hosts that do not have vector ops. This was ok until e2e7168a214b, which changed the encoding of simd_desc such that the odd sizes are impossible. Add memset as a t

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 4:01 PM, Peter Maydell wrote: > On Mon, 4 Jan 2021 at 13:59, Philippe Mathieu-Daudé wrote: >> I don't have access to OSX host. I'll see to install an aarch32 chroot and >> keep testing (not sure what can differ from an i386 guest). >> If I can't find anything I'll resend the same series

[PULL 3/3] tcg: Add tcg_gen_bswap_tl alias

2021-01-04 Thread Richard Henderson
The alias is intended to indicate that the bswap is for the entire target_long. This should avoid ifdefs on some targets. Reviewed-by: Frank Chang Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/tcg/tcg-op.h b/include/tcg/

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Paolo Bonzini
On 04/01/21 16:19, Peter Maydell wrote: On Mon, 4 Jan 2021 at 14:40, Paolo Bonzini wrote: On 04/01/21 14:21, Peter Maydell wrote: The rest of QEMU should only ever be using QEMU's TLS abstractions and not directly be tied to GNUTLS. So ideally the gnutls flags should only ever be added in the

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Peter Maydell
On Mon, 4 Jan 2021 at 17:49, Paolo Bonzini wrote: > On 04/01/21 16:19, Peter Maydell wrote: > > Does this work recursively? For instance monitor/qmp-cmds.c > > needs the gnutls CFLAGS because: > > * qmp-cmds.c includes ui/vnc.h > > * ui/vnc.h includes include/crypto/tlssession.h > > * includ

Re: [Question] SR-IOV VF 'surprise removal' and vfio_reset behavior in pSeries

2021-01-04 Thread Alex Williamson
On Mon, 4 Jan 2021 10:35:45 -0300 Daniel Henrique Barboza wrote: > Hi, > > This question came up while I was investigating a Libvirt bug [1], where an > user is removing > VFs from the host while Libvirt domains was using them, causing Libvirt to > remain in > an inconsistent state. I'm trying

[Bug 1909921] Re: Raspberry Pi 4 qemu:handle_cpu_signal received signal outside vCPU context @ pc=0xffff87709b0e

2021-01-04 Thread Snoobz
Hello, I'm trying to start a TeamSpeak 3 Server inside my Docker container. Yes, this application is publicly available on the developer website and is free to install and use. Feel free to ask more question or test in other to resolve this matter. Thank you. Regards, -- You received this bu

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 6:39 PM, Philippe Mathieu-Daudé wrote: > On 1/4/21 4:01 PM, Peter Maydell wrote: >> On Mon, 4 Jan 2021 at 13:59, Philippe Mathieu-Daudé wrote: >>> I don't have access to OSX host. I'll see to install an aarch32 chroot and >>> keep testing (not sure what can differ from an i386 guest). >>

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Eduardo Habkost
On Mon, Jan 04, 2021 at 01:54:32PM +0100, Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > >> > > >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | > >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) |

Re: [PULL 00/35] MIPS patches for 2021-01-03

2021-01-04 Thread Philippe Mathieu-Daudé
On 1/4/21 7:24 PM, Philippe Mathieu-Daudé wrote: > On 1/4/21 6:39 PM, Philippe Mathieu-Daudé wrote: >> On 1/4/21 4:01 PM, Peter Maydell wrote: >>> On Mon, 4 Jan 2021 at 13:59, Philippe Mathieu-Daudé wrote: I don't have access to OSX host. I'll see to install an aarch32 chroot and keep te

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-04 Thread Alexander Graf
On 04.01.21 16:23, Alex Bennée wrote: Roman Bolshakov writes: Pages can't be both write and executable at the same time on Apple Silicon. macOS provides public API to switch write protection [1] for JIT applications, like TCG. 1. https://developer.apple.com/documentation/apple_silicon/port

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-04 Thread Ram Pai
On Mon, Jan 04, 2021 at 01:46:29PM +0100, Halil Pasic wrote: > On Sun, 3 Jan 2021 23:15:50 -0800 > Ram Pai wrote: > > > On Fri, Dec 18, 2020 at 12:41:11PM +0100, Cornelia Huck wrote: > > > On Thu, 17 Dec 2020 15:15:30 +0100 > [..] > > > > > > > > +int kvmppc_svm_init(SecurableGuestMemory *sgm, Er

Re: [BUG] qemu git error with virgl

2021-01-04 Thread Igor Mammedov
On Sun, 3 Jan 2021 18:28:11 +0100 Philippe Mathieu-Daudé wrote: > Cc'ing Gerd + patch author/reviewer. > > On 1/2/21 2:11 PM, Torsten Wohlfarth wrote: > > Hello, > > > > i can't start any system if i use virgl. I get the following error: > > > > qemu-x86_64: ../ui/console.c:1791: dpy_gl_ctx_cr

Re: [PATCH v2 02/12] libqtest: add qtest_socket_server()

2021-01-04 Thread Wainer dos Santos Moschetta
On 12/7/20 2:20 PM, Stefan Hajnoczi wrote: Add an API that returns a new UNIX domain socket in the listen state. The code for this was already there but only used internally in init_socket(). This new API will be used by vhost-user-blk-test. Signed-off-by: Stefan Hajnoczi --- tests/qtest/l

Re: [PATCH v2 03/12] libqtest: add qtest_kill_qemu()

2021-01-04 Thread Wainer dos Santos Moschetta
On 12/7/20 2:20 PM, Stefan Hajnoczi wrote: Tests that manage multiple processes may wish to kill QEMU before destroying the QTestState. Expose a function to do that. The vhost-user-blk-test testcase will need this. Signed-off-by: Stefan Hajnoczi --- tests/qtest/libqos/libqtest.h | 11 +

Re: [BUG] qemu git error with virgl

2021-01-04 Thread Torsten Wohlfarth
Hi Igor, yes, that fixes my issue. Regards, Torsten Am 04.01.21 um 19:50 schrieb Igor Mammedov: On Sun, 3 Jan 2021 18:28:11 +0100 Philippe Mathieu-Daudé wrote: Cc'ing Gerd + patch author/reviewer. On 1/2/21 2:11 PM, Torsten Wohlfarth wrote: Hello, i can't start any system if i use virgl.

[PATCH v3 0/3] vfio-ccw: Implement request notifier

2021-01-04 Thread Eric Farman
Conny, et al, Here is an updated (final?) version of the QEMU series for the vfio-ccw request notifier now that the kernel code landed upstream [1]. The actual meat (patch 3) is identical to its counterpart in v2 [2]. Earlier versions didn't use update-linux-headers.sh; they just carried a dummy

[PATCH v3 1/3] update-linux-headers: Include const.h

2021-01-04 Thread Eric Farman
Kernel commit a85cbe6159ff ("uapi: move constants from to ") breaks our script because of the unrecognized include. Let's add that to our processing. Signed-off-by: Eric Farman --- scripts/update-linux-headers.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/up

[PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-04 Thread Eric Farman
Signed-off-by: Eric Farman --- .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- include/standard-headers/drm/drm_fourcc.h | 175 +- include/standard-headers/linux/const.h| 36 include/standard-headers

Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

2021-01-04 Thread Atish Patra
On Tue, 2020-12-29 at 12:49 +0800, Bin Meng wrote: > Hi Atish, > > On Wed, Dec 23, 2020 at 9:20 AM Bin Meng wrote: > > > > Hi Atish, > > > > On Wed, Dec 23, 2020 at 3:59 AM Atish Patra > > wrote: > > > > > > On Tue, 2020-12-22 at 13:35 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > >

[PATCH v3 3/3] vfio-ccw: Connect the device request notifier

2021-01-04 Thread Eric Farman
Now that the vfio-ccw code has a notifier interface to request that a device be unplugged, let's wire that together. Signed-off-by: Eric Farman Reviewed-by: Cornelia Huck --- hw/vfio/ccw.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --gi

Re: [PULL for-5.2 2/2] scripts/tracetool: silence SystemTap dtrace(1) long long warnings

2021-01-04 Thread Laurent Vivier
On 11/11/2020 16:56, Stefan Hajnoczi wrote: > SystemTap's dtrace(1) prints the following warning when it encounters > long long arguments: > > Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax > error near: > probe vhost_vdpa_dev_start > > Warning: Proceeding as if --

Re: [PATCH v2] tcg: Fix execution on Apple Silicon

2021-01-04 Thread Alex Bennée
Alexander Graf writes: > On 04.01.21 16:23, Alex Bennée wrote: >> Roman Bolshakov writes: >> >>> Pages can't be both write and executable at the same time on Apple >>> Silicon. macOS provides public API to switch write protection [1] for >>> JIT applications, like TCG. >>> >>> 1. >>> https://

Re: [PATCH] meson: Propagate gnutls dependency

2021-01-04 Thread Paolo Bonzini
On 04/01/21 18:24, Roman Bolshakov wrote: Hi Paolo, I'm sorry I didn't reply earlier. As I showed in an example to Peter (https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg00085.html): https://github.com/mesonbuild/meson/commit/ff5dc65ef841857dd306694dff1fb1cd2bf801e4 The approach doesn'

Re: [PATCH v3 0/3] nvdimm: read-only file support

2021-01-04 Thread Eduardo Habkost
Is anybody already going to merge this? If not, I can merge it. On Mon, Jan 04, 2021 at 05:13:17PM +, Stefan Hajnoczi wrote: > v3: > * Produce an error when -device nvdimm,unarmed=off is used with -object >memory-backend-file,readonly=on instead of silently switching on >unarmed. [Ig

Re: [PATCH v2 04/12] libqtest: add qtest_remove_abrt_handler()

2021-01-04 Thread Wainer dos Santos Moschetta
On 12/7/20 2:20 PM, Stefan Hajnoczi wrote: Add a function to remove previously-added abrt handler functions. Now that a symmetric pair of add/remove functions exists we can also balance the SIGABRT handler installation. The signal handler was installed each time qtest_add_abrt_handler() was ca

Re: [PATCH v2 2/3] hostmem-file: add readonly=on|off option

2021-01-04 Thread Eduardo Habkost
On Mon, Jan 04, 2021 at 03:42:23PM +, Stefan Hajnoczi wrote: > On Mon, Dec 14, 2020 at 12:10:15PM +0100, Igor Mammedov wrote: > > On Wed, 16 Sep 2020 10:51:49 +0100 > > Stefan Hajnoczi wrote: > > > > > Let -object memory-backend-file work on read-only files when the > > > readonly=on option i

Re: [PATCH v2 0/3] pc: Support configuration of SMBIOS entry point type

2021-01-04 Thread Eduardo Habkost
On Tue, Dec 29, 2020 at 02:20:01PM +0100, Igor Mammedov wrote: > On Mon, 14 Dec 2020 15:50:26 -0500 > Eduardo Habkost wrote: > > > This includes code previously submitted[1] by Daniel P. Berrangé > > to add a "smbios-ep" machine property on PC. > > > > SMBIOS 3.0 is necessary to support more tha

[PATCH v3 00/15] target/mips/mips-defs: Simplify ISA definitions

2021-01-04 Thread Philippe Mathieu-Daudé
v3: Replace ISA_MIPS3 by ISA_MIPS64 (Richard) v2: Do not use MIPS3 for 64R1 (Jiaxun) Missing review: 1, 3, 4, 5 As we don't need to duplicate 32/64-bit ISA defititions, this series remove the duplicated 64-bit variants, simplifying the overall. Regards, Phil. $ git backport-diff -u v2 -r ..v3

[PATCH v3 01/15] target/mips/mips-defs: Remove USE_HOST_FLOAT_REGS comment

2021-01-04 Thread Philippe Mathieu-Daudé
Remove a comment added 12 years ago but never used (commit b6d96beda3a: "Use temporary registers for the MIPS FPU emulation"). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/mips/mips-defs.h b/target/mips/mips-def

[PATCH v3 03/15] target/mips/mips-defs: Rename CPU_MIPSxx Release 1 as CPU_MIPSxxR1

2021-01-04 Thread Philippe Mathieu-Daudé
'CPU_MIPS32' and 'CPU_MIPS64' definitions concern CPUs implementing the "Release 1" ISA. Rename it with the 'R1' suffix, as the other CPU definitions do. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 8 target/mips/translate_init.c.inc | 14 +++---

[PATCH v3 11/15] target/mips/mips-defs: Rename ISA_MIPS32 as ISA_MIPS_R1

2021-01-04 Thread Philippe Mathieu-Daudé
The MIPS ISA release '1' is common to 32/64-bit CPUs. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- target/mips/mips-defs.h | 4 +-- target/mips/translate.c | 54 - 3 files changed, 30 insertion

[PATCH v3 06/15] target/mips/mips-defs: Use ISA_MIPS32 definition to check Release 1

2021-01-04 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32 definition to check if the Release 1 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R1 in few commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips

[PATCH v3 02/15] target/mips/mips-defs: Reorder CPU_MIPS5 definition

2021-01-04 Thread Philippe Mathieu-Daudé
Move CPU_MIPS5 after CPU_MIPS4 :) Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h index 555e165fb01.

[PATCH v3 04/15] target/mips/mips-defs: Introduce CPU_MIPS64 and cpu_type_is_64bit()

2021-01-04 Thread Philippe Mathieu-Daudé
MIPS 64-bit ISA is introduced with MIPS3. Introduce the CPU_MIPS64 definition aliased to the MIPS3 ISA, and the cpu_type_is_64bit() method to check if a CPU supports this ISA (thus is 64-bit). Suggested-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 5 +

[PATCH v3 07/15] target/mips/mips-defs: Use ISA_MIPS32R2 definition to check Release 2

2021-01-04 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R2 definition to check if the Release 2 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R2 in few commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mi

[PATCH v3 08/15] target/mips/mips-defs: Use ISA_MIPS32R3 definition to check Release 3

2021-01-04 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R3 definition to check if the Release 3 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R3 in few commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mi

[PATCH v3 05/15] hw/mips/boston: Check 64-bit support with cpu_type_is_64bit()

2021-01-04 Thread Philippe Mathieu-Daudé
Directly check if the CPU supports 64-bit with the recently added cpu_type_is_64bit() helper (inlined). Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/boston.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index c3b94c68e1b..467f

[PATCH v3 15/15] target/mips/mips-defs: Rename ISA_MIPS32R6 as ISA_MIPS_R6

2021-01-04 Thread Philippe Mathieu-Daudé
The MIPS ISA release 6 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 4 +- target/mips/mips-defs.h| 4 +- linux

[PATCH v3 09/15] target/mips/mips-defs: Use ISA_MIPS32R5 definition to check Release 5

2021-01-04 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R5 definition to check if the Release 5 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R5 in few commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mi

[PATCH v3 10/15] target/mips/mips-defs: Use ISA_MIPS32R6 definition to check Release 6

2021-01-04 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R6 definition to check if the Release 6 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R6 in few commits. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mi

[PATCH v3 12/15] target/mips/mips-defs: Rename ISA_MIPS32R2 as ISA_MIPS_R2

2021-01-04 Thread Philippe Mathieu-Daudé
The MIPS ISA release 2 is common to 32/64-bit CPUs. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- target/mips/mips-defs.h| 4 +- linux-user/mips/cpu_loop.c | 2 +- target/mips/cp0_timer.c| 4 +- target/mips/helper.c

[PATCH v3 14/15] target/mips/mips-defs: Rename ISA_MIPS32R5 as ISA_MIPS_R5

2021-01-04 Thread Philippe Mathieu-Daudé
The MIPS ISA release 5 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 4 ++-- target/mips/translate.c | 2 +- 2 files chang

[PATCH v3 13/15] target/mips/mips-defs: Rename ISA_MIPS32R3 as ISA_MIPS_R3

2021-01-04 Thread Philippe Mathieu-Daudé
The MIPS ISA release 3 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v2 3/3] hw/i386: expose a "smbios-ep" PC machine property

2021-01-04 Thread Igor Mammedov
On Mon, 14 Dec 2020 15:50:29 -0500 Eduardo Habkost wrote: > From: Daniel P. Berrangé > > The i440fx and Q35 machine types are both hardcoded to use the legacy > SMBIOS 2.1 entry point. This is a sensible conservative choice because > SeaBIOS only supports SMBIOS 2.1 > > EDK2, however, can also

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2021-01-04 Thread Igor Mammedov
On Mon, 04 Jan 2021 13:54:32 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > >> > > >> > +/* Hyper-V features enabled with 'hyperv=on' */ > >> > +x86mc->default_hyperv_features = BIT(HYPERV_FEAT_RELAXED) | > >> > +BIT(HYPERV_FEAT_VAPIC) | BIT(HYPERV_FEAT_TIME) | > >>

[PATCH v4 0/4] Misc sam460ex fixes (was: Clean up sam460ex irq mapping)

2021-01-04 Thread BALATON Zoltan via
Changes from v3: - removed first two patches changing Kconfig because the FDT one seems to be needed so we should not remove those from KConfig and there was some question about patch 1 - added a new patch to use type cast macro in sam460ex.c - the other 3 patches should be the same as in v3 Re

  1   2   >