On Mon, 4 Jan 2021 at 16:30, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > On 1/4/21 5:12 PM, Peter Maydell wrote: > > The qmp-cmds.c file currently includes ui/vnc.h, which (being located > > in the ui/ directory rather than include) is really supposed to be > > for use only by the ui subsystem. > > That makes me remember yet another cleanup series I started few months > ago to remove -I$(srcdir) from $CFLAGS. Now that Meson is in, I might > eventually refresh it.
Yeah, I just floated that idea on IRC. I bet we have a ton of places that don't follow the "headers not in include/ are supposed to be subsystem-internal" guideline, though, so it feels like one of those "whether it's worth the effort depends on how painful it is" cleanups... thanks -- PMM
