Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size

2020-12-16 Thread Keqian Zhu
Hi drew, On 2020/12/15 19:20, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 03:19:47PM +0800, Keqian Zhu wrote: >> When handle dirty log, we face qemu_real_host_page_size and >> TARGET_PAGE_SIZE. The first one is the granule of KVM dirty >> bitmap, and the second one is the granule of QEMU dirty b

Re: [PATCH 2/2] accel: kvm: Add aligment check for kvm_log_clear_one_slot

2020-12-16 Thread Keqian Zhu
On 2020/12/15 19:55, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 03:19:48PM +0800, Keqian Zhu wrote: >> The parameters start and size are transfered from QEMU memory >> emulation layer. It can promise that they are TARGET_PAGE_SIZE >> aligned. However, KVM needs they are qemu_real_page_size al

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-16 Thread Gerd Hoffmann
Hi, > > I'm wondering though how you end up with spice being enabled > > but spiceaudio driver not being available. There is no separate > > config switch so you should have both spice + spiceaudio or > > none of them ... > > Hi Gerd, > > I can reproduce this problem on my openSUSE 15.2 syste

Re: [PATCH 2/2] accel: kvm: Add aligment check for kvm_log_clear_one_slot

2020-12-16 Thread Keqian Zhu
On 2020/12/16 15:23, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 12:55:50PM +0100, Andrew Jones wrote: >> On Tue, Dec 15, 2020 at 03:19:48PM +0800, Keqian Zhu wrote: >>> The parameters start and size are transfered from QEMU memory >>> emulation layer. It can promise that they are TARGET_PAGE_

Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size

2020-12-16 Thread Keqian Zhu
Hi Peter, On 2020/12/16 1:57, Peter Xu wrote: > On Tue, Dec 15, 2020 at 03:19:47PM +0800, Keqian Zhu wrote: >> When handle dirty log, we face qemu_real_host_page_size and >> TARGET_PAGE_SIZE. The first one is the granule of KVM dirty >> bitmap, and the second one is the granule of QEMU dirty bitma

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo

Re: [PATCH 03/12] qapi/main: handle theoretical None-return from re.match()

2020-12-16 Thread Markus Armbruster
John Snow writes: > Mypy cannot understand that this match can never be None, so help it > along. > > Signed-off-by: John Snow > --- > scripts/qapi/main.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/qapi/main.py b/scripts/qapi/main.py > index 42517210b805

Re: [PATCH 04/12] qapi/gen: assert that _start_if is not None in _wrap_ifcond

2020-12-16 Thread Markus Armbruster
John Snow writes: > We already assert this in end_if, but that's opaque to mypy. Do it in > _wrap_ifcond instead. Same effect at runtime, but mypy can now infer > the type in _wrap_ifcond's body. > > Signed-off-by: John Snow > --- > scripts/qapi/gen.py | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH 05/12] qapi/gen: use './builtin' for the built-in module name

2020-12-16 Thread Markus Armbruster
John Snow writes: > Use this in preference to 'None', which helps remove some edge cases in > the typing. > > Signed-off-by: John Snow Clearly better. Should've done it this way in commit c2e196a9b4 "qapi: Prepare for system modules other than 'builtin'". > --- > scripts/qapi/gen.py | 27 +++

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-16 Thread David Edmondson
On Wednesday, 2020-12-16 at 07:43:53 +01, Andrew Jones wrote: > On Tue, Dec 15, 2020 at 06:20:48PM +, David Edmondson wrote: >> On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: >> >> > static void fdt_add_cpu_nodes(const VirtMachineState *vms) >> > { >> > -int cpu; >> > -

Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-16 Thread Claudio Fontana
On 12/14/20 10:56 PM, Philippe Mathieu-Daudé wrote: > Hi Claudio, Eduardo. > > On 12/14/20 8:10 PM, Eduardo Habkost wrote: >> On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote: >>> From: Eduardo Habkost >>> >>> since tcg_cpu_ops.h is only included in cpu.h, >>> and as a standalone h

[Bug 1908369] [NEW] heap-use-after-free in in nic_reset ../hw/net/eepro100.c:616

2020-12-16 Thread Gaoning Pan
Public bug reported: Hello, An heap-use-after-free issue was found in hw/net/eepro100.c:616 in latest version 5.2.0. This issue was found when I was debugging Qemu in monitor. When I attach An eepro100 NIC, and reload the snapshot, the use-after-free triggers. Qemu boot command is as follows: .

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

2020-12-16 Thread Ying Fang
On 12/16/2020 1:48 AM, Andrew Jones wrote: virt machine's 'smp_cpus' and machine->smp.cpus must always have the same value. And, anywhere we have virt machine state we have machine state. So let's remove the redundancy. Also, to make it easier to see that machine->smp is the true source for "s

[PATCH v2 0/7] PPC64: Add support for the new prefixed instructions

2020-12-16 Thread Gustavo Romero
This series aims to add support for the new prefixed instructions introduced with POWER10 CPUs (ISA v3.1). v2: - Fixes accordingly to Alex Bennée's review: Removed fixes for BUILD_DIR and quiet-command since they are already upstream. Reverted all the tests to ppc64le-linux-user as they a

[Bug 1907969] Re: linux-user/i386: Segfault when mixing threads and signals

2020-12-16 Thread The Lemon Man
I finally understand where the problem is. Qemu's user-mode emulation maps guest threads to native ones by spawning a new native one and running a forked copy of the CPUX86State in parallel with the main thread. This works fine for pretty much every architecture but i386 where the GDT/LDT comes

[PATCH v2 1/7] target/ppc: Add infrastructure for prefixed instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth Some prefixed instructions (Type 0 and 1, e.g. 8-byte Load/Store or 8LS), have a completely seperate namespace for their primary opcodes. Other prefixed instructions (Type 2 and 3, e.g. Modified Load/Store or MLS) actually re-use existing opcodes to provide a modified variant.

[PATCH v2 3/7] tests/tcg: Add tests for prefixed load/store instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth This commit adds various tests to exercise the implementation of prefixed load/store instructions on POWER10. Signed-off-by: Michael Roth [ gromero - fix to avoid alignment interrupt, don't cross 64-byte boundary - fix displacement for pl{bz,hz,ha,wz,wa,d} to skip b

[PATCH v2 2/7] target/ppc: Add support for prefixed load/store instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth This commit adds support for the following prefixed load and store instructions for GPRs: plbz, plh{a,z}, plw{a,z}, pld, plq pstb, psth, pstw, pstd, pstq paddi Signed-off-by: Michael Roth [ gromero: - fix for gen_addr_imm34_index() - fix build when target !=

[PATCH v2 7/7] tests/tcg: Add tests for prefixed load/store FP instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth Signed-off-by: Michael Roth [ gromero: - tweaks in debug output ] Signed-off-by: Gustavo Romero --- tests/tcg/ppc64le/Makefile.target | 4 + .../test-prefixed-load-store-fp.c | 270 ++ 2 files changed, 274 insertions(+) create mode

[PATCH v2 4/7] target/ppc: Add support for paired vector load/store instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth This adds support for the following load/store instructions for paired vector registers: lxvp, plxvp, lxvpx stxvp, pstxvp, stxvpx Signed-off-by: Michael Roth [ gromero: - fix in helper_load_paired_vec(), for LE - fix in helper_store_paired_vec(), for LE

Re: [PATCH v5 3/4] hmp: Use QMP query-netdev in hmp_info_network

2020-12-16 Thread Alexey Kirillov
16.12.2020, 08:58, "Jason Wang" : > - Original Message - >>  Jason Wang writes: >> >>  [...] >>  > One more stupid question, instead of generating the string via hard >>  > codes, is there any method (dict?) to iterate all the key/values >>  > automatically? >> >>  QAPI visitors. >> >>  

[PATCH v2 5/7] tests/tcg: Add tests for paired vector load/store instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth Signed-off-by: Michael Roth [ gromero: - aligned prefixed insns., avoiding cross 64-byte boundary - fix to skip branch insn. just after PLXVP - fix various buffer offsets used in comparisons, for LE only - tweaks in debug output ] Signed-off-by

[PATCH v2 6/7] target/ppc: Add support for prefixed load/store FP instructions

2020-12-16 Thread Gustavo Romero
From: Michael Roth This commit adds support for the following load/store instructions for FP registers: plf, plfd pstfs, pstfd Signed-off-by: Michael Roth Signed-off-by: Gustavo Romero --- target/ppc/translate/fp-impl.c.inc | 48 ++ target/ppc/translate/fp-ops

Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel

2020-12-16 Thread Markus Armbruster
John Snow writes: > We use None to represent an object that has no source information > because it's a builtin. This complicates interface typing, since many > interfaces expect that there is an info object available to print errors > with. > > Introduce a special QAPISourceInfo that represents t

Re: [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions

2020-12-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201216090804.58640-1-grom...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201216090804.58640-1-grom...@linux.ibm.com Subject: [PATCH v2 0/7] PPC64: Add support

[Bug 1907817] Re: qemu-aarch64 tcg assertion v5.2.0

2020-12-16 Thread Matus Kysel
I can confirm this patch fixes the issue -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907817 Title: qemu-aarch64 tcg assertion v5.2.0 Status in QEMU: Confirmed Bug description: After updati

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.12.2020 13:53, Li Feng wrote: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte

[PATCH 0/2] iotests: filter qom path in 172

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here are two small patches to improve _filter_qom_path filter and reuse it for 172 iotest Vladimir Sementsov-Ogievskiy (2): iotests: make _filter_qom_path more strict iotests:172: use _filter_qom_path tests/qemu-iotests/172 | 2 +- tests/qemu-iotests/172.out | 152

[PATCH 1/2] iotests: make _filter_qom_path more strict

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
According to original commit, that added this filter (627f607e3dddb2), the problematic thing in qom path is device[NUMBER], not the whole path. Seems that tracking the other parts of the path in iotest output is not bad. Let's make _filter_qom_path stricter. Signed-off-by: Vladimir Sementsov-Ogiev

[PATCH 2/2] iotests:172: use _filter_qom_path

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
device[NUMBER] thing in QOM path is not stable and tracking it during code modifications is not fun. Let's filter it like it's already done in iotest 186. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/172 | 2 +- tests/qemu-iotests/172.out | 152 ++-

Re: CXL support in QEMU

2020-12-16 Thread Thomas Huth
On 16/12/2020 06.05, Prashant V Agarwal wrote: > Hi, > Is there a way to know the support plans for CXL protocol in QEMU? > I see that there is side branch development going on: > > https://gitlab.com/bwidawsk/qemu/-/tree/cxl-2.0v2 > > > But whe

Re: [PATCH 2/2] qom: Assert that objects being destroyed have no parent

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 11:53:06AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Dec 16, 2020 at 2:41 AM Eduardo Habkost wrote: > > > QOM reference counting bugs are often hard to detect, but there's > > one kind of bug that's easier: if we are freeing an object but is > > still attached to a

[Bug 1908266] Re: spice unnecessary forces nographic

2020-12-16 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908266 Title: spice unnecessary forces nographic Status in QEMU: Incomplete Bug description:

Re: [PATCH v13 07/19] multi-process: add qio channel function to transmit data and fds

2020-12-16 Thread Stefan Hajnoczi
On Tue, Dec 15, 2020 at 01:22:25PM -0800, Elena Ufimtseva wrote: > On Tue, Dec 15, 2020 at 02:49:22PM +0400, Marc-André Lureau wrote: > > I suggest to adapt the code so qio_channel_readv_all_eof() calls > > qio_channel_readv_full_all(). > > > > You may want to split this patch in 2 parts: the read

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-16 Thread Bin Meng
Hi Francisco, On Wed, Dec 16, 2020 at 12:40 AM Francisco Iglesias wrote: > > Hello Bin, > > On [2020 Dec 12] Sat 17:44:27, Bin Meng wrote: > > Hi Francisco, > > > > On Sat, Dec 12, 2020 at 5:24 PM Francisco Iglesias > > wrote: > > > > > > Hi bin, > > > > > > On [2020 Dec 12] Sat 16:16:59, Bin Me

Re: [PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory

2020-12-16 Thread Markus Armbruster
John Snow writes: > -- > > events.py had an info to route, was it by choice that it wasn't before? See below. I figure this is intentionally below the -- line, but ... > Signed-off-by: John Snow ... this should be above it. > --- > scripts/qapi/events.py | 2 +- > scripts/qapi/schema.py |

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-12-16 Thread Steven Price
On 16/12/2020 07:31, Haibo Xu wrote: [...] Hi Steve, Hi Haibo I have finished verifying the POC on a FVP setup, and the MTE test case can be migrated from one VM to another successfully. Since the test case is very simple which just maps one page with MTE enabled and does some memory access,

Re: [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2020-12-16 Thread Bin Meng
Hi Alistair, Peter, On Wed, Dec 2, 2020 at 10:45 PM Bin Meng wrote: > > From: Bin Meng > > Avoid using a magic number (4) everywhere for the number of chip > selects supported. > > Signed-off-by: Bin Meng > Reviewed-by: Alistair Francis > --- > > (no changes since v1) > > hw/ssi/imx_spi.c

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will c

Re: [PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str

2020-12-16 Thread Markus Armbruster
John Snow writes: > QAPIGenC and QAPIGenH in particular depend on fname being defined, but > we have a usage of QAPIGenCCode that isn't intended to be associated > with a particular file. Which one? Hmm, it's this one: class QAPISchemaGenCommandVisitor(QAPISchemaModularCVisitor): d

[Bug 1908369] Re: heap-use-after-free in in nic_reset ../hw/net/eepro100.c:616

2020-12-16 Thread Gaoning Pan
** Changed in: qemu Assignee: (unassigned) => Gaoning Pan (hades0506) ** Description changed: Hello, An heap-use-after-free issue was found in hw/net/eepro100.c:616 in latest version 5.2.0. This issue was found when I was debugging Qemu in monitor. When I attach An eepro100 N

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 15.12.2020 13:53, Li Feng wrote: > > > > This patch addresses this issue: > > > >

Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None

2020-12-16 Thread Markus Armbruster
John Snow writes: > Instead of using None as the built-in module filename, use an empty > string instead. PATCH 05's changes the module name of the special system module for built-in stuff from None to './builtin'. The other system modules are named like './FOO': './init' and './emit' currently

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-16 Thread Philippe Mathieu-Daudé
On 12/16/20 4:14 AM, Jiaxun Yang wrote: > 在 2020/12/16 上午10:50, Jiaxun Yang 写道: >> >> >> TBH I do think it doesn't sounds like a good idea to make 32-bit >> and 64-bit different. In fact ISA_MIPS32R6 is always set for targets >> with ISA_MIPS64R6. >> >> We're treating MIPS64R6 as a superset of MIPS

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-16 Thread Philippe Mathieu-Daudé
On 12/16/20 12:48 AM, Philippe Mathieu-Daudé wrote: > On 12/16/20 12:27 AM, Richard Henderson wrote: >> On 12/15/20 4:57 PM, Philippe Mathieu-Daudé wrote: >>> +bool isa_rel6_available(const CPUMIPSState *env) >>> +{ >>> +if (TARGET_LONG_BITS == 64) { >>> +return cpu_supports_isa(env, IS

Re: [PATCH 1/6] migration: Fix and clean up around @tls-authz

2020-12-16 Thread Daniel P . Berrangé
On Mon, Dec 14, 2020 at 11:14:34AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Nov 13, 2020 at 07:52:31AM +0100, Markus Armbruster wrote: > >> Commit d2f1d29b95 "migration: add support for a "tls-authz" migration > >> parameter" added MigrationParameters member @tls

Re: [PULL 00/45] Misc patches for 2020-12-15

2020-12-16 Thread Peter Maydell
On Tue, 15 Dec 2020 at 17:58, Paolo Bonzini wrote: > > The following changes since commit 69e92bd558d71fdbd0c1989391b20edcc700daa9: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2020-12-15 > 15:35:47 +) > > are available in the Git repos

Re: [PATCH 3/3] target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type

2020-12-16 Thread Peter Maydell
On Tue, 15 Dec 2020 at 21:53, Richard Henderson wrote: > Though it's slightly annoying that F.c has > renamed all of the extensions. It's in a good cause, which is to say it avoids the previous irritating ambiguity where you had some duplication between v8.x-Foo and v8.y-Foo that meant "Foo" alon

[PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Thomas Huth
This initrd contains a virtio-net and a virtio-gpu kernel module, so we can check that we can set a MAC address for the network device and that we can successfully write some stuff into the emulated framebuffer of the virtio-gpu device. Signed-off-by: Thomas Huth --- Based-on: 20201215183623.110

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-16 Thread Philippe Mathieu-Daudé
On 12/16/20 11:50 AM, Philippe Mathieu-Daudé wrote: > On 12/16/20 4:14 AM, Jiaxun Yang wrote: >> 在 2020/12/16 上午10:50, Jiaxun Yang 写道: >>> >>> >>> TBH I do think it doesn't sounds like a good idea to make 32-bit >>> and 64-bit different. In fact ISA_MIPS32R6 is always set for targets >>> with ISA_M

Re: [PATCH] configure: Fail when specified cross compiler cannot be found

2020-12-16 Thread Alex Bennée
Gustavo Romero writes: > Currently if the cross compiler passed to 'configure' (--cross-cc-) does > not exist no error happens and only later when the TCG tests are run they fail > because the cross compiler is not set correctly. Do they? They should just skip because of a non-existing compile

Re: [PATCH v2] gitlab-CI: Test 32-bit builds with the fedora-i386-cross container

2020-12-16 Thread Alex Bennée
Thomas Huth writes: > After adding some missing packages, it's possible to check 32-bit > builds and tests with the fedora-i386-cross container in the gitlab-CI, > too. Unfortunately, the code in subprojects/ ignores the --extra-cflags > (on purpose), so the vhost-user part has to be disabled f

Re: [PATCH] tests/docker: Remove the remainders of debian9 containers from the Makefile

2020-12-16 Thread Alex Bennée
Thomas Huth writes: > The Debian 9 containers have been removed a while ago, so we can > delete the corresponding entries in the Makefile, too. > > Fixes: e3755276d1 ("tests/docker: Remove old Debian 9 containers") > Signed-off-by: Thomas Huth Queued to pr/161220-testing-1, thanks. -- Alex

Re: Are user static builds really dynamically linked ?

2020-12-16 Thread Peter Maydell
On Wed, 16 Dec 2020 at 06:39, Tj (Elloe Linux) wrote: > > user --static builds are apparently resulting in dynamically linked > executables (to the glibc library, not other shared objects ) I think you mean that you end up with an executable that's dynamically linked but although it requires the

Re: [PATCH 0/2] iotests: filter qom path in 172

2020-12-16 Thread Kevin Wolf
Am 16.12.2020 um 10:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > Here are two small patches to improve _filter_qom_path filter and reuse > it for 172 iotest Thanks, applied to the block branch. Kevin

Re: [PATCH v2 8/9] vnc: add support for extended desktop resize

2020-12-16 Thread Daniel P . Berrangé
On Tue, Dec 15, 2020 at 10:20:40AM +, Daniel P. Berrangé wrote: > On Tue, Dec 15, 2020 at 11:15:03AM +0100, Gerd Hoffmann wrote: > > On Tue, Dec 08, 2020 at 06:13:28PM +, Daniel P. Berrangé wrote: > > > On Tue, Dec 08, 2020 at 12:57:36PM +0100, Gerd Hoffmann wrote: > > > > The extended desk

Re: [PATCH] block: report errno when flock fcntl fails

2020-12-16 Thread Kevin Wolf
Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: > When a call to fcntl(2) for the purpose of manipulating file locks > fails, report the error returned by fcntl. > > Signed-off-by: David Edmondson Is appending "Resource temporarily unavailable" in the common case (a file locked by anothe

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-16 Thread Jiaxun Yang
在 2020/12/16 下午6:59, Philippe Mathieu-Daudé 写道: On 12/16/20 11:50 AM, Philippe Mathieu-Daudé wrote: On 12/16/20 4:14 AM, Jiaxun Yang wrote: 在 2020/12/16 上午10:50, Jiaxun Yang 写道: TBH I do think it doesn't sounds like a good idea to make 32-bit and 64-bit different. In fact ISA_MIPS32R6 is a

Re: [PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Cornelia Huck
On Wed, 16 Dec 2020 11:57:11 +0100 Thomas Huth wrote: > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and that we can successfully write some stuff into the emulated > framebuffer of the virtio-gpu device

Re: [PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Thomas Huth
On 16/12/2020 11.57, Thomas Huth wrote: > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and that we can successfully write some stuff into the emulated > framebuffer of the virtio-gpu device. > > Signed-of

Re: [PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Thomas Huth
On 16/12/2020 12.32, Cornelia Huck wrote: > On Wed, 16 Dec 2020 11:57:11 +0100 > Thomas Huth wrote: > >> This initrd contains a virtio-net and a virtio-gpu kernel module, >> so we can check that we can set a MAC address for the network device >> and that we can successfully write some stuff into

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

2020-12-16 Thread Jiaxun Yang
在 2020/12/16 下午6:59, Philippe Mathieu-Daudé 写道: On 12/16/20 11:50 AM, Philippe Mathieu-Daudé wrote: On 12/16/20 4:14 AM, Jiaxun Yang wrote: 在 2020/12/16 上午10:50, Jiaxun Yang 写道: TBH I do think it doesn't sounds like a good idea to make 32-bit and 64-bit different. In fact ISA_MIPS32R6 is al

Re: [PATCH] block: report errno when flock fcntl fails

2020-12-16 Thread David Edmondson
On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: >> When a call to fcntl(2) for the purpose of manipulating file locks >> fails, report the error returned by fcntl. >> >> Signed-off-by: David Edmondson > > Is appending "Resourc

Re: Are user static builds really dynamically linked ?

2020-12-16 Thread Paolo Bonzini
On 16/12/20 12:07, Peter Maydell wrote: On Wed, 16 Dec 2020 at 06:39, Tj (Elloe Linux) wrote: user --static builds are apparently resulting in dynamically linked executables (to the glibc library, not other shared objects ) I think you mean that you end up with an executable that's dynamical

Re: [PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Cornelia Huck
On Wed, 16 Dec 2020 12:36:13 +0100 Thomas Huth wrote: > On 16/12/2020 12.32, Cornelia Huck wrote: > > On Wed, 16 Dec 2020 11:57:11 +0100 > > Thomas Huth wrote: > > > >> This initrd contains a virtio-net and a virtio-gpu kernel module, > >> so we can check that we can set a MAC address for the

Re: [PATCH] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-16 Thread Cornelia Huck
On Wed, 16 Dec 2020 12:32:22 +0100 Thomas Huth wrote: > On 16/12/2020 11.57, Thomas Huth wrote: > > +# Disable blinking cursor, then write some stuff into the > > framebuffer > > +# ("32-bit encoded", the screendump PPM will then only contain > > 24-bit) > > As just discusse

Re: [PATCH] block: report errno when flock fcntl fails

2020-12-16 Thread Kevin Wolf
Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: > On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > > > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: > >> When a call to fcntl(2) for the purpose of manipulating file locks > >> fails, report the error returned by fcntl

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addre

Re: [PATCH v2 2/4] block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

2020-12-16 Thread Kevin Wolf
Am 15.12.2020 um 18:23 hat Sergio Lopez geschrieben: > On Tue, Dec 15, 2020 at 04:01:19PM +0100, Kevin Wolf wrote: > > Am 15.12.2020 um 14:15 hat Sergio Lopez geschrieben: > > > On Tue, Dec 15, 2020 at 01:12:33PM +0100, Kevin Wolf wrote: > > > > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben:

Re: [PATCH for-6.0] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-12-16 Thread Cornelia Huck
On Mon, 14 Dec 2020 09:53:21 +0100 Thomas Huth wrote: > On 25/11/2020 11.54, Thomas Huth wrote: > > We need the CCW address on the libvirt side to correctly identify > > the disk, so add this information to the GuestDiskAddress on s390x. > > > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?

Re: [PATCH for-6.0] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-12-16 Thread Thomas Huth
On 16/12/2020 13.40, Cornelia Huck wrote: > On Mon, 14 Dec 2020 09:53:21 +0100 > Thomas Huth wrote: > >> On 25/11/2020 11.54, Thomas Huth wrote: >>> We need the CCW address on the libvirt side to correctly identify >>> the disk, so add this information to the GuestDiskAddress on s390x. >>> >>> Bu

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 13:41, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > > > On Wed, Dec 16, 2020 at 11:22:

Re: [RFC v2 15/15] target/riscv: rvb: support and turn on B-extension from command line

2020-12-16 Thread Kito Cheng
Hi Alistair, Frank: Should we add the bext_spec option like Vector-ext? I would suggest adding one to align the behavior between V and B. But I have no strong opinion for this. >DEFINE_PROP_STRING("vext_spec", RISCVCPU, cfg.vext_spec),

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 15:57, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On We

[PATCH] tcg,riscv: Fix illegal shift instructions

2020-12-16 Thread Zihao Yu
* This bug can be reproduced by running the following guest instructions on a RISC-V host. (1) xor %ecx,%ecx (2) sar %cl,%eax (3) cmovne %edi,%eax After optimization, the tcg instructions of (2) are movi_i32 tmp3,$0x pref=all sar_i32 tmp3,eax,tmp3 dead

Re: [PATCH] block: report errno when flock fcntl fails

2020-12-16 Thread David Edmondson
On Wednesday, 2020-12-16 at 12:57:46 +01, Kevin Wolf wrote: > Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: >> On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: >> >> > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: >> >> When a call to fcntl(2) for the purpose of man

Re: [PATCH 2/2] qom: Assert that objects being destroyed have no parent

2020-12-16 Thread Paolo Bonzini
On 16/12/20 08:53, Marc-André Lureau wrote: On the principle, I fully agree. But the risk is high to introduce regression if objects are manipulated in strange ways. I remember I wanted object_unref() to automatically remove itself from the parent when the last ref is dropped. I think there

Re: [PATCH v2] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-12-16 Thread Michael Roth
Quoting Thomas Huth (2020-11-27 02:23:53) > We need the CCW address on the libvirt side to correctly identify > the disk, so add this information to the GuestDiskAddress on s390x. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075 > Signed-off-by: Thomas Huth > --- > v2: Add missin

Re: [PATCH for-6.0] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-12-16 Thread Michael Roth
Quoting Cornelia Huck (2020-12-16 06:40:39) > On Mon, 14 Dec 2020 09:53:21 +0100 > Thomas Huth wrote: > > > On 25/11/2020 11.54, Thomas Huth wrote: > > > We need the CCW address on the libvirt side to correctly identify > > > the disk, so add this information to the GuestDiskAddress on s390x. > >

[Bug 1818937] Re: Crash with HV_ERROR on macOS host

2020-12-16 Thread Tung Chieh Lee
For the Mac Big sur 11.0.1 or 11.1, the HV_ERROR issue was caused by code signing issue. the com.apple.vm.hypervisor is deprecated and now is com.apple.security.hypervisor Following pages worth of checking: https://stackoverflow.com/questions/64642062/apple-hypervisor-is-completely-broken-on-mac

[PATCH 00/11] target/mips/mips-defs: Simplify ISA definitions

2020-12-16 Thread Philippe Mathieu-Daudé
As we don't need to duplicate 32/64-bit ISA defititions, this series remove the duplicated 64-bit variants, simplifying the overall. Changes done automatically with my editor using "find and replace". While the 'ISA_MIPS_Rx' form is shorter than 'ISA_MIPS_RELx', which one is the clearer? Regards

[PATCH 01/11] target/mips/mips-defs: Reorder CPU_MIPS5 definition

2020-12-16 Thread Philippe Mathieu-Daudé
Move CPU_MIPS5 after CPU_MIPS4 :) Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h index 805034b8956..f4d76e562d1 100644 --- a/target/mips/mips-defs.h +++ b/ta

[PATCH 04/11] target/mips/mips-defs: Use ISA_MIPS32R3 definition to check Release 3

2020-12-16 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R3 definition to check if the Release 3 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R3 in few commits. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 3 +-- 1 file c

[PATCH 10/11] target/mips/mips-defs: Rename ISA_MIPS32R5 as ISA_MIPS_R5

2020-12-16 Thread Philippe Mathieu-Daudé
The MIPS ISA release 5 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 4 ++-- target/mips/translate.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 03/11] target/mips/mips-defs: Use ISA_MIPS32R2 definition to check Release 2

2020-12-16 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R2 definition to check if the Release 2 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R2 in few commits. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h| 3 +-- linux

Re: CXL support in QEMU

2020-12-16 Thread Jonathan Cameron
On Wed, 16 Dec 2020 10:53:34 +0100 Thomas Huth wrote: > On 16/12/2020 06.05, Prashant V Agarwal wrote: > > Hi, > > Is there a way to know the support plans for CXL protocol in QEMU? > > I see that there is side branch development going on: > > > > https://gitlab.com/bwidawsk/qemu/-/tree/cxl-2.0v

Re: [PATCH v13 12/19] multi-process: introduce proxy object

2020-12-16 Thread Marc-André Lureau
On Mon, Dec 14, 2020 at 9:15 AM Jagannathan Raman wrote: > From: Elena Ufimtseva > > Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Reviewed-by: Stefan Hajnoczi > --- >

[PATCH 05/11] target/mips/mips-defs: Use ISA_MIPS32R5 definition to check Release 5

2020-12-16 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R5 definition to check if the Release 5 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R5 in few commits. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 3 +-- 1 file c

[PATCH 02/11] target/mips/mips-defs: Use ISA_MIPS3 for ISA_MIPS64

2020-12-16 Thread Philippe Mathieu-Daudé
MIPS 64-bit ISA is introduced with MIPS3. No need for another bit/definition to check for 64-bit. Simplify CPU_MIPS64 definition as CPU_MIPS5 contains CPU_MIPS4 which contains CPU_MIPS3 which contains ISA_MIPS3. Suggested-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mi

[PATCH 06/11] target/mips/mips-defs: Use ISA_MIPS32R6 definition to check Release 6

2020-12-16 Thread Philippe Mathieu-Daudé
Use the single ISA_MIPS32R6 definition to check if the Release 6 ISA is supported, whether the CPU support 32/64-bit. For now we keep '32' in the definition name, we will rename it as ISA_MIPS_R6 in few commits. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- target

Re: [PATCH v13 10/19] multi-process: Associate fd of a PCIDevice with its object

2020-12-16 Thread Marc-André Lureau
On Mon, Dec 14, 2020 at 9:15 AM Jagannathan Raman wrote: > Associate the file descriptor for a PCIDevice in remote process with > DeviceState object. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > Reviewed-by: Stefan Hajnoczi > --- > h

[PATCH 07/11] target/mips/mips-defs: Rename ISA_MIPS32 as ISA_MIPS_R1

2020-12-16 Thread Philippe Mathieu-Daudé
The MIPS ISA release '1' is common to 32/64-bit CPUs. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- target/mips/mips-defs.h | 4 ++-- target/mips/translate.c | 44 - 3 files changed, 25 insertions(+), 25 deletions(-) diff --g

[PATCH 08/11] target/mips/mips-defs: Rename ISA_MIPS32R2 as ISA_MIPS_R2

2020-12-16 Thread Philippe Mathieu-Daudé
The MIPS ISA release 2 is common to 32/64-bit CPUs. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 2 +- target/mips/mips-defs.h| 6 +- linux-user/mips/cpu_loop.c | 2 +- target/mips/cp0_timer.c| 4 +- target/mips/cpu.c | 2 +- target/mips/trans

[PATCH 09/11] target/mips/mips-defs: Rename ISA_MIPS32R3 as ISA_MIPS_R3

2020-12-16 Thread Philippe Mathieu-Daudé
The MIPS ISA release 3 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/mip

[PATCH 0/3] Cleanup includes for no-TCG builds

2020-12-16 Thread Paolo Bonzini
Right now, accel/tcg and tcg/$tcg_target are part of the include path for all builds, mostly due to exec/translate-all.h and the flush_icache_range function. But there's also a few useless tcg/tcg.h includes that can simply be removed. This small series, mostly consisting of code movement and fil

[PATCH 11/11] target/mips/mips-defs: Rename ISA_MIPS32R6 as ISA_MIPS_R6

2020-12-16 Thread Philippe Mathieu-Daudé
The MIPS ISA release 6 is common to 32/64-bit CPUs. To avoid holes in the insn_flags type, update the definition with the next available bit. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 4 +- target/mips/mips-defs.h| 4 +- linux-user/elfload.c | 2 +-

[PATCH 1/3] remove TCG includes from common code

2020-12-16 Thread Paolo Bonzini
Enable removing tcg/$tcg_arch from the include path when TCG is disabled. Move translate-all.h to include/exec, since stubs exist for the functions defined therein. Signed-off-by: Paolo Bonzini --- accel/stubs/tcg-stub.c | 1 - accel/tcg/cputlb.c | 2

Re: [PATCH] block: report errno when flock fcntl fails

2020-12-16 Thread Kevin Wolf
Am 16.12.2020 um 14:06 hat David Edmondson geschrieben: > On Wednesday, 2020-12-16 at 12:57:46 +01, Kevin Wolf wrote: > > > Am 16.12.2020 um 12:38 hat David Edmondson geschrieben: > >> On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > >> > >> > Am 15.12.2020 um 20:01 hat David Edmonds

[PATCH 2/3] move icache flush out of tcg.h

2020-12-16 Thread Paolo Bonzini
icache flush is also used by non-TCG accelerators. Do not require users such as physmem.c to include tcg/tcg.h. Signed-off-by: Paolo Bonzini --- include/exec/flush-icache.h | 64 softmmu/physmem.c | 1 + tcg/aarch64/tcg-target.h| 5

[PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds

2020-12-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- trace/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/meson.build b/trace/meson.build index 3fa760f568..012d0dbceb 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -71,7 +71,7 @@ foreach d : [ input:

  1   2   3   4   5   >