Re: [PATCH v2 2/4] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2020-12-13 Thread Philippe Mathieu-Daudé
Hi Wu, [The list is mangling your From: ...] On 12/11/20 11:22 PM, Hao Wu via wrote: > This patch makes NPCM7XX Timer to use a the timer clock generated by the > CLK module instead of the magic nubmer TIMER_REF_HZ. Typo "number". > > Reviewed-by: Havard Skinnemoen > Reviewed-by: Tyrone Ting

[PATCH v12 1/7] Introduce yank feature

2020-12-13 Thread Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register themselves and multiple yank functions. Then all yank functions for selected instances can be called by the 'yank' out-of-band qmp command. Available instances can be queried by a 'qu

[PATCH v12 2/7] block/nbd.c: Add yank feature

2020-12-13 Thread Lukas Straub
Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- block/nbd.c | 154 +++-

Re: [PATCH v2 3/4] hw/adc: Add an ADC module for NPCM7XX

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/11/20 11:22 PM, Hao Wu via wrote: > The ADC is part of NPCM7XX Module. Its behavior is controled by the > ADC_CON register. It converts one of the eight analog inputs into a > digital input and stores it in the ADC_DATA register when enabled. > > Reviewed-by: Havard Skinnemoen > Reviewed-by

[PATCH v12 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-12-13 Thread Lukas Straub
Hello Everyone, So here is v12. @Marc-André Lureau, We still need an ACK for the chardev patch. Changes: v12: -rebase onto master -minor change to migration (removal of "defer" branch in qemu_start_incoming_migration) -add Reviewed-by tags v11: -squashed MAINTAINERS update into patch 1 -

[PATCH v12 3/7] chardev/char-socket.c: Add yank feature

2020-12-13 Thread Lukas Straub
Register a yank function to shutdown the socket on yank. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi --- chardev/char-socket.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 213a4c8dd0..7f2ee

[PATCH v12 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

2020-12-13 Thread Lukas Straub
Migration and yank code assume that qio_channel_shutdown is thread -safe and can be called from qmp oob handler. Document this after checking the code. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- include/io/channel.h | 5 - 1 file changed, 4 in

[PATCH v12 4/7] migration: Add yank feature

2020-12-13 Thread Lukas Straub
Register yank functions on sockets to shut them down. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Acked-by: Dr. David Alan Gilbert --- migration/channel.c | 13 + migration/migration.c | 24 migration/multifd.c | 10 +++

[PATCH v12 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

2020-12-13 Thread Lukas Straub
Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé --- io/channel-tls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c b/io/c

[PATCH v12 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

2020-12-13 Thread Lukas Straub
A connecting chardev object has an additional reference by the connecting thread, so if the chardev is still connecting by the end of the test, then the chardev object won't be freed. This in turn means that the yank instance won't be unregistered and when running the next test-case yank_register_i

[Bug 1907952] [NEW] qemu-system-aarch64: with "-display gtk" arrow keys are received as just ^[ on ttyAMA0

2020-12-13 Thread Ryutaroh Matsumoto
Public bug reported: I originally observed this on Debian packaged qemu 5.2 at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976808 Today I checked out the latest git source at Sun, 13 Dec 2020 19:21:09 +0900 and configured the source as follows: ./configure --prefix=/usr --sysconfdir=/etc -

Re: [PATCH 2/2] include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/12/20 3:41 PM, Peter Maydell wrote: > The grlib.h header defines a set_pil_in_fn typedef which is never > used; remove it. > > Signed-off-by: Peter Maydell > --- > include/hw/sparc/grlib.h | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] hw/sparc: Make grlib-irqmp device handle its own inbound IRQ lines

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/12/20 3:41 PM, Peter Maydell wrote: > Currently the GRLIB_IRQMP device is used in one place (the leon3 board), > but instead of the device providing inbound gpio lines for the board > to wire up, the board code itself calls qemu_allocate_irqs() with > the handler function being a set_irq func

Re: [PATCH v2 4/4] hw/misc: Add a PWM module for NPCM7XX

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/11/20 11:22 PM, Hao Wu via wrote: > The PWM module is part of NPCM7XX module. Each NPCM7XX module has two > identical PWM modules. Each module contains 4 PWM entries. Each PWM has > two outputs: frequency and duty_cycle. Both are computed using inputs > from software side. > > This module do

Re: [PATCH 1/8] hw/ppc/ppc4xx_devs: Make code style fixes to UIC code

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/12/20 1:15 AM, Peter Maydell wrote: > In a following commit we will move the PPC UIC implementation to > its own file in hw/intc. To prevent checkpatch complaining about that > code-motion, fix up the minor style issues first. > > Signed-off-by: Peter Maydell > --- > hw/ppc/ppc4xx_devs.c |

[Bug 1907953] [NEW] pkg install qemu-system-x86_64 não funciona qemu 5.2.0

2020-12-13 Thread Daniel Almeida Moreira
Public bug reported: A qemu funcionava mais quando atualizei para 5.2.0 não iniciar o Windows só fica tela preta quero voltar para anterior mais não consigo ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- d

[PATCH 0/4] coreaudio bug fix and clean up

2020-12-13 Thread Volker Rümelin
Fix a bug reported on the qemu-discuss mailing list. The error message was: coreaudio: Could not lock voice for audioDeviceIOProc Reason: Invalid argument While being there, do some clean up. Howard was kind enough to test the patches. Volker Rümelin (4):   coreaudio: rename misnamed variable f

[PATCH 3/4] coreaudio: always stop audio playback on shut down

2020-12-13 Thread Volker Rümelin
Always stop audio playback and remove the playback callback when QEMU exits. On shut down the function coreaudio_fini_out() destroys the coreaudio mutex but fails to stop audio playback and to remove the audio playback callback, because function audio_is_cleaning_up() always returns true when call

[PATCH 2/4] coreaudio: don't start playback in init routine

2020-12-13 Thread Volker Rümelin
Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device to keep the Core Audio device run state in sync with hw->enabled. Tested-by: Howard Spoelstra Signed-off-by: Volker Rümelin --- audio/coreaudio.c | 11 --- 1 fil

[PATCH 4/4] audio: remove unused function audio_is_cleaning_up()

2020-12-13 Thread Volker Rümelin
The previous commit removed the last call site of audio_is_cleaning_up(). Remove the now unused function. Tested-by: Howard Spoelstra Signed-off-by: Volker Rümelin --- audio/audio.c | 8 audio/audio.h | 1 - 2 files changed, 9 deletions(-) diff --git a/audio/audio.c b/audio/audio.c in

[PATCH 1/4] coreaudio: rename misnamed variable fake_as

2020-12-13 Thread Volker Rümelin
While the variable once was used to fake audio settings, since commit ed2a4a7941 "audio: proper support for float samples in mixeng" this is no longer true. Rename the variable to obt_as. This is the same naming scheme as in audio/sdlaudio.c Tested-by: Howard Spoelstra Signed-off-by: Volker Rümel

Re: [PATCH 3/8] hw/ppc/virtex_ml507: Drop use of ppcuic_init()

2020-12-13 Thread Edgar E. Iglesias
On Sat, Dec 12, 2020 at 12:15:32AM +, Peter Maydell wrote: > Switch the virtex_ml507 board to directly creating and > configuring the UIC, rather than doing it via the old > ppcuic_init() helper function. > > This fixes a trivial Coverity-detected memory leak where > we were leaking the array

Re: [PATCH 2/8] ppc: Convert PPC UIC to a QOM device

2020-12-13 Thread Edgar E. Iglesias
On Sat, Dec 12, 2020 at 12:15:31AM +, Peter Maydell wrote: > Currently the PPC UIC ("Universal Interrupt Controller") is implemented > as a non-QOM device in ppc4xx_devs.c. Convert it to a proper QOM device > in hw/intc. > > The ppcuic_init() function is retained for the moment with its curren

Re: [PATCH 1/8] hw/ppc/ppc4xx_devs: Make code style fixes to UIC code

2020-12-13 Thread Edgar E. Iglesias
On Sat, Dec 12, 2020 at 12:15:30AM +, Peter Maydell wrote: > In a following commit we will move the PPC UIC implementation to > its own file in hw/intc. To prevent checkpatch complaining about that > code-motion, fix up the minor style issues first. Reviewed-by: Edgar E. Iglesias Tested-by: E

Re: [PATCH 8/8] hw/ppc: Remove unused ppcuic_init()

2020-12-13 Thread Edgar E. Iglesias
On Sat, Dec 12, 2020 at 12:15:37AM +, Peter Maydell wrote: > Now we've converted all the callsites to directly create the QOM UIC > device themselves, the ppcuic_init() function is unused and can be > removed. The enum defining PPCUIC symbolic constants can be moved > to the ppc-uic.h header wh

Re: [PATCH 0/2] target/mips: Let cpu_supports_isa() take CPUMIPSState argument

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/7/20 10:52 PM, Philippe Mathieu-Daudé wrote: > Hi Jiaxun, > > Here goes the cpu_supports_isa() helper for your bootloader API: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg764582.html > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): > target/mips: Rename cpu_supports_FE

Re: [PATCH v4 0/6] linux-user: Rework get_elf_hwcap() and support MIPS Loongson 2F/3A

2020-12-13 Thread Philippe Mathieu-Daudé
On 12/7/20 11:43 PM, Philippe Mathieu-Daudé wrote: > Series now fully reviewed. Ping :) > > Since v3: > - Add CP0C0_AR_LENGTH definition (Richard) > - Fixed 3E -> 3A, Longsoon -> Loongson typos (Huacai) > > Since v2: > - Use extract32() in GET_FEATURE_REG_EQU (rth) > > Introduce the GET_FEATUR

Re: [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

2020-12-13 Thread Philippe Mathieu-Daudé
Hi Laurent, On 11/19/20 5:17 PM, Philippe Mathieu-Daudé wrote: > This series allow building linux-user emulator to run ELF > binaries built for the MIPS o32 ABI on 64-bit CPUs (binaries > produced by Sony Linux Toolkit for Playstation 2 for the > R5900 CPU). > > The new QEMU binary is named 'qemu

Re: [PATCH 26/26] MAINTAINERS: Add entry for MIPS Toshiba TCG

2020-12-13 Thread Philippe Mathieu-Daudé
Hi Fredrik, On 12/12/20 5:04 PM, Fredrik Noring wrote: > On Fri, Nov 20, 2020 at 10:08:44PM +0100, Philippe Mathieu-Daudé wrote: >> Add an entry for the TCG core related to Toshiba TXx9. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Adding Fredrik Noring in case he wants to be notified of

Re: [PATCH] target/i386: tracing: format length values as hex

2020-12-13 Thread Laurent Vivier
Le 09/12/2020 à 18:58, Dov Murik a écrit : > ping > > Adding CC qemu-trivial. > > This already got one R-b: > https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html > > -Dov > > > On 03/11/2020 12:07, Dov Murik wrote: >> Three trace events had a literal "0x" prefix but the 'len' v

Re: [PATCH] qemu-options.hx: Fix minor issues in icount documentation

2020-12-13 Thread Laurent Vivier
Le 21/11/2020 à 22:35, Peter Maydell a écrit : > The documentation for the icount documentation has some minor issues: > * in a couple of places it says "sleep=on|off" when in the context of the >sentence it means specifically "sleep=on" > * the synopsis line for the documentation has drifted

Re: [PATCH] MAINTAINERS: update my email address

2020-12-13 Thread Laurent Vivier
Le 28/10/2020 à 21:56, Thomas Huth a écrit : > On 27/10/2020 07.02, Michael Roth wrote: >> I've recently switched employers and the current email address is out >> of date. >> >> Signed-off-by: Michael Roth >> --- >> MAINTAINERS | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> d

Re: [PATCH] hw/xen: Don't use '#' flag of printf format

2020-12-13 Thread Laurent Vivier
Le 04/11/2020 à 14:37, Xinhao Zhang a écrit : > Fix code style. Don't use '#' flag of printf format ('%#') in > format strings, use '0x' prefix instead > > Signed-off-by: Xinhao Zhang > Signed-off-by: Kai Deng > --- > hw/xen/xen_pt.c | 10 +- > hw/xen/xen_pt_config_init.c |

Re: [PATCH] target/i386: tracing: format length values as hex

2020-12-13 Thread Laurent Vivier
Le 13/12/2020 à 16:27, Laurent Vivier a écrit : > Le 09/12/2020 à 18:58, Dov Murik a écrit : >> ping >> >> Adding CC qemu-trivial. >> >> This already got one R-b: >> https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html >> >> -Dov >> >> >> On 03/11/2020 12:07, Dov Murik wrote: >>> Thr

Re: [PATCH] MAINTAINERS: update my email address

2020-12-13 Thread Laurent Vivier
Le 13/12/2020 à 16:58, Laurent Vivier a écrit : > Le 28/10/2020 à 21:56, Thomas Huth a écrit : >> On 27/10/2020 07.02, Michael Roth wrote: >>> I've recently switched employers and the current email address is out >>> of date. >>> >>> Signed-off-by: Michael Roth >>> --- >>> MAINTAINERS | 4 ++-- >>

Re: [PATCH] qemu-options.hx: Fix minor issues in icount documentation

2020-12-13 Thread Laurent Vivier
Le 13/12/2020 à 16:54, Laurent Vivier a écrit : > Le 21/11/2020 à 22:35, Peter Maydell a écrit : >> The documentation for the icount documentation has some minor issues: >> * in a couple of places it says "sleep=on|off" when in the context of the >>sentence it means specifically "sleep=on" >>

Re: [PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

2020-12-13 Thread Laurent Vivier
Le 02/12/2020 à 14:20, Philippe Mathieu-Daudé a écrit : > While this change helps triskaidekaphobic developers, it > is a good practice to avoid magic values and using constant > definitions instead. > > Introduce the PAM_REGIONS_COUNT and use it. No logical change. > > Signed-off-by: Philippe Ma

[Bug 1907969] [NEW] linux-user/i386: Segfault when mixing threads and signals

2020-12-13 Thread The Lemon Man
Public bug reported: Given the following C program, qemu-i386 will surely and certainly segfault when executing it. The problem is only noticeable if the program is statically linked to musl's libc and, as written in the title, it only manifests when targeting i386. Removing the pthread calls o

Re: [PATCH 26/26] MAINTAINERS: Add entry for MIPS Toshiba TCG

2020-12-13 Thread Fredrik Noring
On Sun, Dec 13, 2020 at 04:23:23PM +0100, Philippe Mathieu-Daudé wrote: > On 12/12/20 5:04 PM, Fredrik Noring wrote: > > I may be able to help on the TX79 that is an R5900, but unless commit > > 823f2897bdd7 ("target/mips: Disable R5900 support") is reverted, it > > remains shut off in QEMU. To obt

Re: [PATCH] fsdev: open brace '{' following struct go on the same line

2020-12-13 Thread Laurent Vivier
Le 09/12/2020 à 07:07, zhouyang a écrit : > I found some style problems while check the code using checkpatch.pl. > This commit fixs the issue below: > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: zhouyang > --- > fsdev/9p-marshal.h | 12 > fsdev/fil

Re: [PATCH] CODING_STYLE.rst: Be less strict about 80 character limit

2020-12-13 Thread Laurent Vivier
Le 06/11/2020 à 12:29, Peter Maydell a écrit : > Relax the wording about line lengths a little bit; this goes with the > checkpatch changes to warn at 100 characters rather than 80. > > (Compare the Linux kernel commit bdc48fa11e46f8; our coding style is > not theirs, but the rationale is good and

Re: [PATCH] ads7846: moves from the hw/display folder to the hw/input folder.

2020-12-13 Thread Laurent Vivier
Le 15/11/2020 à 13:35, Gan Qixin a écrit : > ads7846 is a touch-screen controller that is an input device rather > than a display device, so move it to the hw/input folder. > > Signed-off-by: Gan Qixin > --- > hw/arm/Kconfig | 2 +- > hw/display/Kconfig | 3 --- > h

[PATCH 0/3] ui/gtk: paper over a gtk bug on Windows

2020-12-13 Thread Volker Rümelin
Patch dc26435edb "ui/gtk: Update refresh interval after widget is realized" exposed a bug in gtk on Windows. The monitor refresh rate reported by gtk may be much smaller than the real refresh rate leading to an unusable guest screen refresh rate. Details can be found in [PATCH 3/3] ui/gtk: limit v

[PATCH 2/3] ui/gtk: rename variable window to widget

2020-12-13 Thread Volker Rümelin
The type of the variable window is GtkWidget. Rename the variable from window to widget, because windows and widgets are different things. Signed-off-by: Volker Rümelin --- ui/gtk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 86b386a20d..7f

[PATCH 3/3] ui/gtk: limit virtual console max update interval

2020-12-13 Thread Volker Rümelin
Limit the virtual console maximum update interval to GUI_REFRESH_INTERVAL_DEFAULT. This papers over a integer overflow bug in gtk3 on Windows where the reported monitor refresh frequency can be much smaller than the real refresh frequency. The gtk bug report can be found here: https://gitlab.gnome

[PATCH 1/3] ui/gtk: don't try to redefine SI prefixes

2020-12-13 Thread Volker Rümelin
Redefining SI prefixes is always wrong. 1s has per definition 1000ms. Remove the misnamed named constant and replace it with a comment explaining the frequency to period conversion in two simple steps. Now you can cancel out the unit mHz in the comment with the implicit unit mHz in refresh_rate_mil

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Laurent Vivier
Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ since this patch is reviewed. > > On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: >> ping^2... >> >> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrote: >>> ping qemu-block or qemu-arm? >>> >>> On 9/15/20 7:16 PM, Phil

Re: [PATCH v2 2/4] Makefile: Require GNU make 3.82+

2020-12-13 Thread Laurent Vivier
Le 12/10/2020 à 11:47, Thomas Huth a écrit : > On 25/08/2020 22.27, Roman Bolshakov wrote: >> QEMU build fails with cryptic messages if make is too old: >> >> Makefile.ninja:2655: *** multiple target patterns. Stop. >> >> To avoid the confusion it's worth to fail the build right away and print >

Re: [PATCH v2 4/4] configure: Test if $make actually exists

2020-12-13 Thread Laurent Vivier
Le 12/10/2020 à 11:49, Thomas Huth a écrit : > On 25/08/2020 22.27, Roman Bolshakov wrote: >> configure doesn't detect if $make is installed on the build host. >> This is also helpful for hosts where an alias for make is used, i.e. >> configure would fail if gmake is not present on macOS. >> >> Rev

Re: [PATCH RESEND v2 3/7] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init

2020-12-13 Thread Laurent Vivier
Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan > > Missing g_error_free in QEMU_Elf_init() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > Reviewed-by: Viktor Prutyanov > Reviewed-by: Li Qiang > Signed-off-by: Chen Qun > --- > contrib/elf2

Re: [PATCH RESEND v2 4/7] elf2dmp/pdb: Plug memleak in pdb_init_from_file

2020-12-13 Thread Laurent Vivier
Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan > > Missing g_error_free in pdb_init_from_file() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > Reviewed-by: Viktor Prutyanov > Reviewed-by: Li Qiang > Signed-off-by: Chen Qun > --- > contrib

Re: [PATCH RESEND v2 7/7] block/file-posix: fix a possible undefined behavior

2020-12-13 Thread Laurent Vivier
Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan > > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan

Re: [PATCH RESEND v2 6/7] blockdev: Fix a memleak in drive_backup_prepare()

2020-12-13 Thread Laurent Vivier
Le 23/10/2020 à 08:12, Chen Qun a écrit : > From: Pan Nengyuan > > 'local_err' seems forgot to propagate in error path, it'll cause > a memleak. Fix it. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > Reviewed-by: Kevin Wolf > Reviewed-by: Li Qiang > Signed-off-by: Chen Qun > -

Re: [PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > The code that used HAVE_IFADDRS_H has been removed in commit > 0a27af918b ("io: use bind() to check for IPv4/6 availability"), > so we don't need this check in the configure script anymore. > > Signed-off-by: Thomas Huth > --- > configure | 11 -

Re: [PATCH 2/6] configure / meson: Move check for pty.h to meson.build

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 9 - > meson.build | 1 + > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/configure b/configure > index 6c8f

Re: [PATCH 3/6] configure / meson: Move check for drm.h to meson.build

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 10 -- > meson.build | 1 + > 2 files changed, 1 insertion(+), 10 deletions(-) > > diff --git a/configure b/configure > index

Re: [PATCH 4/6] configure / meson: Move check for sys/signal.h to meson.build

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 10 -- > meson.build | 1 + > 2 files changed, 1 insertion(+), 10 deletions(-) > > diff --git a/configure b/configure > index

Re: [PATCH 5/6] configure / meson: Move check for sys/signal.h to meson.build

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > This check can be done in a much shorter way in meson.build. And while > we're at it, rename the #define to HAVE_SYS_KCOV_H to match the other > HAVE_someheader_H symbols that we already have. > > Signed-off-by: Thomas Huth > --- > configure

Re: [PATCH 6/6] configure / meson: Move check for linux/btrfs.h to meson.build

2020-12-13 Thread Laurent Vivier
Le 18/11/2020 à 18:10, Thomas Huth a écrit : > This check can be done in a much shorter way in meson.build. And while > we're at it, rename the #define to HAVE_BTRFS_H to match the other > HAVE_someheader_H symbols that we already have. > > Signed-off-by: Thomas Huth > --- > configure

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds

2020-12-13 Thread Philippe Mathieu-Daudé
On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth wrote: > On 18/11/2020 15.07, Alex Bennée wrote: > > These seem to trigger timeouts with some regularity. > > > > Signed-off-by: Alex Bennée > > --- > > .cirrus.yml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/.cirrus.yml b/.cirrus.

Re: [PATCH v2] hw/block/nand: Decommission the NAND museum

2020-12-13 Thread Peter Maydell
On Sun, 13 Dec 2020 at 17:21, Laurent Vivier wrote: > > Le 16/10/2020 à 18:52, Philippe Mathieu-Daudé a écrit : > > Cc'ing qemu-trivial@ since this patch is reviewed. > > > > On 10/15/20 8:12 PM, Philippe Mathieu-Daudé wrote: > >> ping^2... > >> > >> On 10/1/20 7:31 PM, Philippe Mathieu-Daudé wrot

Re: [PATCH v2 2/4] Makefile: Require GNU make 3.82+

2020-12-13 Thread Peter Maydell
On Sun, 13 Dec 2020 at 17:22, Laurent Vivier wrote: > > Le 12/10/2020 à 11:47, Thomas Huth a écrit : > > On 25/08/2020 22.27, Roman Bolshakov wrote: > >> QEMU build fails with cryptic messages if make is too old: > >> > >> Makefile.ninja:2655: *** multiple target patterns. Stop. > >> > >> To av

Re: [RFC PATCH] .cirrus.yml: bump timeout period for MacOS builds

2020-12-13 Thread Yonggang Luo
On Mon, Dec 14, 2020 at 2:36 AM Philippe Mathieu-Daudé wrote: > > On Wed, Nov 18, 2020 at 4:11 PM Thomas Huth wrote: > > On 18/11/2020 15.07, Alex Bennée wrote: > > > These seem to trigger timeouts with some regularity. > > > > > > Signed-off-by: Alex Bennée > > > --- > > > .cirrus.yml | 2 ++ >

Re: Slow video output from webcam with qemu-xhci but smooth with usb-ehci

2020-12-13 Thread Diego Viola
Not sure it's related but I'm seeing this on the guest now when I use mpv --vo=drm on a tty: [ 28.918606] xhci_hcd :00:04.0: ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13 [ 28.919816] xhci_hcd :00:04.0: Looking for event-dma 00012a8c7d80 trb-start

Re: Slow video output from webcam with qemu-xhci but smooth with usb-ehci

2020-12-13 Thread Diego Viola
On Sun, Dec 13, 2020 at 4:30 PM Diego Viola wrote: > > Not sure it's related but I'm seeing this on the guest now when I use > mpv --vo=drm on a tty: mpv --vo=drm /dev/video0

Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()

2020-12-13 Thread dann frazier
On Wed, Sep 16, 2020 at 2:42 AM Gerd Hoffmann wrote: > > Handle the spice special case in audio_init instead. > > With the qemu_spice_audio_init() symbol dependency being > gone we can build spiceaudio as module. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/qemu-spice.h | 1 - > audio/au

[PULL 00/26] MIPS patches for 2020-12-13

2020-12-13 Thread Philippe Mathieu-Daudé
The following changes since commit ad717e6da3852b5729217d7938eecdb81c546114: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-12-12 00:20:46 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-20201213

[PULL 03/26] target/mips/kvm: Remove unused headers

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-7-f4...@amsat.org> --- target/mips/kvm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/mips/kvm.c b/target/mips/kvm.c index cbd0cb8faa4..94b3a88d8f8 100644 --- a/target/mips/kvm

[PULL 01/26] MAINTAINERS: che...@lemote.com -> chenhua...@kernel.org

2020-12-13 Thread Philippe Mathieu-Daudé
From: Huacai Chen Use @kernel.org address as the main communications end point. Update the corresponding M-entries and .mailmap (for git shortlog translation). Signed-off-by: Huacai Chen Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <1607160121-9977-1-git-s

[PULL 08/26] target/mips: Also display exception names in user-mode

2020-12-13 Thread Philippe Mathieu-Daudé
Currently MIPS exceptions are displayed as string in system-mode emulation, but as number in user-mode. Unify by extracting the current system-mode code as excp_name() and use that in user-mode. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201119160536.1980

[PULL 06/26] target/mips: Do not include CP0 helpers in user-mode emulation

2020-12-13 Thread Philippe Mathieu-Daudé
CP0 helpers are restricted to system-mode emulation. Do not intent do build cp0_helper.c in user-mode (this allows to simplify some #ifdef'ry). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Huacai Chen Message-Id: <20201109090422.2445166-3-f4...@amsat.org> --

[PULL 04/26] target/mips: Include "exec/memattrs.h" in 'internal.h'

2020-12-13 Thread Philippe Mathieu-Daudé
mips_cpu_do_transaction_failed() requires MemTxAttrs and MemTxResult declarations. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-8-f4...@amsat.org> --- target/mips/internal.h | 1 + target/mips/kvm.c | 1 - 2 files changed, 1 inser

[PULL 14/26] target/mips: Remove unused headers from translate.c

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-3-f4...@amsat.org> --- target/mips/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 4a1ae73f9d0..e87f472a8d1 100644 ---

[PULL 02/26] target/mips/kvm: Assert unreachable code is not used

2020-12-13 Thread Philippe Mathieu-Daudé
This code must not be used outside of KVM. Abort if it is. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Huacai Chen Acked-by: Paolo Bonzini Message-Id: <20200429082916.10669-3-f4...@amsat.org> --- target/mips/kvm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PULL 15/26] target/mips: Remove unused headers from op_helper.c

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-6-f4...@amsat.org> --- target/mips/op_helper.c | 4 1 file changed, 4 deletions(-) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 5184a1838be..5aa97902e98 100644 -

[PULL 12/26] target/mips: Introduce cpu_supports_isa() taking CPUMIPSState argument

2020-12-13 Thread Philippe Mathieu-Daudé
Introduce cpu_supports_isa() which takes a CPUMIPSState argument, more useful at runtime when the CPU is created (no need to call the extensive object_class_by_name()). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201207215257.4004222-3-f4...@amsat.org> ---

[PULL 07/26] target/mips: Remove unused headers from cp0_helper.c

2020-12-13 Thread Philippe Mathieu-Daudé
Remove unused headers and add missing "qemu/log.h" since qemu_log() is called. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-5-f4...@amsat.org> --- target/mips/cp0_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PULL 05/26] target/mips: Replace magic values by CP0PM_MASK or TARGET_PAGE_BITS_MIN

2020-12-13 Thread Philippe Mathieu-Daudé
Replace magic values related to page size: 12 -> TARGET_PAGE_BITS_MIN 13 -> CP0PM_MASK Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Huacai Chen Message-Id: <20201109090422.2445166-2-f4...@amsat.org> --- target/mips/cp0_helper.c | 5 +++-- target/mips/h

[PULL 17/26] target/mips: Introduce ase_mt_available() helper

2020-12-13 Thread Philippe Mathieu-Daudé
Instead of accessing CP0_Config3 directly and checking the 'Multi-Threading Present' bit, introduce an helper to simplify code review. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201204222622.2743175-3-f4...@amsat.org> --- target/mips/cpu.h| 7 +++

[PULL 10/26] target/mips: Explicit Release 6 MMU types

2020-12-13 Thread Philippe Mathieu-Daudé
As of Release 6, MMU type 4 is assigned to "Dual Variable-Page-Size and Fixed-Page-Size TLBs" and type 2 to "Block Address Translation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201201132817.2863301-4-f4...@amsat.org> --- target/mips/internal.h | 9

[PULL 16/26] target/mips: Remove mips_def_t unused argument from mvp_init()

2020-12-13 Thread Philippe Mathieu-Daudé
mvp_init() doesn't require any CPU definition (beside the information accessible via CPUMIPSState). Remove the unused argument. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201204222622.2743175-2-f4...@amsat.org> --- target/mips/translate.c | 2 +-

[PULL 09/26] target/mips: Allow executing MSA instructions on Loongson-3A4000

2020-12-13 Thread Philippe Mathieu-Daudé
The Loongson-3A4000 is a GS464V-based processor with MIPS MSA ASE: https://www.mail-archive.com/qemu-devel@nongnu.org/msg763059.html Commit af868995e1b correctly set the 'MSA present' bit of Config3 register, but forgot to allow the MSA instructions decoding in insn_flags, so executing them trigge

[PULL 11/26] target/mips: Rename cpu_supports_FEAT() as cpu_type_supports_FEAT()

2020-12-13 Thread Philippe Mathieu-Daudé
As cpu_supports_isa() / cpu_supports_cps_smp() take a 'cpu_type' name argument, rename them cpu_type_supports_FEAT(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201207215257.4004222-2-f4...@amsat.org> --- target/mips/cpu.h | 4 ++-- hw/mips/boston.

[PULL 26/26] target/mips: Use FloatRoundMode enum for FCR31 modes conversion

2020-12-13 Thread Philippe Mathieu-Daudé
Use the FloatRoundMode enum type introduced in commit 3dede407cc6 ("softfloat: Name rounding mode enum") instead of 'unsigned int'. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201123204448.3260804-2-f4...@amsat.org> --- ta

[PULL 19/26] hw/mips/malta: Do not initialize MT registers if MT ASE absent

2020-12-13 Thread Philippe Mathieu-Daudé
Do not initialize MT-related config register if the MT ASE is not present. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201204222622.2743175-5-f4...@amsat.org> --- hw/mips/malta.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/mi

[PULL 21/26] target/mips: Extract cpu_supports*/cpu_set* translate.c

2020-12-13 Thread Philippe Mathieu-Daudé
Move cpu_supports*() and cpu_set_exception_base() from translate.c to cpu.c. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-9-f4...@amsat.org> --- target/mips/cpu.c | 18 ++ target/mips/translate.c | 18

[PULL 13/26] hw/mips: Move address translation helpers to target/mips/

2020-12-13 Thread Philippe Mathieu-Daudé
Address translation is an architectural thing (not hardware related). Move the helpers from hw/ to target/. As physical address and KVM are specific to system mode emulation, restrict this file to softmmu, so it doesn't get compiled for user-mode emulation. Signed-off-by: Philippe Mathieu-Daudé

[PULL 24/26] target/mips: Inline cpu_mips_realize_env() in mips_cpu_realizefn()

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-17-f4...@amsat.org> --- target/mips/cpu.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index f2c4de7d070..aa

[PULL 20/26] hw/mips/malta: Rewrite CP0_MVPConf0 access using deposit()

2020-12-13 Thread Philippe Mathieu-Daudé
PTC field has 8 bits, PVPE has 4. We plan to use the "hw/registerfields.h" API with MIPS CPU definitions (target/mips/cpu.h). Meanwhile we use magic 8 and 4. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201204222622.2743175-6-f4...@amsat.org> --- hw/mips/m

[PULL 18/26] target/mips: Do not initialize MT registers if MT ASE absent

2020-12-13 Thread Philippe Mathieu-Daudé
Do not initialize MT-related config registers if the MT ASE is not present. As some functions access the 'mvp' structure, we still zero-allocate it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201204222622.2743175-4-f4...@amsat.org> --- target/mips/transl

Re: [PATCH] target/i386/sev: add the support to query the attestation report

2020-12-13 Thread Dov Murik
On 04/12/2020 23:31, Brijesh Singh wrote: The SEV FW >= 0.23 added a new command that can be used to query the attestation report containing the SHA-256 digest of the guest memory and VMSA encrypted with the LAUNCH_UPDATE and sign it with the PEK. Note, we already have a command (LAUNCH_MEASU

[PULL 22/26] target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-10-f4...@amsat.org> --- target/mips/cpu.c| 33 + target/mips/helper.c | 33 - 2 files changed, 33 insertions(+), 33 deletio

[PULL 23/26] target/mips: Move cpu definitions, reset() and realize() to cpu.c

2020-12-13 Thread Philippe Mathieu-Daudé
Nothing TCG specific there, move to common cpu code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-16-f4...@amsat.org> --- target/mips/internal.h | 4 - target/mips/cpu.c | 243 target/m

[PULL 25/26] target/mips: Remove unused headers from fpu_helper.c

2020-12-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201206233949.3783184-4-f4...@amsat.org> --- target/mips/fpu_helper.c | 4 1 file changed, 4 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 020b768e87b..956e3417d0f 10064

[PATCH] scripts/git.orderfile: Keep files with .inc extension sorted

2020-12-13 Thread Philippe Mathieu-Daudé
Sort .inc files along with the extension including them. Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index 3736c1d6aff..b32203b7106 100644 --- a/scripts/git.orderfile +++ b/sc

[PATCH] hw/usb/host-libusb.c: fix build with kernel < 5.0

2020-12-13 Thread Fabrice Fontaine
USBDEVFS_GET_SPEED is used since version 5.2.0 and https://gitlab.com/qemu-project/qemu/-/commit/202d69a715a4b1824dcd7ec1683d027ed2bae6d3 resulting in the following build failure with kernel < 5.0: ../hw/usb/host-libusb.c: In function 'usb_host_open': ../hw/usb/host-libusb.c:953:32: error: 'USBDEV

Re: [PATCH] hw/usb/host-libusb.c: fix build with kernel < 5.0

2020-12-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201213210455.299668-1-fontaine.fabr...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201213210455.299668-1-fontaine.fabr...@gmail.com Subject: [PATCH] hw/usb/host-l

[PATCH] tests/docker: Include 'ccache' in Debian base image

2020-12-13 Thread Philippe Mathieu-Daudé
Include the 'ccache' package to speed up compilation. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/debian10.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker index 73a3caac9cd..9d4

[PATCH v2] hw/usb/host-libusb.c: fix build with kernel < 5.0

2020-12-13 Thread Fabrice Fontaine
USBDEVFS_GET_SPEED is used since version 5.2.0 and https://gitlab.com/qemu-project/qemu/-/commit/202d69a715a4b1824dcd7ec1683d027ed2bae6d3 resulting in the following build failure with kernel < 5.0: ../hw/usb/host-libusb.c: In function 'usb_host_open': ../hw/usb/host-libusb.c:953:32: error: 'USBDEV

Re: [PATCH v2] hw/usb/host-libusb.c: fix build with kernel < 5.0

2020-12-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201213213016.457350-1-fontaine.fabr...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201213213016.457350-1-fontaine.fabr...@gmail.com Subject: [PATCH v2] hw/usb/hos

  1   2   >