[PATCH 09/28] keyval: introduce keyval_parse_into

2020-12-02 Thread Paolo Bonzini
Allow parsing multiple keyval sequences into the same dictionary. Signed-off-by: Paolo Bonzini --- include/qemu/option.h | 2 ++ util/keyval.c | 39 --- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/include/qemu/option.h b/include/qe

[PATCH 01/28] qemu-option: simplify search for end of key

2020-12-02 Thread Paolo Bonzini
Use strcspn to find an equal or comma value, and pass the result directly to get_opt_name to avoid another strchr. Signed-off-by: Paolo Bonzini --- util/qemu-option.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/util/qemu-option.c b/ut

[PATCH 12/28] hmp: special case help options for object_add

2020-12-02 Thread Paolo Bonzini
Fix "object_add help" and "object_add TYPE,help". Signed-off-by: Paolo Bonzini --- include/qom/object_interfaces.h | 9 - monitor/hmp-cmds.c | 22 -- qom/object_interfaces.c | 2 +- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git

[PATCH 17/28] vl: plumb keyval-based options into -set and -readconfig

2020-12-02 Thread Paolo Bonzini
Add generic machinery to support parsing command line options with keyval in -set and -readconfig, choosing between QDict and QemuOpts as the underlying data structure. The keyval_merge function is slightly heavyweight as a way to do qemu_set_option for QDict-based options, but it will be put to f

[PATCH 05/28] qemu-option: warn for short-form boolean options

2020-12-02 Thread Paolo Bonzini
Options such as "server" or "nowait", that are commonly found in -chardev, are sugar for "server=on" and "wait=off". This is quite surprising and also does not have any notion of typing attached. It is even possible to do "-device e1000,noid" and get a device with "id=off". Deprecate it and prin

[PATCH 16/28] qemu-config: parse configuration files to a QDict

2020-12-02 Thread Paolo Bonzini
Change the parser to put the values into a QDict and pass them to a callback. qemu_config_parse's QemuOpts creation is itself turned into a callback function. Signed-off-by: Paolo Bonzini --- include/qemu/config-file.h | 6 ++- softmmu/vl.c | 4 +- util/qemu-config.c | 9

[PATCH 11/28] qom: use qemu_printf to print help for user-creatable objects

2020-12-02 Thread Paolo Bonzini
This is needed when we add help support for object_add. Signed-off-by: Paolo Bonzini --- qom/object_interfaces.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c index ed896fe764..34edc3d1d8 100644 --- a/qom/objec

[PATCH 14/28] qemu-config: add error propagation to qemu_config_parse

2020-12-02 Thread Paolo Bonzini
This enables some simplification of vl.c via error_fatal. Signed-off-by: Paolo Bonzini --- block/blkdebug.c | 3 +-- include/qemu/config-file.h | 4 ++-- softmmu/vl.c | 30 -- util/qemu-config.c | 20 ++-- 4 files chan

Re: [PATCH] docs: set CONFDIR when running sphinx

2020-12-02 Thread Paolo Bonzini
On 01/12/20 19:37, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The default configuration path /etc/qemu can be overriden with configure options, and the generated documentation used to reflect it. Fixes regression introduced in commit f8aa24ea9a82da38370470c6bc0eaa393999edfe ("m

[PATCH 08/28] tests: convert check-qom-proplist to keyval

2020-12-02 Thread Paolo Bonzini
The command-line creation test is using QemuOpts. Switch it to keyval, since all the -object command line options will follow qemu-storage-daemon and do the same. Signed-off-by: Paolo Bonzini --- tests/check-qom-proplist.c | 58 +- 1 file changed, 38 insertio

[PATCH 24/28] qom: export more functions for use with non-UserCreatable objects

2020-12-02 Thread Paolo Bonzini
Machines and accelerators are not user-creatable but they share similar parsing machinery. Export functions that will be used with -machine and -accel in softmmu/vl.c. Signed-off-by: Paolo Bonzini --- include/qom/object.h| 21 + qom/object_interfaces.c | 51 +

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 01/12/20 23:08, Eduardo Habkost wrote: Properties are only a useful concept if they have a use. If -object/object_add/object-add can do the same job without properties, properties are not needed anymore. Do you mean "not needed for -object anymore"? Properties are still used by internal C

[PATCH 27/28] qemu-option: remove now-dead code

2020-12-02 Thread Paolo Bonzini
-M was the sole user of qemu_opts_set and qemu_opts_set_defaults, remove them and the arguments that they used. Signed-off-by: Paolo Bonzini --- include/qemu/option.h | 3 --- tests/test-qemu-opts.c | 35 - util/qemu-option.c | 51 +--

[PATCH 21/28] qemu-img: use keyval for -object parsing

2020-12-02 Thread Paolo Bonzini
Enable creation of object with non-scalar properties. Signed-off-by: Paolo Bonzini --- qemu-img.c | 258 +++-- 1 file changed, 52 insertions(+), 206 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 8bdea40b58..a91bbba4c6 100644 --- a/qemu-i

[PATCH 22/28] qemu: use keyval for -object parsing

2020-12-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/qom/object_interfaces.h | 65 +--- qom/object_interfaces.c | 75 - softmmu/vl.c| 75 + 3 files changed, 48 insertions(+), 167 deletions(-)

Re: [PATCH] docs/devel/writing-qmp-commands.txt: Fix docs

2020-12-02 Thread Markus Armbruster
Zihao Chang writes: > Fix the example of add qmp hello-world example. > Without ":", make will report error: > ../qapi/misc.json:573:2: line should end with ':' > > Signed-off-by: Zihao Chang > --- > docs/devel/writing-qmp-commands.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH 10/28] hmp: replace "O" parser with keyval

2020-12-02 Thread Paolo Bonzini
HMP is using QemuOpts to parse free-form commands device_add, netdev_add and object_add. However, none of these need QemuOpts for validation (these three QemuOptsLists are all of the catch-all kind), and keyval is already able to parse into QDict. So use keyval directly, avoiding the detour from

[PATCH 26/28] vl: switch -M parsing to keyval

2020-12-02 Thread Paolo Bonzini
Switch from QemuOpts to keyval. This enables non-scalar machine properties. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 296 +++ 1 file changed, 132 insertions(+), 164 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index a942ce2004..5a

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > If we have a paused guest, it can't unplug the network VF device, so > we wait there forever. Just change the code to give one error on that > case. > > Signed-off-by: Juan Quintela It's certainly possible but it's management that

[PATCH 23/28] storage-daemon: do not register the "object" group with QemuOpts

2020-12-02 Thread Paolo Bonzini
Since qsd uses keyval instead of -object, do not bother registering qemu_object_opts. It used to be necessary for object-del; that requirement is not there anymore since emulators have switched to keyval. Signed-off-by: Paolo Bonzini --- storage-daemon/qemu-storage-daemon.c | 10 -- 1 f

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote: > Cool. I'll run a few more comprehensive tests then send out the > trivial patch to enable the kernel option + v2 of the qemu support. IIUC there will be another version of this patch, right? -- MST

[PATCH 25/28] vl: rename local variable in configure_accelerators

2020-12-02 Thread Paolo Bonzini
Silly patch extracted from the next one, which is already big enough. Because there are already local variables named "accel", we will name the global vl.c variable for "-M accel" accelerators instead. Rename it already in configure_accelerators to be ready. Signed-off-by: Paolo Bonzini --- so

Re: [PATCH v2 32/32] scripts: kernel-doc: remove unnecesssary change wrt Linux

2020-12-02 Thread Paolo Bonzini
On 02/12/20 10:03, Philippe Mathieu-Daudé wrote: On 12/1/20 11:35 AM, Paolo Bonzini wrote: A comment in kernel-doc mentions QEMU's qatomic_set macro, but since this code originated in Linux we should just revert it and stay as close to the kernel's copy of the script as possible. The change was

Re: [PATCH v2 00/27] Virtio net failover fixes

2020-12-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote: >> Hi >> >> This is a big rework of the network failover setup. General idea is: >> * We don't cache the name of the primary/standby devices >> We have several problems there with stale pointers >> * A

[PATCH 18/28] qom: do not modify QDict argument in user_creatable_add_dict

2020-12-02 Thread Paolo Bonzini
-object will process its QDicts in two steps, first for the "early" objects and then for the "late" objects. If qom-type is removed by the "early" pass, the late pass fails. So just create a shallow copy of the QDict in user_creatable_add_dict. Signed-off-by: Paolo Bonzini --- include/qom/obje

Re: [PATCH v3 4/6] linux-user/elfload: Introduce MIPS GET_FEATURE_REG_EQU() macro

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 12:15 AM, Richard Henderson wrote: > On 12/1/20 1:28 PM, Philippe Mathieu-Daudé wrote: >> ISA features are usually denoted in read-only bits from >> CPU registers. Add the GET_FEATURE_REG_EQU() macro which >> checks if a CPU register has bits set to a specific value. >> >> Use the macro

[PATCH 20/28] qemu-nbd: use keyval for -object parsing

2020-12-02 Thread Paolo Bonzini
Enable creation of object with non-scalar properties. Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a7075c5419..b4bd21a21e 100644 --- a/qemu-nbd.c +++ b/qe

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 01.12.2020 um 22:23 hat Paolo Bonzini geschrieben: > On 01/12/20 20:35, Kevin Wolf wrote: > > Am 01.12.2020 um 18:16 hat Paolo Bonzini geschrieben: > > I don't think this is actually a new things. We already have types and > > commands declared with things like 'if': 'defined(TARGET_S390X)'. > >

[PATCH 15/28] qemu-option: support accept-any QemuOptsList in qemu_opts_absorb_qdict

2020-12-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- util/qemu-option.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index 40564a12eb..afba08d92e 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -1052,7 +1052,8 @@ bool qemu_opts_absorb_qdict

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 10:30 hat Paolo Bonzini geschrieben: > On 01/12/20 23:08, Eduardo Habkost wrote: > > > Properties are only a useful concept if they have a use. If > > > -object/object_add/object-add can do the same job without properties, > > > properties are not needed anymore. > > > > Do you m

check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Claudio Fontana
Hi Alex and all, when trying to use check-tcg (master), I am getting often these errors: $ ../configure --disable-system --disable-tools $ make -j12 check-tcg ERRO[] cannot find mappings for user claudio: No subgid ranges found for group "claudio" in /etc/subgid ERRO[] cannot find map

Re: [PATCH V17 4/6] hw/mips: Add Loongson-3 boot parameter helpers

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 2:14 AM, Huacai Chen wrote: > Hi, Phillippe, > > On Tue, Nov 24, 2020 at 6:25 AM Philippe Mathieu-Daudé > wrote: >> >> On 11/6/20 5:21 AM, Huacai Chen wrote: >>> Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a >>> UEFI-like interface for BIOS-Kernel boot paramete

Re: [PATCH v3 6/6] linux-user: Add support for MIPS Loongson 2F/3E

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 2:01 AM, chen huacai wrote: > Hi, Philippe, > > On Wed, Dec 2, 2020 at 3:31 AM Philippe Mathieu-Daudé wrote: >> >> Userland ELF binaries using Longsoon SIMD instructions have the >> HWCAP_LOONGSON_MMI bit set [1]. >> Binaries compiled for Longsoon 3E [2] have the HWCAP_LOONGSON_EXT >>

Re: [PATCH] virtio: reset device on bad guest index in virtio_load()

2020-12-02 Thread Michael S. Tsirkin
On Fri, Nov 20, 2020 at 06:51:07PM +, John Levon wrote: > > If we find a queue with an inconsistent guest index value, explicitly mark the > device as needing a reset - and broken - via virtio_error(). > > There's at least one driver implementation - the virtio-win NetKVM driver - > that > i

Re: [PATCH] scripts/checkpatch.pl: Modify the line length limit of the code

2020-12-02 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 9 Nov 2020 at 09:01, Markus Armbruster wrote: >> CODING_STYLE.rst: "Lines should be 80 characters; try not to make them >> longer." I'd like to keep the tooling we have to help us with trying >> not to make them longer. >> >> If we have lost the ability to differ

Re: [PATCH 0/4] Use lock guard macros in block

2020-12-02 Thread Markus Armbruster
Did this fall through the cracks? Gan Qixin writes: > Hi all, > I saw some tasks to replace manual lock()/unlock() calls with lock guard > macros in BiteSizedTasks. > I am very interested in this and modified some of the files under block. > Could someone help me check the code? > > Thanks,

Re: [PATCH v6] hw/i386/pc: add max combined fw size as machine configuration option

2020-12-02 Thread Michael S. Tsirkin
Could you help by rebasing this on master? Shouldn't be hard ... Thanks!

Re: [PATCH 0/4] Use lock guard macros in block

2020-12-02 Thread Paolo Bonzini
On 02/12/20 10:22, Markus Armbruster wrote: Did this fall through the cracks? Gan Qixin writes: Hi all, I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks. I am very interested in this and modified some of the files under block. Could someon

Re: [PATCH 1/1] qemu vhost scsi: add VHOST_SET_VRING_ENABLE support

2020-12-02 Thread Michael S. Tsirkin
On Thu, Nov 12, 2020 at 05:19:00PM -0600, Mike Christie wrote: > diff --git a/linux-headers/linux/vhost.h b/linux-headers/linux/vhost.h > index 7523218..98dd919 100644 > --- a/linux-headers/linux/vhost.h > +++ b/linux-headers/linux/vhost.h > @@ -70,6 +70,7 @@ > #define VHOST_VRING_BIG_ENDIAN 1 >

RE: [PATCH 2/2] i386/cpu: Make the Intel PT LIP feature configurable

2020-12-02 Thread Kang, Luwei
> > The current implementation will disable the guest Intel PT feature if > > the Intel PT LIP feature is supported on the host, but the LIP feature > > is comming soon(e.g. SnowRidge and later). > > > > This patch will make the guest LIP feature configurable and Intel PT > > feature can be enabled

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

2020-12-02 Thread Dr. David Alan Gilbert
* Shenming Lu (lushenm...@huawei.com) wrote: > Hi, > > After reading everyone's opinions, we have a rough idea for this issue. > > One key point is whether it is necessary to setup the config space before > the device can accept further migration data. I think it is decided by > the vendor driver

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > If we have a paused guest, it can't unplug the network VF device, so > > we wait there forever. Just change the code to give one error on that > > case. > > > >

Re: [PATCH v2 00/27] Virtio net failover fixes

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 11:16:04AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote: > >> Hi > >> > >> This is a big rework of the network failover setup. General idea is: > >> * We don't cache the name of the primary/sta

Re: [PATCH v10 0/9] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-12-02 Thread Michael S. Tsirkin
On Thu, Nov 19, 2020 at 09:48:32AM +0800, Jiahui Cen wrote: > Changes with v9 > v9->v10: > Refactor patch2 to drop useless macros and variables. > Split patch2 into two patches. I tagged this for after the release. To help make sure this is not lost pls ping me after the release. Thanks! > Chang

[PULL 0/6] pc,vhost: fixes

2020-12-02 Thread Michael S. Tsirkin
Patch 5 gave me pause but we do need patch 6 as it's a guest triggerable assert, and it seemed cleaner to just take the whole patchset than cherry-pick. The following changes since commit d73c46e4a84e47ffc61b8bf7c378b1383e7316b5: Update version for v5.2.0-rc4 release (2020-12-01 16:21:01 +)

Re: [PATCH v2 00/27] Virtio net failover fixes

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote: > Hi I tagged this for after the release. To help make sure this is not lost pls ping me after the release. Thanks! > This is a big rework of the network failover setup. General idea is: > * We don't cache the name of the primary/st

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > > If we have

[PULL 4/6] memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez This allows us to differentiate between regular IOMMU map/unmap events and DEVIOTLB unmap. Doing so, notifiers that only need device IOTLB invalidations will not receive regular IOMMU unmappings. Adapt intel and vhost to use it. Signed-off-by: Eugenio Pérez Reviewed-by: Pet

[PATCH v2] i386/cpu: Make the Intel PT LIP feature configurable

2020-12-02 Thread Luwei Kang
The current implementation will disable the guest Intel PT feature if the Intel PT LIP feature is supported on the host, but the LIP feature is comming soon(e.g. SnowRidge and later). This patch will make the guest LIP feature configurable and Intel PT feature can be enabled in guest when the gues

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 05:31:50AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > > If we have

Re: [PATCH 4/4] block/iscsi.c: Use lock guard macros

2020-12-02 Thread Kevin Wolf
Am 09.11.2020 um 16:43 hat Gan Qixin geschrieben: > Replace manual lock()/unlock() calls with lock guard macros > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi.c. > > Signed-off-by: Gan Qixin > --- > block/iscsi.c | 28 +--- > 1 file changed, 13 insertions(+), 15

[PULL 1/6] vhost-user-scsi: Fix memleaks in vus_proc_req()

2020-12-02 Thread Michael S. Tsirkin
From: Alex Chen The 'elem' is allocated memory in vu_queue_pop(), and its memory should be freed in all error branches after vu_queue_pop(). In addition, in order to free the 'elem' memory outside of while(1) loop, move the definition of 'elem' to the beginning of vus_proc_req(). Reported-by: Eu

[PULL 2/6] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez Previous name didn't reflect the iommu operation. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: David Gibson Reviewed-by: Juan Quintela Reviewed-by: Eric Auger Acked-by: Jason Wang Message-Id: <20201116165506.31315-2-epere...@redhat.com> Reviewed-by: M

[PULL 6/6] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of the memory region or even [0, ~0ULL] for all the space. The assertion could be hit by a guest, and rhel7 guest effectively hit it. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: Juan Qu

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > > >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P.

[PULL 5/6] intel_iommu: Skip page walking on device iotlb invalidations

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez Although they didn't reach the notifier because of the filtering in memory_region_notify_iommu_one, the vt-d was still splitting huge memory invalidations in chunks. Skipping it. This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1923.6Mbit/s to 2

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > If we have a paused guest, it can't unplug the network VF device, so > > > we wait ther

Re: [PATCH 3/4] block/throttle-groups.c: Use lock guard macros

2020-12-02 Thread Kevin Wolf
Am 09.11.2020 um 16:43 hat Gan Qixin geschrieben: > Replace manual lock()/unlock() calls with lock guard macros > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/throttle-groups.c. > > Signed-off-by: Gan Qixin > @@ -638,14 +636,14 @@ void > throttle_group_detach_aio_context(ThrottleGroupMember

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-12-02 Thread Stefano Garzarella
On Tue, Dec 01, 2020 at 05:43:38PM +, Stefan Hajnoczi wrote: On Tue, Dec 01, 2020 at 02:45:18PM +0100, Stefano Garzarella wrote: On Tue, Dec 01, 2020 at 12:59:43PM +, Stefan Hajnoczi wrote: > On Fri, Nov 20, 2020 at 07:31:08AM -0500, Michael S. Tsirkin wrote: > > On Fri, Nov 20, 2020 at

Re: [PATCH] accel/tcg: Remove deprecated '-tb-size' option

2020-12-02 Thread Thomas Huth
On 02/12/2020 12.27, Philippe Mathieu-Daudé wrote: > The '-tb-size' option (replaced by '-accel tcg,tb-size') is > deprecated since 5.0 (commit fe174132478). Remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/deprecated.rst | 12 +--- > accel/tcg/translate-all.c |

[PATCH] accel/tcg: Remove deprecated '-tb-size' option

2020-12-02 Thread Philippe Mathieu-Daudé
The '-tb-size' option (replaced by '-accel tcg,tb-size') is deprecated since 5.0 (commit fe174132478). Remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 12 +--- accel/tcg/translate-all.c | 2 +- softmmu/vl.c | 8 qemu-options.hx

Re: [PATCH 12/15] plugin: propagate errors

2020-12-02 Thread Alex Bennée
Paolo Bonzini writes: > qemu_finish_machine_init currently can only exit QEMU if it fails. > Prepare for giving it proper error propagation, and possibly for > adding a plugin_add monitor command that calls an accelerator > method. > > While at it, make all errors from plugin_load look the same

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Jonathan Cameron
On Wed, 2 Dec 2020 05:02:57 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote: > > Cool. I'll run a few more comprehensive tests then send out the > > trivial patch to enable the kernel option + v2 of the qemu support. > > IIUC there will be

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > > "Michael S.

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: >> > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan

[PULL 3/6] memory: Add IOMMUTLBEvent

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez This way we can tell between regular IOMMUTLBEntry (entry of IOMMU hardware) and notifications. In the notifications, we set explicitly if it is a MAPs or an UNMAP, instead of trusting in entry permissions to differentiate them. Signed-off-by: Eugenio Pérez Reviewed-by: Pet

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Alex Bennée
Claudio Fontana writes: > Hi Alex and all, > > when trying to use check-tcg (master), I am getting often these errors: > > $ ../configure --disable-system --disable-tools > > $ make -j12 check-tcg > > ERRO[] cannot find mappings for user claudio: No subgid ranges found for > group "claudio

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Claudio Fontana
On 12/2/20 12:16 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hi Alex and all, >> >> when trying to use check-tcg (master), I am getting often these errors: >> >> $ ../configure --disable-system --disable-tools >> >> $ make -j12 check-tcg >> >> ERRO[] cannot find mappings for user

[Call for Presentations] FOSDEM 2021: Virt & IaaS Devroom

2020-12-02 Thread Kashyap Chamarthy
[Cross-posting to KVM, QEMU, and libvirt lists] The Call For Papers for FOSDEM's Virt & IaaS Devroom went out yesterday[1]. Here's the text (slightly formatted for readability): === We are excited to announce that the call for p

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > "Michael S. Tsirkin" wrote: > > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S

Re: [PULL 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

2020-12-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201202080849.4125477-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202080849.4125477-1-pbonz...@redhat.com Subject: [PULL 000/113] First batch of mis

Re: [PATCH 03/23] tests/docker: use project specific container registries

2020-12-02 Thread Gerd Hoffmann
> --- a/tests/docker/dockerfiles/centos8.docker > +++ b/tests/docker/dockerfiles/centos8.docker > @@ -1,4 +1,4 @@ > -FROM centos:8.1.1911 > +FROM registry.centos.org/centos:8 At least for centos-8 I've noticed the docker.io containters are multiarch whereas registry.centos.org has x86_64 only. I

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > > > On Wed,

Re: [PATCH] accel/tcg: Remove deprecated '-tb-size' option

2020-12-02 Thread Ján Tomko
On a Wednesday in 2020, Philippe Mathieu-Daudé wrote: The '-tb-size' option (replaced by '-accel tcg,tb-size') is deprecated since 5.0 (commit fe174132478). Remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 12 +--- accel/tcg/translate-all.c | 2 +- softm

Re: [PATCH 03/23] tests/docker: use project specific container registries

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 12:54:14PM +0100, Gerd Hoffmann wrote: > > --- a/tests/docker/dockerfiles/centos8.docker > > +++ b/tests/docker/dockerfiles/centos8.docker > > @@ -1,4 +1,4 @@ > > -FROM centos:8.1.1911 > > +FROM registry.centos.org/centos:8 > > At least for centos-8 I've noticed the docker.

Re: [PATCH 18/23] tests/docker: auto-generate centos7 with lcitool

2020-12-02 Thread Gerd Hoffmann
Hi, > +RUN echo 'skip_missing_names_on_install=0' >> /etc/yum.conf && \ > +yum install -y epel-release && \ > +yum install -y centos-release-xen-48 && \ > +yum update -y && \ > +yum install -y \ > +SDL2-devel \ More a comment for lcitool I guess: rpmbuild generates prov

Re: [PATCH 05/23] tests/docker: remove travis container

2020-12-02 Thread Thomas Huth
On 01/12/2020 18.18, Daniel P. Berrangé wrote: > The travis container that we have no longer matches what travis > currently uses. As all x86 jobs are being moved to GitLab CI too, > there is no compelling reason to update the travis container. It > is simpler to just remove it. > > Signed-off-by:

Re: [PATCH v11 2/7] block/nbd.c: Add yank feature

2020-12-02 Thread Vladimir Sementsov-Ogievskiy
15.11.2020 14:36, Lukas Straub wrote: Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Hi! Could I ask, what's the reason for qatomic_load_acquire a

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Konrad, all +-- On Tue, 1 Dec 2020, Konrad Rzeszutek Wilk wrote --+ | On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: | > We are about to introduce a qemu-security mailing list to report | > and triage QEMU security issues. | > Update the QEMU security process web page with new mail

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 11:38, Kevin Wolf wrote: Am 02.12.2020 um 10:30 hat Paolo Bonzini geschrieben: On 01/12/20 23:08, Eduardo Habkost wrote: Properties are only a useful concept if they have a use. If -object/object_add/object-add can do the same job without properties, properties are not needed anymo

virtiofsd-rs: A rust virtiofs daemon

2020-12-02 Thread Dr. David Alan Gilbert
Hi, Sergio has been working on virtiofsd-rs, a virtiofs daemon written in rust, and which can be found at: https://gitlab.com/virtio-fs/virtiofsd-rs It started life originally as part of the crosvm project, got ported to vhost-user as part of the Cloud Hypervisor project, and has now been spl

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Daniel P . Berrangé
On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the QEMU security process web page with new mailing list > and triage details. > > Signed-off-by: Pra

Re: [PATCH v11 2/7] block/nbd.c: Add yank feature

2020-12-02 Thread Lukas Straub
On Wed, 2 Dec 2020 15:18:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > 15.11.2020 14:36, Lukas Straub wrote: > > Register a yank function which shuts down the socket and sets > > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > > error occured. > > > > Signed-off-by: Lukas Stra

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 11:27, Kevin Wolf wrote: Declaring read-only QOM properties is trivial. Trivial sounds like it's something the computer should be doing. Possibly, but not necessarily. There's always a cost to automatic code generation. If things are _too_ trivial and easy to get right, the cos

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 10:30:11AM +0100, Paolo Bonzini wrote: > On 01/12/20 23:08, Eduardo Habkost wrote: > > > Properties are only a useful concept if they have a use. If > > > -object/object_add/object-add can do the same job without properties, > > > properties are not needed anymore. > > > >

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Alex Bennée
Claudio Fontana writes: > On 12/2/20 12:16 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> Hi Alex and all, >>> >>> when trying to use check-tcg (master), I am getting often these errors: >>> >>> $ ../configure --disable-system --disable-tools >>> >>> $ make -j12 check-tcg >>> >>

Re: [PATCH 06/15] arc: TCG instruction definitions

2020-12-02 Thread Cupertino Miranda
Hi Richard, Thank you so much for your reviews. I will start working on improving the code straight away to try to minimize waiting times. However lets just address the elephant in the room. Indeed we have the TCG definitions being generated. However we are very serious about wanting to upstream

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 20/11/20 16:34, Igor Mammedov wrote: > > > qapi_event_send_migration(MIGRATION_STATUS_SETUP); > > > -if (!strcmp(uri, "defer")) { > > > -deferred_incoming_migration(errp); > > > -} else if (strstart(uri, "tcp:", &p) || > > > -

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 01:10:37PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 20/11/20 16:34, Igor Mammedov wrote: > > > > qapi_event_send_migration(MIGRATION_STATUS_SETUP); > > > > -if (!strcmp(uri, "defer")) { > > > > -deferred_inc

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread P J P
Hi, [doing a combined reply] +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Is it possible to release the reproducer to the community, so we can work on | a fix and test it? * No, we can not release/share reproducers on a public list. * We can request reporters to do so by thei

[PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

2020-12-02 Thread Philippe Mathieu-Daudé
While this change helps triskaidekaphobic developers, it is a good practice to avoid magic values and using constant definitions instead. Introduce the PAM_REGIONS_COUNT and use it. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/i440fx.h | 2 +- include/hw/pci-

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 13:51, Eduardo Habkost wrote: I'm liking the direction this is taking. However, I would still like to have a clearer and feasible plan that would work for -device, -machine, and -cpu. -cpu is not a problem since it's generally created with a static configuration (now done with glob

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:15, Daniel P. Berrangé wrote: Can someone remind me why we need to have an -incoming arg at all ? With snapshots, we can just start QEMU normally, using -S if desired, and then invoke "loadvm" to restore from a snapshot at any time. What is different thet means we can't just run

Re: [PATCH] linux-user/elfload: Fix handling of pure BSS segments

2020-12-02 Thread Alex Bennée
Stephen Long writes: > Alex Bennee writes: > >>> Apologies for the unclear commit msg. I was also seeing a SIGSEGV in >>> zero_bss() with the binaries I was generating. I was using LLD to generate >>> the binaries. The binaries all had LOAD segments with a file size of >>> 0. >> >> How hairy i

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:17, P J P wrote: Hi, [doing a combined reply] +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Is it possible to release the reproducer to the community, so we can work on | a fix and test it? * No, we can not release/share reproducers on a public list. We do n

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:10, Dr. David Alan Gilbert wrote: I'm more worried about how this stops a repeated 'migrate incoming' or a 'migrate_incoming' that's issued following a qemu that's been started with -incoming tcp:... but which a socket hasn't yet connected to. Good question, fortunately it is sim

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 2:17 PM, P J P wrote: > +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ > | Is it possible to release the reproducer to the community, so we can work > on > | a fix and test it? > > * No, we can not release/share reproducers on a public list. > > * We can request reporte

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Philippe Mathieu-Daudé
Hi Prasad, On 11/30/20 2:49 PM, P J P wrote: > From: Prasad J Pandit > ... > +## How we respond: > + > +* Process of handling security issues can be divided in two halves. > + Maybe: 0) **Acknowledge reception** - A non-automated response email is sent to acknowledge the r

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 02:26:44PM +0100, Paolo Bonzini wrote: > On 02/12/20 13:51, Eduardo Habkost wrote: > > > > I'm liking the direction this is taking. However, I would still > > > > like to have a clearer and feasible plan that would work for > > > > -device, -machine, and -cpu. > > > > > >

<    1   2   3   4   5   >