Patchew URL: https://patchew.org/QEMU/20201202080849.4125477-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202080849.4125477-1-pbonz...@redhat.com Subject: [PULL 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201202080849.4125477-1-pbonz...@redhat.com -> patchew/20201202080849.4125477-1-pbonz...@redhat.com * [new tag] patchew/20201202101042.11967-1-luwei.k...@intel.com -> patchew/20201202101042.11967-1-luwei.k...@intel.com Switched to a new branch 'test' a4add9d scripts: kernel-doc: remove unnecesssary change wrt Linux a12200d Revert "docs: temporarily disable the kernel-doc extension" f913504 scripts: kernel-doc: use :c:union when needed 0948494 scripts: kernel-doc: split typedef complex regex 69e58d5 scripts: kernel-doc: fix typedef parsing 729a65a Revert "kernel-doc: Handle function typedefs that return pointers" d74922c Revert "kernel-doc: Handle function typedefs without asterisks" 2cfa827 scripts: kernel-doc: try to use c:function if possible 49b1924 scripts: kernel-doc: fix line number handling 599bd60 scripts: kernel-doc: allow passing desired Sphinx C domain dialect ccd0a99 scripts: kernel-doc: don't mangle with parameter list c8041c1 scripts: kernel-doc: fix typedef identification 6619dbb scripts: kernel-doc: reimplement -nofunction argument 871d904 scripts: kernel-doc: fix troubles with line counts 2c31789 scripts: kernel-doc: use a less pedantic markup for funcs on Sphinx 3.x 47720be scripts: kernel-doc: make it more compatible with Sphinx 3.x 34e04d1 Revert "kernel-doc: Use c:struct for Sphinx 3.0 and later" f8d8ba0 Revert "scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments" c8cf35b scripts: kernel-doc: add support for typedef enum ef6d10d kernel-doc: add support for ____cacheline_aligned attribute 5a89198 kernel-doc: include line numbers for function prototypes 98f7e32 scripts/kernel-doc: optionally treat warnings as errors c164b21 scripts/kernel-doc: handle function pointer prototypes 8176521 scripts/kernel-doc: parse __ETHTOOL_DECLARE_LINK_MODE_MASK 8bb93e4 Replace HTTP links with HTTPS ones: documentation 16067ba scripts: kernel-doc: accept blank lines on parameter description 1069fce scripts: kernel-doc: accept negation like !@var 901c775 scripts: kernel-doc: proper handle @foo->bar() ae759fa scripts/kernel-doc: Add support for named variable macro arguments ca93033 kernel-doc: add support for ____cacheline_aligned_in_smp attribute 3222311 kernel-doc: fix processing nested structs with attributes 172c67f docs: temporarily disable the kernel-doc extension 34ec2d3 config-file: move -set implementation to vl.c b3b2b33 vl: clean up -boot variables 0df7ae4 vl: remove serial_max_hds b2d4a21 vl: extract softmmu/rtc.c 56b895b vl: extract machine done notifiers 9077c47 vl: extract softmmu/datadir.c cd666a4 hmp: introduce cmd_available ca5aed00 vl: start VM via qmp_cont 64d36f6 migration, vl: start migration via qmp_migrate_incoming c4ff80b vl: move -global check earlier 2c5bb35 vl: initialize displays before preconfig loop add091a vl: separate qemu_resolve_machine_memdev f77baee vl: separate qemu_apply_machine_options ba665b8 vl: separate qemu_create_machine efd7675 vl: separate qemu_create_late_backends 6558486 vl: separate qemu_create_early_backends 25838a4 vl: move CHECKPOINT_INIT after preconfig ac306e3 vl: extract default devices to separate functions 847be0b vl: load plugins as late as possible edaf366 vl: create "-net nic -net user" default earlier aab2f9e qemu-option: restrict qemu_opts_set to merge-lists QemuOpts 87e13df vl: extract various command line desugaring snippets to a new function 4e2dfcb vl: preconfig and loadvm are mutually exclusive 6a2d4ef vl: extract various command line validation snippets to a new function 3c7c482 vl: move prelaunch part of qemu_init to new functions 6ac7d06 vl: extract qemu_init_subsystems 60ee017 vl: move various initialization routines out of qemu_init 020c4c9 vl: split various early command line options to a separate function ab08620 vl: remove bogus check e8e842d vl: extract validation of -smp to machine.c 833cfa8 treewide: do not use short-form boolean options 98cfa88 hw/char/serial: Clean up unnecessary code 510df76 make ram_size local to vl.c d84de6d sparc64: do not use ram_size global 00ebf53 s390x: do not use ram_size global 9ff7cc4 riscv: do not use ram_size global 98cf13e ppc: do not use ram_size global ed74abd nios2: do not use ram_size global d00dcd5 moxie: do not use ram_size global 38b793d mips: do not use ram_size global e1a50d6 microblaze: do not use ram_size global 7c127cb m68k: do not use ram_size global fd63dcc i386: do not use ram_size global 428de9d hppa: do not use ram_size global 05299f4 cris: do not use ram_size global 9406a17 arm: do not use ram_size global e634ff6 vl: remove bios_name 20b1187 digic: remove bios_name d372a5a sparc: remove bios_name 154bddd sh4: remove bios_name 9071caa s390: remove bios_name 035077d rx: move BIOS load from MCU to board 5c273df ppc: remove bios_name f7b4de3 moxie: remove bios_name cf9d5b4 mips: remove bios_name 108b2e3 m68k: remove bios_name 1eead6f lm32: remove bios_name a49771b i386: remove bios_name 5a5970f hppa: remove bios_name 3187659 arm: remove bios_name 83b63e4 alpha: remove bios_name da8b722 hw/net/xilinx_axienet: Rename StreamSlave as StreamSink d7ae99f hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink 957ea65 hw/core/stream: Rename StreamSlave as StreamSink 6803e24 hw/ssi: Rename SSI 'slave' as 'peripheral' 7a384ce hw/ssi: Update coding style to make checkpatch.pl happy 5ad8038 hw/ssi/aspeed_smc: Rename 'max_slaves' variable as 'max_peripherals' b6bab69 pci: Let pci_dma_write() propagate MemTxResult 01f0c0d pci: Let pci_dma_read() propagate MemTxResult a075ff9 pci: Let pci_dma_rw() propagate MemTxResult 855c99f dma: Let dma_memory_write() propagate MemTxResult 9b3cf7d dma: Let dma_memory_read() propagate MemTxResult 08ca748 dma: Let dma_memory_rw() propagate MemTxResult 9c9a425 dma: Let dma_memory_set() propagate MemTxResult 9397a5c dma: Document address_space_map/address_space_unmap() prototypes fd20310 qom: eliminate identical functions de31305 docs/devel/loads-stores: Add regexp for DMA functions 3b52ff3 WHPX: support for the kernel-irqchip on/off 029acf2 target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper 4381f45 target/i386: Support up to 32768 CPUs without IRQ remapping 488278c target/i386: fix operand order for PDEP and PEXT === OUTPUT BEGIN === 1/113 Checking commit 488278c248b4 (target/i386: fix operand order for PDEP and PEXT) WARNING: Block comments use a leading /* on a separate line #29: FILE: target/i386/translate.c:3939: + /* Note that by zero-extending the source operand, we WARNING: Block comments use a leading /* on a separate line #46: FILE: target/i386/translate.c:3957: + /* Note that by zero-extending the source operand, we WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #73: new file mode 100644 ERROR: open brace '{' following function declarations go on the next line #82: FILE: tests/tcg/i386/test-i386-bmi2.c:5: +int main(int argc, char *argv[]) { WARNING: line over 80 characters #92: FILE: tests/tcg/i386/test-i386-bmi2.c:15: + asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(result64), "m"(mask)); WARNING: line over 80 characters #95: FILE: tests/tcg/i386/test-i386-bmi2.c:18: + asm volatile ("pextq %2, %1, %0" : "=r"(result64) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #98: FILE: tests/tcg/i386/test-i386-bmi2.c:21: + asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #102: FILE: tests/tcg/i386/test-i386-bmi2.c:25: + asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(ehlo), "m"(mask)); WARNING: line over 80 characters #105: FILE: tests/tcg/i386/test-i386-bmi2.c:28: + asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(result32), "m"(mask)); WARNING: line over 80 characters #108: FILE: tests/tcg/i386/test-i386-bmi2.c:31: + asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #111: FILE: tests/tcg/i386/test-i386-bmi2.c:34: + asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull), "m"(mask)); total: 1 errors, 10 warnings, 80 lines checked Patch 1/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/113 Checking commit 4381f45552ba (target/i386: Support up to 32768 CPUs without IRQ remapping) ERROR: line over 90 characters #97: FILE: target/i386/cpu.c:802: + "kvm-poll-control", "kvm-pv-sched-yield", "kvm-asyncpf-int", "kvm-msi-ext-dest-id", WARNING: Block comments use a trailing */ on a separate line #191: FILE: target/i386/kvm.c:4647: + * extended destination ID in the low bits 11-5. */ total: 1 errors, 1 warnings, 178 lines checked Patch 2/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/113 Checking commit 029acf24d550 (target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper) 4/113 Checking commit 3b52ff34f4e9 (WHPX: support for the kernel-irqchip on/off) ERROR: spaces required around that '*' (ctx:VxW) #185: FILE: target/i386/whp-dispatch.h:34: + WHV_INTERRUPT_CONTROL* Interrupt, UINT32 InterruptControlSize)) \ ^ ERROR: spaces required around that '*' (ctx:VxW) #188: FILE: target/i386/whp-dispatch.h:37: + UINT32 StateSize, UINT32* WrittenSize)) \ ^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #642: new file mode 100644 total: 2 errors, 1 warnings, 831 lines checked Patch 4/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/113 Checking commit de313059f54c (docs/devel/loads-stores: Add regexp for DMA functions) 6/113 Checking commit fd2031062b26 (qom: eliminate identical functions) 7/113 Checking commit 9397a5c0e693 (dma: Document address_space_map/address_space_unmap() prototypes) 8/113 Checking commit 9c9a425c4c0d (dma: Let dma_memory_set() propagate MemTxResult) 9/113 Checking commit 08ca748be28a (dma: Let dma_memory_rw() propagate MemTxResult) 10/113 Checking commit 9b3cf7d642e3 (dma: Let dma_memory_read() propagate MemTxResult) 11/113 Checking commit 855c99fb23b0 (dma: Let dma_memory_write() propagate MemTxResult) 12/113 Checking commit a075ff905b9e (pci: Let pci_dma_rw() propagate MemTxResult) 13/113 Checking commit 01f0c0d418c8 (pci: Let pci_dma_read() propagate MemTxResult) 14/113 Checking commit b6bab6940e8a (pci: Let pci_dma_write() propagate MemTxResult) 15/113 Checking commit 5ad8038e03dd (hw/ssi/aspeed_smc: Rename 'max_slaves' variable as 'max_peripherals') 16/113 Checking commit 7a384ce4e3e3 (hw/ssi: Update coding style to make checkpatch.pl happy) 17/113 Checking commit 6803e24640db (hw/ssi: Rename SSI 'slave' as 'peripheral') 18/113 Checking commit 957ea6540d4d (hw/core/stream: Rename StreamSlave as StreamSink) 19/113 Checking commit d7ae99f496ea (hw/dma/xilinx_axidma: Rename StreamSlave as StreamSink) 20/113 Checking commit da8b722912fb (hw/net/xilinx_axienet: Rename StreamSlave as StreamSink) WARNING: line over 80 characters #32: FILE: hw/net/xilinx_axienet.c:52: +DECLARE_INSTANCE_CHECKER(XilinxAXIEnetStreamSink, XILINX_AXI_ENET_CONTROL_STREAM, total: 0 errors, 1 warnings, 74 lines checked Patch 20/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/113 Checking commit 83b63e4f87e3 (alpha: remove bios_name) 22/113 Checking commit 3187659c541f (arm: remove bios_name) WARNING: line over 80 characters #40: FILE: hw/arm/highbank.c:301: + sysboot_filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware); total: 0 errors, 1 warnings, 105 lines checked Patch 22/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/113 Checking commit 5a5970f5ec19 (hppa: remove bios_name) WARNING: line over 80 characters #25: FILE: hw/hppa/machine.c:216: + machine->firmware ?: "hppa-firmware.img"); total: 0 errors, 1 warnings, 9 lines checked Patch 23/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/113 Checking commit a49771b33fdc (i386: remove bios_name) WARNING: line over 80 characters #36: FILE: hw/i386/microvm.c:266: + x86_bios_rom_init(MACHINE(mms), default_firmware, get_system_memory(), true); total: 0 errors, 1 warnings, 75 lines checked Patch 24/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/113 Checking commit 1eead6ffcca0 (lm32: remove bios_name) 26/113 Checking commit 108b2e3282ed (m68k: remove bios_name) 27/113 Checking commit cf9d5b46e341 (mips: remove bios_name) WARNING: line over 80 characters #47: FILE: hw/mips/jazz.c:221: + filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware ?: BIOS_FILENAME); WARNING: line over 80 characters #82: FILE: hw/mips/malta.c:1346: + error_report("Could not load MIPS bios '%s'", machine->firmware); WARNING: line over 80 characters #95: FILE: hw/mips/mipssim.c:180: + filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware ?: BIOS_FILENAME); total: 0 errors, 3 warnings, 73 lines checked Patch 27/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/113 Checking commit f7b4de3425d7 (moxie: remove bios_name) WARNING: line over 80 characters #25: FILE: hw/moxie/moxiesim.c:137: + if (load_image_targphys(machine->firmware, FIRMWARE_BASE, FIRMWARE_SIZE) < 0) { total: 0 errors, 1 warnings, 12 lines checked Patch 28/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/113 Checking commit 5c273df64a72 (ppc: remove bios_name) 30/113 Checking commit 035077dcf0b6 (rx: move BIOS load from MCU to board) 31/113 Checking commit 9071caa126df (s390: remove bios_name) 32/113 Checking commit 154bddd11ad6 (sh4: remove bios_name) 33/113 Checking commit d372a5a66ee2 (sparc: remove bios_name) 34/113 Checking commit 20b11873e969 (digic: remove bios_name) 35/113 Checking commit e634ff6dba77 (vl: remove bios_name) 36/113 Checking commit 9406a17e13c4 (arm: do not use ram_size global) WARNING: line over 80 characters #33: FILE: hw/arm/aspeed.c:336: + memory_region_add_subregion(&bmc->ram_container, machine->ram_size, &bmc->max_ram); WARNING: line over 80 characters #63: FILE: hw/display/pxa2xx_lcd.c:309: + sizeof(desc) <= PXA2XX_SDRAM_BASE + current_machine->ram_size) || total: 0 errors, 2 warnings, 64 lines checked Patch 36/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 37/113 Checking commit 05299f4f808a (cris: do not use ram_size global) 38/113 Checking commit 428de9d7ab5e (hppa: do not use ram_size global) 39/113 Checking commit fd63dcc7879f (i386: do not use ram_size global) ERROR: line over 90 characters #105: FILE: hw/smbios/smbios.c:914: + : ((current_machine->ram_size - 1) % MAX_DIMM_SZ) + 1) WARNING: line over 80 characters #108: FILE: hw/smbios/smbios.c:916: + dimm_cnt = QEMU_ALIGN_UP(current_machine->ram_size, MAX_DIMM_SZ) / MAX_DIMM_SZ; total: 1 errors, 1 warnings, 72 lines checked Patch 39/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/113 Checking commit 7c127cb8d1c6 (m68k: do not use ram_size global) 41/113 Checking commit e1a50d6ea755 (microblaze: do not use ram_size global) 42/113 Checking commit 38b793d3f022 (mips: do not use ram_size global) WARNING: line over 80 characters #30: FILE: hw/mips/fuloong2e.c:144: + loaderparams.ram_size - initrd_offset); WARNING: line over 80 characters #43: FILE: hw/mips/malta.c:1090: + loaderparams.ram_size - initrd_offset); total: 0 errors, 2 warnings, 24 lines checked Patch 42/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 43/113 Checking commit d00dcd5c5d98 (moxie: do not use ram_size global) 44/113 Checking commit ed74abd513f7 (nios2: do not use ram_size global) 45/113 Checking commit 98cf13eb12a8 (ppc: do not use ram_size global) 46/113 Checking commit 9ff7cc4471d5 (riscv: do not use ram_size global) 47/113 Checking commit 00ebf53f6c78 (s390x: do not use ram_size global) WARNING: line over 80 characters #30: FILE: hw/s390x/ipl.c:130: + uint64_t fwbase = (MIN(ms->ram_size, 0x80000000U) - 0x200000) & ~0xffffUL; total: 0 errors, 1 warnings, 159 lines checked Patch 47/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 48/113 Checking commit d84de6da2270 (sparc64: do not use ram_size global) WARNING: line over 80 characters #43: FILE: hw/sparc64/sun4u.c:693: + machine->ram_size, &initrd_size, &initrd_addr, total: 0 errors, 1 warnings, 31 lines checked Patch 48/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/113 Checking commit 510df764285c (make ram_size local to vl.c) ERROR: line over 90 characters #29: FILE: hw/core/generic-loader.c:158: + size = load_image_targphys_as(s->file, s->addr, current_machine->ram_size, as); WARNING: line over 80 characters #42: FILE: hw/core/numa.c:645: + * (ms->maxram_size > ms->ram_size) but without '-numa' options explicitly on total: 1 errors, 1 warnings, 92 lines checked Patch 49/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 50/113 Checking commit 98cfa88253df (hw/char/serial: Clean up unnecessary code) 51/113 Checking commit 833cfa890f97 (treewide: do not use short-form boolean options) WARNING: line over 80 characters #230: FILE: tests/test-char.c:416: + "websocket:127.0.0.1:0,server=on,wait=off", NULL); total: 0 errors, 1 warnings, 196 lines checked Patch 51/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 52/113 Checking commit e8e842ded54b (vl: extract validation of -smp to machine.c) 53/113 Checking commit ab08620cf4da (vl: remove bogus check) 54/113 Checking commit 020c4c972d1e (vl: split various early command line options to a separate function) 55/113 Checking commit 60ee01799384 (vl: move various initialization routines out of qemu_init) 56/113 Checking commit 6ac7d06dac4d (vl: extract qemu_init_subsystems) 57/113 Checking commit 3c7c4824375c (vl: move prelaunch part of qemu_init to new functions) ERROR: braces {} are necessary for all arms of this statement #73: FILE: softmmu/vl.c:3048: + if (foreach_device_config(DEV_USB, usb_parse) < 0) [...] WARNING: Block comments use a leading /* on a separate line #93: FILE: softmmu/vl.c:3068: + /* Don't warn about the default network setup that you get if WARNING: Block comments use a leading /* on a separate line #133: FILE: softmmu/vl.c:3108: + /* TODO: once all bus devices are qdevified, this should be done WARNING: Block comments use a trailing */ on a separate line #134: FILE: softmmu/vl.c:3109: + * when bus is created by qdev.c */ WARNING: Block comments use a leading /* on a separate line #153: FILE: softmmu/vl.c:3128: + /* This checkpoint is required by replay to separate prior clock WARNING: Block comments use * on subsequent lines #154: FILE: softmmu/vl.c:3129: + /* This checkpoint is required by replay to separate prior clock + reading from the other reads, because timer polling functions query WARNING: Block comments use a trailing */ on a separate line #155: FILE: softmmu/vl.c:3130: + clock values from the log. */ total: 1 errors, 6 warnings, 286 lines checked Patch 57/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 58/113 Checking commit 6a2d4ef56df4 (vl: extract various command line validation snippets to a new function) ERROR: suspect code indent for conditional statements (4, 9) #46: FILE: softmmu/vl.c:2885: + if (kernel_filename == NULL) { + if (kernel_cmdline != NULL) { ERROR: suspect code indent for conditional statements (9, 14) #47: FILE: softmmu/vl.c:2886: + if (kernel_cmdline != NULL) { + error_report("-append only allowed with -kernel option"); ERROR: suspect code indent for conditional statements (10, 14) #52: FILE: softmmu/vl.c:2891: + if (initrd_filename != NULL) { + error_report("-initrd only allowed with -kernel option"); total: 3 errors, 0 warnings, 139 lines checked Patch 58/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 59/113 Checking commit 4e2dfcb8761c (vl: preconfig and loadvm are mutually exclusive) 60/113 Checking commit 87e13df0476b (vl: extract various command line desugaring snippets to a new function) ERROR: line over 90 characters #49: FILE: softmmu/vl.c:2924: + (uint32_t) qemu_opt_get_number(qemu_find_opts_singleton("smp-opts"), "cpus", 1)); ERROR: space prohibited between function name and open parenthesis '(' #58: FILE: softmmu/vl.c:2933: + exit (i == 1 ? 1 : 0); total: 2 errors, 0 warnings, 88 lines checked Patch 60/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 61/113 Checking commit aab2f9e83c64 (qemu-option: restrict qemu_opts_set to merge-lists QemuOpts) WARNING: line over 80 characters #54: FILE: include/qemu/option.h:122: +bool qemu_opts_set(QemuOptsList *list, const char *name, const char *value, Error **errp); WARNING: line over 80 characters #68: FILE: softmmu/vl.c:3391: + qemu_opts_set(qemu_find_opts("machine"), "kernel", optarg, &error_abort); WARNING: line over 80 characters #73: FILE: softmmu/vl.c:3394: + qemu_opts_set(qemu_find_opts("machine"), "initrd", optarg, &error_abort); WARNING: line over 80 characters #78: FILE: softmmu/vl.c:3397: + qemu_opts_set(qemu_find_opts("machine"), "append", optarg, &error_abort); WARNING: line over 80 characters #83: FILE: softmmu/vl.c:3400: + qemu_opts_set(qemu_find_opts("machine"), "dtb", optarg, &error_abort); ERROR: line over 90 characters #93: FILE: softmmu/vl.c:3510: + qemu_opts_set(qemu_find_opts("machine"), "firmware", optarg, &error_abort); WARNING: line over 80 characters #170: FILE: util/qemu-option.c:673: +bool qemu_opts_set(QemuOptsList *list, const char *name, const char *value, Error **errp) total: 1 errors, 6 warnings, 116 lines checked Patch 61/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 62/113 Checking commit edaf36690fbf (vl: create "-net nic -net user" default earlier) 63/113 Checking commit 847be0b2431c (vl: load plugins as late as possible) 64/113 Checking commit ac306e3f0b17 (vl: extract default devices to separate functions) ERROR: do not initialise statics to 0 or NULL #21: FILE: softmmu/vl.c:130: +static bool nographic = false; ERROR: do not initialise statics to 0 or NULL #29: FILE: softmmu/vl.c:152: +static const char *vga_model = NULL; WARNING: Block comments use a leading /* on a separate line #76: FILE: softmmu/vl.c:2269: + /* According to documentation and historically, -nographic redirects ERROR: braces {} are necessary for all arms of this statement #93: FILE: softmmu/vl.c:2286: + if (default_parallel) [...] ERROR: braces {} are necessary for all arms of this statement #98: FILE: softmmu/vl.c:2291: + if (default_serial) [...] ERROR: braces {} are necessary for all arms of this statement #100: FILE: softmmu/vl.c:2293: + if (default_monitor) [...] ERROR: braces {} are necessary for all arms of this statement #104: FILE: softmmu/vl.c:2297: + if (default_serial) [...] ERROR: braces {} are necessary for all arms of this statement #106: FILE: softmmu/vl.c:2299: + if (default_parallel) [...] ERROR: braces {} are necessary for all arms of this statement #108: FILE: softmmu/vl.c:2301: + if (default_monitor) [...] total: 8 errors, 1 warnings, 254 lines checked Patch 64/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 65/113 Checking commit 25838a45c295 (vl: move CHECKPOINT_INIT after preconfig) WARNING: Block comments use a leading /* on a separate line #24: FILE: hw/core/machine.c:1110: + /* This checkpoint is required by replay to separate prior clock WARNING: Block comments use * on subsequent lines #25: FILE: hw/core/machine.c:1111: + /* This checkpoint is required by replay to separate prior clock + reading from the other reads, because timer polling functions query WARNING: Block comments use a trailing */ on a separate line #26: FILE: hw/core/machine.c:1112: + clock values from the log. */ total: 0 errors, 3 warnings, 22 lines checked Patch 65/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 66/113 Checking commit 65584863cc98 (vl: separate qemu_create_early_backends) 67/113 Checking commit efd767594942 (vl: separate qemu_create_late_backends) ERROR: braces {} are necessary for all arms of this statement #46: FILE: softmmu/vl.c:2786: + if (foreach_device_config(DEV_SERIAL, serial_parse) < 0) [...] ERROR: braces {} are necessary for all arms of this statement #48: FILE: softmmu/vl.c:2788: + if (foreach_device_config(DEV_PARALLEL, parallel_parse) < 0) [...] ERROR: braces {} are necessary for all arms of this statement #50: FILE: softmmu/vl.c:2790: + if (foreach_device_config(DEV_DEBUGCON, debugcon_parse) < 0) [...] total: 3 errors, 0 warnings, 92 lines checked Patch 67/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 68/113 Checking commit ba665b8c10bd (vl: separate qemu_create_machine) WARNING: line over 80 characters #72: FILE: softmmu/vl.c:2893: + current_machine = MACHINE(object_new_with_class(OBJECT_CLASS(machine_class))); WARNING: Block comments use a leading /* on a separate line #84: FILE: softmmu/vl.c:2905: + /* This would be a board error: specifying a minimum smaller than total: 0 errors, 2 warnings, 168 lines checked Patch 68/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 69/113 Checking commit f77baee65d5d (vl: separate qemu_apply_machine_options) 70/113 Checking commit add091a410c8 (vl: separate qemu_resolve_machine_memdev) 71/113 Checking commit 2c5bb359418d (vl: initialize displays before preconfig loop) 72/113 Checking commit c4ff80b228bc (vl: move -global check earlier) 73/113 Checking commit 64d36f6e2df4 (migration, vl: start migration via qmp_migrate_incoming) 74/113 Checking commit ca5aed003ae3 (vl: start VM via qmp_cont) 75/113 Checking commit cd666a43a638 (hmp: introduce cmd_available) 76/113 Checking commit 9077c47e5311 (vl: extract softmmu/datadir.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #524: new file mode 100644 total: 0 errors, 1 warnings, 634 lines checked Patch 76/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 77/113 Checking commit 56b895b96606 (vl: extract machine done notifiers) 78/113 Checking commit b2d4a21405b5 (vl: extract softmmu/rtc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #85: FILE: softmmu/rtc.c:44: +static int rtc_host_datetime_offset = -1; /* valid & used only with WARNING: Block comments use * on subsequent lines #86: FILE: softmmu/rtc.c:45: +static int rtc_host_datetime_offset = -1; /* valid & used only with + RTC_BASE_DATETIME */ WARNING: Block comments use a trailing */ on a separate line #86: FILE: softmmu/rtc.c:45: + RTC_BASE_DATETIME */ total: 0 errors, 4 warnings, 373 lines checked Patch 78/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 79/113 Checking commit 0df7ae49cea5 (vl: remove serial_max_hds) 80/113 Checking commit b3b2b334a353 (vl: clean up -boot variables) WARNING: line over 80 characters #73: FILE: softmmu/vl.c:3225: + qemu_register_reset(restore_boot_order, g_strdup(current_machine->boot_order)); total: 0 errors, 1 warnings, 49 lines checked Patch 80/113 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 81/113 Checking commit 34ec2d397e79 (config-file: move -set implementation to vl.c) 82/113 Checking commit 172c67f632e1 (docs: temporarily disable the kernel-doc extension) 83/113 Checking commit 32223115f7c5 (kernel-doc: fix processing nested structs with attributes) 84/113 Checking commit ca93033bae77 (kernel-doc: add support for ____cacheline_aligned_in_smp attribute) 85/113 Checking commit ae759fa55aa5 (scripts/kernel-doc: Add support for named variable macro arguments) 86/113 Checking commit 901c77534fd0 (scripts: kernel-doc: proper handle @foo->bar()) 87/113 Checking commit 1069fceebe25 (scripts: kernel-doc: accept negation like !@var) 88/113 Checking commit 16067baa2b49 (scripts: kernel-doc: accept blank lines on parameter description) 89/113 Checking commit 8bb93e4177f9 (Replace HTTP links with HTTPS ones: documentation) 90/113 Checking commit 8176521edd11 (scripts/kernel-doc: parse __ETHTOOL_DECLARE_LINK_MODE_MASK) 91/113 Checking commit c164b215560d (scripts/kernel-doc: handle function pointer prototypes) 92/113 Checking commit 98f7e3212665 (scripts/kernel-doc: optionally treat warnings as errors) 93/113 Checking commit 5a891985b542 (kernel-doc: include line numbers for function prototypes) 94/113 Checking commit ef6d10d001a7 (kernel-doc: add support for ____cacheline_aligned attribute) 95/113 Checking commit c8cf35b1be61 (scripts: kernel-doc: add support for typedef enum) 96/113 Checking commit f8d8ba092894 (Revert "scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments") 97/113 Checking commit 34e04d12af19 (Revert "kernel-doc: Use c:struct for Sphinx 3.0 and later") 98/113 Checking commit 47720be5c796 (scripts: kernel-doc: make it more compatible with Sphinx 3.x) 99/113 Checking commit 2c31789a2d62 (scripts: kernel-doc: use a less pedantic markup for funcs on Sphinx 3.x) 100/113 Checking commit 871d904d759e (scripts: kernel-doc: fix troubles with line counts) 101/113 Checking commit 6619dbbbe4e8 (scripts: kernel-doc: reimplement -nofunction argument) 102/113 Checking commit c8041c1ab2ad (scripts: kernel-doc: fix typedef identification) 103/113 Checking commit ccd0a9979248 (scripts: kernel-doc: don't mangle with parameter list) 104/113 Checking commit 599bd606b558 (scripts: kernel-doc: allow passing desired Sphinx C domain dialect) 105/113 Checking commit 49b192447283 (scripts: kernel-doc: fix line number handling) 106/113 Checking commit 2cfa827384d2 (scripts: kernel-doc: try to use c:function if possible) 107/113 Checking commit d74922c086ee (Revert "kernel-doc: Handle function typedefs without asterisks") 108/113 Checking commit 729a65a0cab4 (Revert "kernel-doc: Handle function typedefs that return pointers") 109/113 Checking commit 69e58d5117bb (scripts: kernel-doc: fix typedef parsing) 110/113 Checking commit 09484947d8c9 (scripts: kernel-doc: split typedef complex regex) 111/113 Checking commit f913504eb1de (scripts: kernel-doc: use :c:union when needed) 112/113 Checking commit a12200d87dfc (Revert "docs: temporarily disable the kernel-doc extension") 113/113 Checking commit a4add9d69218 (scripts: kernel-doc: remove unnecesssary change wrt Linux) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201202080849.4125477-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
