Re: [PATCH v2 for-5.2] tests/9pfs: Mark "local" tests as "slow"

On Tue, 24 Nov 2020 08:54:38 +0100 Thomas Huth wrote: > On 24/11/2020 08.43, Greg Kurz wrote: > > The "local" tests can fail on some automated build systems as > > reported here: > > > > https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html > > > > This will need to be investig

Re: [RFC PATCH v2 2/5] ebpf: Added eBPF RSS program.

On 2020/11/19 下午7:13, Andrew Melnychenko wrote: From: Andrew RSS program and Makefile to build it. Also, added a python script that would generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to r

Re: [PATCH v3 3/7] support UFFD write fault processing in ram_save_iterate()

On 24.11.2020 00:34, Peter Xu wrote: On Fri, Nov 20, 2020 at 07:53:34PM +0300, Andrey Gruzdev wrote: On 20.11.2020 19:43, Peter Xu wrote: On Fri, Nov 20, 2020 at 07:15:07PM +0300, Andrey Gruzdev wrote: Yeah, I think we can re-use the postcopy queue code for faulting pages. I'm worring a little

Re: [RFC PATCH v2 3/5] ebpf: Added eBPF RSS loader.

On 2020/11/19 下午7:13, Andrew Melnychenko wrote: From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

Eduardo Habkost writes: > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: >> [...] >> >> When the structure of a data type is to be kept away from its users, I >> >> prefer t

Re: [RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net.

On 2020/11/19 下午7:13, Andrew Melnychenko wrote: From: Andrew When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with

Re: [RFC PATCH v2 5/5] docs: Added eBPF documentation.

On 2020/11/19 下午7:13, Andrew Melnychenko wrote: From: Andrew Also, added maintainers information. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 7 +++ docs/ebpf_rss.rst | 133 ++ 2 files changed,

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

Yuri Benditovich writes: > On Mon, Nov 23, 2020 at 11:25 AM Markus Armbruster > wrote: > >> Andrew Melnichenko writes: >> >> > --f73b2205b4aef0c5 >> > Content-Type: text/plain; charset="UTF-8" >> > >> > Hi, the bug can be reproduced like that: >> > >> >> QEMU 5.1.50 monitor - type '

Re: [PATCH 1/1] Fix qcow2 corruption on discard

Am 23.11.2020 um 19:11 hat Maxim Levitsky geschrieben: > On Mon, 2020-11-23 at 18:38 +0100, Kevin Wolf wrote: > > Am 23.11.2020 um 16:49 hat Maxim Levitsky geschrieben: > > > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > > > introduced a subtle change to code in zero_i

[PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

An integer underflow could occur during packet transmission due to 'tx_len' not being updated if SONIC_TFC register is set to zero. Check for negative 'tx_len' when removing existing FCS. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1899722 Signed-off-by: Mauro Matteo Cascella Reported-by: G

[PATCH for-5.2 v2] qcow2: Fix corruption on write_zeroes with MAY_UNMAP

From: Maxim Levitsky Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") introduced a subtle change to code in zero_in_l2_slice: It swapped the order of 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); 2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO

Re: [PATCH 1/2] block: make bdrv_drop_intermediate() less wrong

23.11.2020 23:12, Vladimir Sementsov-Ogievskiy wrote: First, permission update loop tries to do iterations transactionally, but the whole update is not transactional: nobody roll-back successful loop iterations when some iteration fails. Second, in the iteration we have nested permission update:

Re: [PATCH 04/21] block: bdrv_refresh_perms: check parents compliance

23.11.2020 23:12, Vladimir Sementsov-Ogievskiy wrote: Add additional check that node parents do not interfere with each other. This should not hurt existing callers and allows in further patch use bdrv_refresh_perms() to update a subtree of changed BdrvChild (check that change is correct). New c

Re: [PATCH 2/2] block: assert that permission commit sets same permissions

23.11.2020 23:12, Vladimir Sementsov-Ogievskiy wrote: On permission update commit we must set same permissions as on_check_. Let's add assertions. Next step may be to drop permission parameters from_set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdrv_

[PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

v2: Drop some package from dockerfile to make docker image more light. v1: Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. Use openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Cho, Yu-Chen --- .gitlab-ci.d/containers.yml | 5 ++ .gitlab-

[PATCH-for-5.2? 3/4] hw/arm/xlnx-versal: Add SD bus QOM alias on the SoC

To be able to select a particular SD bus from the command line, add a QOM alias on the SoC (using an unique name). Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-versal.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xl

[PATCH-for-5.2? 4/4] hw/arm/xilinx_zynq: Add SD bus QOM alias on the machine

To be able to select a particular SD bus from the command line, add a QOM alias on the machine (using an unique name). Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xilinx_zynq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/a

[PATCH-for-5.2? 0/4] hw/arm: Add SD bus QOM alias on the machine/soc

Easy fix for LP#1895895 suggested by Peter. As TYPE_ASPEED_SDHCI creates SDHCI inside a controller (not a SoC/machine) we don't bother modifying it yet. Philippe Mathieu-Daudé (4): hw/arm/fsl-imx: Add SD bus QOM alias on the SoC hw/arm/exynos4210: Add SD bus QOM alias on the SoC hw/arm/xlnx

Re: [PATCH v3 08/19] qlit: Move qlit_equal_qobject() reference values to array

Eduardo Habkost writes: > Add an array of values to qlit_equal_qobject_test(), so we can > extend the test case to compare multiple literals, not just the > ones at the existing `qlit` and `qlit_foo` variables. > > Signed-off-by: Eduardo Habkost > --- > This is a new patch added in v3 of this se

[PATCH-for-5.2? 1/4] hw/arm/fsl-imx: Add SD bus QOM alias on the SoC

To be able to select a particular SD bus from the command line, add a QOM alias on the SoC (using an unique name). Buglink: https://bugs.launchpad.net/qemu/+bug/1895895 Reported-by: David Aghaian Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/fsl-imx25.c | 6 +

[PATCH-for-5.2? 2/4] hw/arm/exynos4210: Add SD bus QOM alias on the SoC

To be able to select a particular SD bus from the command line, add a QOM alias on the SoC (using an unique name). Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/exynos4210.c b/hw/arm/exyn

Re: [PATCH v3 10/19] qlit: Support all types of QNums

Eduardo Habkost writes: > Add two new macros to support other types of QNums: > QLIT_QNUM_UINT, and QLIT_QNUM_DOUBLE, and include them > in the qlit_equal_qobject_test() test case. > > Signed-off-by: Eduardo Habkost > --- > Changes v2 -> v3: > * QLIT_QNUM macro doesn't exist anymore > * Addition

Re: [PATCH v3 11/19] qom: field_prop_set_default_value() helper

Eduardo Habkost writes: > Move code that sets the property default value to a separate > function, to reduce duplication and make refactoring easier. > > Signed-off-by: Eduardo Habkost > --- > This is a new patch added in v3 of this series. > Hopefully, this will make the series easier to review

Re: [PATCH v2 1/2] iotests: add another bash sleep command to 247

23.11.2020 18:44, Andrey Shinkevich wrote: This patch paves the way for the one that follows. The following patch makes the QMP monitor to read up to 4K from stdin at once. That results in running the bash 'sleep' command before the _qemu_proc_exec() starts But how? Before _qemu_proc_exec() sta

[PATCH] block: Don't inactivate bs if it is aleady inactive

The following steps will cause qemu assertion failure: - pause vm - save memory snapshot into local file through fd migration - do the above operation again will cause qemu assertion failure The backtrace looks like: #0 0x7fbf958c5c37 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x000

Re: [PATCH for-5.2 v2] qcow2: Fix corruption on write_zeroes with MAY_UNMAP

On Tue 24 Nov 2020 10:28:15 AM CET, Kevin Wolf wrote: > From: Maxim Levitsky > > Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") > introduced a subtle change to code in zero_in_l2_slice: > > It swapped the order of > > 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

Markus Armbruster writes: > This means commit 08712fcb85 "net: Track netdevs in NetClientState > rather than QemuOpt" didn't actually replace QemuOpts completely. > > This affects QMP: > > $ socat "READLINE,history=$HOME/.qmp_history,prompt=QMP>" > UNIX-CONNECT:$HOME/work/images/test-qmp >

[PATCH] target/mips/translate: Simplify PCPYH using deposit/extract

Simplify (and optimize) the Parallel Copy Halfword instruction using deposit() / extract() helpers. Ref: C790-Specific Instruction Set, Appendix B-63. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 35 ++- 1 file changed, 10 insertions(+), 25

Re: [PATCH 2/2] target/mips/kvm: Assert unreachable code is not used

Huacai, ping? On 5/12/20 9:09 AM, Philippe Mathieu-Daudé wrote: > +Paolo > > On 4/29/20 10:29 AM, Philippe Mathieu-Daudé wrote: >> This code must not be used outside of KVM. Abort if it is. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/mips/kvm.c | 8 ++-- >>   1 file changed

Re: [PATCH v3 10/19] qlit: Support all types of QNums

On 24/11/20 10:55, Markus Armbruster wrote: +/* Larger than UINT64_MAX: */ +QLIT_QNUM_DOUBLE(18446744073709552e3), +/* Smaller than INT64_MIN: */ +QLIT_QNUM_DOUBLE(-92233720368547758e2), Why "larger than UINT64_MAX" and "smaller than INT64_MIN"? I guess the poi

[Bug 1895895] Re: Attaching SD-Card to specific SD-Bus Sabrelite (ARM)

Patch sent: https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg05942.html ** Changed in: qemu Status: Confirmed => In Progress ** Changed in: qemu Assignee: (unassigned) => Philippe Mathieu-Daudé (philmd) -- You received this bug notification because you are a member of qemu-

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

On 2020/11/24 3:33, Neo Jia wrote: > On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: >> External email: Use caution opening links or attachments >> >> >> On 2020/11/21 6:01, Alex Williamson wrote: >>> On Fri, 20 Nov 2020 22:05:49 +0800 >>> Shenming Lu wrote: >>> On 2020/11/20 1:4

Re: [PATCH RFC] vfio: Move the saving of the config space to the right place in VFIO migration

* Neo Jia (c...@nvidia.com) wrote: > On Mon, Nov 23, 2020 at 11:14:38AM +0800, Shenming Lu wrote: > > External email: Use caution opening links or attachments > > > > > > On 2020/11/21 6:01, Alex Williamson wrote: > > > On Fri, 20 Nov 2020 22:05:49 +0800 > > > Shenming Lu wrote: > > > > > >> On

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

On Wed, 18 Nov 2020 10:03:44 +0100 Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdo

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

On Mon, 23 Nov 2020 19:41:40 +0100 Thomas Huth wrote: > On 23/11/2020 16.59, Cornelia Huck wrote: > > On Mon, 23 Nov 2020 11:47:25 +0100 > > Markus Armbruster wrote: > > > >> Thomas Huth writes: > >> > >>> On 18/11/2020 15.30, Peter Maydell wrote: > On Wed, 18 Nov 2020 at 14:24, M

Re: [PATCH 2/2] target/mips/kvm: Assert unreachable code is not used

On 24/11/20 11:41, Philippe Mathieu-Daudé wrote: Huacai, ping? On 5/12/20 9:09 AM, Philippe Mathieu-Daudé wrote: +Paolo On 4/29/20 10:29 AM, Philippe Mathieu-Daudé wrote: This code must not be used outside of KVM. Abort if it is. Signed-off-by: Philippe Mathieu-Daudé ---   target/mips/kvm.

Re: [PATCH v2 2/2] monitor: increase amount of data for monitor to read

23.11.2020 18:44, Andrey Shinkevich wrote: QMP and HMP monitors read one byte at a time from the socket or stdin, which is very inefficient. With 100+ VMs on the host, this results in multiple extra system calls and CPU overuse. This patch increases the amount of read data up to 4096 bytes that f

help with a build-user and build-user-plugin failure

Hi Alex, I am seeing build failures with build-user and build-user-plugin: https://gitlab.com/hw-claudio/qemu/-/pipelines/220245998 and I am trying to start investigating. How do I reproduce this locally? I am trying to run locally the check-tcg rule, but I cannot get it to work. I managed to

Re: [PATCH 1/2] libvhost-user: replace qemu/bswap.h with glibc endian.h

* marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Dr. David Alan Gilbert > --- > contrib/libvhost-user/libvhost-user.c | 77 ++- > 1 file changed, 40 insertions(+), 37 delet

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

Please confirm that this patch is intended to solve only the problem with hmp (and disallow duplicated ids) With it the netdev that was added from qemu's command line and was deleted (for example by hmp) still can't be created, correct? On Tue, Nov 24, 2020 at 12:21 PM Markus Armbruster wrote: >

Re: [PATCH v2 for-5.2] tests/9pfs: Mark "local" tests as "slow"

On Dienstag, 24. November 2020 08:43:43 CET Greg Kurz wrote: > The "local" tests can fail on some automated build systems as > reported here: > > https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html > > This will need to be investigated and addressed later. Let's go for a > work

Re: [PATCH 2/2] libvhost-user: replace qemu/memfd.h usage

* marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > From: Marc-André Lureau > > Undo the damage from commit 5f9ff1eff3 ("libvhost-user: Support tracking > inflight I/O in shared memory") which introduced glib dependency through > osdep.h inclusion. > > libvhost-user.c tries to

[PULL 0/1] 9p fixes for 5.2 2020-11-24

The following changes since commit 683685e72dccaf8cb9fe8ffa20f5c5aacea72118: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2020-11-23 13:03:13 +) are available in the Git repository at: https://gitlab.com/gkurz/qemu.git tags/9p-fix-2020-11

[PULL 1/1] tests/9pfs: Mark "local" tests as "slow"

The "local" tests can fail on some automated build systems as reported here: https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html This will need to be investigated and addressed later. Let's go for a workaround in the meantime : mark the "local" tests as "slow" so that they aren

Re: [PATCH v2 1/2] iotests: add another bash sleep command to 247

On 24.11.2020 13:04, Vladimir Sementsov-Ogievskiy wrote: 23.11.2020 18:44, Andrey Shinkevich wrote: This patch paves the way for the one that follows. The following patch makes the QMP monitor to read up to 4K from stdin at once. That results in running the bash 'sleep' command before the _qemu_

Re: [PATCH for-5.2 05/10] vhost-user-blk-test: close fork child file descriptors

Hi Stefan, On Wed, Nov 11, 2020 at 12:43:26PM +, Stefan Hajnoczi wrote: Do not leave stdin and stdout open after fork. stdout is the tap-driver.pl pipe. If we keep the pipe open then tap-driver.pl will not detect that qos-test has terminated and it will hang. I wonder under which situation

Re: [PATCH] contrib/rdmacm-mux: Fix error condition in hash_tbl_search_fd_by_ifid()

Hi everyone， Who can help me merge this patch into the master branch? This patch may be need for qemu-5.2 Thanks， Alex On 2020/11/4 0:35, Marcel Apfelbaum wrote: > Hi Alex, > > On Thu, Oct 29, 2020 at 3:43 PM AlexChen > wrote: > > When fd is not found accordi

Re: [PATCH v3 10/19] qlit: Support all types of QNums

Paolo Bonzini writes: > On 24/11/20 10:55, Markus Armbruster wrote: >>> +/* Larger than UINT64_MAX: */ >>> +QLIT_QNUM_DOUBLE(18446744073709552e3), >>> +/* Smaller than INT64_MIN: */ >>> +QLIT_QNUM_DOUBLE(-92233720368547758e2), >> Why "larger than UINT64_MAX" and "s

[RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, OSPM on CPU eject will set bit #4 in CPU hotplug block for to be ejected CPU to mark it for removal by firmware and trigger SMI upcall to let firmware do actual eject. Signed-off-by: Igor Mammedov --- PS: - abuse 5.1 machine type

[Bug 1761798] Re: live migration intermittently fails in CI with "VQ 0 size 0x80 Guest index 0x12c inconsistent with Host index 0x134: delta 0xfff8"

hang on, I've just noticed the : char device redirected to /dev/pts/2 (label charserial0) virtio: bogus descriptor or out of resources 2020-11-20 14:25:39.911+: initiating migration I've never seen that 'bogus descriptor or out of resources' one before; the fact that's happening before the

Re: [PATCH v2 1/2] iotests: add another bash sleep command to 247

On 23.11.2020 18:44, Andrey Shinkevich wrote: This patch paves the way for the one that follows. The following patch makes the QMP monitor to read up to 4K from stdin at once. That results in running the bash 'sleep' command before the _qemu_proc_exec() starts in subshell. Another 'sleep' command

[PATCH] qxl: fix segfault

Add missing sanity check. Reproducer: run qemu with "-device qxl" but without "-spice ..." Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") Signed-off-by: Gerd Hoffmann --- ui/console.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/console.c b

Re: [PATCH] qxl: fix segfault

Hi On Tue, Nov 24, 2020 at 4:30 PM Gerd Hoffmann wrote: > Add missing sanity check. > Reproducer: run qemu with "-device qxl" but without "-spice ..." > > Fixes: 0d9b90ce5c73 ("console: make QMP/HMP screendump run in coroutine") > Signed-off-by: Gerd Hoffmann > --- > ui/console.c | 4 +++- > 1

[PATCH 0/2] Remove GCC < 4.8 checks

From: Marc-André Lureau Hi, Since commit efc6c07 ("configure: Add a test for the minimum compiler version= "), QEMU explicitely depends on GCC >=3D 4.8. Marc-Andr=C3=A9 Lureau (2): Remove GCC version checks (all < 4.8) compiler.h: remove QEMU_GNUC_PREREQ macro include/qemu/atomic.h

[PATCH 1/2] Remove GCC version checks (all < 4.8)

From: Marc-André Lureau Since commit efc6c07 ("configure: Add a test for the minimum compiler version"), QEMU explicitely depends on GCC >= 4.8. Signed-off-by: Marc-André Lureau --- include/qemu/atomic.h | 17 - include/qemu/compiler.h | 22 ++

[PATCH 2/2] compiler.h: remove QEMU_GNUC_PREREQ macro

From: Marc-André Lureau (eventually, future checks could be done with G_GNUC_CHECK_VERSION) Signed-off-by: Marc-André Lureau --- include/qemu/compiler.h| 11 --- scripts/cocci-macro-file.h | 1 - 2 files changed, 12 deletions(-) diff --git a/include/qemu/compiler.h b/include/qemu

RE: [raw] Guest stuck during live live-migration

Thanks Kevin, > > Hello, > > > > In our company, we are hosting a large number of Vm, hosted behind > > Openstack (so libvirt/qemu). > > A large majority of our Vms are runnign with local data only, stored on > > NVME, and most of them are RAW disks. > > > > With Qemu 4.0 (can be even with olde

[PATCH] sbsa-ref: allow to use Cortex-A53/57/72 cpus

Trusted Firmware now supports A72 on sbsa-ref by default [1] so enable it for QEMU as well. A53 was already enabled there. 1. https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7117 Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 23 --- 1 file changed,

Re: [PATCH 0/2] Remove GCC < 4.8 checks

On Tue, Nov 24, 2020 at 4:54 PM wrote: > From: Marc-André Lureau > > Hi, > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version= > "), > QEMU explicitely depends on GCC >=3D 4.8. > > Marc-Andr=C3=A9 Lureau (2): > Remove GCC version checks (all < 4.8) > compiler.h

Re: [PATCH 0/2] Remove GCC < 4.8 checks

Patchew URL: https://patchew.org/QEMU/20201124125235.266884-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201124125235.266884-1-marcandre.lur...@redhat.com Subject: [PATCH 0/2] Remove

Re: [PATCH] sbsa-ref: allow to use Cortex-A53/57/72 cpus

W dniu 21.11.2020 o 18:09, Richard Henderson pisze: +static const char *valid_cpus[] = { const char * const I copied it from hw/arm/virt.c file. Otherwise, Reviewed-by: Richard Henderson Thanks. Fixed patch sent in separate mail.

Re: [PATCH for-6.0 5/9] spapr: Simplify error path of spapr_core_plug()

On Mon, 23 Nov 2020 16:13:18 +1100 David Gibson wrote: > On Sat, Nov 21, 2020 at 12:42:04AM +0100, Greg Kurz wrote: > > spapr_core_pre_plug() already guarantees that the slot for the given core > > ID is available. It is thus safe to assume that spapr_find_cpu_slot() > > returns a slot during plu

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

Yuri Benditovich writes: > Please confirm that this patch is intended to solve only the problem with > hmp (and disallow duplicated ids) The intent is to reject duplicate ID and to accept non-duplicate ID, no matter how the device is created (CLI, HMP, QMP) or a prior instance was deleted (HMP,

Re: virtio-9p-test.c:300:v9fs_req_recv: assertion failed (hdr.id == id): (7 == 73)

On 11/23/20 2:45 PM, Christian Schoenebeck wrote: > On Montag, 23. November 2020 14:48:15 CET Christian Schoenebeck wrote: >> On Montag, 23. November 2020 14:17:34 CET Greg Kurz wrote: >>> Fixed maintainer's address: s/o...@crudebyte.com/qemu_...@crudebyte.com >>> >>> On Sat, 21 Nov 2020 17:03:14 -

Re: [PATCH 2/2] libvhost-user: replace qemu/memfd.h usage

Hi On Tue, Nov 24, 2020 at 3:54 PM Dr. David Alan Gilbert wrote: > > * marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > > From: Marc-André Lureau > > > > Undo the damage from commit 5f9ff1eff3 ("libvhost-user: Support tracking > > inflight I/O in shared memory") which introduce

Re: [PATCH 0/2] Remove GCC < 4.8 checks

On Tue, 24 Nov 2020 at 12:52, wrote: > > From: Marc-André Lureau > > Hi, > > Since commit efc6c07 ("configure: Add a test for the minimum compiler version= > "), > QEMU explicitely depends on GCC >= 4.8. You need to be a bit cautious about removing QEMU_GNUC_PREREQ() checks, because clang advert

Re: [PULL 0/5] Net patches

On Tue, 24 Nov 2020 at 02:44, Jason Wang wrote: > > The following changes since commit 23895cbd82be95428e90168b12e925d0d3ca2f06: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201123.0' > into staging (2020-11-23 18:51:13 +) > > are available in the git repository at:

Re: [PATCH 2/2] libvhost-user: replace qemu/memfd.h usage

Hi On Tue, Nov 24, 2020 at 5:32 PM Marc-André Lureau wrote: > > Hi > > On Tue, Nov 24, 2020 at 3:54 PM Dr. David Alan Gilbert > wrote: > > > > * marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > > > From: Marc-André Lureau > > > > > > Undo the damage from commit 5f9ff1eff3 ("li

Re: virtio-9p-test.c:300:v9fs_req_recv: assertion failed (hdr.id == id): (7 == 73)

On Dienstag, 24. November 2020 14:25:17 CET Cole Robinson wrote: > On 11/23/20 2:45 PM, Christian Schoenebeck wrote: > > On Montag, 23. November 2020 14:48:15 CET Christian Schoenebeck wrote: > >> On Montag, 23. November 2020 14:17:34 CET Greg Kurz wrote: > >>> Fixed maintainer's address: s/o...@cr

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

Markus Armbruster writes: > Yuri Benditovich writes: > >> Please confirm that this patch is intended to solve only the problem with >> hmp (and disallow duplicated ids) > > The intent is to reject duplicate ID and to accept non-duplicate ID, no > matter how the device is created (CLI, HMP, QMP)

Re: [PATCH 0/2] Remove GCC < 4.8 checks

On Tue, Nov 24, 2020 at 5:33 PM Peter Maydell wrote: > On Tue, 24 Nov 2020 at 12:52, wrote: > > > > From: Marc-André Lureau > > > > Hi, > > > > Since commit efc6c07 ("configure: Add a test for the minimum compiler > version= > > "), > > QEMU explicitely depends on GCC >= 4.8. > > You need to be

[PATCH-for-5.2?] target/mips/translate: Check R6 reserved encoding for Load Linked Word

Release 6 recoded the 'Load Linked Word' using SPECIAL3 opcode, this opcode (0b11) is now reserved. Ref: A.2 Instruction Bit Encoding Tables: "6Rm instructions signal a Reserved Instruction exception when executed by a Release 6 implementation." The check was added in commit 4368b29a26e

Re: help with a build-user and build-user-plugin failure

On 11/24/20 12:04 PM, Claudio Fontana wrote: > Hi Alex, > > I am seeing build failures with build-user and build-user-plugin: > > https://gitlab.com/hw-claudio/qemu/-/pipelines/220245998 > > and I am trying to start investigating. > > How do I reproduce this locally? > > I am trying to run loc

Re: [PATCH for-6.0 2/8] spapr/xive: Introduce spapr_xive_nr_ends()

On 11/23/20 12:16 PM, Greg Kurz wrote: > On Mon, 23 Nov 2020 10:46:38 +0100 > Cédric Le Goater wrote: > >> On 11/20/20 6:46 PM, Greg Kurz wrote: >>> We're going to kill the "nr_ends" field in a subsequent patch. >> >> why ? it is one of the tables of the controller and its part of >> the main XI

Re: help with a build-user and build-user-plugin failure

On 11/24/20 2:54 PM, Philippe Mathieu-Daudé wrote: > On 11/24/20 12:04 PM, Claudio Fontana wrote: >> Hi Alex, >> >> I am seeing build failures with build-user and build-user-plugin: >> >> https://gitlab.com/hw-claudio/qemu/-/pipelines/220245998 >> >> and I am trying to start investigating. >> >> Ho

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

On Tue, Nov 24, 2020 at 3:36 PM Markus Armbruster wrote: > Markus Armbruster writes: > > > Yuri Benditovich writes: > > > >> Please confirm that this patch is intended to solve only the problem > with > >> hmp (and disallow duplicated ids) > > > > The intent is to reject duplicate ID and to acc

Re: [PATCH v3] qga: Correct loop count in qmp_guest_get_vcpus()

Hi, On 11/20/20 1:33 PM, Marc-André Lureau wrote: > Hi > > On Fri, Nov 20, 2020 at 4:27 PM Lin Ma > wrote: > > The guest-get-vcpus returns incorrect vcpu info in case we hotunplug > vcpus(not > the last one). > e.g.: > A VM has 4 VCPUs: cpu0 + 3 hotunpl

Re: [PATCH for-5.2] Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()"

On 11/20/20 2:10 PM, Paolo Bonzini wrote: > On 20/11/20 14:04, Michael S. Tsirkin wrote: >> This reverts commit bccb20c49df1bd683248a366021973901c11982f as it >> introduced a regression blocking bus addresses > 0x1f or higher. >> Legal bus numbers go up to 0xff. >> >> Cc: "Philippe Mathieu-Daudé"

Re: [PATCH for-6.0 3/8] spapr/xive: Add "nr-servers" property

>> The only other place where the number of vCPUs is used is in >> spapr_xive_dt() to define the vCPU IPI range, which done at >> the machine level again. > > spapr_max_server_number() isn't the number of vCPUs. It is the > number of consecutive vCPU ids the IC might be exposed to, > starting fro

[RFC 0/1] security-process: update with mailing list details

From: Prasad J Pandit Hello, * After upstream discussions and considering various options like LaunchPad bugs, GitLab issues etc. -> https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg04266.html -> https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg00059.html We are a

[RFC 1/1] security-process: update process information

From: Prasad J Pandit We are about to introduce a qemu-security mailing list to report and triage QEMU security issues. Update the QEMU security process web page with new mailing list and triage details. Signed-off-by: Prasad J Pandit --- contribute/security-process.md | 105 +

[PULL 0/1] Block layer patches for 5.2.0-rc3

The following changes since commit 23895cbd82be95428e90168b12e925d0d3ca2f06: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201123.0' into staging (2020-11-23 18:51:13 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for yo

[PULL 1/1] qcow2: Fix corruption on write_zeroes with MAY_UNMAP

From: Maxim Levitsky Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()") introduced a subtle change to code in zero_in_l2_slice: It swapped the order of 1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); 2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO

Re: [PATCH 2/2] libvhost-user: replace qemu/memfd.h usage

* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > On Tue, Nov 24, 2020 at 3:54 PM Dr. David Alan Gilbert > wrote: > > > > * marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > > > From: Marc-André Lureau > > > > > > Undo the damage from commit 5f9ff1eff3 ("libvho

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbruster wrote: > >> [...] > >> >> Wh

Re: [PATCH v3 11/19] qom: field_prop_set_default_value() helper

On Tue, Nov 24, 2020 at 10:58:27AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Move code that sets the property default value to a separate > > function, to reduce duplication and make refactoring easier. > > > > Signed-off-by: Eduardo Habkost > > --- > > This is a new patch

Re: [PATCH v3 08/19] qlit: Move qlit_equal_qobject() reference values to array

On Tue, Nov 24, 2020 at 10:51:34AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Add an array of values to qlit_equal_qobject_test(), so we can > > extend the test case to compare multiple literals, not just the > > ones at the existing `qlit` and `qlit_foo` variables. > > > > S

Re: [PATCH] hmp: Changed hmp_netdev_add() using qmp_marshal_netdev_add()

On 11/24/20 7:36 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Yuri Benditovich writes: >> >>> Please confirm that this patch is intended to solve only the problem with >>> hmp (and disallow duplicated ids) >> >> The intent is to reject duplicate ID and to accept non-duplicate ID

[PATCH] vhost-user-scsi: Fix memleaks in vus_proc_req()

The 'elem' is allocated memory in vu_queue_pop(), and it's memory should be freed in all error branchs after vu_queue_pop(). In addition, in order to free 'elem' memory outside of while(1) loop, move the definition of 'elem' to the begin of vus_proc_req(). Reported-by: Euler Robot Signed-off-by:

Re: [PATCH v3 10/19] qlit: Support all types of QNums

On Tue, Nov 24, 2020 at 01:22:02PM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 24/11/20 10:55, Markus Armbruster wrote: > >>> +/* Larger than UINT64_MAX: */ > >>> +QLIT_QNUM_DOUBLE(18446744073709552e3), > >>> +/* Smaller than INT64_MIN: */ > >>> +

Re: [PATCH v2 2/2] monitor: increase amount of data for monitor to read

24.11.2020 14:03, Vladimir Sementsov-Ogievskiy wrote: 23.11.2020 18:44, Andrey Shinkevich wrote: QMP and HMP monitors read one byte at a time from the socket or stdin, which is very inefficient. With 100+ VMs on the host, this results in multiple extra system calls and CPU overuse. This patch in

Re: [PATCH for-5.2] Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()"

On Tue, Nov 24, 2020 at 03:13:14PM +0100, Philippe Mathieu-Daudé wrote: > On 11/20/20 2:10 PM, Paolo Bonzini wrote: > > On 20/11/20 14:04, Michael S. Tsirkin wrote: > >> This reverts commit bccb20c49df1bd683248a366021973901c11982f as it > >> introduced a regression blocking bus addresses > 0x1f or

[PULL 0/1] PCI host devaddr property fix for 5.2

The following changes since commit d536d9578ec3ac5029a70b8126cb84bb6f2124a4: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2020-11-24 10:59:12 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-for-5.2-pu

[PULL 1/1] Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()"

From: "Michael S. Tsirkin" This reverts commit bccb20c49df1bd683248a366021973901c11982f as it introduced a regression blocking bus addresses > 0x1f or higher. Legal bus numbers go up to 0xff. Fixes: bccb20c49df ("Use qemu_strtoul() in set_pci_host_devaddr()") Reported-by: Klaus Herman Reported-

Re: [PATCH v3 08/19] qlit: Move qlit_equal_qobject() reference values to array

Eduardo Habkost writes: > On Tue, Nov 24, 2020 at 10:51:34AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Add an array of values to qlit_equal_qobject_test(), so we can >> > extend the test case to compare multiple literals, not just the >> > ones at the existing `qlit` an

Re: [PATCH v3 3/7] support UFFD write fault processing in ram_save_iterate()

On Tue, Nov 24, 2020 at 11:02:09AM +0300, Andrey Gruzdev wrote: > On 24.11.2020 00:34, Peter Xu wrote: > > On Fri, Nov 20, 2020 at 07:53:34PM +0300, Andrey Gruzdev wrote: > > > On 20.11.2020 19:43, Peter Xu wrote: > > > > On Fri, Nov 20, 2020 at 07:15:07PM +0300, Andrey Gruzdev wrote: > > > > > Yea

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

Eduardo Habkost writes: > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Fri, Nov 20, 2020 at 06:29:16AM +0100, Markus Armbr

Re: [PULL 0/1] PCI host devaddr property fix for 5.2

Patchew URL: https://patchew.org/QEMU/20201124151500.2945356-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201124151500.2945356-1-ehabk...@redhat.com Subject: [PULL 0/1] PCI host devaddr prope

Re: [PULL 0/1] ppc-for-5.2 queue 20201124

available in the Git repository at: > > https://gitlab.com/dgibson/qemu.git tags/ppc-for-5.2-20201124 > > for you to fetch changes up to afae37d98ae991c0792c867dbd9f32f988044318: > > ppc/translate: Implement lxvwsx opcode (2020-11-24 11:34:18 +1100) > > ---

Re: [PATCH v2 3/8] qnum: QNumValue type for QNum value literals

On Tue, Nov 24, 2020 at 04:20:37PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Nov 24, 2020 at 09:49:30AM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Mon, Nov 23, 2020 at 08:51:27AM +0100, Markus Armbruster wrote: > >> >> Eduardo Habko

  1   2   3   >