RE: [PATCH v13 0/4] Add Versal usb model

2020-11-16 Thread Sai Pavan Boddu
Hi Peter, > -Original Message- > From: Sai Pavan Boddu > Sent: Tuesday, November 10, 2020 12:22 PM > To: Peter Maydell ; Markus Armbruster > ; Marc-André Lureau ; > Paolo Bonzini ; Gerd Hoffmann ; > Edgar Iglesias ; Francisco Eduardo Iglesias > ; Alistair Francis ; Eduardo > Habkost ; Yin

Re: [RFC] vfio-pci/migration: Dirty logging of the Memory BAR region?

2020-11-16 Thread Zenghui Yu
On 2020/11/15 23:03, Paolo Bonzini wrote: On 15/11/20 15:31, Zenghui Yu wrote: diff --git a/softmmu/memory.c b/softmmu/memory.c index 71951fe4dc..0958db1a08 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1806,7 +1806,10 @@ bool memory_region_is_ram_device(MemoryRegion *mr) uint8_t mem

Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-11-16 Thread Markus Armbruster
John Snow writes: > _make_tree might receive a dict or some other type. Are you talking about @obj? > Adding features > information should arguably be performed by the caller at such a time > when we know the type of the object and don't have

[Bug 1492649] Re: QEMU soundhw HDA huge microphone lag

2020-11-16 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[PATCH 01/13] pc-dimm: put it into the 'storage' category

2020-11-16 Thread Gan Qixin
The category of the pc-dimm device is not set, put it into the 'storage' category. Signed-off-by: Gan Qixin --- Cc: Michael S. Tsirkin --- hw/mem/pc-dimm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 2ffc986734..017146e3d1 100644 --- a/hw/mem/pc

[PATCH 00/13] Categorize some uncategorized devices

2020-11-16 Thread Gan Qixin
Hi all, By running "qemu-system-x86_64 -device help" and "qemu-system-arm -M none -device help", I found many uncategorized devices. Therefore, I categorized them. Thanks, Gan Qixin Gan Qixin (13): pc-dimm: put it into the 'storage' category virtio-pmem: put it into the 'storage' category

[PATCH 09/13] u2f-passthru: put it into the 'usb' category

2020-11-16 Thread Gan Qixin
The category of the u2f-passthru device is not set, put it into the 'usb' category. Signed-off-by: Gan Qixin --- Cc: Gerd Hoffmann --- hw/usb/u2f-passthru.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c index ae00e93f35..000822f396 100644 ---

[PATCH 05/13] mc146818rtc: put it into the 'misc' category

2020-11-16 Thread Gan Qixin
The category of the mc146818rtc device is not set, put it into the 'misc' category. Signed-off-by: Gan Qixin --- Cc: Michael S. Tsirkin --- hw/rtc/mc146818rtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 7a38540cb9..39edca0996 100644 --

[PATCH 03/13] vmmouse: put it into the 'input' category

2020-11-16 Thread Gan Qixin
The category of the vmmouse device is not set, put it into the 'input' category. Signed-off-by: Gan Qixin --- Cc: Michael S. Tsirkin --- hw/i386/vmmouse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c index a3556438f0..df4798f502 100644 --- a/hw/i386/

[PATCH 02/13] virtio-pmem: put it into the 'storage' category

2020-11-16 Thread Gan Qixin
The category of the virtio-pmem device is not set, put it into the 'storage' category. Signed-off-by: Gan Qixin --- Cc: Michael S. Tsirkin --- hw/virtio/virtio-pmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index ddb0125901..98b3139c

[PATCH 11/13] spitz: put some Spitz-family devices into the correct category

2020-11-16 Thread Gan Qixin
Some Spitz-family devices have no category, put them into the correct category. Signed-off-by: Gan Qixin --- Cc: Peter Maydell --- hw/arm/spitz.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 32bdeacfd3..0e5e8a4634 100644 --- a/hw/arm/spitz.c +++ b/

[PATCH 08/13] AMDVI-PCI: put it into the 'misc' category

2020-11-16 Thread Gan Qixin
The category of the AMDVI-PCI device is not set, put it into the 'misc' category. Signed-off-by: Gan Qixin --- Cc: Paolo Bonzini --- hw/i386/amd_iommu.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 74a93a5d93..1d4e488f7f 100644 ---

[PATCH 04/13] nvdimm: put it into the 'storage' category

2020-11-16 Thread Gan Qixin
The category of the nvdimm device is not set, put it into the 'storage' category. Signed-off-by: Gan Qixin --- Cc: Xiao Guangrong --- hw/mem/nvdimm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index e1574bc07c..e30695b2ce 100644 --- a/hw/mem/nvdimm.c +

[PATCH 12/13] SPI flash devices: put them into the 'storage' category

2020-11-16 Thread Gan Qixin
SPI flash devices have no category, put them into the 'storage' category. Signed-off-by: Gan Qixin --- Cc: Alistair Francis --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 483925f57a..8dd3ef8559 100644 --- a/hw/block/m25p80.c

[PATCH 07/13] tpm: put some tpm devices into the correct category

2020-11-16 Thread Gan Qixin
Some tpm devices have no category, put them into the correct category. Signed-off-by: Gan Qixin --- Cc: Stefan Berger --- hw/tpm/tpm_tis_isa.c| 1 + hw/tpm/tpm_tis_sysbus.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/tpm/tpm_tis_isa.c b/hw/tpm/tpm_tis_isa.c index 6fd876eebf..10

[PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category

2020-11-16 Thread Gan Qixin
Some peripherals of bcm2835 cprman have no category, put them into the 'misc' category. Signed-off-by: Gan Qixin --- Cc: Philippe Mathieu-Daud?? --- hw/misc/bcm2835_cprman.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/misc/bcm2835_cprman.c b/hw/misc/bcm2835_cprman.c index 7e415a0

[PATCH 06/13] ipmi: put some ipmi devices into the correct category

2020-11-16 Thread Gan Qixin
Some ipmi devices have no category, put them into the correct category. Signed-off-by: Gan Qixin --- Cc: Corey Minyard --- hw/ipmi/ipmi_bmc_extern.c | 1 + hw/ipmi/ipmi_bmc_sim.c| 1 + hw/ipmi/isa_ipmi_bt.c | 1 + hw/ipmi/isa_ipmi_kcs.c| 1 + hw/ipmi/pci_ipmi_bt.c | 1 + hw/ipmi

[PATCH] gitlab-ci.yml: Add openSUSE Tumbleweed and Leap for gitlab CI/CD

2020-11-16 Thread Yu-Chen, Cho
Add build-system-opensusetw and build-system-opensuse152 jobs and add opensuse152.docker and opensusetw.docker dockerfile. Use openSUSE Tumbleweed and openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Yu-Chen, Cho --- .gitlab-ci.d/containers.yml | 10 +++ .gitla

[PATCH 10/13] tosa-ssp: put it into the 'misc' category

2020-11-16 Thread Gan Qixin
The category of the tosa-ssp device is not set, put it into the 'misc' category. Signed-off-by: Gan Qixin --- Cc: Peter Maydell --- hw/arm/tosa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c index fe88ed89fe..0e3461c8ed 100644 --- a/hw/arm/tosa.c +++ b/hw/

Re: [PATCH v7 00/21] preallocate filter

2020-11-16 Thread Vladimir Sementsov-Ogievskiy
13.11.2020 22:33, Max Reitz wrote: On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a filter, which does preallocation on write. v7: 01: add Alberto's r-b 07: don't remove sentence from the comment 08: - drop extra "s->file_end = end;" line - improve check/set perm h

Re: [PATCH v2 07/11] qapi/introspect.py: Unify return type of _make_tree()

2020-11-16 Thread Markus Armbruster
John Snow writes: > Returning two different types conditionally can be complicated to > type. Let's always return a tuple for consistency. Prohibit the use of > annotations with dict-values in this circumstance. It can be implemented > later if and when the need for it arises. > > Signed-off-by:

Re: [PATCH] contrib/libvhost-user: Fix bad printf format specifiers

2020-11-16 Thread Michael S. Tsirkin
It's in the latest pull weren't you Cc'd? On Mon, Nov 16, 2020 at 10:14:12AM +0800, Alex Chen wrote: > Kindly ping... > > On 2020/11/4 18:23, AlexChen wrote: > > We should use printf format specifier "%u" instead of "%d" for > > argument of type "unsigned int". > > > > Reported-by: Euler Robot

Re: [PATCH v2 08/11] qapi/introspect.py: replace 'extra' dict with 'comment' argument

2020-11-16 Thread Markus Armbruster
John Snow writes: > This is only used to pass in a dictionary with a comment already set, so > skip the runaround and just accept the comment. > > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git

[PATCH] tests/acceptance: fix timeout for vm.wait

2020-11-16 Thread Pavel Dovgalyuk
This patch adds timeout parameter to vm.wait() calls, because the default value is just 30 seconds, and tests may last for more time. Signed-off-by: Pavel Dovgalyuk --- tests/acceptance/boot_linux_console.py |8 tests/acceptance/replay_kernel.py |2 +- 2 files changed, 5 in

Re: [PATCH v2 09/11] qapi/introspect.py: create a typed 'Annotated' data strutcure

2020-11-16 Thread Markus Armbruster
John Snow writes: > This replaces _make_tree with Annotated(). By creating it as a generic > container, we can more accurately describe the exact nature of this > particular value. i.e., each Annotated object is actually an > Annotated, describing its contained value. > > This adds stricter typin

Re: [PATCH v2 10/11] qapi/introspect.py: improve readability of _tree_to_qlit

2020-11-16 Thread Markus Armbruster
John Snow writes: > Subjective, but I find getting rid of the comprehensions helps. Also, > divide the sections into scalar and non-scalar sections, and remove > old-style string formatting. > > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 37 +--

Re: [PATCH v13 0/4] Add Versal usb model

2020-11-16 Thread Peter Maydell
On Mon, 16 Nov 2020 at 08:10, Sai Pavan Boddu wrote: > > Hi Peter, > > Does these changes looks good ? Hi; this is on my to-review queue, but I'm currently prioritizing work that will go into the 5.2 release. thanks -- PMM

Re: [PATCH] ads7846: moves from the hw/display folder to the hw/input folder.

2020-11-16 Thread Peter Maydell
On Mon, 16 Nov 2020 at 03:08, Gan Qixin wrote: > > ads7846 is a touch-screen controller that is an input device rather > than a display device, so move it to the hw/input folder. > > Signed-off-by: Gan Qixin Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] hw: add compat machines for 6.0

2020-11-16 Thread Greg Kurz
On Mon, 9 Nov 2020 18:39:28 +0100 Cornelia Huck wrote: > Add 6.0 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c

Re: [PATCH] hw: add compat machines for 6.0

2020-11-16 Thread Cornelia Huck
On Mon, 16 Nov 2020 11:23:14 +0100 Greg Kurz wrote: > On Mon, 9 Nov 2020 18:39:28 +0100 > Cornelia Huck wrote: > > > Add 6.0 machine types for arm/i440fx/q35/s390x/spapr. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/arm/virt.c | 9 - > > hw/core/machine.c

[RFC PATCH 3/5] hw/arm: Convert assertions about flash image size to error_report

2020-11-16 Thread David Edmondson
Rather than throwing an assertion, provide a more detailed report if a flash image is inappropriately sized or aligned. Signed-off-by: David Edmondson --- hw/arm/virt.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 27dbe

[RFC PATCH 1/5] hw/block: blk_check_size_and_read_all should report backend name

2020-11-16 Thread David Edmondson
If there are problems examining or reading data from the block backend, the error messages should include an appropriate identifier to assist in diagnoses. Signed-off-by: David Edmondson --- hw/block/block.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/bl

[RFC PATCH 2/5] hw/block: Flash images can be smaller than the device

2020-11-16 Thread David Edmondson
When loading a flash image into a device, allow the image to be smaller than the extent of the device. Signed-off-by: David Edmondson --- hw/block/block.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/block/block.c b/hw/block/block.c index 8b284e1f14..40

[RFC PATCH 4/5] hw/arm: Flash image mapping follows image size

2020-11-16 Thread David Edmondson
When mapping flash images into the bottom 128MB, create mappings that match the size of the underlying block device rather than 64MB. Signed-off-by: David Edmondson --- hw/arm/trace-events | 2 + hw/arm/virt-acpi-build.c | 29 --- hw/arm/virt.c| 79 +

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 03:48:50PM +, Daniel P. Berrangé wrote: > On Wed, Nov 11, 2020 at 02:36:15PM +, Stefan Hajnoczi wrote: > > On Tue, Nov 10, 2020 at 12:12:31PM +0100, Paolo Bonzini wrote: > > > On 10/11/20 10:53, Stefan Hajnoczi wrote: > In terms of validation I can't help but feel th

[RFC PATCH 5/5] hw/arm: Only minimise flash size on older machines

2020-11-16 Thread David Edmondson
Prior to 5.2 the flash images loaded into the bottom 128MB always filled the region. Ensure that this continues to be the case. Signed-off-by: David Edmondson --- hw/arm/virt-acpi-build.c | 11 +++--- hw/arm/virt.c| 79 ++-- include/hw/arm/virt.h

[RFC PATCH 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-16 Thread David Edmondson
Currently ARM UEFI images are typically built as 2MB/768kB flash images for code and variables respectively. These images are both then padded out to 64MB before being loaded by QEMU. Because the images are 64MB each, QEMU allocates 128MB of memory to read them, and then proceeds to read all 128MB

[PATCH for-5.2] configure: Make "does libgio work" test pull in some actual functions

2020-11-16 Thread Peter Maydell
In commit 76346b6264a9b01979 we tried to add a configure check that the libgio pkg-config data was correct, which builds an executable linked against it. Unfortunately this doesn't catch the problem (missing static library dependency info), because a "do nothing" test source file doesn't have any

Re: [PATCH] RFC: sphinx: adopt kernel readthedoc theme

2020-11-16 Thread Marc-André Lureau
Hi, On Thu, Nov 5, 2020 at 8:03 PM wrote: > > From: Marc-André Lureau > > The default "alabaster" sphinx theme has a couple shortcomings: > - the navbar moves along the page > - the search bar is not always at the same place > - it lacks some contrast and colours > > The "rtd" theme from readthe

[PATCH] util/vfio-helpers.c: Use ram_block_discard_disable() in qemu_vfio_open_pci()

2020-11-16 Thread David Hildenbrand
Currently, when using "nvme://" for a block device, like -drive file=nvme://:01:00.0/1,if=none,id=drive0 \ -device virtio-blk,drive=drive0 \ VFIO may pin all guest memory, and discarding of RAM no longer works as expected. I was able to reproduce this easily with my 01:00.0 Non-Vol

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 04:35:43PM +0100, Cornelia Huck wrote: > On Wed, 11 Nov 2020 15:14:49 + > Stefan Hajnoczi wrote: > > > On Wed, Nov 11, 2020 at 12:48:53PM +0100, Cornelia Huck wrote: > > > On Tue, 10 Nov 2020 13:14:04 -0700 > > > Alex Williamson wrote: > > > > On Tue, 10 Nov 2020 09

[Bug 1759333] Re: Illegal Instruction with HVF when encountering SSE instructions in the emulator

2020-11-16 Thread Roman Bolshakov
Thomas, I think the issue is there. SSE/MMX weren't yet added for HVF. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759333 Title: Illegal Instruction with HVF when encountering SSE instructions i

[PULL 3/6] usb-storage: use bool for removable property

2020-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201105134112.25119-4-kra...@redhat.com --- hw/usb/dev-storage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index d5cc6137443c..360e8ca8f2bd 1006

[PULL 4/6] usb-storage: fill csw on cancel

2020-11-16 Thread Gerd Hoffmann
When scsi requests are canceled fill the csw (command status word) accordingly. Buglink: https://bugs.launchpad.net/qemu/+bug/1901981 Signed-off-by: Gerd Hoffmann Message-id: 20201105134112.25119-5-kra...@redhat.com --- hw/usb/dev-storage.c | 4 1 file changed, 4 insertions(+) diff --git a

Re: [PATCH 2/2] monitor: increase amount of data for monitor to read

2020-11-16 Thread Andrey Shinkevich
On 09.11.2020 12:55, Vladimir Sementsov-Ogievskiy wrote: 06.11.2020 15:42, Andrey Shinkevich wrote: QMP and HMP monitors read one byte at a time from the socket or stdin, which is very inefficient. With 100+ VMs on the host, this results in multiple extra system calls and CPU overuse. This patch

[PULL 0/6] Fixes 20201116 patches

2020-11-16 Thread Gerd Hoffmann
The following changes since commit b50ea0d54bbca7d440315c3d0c0f7a4d6537b180: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201113-1' into staging (2020-11-14 11:22:07 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixe

[PULL 2/6] usb-storage: add commandlog property

2020-11-16 Thread Gerd Hoffmann
Add property so scsi command logging can be switched at runtime instead of compile time. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201105134112.25119-3-kra...@redhat.com --- hw/usb/dev-storage.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-

[PULL 6/6] xhci: move sanity checks

2020-11-16 Thread Gerd Hoffmann
The v variable goes negative for reg < 0x20. Reorder the code to first sanity check then calculate v and assign intr to make sanity checkers happy. Buglink: https://bugs.launchpad.net/qemu/+bug/1902112 Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201105134112.2

[PULL 1/6] usb-storage: switch trace events

2020-11-16 Thread Gerd Hoffmann
Replace most DPRINTF macros with trace events. Drop some DPRINTF macros. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201105134112.25119-2-kra...@redhat.com --- hw/usb/dev-storage.c | 42 +- hw/usb/trace-events | 12

[PULL 5/6] xhci: fix guest triggerable assert

2020-11-16 Thread Gerd Hoffmann
We didn't start any work yet so we can just return at that point instead of asserting. Buglink: https://bugs.launchpad.net/qemu/+bug/1883732 Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20201105134112.25119-6-kra...@redhat.com --- hw/usb/hcd-xhci.c | 4 +++- 1 fi

Re: [PATCH] tests/acceptance: fix timeout for vm.wait

2020-11-16 Thread Philippe Mathieu-Daudé
Cc'ing John. On Mon, Nov 16, 2020 at 11:08 AM Pavel Dovgalyuk wrote: > > This patch adds timeout parameter to vm.wait() calls, because the default > value is just 30 seconds, and tests may last for more time. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/boot_linux_console.py |

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 03:48:50PM +, Daniel P. Berrangé wrote: > On Wed, Nov 11, 2020 at 02:36:15PM +, Stefan Hajnoczi wrote: > > On Tue, Nov 10, 2020 at 12:12:31PM +0100, Paolo Bonzini wrote: > > > On 10/11/20 10:53, Stefan Hajnoczi wrote: > > Yes, the current syntax supports sparse range

Re: [PATCH] contrib/libvhost-user: Fix bad printf format specifiers

2020-11-16 Thread Alex Chen
On 2020/11/16 17:52, Michael S. Tsirkin wrote: > It's in the latest pull weren't you Cc'd? > This is my fault, I see this patch in the latest pull. thank you!!! Thanks, Alex > On Mon, Nov 16, 2020 at 10:14:12AM +0800, Alex Chen wrote: >> Kindly ping... >> >> On 2020/11/4 18:23, AlexChen wrote:

Re: [RFC PATCH 1/5] hw/block: blk_check_size_and_read_all should report backend name

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/16/20 11:42 AM, David Edmondson wrote: > If there are problems examining or reading data from the block > backend, the error messages should include an appropriate identifier > to assist in diagnoses. > > Signed-off-by: David Edmondson > --- > hw/block/block.c | 14 +++--- > 1 file

Re: [PATCH v8 1/5] hw/block/nvme: remove superfluous NvmeCtrl parameter

2020-11-16 Thread Minwoo Im
On 11/12 20:59, Klaus Jensen wrote: > From: Klaus Jensen > > nvme_check_bounds has no use of the NvmeCtrl parameter; remove it. > > Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im

[PATCH] gitlab-ci.yml: Add openSUSE Tumbleweed and Leap for gitlab CI/CD

2020-11-16 Thread Yu-Chen, Cho
Add build-system-opensusetw and build-system-opensuse152 jobs and add opensuse152.docker and opensusetw.docker dockerfile. Use openSUSE Tumbleweed and openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Yu-Chen, Cho --- .gitlab-ci.d/containers.yml | 10 +++ .gitla

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Stefan Hajnoczi
On Wed, Nov 11, 2020 at 04:28:10PM +0100, Cornelia Huck wrote: > On Wed, 11 Nov 2020 15:10:14 + > Stefan Hajnoczi wrote: > > On Tue, Nov 10, 2020 at 01:14:04PM -0700, Alex Williamson wrote: > > > On Tue, 10 Nov 2020 09:53:49 + > > > Stefan Hajnoczi wrote: > > Or we could create a kobject

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Minwoo Im
On 11/12 20:59, Klaus Jensen wrote: > From: Klaus Jensen > > Add a new function, nvme_aio_err, to handle errors resulting from AIOs > and use this from the callbacks. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 61 + > 1 file change

Re: [RFC PATCH 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-16 Thread Philippe Mathieu-Daudé
Hi David, On 11/16/20 11:42 AM, David Edmondson wrote: > Currently ARM UEFI images are typically built as 2MB/768kB flash > images for code and variables respectively. These images are both then > padded out to 64MB before being loaded by QEMU. > > Because the images are 64MB each, QEMU allocates

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Daniel P . Berrangé
On Mon, Nov 16, 2020 at 11:15:24AM +, Stefan Hajnoczi wrote: > On Wed, Nov 11, 2020 at 03:48:50PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 11, 2020 at 02:36:15PM +, Stefan Hajnoczi wrote: > > > On Tue, Nov 10, 2020 at 12:12:31PM +0100, Paolo Bonzini wrote: > > > > On 10/11/20 10:53,

Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/16/20 7:42 AM, Markus Armbruster wrote: > "Chenqun (kuhn)" writes: > >>> -Original Message- >>> From: Chenzhendong (alex) >>> Sent: Friday, November 13, 2020 10:55 PM >>> To: arm...@redhat.com >>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; >>> qemu-triv...@nongnu.org; Zhanghai

Re: [PATCH v8 3/5] hw/block/nvme: add dulbe support

2020-11-16 Thread Minwoo Im
On 11/12 20:59, Klaus Jensen wrote: > From: Klaus Jensen > > Add support for reporting the Deallocated or Unwritten Logical Block > Error (DULBE). > > Rely on the block status flags reported by the block layer and consider > any block with the BDRV_BLOCK_ZERO flag to be deallocated. > > Multipl

Re: [PATCH-for-5.2 v3 6/7] ppc: Add a missing break for PPC6xx_INPUT_TBEN

2020-11-16 Thread Philippe Mathieu-Daudé
David, can you queue this patch for 5.2 (bugfix)? On 11/16/20 3:48 AM, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > hw/ppc/ppc.c:118:16: warning: this statement may fall through > [-Wimplicit-fallth

Re: [PATCH v8 4/5] nvme: add namespace I/O optimization fields to shared header

2020-11-16 Thread Minwoo Im
On 11/12 20:59, Klaus Jensen wrote: > From: Klaus Jensen > > This adds the NPWG, NPWA, NPDG, NPDA and NOWS family of fields to the > shared nvme.h header for use by later patches. > > Signed-off-by: Klaus Jensen > Cc: Stefan Hajnoczi > Cc: Fam Zheng > Reviewed-by: Stefan Hajnoczi Reviewed-b

Re: [PATCH v2 3/4] configure: Add a proper check for sys/ioccom.h and use it in tpm_ioctl.h

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/15/20 4:23 PM, Thomas Huth wrote: > On Solaris and Haiku, the _IO() macros are defined in . > Add a proper check for this header to our build system, and make sure > to include the header in tpm_ioctl.h to fix a build failure on Solaris > and Haiku. > > Signed-off-by: Thomas Huth > --- > v

Re: [PATCH 2/4] configure: Do not build pc-bios/optionrom on Haiku

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/14/20 5:51 PM, Thomas Huth wrote: > Compilation of pc-bios/optionrom fails on Haiku with: > >BUILD pvh.img > ld: pvh_main.o: in function `pvh_load_kernel': > pc-bios/optionrom/pvh_main.c:73: undefined reference to > `GLOBAL_OFFSET_TABLE_' > Makefile:57: recipe for target 'pvh.img'

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Klaus Jensen
On Nov 16 20:36, Minwoo Im wrote: > On 11/12 20:59, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add a new function, nvme_aio_err, to handle errors resulting from AIOs > > and use this from the callbacks. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 61 ++

Re: [PATCH v8 3/5] hw/block/nvme: add dulbe support

2020-11-16 Thread Klaus Jensen
On Nov 16 20:43, Minwoo Im wrote: > On 11/12 20:59, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add support for reporting the Deallocated or Unwritten Logical Block > > Error (DULBE). > > > > Rely on the block status flags reported by the block layer and consider > > any block with the BD

Want to run QEMU Advent Calendar 2020?

2020-11-16 Thread Stefan Hajnoczi
Hi, It's time for a QEMU Advent Calendar again where the QEMU community shares a disk image every day from December 1st to 24th. The advent calendar is a fun project we do to showcase cool disk images and QEMU. You can view previous years here: https://www.qemu-advent-calendar.org/ This year we ar

Re: [Bug 1904317] [NEW] cpu feature selection is not affected to guest 's cpuid with whpx

2020-11-16 Thread Philippe Mathieu-Daudé
Cc'ing Sunil (WHPX maintainer). On 11/15/20 10:06 AM, Takumi Nakamura wrote: > Public bug reported: > > On windows with -accel whpx, "-cpu" is ignored without any messages. > Guest recognizes features as same as host's. > > Confirmed on v5.2.0-rc1. > > I suggest qemu may do, > > - Warn with in

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Daniel P . Berrangé
On Mon, Nov 16, 2020 at 07:03:03AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2020 at 11:41:25AM +, Daniel P. Berrangé wrote: > > > It is possible to simplify the problem, but we'll lose freedom. For > > > example, hard coding knowledge of the device implementation into the > > > manag

Re: [PATCH-for-5.2 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/13/20 6:25 PM, Rebecca Cran wrote: > Update containers.yml to use the $CI_REGISTRY variable as other files > such as edk2.yml do. > > Signed-off-by: Rebecca Cran > --- > .gitlab-ci.d/containers.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitlab-ci.d/conta

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Michael S. Tsirkin
On Wed, Nov 11, 2020 at 03:48:50PM +, Daniel P. Berrangé wrote: > In terms of validation I can't help but feel the whole proposal is > really very complicated. > > In validating QEMU migration compatibility we merely compare the > versioned machine type. > > IIUC, in this proposal, it would

Re: [PATCH-for-5.2] io_uring: do not use pointer after free

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/13/20 4:41 PM, Paolo Bonzini wrote: > Even though only the pointer value is only printed, it is untidy > and Coverity complains. > > Cc: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > block/io_uring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe M

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2020 at 11:41:25AM +, Daniel P. Berrangé wrote: > > It is possible to simplify the problem, but we'll lose freedom. For > > example, hard coding knowledge of the device implementation into the > > management tool eliminates the need for a general migration checking > > algorith

RE: [PATCH v13 0/4] Add Versal usb model

2020-11-16 Thread Sai Pavan Boddu
Hi Peter > -Original Message- > From: Peter Maydell > Sent: Monday, November 16, 2020 3:49 PM > To: Sai Pavan Boddu > Cc: QEMU Developers ; Markus Armbruster > ; Marc-André Lureau ; > Paolo Bonzini ; Gerd Hoffmann ; > Edgar Iglesias ; Francisco Eduardo Iglesias > ; Alistair Francis ; Edua

Re: [RFC PATCH 03/25] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5)

2020-11-16 Thread Jonathan Cameron
On Tue, 10 Nov 2020 21:47:02 -0800 Ben Widawsky wrote: > A CXL 2.0 component is any entity in the CXL topology. All components > have a analogous function in PCIe. Except for the CXL host bridge, all > have a PCIe config space that is accessible via the common PCIe > mechanisms. CXL components ar

Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

2020-11-16 Thread Cornelia Huck
On Fri, 13 Nov 2020 17:10:22 -0500 Collin Walling wrote: [please remember to put qemu-devel on cc: as well] > The Control Program Name Code (CPNC) portion of the diag318 > info must be set within the SIE block of each VCPU in the > configuration. The handler will iterate through each VCPU > and

Re: [PATCH] gitlab-ci.yml: Add openSUSE Tumbleweed and Leap for gitlab CI/CD

2020-11-16 Thread Alex Bennée
Yu-Chen, Cho writes: > Add build-system-opensusetw and build-system-opensuse152 jobs and > add opensuse152.docker and opensusetw.docker dockerfile. > Use openSUSE Tumbleweed and openSUSE Leap 15.2 container image in the > gitlab-CI. > > Signed-off-by: Yu-Chen, Cho Hi, Could you split the TW

Re: [PATCH 1/3] quorum: Require WRITE perm with rewrite-corrupted

2020-11-16 Thread Alberto Garcia
On Fri 13 Nov 2020 10:17:16 PM CET, Max Reitz wrote: > Using rewrite-corrupted means quorum may issue writes to its children > just from receiving read requests from its parents. Thus, it must take > the WRITE permission when rewrite-corrupted is used. > > Signed-off-by: Max Reitz Reviewed-by: A

[PULL 3/9] meson.build: fix building of Xen support for aarch64

2020-11-16 Thread Alex Bennée
Xen is supported on ARM although weirdly using the i386-softmmu model. Checking based on the host CPU meant we never enabled Xen support. It would be nice to enable CONFIG_XEN for aarch64-softmmu to make it not seem weird but that will require further build surgery. Fixes: 8a19980e3f ("configure:

[PULL 2/9] plugins: Fix two resource leaks in setup_socket()

2020-11-16 Thread Alex Bennée
From: Alex Chen Either accept() fails or exits normally, we need to close the fd. Reported-by: Euler Robot Signed-off-by: Alex Chen Signed-off-by: Alex Bennée Message-Id: <20201109082829.87496-3-alex.c...@huawei.com> Message-Id: <20201110192316.26397-3-alex.ben...@linaro.org> diff --git a/co

[PULL 1/9] plugins: Fix resource leak in connect_socket()

2020-11-16 Thread Alex Bennée
From: Alex Chen Close the fd when the connect() fails. Reported-by: Euler Robot Signed-off-by: Alex Chen Signed-off-by: Alex Bennée Message-Id: <20201109082829.87496-2-alex.c...@huawei.com> Message-Id: <20201110192316.26397-2-alex.ben...@linaro.org> diff --git a/contrib/plugins/lockstep.c b/

[PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub

2020-11-16 Thread Alex Bennée
We should never build something that calls this without having it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-6-alex.ben...@linaro.org> diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 2ea8190921..15f3921a76 100644 --- a/stubs/xe

[PULL 6/9] accel/stubs: drop unused cpu.h include

2020-11-16 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-7-alex.ben...@linaro.org> diff --git a/accel/stubs/hax-stub.c b/accel/stubs/hax-stub.c index 1a9da83185..49077f88e3 100644 --- a/accel/stubs/hax-stub.c +++ b/accel/stubs/hax-stub.c @@ -14,7 +14,6 @@

[PULL 0/9] various fixes (CI, Xen, warnings)

2020-11-16 Thread Alex Bennée
The following changes since commit b50ea0d54bbca7d440315c3d0c0f7a4d6537b180: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20201113-1' into staging (2020-11-14 11:22:07 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-te

[PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé GCC 9.3.0 thinks that 'method' can be left uninitialized. This code is already in the "if (bsel || pcihp_bridge_en)" block statement, but it isn't smart enough to figure it out. Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)" block statement t

[PULL 8/9] tests/acceptance: Disable Spartan-3A DSP 1800A test

2020-11-16 Thread Alex Bennée
From: Philippe Mathieu-Daudé This test is regularly failing on CI: (05/34) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_microblaze_s3adsp1800: Linux version 4.11.3 (th...@thuth.remote.csb) (gcc version 6.4.0 (Buildroot 2018.05.2) ) #5 Tue Dec 11 11:56:23 CET 2018 ... F

[PULL 4/9] include/hw/xen.h: drop superfluous struct

2020-11-16 Thread Alex Bennée
Chardev is already a typedef'ed struct. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201110192316.26397-5-alex.ben...@linaro.org> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index 1406648ca5..0f9962b1c1 100644 --- a/include/hw/xen/xen.h +++ b/includ

[PULL 9/9] .gitlab-ci.d/check-patch: tweak output for CI logs

2020-11-16 Thread Alex Bennée
We don't need running commentary for the CI logs and by keeping it short we might just see the problem on the first page. While we are at it flush the previous line so order is maintained between script and sub process. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Message-Id: <2020

Re: [PULL 7/9] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2020 at 12:24:15PM +, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > GCC 9.3.0 thinks that 'method' can be left uninitialized. This code > is already in the "if (bsel || pcihp_bridge_en)" block statement, > but it isn't smart enough to figure it out. > > Restrict the

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2020 at 12:05:18PM +, Daniel P. Berrangé wrote: > On Mon, Nov 16, 2020 at 07:03:03AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 16, 2020 at 11:41:25AM +, Daniel P. Berrangé wrote: > > > > It is possible to simplify the problem, but we'll lose freedom. For > > > > e

Re: [PATCH for-5.2] iotests: Replace deprecated ConfigParser.readfp()

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/13/20 11:06 AM, Kevin Wolf wrote: > iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning > changes the output: > > nbd-fault-injector.py:230: DeprecationWarning: This method will be > removed in future versions. Use 'parser.read_file()' instead. > > In fact, rea

Re: [PATCH 01/10] qerror: Drop unused QERR_ macros

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/13/20 9:26 AM, Markus Armbruster wrote: > QERR_INVALID_BLOCK_FORMAT is dead since commit e6641719fe "block: > Always pass NULL as drv for bdrv_open()", 2015-09-14. > > QERR_INVALID_PASSWORD is dead since commit c01c214b69 "block: remove > all encryption handling APIs", 2017-07-11. > > Bury

Re: [PATCH] tests: add prefixes to the bare mkdtemp calls

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/13/20 2:34 PM, Alex Bennée wrote: > The first step to debug a thing is to know what created the thing in > the first place. Add some prefixes so random tmpdir's have something > grep in the code. > > Signed-off-by: Alex Bennée > --- > python/qemu/machine.py| 2 +- > tes

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Daniel P . Berrangé
On Mon, Nov 16, 2020 at 07:34:25AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 16, 2020 at 12:05:18PM +, Daniel P. Berrangé wrote: > > On Mon, Nov 16, 2020 at 07:03:03AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Nov 16, 2020 at 11:41:25AM +, Daniel P. Berrangé wrote: > > > > > I

Re: [PATCH v3 1/4] ssd0323: put it into the 'display' category

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/12/20 1:58 PM, Gan Qixin wrote: > The category of the ssd0323 device is not set, put it into the 'display' > category. > > Signed-off-by: Gan Qixin > Reviewed-by: Thomas Huth > --- > hw/display/ssd0323.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 3/4] nand: put it into the 'storage' category

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/12/20 1:58 PM, Gan Qixin wrote: > The category of the nand device is not set, put it into the 'storage' > category. > > Signed-off-by: Gan Qixin > Reviewed-by: Thomas Huth > --- > hw/block/nand.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 2/4] ads7846: put it into the 'input' category

2020-11-16 Thread Philippe Mathieu-Daudé
On 11/12/20 1:58 PM, Gan Qixin wrote: > The category of the ads7846 device is not set, put it into the 'input' > category. > > Signed-off-by: Gan Qixin > --- > Cc: Peter Maydell > --- > hw/display/ads7846.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC v3] VFIO Migration

2020-11-16 Thread Gerd Hoffmann
> > In validating QEMU migration compatibility we merely compare the > > versioned machine type. > > Thinking more about this, maybe the big picture is: > > Today the managment tool controls the variables in the migration (the > device configuration). It has knowledge of the VMM, can set a machin

  1   2   3   4   >