Re: [PATCH v3 5/7] virtiofsd: Announce sub-mount points

2020-11-03 Thread Miklos Szeredi
On Mon, Nov 2, 2020 at 5:19 PM Max Reitz wrote: > > Whenever we encounter a directory with an st_dev or mount ID that > differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so > the guest can create a submount for it. > > We only need to do so in lo_do_lookup(). The following funct

Re: [PATCH v3 0/7] virtiofsd: Announce submounts to the guest

2020-11-03 Thread Miklos Szeredi
On Mon, Nov 2, 2020 at 5:19 PM Max Reitz wrote: > > RFC: https://www.redhat.com/archives/virtio-fs/2020-May/msg00024.html > v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03598.html > v2: https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg09117.html > > Branch: https://gi

[PATCH for-5.2] meson: use b_staticpic=false for meson >=0.56.0

2020-11-03 Thread Paolo Bonzini
Meson 0.56.0 correctly builds non-PIC static libraries with -fPIE if b_pie=true. We do not have to pass b_staticpic=true if PIE is requested if Meson is new-enough, which improves performance. Signed-off-by: Paolo Bonzini --- configure | 6 +- meson.build | 4 ++-- 2 files changed, 7 inse

Re: VFIO Migration

2020-11-03 Thread Jason Wang
On 2020/11/2 下午7:11, Stefan Hajnoczi wrote: There is discussion about VFIO migration in the "Re: Out-of-Process Device Emulation session at KVM Forum 2020" thread. The current status is that Kirti proposed a VFIO device region type for saving and loading device state. There is currently no guid

Re: [PATCH v3 5/7] virtiofsd: Announce sub-mount points

2020-11-03 Thread Max Reitz
On 03.11.20 09:10, Miklos Szeredi wrote: > On Mon, Nov 2, 2020 at 5:19 PM Max Reitz wrote: >> >> Whenever we encounter a directory with an st_dev or mount ID that >> differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so >> the guest can create a submount for it. >> >> We only need

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Jason Wang
On 2020/11/3 上午2:51, Andrew Melnychenko wrote: Basic idea is to use eBPF to calculate and steer packets in TAP. RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash. eBPF RSS allows us to use RSS with vhost TAP. This set of patches int

Re: [PATCH v3 5/7] virtiofsd: Announce sub-mount points

2020-11-03 Thread Miklos Szeredi
On Tue, Nov 3, 2020 at 10:00 AM Max Reitz wrote: > > On 03.11.20 09:10, Miklos Szeredi wrote: > > On Mon, Nov 2, 2020 at 5:19 PM Max Reitz wrote: > >> > >> Whenever we encounter a directory with an st_dev or mount ID that > >> differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so

Re: [PATCH-for-5.2 v2] hw/virtio/vhost-backend: Fix Coverity CID 1432871

2020-11-03 Thread Stefano Garzarella
On Tue, Nov 03, 2020 at 07:35:41AM +0100, Philippe Mathieu-Daudé wrote: Fix uninitialized value issues reported by Coverity: Field 'msg.reserved' is uninitialized when calling write(). While the 'struct vhost_msg' does not have a 'reserved' field, we still initialize it to have the two parts

Re: [PATCH 1/6] target/xtensa: fix uninitialized variable warning

2020-11-03 Thread Max Filippov
On Mon, Nov 2, 2020 at 5:52 PM Chen Qun wrote: > > The compiler cannot determine whether the return values of the > xtensa_operand_is_register(isa, opc, opnd) > and xtensa_operand_is_visible(isa, opc, opnd) functions are the same. It doesn't have to because 1) they definitely are not the same,

Re: [PATCH] block/vvfat: Fix bad printf format specifiers

2020-11-03 Thread Kevin Wolf
Am 02.11.2020 um 12:52 hat AlexChen geschrieben: > We should use printf format specifier "%u" instead of "%d" for > argument of type "unsigned int". > In addition, fix two error format problems found by checkpatch.pl: > ERROR: space required after that ',' (ctx:VxV) > +fprintf(stderr,"%s at

[PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write()

2020-11-03 Thread AlexChen
According to the loongson spec (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf) and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know that the ISR size of per CORE is 8, so here we need to divide (addr - R_PERCORE_ISR(0)) by 8, not 4. Reported-by

Re: [PATCH] qemu-img: Make sure @sn_opts can be deleted in all error cases

2020-11-03 Thread Kevin Wolf
Am 02.11.2020 um 10:04 hat Tuguoyi geschrieben: > @sn_opts is initialized at the beginning, so it should be deleted > after jumping to the lable 'fail_getopt' > > Signed-off-by: Guoyi Tu Thanks, applied to the block branch. Kevin

[Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts

2020-11-03 Thread Daniel Berrange
This looks to me like a significant implementation flaw in the QEMU code. Both src and dst QEMU appear to be running code from the main event loop, and they appear to be doing blocking I/O operations. This is very bad as we should never have anything running in the main event loop thread that is ab

Re: [PATCH] block/vvfat: Fix bad printf format specifiers

2020-11-03 Thread AlexChen
On 2020/11/3 17:30, Kevin Wolf wrote: > Am 02.11.2020 um 12:52 hat AlexChen geschrieben: >> We should use printf format specifier "%u" instead of "%d" for >> argument of type "unsigned int". >> In addition, fix two error format problems found by checkpatch.pl: >> ERROR: space required after that ',

[PATCH V2] block/vvfat: Fix bad printf format specifiers

2020-11-03 Thread AlexChen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". In addition, fix two error format problems found by checkpatch.pl: ERROR: space required after that ',' (ctx:VxV) +fprintf(stderr,"%s attributes=0x%02x begin=%u size=%d\n",

[PATCH] scsi: allow user to set werror as report

2020-11-03 Thread Zihao Chang
'enospc' is the default for -drive, but qemu allows user to set drive option werror. If werror of scsi-generic is set to 'report' by user, qemu will not allow vm to start. This patch allow user to set werror as 'report' for scsi-generic. Signed-off-by: Zihao Chang --- hw/scsi/scsi-generic.c | 3

Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write()

2020-11-03 Thread Jiaxun Yang
在 2020/11/3 17:32, AlexChen 写道: According to the loongson spec (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf) and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know that the ISR size of per CORE is 8, so here we need to divide (addr - R_PERC

Re: [Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts

2020-11-03 Thread Zheng Chuan
On 2020/11/3 17:29, Daniel Berrange wrote: > This looks to me like a significant implementation flaw in the QEMU > code. Both src and dst QEMU appear to be running code from the main > event loop, and they appear to be doing blocking I/O operations. This is > very bad as we should never have any

Re: Call for Volunteers: Summaries of a few KVMForum-2020 talks for an LWN article

2020-11-03 Thread Kashyap Chamarthy
On Thu, Oct 29, 2020 at 03:27:07PM +0100, Kashyap Chamarthy wrote: > Hi, folks > > Like last year[1], we're aiming to submit a KVM Forum 2020 "recap" > article for LWN. > > This won't be a comprehensive summary of a lot of talks — LWN normally > aims for 1500 words; they say "fewer can sometimes

[PATCH] target/i386: tracing: format length values as hex

2020-11-03 Thread Dov Murik
Three trace events had a literal "0x" prefix but the 'len' values were formatted in decimal base. Keep the prefix and format the numbers as hex, as is usually the case for length of memory regions. Signed-off-by: Dov Murik --- target/i386/trace-events | 6 +++--- 1 file changed, 3 insertions(+)

Re: [PATCH 0/6] fix uninitialized variable warning

2020-11-03 Thread Peter Maydell
On Tue, 3 Nov 2020 at 02:07, Chen Qun wrote: > > Hi all, > There are some variables initialized warnings reported by the compiler, > even if the default CFLAG for the compiler parameters are uesed. > > This serial has added some default values or changed the assignment places > for the variabli

Re: [PULL 10/12] virtiofsd: Announce sub-mount points

2020-11-03 Thread Max Reitz
On 02.11.20 20:56, Dr. David Alan Gilbert (git) wrote: > From: Max Reitz > > Whenever we encounter a directory with an st_dev or mount ID that > differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so > the guest can create a submount for it. > > We only need to do so in lo_do_loo

[PATCH 3/3] hw/acpi : add spaces around operator

2020-11-03 Thread Xinhao Zhang
Fix code style. Operator needs spaces both sides. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- hw/acpi/pcihp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 32ae8b2c0a..17c32e0ffd 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi

[PATCH 1/3] hw/acpi : Don't use '#' flag of printf format

2020-11-03 Thread Xinhao Zhang
Fix code style. Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- hw/acpi/nvdimm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nv

Re: [PULL 10/12] virtiofsd: Announce sub-mount points

2020-11-03 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 02.11.20 20:56, Dr. David Alan Gilbert (git) wrote: > > From: Max Reitz > > > > Whenever we encounter a directory with an st_dev or mount ID that > > differs from that of its parent, we set the FUSE_ATTR_SUBMOUNT flag so > > the guest can create a submo

[PATCH 2/3] hw/acpi : add space before the open parenthesis '('

2020-11-03 Thread Xinhao Zhang
Fix code style. Space required before the open parenthesis '('. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- hw/acpi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index ade9158cbf..2c0c83221f 100644 --- a/hw/acpi/core.c +++

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Yuri Benditovich
On Tue, Nov 3, 2020 at 11:02 AM Jason Wang wrote: > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > Basic idea is to use eBPF to calculate and steer packets in TAP. > > RSS(Receive Side Scaling) is used to distribute network packets to guest > virtqueues > > by calculating packet hash. > > e

Re: [PULL 00/12] migration queue

2020-11-03 Thread Peter Maydell
On Mon, 2 Nov 2020 at 20:00, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit b139d11ae198aba0e009daddf7a3370ce84b2d09: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20201102' into > staging (2020-11-02 16:05:47 +00

Re: [PULL 5/7] tests.acceptance: adds simple migration test

2020-11-03 Thread Philippe Mathieu-Daudé
Hi, On Fri, Feb 22, 2019 at 8:42 PM Cleber Rosa wrote: > > From: Caio Carrara > > This change adds the simplest possible migration test. Beyond the test > purpose itself it's also useful to exercise the multi virtual machines > capabilities from base avocado qemu test class. > > Signed-off-by: C

Re: [PATCH] target/i386: tracing: format length values as hex

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/3/20 11:07 AM, Dov Murik wrote: > Three trace events had a literal "0x" prefix but the 'len' values were > formatted in decimal base. Keep the prefix and format the numbers as > hex, as is usually the case for length of memory regions. > > Signed-off-by: Dov Murik > --- > target/i386/trac

RE: [PATCH 0/6] fix uninitialized variable warning

2020-11-03 Thread Chenqun (kuhn)
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, November 3, 2020 6:15 PM > To: Chenqun (kuhn) > Cc: QEMU Developers ; QEMU Trivial > ; Zhanghailiang > ; ganqixin > Subject: Re: [PATCH 0/6] fix uninitialized variable warning > > On Tue, 3 Nov

Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count

2020-11-03 Thread Cornelia Huck
On Tue, 3 Nov 2020 06:49:13 +0100 Philippe Mathieu-Daudé wrote: > Hi Matthew, > > On 11/1/20 10:02 PM, Alex Williamson wrote: > > From: Matthew Rosato > > > > Create new files for separating out vfio-specific work for s390 > > pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO >

[RFC PATCH] docs: add some notes on the sbsa-ref machine

2020-11-03 Thread Alex Bennée
We should at least document what this machine is about. Cc: Graeme Gregory Cc: Leif Lindholm Cc: Hongbo Zhang Cc: Shashi Mallela Signed-off-by: Alex Bennée --- docs/system/arm/sbsa.rst | 30 ++ docs/system/target-arm.rst | 1 + 2 files changed, 31 insertions(+)

Re: [PATCH] scsi: allow user to set werror as report

2020-11-03 Thread Fam Zheng
On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote: > 'enospc' is the default for -drive, but qemu allows user to set > drive option werror. If werror of scsi-generic is set to 'report' > by user, qemu will not allow vm to start. > > This patch allow user to set werror as 'report' for scsi-gener

Re: [RFC PATCH] docs: add some notes on the sbsa-ref machine

2020-11-03 Thread Graeme Gregory
On Tue, Nov 03, 2020 at 10:47:10AM +, Alex Bennée wrote: > We should at least document what this machine is about. > Looks good to me. Reviewed-by: Graeme Gregory > Cc: Graeme Gregory > Cc: Leif Lindholm > Cc: Hongbo Zhang > Cc: Shashi Mallela > Signed-off-by: Alex Bennée > --- > docs

Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/3/20 11:45 AM, Cornelia Huck wrote: > On Tue, 3 Nov 2020 06:49:13 +0100 > Philippe Mathieu-Daudé wrote: > >> Hi Matthew, >> >> On 11/1/20 10:02 PM, Alex Williamson wrote: >>> From: Matthew Rosato >>> >>> Create new files for separating out vfio-specific work for s390 >>> pci. Add the first

Re: VFIO Migration

2020-11-03 Thread Stefan Hajnoczi
On Mon, Nov 02, 2020 at 12:38:23PM -0700, Alex Williamson wrote: > > Cc+ Intel folks as this really bumps into the migration compatibility > discussion[1][2][3] > > On Mon, 2 Nov 2020 11:11:53 + > Stefan Hajnoczi wrote: > > > There is discussion about VFIO migration in the "Re: Out-of-Proce

Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/3/20 11:45 AM, Cornelia Huck wrote: > On Tue, 3 Nov 2020 06:49:13 +0100 > Philippe Mathieu-Daudé wrote: > >> Hi Matthew, >> >> On 11/1/20 10:02 PM, Alex Williamson wrote: >>> From: Matthew Rosato >>> >>> Create new files for separating out vfio-specific work for s390 >>> pci. Add the first

Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count

2020-11-03 Thread Cornelia Huck
On Tue, 3 Nov 2020 12:08:20 +0100 Philippe Mathieu-Daudé wrote: > On 11/3/20 11:45 AM, Cornelia Huck wrote: > > On Tue, 3 Nov 2020 06:49:13 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> Hi Matthew, > >> > >> On 11/1/20 10:02 PM, Alex Williamson wrote: > >>> From: Matthew Rosato > >>> >

Re: About 'qemu-security' mailing list

2020-11-03 Thread P J P
+-- On Tue, 20 Oct 2020, P J P wrote --+ | +-- On Fri, 16 Oct 2020, P J P wrote --+ | | * So ie. we need to: | | | | 1. Create/setup a regular non-encrypted 'qemu-security' list. | | | | 2. Invite representatives from user/downstream communities to subscribe to | | it. | | | | 3. Co

Re: [RFC PATCH] docs: add some notes on the sbsa-ref machine

2020-11-03 Thread Leif Lindholm
On Tue, Nov 03, 2020 at 10:47:10 +, Alex Bennée wrote: > We should at least document what this machine is about. Thanks! (comments below) > Cc: Graeme Gregory > Cc: Leif Lindholm > Cc: Hongbo Zhang > Cc: Shashi Mallela > Signed-off-by: Alex Bennée > --- > docs/system/arm/sbsa.rst | 30

[PATCH] meson: vhost-user-gpu/virtiofsd: use absolute path

2020-11-03 Thread Marc Hartmayer
The option `libexecdir` is relative to `prefix` (see https://mesonbuild.com/Builtin-options.html), so we have to be aware of this when creating 50-qemu-gpu.json and 50-qemu-virtiofsd.json. Otherwise, tools like libvirt will not be able to find the executable. Fixes: 16bf7a3326d8 ("configure: move

[PATCH-for-5.2 0/4] misc: Trivial format string fixes

2020-11-03 Thread Philippe Mathieu-Daudé
IIUC qemu-trivial@ doesn't queue patches during freeze, so it might be easier if patches are queued by respective subsystem maintainers. Philippe Mathieu-Daudé (4): hw/display/cirrus_vga: Remove debugging code commented out hw/display/cirrus_vga: Fix hexadecimal format string specifier hw/pp

[PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier

2020-11-03 Thread Philippe Mathieu-Daudé
The '%u' conversion specifier is for decimal notation. When prefixing a format with '0x', we want the hexadecimal specifier ('%x'). Inspired-by: Dov Murik Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dis

[PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out

2020-11-03 Thread Philippe Mathieu-Daudé
Commit ec87f206d70 ("cirrus: replace debug printf with trace points") forgot to remove this code once replaced. Do it now. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cirrus_vga.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display

[PATCH-for-5.2 3/4] hw/ppc/spapr_tpm_proxy: Fix hexadecimal format string specifier

2020-11-03 Thread Philippe Mathieu-Daudé
The '%u' conversion specifier is for decimal notation. When prefixing a format with '0x', we want the hexadecimal specifier ('%x'). Inspired-by: Dov Murik Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/tra

[PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier

2020-11-03 Thread Philippe Mathieu-Daudé
The '%u' conversion specifier is for decimal notation. When prefixing a format with '0x', we want the hexadecimal specifier ('%x'). Inspired-by: Dov Murik Signed-off-by: Philippe Mathieu-Daudé --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.

Re: [PATCH] meson: vhost-user-gpu/virtiofsd: use absolute path

2020-11-03 Thread Marc Hartmayer
On Tue, Nov 03, 2020 at 12:23 PM +0100, Marc Hartmayer wrote: > The option `libexecdir` is relative to `prefix` (see > https://mesonbuild.com/Builtin-options.html), so we have to be aware > of this when creating 50-qemu-gpu.json and > 50-qemu-virtiofsd.json. Otherwise, tools like libvirt will not

Re: [PATCH-for-5.2] MAINTAINERS: Demote Renesas target & hardware to 'Odd Fixes'

2020-11-03 Thread Thomas Huth
On 02/11/2020 11.40, Philippe Mathieu-Daudé wrote: > To be fair with other subsystems listed as 'Odd Fixes' but having > maintainers more present, demote the Renesas sections from being > 'Maintained' to 'Odd Fixes' (has a maintainer but they don't have > time to do much other than throw the odd pa

Re: [PULL 00/26] target-arm queue

2020-11-03 Thread Peter Maydell
On Mon, 2 Nov 2020 at 17:10, Peter Maydell wrote: > > > Small pile of bug fixes for rc1. I've included my patches to get > our docs building with Sphinx 3, just for convenience... > > -- PMM > > The following changes since commit b149dea55cce97cb226683d06af61984a1c11e96: > > Merge remote-trackin

Re: VFIO Migration

2020-11-03 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 11:11:53AM +, Stefan Hajnoczi wrote: > There is discussion about VFIO migration in the "Re: Out-of-Process > Device Emulation session at KVM Forum 2020" thread. The current status > is that Kirti proposed a VFIO device region type for saving and loading > device state. T

Re: [PATCH-for-5.2 3/4] hw/ppc/spapr_tpm_proxy: Fix hexadecimal format string specifier

2020-11-03 Thread Greg Kurz
On Tue, 3 Nov 2020 12:25:57 +0100 Philippe Mathieu-Daudé wrote: > The '%u' conversion specifier is for decimal notation. > When prefixing a format with '0x', we want the hexadecimal > specifier ('%x'). > > Inspired-by: Dov Murik > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Greg

[PATCH] target/openrisc: Remove dead code attempting to check "is timer disabled"

2020-11-03 Thread Peter Maydell
In the mtspr helper we attempt to check for "is the timer disabled" with "if (env->ttmr & TIMER_NONE)". This is wrong because TIMER_NONE is zero and the condition is always false (Coverity complains about the dead code.) The correct check would be to test whether the TTMR_M field in the register

[PATCH 1/3] target/arm: add spaces around operator

2020-11-03 Thread Xinhao Zhang
Fix code style. Operator needs spaces both sides. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- target/arm/arch_dump.c | 8 target/arm/arm-semi.c | 8 target/arm/helper.c| 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/target/arm/arch_dump.

[PATCH 2/3] target/arm: Don't use '#' flag of printf format

2020-11-03 Thread Xinhao Zhang
Fix code style. Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- target/arm/translate-a64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/ar

[PATCH] hw/arm/nseries: Check return value from load_image_targphys()

2020-11-03 Thread Peter Maydell
The nseries machines have a codepath that allows them to load a secondary bootloader. This code wasn't checking that the load_image_targphys() succeeded. Check the return value and report the error to the user. While we're in the vicinity, fix the comment style of the comment documenting what th

[PATCH 3/3] target/arm: add space before the open parenthesis '('

2020-11-03 Thread Xinhao Zhang
Fix code style. Space required before the open parenthesis '('. Signed-off-by: Xinhao Zhang Signed-off-by: Kai Deng --- target/arm/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 38371db540..efa3b59d04 100644

[PATCH] tests/qtest/libqtest.c: Check for setsockopt() failure

2020-11-03 Thread Peter Maydell
In socket_accept() we use setsockopt() to set SO_RCVTIMEO, but we don't check the return value for failure. Do so. Fixes: Coverity CID 1432321 Signed-off-by: Peter Maydell --- tests/qtest/libqtest.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qtest/libqtest

[PATCH] tests/qtest/libqos/ahci.c: Avoid NULL dereference in ahci_exec()

2020-11-03 Thread Peter Maydell
In ahci_exec() we attempt to permit the caller to pass a NULL pointer for opts_in (in which case we use a default set of options). However although we check for NULL when setting up the opts variable at the top of the function, we unconditionally dereference opts_in at the end of the function as p

Re: [PATCH] meson: vhost-user-gpu/virtiofsd: use absolute path

2020-11-03 Thread Paolo Bonzini
On 03/11/20 12:28, Marc Hartmayer wrote: > On Tue, Nov 03, 2020 at 12:23 PM +0100, Marc Hartmayer > wrote: >> The option `libexecdir` is relative to `prefix` (see >> https://mesonbuild.com/Builtin-options.html), so we have to be aware >> of this when creating 50-qemu-gpu.json and >> 50-qemu-virti

Re: [PATCH] tests/qtest/libqtest.c: Check for setsockopt() failure

2020-11-03 Thread Paolo Bonzini
On 03/11/20 12:51, Peter Maydell wrote: > In socket_accept() we use setsockopt() to set SO_RCVTIMEO, > but we don't check the return value for failure. Do so. > > Fixes: Coverity CID 1432321 > Signed-off-by: Peter Maydell > --- > tests/qtest/libqtest.c | 9 +++-- > 1 file changed, 7 insertio

Re: [PATCH] tests/qtest/libqos/ahci.c: Avoid NULL dereference in ahci_exec()

2020-11-03 Thread Paolo Bonzini
On 03/11/20 12:52, Peter Maydell wrote: > In ahci_exec() we attempt to permit the caller to pass a NULL pointer > for opts_in (in which case we use a default set of options). However > although we check for NULL when setting up the opts variable at the > top of the function, we unconditionally der

Re: [RFC PATCH 0/6] eBPF RSS support for virtio-net

2020-11-03 Thread Daniel P . Berrangé
On Tue, Nov 03, 2020 at 12:32:43PM +0200, Yuri Benditovich wrote: > On Tue, Nov 3, 2020 at 11:02 AM Jason Wang wrote: > > > > > On 2020/11/3 上午2:51, Andrew Melnychenko wrote: > > > Basic idea is to use eBPF to calculate and steer packets in TAP. > > > RSS(Receive Side Scaling) is used to distribu

Re: [PATCH v2 0/2] Assorted fixes to tests that were broken by recent scsi changes

2020-11-03 Thread Christian Borntraeger
On 01.11.20 17:15, Maxim Levitsky wrote: > While most of the patches in V1 of this series are already merged upstream, > the patch that fixes iotest 240 was broken on s390 and was not accepted. > > This is an updated version of this patch, based on Paulo's suggestion, > that hopefully mak

Re: [RFC PATCH] docs: add some notes on the sbsa-ref machine

2020-11-03 Thread Peter Maydell
On Tue, 3 Nov 2020 at 10:47, Alex Bennée wrote: > > We should at least document what this machine is about. typo and grammar nits only: > +Supported devices > +" > + > +The sbsa-ref board supports: > + > + - A configurable number of Cortex-A57 cpus "CPUs" (Also if you take Lei

Re: [PATCH] meson: vhost-user-gpu/virtiofsd: use absolute path

2020-11-03 Thread Marc Hartmayer
On Tue, Nov 03, 2020 at 12:55 PM +0100, Paolo Bonzini wrote: > On 03/11/20 12:28, Marc Hartmayer wrote: >> On Tue, Nov 03, 2020 at 12:23 PM +0100, Marc Hartmayer >> wrote: >>> The option `libexecdir` is relative to `prefix` (see >>> https://mesonbuild.com/Builtin-options.html), so we have to be

Re: [PATCH] hw/9pfs: virtio-9p: Ensure config space is a multiple of 4 bytes

2020-11-03 Thread Michael S. Tsirkin
On Tue, Nov 03, 2020 at 02:26:10PM +0800, Bin Meng wrote: > Hi Michael, > > On Fri, Oct 30, 2020 at 5:29 PM Michael S. Tsirkin wrote: > > > > On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote: > > > From: Bin Meng > > > > > > At present the virtio device config space access is handled by

Re: [PATCH] s390-bios: Skip writing iplb location to low core for ccw ipl

2020-11-03 Thread Christian Borntraeger
On 30.10.20 13:28, Christian Borntraeger wrote: > From: "Jason J. Herne" > > The architecture states that the iplb location is only written to low > core for list directed ipl and not for traditional ccw ipl. If we don't > skip this then operating systems that load by reading into low core > memo

Re: VFIO Migration

2020-11-03 Thread Stefan Hajnoczi
On Tue, Nov 03, 2020 at 04:46:53PM +0800, Jason Wang wrote: > > On 2020/11/2 下午7:11, Stefan Hajnoczi wrote: > > There is discussion about VFIO migration in the "Re: Out-of-Process > > Device Emulation session at KVM Forum 2020" thread. The current status > > is that Kirti proposed a VFIO device re

Re: VFIO Migration

2020-11-03 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > There is discussion about VFIO migration in the "Re: Out-of-Process > Device Emulation session at KVM Forum 2020" thread. The current status > is that Kirti proposed a VFIO device region type for saving and loading > device state. There is currently

Re: [PATCH v3 0/9] block-backend: Introduce I/O hang

2020-11-03 Thread cenjiahui
On 2020/10/30 21:21, Stefan Hajnoczi wrote: > On Thu, Oct 29, 2020 at 05:42:42PM +0800, cenjiahui wrote: >> >> On 2020/10/27 0:53, Stefan Hajnoczi wrote: >>> On Thu, Oct 22, 2020 at 09:02:54PM +0800, Jiahui Cen wrote: A VM in the cloud environment may use a virutal disk as the backend

[PATCH v9 5/8] acpi: Align the size to 128k

2020-11-03 Thread Jiahui Cen
From: Yubo Miao If table size is changed between virt_acpi_build and virt_acpi_build_update, the table size would not be updated to UEFI, therefore, just align the size to 128kb, which is enough and same with x86. It would warn if 64k is not enough and the align size should be updated. Signed-of

[PATCH v9 3/8] acpi: Extract crs build form acpi_build.c

2020-11-03 Thread Jiahui Cen
From: Yubo Miao Extract crs build form acpi_build.c, the function could also be used to build the crs for pxbs for arm. The resources are composed by two parts: 1. The bar space of pci-bridge/pcie-root-ports 2. The resources needed by devices behind PXBs. The base and limit of memory/io are obtai

[PATCH v9 0/8] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-11-03 Thread Jiahui Cen
Changes with v8 v8->v9: Rebase to master Changes with v7 v7->v8: Fix the error:no member named 'fw_cfg' in 'struct PCMachineState' Changes with v6 v6->v7: Refactor fw_cfg_write_extra_pci_roots Add API PCI_GET_PCIE_HOST_STATE Fix typos Changes with v5 v5->v6: stat crs_range_insert in aml_build.h

[PATCH v9 8/8] unit-test: Add the binary file and clear diff.h

2020-11-03 Thread Jiahui Cen
From: Yubo Miao Add the binary file DSDT.pxb and clear bios-tables-test-allowed-diff.h Signed-off-by: Yubo Miao Signed-off-by: Jiahui Cen --- tests/data/acpi/virt/DSDT.pxb | Bin 0 -> 7802 bytes tests/qtest/bios-tables-test-allowed-diff.h | 1 - 2 files changed, 1 deletion(-)

[PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

2020-11-03 Thread Jiahui Cen
From: Yubo Miao Write the extra roots into the fw_cfg, therefore the uefi could get the extra roots. Only if the uefi knows there are extra roots, the config space of devices behind the root could be obtained. Signed-off-by: Yubo Miao Signed-off-by: Jiahui Cen --- hw/arm/virt.c |

[PATCH v9 1/8] acpi: Extract two APIs from acpi_dsdt_add_pci

2020-11-03 Thread Jiahui Cen
From: Yubo Miao Extract two APIs acpi_dsdt_add_pci_route_table and acpi_dsdt_add_pci_osc from acpi_dsdt_add_pci. The first API is used to specify the pci route table and the second API is used to declare the operation system capabilities. These two APIs would be used to specify the pxb-pcie in DS

[PATCH v9 6/8] unit-test: The files changed.

2020-11-03 Thread Jiahui Cen
From: Yubo Miao The unit-test is seperated into three patches: 1. The files changed and list in bios-tables-test-allowed-diff.h 2. The unit-test 3. The binary file and clear bios-tables-test-allowed-diff.h The ASL diff would also be listed. Sice there are 1000+lines diff, some changes would be o

[PATCH v9 7/8] unit-test: Add testcase for pxb

2020-11-03 Thread Jiahui Cen
From: Yubo Miao Add testcase for pxb to make sure the ACPI table is correct for guest. Signed-off-by: Yubo Miao Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test.c | 58 ++ 1 file changed, 52 insertions(+), 6 deletions(-) diff --git a/tests/qtest/bios

Re: [PATCH 1/3] hw/acpi : Don't use '#' flag of printf format

2020-11-03 Thread Igor Mammedov
On Tue, 3 Nov 2020 18:26:32 +0800 Xinhao Zhang wrote: > Fix code style. Don't use '#' flag of printf format ('%#') in > format strings, use '0x' prefix instead > > Signed-off-by: Xinhao Zhang > Signed-off-by: Kai Deng Reviewed-by: Igor Mammedov --- PS: in future please use --cover-letter wh

[PATCH v9 4/8] acpi: Refactor the source of host bridge and build tables for pxb

2020-11-03 Thread Jiahui Cen
From: Yubo Miao The resources of pxbs are obtained by crs_build and the resources used by pxbs would be moved from the resources defined for host-bridge. The resources for pxb are composed of following two parts: 1. The bar space of the pci-bridge/pcie-root-port behined it 2. The config space of

Re: [PATCH 2/3] hw/acpi : add space before the open parenthesis '('

2020-11-03 Thread Igor Mammedov
On Tue, 3 Nov 2020 18:26:33 +0800 Xinhao Zhang wrote: > Fix code style. Space required before the open parenthesis '('. > > Signed-off-by: Xinhao Zhang > Signed-off-by: Kai Deng Reviewed-by: Igor Mammedov > --- > hw/acpi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message

2020-11-03 Thread Igor Mammedov
On Fri, 30 Oct 2020 16:21:27 -0400 Eduardo Habkost wrote: > object_property_parse() will add a > "Property '.' can't take value ''" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Xiao Guangrong > Cc: "Michael S. Tsirkin" > Cc: Igo

Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write()

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/3/20 10:32 AM, AlexChen wrote: > According to the loongson spec > (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf) > and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know > that the ISR size of per CORE is 8, so here we need to divide > (add

Re: [PATCH 3/3] hw/acpi : add spaces around operator

2020-11-03 Thread Igor Mammedov
On Tue, 3 Nov 2020 18:26:34 +0800 Xinhao Zhang wrote: > Fix code style. Operator needs spaces both sides. > > Signed-off-by: Xinhao Zhang > Signed-off-by: Kai Deng Reviewed-by: Igor Mammedov > --- > hw/acpi/pcihp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/h

Re: [PATCH] s390-bios: Skip writing iplb location to low core for ccw ipl

2020-11-03 Thread Thomas Huth
On 30/10/2020 13.28, Christian Borntraeger wrote: > From: "Jason J. Herne" > > The architecture states that the iplb location is only written to low > core for list directed ipl and not for traditional ccw ipl. If we don't > skip this then operating systems that load by reading into low core > me

Re: [PATCH 10/20] memfd: Remove unnecessary prefix from error message

2020-11-03 Thread Igor Mammedov
On Fri, 30 Oct 2020 16:21:21 -0400 Eduardo Habkost wrote: > object_property_parse() will add a > "Property '.' can't take value ''" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: qemu-deve

Re: [PATCH] s390-bios: Skip writing iplb location to low core for ccw ipl

2020-11-03 Thread Cornelia Huck
On Tue, 3 Nov 2020 13:32:47 +0100 Thomas Huth wrote: > On 30/10/2020 13.28, Christian Borntraeger wrote: > > From: "Jason J. Herne" > > > > The architecture states that the iplb location is only written to low > > core for list directed ipl and not for traditional ccw ipl. If we don't > > skip

[PATCH for-5.2] s390x: fix build for --without-default-devices

2020-11-03 Thread Cornelia Huck
s390-pci-vfio.c calls into the vfio code, so we need it to be built conditionally on vfio (which implies CONFIG_LINUX). Reported-by: Philippe Mathieu-Daudé Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count") Signed-off-by: Cornelia Huck --- hw/s390x/meson.build

Re: [PATCH] vnc: fix resource leak when websocket channel error

2020-11-03 Thread Gerd Hoffmann
On Thu, Oct 29, 2020 at 11:22:41AM +0800, Ding Hui wrote: > When we connect to vnc by websocket channel, and disconnect > (maybe by some network exception) before handshake, > qemu will left CLOSE_WAIT socket and never close it Added to fixes queue. thanks, Gerd

Re: [PATCH 01/20] qom: Add prefix to error message inside object_property_parse()

2020-11-03 Thread Igor Mammedov
On Fri, 30 Oct 2020 16:21:12 -0400 Eduardo Habkost wrote: > Make object_property_parse() automatically add a error message > prefix mentioning the QOM type and property name when > encountering errors. > > As we have a large number of functions that add their own > "Property '...'" to the error

Re: Question on UEFI ACPI tables setup and probing on arm64

2020-11-03 Thread Igor Mammedov
On Fri, 30 Oct 2020 10:50:01 +0800 Ying Fang wrote: > Hi, > > I have a question on UEFI/ACPI tables setup and probing on arm64 platform. CCing Laszlo, who might know how it's implemented. > Currently on arm64 platform guest can be booted with both fdt and ACPI > supported. If ACPI is enabled,

Re: [PATCH 14/20] i386: Remove unnecessary prefix from error message

2020-11-03 Thread Igor Mammedov
On Fri, 30 Oct 2020 16:21:25 -0400 Eduardo Habkost wrote: > object_property_parse() will add a > "Property '.' can't take value ''" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo

Re: [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out

2020-11-03 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Commit ec87f206d70 ("cirrus: replace debug printf with trace points") > forgot to remove this code once replaced. Do it now. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > hw/display/cirrus_vga.c |

Re: [PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier

2020-11-03 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > The '%u' conversion specifier is for decimal notation. > When prefixing a format with '0x', we want the hexadecimal > specifier ('%x'). > > Inspired-by: Dov Murik > Signed-off-by: Philippe Mathieu-Daudé Oh that's nice, one my regex wouldn'

Re: [PATCH-for-5.2 4/4] migration/ram: Fix hexadecimal format string specifier

2020-11-03 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > The '%u' conversion specifier is for decimal notation. > When prefixing a format with '0x', we want the hexadecimal > specifier ('%x'). > > Inspired-by: Dov Murik > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert

Re: [PATCH V16 2/6] target/mips: Add unaligned access support for MIPS64R6 and Loongson-3

2020-11-03 Thread Philippe Mathieu-Daudé
On 10/30/20 11:25 AM, Huacai Chen wrote: > MIPSR6 (not only MIPS32R6) processors support unaligned access in > hardware, so set MO_UNALN in their default_tcg_memop_mask. Btw, new > Loongson-3 (such as Loongson-3A4000) also support unaligned access, > since both old and new Loongson-3 use the same b

Re: [PATCH v2 2/2] iotests: rewrite iotest 240 in python

2020-11-03 Thread Max Reitz
On 01.11.20 17:15, Maxim Levitsky wrote: > The recent changes that brought RCU delayed device deletion, > broke few tests and this test breakage went unnoticed. > > Fix this test by rewriting it in python > (which allows to wait for DEVICE_DELETED events before continuing). > > Signed-off-by: Max

Re: [PATCH 5/30] mips tcg: Fix Lesser GPL version number

2020-11-03 Thread Philippe Mathieu-Daudé
On 10/16/20 4:35 PM, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH] hw/intc: Fix incorrect calculation of core in liointc_read() and liointc_write()

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/3/20 10:32 AM, AlexChen wrote: > According to the loongson spec > (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf) > and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know > that the ISR size of per CORE is 8, so here we need to divide > (add

  1   2   3   4   5   6   >