On 03/11/20 12:51, Peter Maydell wrote: > In socket_accept() we use setsockopt() to set SO_RCVTIMEO, > but we don't check the return value for failure. Do so. > > Fixes: Coverity CID 1432321 > Signed-off-by: Peter Maydell <[email protected]> > --- > tests/qtest/libqtest.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index 99deff47efc..be0fb430ddd 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -110,8 +110,13 @@ static int socket_accept(int sock) > struct timeval timeout = { .tv_sec = SOCKET_TIMEOUT, > .tv_usec = 0 }; > > - setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)&timeout, > - sizeof(timeout)); > + if (qemu_setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, > + (void *)&timeout, sizeof(timeout))) { > + fprintf(stderr, "%s failed to set SO_RCVTIMEO: %s\n", > + __func__, strerror(errno)); > + close(sock); > + return -1; > + } > > do { > addrlen = sizeof(addr); >
Queued, thanks. Paolo
