On 13/10/2020 16.05, Jason Andryuk wrote:
> dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition
> will never evaluate true. Remove it.
>
> Signed-off-by: Jason Andryuk
> ---
> v2: New in v2
> ---
> accel/qtest/qtest-cpus.c | 5 -
> 1 file changed, 5 deletions(-)
>
> di
On 13/10/2020 16.05, Jason Andryuk wrote:
> Move and rename accel/qtest/qtest-cpus.c files to accel/dummy-cpus.c so
> it can be re-used by Xen.
>
> Signed-off-by: Jason Andryuk
>
> ---
> v2:
> - Use accel/dummy-cpus.c
> - Put prototype in include/sysemu/cpus.h
> ---
> accel/{qtest/qtest-cpus.
On 22/10/2020 17.29, Paolo Bonzini wrote:
> On 22/10/20 17:17, Jason Andryuk wrote:
>> On Tue, Oct 13, 2020 at 1:16 PM Paolo Bonzini wrote:
>>>
>>> On 13/10/20 16:05, Jason Andryuk wrote:
Xen was left behind when CpusAccel became mandatory and fails the assert
in qemu_init_vcpu(). It re
Bring new microvm goodies to arm virt too. Wire up
-machine usb=on, add sysbus-xhci in case it is enabled.
Gerd Hoffmann (8):
tests/acpi: allow updates for expected data files
tests/acpi: add empty tests/data/acpi/virt/DSDT.usb file
arm/virt: add support for -machine usb=on
arm/virt: add
Signed-off-by: Gerd Hoffmann
---
tests/data/acpi/microvm/DSDT.usb | Bin 414 -> 426 bytes
tests/data/acpi/virt/DSDT.usb| Bin 0 -> 5257 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/tests/data/acpi/microvm/DSDT.usb b/tests/data/acpi/microvm/DSDT.usb
index
14423381ea235
Signed-off-by: Gerd Hoffmann
---
tests/data/acpi/virt/DSDT.usb | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 tests/data/acpi/virt/DSDT.usb
diff --git a/tests/data/acpi/virt/DSDT.usb b/tests/data/acpi/virt/DSDT.usb
new file mode 100644
index ..e69de29bb2d1
-
Wire up sysbus-xhci in case usb is enabled.
Signed-off-by: Gerd Hoffmann
---
include/hw/arm/virt.h | 1 +
hw/arm/virt.c | 23 +++
hw/arm/Kconfig| 1 +
3 files changed, 25 insertions(+)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index aad6d69
Also tweak xhci_sysbus_build_aml, add _UID and _CCA.
Without _CCA the linux kernel's xhci probe fails on arm.
ASL changes:
Device (XHCI)
{
Name (_HID, EisaId ("PNP0D10") /* XHCI USB Controller with debug
*/) // _HID: Hardware ID
+Name (_UID, Zero) //
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..5d523ded1282 100644
--- a/tests/qtest/bios-tables-test-
Signed-off-by: Gerd Hoffmann
---
hw/arm/virt.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index f2b34fd33be4..4319dd95ef78 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -812,7 +812,10 @@ static void create_rtc(const VirtMachineState *vms)
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 3830a40d1041..438cea38a177 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bi
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index 5d523ded1282..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-a
On 10/23/2020 12:21 AM, Alex Williamson wrote:
On Thu, 22 Oct 2020 16:41:57 +0530
Kirti Wankhede wrote:
Define flags to be used as delimiter in migration stream for VFIO devices.
Added .save_setup and .save_cleanup functions. Map & unmap migration
region from these functions at source durin
On 23/10/2020 08.12, Chen Qun wrote:
> From: Pan Nengyuan
>
> Missing g_error_free in QEMU_Elf_init() error path. Fix that.
>
> Reported-by: Euler Robot
> Signed-off-by: Pan Nengyuan
> Reviewed-by: Viktor Prutyanov
> Reviewed-by: Li Qiang
> Signed-off-by: Chen Qun
> ---
> contrib/elf2dmp/q
On 23/10/2020 08.12, Chen Qun wrote:
> From: Pan Nengyuan
>
> Missing g_error_free in pdb_init_from_file() error path. Fix that.
>
> Reported-by: Euler Robot
> Signed-off-by: Pan Nengyuan
> Reviewed-by: Viktor Prutyanov
> Reviewed-by: Li Qiang
> Signed-off-by: Chen Qun
> ---
> contrib/elf2
On 22/10/2020 22.29, Laurent Vivier wrote:
> They are unused since the target has been converted to TCG.
>
> Fixes: e1f3808e03f7 ("Convert m68k target to TCG.")
> Signed-off-by: Laurent Vivier
> ---
> target/m68k/cpu.h | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/m68k/cpu.
The current URL on cdn.netbsd.org is failing - using archive.netbsd.org
instead seems to be fine.
Signed-off-by: Thomas Huth
---
tests/acceptance/ppc_prep_40p.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.p
We are not running the acceptance tests on Travis anymore, so these
checks can be removed now.
Signed-off-by: Thomas Huth
---
tests/acceptance/ppc_prep_40p.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
index e82755c9cf
These patches enable more "check-acceptance" tests in the gitlab-CI,
fixing a broken URL, setting AVOCADO_ALLOW_UNTRUSTED_CODE and adding
some missing packages to the containers.
Thomas Huth (4):
tests/acceptance/ppc_prep_40p: Fix the URL to the NetBSD-4.0 archive
test/acceptance: Remove the C
Machine definitions may miss some vCPU-related parameters.
E.g., xlnx-versal-virt missed min_cpus and it was set to 1 by default.
This allowed using -smp 1 command line argument. But the machine
still created 2 vCPUs and passed all checks.
This patch adds one more check that does not allow creating
This patch sets min_cpus field for xlnx-versal-virt platform,
because it always creates XLNX_VERSAL_NR_ACPUS cpus even with
-smp 1 command line option.
Signed-off-by: Pavel Dovgalyuk
---
hw/arm/xlnx-versal-virt.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/xlnx-versal-virt.c b/
The tests are running in containers here, so it should be OK to
run with AVOCADO_ALLOW_UNTRUSTED_CODE enabled in this case.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 66ad7aa5c2..5d6773efd2 100644
--- a/
On 10/23/20 12:31 AM, Eduardo Habkost wrote:
Based-on: 20201009160122.1662082-1-ehabk...@redhat.com
Git branch: https://github.com/ehabkost/qemu work/qom-bool-ptr-prop
This series introduces a helper to make it easier to register
simple boolan QOM properties. It will be useful for simplifying
e
Hi,
> For clarification, I'm assuming the set of committers is rather small,
> and not the same as the set of subsystem maintainers who send pull
> requests for a committer to then merge in.
Yes.
> Does this proposal mean that
> pull requests would have to switch to gitlab merge requests,
I m
Some of the "check-acceptance" tests are still skipped in the CI
since the docker images do not provide the necessary packages, e.g.
the netcat binary. Add them to get more test coverage.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/centos8.docker | 1 +
tests/docker/dockerfiles/
Am 20.10.2020 um 16:47 hat Zhengui li geschrieben:
> Currently, there is no rate limit for qemu-img commit and convert. This may
> cause the task of qemu-img commit and convert to consume all the bandwidth
> of the storage. This will affect the IO performance of other processes
> and virtual machin
On Thu, Oct 22, 2020 at 04:56:16PM -0400, Peter Xu wrote:
> On Thu, Oct 22, 2020 at 06:39:37PM +0200, Jean-Philippe Brucker wrote:
> > So what I'd like to do for next version:
> >
> > * Set qemu_real_host_page_mask as the default page mask, instead of the
> > rather arbitrary TARGET_PAGE_MASK.
>
Le 23/10/2020 à 09:27, Thomas Huth a écrit :
> On 22/10/2020 22.29, Laurent Vivier wrote:
>> They are unused since the target has been converted to TCG.
>>
>> Fixes: e1f3808e03f7 ("Convert m68k target to TCG.")
>> Signed-off-by: Laurent Vivier
>> ---
>> target/m68k/cpu.h | 4
>> 1 file chang
On 10/23/2020 2:07 AM, Alex Williamson wrote:
On Thu, 22 Oct 2020 16:42:04 +0530
Kirti Wankhede wrote:
When vIOMMU is enabled, register MAP notifier from log_sync when all
devices in container are in stop and copy phase of migration. Call replay
and get dirty pages from notifier callback.
On 10/13/20 4:05 PM, Jason Andryuk wrote:
dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition
will never evaluate true. Remove it.
I disagree with this removal, as you are making this a generic
accelerator out of QTest. I'd rather keep this and replace the
error message wi
On Fri, Oct 23, 2020 at 10:46 AM Gerd Hoffmann wrote:
> Build virtio-gpu pci devices modular. Must be a separate module because
> not all qemu softmmu variants come with PCI support.
>
> Signed-off-by: Gerd Hoffmann
>
Hmm, I realize we have a different behaviour when building devices as
module
On 10/23/20 9:33 AM, Thomas Huth wrote:
The current URL on cdn.netbsd.org is failing - using archive.netbsd.org
instead seems to be fine.
Signed-off-by: Thomas Huth
---
tests/acceptance/ppc_prep_40p.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/acceptance/ppc_p
On 10/23/20 9:33 AM, Thomas Huth wrote:
The tests are running in containers here, so it should be OK to
run with AVOCADO_ALLOW_UNTRUSTED_CODE enabled in this case.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 1 +
1 file changed, 1 insertion(+)
Thanks :)
Reviewed-by: Philippe Mathieu-D
On 10/23/20 9:33 AM, Thomas Huth wrote:
Some of the "check-acceptance" tests are still skipped in the CI
since the docker images do not provide the necessary packages, e.g.
the netcat binary. Add them to get more test coverage.
Signed-off-by: Thomas Huth
---
tests/docker/dockerfiles/centos8.d
On 10/23/20 9:33 AM, Thomas Huth wrote:
We are not running the acceptance tests on Travis anymore, so these
checks can be removed now.
Signed-off-by: Thomas Huth
---
tests/acceptance/ppc_prep_40p.py | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 10/23/20 9:35 AM, Pavel Dovgalyuk wrote:
This patch sets min_cpus field for xlnx-versal-virt platform,
because it always creates XLNX_VERSAL_NR_ACPUS cpus even with
-smp 1 command line option.
Signed-off-by: Pavel Dovgalyuk
---
hw/arm/xlnx-versal-virt.c |1 +
1 file changed, 1 inserti
On Fri, Oct 23, 2020 at 10:48 AM Gerd Hoffmann wrote:
> Build virtio-gpu vga devices modular. Must be a separate module because
> not all qemu softmmu variants come with VGA support.
>
> Signed-off-by: Gerd Hoffmann
>
Reviewed-by: Marc-André Lureau
---
> util/module.c | 3 +++
> h
On 10/23/20 9:34 AM, Pavel Dovgalyuk wrote:
Machine definitions may miss some vCPU-related parameters.
E.g., xlnx-versal-virt missed min_cpus and it was set to 1 by default.
This allowed using -smp 1 command line argument. But the machine
still created 2 vCPUs and passed all checks.
This patch ad
On 23.10.2020 11:10, Philippe Mathieu-Daudé wrote:
On 10/23/20 9:34 AM, Pavel Dovgalyuk wrote:
Machine definitions may miss some vCPU-related parameters.
E.g., xlnx-versal-virt missed min_cpus and it was set to 1 by default.
This allowed using -smp 1 command line argument. But the machine
still
On Thu, Oct 22, 2020 at 06:47:55PM +0200, Paolo Bonzini wrote:
> Hi all,
>
> now that Gitlab is the primary CI infrastructure for QEMU, and that all
> QEMU git repositories (including mirrors) are available on Gitlab, I
> would like to propose that committers use Gitlab when merging commits to
> Q
On Thu, Oct 22, 2020 at 12:24:28PM -0500, Eric Blake wrote:
> On 10/22/20 11:47 AM, Paolo Bonzini wrote:
> > Hi all,
> >
> > now that Gitlab is the primary CI infrastructure for QEMU, and that all
> > QEMU git repositories (including mirrors) are available on Gitlab, I
> > would like to propose th
Sometime vdpa get an all 0 mac address from the hardware, this will cause the
traffic down
So we add the check for this part.
if we get an 0 mac address we will use the default mac address instead
---
hw/net/virtio-net.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw
On Fri, Oct 23, 2020 at 07:59:00AM +0200, Thomas Huth wrote:
> On 09/07/2020 12.22, Thomas Huth wrote:
> > On 09/07/2020 12.16, Gerd Hoffmann wrote:
> >> Hi,
> >>
> 2. wiki.qemu.org is a MediaWiki instance. Account creation is a hurdle
> to one-time or new contributors. It is unclear wh
Add basic CPU state description to the newly created machine.c
Signed-off-by: Yifei Jiang
Signed-off-by: Yipeng Yin
---
target/riscv/cpu.c | 8 +
target/riscv/internals.h | 4 +++
target/riscv/machine.c | 74
target/riscv/meson.build | 3 +
This patches supported RISC-V migration based on tcg accel. And we have
verified related migration features such as snapshot and live migration.
A few weeks ago, we submitted RFC patches about supporting RISC-V migration
based on kvm accel: https://www.spinics.net/lists/kvm/msg223605.html.
And we
Patchew URL: https://patchew.org/QEMU/20201023090743.3023-1-l...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201023090743.3023-1-l...@redhat.com
Subject: [PATCH] virtio-net: Add check for mac address wh
Add sifive_plic vmstate for supporting sifive_plic migration.
Current vmstate framework only supports one structure parameter
as num field to describe variable length arrays, so introduce
num_enables.
Signed-off-by: Yifei Jiang
Signed-off-by: Yipeng Yin
---
hw/intc/sifive_plic.c | 26 ++
In the case of supporting H extension, add H extension description
to vmstate_riscv_cpu.
Signed-off-by: Yifei Jiang
Signed-off-by: Yipeng Yin
---
target/riscv/machine.c | 47 ++
1 file changed, 47 insertions(+)
diff --git a/target/riscv/machine.c b/targe
mstatus/mstatush and vsstatus/vsstatush are two halved for RISCV32.
This patch expands mstatus and vsstatus to uint64_t instead of
target_ulong so that it can be saved as one unit and reduce some
ifdefs in the code.
Signed-off-by: Yifei Jiang
Signed-off-by: Yipeng Yin
---
target/riscv/cpu.c
In the case of supporting PMP feature, add PMP state description
to vmstate_riscv_cpu.
'vmstate_pmp_addr' and 'num_rules' could be regenerated by
pmp_update_rule(). But there exists the problem of updating
num_rules repeatedly in pmp_update_rule(). So here extracts
pmp_update_rule_addr() and pmp_u
In the case of supporting V extension, add V extension description
to vmstate_riscv_cpu.
Signed-off-by: Yifei Jiang
Signed-off-by: Yipeng Yin
Reviewed-by: Richard Henderson
---
target/riscv/machine.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/target/riscv/ma
Sometime vdpa get an all 0 mac address from the hardware, this will cause the
traffic down
So we add the check for this part.
if we get an 0 mac address we will use the default mac address instead
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 7 ++-
1 file changed, 6 insertions(+), 1 de
On Fri, Oct 23, 2020 at 10:35:49AM +0300, Pavel Dovgalyuk wrote:
> This patch sets min_cpus field for xlnx-versal-virt platform,
> because it always creates XLNX_VERSAL_NR_ACPUS cpus even with
> -smp 1 command line option.
Reviewed-by: Edgar E. Iglesias
>
> Signed-off-by: Pavel Dovgalyuk
> -
On 10/23/20 4:02 AM, Bin Meng wrote:
Hi Niek,
On Thu, Oct 22, 2020 at 11:20 PM Niek Linnenbank
wrote:
Hi Bin, Philippe,
If im correct the acceptance tests for orange pi need to be run with a flag
ARMBIAN_ARTIFACTS_CACHED set that explicitly allows them to be run using the
armbian mirror. S
Alex Bennée writes:
(fix the qemu-devel address)
> Hi Gerd,
>
> I'm currently trying to get accelerated graphics working on an AArch64
> AGL distribution (both in KVM and TCG builds). As far as I can tell the
> device is being correctly created and I do get a working DRI based
> display. Howev
On 23/10/20 09:09, Thomas Huth wrote:
> On 22/10/2020 17.29, Paolo Bonzini wrote:
>> On 22/10/20 17:17, Jason Andryuk wrote:
>>> On Tue, Oct 13, 2020 at 1:16 PM Paolo Bonzini wrote:
On 13/10/20 16:05, Jason Andryuk wrote:
> Xen was left behind when CpusAccel became mandatory and fail
On 10/23/20 11:23 AM, Philippe Mathieu-Daudé wrote:
On 10/23/20 4:02 AM, Bin Meng wrote:
Hi Niek,
On Thu, Oct 22, 2020 at 11:20 PM Niek Linnenbank
wrote:
Hi Bin, Philippe,
If im correct the acceptance tests for orange pi need to be run with
a flag ARMBIAN_ARTIFACTS_CACHED set that explicit
On 22/10/20 19:24, Eric Blake wrote:
> Does this proposal mean that pull requests would have to switch to
> gitlab merge requests, or would there be a transition period where
> submaintainers still send pull requests via whichever means desired
> (mail or gitlab merge request), but the eventual com
On Thu, Oct 22, 2020 at 05:47:33PM +0530, Sai Pavan Boddu wrote:
> This patch series attempts to make 'hcd-xhci' an independent model so it can
> be used by both pci and system-bus interface.
On the series:
Reviewed-by: Edgar E. Iglesias
>
> Changes for V2:
> Make XHCIState non-qom
>
> -Original Message-
> From: Jiangyifei
> Sent: Friday, October 23, 2020 5:12 PM
> To: qemu-devel@nongnu.org; qemu-ri...@nongnu.org
> Cc: pal...@dabbelt.com; alistair.fran...@wdc.com;
> sag...@eecs.berkeley.edu; kbast...@mail.uni-paderborn.de;
> richard.hender...@linaro.org; Zhangxiaofeng
22.10.2020 23:50, Vladimir Sementsov-Ogievskiy wrote:
22.07.2020 14:28, Max Reitz wrote:
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
Add function to cancel running async block-copy call. It will be used
in backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/bloc
On 10/23/2020 1:20 AM, Alex Williamson wrote:
On Thu, 22 Oct 2020 16:41:59 +0530
Kirti Wankhede wrote:
Sequence during _RESUMING device state:
While data for this device is available, repeat below steps:
a. read data_offset from where user application should write data.
b. write data of da
While the qemu-storage-daemon command line is still considered unstable,
let's change --chardev from the old QemuOpts-based parser to QAPI, so
that it becomes a simple mapping of chardev-add to the command line and
will fit in a future fully QAPIfied command line without later
incompatible changes
Variants of simple unions are always contained in a wrapper object
called 'data' that serves no real use. When mapping a QAPI object to the
command line, this becomes very visible to users because they have to
add one or more useless 'data.' to many option names.
As a first step towards avoiding t
We'll want to call the same from a non-QemuOpts code path.
Signed-off-by: Kevin Wolf
---
include/chardev/char.h | 1 +
chardev/char.c | 17 +++--
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/include/chardev/char.h b/include/chardev/char.h
index db42f0a8c6.
Commit 02c4bdf1 tried to make signal=on the default for stdio chardevs
except for '-serial mon:stdio', but it forgot about QMP and accidentally
switched the QMP default from true (except for -nographic) to false
(always). The documentation was kept unchanged and still describes the
opposite of the
This extends the Visitor interface with an option that can enable flat
representation (without the 'data' wrapper) for simple unions. This way,
a command line parser can enable a more user friendly syntax while QMP
doesn't enable the option and uses the same representation as before.
We need to di
While this makes the code quite a bit longer and arguably isn't very
elegant, it removes the dependency on QemuOpts from the --chardev option
of the storage daemon.
Going through qmp_chardev_add() already now ensures that semantics and
accessible features won't change incompatibly once we QAPIfy i
This adds some test cases related to flat representation of simple
unions and the 'allow-flat' option for union branches.
Signed-off-by: Kevin Wolf
---
tests/qapi-schema/flat-union-allow-flat.err| 2 ++
tests/qapi-schema/flat-union-allow-flat.json | 10 ++
tests/qapi-schem
On 10/23/2020 3:48 AM, Alex Williamson wrote:
On Thu, 22 Oct 2020 16:42:07 +0530
Kirti Wankhede wrote:
Added amount of bytes transferred to the VM at destination by all VFIO
devices
Signed-off-by: Kirti Wankhede
Reviewed-by: Dr. David Alan Gilbert
---
hw/vfio/common.c| 20 +
On Fri, Oct 23, 2020 at 12:12:16PM +0200, Kevin Wolf wrote:
> While the qemu-storage-daemon command line is still considered unstable,
> let's change --chardev from the old QemuOpts-based parser to QAPI, so
> that it becomes a simple mapping of chardev-add to the command line and
> will fit in a fu
On Fri, Oct 23, 2020 at 2:14 PM Kevin Wolf wrote:
> We'll want to call the same from a non-QemuOpts code path.
>
> Signed-off-by: Kevin Wolf
> ---
> include/chardev/char.h | 1 +
> chardev/char.c | 17 +++--
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git
On Fri, Oct 23, 2020 at 2:14 PM Kevin Wolf wrote:
> Commit 02c4bdf1 tried to make signal=on the default for stdio chardevs
> except for '-serial mon:stdio', but it forgot about QMP and accidentally
> switched the QMP default from true (except for -nographic) to false
> (always). The documentation
If a BDS gets deleted during blk_drain_all(), it might miss a
call to bdrv_do_drained_end(). This means missing a call to
aio_enable_external() and the AIO context remains disabled for
ever. This can cause a device to become irresponsive and to
disrupt the guest execution, ie. hang, loop forever or
Patchew URL:
https://patchew.org/QEMU/160344969243.4091343.14371338409686732879.st...@bahia.lan/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 160344969243.4091343.14371338409686732879.st...@bahia.lan
Subject: [PATCH]
Hi,
> [2.930300] [drm] virgl 3d acceleration not supported by host
Nope, not active.
> -display gtk,show-cursor=on \
Needs -display gtk,gl=on for opengl support.
> -device virtio-gpu-pci,virgl=true
virgl is silently turned off in case opengl support is not available.
Ideally v
On Fri, 23 Oct 2020 03:48:39 -0700
wrote:
> Patchew URL:
> https://patchew.org/QEMU/160344969243.4091343.14371338409686732879.st...@bahia.lan/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 160344
Mhm, weird. On my other machine it works.
There I used the AUR package qemu-user-static instead of qemu-arm-static.
However that seems not to be the problem since it doesnt even work after
switching to qemu-user-static.
With the working setup the log files are also created (which makes sense
sin
Hi,
> Hmm, I realize we have a different behaviour when building devices as
> modules shared by different qemu system binaries.
>
> It will attempt to load any kind of modules:
>
> ./qemu-system-m68k -kernel ~/Downloads/vmlinux-5.8.0-3-m68k -device
> virtio-gpu-pci
> Failed to open module:
>
On 23/10/20 12:36, Daniel P. Berrangé wrote:
> IOW, if we're considering our ideal long term configuration goals
> for QEMU, then I think we should be looking at a solution to bridge
> the gap, so that we can get the best of both worlds, and have a single
> way todo things.
>
> IMHO, ideally none
Hi
On Fri, Oct 23, 2020 at 2:40 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Fri, Oct 23, 2020 at 2:14 PM Kevin Wolf wrote:
>
>> Variants of simple unions are always contained in a wrapper object
>> called 'data' that serves no real use. When mapping a QAPI object to the
On Sat, 10 Oct 2020 11:30:28 +0800
Jason Wang wrote:
>
> On 2020/10/8 上午12:30, Greg Kurz wrote:
> > The first loop in vhost_get_log_size() computes the size of the dirty log
> > bitmap so that it allows to track changes in the entire guest memory, in
> > terms of GPA.
> >
> > When not using a vI
On 10/23/20 5:55 AM, Guenter Roeck wrote:
On 10/22/20 3:06 PM, Philippe Mathieu-Daudé wrote:
Cc'ing Guenter who had a similar patch and might be interested
to test :)
I applied the series on top of qemu mainline and ran all my test with it
(raspi2 with qemu-system-arm as well as qemu-system-aa
Hook vfio_get_object callback for PCI devices.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
Suggested-by: Cornelia Huck
Reviewed-by: Cornelia Huck
---
hw/vfio/pci.c | 8
include/hw/vfio/vfio-common.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/vfio/
Hi,
This Patch set adds migration support for VFIO devices in QEMU.
This Patch set include patches as below:
Patch 1-2:
- Few code refactor
Patch 3:
- Added save and restore functions for PCI configuration space. Used
pci_device_save() and pci_device_load() so that config space cache is saved
VM state change handler is called on change in VM's state. Based on
VM state, VFIO device state should be changed.
Added read/write helper functions for migration region.
Added function to set device_state.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
Reviewed-by: Dr. David Alan Gilbert
-
mr->ram_block is NULL when mr->is_iommu is true, then fr.dirty_log_mask
wasn't set correctly due to which memory listener's log_sync doesn't
get called.
This patch returns log_mask with DIRTY_MEMORY_MIGRATION set when
IOMMU is enabled.
Signed-off-by: Kirti Wankhede
---
softmmu/memory.c | 2 +-
1
This function will be used for migration region.
Migration region is mmaped when migration starts and will be unmapped when
migration is complete.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
Reviewed-by: Cornelia Huck
---
hw/vfio/common.c | 32 --
Added functions to save and restore PCI device specific data,
specifically config space of PCI device.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
---
hw/vfio/pci.c | 48 +++
include/hw/vfio/vfio-common.h | 2 ++
2 files changed, 5
Whether the VFIO device supports migration or not is decided based of
migration region query. If migration region query is successful and migration
region initialization is successful then migration is supported else
migration is blocked.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
Acked-
vfio_listener_log_sync gets list of dirty pages from container using
VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all
devices are stopped and saving state.
Return early for the RAM block section of mapped MMIO region.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
---
h
Sequence during _RESUMING device state:
While data for this device is available, repeat below steps:
a. read data_offset from where user application should write data.
b. write data of data_size to migration region from data_offset.
c. write data_size which indicates vendor driver that data is wri
Define flags to be used as delimiter in migration stream for VFIO devices.
Added .save_setup and .save_cleanup functions. Map & unmap migration
region from these functions at source during saving or pre-copy phase.
Set VFIO device state depending on VM's state. During live migration, VM is
running
Added migration state change notifier to get notification on migration state
change. These states are translated to VFIO device state and conveyed to
vendor driver.
Signed-off-by: Kirti Wankhede
Reviewed-by: Neo Jia
Reviewed-by: Dr. David Alan Gilbert
---
hw/vfio/migration.c | 28 +++
Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy
functions. These functions handles pre-copy and stop-and-copy phase.
In _SAVING|_RUNNING device state or pre-copy phase:
- read pending_bytes. If pending_bytes > 0, go through below steps.
- read data_offset - indicates k
When vIOMMU is enabled, add MAP notifier from log_sync when all
devices in container are in stop and copy phase of migration. Call replay
and then from notifier callback, get dirty pages.
Suggested-by: Alex Williamson
Signed-off-by: Kirti Wankhede
---
hw/vfio/common.c | 88 +
With vIOMMU, IO virtual address range can get unmapped while in pre-copy
phase of migration. In that case, unmap ioctl should return pages pinned
in that range and QEMU should find its correcponding guest physical
addresses and report those dirty.
Suggested-by: Alex Williamson
Signed-off-by: Kirt
Added helper functions to get IOMMU info capability chain.
Added function to get migration capability information from that
capability chain for IOMMU container.
Similar change was proposed earlier:
https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg03759.html
Disable migration for devices
If the device is not a failover primary device, call
vfio_migration_probe() and vfio_migration_finalize() to enable
migration support for those devices that support it respectively to
tear it down again.
Removed migration blocker from VFIO PCI device specific structure and use
migration blocker fro
Call VFIO_IOMMU_DIRTY_PAGES ioctl to start and stop dirty pages tracking
for VFIO devices.
Signed-off-by: Kirti Wankhede
Reviewed-by: Dr. David Alan Gilbert
---
hw/vfio/migration.c | 36
1 file changed, 36 insertions(+)
diff --git a/hw/vfio/migration.c b/hw
1 - 100 of 457 matches
Mail list logo
