Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-20 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:54:50PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > > + > > > +- name: Checks the availability of official gitlab-runner builds in > > > the archive >

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Bihong Yu
On 2020/10/20 14:54, Philippe Mathieu-Daudé wrote: > On 10/20/20 8:42 AM, Bihong Yu wrote: >> Signed-off-by: Bihong Yu >> --- >>   migration/block.c  | 36 ++-- >>   migration/page_cache.c | 13 +++-- >>   migration/trace-events | 13 + >>  

Re: [PATCH] ati: mask x y display parameter values

2020-10-20 Thread P J P
Hi, +-- On Mon, 19 Oct 2020, BALATON Zoltan wrote --+ | On Mon, 19 Oct 2020, P J P wrote: | >dst_x = ... (s->regs.dst_x(=0) + 1 - s->regs.dst_width(=16383)) | >dst_y = ... (s->regs.dst_y(=0) + 1 - s->regs.dst_height(=16383)) | > | > ati_2d_blt | >pixman_blt(0x7f03cbe0, 0x7f03cbe

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 9:07 AM, Bihong Yu wrote: On 2020/10/20 14:54, Philippe Mathieu-Daudé wrote: On 10/20/20 8:42 AM, Bihong Yu wrote: Signed-off-by: Bihong Yu ---   migration/block.c  | 36 ++--   migration/page_cache.c | 13 +++--   migration/trace-even

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Bihong Yu
OK, thank you for your help. On 2020/10/20 15:18, Philippe Mathieu-Daudé wrote: > On 10/20/20 9:07 AM, Bihong Yu wrote: >> >> >> On 2020/10/20 14:54, Philippe Mathieu-Daudé wrote: >>> On 10/20/20 8:42 AM, Bihong Yu wrote: Signed-off-by: Bihong Yu ---    migration/block.c  | 36

[PATCH v3] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Bihong Yu
Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index 273392b

Re: [PULL v3 2/6] tests/9pfs: change qtest name prefix to synth

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/8/20 8:34 PM, Christian Schoenebeck wrote: All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names f

RE: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-20 Thread Chenqun (kuhn)
Ping! Hello, Maybe this patch, some people have any other suggestions? Or, maybe missed to queue? Thanks, Chen Qun > -Original Message- > From: Vladimir Sementsov-Ogievskiy [mailto:vsement...@virtuozzo.com] > Sent: Wednesday, October 14, 2020 11:56 PM > To: Chenqun (kuhn) ; qemu-de

Re: [RFC v5 00/68] support vector extension v1.0

2020-10-20 Thread Frank Chang
On Wed, Sep 30, 2020 at 3:04 AM wrote: > From: Frank Chang > > This patchset implements the vector extension v1.0 for RISC-V on QEMU. > > This patchset is sent as RFC because RVV v1.0 is still in draft state. > v2 patchset was sent for RVV v0.9 and bumped to RVV v1.0 since v3 patchset. > > The p

[PATCH] hw/core/qdev-clock: add a reference on aliased clocks

2020-10-20 Thread Luc Michel
When aliasing a clock with the qdev_alias_clock() function, a new link property is created on the device aliasing the clock. The link points to the aliased clock and use the OBJ_PROP_LINK_STRONG flag. This property is read only since it does not provide a check callback for modifications. The obje

[PATCH v3 00/10] microvm: add usb support

2020-10-20 Thread Gerd Hoffmann
This depends on the pending microvm pull request. v2: - add some xhci cleanups. - move aml builder to sysbus-xhci. - add acpi testcase for usb=on (and while being at it rtc=on too). v3: - fix Kconfig deps for XHCI Gerd Hoffmann (10): acpi: add aml builder stubs usb/xhci: add include/hw/us

[PATCH v3 10/10] tests/acpi: update expected data files

2020-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- tests/data/acpi/microvm/DSDT.rtc| Bin 0 -> 404 bytes tests/data/acpi/microvm/DSDT.usb| Bin 0 -> 414 bytes 3 files changed, 2 deletions(-) diff --git a/tests/qtest/bios-tables-test-all

[PATCH v3 02/10] usb/xhci: add include/hw/usb/xhci.h header file

2020-10-20 Thread Gerd Hoffmann
Move a bunch of defines which might be needed outside core xhci code to that place. Add XHCI_ prefixes to avoid name clashes. No functional change. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci-sysbus.h | 1 - hw/usb/hcd-xhci.h| 22 ++ include/hw/usb/xhci.h|

[PATCH v3 03/10] usb/xhci: add xhci_sysbus_build_aml() helper

2020-10-20 Thread Gerd Hoffmann
The helper generates an acpi dsdt device entry for the xhci sysbus device. Signed-off-by: Gerd Hoffmann --- include/hw/usb/xhci.h| 2 ++ hw/usb/hcd-xhci-sysbus.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/usb/xhci.h b/include/hw/usb/xhci.h index dc0c299

[PATCH v3 01/10] acpi: add aml builder stubs

2020-10-20 Thread Gerd Hoffmann
Add stubs for aml_interrupt and aml_memory32_fixed, these will be needed by followup patches, Signed-off-by: Gerd Hoffmann --- hw/acpi/aml-build-stub.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/acpi/aml-build-stub.c b/hw/acpi/aml-build-stub.c index 58b2e162277f..8d8a

[PATCH v3 09/10] tests/acpi: add microvm rtc test

2020-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 17e11800274d..3830a40d1041 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tab

[PATCH v3 08/10] tests/acpi: add microvm usb test

2020-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 564762449233..17e11800274d 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tab

[PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps

2020-10-20 Thread Gerd Hoffmann
USB_XHCI does not depend on PCI any more. USB_XHCI_SYSBUS must select USB_XHCI not USB. Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 4dd2ba9630cb..a674ce4c542e 100644 --- a/hw/usb/K

[PATCH v3 06/10] tests/acpi: allow updates for expected data files

2020-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..afd6b04a475a 100644 --- a/tests/qtest/bios-tables-test-

[PATCH v3 05/10] microvm: add usb support

2020-10-20 Thread Gerd Hoffmann
Wire up "usb=on" machine option, when enabled add a sysbus xhci controller with 8 ports. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 5 - hw/i386/acpi-microvm.c| 9 + hw/i386/microvm.c | 13 + hw/i386/Kconfig | 1 + 4 files change

[PATCH v3 07/10] tests/acpi: add empty tests/data/acpi/microvm/DSDT.{usb, rtc} files

2020-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/DSDT.rtc | 0 tests/data/acpi/microvm/DSDT.usb | 0 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/data/acpi/microvm/DSDT.rtc create mode 100644 tests/data/acpi/microvm/DSDT.usb diff --git a/tests/data/acpi/mic

Re: [PATCH] hw/core/qdev-clock: add a reference on aliased clocks

2020-10-20 Thread Philippe Mathieu-Daudé
Cc'ing Markus/Marc-André too. On 10/20/20 9:44 AM, Luc Michel wrote: When aliasing a clock with the qdev_alias_clock() function, a new link property is created on the device aliasing the clock. The link points to the aliased clock and use the OBJ_PROP_LINK_STRONG flag. This property is read only

Re: Question on Compression for Raw Image

2020-10-20 Thread Kevin Wolf
Am 20.10.2020 um 03:31 hat Wang, Wei W geschrieben: > Hi, > > Does anyone know the reason why raw-format.c doesn't have compression > support (but qcow has the supported added)? For example, raw image > backup with compression, "qemu-img convert -c -O raw origin.img > dist.img", doesn't work. A

Re: [PATCH V14 7/8] hw/mips: Add Loongson-3 machine support

2020-10-20 Thread Huacai Chen
Hi, Philippe, On Sat, Oct 17, 2020 at 11:58 PM Philippe Mathieu-Daudé wrote: > > On 10/16/20 8:51 AM, Huacai Chen wrote: > > Add Loongson-3 based machine support, it use liointc as the interrupt > > controler and use GPEX as the pci controller. Currently it can work with > > both TCG and KVM. > >

Re: [PATCH v3] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 9:32 AM, Bihong Yu wrote: Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migrati

[PATCH v3 2/7] qga: add ssh-{add,remove}-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau Add new commands to add and remove SSH public keys from ~/.ssh/authorized_keys. I took a different approach for testing, including the unit tests right with the code. I wanted to overwrite the function to get the user details, I couldn't easily do that over QMP. Furthermo

[PATCH v3 0/7] qemu-ga: add ssh-{get,add,remove}-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau Hi Add new commands to help modify a user .ssh/authorized_keys. Although it's possible already to modify the authorized_keys files via file-{read,write} or exec, the commands are often denied by default, and the logic is left to the client. Let's add specific commands fo

[PATCH v3 1/7] glib-compat: add g_unix_get_passwd_entry_qemu()

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau The glib function was introduced in 2.64. It's a safer version of getpwnam, and also simpler to use than getpwnam_r. Currently, it's only use by the next patch in qemu-ga, which doesn't (well well...) need the thread safety guarantees. Since the fallback version is still

[PATCH v3 3/7] fixup! qga: add ssh-{add,remove}-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau I forgot to reset the file ownership after it is written. --- qga/commands-posix-ssh.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/qga/commands-posix-ssh.c b/qga/commands-posix-ssh.c index d41c114c3c..a7bc9a1c24 100644 --- a/qga/comm

[PATCH v3 4/7] fixup! qga: add ssh-{add,remove}-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau Use 'if' condition, as suggested by E. Blake. --- qga/commands-win32.c | 12 qga/qapi-schema.json | 6 -- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 1e188b03d3..0c3c05484f 100644 ---

[PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread P J P
From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type to use based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, as it maybe triggered by a guest user. Report

[PATCH v3 6/7] meson: minor simplification

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/meson.build | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/qga/meson.build b/qga/meson.build index 6315bb357e..8340892139 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -22,12 +22,7 @@ qga_qapi_fi

[PATCH v3 5/7] qga: add *reset argument to ssh-add-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau I prefer 'reset' over 'clear', since 'clear' and keys may have some other relations or meaning. Signed-off-by: Marc-André Lureau --- qga/commands-posix-ssh.c | 53 qga/qapi-schema.json | 3 ++- 2 files changed, 50 insertions

[PATCH v3 7/7] qga: add ssh-get-authorized-keys

2020-10-20 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/commands-posix-ssh.c | 66 qga/meson.build | 11 +-- qga/qapi-schema.json | 31 +++ 3 files changed, 106 insertions(+), 2 deletions(-) diff --git a/qga/com

Re: Plans to bring QMP 'x-blockdev-reopen' out of experimental?

2020-10-20 Thread Kashyap Chamarthy
On Mon, Oct 19, 2020 at 05:56:56PM +0200, Alberto Garcia wrote: > On Tue 06 Oct 2020 11:10:01 AM CEST, Kashyap Chamarthy wrote: > > Hi, folks > > > > If this was already discussed on the list, please point me to the > > thread. I took a quick look at my local archives, I didn't find any, > > besid

Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-20 Thread Laurent Vivier
Le 20/10/2020 à 09:36, Chenqun (kuhn) a écrit : > Ping! > > Hello, > > Maybe this patch, some people have any other suggestions? Or, maybe > missed to queue? Hi, As we've seen by reviewing previous versions, this change is not really trivial, so I will not take it via the trivial queue. P

Re: [RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-10-20 Thread Andrew Jones
On Tue, Oct 20, 2020 at 10:52:11AM +0800, Ying Fang wrote: > > > On 10/16/2020 6:07 PM, Andrew Jones wrote: > > On Fri, Oct 16, 2020 at 05:40:02PM +0800, Ying Fang wrote: > > > > > > > > > On 10/15/2020 3:59 PM, Andrew Jones wrote: > > > > On Thu, Oct 15, 2020 at 10:07:16AM +0800, Ying Fang wro

Re: [PATCH v7 04/11] hw/block/nvme: Support allocated CNS command variants

2020-10-20 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: (snip) > CAP.CSS (together with the I/O Command Set data structure) defines > what command sets are supported by the controller. > > CC.CSS (together with Set Profile) can be set to enable a subset of > the available command sets. > > Even if a user confi

Re: [PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 10:11 AM, P J P wrote: From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type to use based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, as it may

Re: Plans to bring QMP 'x-blockdev-reopen' out of experimental?

2020-10-20 Thread Kevin Wolf
Am 19.10.2020 um 18:46 hat Alberto Garcia geschrieben: > On Mon 19 Oct 2020 05:56:56 PM CEST, Alberto Garcia wrote: > > And this one in particular: > > > >https://lists.gnu.org/archive/html/qemu-block/2020-02/msg00601.html > > I forgot to add, we still don't support changing bs->file with this

RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
Hi, all. I recently found a corner case when it is impossible AFAIK to find out valid backing chain after block commit operation. Imagine committing top image. After commit ready state pivot is sent and then mgmt crashed. So far so good. Upon next start mgmt can either check block job status for n

Re: [PATCH v3 0/7] qemu-ga: add ssh-{get,add,remove}-authorized-keys

2020-10-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201020081257.2054548-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201020081257.2054548-1-marcandre.lur...@redhat.com Subject: [PATCH v3 0/7] qe

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-20 Thread Daniel P . Berrangé
On Tue, Oct 20, 2020 at 08:58:39AM +0200, Erik Skultety wrote: > On Mon, Oct 19, 2020 at 04:41:38PM -0400, Cleber Rosa wrote: > > On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > > > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > > > To have the jobs dispatched to

Re: [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers

2020-10-20 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > With ZNS support in place, the majority of code in nvme_rw() has > become read- or write-specific. Move these parts to two separate > handlers, nvme_read() and nvme_write() to make the code more > readable and to remove multiple is_write checks that so far

Re: [PATCH v7 11/11] hw/block/nvme: Merge nvme_write_zeroes() with nvme_write()

2020-10-20 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > nvme_write() now handles WRITE, WRITE ZEROES and ZONE_APPEND. > Same here, Acked, but maybe move it in front as a preparation patch as well? signature.asc Description: PGP signature

[PATCH v4] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Bihong Yu
Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index 273392b

Re: [PATCH] hw/core/qdev-clock: add a reference on aliased clocks

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 9:58 AM, Philippe Mathieu-Daudé wrote: Cc'ing Markus/Marc-André too. On 10/20/20 9:44 AM, Luc Michel wrote: When aliasing a clock with the qdev_alias_clock() function, a new link property is created on the device aliasing the clock. The link points to the aliased clock and use the O

Re: [PATCH v4] migration: using trace_ to replace DPRINTF

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 10:31 AM, Bihong Yu wrote: Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) Reviewed-by: Phili

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-20 Thread Paolo Bonzini
On 20/10/20 07:15, Thomas Huth wrote: >> + ;; >> + --enable-cross-compile) cross_compile="yes" >> + ;; >> + --disable-cross-compile) cross_compile="no" > > Can't you simply use --cros-prefix="" instead? I mean, still introduce the "cross_compile=yes" variable,

Re: RFC: tracking valid backing chain issue

2020-10-20 Thread Kevin Wolf
Am 20.10.2020 um 10:21 hat Nikolay Shirokovskiy geschrieben: > Hi, all. > > I recently found a corner case when it is impossible AFAIK to find out valid > backing chain after block commit operation. Imagine committing top image. > After > commit ready state pivot is sent and then mgmt crashed. So

Re: [PATCH v4 4/7] nbd: Update qapi to support exporting multiple bitmaps

2020-10-20 Thread Markus Armbruster
Eric Blake writes: > On 10/14/20 7:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> 10.10.2020 00:55, Eric Blake wrote: >>> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to >>> 5.2, we can still tweak the interface.  Allowing 'bitmaps':['str'] is >>> nicer than 'bitmap':'str'. 

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-20 Thread Andrea Bolognani
On Mon, 2020-10-19 at 11:02 +0100, Daniel P. Berrangé wrote: > On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote: > > I think this need to be considered very carefully. > > > > I'm not overly familiar with the Python ecosystem but it would appear > > that, despite PEP 440 not mandat

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-20 Thread Paolo Bonzini
On 15/10/20 16:37, to...@linux.ibm.com wrote: > -static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) > +void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **errp) > { > MemoryRegionSection mrs = memory_region_find(get_system_memory(), > -

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-20 Thread Daniel P . Berrangé
On Tue, Oct 20, 2020 at 10:52:14AM +0200, Andrea Bolognani wrote: > On Mon, 2020-10-19 at 11:02 +0100, Daniel P. Berrangé wrote: > > On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote: > > > With that in mind, I think it would be unwise for qemu.* not to do > > > the same; in particul

Re: [PATCH v3 1/5] tools/virtiofsd: xattr name mappings: Add option

2020-10-20 Thread Stefan Hajnoczi
On Wed, Oct 14, 2020 at 07:02:05PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add an option to define mappings of xattr names so that > the client and server filesystems see different views. > This can be used to have different SELinux mappings as > seen by th

[PATCH v2] hw/core/qdev-clock: add a reference on aliased clocks

2020-10-20 Thread Luc Michel
When aliasing a clock with the qdev_alias_clock() function, a new link property is created on the device aliasing the clock. The link points to the aliased clock and use the OBJ_PROP_LINK_STRONG flag. This property is read only since it does not provide a check callback for modifications. The obje

Re: [PATCH] meson: rewrite curses/iconv test

2020-10-20 Thread Paolo Bonzini
On 19/10/20 21:58, 罗勇刚(Yonggang Luo) wrote: > >> + if not curses.found() +curses_compile_args = >> ['-DNCURSES_WIDECHAR'] > > Here is what I think need improve in meson, when declare > dependencies, we need a extra option compile_args for easily testing > extra compile args, and maybe also n

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Olaf Hering
This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f On Mon, Sep 07, Laszlo Ersek wrote: > In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", > 2020-04-16), part of edk2-stable202005, the Brotli compressor / > decompressor source code that edk2 had flattened into BaseTo

Re: [PATCH v3 2/5] tools/virtiofsd: xattr name mappings: Map client xattr names

2020-10-20 Thread Stefan Hajnoczi
On Wed, Oct 14, 2020 at 07:02:06PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Map xattr names originating at the client; from get/set/remove xattr. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 101

Re: [PATCH v2] hw/core/qdev-clock: add a reference on aliased clocks

2020-10-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201020091024.320381-1-...@lmichel.fr/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201020091024.320381-1-...@lmichel.fr Subject: [PATCH v2] hw/core/qdev-clock: add a reference

Re: [PATCH] trace/simple: Enable tracing on startup only if the user specifies a trace option

2020-10-20 Thread Markus Armbruster
Markus Armbruster writes: > Stefan Hajnoczi writes: > >> On Sun, Aug 16, 2020 at 12:46:10PM -0500, dubo...@gmail.com wrote: >>> From: Josh DuBois >>> >>> Tracing can be enabled at the command line or via the >>> monitor. Command-line trace options are recorded during >>> trace_opt_parse(), but

Re: [PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-20 Thread Paolo Bonzini
On 19/10/20 21:02, Alex Williamson wrote: >> For KVM we were thinking of changing the whole >> memory map with a single ioctl, but that's much easier because KVM >> builds its page tables lazily. It would be possible for the IOMMU too >> but it would require a relatively complicated comparison of t

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Philippe Mathieu-Daudé
Hi Olaf, On 10/20/20 11:16 AM, Olaf Hering wrote: This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f On Mon, Sep 07, Laszlo Ersek wrote: In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", 2020-04-16), part of edk2-stable202005, the Brotli compressor / decompressor

Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Reduce the machine code pulled into qemu-storage-daemon. > > The series is fully Acked, but Markus wants it reviewed > by the Machine core maintainers. Queued, thanks!

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Olaf Hering
Am Tue, 20 Oct 2020 11:29:01 +0200 schrieb Philippe Mathieu-Daudé : > The EDK2 roms are only used for testing, we certainly don't want them > to be used by distributions. You mean 'make -C rom efirom' is something that must not be done? Olaf pgpHpgtTLDewr.pgp Description: Digitale Signatur vo

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-20 Thread Christian Borntraeger
On 17.10.20 20:09, Alexander Graf wrote: > Hi Jason, > > On 17.10.20 15:24, Jason A. Donenfeld wrote: >> >> After discussing this offline with Jann a bit, I have a few general >> comments on the design of this. >> >> First, the UUID communicated by the hypervisor should be consumed by >> the ke

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 11:29 AM, Philippe Mathieu-Daudé wrote: Hi Olaf, On 10/20/20 11:16 AM, Olaf Hering wrote: This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f On Mon, Sep 07, Laszlo Ersek wrote: In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", 2020-04-16), part of ed

[PATCH] scripts/tracetool: silence SystemTap dtrace(1) long long warnings

2020-10-20 Thread Stefan Hajnoczi
SystemTap's dtrace(1) prints the following warning when it encounters long long arguments: Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: probe vhost_vdpa_dev_start Warning: Proceeding as if --no-pyparsing was given. Use the uint64_t and int64_t types,

Re: [PULL v3 2/6] tests/9pfs: change qtest name prefix to synth

2020-10-20 Thread Christian Schoenebeck
On Dienstag, 20. Oktober 2020 09:36:10 CEST Philippe Mathieu-Daudé wrote: > On 10/8/20 8:34 PM, Christian Schoenebeck wrote: > > All existing 9pfs test cases are using the 'synth' fs driver so far, which > > means they are not accessing real files, but a purely simulated (in RAM > > only) file syst

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Daniel P . Berrangé
On Tue, Oct 20, 2020 at 11:29:01AM +0200, Philippe Mathieu-Daudé wrote: > Hi Olaf, > > On 10/20/20 11:16 AM, Olaf Hering wrote: > > This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f > > > > On Mon, Sep 07, Laszlo Ersek wrote: > > > > > In edk2 commit 06033f5abad3 ("BaseTools: Make

Re: [PATCH] scripts/tracetool: silence SystemTap dtrace(1) long long warnings

2020-10-20 Thread Daniel P . Berrangé
On Tue, Oct 20, 2020 at 10:40:43AM +0100, Stefan Hajnoczi wrote: > SystemTap's dtrace(1) prints the following warning when it encounters > long long arguments: > > Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax > error near: > probe vhost_vdpa_dev_start > > Warning

Re: [PATCH v3 3/5] tools/virtiofsd: xattr name mappings: Map server xattr names

2020-10-20 Thread Stefan Hajnoczi
On Wed, Oct 14, 2020 at 07:02:07PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Map xattr names coming from the server, i.e. the host filesystem; > currently this is only from listxattr. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passth

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-20 Thread Andrea Bolognani
On Tue, 2020-10-20 at 10:06 +0100, Daniel P. Berrangé wrote: > The QEMU python modules are not like other python modules though, > precisely because they are talking to QEMU. If we are shipping > QEMU python releases on the same schedule as QEMU, then we can > expect the normal ase to be updating b

Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 11:44 AM, Daniel P. Berrangé wrote: On Tue, Oct 20, 2020 at 11:29:01AM +0200, Philippe Mathieu-Daudé wrote: Hi Olaf, On 10/20/20 11:16 AM, Olaf Hering wrote: This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f On Mon, Sep 07, Laszlo Ersek wrote: In edk2 commit 06033f

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-20 Thread Alexander Graf
On 20.10.20 11:35, Christian Borntraeger wrote: On 17.10.20 20:09, Alexander Graf wrote: Hi Jason, On 17.10.20 15:24, Jason A. Donenfeld wrote: After discussing this offline with Jann a bit, I have a few general comments on the design of this. First, the UUID communicated by the hypervisor

Re: [PATCH v3 4/5] tools/virtiofsd: xattr name mapping examples

2020-10-20 Thread Stefan Hajnoczi
On Wed, Oct 14, 2020 at 07:02:08PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add a few examples of xattrmaps to the documentation. > > Signed-off-by: Dr. David Alan Gilbert > --- > docs/tools/virtiofsd.rst | 50 > 1

Re: [PATCH] s390x/s390-virtio-ccw: Reset PCI devices during subsystem reset

2020-10-20 Thread Cornelia Huck
On Thu, 15 Oct 2020 09:16:07 -0400 Matthew Rosato wrote: > Currently, a subsystem reset event leaves PCI devices enabled, causing > issues post-reset in the guest (an example would be after a kexec). These > devices need to be reset during a subsystem reset, allowing them to be > properly re-ena

Re: [PATCH 00/14] ui: build spice and opengl as module.

2020-10-20 Thread Marc-André Lureau
Hi On Mon, Oct 19, 2020 at 12:06 PM Gerd Hoffmann wrote: > - Add QemuSpiceOps, reorganize spice stubs. > - Add support for module dependencies. > - Build spice-core modular, and make the existing spice > modules (audio, chardev, qxl) depend on spice-core. > - Build egl-headless display and ope

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-20 Thread Alexander Graf
On 19.10.20 19:15, Mathieu Desnoyers wrote: - On Oct 17, 2020, at 2:10 PM, Andy Lutomirski l...@kernel.org wrote: On Fri, Oct 16, 2020 at 6:40 PM Jann Horn wrote: [adding some more people who are interested in RNG stuff: Andy, Jason, Theodore, Willy Tarreau, Eric Biggers. also linux-

Re: [PULL v3 2/6] tests/9pfs: change qtest name prefix to synth

2020-10-20 Thread Greg Kurz
On Tue, 20 Oct 2020 11:43:18 +0200 Christian Schoenebeck wrote: > On Dienstag, 20. Oktober 2020 09:36:10 CEST Philippe Mathieu-Daudé wrote: > > On 10/8/20 8:34 PM, Christian Schoenebeck wrote: > > > All existing 9pfs test cases are using the 'synth' fs driver so far, which > > > means they are no

Re: [PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread P J P
+-- On Tue, 20 Oct 2020, Philippe Mathieu-Daudé wrote --+ | Maybe LOG_UNIMP with useful fields, so when user send bug report we directly | know what has to be implemented. qemu_log("Probably not GSO frame, unknown L3 protocol: %hd\n", l3_proto); Maybe just qemu_log()? LOG_UNIMP seems mismatchi

[PULL 2/4] xen: Rename XENBACKEND_DEVICE to XENBACKEND

2020-10-20 Thread Anthony PERARD via
From: Eduardo Habkost Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Acked-by: Anthony PERARD Message-Id: <20200902224311.1321159-58-ehabk...@redhat.com> Signed-off-by: Anthony PERARD --- include/hw/xen/xen-legacy-backend.h | 2 +- 1 fil

[PULL 3/4] xen-bus: reduce scope of backend watch

2020-10-20 Thread Anthony PERARD via
From: Paul Durrant Currently a single watch on /local/domain/X/backend is registered by each QEMU process running in service domain X (where X is usually 0). The purpose of this watch is to ensure that QEMU is notified when the Xen toolstack creates a new device backend area. Such a backend area

[PULL 0/4] xen queue 2020-10-20

2020-10-20 Thread Anthony PERARD via
erard/qemu-dm.git tags/pull-xen-20201020 for you to fetch changes up to 8959e0a63a3a681a31ff8397d9345a88e6d905bf: hw/xen: Set suppress-vmdesc for Xen machines (2020-10-19 16:33:28 +0100) Xen queue * cleanup patches. * improve xen bac

[PULL 1/4] xen: xenguest is not used so is not needed

2020-10-20 Thread Anthony PERARD via
From: Michael Tokarev There's no references in only file which includes xenguest.h to any xen definitions. And there's no references to -lxenguest in qemu, either. Drop it. Signed-off-by: Michael Tokarev Reviewed-by: Anthony PERARD Message-Id: <20200727140048.19779-1-...@msgid.tls.msk.ru> [per

Re: [PATCH] scripts/tracetool: silence SystemTap dtrace(1) long long warnings

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 11:40 AM, Stefan Hajnoczi wrote: SystemTap's dtrace(1) prints the following warning when it encounters long long arguments: Warning: /usr/bin/dtrace:trace/trace-dtrace-hw_virtio.dtrace:76: syntax error near: probe vhost_vdpa_dev_start Warning: Proceeding as if --no-pyparsi

[PULL 4/4] hw/xen: Set suppress-vmdesc for Xen machines

2020-10-20 Thread Anthony PERARD via
From: Jason Andryuk xen-save-devices-state doesn't currently generate a vmdesc, so restore always triggers "Expected vmdescription section, but got 0". This is not a problem when restore comes from a file. However, when QEMU runs in a linux stubdom and comes over a console, EOF is not received.

Re: [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map'

2020-10-20 Thread Stefan Hajnoczi
On Wed, Oct 14, 2020 at 07:02:09PM +0100, Dr. David Alan Gilbert (git) wrote: > +static XattrMapEntry *parse_xattrmap_map(const char *rule, > + XattrMapEntry *map, > + size_t *nentries) > +{ > +char sep = *rule++; >

Re: RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
On 20.10.2020 11:50, Kevin Wolf wrote: > Am 20.10.2020 um 10:21 hat Nikolay Shirokovskiy geschrieben: >> Hi, all. >> >> I recently found a corner case when it is impossible AFAIK to find out valid >> backing chain after block commit operation. Imagine committing top image. >> After >> commit re

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-20 Thread Cornelia Huck
On Mon, 19 Oct 2020 11:51:36 -0600 Alex Williamson wrote: > On Sun, 18 Oct 2020 23:13:39 +0530 > Kirti Wankhede wrote: > > > > > > > +vfio_migration_set_state(char *name, uint32_t state) " (%s) state %d" > > +vfio_vmstate_change(char *name, int running, const char *reason, > > >>

Re: RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
On 20.10.2020 13:23, Nikolay Shirokovskiy wrote: > > > On 20.10.2020 11:50, Kevin Wolf wrote: >> Am 20.10.2020 um 10:21 hat Nikolay Shirokovskiy geschrieben: >>> Hi, all. >>> >>> I recently found a corner case when it is impossible AFAIK to find out valid >>> backing chain after block commit o

Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2020 11:16, Laurent Vivier wrote: Le 20/10/2020 à 09:36, Chenqun (kuhn) a écrit : Ping! Hello, Maybe this patch, some people have any other suggestions? Or, maybe missed to queue? Hi, As we've seen by reviewing previous versions, this change is not really trivial, so I will not

[PATCH v2] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-20 Thread Thomas Huth
When compiling with -Werror=implicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is indeed wanted here, but instead of adding the annotations, it can be done more efficiently by simply calculating the offset with a subtraction

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-20 Thread Cornelia Huck
On Sun, 18 Oct 2020 01:54:56 +0530 Kirti Wankhede wrote: > On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Wed, 23 Sep 2020 04:54:07 +0530 > >> Kirti Wankhede wrote: > >> > >>> VM state change handler gets called on change in VM's st

Re: [PATCH v11 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-10-20 Thread Peter Maydell
On Wed, 14 Oct 2020 at 07:04, Vikram Garhwal wrote: > > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through command lines. > > Example for using single CAN: > -object c

Re: [PATCH v26 06/17] vfio: Add migration state change notifier

2020-10-20 Thread Cornelia Huck
On Mon, 19 Oct 2020 11:57:47 -0600 Alex Williamson wrote: > On Sun, 18 Oct 2020 02:05:03 +0530 > Kirti Wankhede wrote: > > > On 9/26/2020 1:50 AM, Alex Williamson wrote: > > > On Wed, 23 Sep 2020 04:54:08 +0530 > > > Kirti Wankhede wrote: > > >> diff --git a/include/hw/vfio/vfio-common.h >

Re: [RFC 2/5] block/nvme: Change size and alignment of IDENTIFY response buffer

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/15/20 1:52 PM, Eric Auger wrote: In preparation of 64kB host page support, let's change the size and alignment of the IDENTIFY command response buffer so that the VFIO DMA MAP succeeds. We align on the host page size. Signed-off-by: Eric Auger --- block/nvme.c | 10 ++ 1 file c

[PATCH] hw/arm/highbank: Silence warnings about missing fallthrough statements

2020-10-20 Thread Thomas Huth
When compiling with -Werror=implicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is very likely intended here, so add some comments to silence the compiler warnings. Signed-off-by: Thomas Huth --- hw/arm/highbank.c | 2 ++ 1

[Bug 1856834] Re: PCI broken in qemu ppc e500 in v2.12.0 and other versions

2020-10-20 Thread Andrej Krutak
After some research, the problem is that mpc8544ds has only 2 PCI slots defined (hw/ppc/mpc8544ds.c -> pmc->pci_nr_slots = 2;). This in turn results in DTB only contain 2 devices in pci@e0008000/interrupt-map. Too bad qemu doesn't complain when more devices are added - the PCI bars seem to be OK, j

[PATCH 06/10] hw/pci/:split some lines containing more than 80 characters

2020-10-20 Thread Gan Qixin
By using scripts/checkpatch.pl, it is found that many files in hw/pci/ contain lines with more than 80 characters. Signed-off-by: Gan Qixin --- hw/pci/msi.c| 3 ++- hw/pci/msix.c | 8 hw/pci/pci.c| 31 --- hw/pci/pci_bridge.c | 3 ++-

  1   2   3   4   5   >