Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/19/20 6:48 PM, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote: Eduardo Habkost writes: > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: >>

Re: [PATCH] intel_iommu: Fix two misuse of "0x%u" prints

2020-10-19 Thread Jason Wang
On 2020/10/20 上午1:39, Peter Xu wrote: Dave magically found this. Fix them with "0x%x". Reported-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu

Re: [PATCH] scripts/qmp: delete 'qmp' script

2020-10-19 Thread Thomas Huth
On 19/10/2020 23.04, John Snow wrote: > This script has not seen a patch that was specifically for this script > since it was moved to this location in 2013, and I doubt it is used. It > uses "man qmp" for its help message, which does not exist. It also > presumes there is a manual page for qmp-XXX

[Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2020-10-19 Thread Thomas Huth
So is this now working for everybody with the correct ssh config (maybe also check your firewall settings)? Could we close this ticket nowadays? Or is somebody still having trouble? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-19 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:25:31PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:27:41PM +0200, Erik Skultety wrote: > > ... > > > > > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory > > > new file mode 100644 > > > index 00..8bb7ba6b33 > > > --- /dev/null > >

Re: [PATCH V2 00/14] fix some comment spelling errors

2020-10-19 Thread Philippe Mathieu-Daudé
You forgot to Cc qemu-devel@. (See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer) On Tue, Oct 20, 2020 at 4:46 AM Lichang Zhao wrote: Now your name is properly displayed, so I assume you finally ran: $ git config user.name "Lichang Zhao". To fix how your name is dis

[PATCH v2] migration: using trace_ to replace DPRINTF

2020-10-19 Thread Bihong Yu
Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index 273392b

Re: [PATCH] qmp-shell: Sort by key when pretty-printing

2020-10-19 Thread Markus Armbruster
David Edmondson writes: > If the user selects pretty-printing (-p) the contents of any > dictionaries in the output are sorted by key. > > Signed-off-by: David Edmondson > --- > scripts/qmp/qmp-shell | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qmp/qmp-shell

Re: [PATCH] scripts/qmp: delete 'qmp' script

2020-10-19 Thread Markus Armbruster
John Snow writes: > This script has not seen a patch that was specifically for this script > since it was moved to this location in 2013, and I doubt it is used. It > uses "man qmp" for its help message, which does not exist. It also > presumes there is a manual page for qmp-XXX, for each defined

Re: [PATCH v2 2/8] migration: Don't use '#' flag of printf format

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/12/20 3:08 PM, Bihong Yu wrote: Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/2] qga: add ssh-{add,remove}-authorized-keys

2020-10-19 Thread Marc-André Lureau
Hi On Mon, Oct 19, 2020 at 11:09 PM Eric Blake wrote: > On 10/13/20 3:25 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add new commands to add and remove SSH public keys from > > ~/.ssh/authorized_keys. > > > > > +++ b/qga/qapi-schema.json > > @@ -1306,3 +1306,35 @@

Re: [PATCH v2 5/8] migration: Add braces {} for if statement

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/12/20 3:08 PM, Bihong Yu wrote: Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/14/20 9:21 PM, Dr. David Alan Gilbert wrote: * Bihong Yu (yubih...@huawei.com) wrote: Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng OK, sometimes I find initialisation clearer Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2

Re: [PATCH v2 8/8] migration: Delete redundant spaces

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/12/20 3:09 PM, Bihong Yu wrote: Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/20/20 8:42 AM, Bihong Yu wrote: Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migrati

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Erik Skultety
On Mon, Oct 19, 2020 at 04:41:38PM -0400, Cleber Rosa wrote: > On Mon, Oct 19, 2020 at 12:26:10PM +0200, Erik Skultety wrote: > > On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > > > To have the jobs dispatched to custom runners, gitlab-runner must > > > be installed, active as a serv

<    1   2   3   4   5