On 10/14/20 9:21 PM, Dr. David Alan Gilbert wrote:
* Bihong Yu (yubih...@huawei.com) wrote:
Signed-off-by: Bihong Yu <yubih...@huawei.com>
Reviewed-by: Chuan Zheng <zhengch...@huawei.com>
OK, sometimes I find initialisation clearer
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
---
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 09178cc..2da2b62 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2743,7 +2743,7 @@ static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void
*host)
*/
static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)
{
- static RAMBlock *block = NULL;
+ static RAMBlock *block;
OK.
char id[256];
uint8_t len;
diff --git a/migration/savevm.c b/migration/savevm.c
index 9e95df1..f808bc2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -64,7 +64,7 @@
#include "qemu/bitmap.h"
#include "net/announce.h"
-const unsigned int postcopy_ram_discard_version = 0;
+const unsigned int postcopy_ram_discard_version;
I agree with Dave, this one is clearer initialized.
/* Subcommands for QEMU_VM_COMMAND */
enum qemu_vm_cmd {
--
1.8.3.1
