答复: [PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-19 Thread FelixCui-oc
hi paolo, >2) you're adding a check for the host, but the bug applies to all hosts. >If there is a bug on x86 hardware emulation, it should be fixed even >when emulating x86 from ARM. It should also apply to all CPU vendors. What is the progress of handling this bug ? If the processing is mor

Re: [PATCH 0/4] RfC: microvm: add second ioapic

2020-10-19 Thread Gerd Hoffmann
On Fri, Oct 16, 2020 at 03:16:20PM +0200, Philippe Mathieu-Daudé wrote: > On 10/16/20 1:43 PM, Gerd Hoffmann wrote: > > Add a second ioapic to microvm. Gives us more IRQ lines we can > > use for virtio-mmio devices. Bump number of possible virtio-mmio > > devices from 8 to 24. > > > > Gerd Hoff

Re: [PULL 00/13] qemu-macppc queue 20201018

2020-10-19 Thread Mark Cave-Ayland
On 18/10/2020 16:59, Mark Cave-Ayland wrote: The following changes since commit e12ce85b2c79d83a340953291912875c30b3af06: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2020-10-16 22:46:28 +0100) are available in the Git repository at: git://gi

[PULL v2 00/13] qemu-macppc queue 20201019

2020-10-19 Thread Mark Cave-Ayland
emu-macppc-20201019 for you to fetch changes up to bb997e5c967b3b6f19f1461811df6317ed37c5ff: mac_oldworld: Change PCI address of macio to match real hardware (2020-10-19 08:11:21 +0100) qemu-macp

Re: [PATCH v7 00/11] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2020-10-19 Thread Niklas Cassel
On Mon, Oct 19, 2020 at 11:17:15AM +0900, Dmitry Fomichev wrote: (snip) > > Dmitry Fomichev (9): > hw/block/nvme: Add Commands Supported and Effects log > hw/block/nvme: Generate namespace UUIDs > hw/block/nvme: Support Zoned Namespace Command Set > hw/block/nvme: Introduce max active an

Re: [PATCH v6 03/36] qapi-gen: Separate arg-parsing from generation

2020-10-19 Thread Markus Armbruster
John Snow writes: > On 10/9/20 1:26 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> This is a minor re-work of the entrypoint script. It isolates a >> entrypoint is not a word ;-P >> > > I'm not entirely sure why a German is complaining about the birth of a > new and beautiful compou

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/12/20 1:50 PM, BALATON Zoltan via wrote: >> On Mon, 12 Oct 2020, David Gibson wrote: >>> On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe >>> Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: > On Sun, Oct 11, 2020 at 09:03:32P

[PATCH 08/14] spice: wire up monitor in QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Rename qmp_query_spice() to qmp_query_spice_real(), add to QemuSpiceOps. Add new qmp_query_spice() function which calls the real function via QemuSpiceOps if available, otherwise return SpiceInfo.enabled = false. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 3 +++ ui/spice

[PATCH 04/14] spice: move display_init() to QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 1 + include/ui/qemu-spice.h| 7 --- softmmu/vl.c | 2 +- ui/spice-core.c| 1 + ui/spice-module.c | 9 + 5 files changed, 12 insertions(+), 8 deletions(-) diff --g

[PATCH 09/14] spice: load module when enabled on the cmdline

2020-10-19 Thread Gerd Hoffmann
In case the spice opts are not registered, try loading the spice module. Signed-off-by: Gerd Hoffmann --- softmmu/vl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 8a06fe8bf77a..14fc527fc6e0 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.

[PATCH 01/14] spice: add module helpers

2020-10-19 Thread Gerd Hoffmann
Add new spice-module.c + qemu-spice-module.h files. The code needed to support modular spice will be there. For starters this will be only the using_spice variable, more will follow ... Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 23 +++ include/ui/qem

[PATCH 06/14] spice: move auth functions to QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Move qemu_spice_set_passwd() and qemu_spice_set_pw_expire() functions to QemuSpiceOps. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 3 +++ include/ui/qemu-spice.h| 14 -- monitor/qmp-cmds.c | 4 ++-- ui/spice-core.c| 10 +

[PATCH 11/14] modules: add spice dependencies

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/module.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/module.c b/util/module.c index 0c0f258923dc..21237dcc24df 100644 --- a/util/module.c +++ b/util/module.c @@ -176,6 +176,11 @@ static const struct { const char *name; const char *

[PATCH 12/14] spice: flip modules switch

2020-10-19 Thread Gerd Hoffmann
Build spice core code as module. This removes libspice-server and a handful of indirect dependencies from core qemu. The number of shared libraries for qemu-system-x86_64 goes down from 73 to 66 on my system. Signed-off-by: Gerd Hoffmann --- ui/meson.build | 11 ++- 1 file changed, 10

[PATCH 02/14] spice: add QemuSpiceOps, move migrate_info

2020-10-19 Thread Gerd Hoffmann
Add QemuSpiceOps struct. This struct holds function pointers to the spice functions. It will be initialized with pointers to the stub functions. When spice gets initialized the function pointers will be re-written to the real functions. The spice stubs will move from qemu-spice.h to spice-modul

Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: >> Reduce the machine code pulled into qemu-storage-daemon. >> >> The series is fully Acked, but Markus wants it reviewed >> by the Machine core maintainers. > > I've confirmed that all patches move

Re: [PATCH v2 1/2] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup

2020-10-19 Thread Jason Wang
On 2020/10/16 上午11:09, Cindy Lu wrote: fix the bug that fd will still open after the cleanup Signed-off-by: Cindy Lu --- net/vhost-vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index bc0e0d2d35..0480b92102 100644 --- a/net/vhost-vdpa.c +

Re: [PATCH v2 2/2] net: Add vhost-vdpa in show_netdevs()

2020-10-19 Thread Jason Wang
On 2020/10/16 上午11:09, Cindy Lu wrote: Fix the bug that while Check qemu supported netdev, there is no vhost-vdpa Signed-off-by: Cindy Lu --- net/net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/net.c b/net/net.c index 7a2a0fb5ac..794c652282 100644 --- a/net/net.c +++ b/net

[PATCH 14/14] opengl: build opengl helper code modular

2020-10-19 Thread Gerd Hoffmann
Removes opengl dependency from core qemu. The number of shared libraries for qemu-system-x86_64 goes down from 66 to 60 on my system. Signed-off-by: Gerd Hoffmann --- util/module.c | 7 +++ ui/meson.build | 8 +++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/util/mod

[PATCH 00/14] ui: build spice and opengl as module.

2020-10-19 Thread Gerd Hoffmann
- Add QemuSpiceOps, reorganize spice stubs. - Add support for module dependencies. - Build spice-core modular, and make the existing spice modules (audio, chardev, qxl) depend on spice-core. - Build egl-headless display and opengl helpers modular (pretty easy thanks to module dependencies). Ge

[PATCH 10/14] modules: dependencies infrastructure

2020-10-19 Thread Gerd Hoffmann
Allow modules depending on other modules. module_load_file() gets the option to export symbols (by not adding the G_MODULE_BIND_LOCAL flag). module_load_one() will check the module dependency list to figure (a) whenever are other modules must be loaded first, or (b) the module should export the s

[PATCH 13/14] opengl: build egl-headless display modular

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/meson.build b/ui/meson.build index 996e1d13ab34..3cf03d2c297b 100644 --- a/ui/meson.build +++ b/ui/meson.build @@ -34,7 +34,6 @@ vnc_ss.add(when: sasl, if_true: files('vnc

[PATCH 05/14] spice: move add_interface() to QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 7 +++ include/ui/qemu-spice.h| 1 - audio/spiceaudio.c | 4 ++-- chardev/spice.c| 2 +- ui/spice-core.c| 5 +++-- ui/spice-input.c | 6 +++--- 6 files changed,

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-19 Thread Thomas Huth
On 19/10/2020 03.39, Joelle van Dyne wrote: > From: osy > > The iOS toolchain does not use the host prefix naming convention. We add a > new option `--enable-cross-compile` that forces cross-compile even without > a cross_prefix. > > Signed-off-by: Joelle van Dyne > --- > configure | 13 ++

[PATCH 03/14] spice: move qemu_spice_init() to QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 1 + include/ui/qemu-spice.h| 5 - softmmu/vl.c | 2 +- ui/spice-core.c| 3 ++- ui/spice-module.c | 5 + 5 files changed, 9 insertions(+), 7 deletions(-) diff --git a/

[PATCH 07/14] spice: move display_add_client() to QemuSpiceOps.

2020-10-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/qemu-spice-module.h | 1 + include/ui/qemu-spice.h| 6 -- monitor/qmp-cmds.c | 2 +- ui/spice-core.c| 3 ++- ui/spice-module.c | 7 +++ 5 files changed, 11 insertions(+), 8 deletions(-) diff --gi

Re: [PULL 00/34] QAPI patches patches for 2020-10-10

2020-10-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/10/20 11:54 AM, Markus Armbruster wrote: >> The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1: >>Merge remote-tracking branch >> 'remotes/dgibson/tags/ppc-for-5.2-20201009' into staging (2020-10-09 >> 15:48:04 +0100) >> are avai

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-19 Thread Thomas Huth
On 19/10/2020 10.07, Thomas Huth wrote: > On 19/10/2020 03.39, Joelle van Dyne wrote: >> From: osy >> >> The iOS toolchain does not use the host prefix naming convention. We add a >> new option `--enable-cross-compile` that forces cross-compile even without >> a cross_prefix. >> >> Signed-off-by:

Re: [PATCH] softfloat: Mark base int-to-float routines QEMU_FLATTEN

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/18/20 10:33 PM, Richard Henderson wrote: This merges the int_to_float routine and the round_pack_canonical routine into the same function, allowing the FloatParts structure to be decomposed by the compiler. This results in a 60-75% speedup of the flattened function. Leave the narrower int

[PATCH] docs/system: Deprecate raspi2/raspi3 machine aliases

2020-10-19 Thread Philippe Mathieu-Daudé
Since commit aa35ec2213b ("hw/arm/raspi: Use more specific machine names") the raspi2/raspi3 machines have been renamed as raspi2b/raspi3b. As more Raspberry Pi 2/3 models are emulated, in order to avoid confusion deprecate the raspi2/raspi3 machine aliases. Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-19 Thread Daniel P . Berrangé
On Fri, Oct 16, 2020 at 10:26:16AM +0200, Philippe Mathieu-Daudé wrote: > Le jeu. 15 oct. 2020 22:22, Bruce Rogers a écrit : > > > These files are not needed for a linux-user only install. > > > > Signed-off-by: Bruce Rogers > > --- > > ui/meson.build | 7 +-- > > 1 file changed, 5 insert

Re: [PULL v2 00/22] Build system + misc changes for 2020-10-16

2020-10-19 Thread Paolo Bonzini
On 17/10/20 21:48, Peter Maydell wrote: >> 1) are you going to pull v3 and I can fix up everything later? Or would >> you prefer me to send v4 once the new curses test is reviewed? > > If the only issue with v3 is that stray warning message I'm > OK with applying it and improving the test later.

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Bihong Yu (yubih...@huawei.com) wrote: >> Signed-off-by: Bihong Yu >> Reviewed-by: Chuan Zheng > > Yes that's OK, I'm a bit sturprised we need the space afte rthe * in the > VMStateDescription case, I wouldn't necessarily go and change them all. We don't: i

Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-19 Thread Ivan Griffin
Hi Bin, Well spotted with the register map. I grepped it for 0x3702 and didn't find it, but it seems the address (incorrectly) is 0x0702 in the documentation. Thanks, Ivan. From: Bin Meng Sent: Monday 19 October 2020 03:05 To: Ivan Griffin Cc: Alistair

Re: [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac

2020-10-19 Thread Thomas Huth
On 19/10/2020 03.39, Joelle van Dyne wrote: > From: osy That "From:" line looks wrong ... could you please fix the "Author" of your patches / your git config? > macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure > will succeed with CONFIG_PREADV even when targeting a lower

Re: [PATCH] docs/system: Deprecate raspi2/raspi3 machine aliases

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 10:21 AM, Philippe Mathieu-Daudé wrote: Since commit aa35ec2213b ("hw/arm/raspi: Use more specific machine names") the raspi2/raspi3 machines have been renamed as raspi2b/raspi3b. As more Raspberry Pi 2/3 models are emulated, in order to avoid confusion deprecate the raspi2/raspi3 ma

Re: [PATCH v2 0/9] iOS and Apple Silicon host support

2020-10-19 Thread Thomas Huth
On 19/10/2020 03.39, Joelle van Dyne wrote: > These set of changes brings QEMU TCG to iOS devices and future Apple Silicon > devices. They were originally developed last year and have been working in the > UTM app. Recently, we ported the changes to master, re-wrote a lot of the > build > script c

Re: [PATCH 0/4] RfC: microvm: add second ioapic

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 9:07 AM, Gerd Hoffmann wrote: On Fri, Oct 16, 2020 at 03:16:20PM +0200, Philippe Mathieu-Daudé wrote: On 10/16/20 1:43 PM, Gerd Hoffmann wrote: Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices

Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-19 Thread Bin Meng
Hi Ivan, On Mon, Oct 19, 2020 at 4:17 PM Ivan Griffin wrote: > > Hi Bin, > > Well spotted with the register map. I grepped it for 0x3702 and didn't > find it, but it seems the address (incorrectly) is 0x0702 in the > documentation. > I believe the documented offset 0x0702 is the of

Re: [PULL v3 00/22] Build system + misc changes for 2020-10-16

2020-10-19 Thread Peter Maydell
On Sat, 17 Oct 2020 at 15:50, Paolo Bonzini wrote: > > The following changes since commit 3e40748834923798aa57e3751db13a069e2c617b: > > Merge remote-tracking branch 'remotes/rth/tags/pull-mb-20201014' into > staging (2020-10-15 20:30:24 +0100) > > are available in the Git repository at: > > h

Re: [PATCH] hw/riscv: microchip_pfsoc: IOSCBCTRL memmap entry

2020-10-19 Thread Ivan Griffin
Yes, it could be. But the "Physical Address" column, in my mind, should be the 0x3702 address. At least when I check other peripherals, their physical address values in the register map HTML corresponds to the source code. Cheers, Ivan. From: Bin Meng Sen

[PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

2020-10-19 Thread Greg Kurz
pc_dimm_plug() doesn't use it. It only aborts on error. Drop @errp and adapt the callers accordingly. Signed-off-by: Greg Kurz --- hw/arm/virt.c|9 + hw/i386/pc.c |8 +--- hw/mem/pc-dimm.c |2 +- hw/ppc/spapr.c |5 + incl

[PATCH 2/5] spapr: Use appropriate getter for PC_DIMM_ADDR_PROP

2020-10-19 Thread Greg Kurz
The PC_DIMM_ADDR_PROP property is defined as: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), Use object_property_get_uint() instead of object_property_get_int(). Signed-off-by: Greg Kurz --- hw/ppc/spapr.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 0/5] spapr: Error handling fixes and cleanups (round 3)

2020-10-19 Thread Greg Kurz
Hi, This is a followup to a previous cleanup for the sPAPR code: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg04860.html The last two patches had to be dropped because they were wrongly assuming that object_property_get_uint() returning zero meant failure. This led to a discussion in

[PATCH 5/5] spapr: Simplify error handling in spapr_memory_plug()

2020-10-19 Thread Greg Kurz
As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_plug(). This allows to get rid of the error propagation overhead. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c| 23 ++-

[PATCH 3/5] spapr: Use appropriate getter for PC_DIMM_SLOT_PROP

2020-10-19 Thread Greg Kurz
The PC_DIMM_SLOT_PROP property is defined as: DEFINE_PROP_INT32(PC_DIMM_SLOT_PROP, PCDIMMDevice, slot, PC_DIMM_UNASSIGNED_SLOT), Use object_property_get_int() instead of object_property_get_uint(). Since spapr_memory_plug() only gets called if pc_dimm_pre_plug() succeede

[PATCH 4/5] spapr: Pass &error_abort when getting some PC DIMM properties

2020-10-19 Thread Greg Kurz
Both PC_DIMM_SLOT_PROP and PC_DIMM_ADDR_PROP are defined in the default property list of the PC DIMM device class: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), DEFINE_PROP_INT32(PC_DIMM_SLOT_PROP, PCDIMMDevice, slot, PC_DIMM_UNASSIGNED_SLOT), They s

Re: [PATCH] docs/system: Deprecate raspi2/raspi3 machine aliases

2020-10-19 Thread Peter Krempa
On Mon, Oct 19, 2020 at 10:21:21 +0200, Philippe Mathieu-Daudé wrote: > Since commit aa35ec2213b ("hw/arm/raspi: Use more > specific machine names") the raspi2/raspi3 machines > have been renamed as raspi2b/raspi3b. > > As more Raspberry Pi 2/3 models are emulated, in order > to avoid confusion d

Re: [PULL 09/14] qmp: Move dispatcher to a coroutine

2020-10-19 Thread Kevin Wolf
Am 17.10.2020 um 10:15 hat Volker Rümelin geschrieben: > > From: Kevin Wolf > > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > handlers that declare 'coroutine': true in coroutine context so they > > can avoid blocking the main loop while doing I/O or waiting for ot

Re: [PATCH v4 1/7] keyval: Fix and clarify grammar

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/11/20 2:34 AM, Markus Armbruster wrote: >> The grammar has a few issues: >> * key-fragment = / [^=,.]* / >>Prose restricts key fragments: they "must be valid QAPI names or >>consist only of decimal digits". Technically, '' consists only of >>decimal digits.

Re: [PATCH v4 4/7] keyval: Parse help options

2020-10-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.10.2020 um 09:35 hat Markus Armbruster geschrieben: >> From: Kevin Wolf >> >> This adds a special meaning for 'help' and '?' as options to the keyval >> parser. Instead of being an error (because of a missing value) or a >> value for an implied key, they now request h

Re: [PATCH 2/5] spapr: Use appropriate getter for PC_DIMM_ADDR_PROP

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 10:48 AM, Greg Kurz wrote: The PC_DIMM_ADDR_PROP property is defined as: DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0), Use object_property_get_uint() instead of object_property_get_int(). Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH v4 4/7] keyval: Parse help options

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/11/20 2:35 AM, Markus Armbruster wrote: >> From: Kevin Wolf >> This adds a special meaning for 'help' and '?' as options to the >> keyval >> parser. Instead of being an error (because of a missing value) or a >> value for an implied key, they now request help, which is

Re: [PATCH 3/5] spapr: Use appropriate getter for PC_DIMM_SLOT_PROP

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 10:48 AM, Greg Kurz wrote: The PC_DIMM_SLOT_PROP property is defined as: DEFINE_PROP_INT32(PC_DIMM_SLOT_PROP, PCDIMMDevice, slot, PC_DIMM_UNASSIGNED_SLOT), Worth adding: #define PC_DIMM_UNASSIGNED_SLOT -1 for better understanding why it is signed

Re: [PATCH v4 0/7] qemu-storage-daemon: Remove QemuOpts from --object

2020-10-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.10.2020 um 09:34 hat Markus Armbruster geschrieben: >> This replaces the QemuOpts-based help code for --object in the storage >> daemon with code based on the keyval parser. >> >> Review of v3 led me to preexisting issues. Instead of posting my >> fixes separately, th

Re: [PATCH 0/4] RfC: microvm: add second ioapic

2020-10-19 Thread Gerd Hoffmann
Hi, > /me updates the WIP microvm blog post ;) Online now. https://www.kraxel.org/blog/2020/10/qemu-microvm-acpi/ take care, Gerd

Re: [PATCH 5/5] spapr: Simplify error handling in spapr_memory_plug()

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 10:49 AM, Greg Kurz wrote: As recommended in "qapi/error.h", add a bool return value to spapr_add_lmbs() and spapr_add_nvdimm(), and use them instead of local_err in spapr_memory_plug(). This allows to get rid of the error propagation overhead. Signed-off-by: Greg Kurz --- hw/ppc

[PATCH] [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

2020-10-19 Thread Zenghui Yu
Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA translation can work properly during migration. Signed-off-by: Zenghui Yu --- not sure if anything would actually go wrong... hw/arm/smmuv3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smm

Re: [PATCH] monitor: Fix order in monitor_cleanup()

2020-10-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.10.2020 um 19:20 hat Alex Bennée geschrieben: >> >> Kevin Wolf writes: >> >> > We can only destroy Monitor objects after we're sure that they are not >> > in use by the dispatcher coroutine any more. This fixes crashes like the >> > following where we tried to des

Re: io_uring possibly the culprit for qemu hang (linux-5.4.y)

2020-10-19 Thread Pankaj Gupta
@Jack Wang, Maybe four io_uring patches in 5.4.71 fixes the issue for you as well? Thanks, Pankaj > Hi Jens. > > On Sat, Oct 17, 2020 at 3:07 AM Jens Axboe wrote: > > > > Would be great if you could try 5.4.71 and see if that helps for your > > issue. > > > > Oh wow, yeah it did fix the issue. >

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > The reporter states neither the source nor destination hardware supports > > SVE. My guess is that what's happening is the reserved ID register > > ID_UNALLOCATED(4,4) was showing

Re: [PULL 25/33] tests/acceptance: Add a test for the N800 and N810 arm machines

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 8:31 AM, Thomas Huth wrote: On 17/10/2020 19.51, Philippe Mathieu-Daudé wrote: Hi Peter, Igor, Thomas, On 2/28/20 5:38 PM, Peter Maydell wrote: From: Thomas Huth Old kernels from the Meego project can be used to check that Linux is at least starting on these machines. Signed-off

[PATCH] ACPI: Avoid infinite recursion when dump-vmstate

2020-10-19 Thread Peng Liang
There is a field with vmstate_ghes_state as vmsd in vmstate_ghes_state, which will lead to infinite recursion in dump_vmstate_vmsd. Fixes: a08a64627b ("ACPI: Record the Generic Error Status Block address") Reported-by: Euler Robot Signed-off-by: Peng Liang --- hw/acpi/generic_event_device.c | 3

[PATCH] microbit_i2c: Fix coredump when dump-vmstate

2020-10-19 Thread Peng Liang
VMStateDescription.fields should be end with VMSTATE_END_OF_LIST(). However, microbit_i2c_vmstate doesn't follow it. Let's change it. Fixes: 9d68bf564e ("arm: Stub out NRF51 TWI magnetometer/accelerometer detection") Reported-by: Euler Robot Signed-off-by: Peng Liang --- hw/i2c/microbit_i2c.c

Re: [PULL 25/33] tests/acceptance: Add a test for the N800 and N810 arm machines

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 11:30 AM, Philippe Mathieu-Daudé wrote: On 10/19/20 8:31 AM, Thomas Huth wrote: On 17/10/2020 19.51, Philippe Mathieu-Daudé wrote: Hi Peter, Igor, Thomas, On 2/28/20 5:38 PM, Peter Maydell wrote: From: Thomas Huth Old kernels from the Meego project can be used to check that Linu

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Bihong Yu
Yes, I used to think "const VMStateDescription *[]" was right, but when I search similar expressions, most of all are "xxx * []". Such as: fsdev/qemu-fsdev.c:54:.opts = (const char * []) hw/intc/s390_flic_kvm.c:567:.subsections = (const VMStateDescription * []) ... So, I keep the same

Re: [Virtio-fs] [PATCH v3] virtiofsd: add container-friendly -o sandbox=chroot option

2020-10-19 Thread Chirantan Ekbote
On Thu, Oct 8, 2020 at 5:55 PM Stefan Hajnoczi wrote: > > virtiofsd cannot run in a container because CAP_SYS_ADMIN is required to > create namespaces. > In crosvm we deal with this by also creating a user namespace, which then allows us to create the mount, net, and pid namespaces as well. Could

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-19 Thread Andrea Bolognani
On Wed, 2020-10-14 at 10:29 -0400, John Snow wrote: > Python infrastructure as it exists today is not capable reliably of > single-sourcing a package version from a parent directory. The authors > of pip are working to correct this, but as of today this is not possible > to my knowledge. > > The p

[PATCH] meson: rewrite curses/iconv test

2020-10-19 Thread Paolo Bonzini
Redo the curses test to do the same tests that the configure check used to do. OpenBSD triggers the warning because it does not support NCURSES_WIDECHAR and thus the cc.links test fails. Signed-off-by: Paolo Bonzini --- meson.build | 109 +--- 1 f

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Define values and structures that are needed to support Zoned > Namespace Command Set (NVM

[PATCH] hw/arm/nseries: Fix loading kernel image on n8x0 machines

2020-10-19 Thread Philippe Mathieu-Daudé
Commit 7998beb9c2e removed the ram_size initialization in the arm_boot_info structure, however it is used by arm_load_kernel(). Initialize the field to fix: $ qemu-system-arm -M n800 -append 'console=ttyS1' \ -kernel meego-arm-n8x0-1.0.80.20100712.1431-vmlinuz-2.6.35~rc4-129.1-n8x0 qemu-s

Re: [PULL v2 0/5] 9p queue (previous 2020-10-15)

2020-10-19 Thread Peter Maydell
On Sat, 17 Oct 2020 at 15:23, Christian Schoenebeck wrote: > > The following changes since commit e12ce85b2c79d83a340953291912875c30b3af06: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2020-10-16 22:46:28 +0100) > > are available in the Git repo

Re: [PATCH] softfpu: Generalize pick_nan_muladd to opaque structures

2020-10-19 Thread Alex Bennée
Richard Henderson writes: > This will allow us to share code between FloatParts and FloatParts128. > > Signed-off-by: Richard Henderson > --- > Cc: Alex Bennee > > What do you think of this instead of inlining pick_nan_muladd > into the two muladd implementations? I think that can work. I wa

Re: [PATCH v2 03/15] python: add VERSION file

2020-10-19 Thread Daniel P . Berrangé
On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote: > On Wed, 2020-10-14 at 10:29 -0400, John Snow wrote: > > Python infrastructure as it exists today is not capable reliably of > > single-sourcing a package version from a parent directory. The authors > > of pip are working to correc

Re: [PATCH] softfloat: Mark base int-to-float routines QEMU_FLATTEN

2020-10-19 Thread Alex Bennée
Richard Henderson writes: > This merges the int_to_float routine and the round_pack_canonical > routine into the same function, allowing the FloatParts structure > to be decomposed by the compiler. > > This results in a 60-75% speedup of the flattened function. > > Leave the narrower integer in

Re: [PATCH] accel/kvm: add PIO ioeventfds only in case kvm_eventfds_allowed is true

2020-10-19 Thread Stefan Hajnoczi
On Sat, Oct 17, 2020 at 02:01:01PM -0700, Elena Afanasova wrote: > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Elena Afanasova > --- > accel/kvm/kvm-all.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Additional information for the commit description: MMIO eventfd_add/del

Re: [PATCH v4 0/3] unbreak non-tcg builds

2020-10-19 Thread Claudio Fontana
Hi all, anything more for me to do here? On 10/13/20 9:21 PM, Claudio Fontana wrote: > This series now unbreaks current non-tcg builds > (!CONFIG_TCG). > > tests Makefiles need to avoid relying on all non-native > archs binaries to be present, > > bios-tables-test needs to skip tests that are t

Re: [PATCH v3 2/3] accel/tcg: split tcg_start_vcpu_thread

2020-10-19 Thread Claudio Fontana
Hi all, is this one ok now in your view? Thanks, Claudio On 10/15/20 4:32 PM, Claudio Fontana wrote: > after the initial split into 3 tcg variants, we proceed to also > split tcg_start_vcpu_thread. > > We actually split it in 2 this time, since the icount variant > just uses the round robin fu

Re: [PATCH 02/14] spice: add QemuSpiceOps, move migrate_info

2020-10-19 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Add QemuSpiceOps struct. This struct holds function pointers to the > spice functions. It will be initialized with pointers to the stub > functions. When spice gets initialized the function pointers will > be re-written to the real functions. > > The

Re: [PULL v2 0/5] 9p queue (previous 2020-10-15)

2020-10-19 Thread Christian Schoenebeck
On Montag, 19. Oktober 2020 11:52:38 CEST Peter Maydell wrote: > On Sat, 17 Oct 2020 at 15:23, Christian Schoenebeck > > wrote: > > The following changes since commit e12ce85b2c79d83a340953291912875c30b3af06: > > Merge remote-tracking branch > > 'remotes/ehabkost/tags/x86-next-pull-request'

Re: [PULL v2 0/5] 9p queue (previous 2020-10-15)

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 11:19, Christian Schoenebeck wrote: > > On Montag, 19. Oktober 2020 11:52:38 CEST Peter Maydell wrote: > > This emits a lot of new warnings during 'make check': > > > > PASS 27 qtest-arm: qos-test > > /arm/virt/virtio-mmio/virtio-bus/virtio-9p-device/virtio-9p/virtio-9p-test

Re: [PATCH] softmmu/memory: fix memory_region_ioeventfd_equal()

2020-10-19 Thread Stefan Hajnoczi
On Sat, Oct 17, 2020 at 02:01:02PM -0700, Elena Afanasova wrote: > Eventfd can be registered with a zero length when fast_mmio is true. > Handle this case properly when dispatching through QEMU. > > Signed-off-by: Elena Afanasova > --- > softmmu/memory.c | 15 +++ > 1 file changed, 1

Re: [PULL v2 0/5] 9p queue (previous 2020-10-15)

2020-10-19 Thread Christian Schoenebeck
On Montag, 19. Oktober 2020 12:22:47 CEST Peter Maydell wrote: > On Mon, 19 Oct 2020 at 11:19, Christian Schoenebeck > > wrote: > > On Montag, 19. Oktober 2020 11:52:38 CEST Peter Maydell wrote: > > > This emits a lot of new warnings during 'make check': > > > > > > PASS 27 qtest-arm: qos-test >

Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

2020-10-19 Thread Erik Skultety
... > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory > new file mode 100644 > index 00..8bb7ba6b33 > --- /dev/null > +++ b/scripts/ci/setup/inventory > @@ -0,0 +1,2 @@ > +[local] Nit pick, is a group for localhost actually needed? Regards, Erik

Re: [PATCH v4 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2020-10-19 Thread Daniel P . Berrangé
On Sun, Oct 18, 2020 at 09:50:03PM -0400, Cleber Rosa wrote: > The QEMU project has two machines (aarch64 and s390) that can be used > for jobs that do build and run tests. This introduces those jobs, > which are a mapping of custom scripts used for the same purpose. > > Signed-off-by: Cleber Ros

Re: [PATCH v4 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

2020-10-19 Thread Erik Skultety
On Sun, Oct 18, 2020 at 09:50:02PM -0400, Cleber Rosa wrote: > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduc

Re: [PATCH] microbit_i2c: Fix coredump when dump-vmstate

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 11:34 AM, Peng Liang wrote: VMStateDescription.fields should be end with VMSTATE_END_OF_LIST(). However, microbit_i2c_vmstate doesn't follow it. Let's change it. It might be easy to add a Coccinelle script to avoid future errors. Reviewed-by: Philippe Mathieu-Daudé Fixes: 9d68

Re: [PATCH v4 01/12] libqos/qgraph: add qemu_name to QOSGraphNode

2020-10-19 Thread Christian Schoenebeck
On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote: > Add new member variable 'qemu_name' to struct QOSGraphNode. > > This new member may be optionally set in case a different > name for the node (which must always be a unique name) vs. > its actually associated QEMU (QMP) de

Re: [PATCH 6/30] semihosting: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 16/10/2020 16.42, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH 5/30] mips tcg: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 16/10/2020 16.35, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH 7/30] non-virt: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 16/10/2020 16.53, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH 2/30] io: Fix Lesser GPL version number

2020-10-19 Thread Daniel P . Berrangé
On Wed, Oct 14, 2020 at 01:40:33PM +, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment sec

Re: [PATCH 4/30] authz: Fix Lesser GPL version number

2020-10-19 Thread Daniel P . Berrangé
On Wed, Oct 14, 2020 at 01:49:02PM +, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment sec

[PATCH v2 1/5] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-10-19 Thread Eugenio Pérez
Previous name didn't reflect the iommu operation. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: David Gibson Reviewed-by: Juan Quintela Reviewed-by: Eric Auger --- include/exec/memory.h | 6 +++--- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/i386/intel_io

Re: [PATCH 3/30] crypt: Fix Lesser GPL version number

2020-10-19 Thread Daniel P . Berrangé
On Wed, Oct 14, 2020 at 01:42:48PM +, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment sec

[PATCH v2 1/5] memory: Rename memory_region_notify_one to memory_region_notify_iommu_one

2020-10-19 Thread Eugenio Pérez
Previous name didn't reflect the iommu operation. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: David Gibson Reviewed-by: Juan Quintela Reviewed-by: Eric Auger --- include/exec/memory.h | 6 +++--- hw/arm/smmu-common.c | 2 +- hw/arm/smmuv3.c | 2 +- hw/i386/intel_io

Re: [PATCH v4 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 3:50 AM, Cleber Rosa wrote: The QEMU project has two machines (aarch64 and s390) that can be used "s390x" =) for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa --- .gitl

Re: [PATCH 8/30] powerpc tcg: Fix Lesser GPL version number

2020-10-19 Thread Daniel P . Berrangé
This subject line says 8/30, but I've never received patches 9->30, and I don't see them in the mailing list archive either... On Mon, Oct 19, 2020 at 06:11:26AM +, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser

[PATCH v2 2/5] memory: Add IOMMUTLBEvent

2020-10-19 Thread Eugenio Pérez
This way we can tell between regular IOMMUTLBEntry (entry of IOMMU hardware) and notifications. In the notifications, we set explicitly if it is a MAPs or an UNMAP, instead of trusting in entry permissions to differentiate them. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: Ju

[PATCH v2 0/5] memory: Skip assertion in memory_region_unregister_iommu_notifier

2020-10-19 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line: /h

  1   2   3   4   5   >