[PATCH V14 4/8] target/mips: Add loongson-ext lsdc2 group of instructions

2020-10-16 Thread Huacai Chen
From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4 bytes to GPR gsldx: load 8 bytes to GPR gslwxc

Re: [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device

2020-10-16 Thread Mark Cave-Ayland
On 16/10/2020 01:16, David Gibson wrote: On Tue, Oct 13, 2020 at 12:49:20PM +0100, Mark Cave-Ayland wrote: Instead use qdev_prop_set_chr() to configure the ESCC serial chardevs at the Mac Old World and New World machine level. Also remove the now obsolete comment referring to the use of serial

[PATCH V14 5/8] hw/mips: Implement fw_cfg_arch_key_name()

2020-10-16 Thread Huacai Chen
Implement fw_cfg_arch_key_name(), which returns the name of a mips-specific key. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- hw/mips/fw_cfg.c| 35 +++ hw/mips/fw_cfg.h| 19 +++ hw/mips/m

Re: [PATCH V14 0/8] mips: Add Loongson-3 machine support

2020-10-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1602831120-3377-1-git-send-email-che...@lemote.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602831120-3377-1-git-send-email-che...@lemote.com Subject: [PATCH V14 0/8] mips:

Re: [PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-16 Thread Paolo Bonzini
On 15/10/20 22:18, Bruce Rogers wrote: > These files are not needed for a linux-user only install. > > Signed-off-by: Bruce Rogers > --- > ui/meson.build | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/ui/meson.build b/ui/meson.build > index 78ad792ffb..fb36d305c

Re: [PATCH v10 01/10] virtio-iommu: Fix virtio_iommu_mr()

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > Due to an invalid mask, virtio_iommu_mr() may return the wrong memory > region. It hasn't been too problematic so far because the function was > only used to test existence of an endpoint, but that is about to change. > > Fixes: cfb42188

Re: [PATCH v10 02/10] virtio-iommu: Store memory region in endpoint struct

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > Store the memory region associated to each endpoint into the endpoint > structure, to allow efficient memory notification on map/unmap. > > Signed-off-by: Jean-Philippe Brucker Acked-by: Eric Auger > --- > Not super confident about th

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
Here is a better way to write the meson test: if get_option('sphinx_build') == '' sphinx_build = find_program(['sphinx-build-3', 'sphinx-build'], required: get_option('docs')) else sphinx_build = find_program(get_option('sphinx_build'),

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:46 PM Paolo Bonzini wrote: > > Here is a better way to write the meson test: > > if get_option('sphinx_build') == '' > sphinx_build = find_program(['sphinx-build-3', 'sphinx-build'], > required: get_option('docs')) > else > sphinx_build =

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > >> build_docs = false >> if sphinx_build.found() >>   # This is a bit awkward but works: create a trivial document and >>   # try to run it with our configuration file (which enforces a >>   # version requirement). This will fail if sphinx-build is too

Re: [PATCH v10 03/10] virtio-iommu: Add memory notifiers for map/unmap

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Extend VIRTIO_IOMMU_T_MAP/UNMAP request to notify memory listeners. It > will call VFIO notifier to map/unmap regions in the physical IOMMU. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Eric Auger > Sig

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to run it with our configuration file (which enforces a

[PATCH] hax: unbreak accelerator cpu code after cpus.c split

2020-10-16 Thread Claudio Fontana
during my split of cpus.c, code line "current_cpu = cpu" was removed by mistake, causing hax to break. This commit fixes the situation restoring it. Reported-by: Volker Rümelin Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc Signed-off-by: Claudio Fontana --- target/i386/hax-cpus.c | 1 + 1 fi

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to run it with our configuration file (which enforces a

Re: [PULL 07/37] cpus: extract out hax-specific code to target/i386/

2020-10-16 Thread Claudio Fontana
On 10/16/20 8:48 AM, Volker Rümelin wrote: >> From: Claudio Fontana >> >> register a "CpusAccel" interface for HAX as well. >> > >> diff --git a/softmmu/cpus.c b/softmmu/cpus.c >> index 9fa73735a2..900fff827a 100644 >> --- a/softmmu/cpus.c >> +++ b/softmmu/cpus.c >> @@ -416,35 +403,6 @@ void qemu

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
On 16/10/20 09:57, Paolo Bonzini wrote: > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: >> >>> build_docs = false >>> if sphinx_build.found() >>>   # This is a bit awkward but works: create a trivial document and >>>   # try to run it with our configuration file (which enforces a >>>   # version requ

Re: [PATCH v10 04/10] virtio-iommu: Call memory notifiers in attach/detach

2020-10-16 Thread Auger Eric
Hi jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Call the memory notifiers when attaching an endpoint to a domain, to > replay existing mappings, and when detaching the endpoint, to remove all > mappings. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Je

Re: [PATCH] hax: unbreak accelerator cpu code after cpus.c split

2020-10-16 Thread Paolo Bonzini
On 16/10/20 10:00, Claudio Fontana wrote: > during my split of cpus.c, code line > "current_cpu = cpu" > was removed by mistake, causing hax to break. > > This commit fixes the situation restoring it. > > Reported-by: Volker Rümelin > Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc > Signed-off-

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:05 PM Paolo Bonzini wrote: > > On 16/10/20 09:57, Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > >> > >>> build_docs = false > >>> if sphinx_build.found() > >>> # This is a bit awkward but works: create a trivial document and > >>> # try to run

[PATCH v5 2/4] configure: the docdir option should passed to meson as is.

2020-10-16 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 78062fb091..432ea124e1 100755 --- a/configure +++ b/configure @@ -968,7 +968,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; - --docdi

[PATCH v5 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 52 ++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5 files

[PATCH v5 1/4] docs: Fixes build docs on msys2/mingw

2020-10-16 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Add the perl as the first parameter Signed-off-by: Yonggang Luo --- docs/sphinx/kerneldoc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/kerneldoc.py b/docs/sphinx/kerneldoc.py index 3e87940206..af130d

[PATCH v5 0/4] Fixes docs building on msys2/mingw

2020-10-16 Thread Yonggang Luo
V4-V5 Revise * docs: Fixes build docs on msys2/mingw For easier to review. Revise * meson: Move the detection logic for sphinx to meson According Paolo's suggestion with fixes. V3-V4 Quic fixes of python style if xxx: tested locally V2-V3 No need convert perl trick to python script anymore after

[PATCH v5 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-16 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9

Re: [PATCH v10 06/10] virtio-iommu: Add notify_flag_changed() memory region callback

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Add notify_flag_changed() to notice when memory listeners are added and > removed. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Jean-Philippe Brucker > --- > v10: > * Use notifier flags instead of notif

Re: [PATCH] hax: unbreak accelerator cpu code after cpus.c split

2020-10-16 Thread Philippe Mathieu-Daudé
Le ven. 16 oct. 2020 10:03, Claudio Fontana a écrit : > during my split of cpus.c, code line > "current_cpu = cpu" > was removed by mistake, causing hax to break. > > This commit fixes the situation restoring it. > > Reported-by: Volker Rümelin > Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc >

Re: [PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-16 Thread Philippe Mathieu-Daudé
Le jeu. 15 oct. 2020 22:22, Bruce Rogers a écrit : > These files are not needed for a linux-user only install. > Signed-off-by: Bruce Rogers > --- > ui/meson.build | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/ui/meson.build b/ui/meson.build > index 78ad792ff

Re: [PATCH v5 2/2] hw/arm/sbsa-ref: add SBSA watchdog device

2020-10-16 Thread Graeme Gregory
On Thu, Oct 15, 2020 at 06:21:09PM +0300, Maxim Uvarov wrote: > On Thu, 15 Oct 2020 at 17:12, Graeme Gregory wrote: > > > > On Wed, Oct 14, 2020 at 01:04:43PM -0400, Shashi Mallela wrote: > > > This was added as a placeholder for the virt requirement suggested by > > > Maxim > > > earlier.Agreed

Re: [PATCH v10 05/10] virtio-iommu: Add replay() memory region callback

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Implement the replay callback to setup all mappings for a new memory > region. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Jean-Philippe Brucker > --- > v10: Homogenize tracepoint arguments > --- > hw

[PATCH] meson: move SPHINX_ARGS references within "if build_docs"

2020-10-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qapi-schema/meson.build | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build index 1f222a7a13..66c7f04cf8 100644 --- a/tests/qapi-schema/meson.

Re: [PATCH v10 07/10] memory: Add interface to set iommu page size mask

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Allow to set the page size mask supported by an iommu memory region. > This enables a vIOMMU to communicate the page size granule supported by > an assigned device, on hosts that use page sizes greater than 4kB.

Re: [PATCH] meson: move SPHINX_ARGS references within "if build_docs"

2020-10-16 Thread Philippe Mathieu-Daudé
Le ven. 16 oct. 2020 11:15, Paolo Bonzini a écrit : > Signed-off-by: Paolo Bonzini > Reviewed-by: Philippe Mathieu-Daudé --- > tests/qapi-schema/meson.build | 88 +-- > 1 file changed, 44 insertions(+), 44 deletions(-) > > diff --git a/tests/qapi-schema/meson.

Re: [PATCH v10 08/10] vfio: Set IOMMU page size as per host supported page size

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > Set IOMMU supported page size mask same as host Linux supported page > size mask. > > Signed-off-by: Bharat Bhushan > Signed-off-by: Jean-Philippe Brucker Reviewed-by: Eric Auger Thanks Eric > --- > hw/vfi

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-16 Thread Mark Cave-Ayland
On 15/10/2020 22:41, Paolo Bonzini wrote: Il gio 15 ott 2020, 20:49 Mark Cave-Ayland > ha scritto: Is there any reason why https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06997.html

Re: [PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-16 Thread Mark Cave-Ayland
On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote: Since v1: - Do not remove mem_base in patch 1 (Laurent) - Pass MemoryRegion* (new patch) - Run check-qtest Philippe Mathieu-Daudé (2): hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument hw/rtc/m48t59: Simplify m48t59_init()

Re: [RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-10-16 Thread Ying Fang
On 10/15/2020 3:59 PM, Andrew Jones wrote: On Thu, Oct 15, 2020 at 10:07:16AM +0800, Ying Fang wrote: On 10/14/2020 2:08 AM, Andrew Jones wrote: On Tue, Oct 13, 2020 at 12:11:20PM +, Zengtao (B) wrote: Cc valentin -Original Message- From: Qemu-devel [mailto:qemu-devel-bounce

Re: [PATCH v2 03/10] softfloat: Tidy a * b + inf return

2020-10-16 Thread Alex Bennée
Richard Henderson writes: > No reason to set values in 'a', when we already > have float_class_inf in 'c', and can flip that sign. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 04/10] softfloat: Add float_cmask and constants

2020-10-16 Thread Alex Bennée
Richard Henderson writes: > Testing more than one class at a time is better done with masks. > This reduces the static branch count. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v10 10/10] vfio: Don't issue full 2^64 unmap

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > IOMMUs may declare memory regions spanning from 0 to UINT64_MAX. When > attempting to deal with such region, vfio_listener_region_del() passes a > size of 2^64 to int128_get64() which throws an assertion failure. Even > ignoring this, th

Re: [PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-16 Thread Philippe Mathieu-Daudé
Le ven. 16 oct. 2020 11:39, Mark Cave-Ayland a écrit : > On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote: > > > Since v1: > > - Do not remove mem_base in patch 1 (Laurent) > > - Pass MemoryRegion* (new patch) > > - Run check-qtest > > > > Philippe Mathieu-Daudé (2): > >hw/rtc/m48t59: Simpli

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-16 Thread Mark Cave-Ayland
On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to (target_ulong) from (uint32_t) as requested by Mark in

[PATCH] ci: include configure and meson logs in all jobs if configure fails

2020-10-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .gitlab-ci.yml | 6 +++--- .travis.yml| 8 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index e099da0fec..81a2960b1a 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -13,7 +13,7 @@

Re: [RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-10-16 Thread Andrew Jones
On Fri, Oct 16, 2020 at 05:40:02PM +0800, Ying Fang wrote: > > > On 10/15/2020 3:59 PM, Andrew Jones wrote: > > On Thu, Oct 15, 2020 at 10:07:16AM +0800, Ying Fang wrote: > > > > > > > > > On 10/14/2020 2:08 AM, Andrew Jones wrote: > > > > On Tue, Oct 13, 2020 at 12:11:20PM +, Zengtao (B) w

Re: [PATCH] ci: include configure and meson logs in all jobs if configure fails

2020-10-16 Thread Philippe Mathieu-Daudé
Le ven. 16 oct. 2020 12:05, Paolo Bonzini a écrit : > Signed-off-by: Paolo Bonzini > Reviewed-by: Philippe Mathieu-Daudé --- > .cirrus.yml| 6 +++--- > .gitlab-ci.yml | 6 +++--- > .travis.yml| 8 > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/.cirrus.

[Bug 1900122] [NEW] Unsupported ioctl: cmd=0xffffffff80685600 when accessing /dev/video* in aarch64 guest

2020-10-16 Thread vak
Public bug reported: **Description:** Any attempt to work with video in aarch64 architecture emulated on x86_64 leads currently to the error "Function not implemented". For example: ``` # v4l2-ctl -l --verbose Failed to open /dev/video0: Function not implemented root@12dd9b6fcfcb:/# ll /dev/vid

[PATCH v3 1/2] QSLIST: add atomic replace operation

2020-10-16 Thread wanghonghao
Replace a queue with another atomicly. It's useful when we need to transfer queues between threads. Signed-off-by: wanghonghao --- include/qemu/queue.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index e029e7bf66..1f0cbdf87e 100644 --- a/in

[PATCH v3 2/2] coroutine: take exactly one batch from global pool at a time

2020-10-16 Thread wanghonghao
This patch replace the global coroutine queue with a lock-free stack of which the elements are coroutine queues. Threads can put coroutine queues into the stack or take queues from it and each coroutine queue has exactly POOL_BATCH_SIZE coroutines. Note that the stack is not strictly LIFO, but it's

aio_poll() assertion fail on Windows

2020-10-16 Thread Mark Cave-Ayland
Whilst testing a Windows build of git master of qemu-system-ppc in MSYS2/MingW64 I noticed the following assertion message in the console after booting into OpenBIOS and then closing the GTK GUI window without booting a client OS: $ ./qemu-system-ppc ** ERROR:../util/aio-win32.c:337:aio_poll: a

[PATCH 0/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread FelixCuioc
The actual situation we encountered is: When assign EHCI device to the virtual machine, after initializing EHCI in seabios,it will continuously send dma cycles. After flatview_simplify(),the IOVA mappings of the EHCI device will be innocently unmapped between the delate and add phases of the VFIO M

[PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread FelixCuioc
The issue here is that an assinged EHCI device accesses an adjacent mapping between the delete and add phases of the VFIO MemoryListener. We want to skip flatview_simplify() is to prevent EHCI device IOVA mappings from being unmapped. Signed-off-by: FelixCuioc --- softmmu/memory.c | 20

[PATCH 4/7] microvm: set pci_irq_mask

2020-10-16 Thread Gerd Hoffmann
Makes sure the PCI interrupt overrides are added to the APIC table in case PCIe is enabled. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-microvm.c | 2 +- hw/i386/microvm.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-micro

[PATCH 6/7] tests/acpi: update expected data files

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.pcie | Bin 0 -> 110 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/microvm/APIC.pcie b/tests/data/acpi/microvm/APIC.pcie index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..6c51081b50beb061c5f4e5baa1

[PATCH 2/7] tests/acpi: add empty microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/APIC.pcie | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/data/acpi/microvm/APIC.pcie diff --git a/tests/data/acpi/microvm/APIC.pcie b/tests/data/acpi/microvm/APIC.pcie new file mode 100644 index 000

[PATCH 7/7] tests/acpi: disallow changes for microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 0c37ccebc5ba..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

[PATCH 1/7] tests/acpi: allow changes for microvm/APIC.pcie

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..0c37ccebc5ba 100644 --- a/tests/qtest/bios-tables-test-al

Re: [PATCH 1/1] Skip flatview_simplify() for cpu vendor zhaoxin

2020-10-16 Thread Paolo Bonzini
On 16/10/20 13:29, FelixCuioc wrote: > The issue here is that an assinged EHCI device accesses > an adjacent mapping between the delete and add phases > of the VFIO MemoryListener. > We want to skip flatview_simplify() is to prevent EHCI > device IOVA mappings from being unmapped. Hi, there is in

[PATCH 0/7] microvm: fix PCIe IRQs in APIC table.

2020-10-16 Thread Gerd Hoffmann
Gerd Hoffmann (7): tests/acpi: allow changes for microvm/APIC.pcie tests/acpi: add empty microvm/APIC.pcie x86: make pci irqs runtime configurable microvm: set pci_irq_mask apci: drop has_pci arg for acpi_build_madt tests/acpi: update expected data files tests/acpi: disallow changes

[PATCH 5/7] apci: drop has_pci arg for acpi_build_madt

2020-10-16 Thread Gerd Hoffmann
Setting x86ms->pci_irq_mask to zero has the same effect, so we don't need the has_pci argument any more. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-common.h | 3 +-- hw/i386/acpi-build.c | 2 +- hw/i386/acpi-common.c | 25 +++-- hw/i386/acpi-microvm.c | 2 +- 4 file

[PATCH 0/4] RfC: microvm: add second ioapic

2020-10-16 Thread Gerd Hoffmann
Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24. Gerd Hoffmann (4): microvm: make number of virtio transports runtime configurable microvm: make pcie irq base runtime configurable microvm:

[PATCH 3/7] x86: make pci irqs runtime configurable

2020-10-16 Thread Gerd Hoffmann
Add a variable to x86 machine state instead of hard-coding the PCI interrupts. Signed-off-by: Gerd Hoffmann --- include/hw/i386/x86.h | 2 ++ hw/i386/acpi-common.c | 3 +-- hw/i386/x86.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/x86.h b/include

[PATCH 1/4] microvm: make number of virtio transports runtime configurable

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index 91b064575d55..0154ad5bd707 100644 --- a/include/hw/i386/microvm.h

[PATCH 2/4] microvm: make pcie irq base runtime configurable

2020-10-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 2 +- hw/i386/microvm.c | 11 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index 0154ad5bd707..ede9625756b8 100644 --- a/include/hw/i386/microv

[PULL 02/22] Makefile: Ensure cscope.out/tags/TAGS are generated in the source tree

2020-10-16 Thread Paolo Bonzini
From: Greg Kurz Tools usually expect the index files to be in the source tree, eg. emacs. This is already the case when doing out-of-tree builds, but with in-tree builds they end up in the build directory. Force cscope, ctags and etags to put them in the source tree. Signed-off-by: Greg Kurz M

[PULL 08/22] add ninja to dockerfiles, CI configurations and test VMs

2020-10-16 Thread Paolo Bonzini
Reviewed-by: Daniel P. Berrangé Acked-by: Alex Bennée Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .travis.yml| 13 + tests/docker/dockerfiles/centos7.docker| 1 + tests/docker/dockerfiles/centos8.docke

[PATCH 3/4] microvm: add second ioapic

2020-10-16 Thread Gerd Hoffmann
Add more IRQ lines. Depends on ACPI. Also enable this only with userspace ioapic, not sure whenever the kernel can handle two ioapics. Signed-off-by: Gerd Hoffmann --- include/hw/i386/ioapic_internal.h | 2 +- include/hw/i386/x86.h | 1 + hw/i386/acpi-common.c | 10 +++

[PULL 00/22] Build system + misc changes for 2020-10-16

2020-10-16 Thread Paolo Bonzini
The following changes since commit 57c98ea9acdcef5021f5671efa6475a5794a51c4: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20201014-pull-request' into staging (2020-10-14 13:56:06 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream fo

[PULL 11/22] build: add --enable/--disable-libudev

2020-10-16 Thread Paolo Bonzini
Initially, libudev detection was bundled with --enable-mpath because qemu-pr-helper was the only user of libudev. Recently however the USB U2F emulation has also started using libudev, so add a separate option. This also allows 1) disabling libudev if desired for static builds and 2) for non-stat

[PULL 07/22] dockerfiles: enable Centos 8 PowerTools

2020-10-16 Thread Paolo Bonzini
ninja is included in the CentOS PowerTools repository. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/centos8.docker | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker index 0fc26974

[PATCH 4/4] microvm: reconfigure irqs if second ioapic is available

2020-10-16 Thread Gerd Hoffmann
Use GSI 16+ for PCIe (needs acpi_build_madt() tweak). Use GSI 24+ (second ioapic) for virtio-mmio. Use all irq lines of the second ioapic and allow up to 24 virtio-mmio devices. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-common.c | 2 +- hw/i386/microvm.c | 6 +- 2 files changed, 6 in

[PULL 06/22] configure: move QEMU_INCLUDES to meson

2020-10-16 Thread Paolo Bonzini
Confusingly, QEMU_INCLUDES is not used by configure tests. Moving it to meson.build ensures that Windows paths are specified instead of the msys paths like /c/Users/... Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- configure | 20 meson.build | 30

[PULL 04/22] make: run shell with pipefail

2020-10-16 Thread Paolo Bonzini
Without pipefail, it is possible to miss failures if the recipes include pipes. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index d20c7a3f80..91c62a26c8 100644 --- a/Makefile +++ b/Makefile @

[PULL 14/22] configure: fix handling of --docdir parameter

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the qemu_docdir name in the final assignment. Unfortunately, one instance of qemu_docdir was missed: the one which comes from the --docdir parameter. This patch restores the proper handling of the --docdir par

[PULL 01/22] submodules: bump meson to 0.55.3

2020-10-16 Thread Paolo Bonzini
This adds some bugfixes, and allows MSYS2 to configure without "--ninja=ninja". Signed-off-by: Paolo Bonzini --- .cirrus.yml | 3 +-- meson | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 99d118239c..0f46cb5eaf 100644 --- a/.cirrus.yml

[PULL 09/22] build: cleanups to Makefile

2020-10-16 Thread Paolo Bonzini
Group similar rules, add comments to "else" and "endif" lines, detect too-old config-host.mak before messing things up. Signed-off-by: Paolo Bonzini --- Makefile | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/Makefile b/Makefil

[PULL 10/22] build: replace ninjatool with ninja

2020-10-16 Thread Paolo Bonzini
Now that the build is done entirely by Meson, there is no need to keep the Makefile conversion. Instead, we can ask Ninja about the targets it exposes and forward them. The main advantages are, from smallest to largest: - reducing the possible namespace pollution within the Makefile - removal o

[PULL 03/22] tests/Makefile.include: unbreak non-tcg builds

2020-10-16 Thread Paolo Bonzini
Remove from check-block the requirement that all TARGET_DIRS are built. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5aca98e60c..4

[PULL 16/22] docs: Fix Sphinx configuration for msys2/mingw

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Python doesn't support running ../scripts/kernel-doc directly. Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-2-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertio

[PULL 17/22] meson: move SPHINX_ARGS references within "if build_docs"

2020-10-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qapi-schema/meson.build | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build index 1f222a7a13..304ef939bd 100644 --- a/tests/qapi-schema/meson.

[PULL 15/22] meson: Only install icons and qemu.desktop if have_system

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers These files are not needed for a linux-user only install. Signed-off-by: Bruce Rogers Message-Id: <20201015201840.282956-1-brog...@suse.com> Signed-off-by: Paolo Bonzini --- ui/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ui/meson.b

[PULL 05/22] tests: add missing generated sources to testqapi

2020-10-16 Thread Paolo Bonzini
Ninja notices them due to a different order in visiting the graph. Reviewed-by: Daniel P. Berrangé Signed-off-by: Paolo Bonzini --- tests/include/meson.build | 8 tests/meson.build | 14 -- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/inclu

[PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- configure | 59 --- docs/meson.build | 46 meson.build | 30 +

[PULL 20/22] fuzz: Disable QEMU's SIG{INT,HUP,TERM} handlers

2020-10-16 Thread Paolo Bonzini
From: Alexander Bulekov Prior to this patch, the only way I found to terminate the fuzzer was either to: 1. Explicitly specify the number of fuzzer runs with the -runs= flag 2. SIGKILL the process with "pkill -9 qemu-fuzz-*" or similar In addition to being annoying to deal with, SIGKILLing the

[PULL 21/22] hax: unbreak accelerator cpu code after cpus.c split

2020-10-16 Thread Paolo Bonzini
From: Claudio Fontana during my split of cpus.c, code line "current_cpu = cpu" was removed by mistake, causing hax to break. This commit fixes the situation restoring it. Reported-by: Volker Rümelin Fixes: e92558e4bf8059ce4f0b310afe218802b72766bc Signed-off-by: Claudio Fontana Message-Id: <20

[PULL 19/22] cirrus: Enable doc build on msys2/mingw

2020-10-16 Thread Paolo Bonzini
From: Yonggang Luo Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo Message-Id: <20201015220626.418-5-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- .cirrus.ym

[PULL 13/22] meson: cleanup curses/iconv test

2020-10-16 Thread Paolo Bonzini
Skip the test if it is system emulation is not requested, and differentiate errors for lack of iconv and lack of curses. Signed-off-by: Paolo Bonzini --- meson.build | 85 - 1 file changed, 45 insertions(+), 40 deletions(-) diff --git a/meson.

[PULL 22/22] ci: include configure and meson logs in all jobs if configure fails

2020-10-16 Thread Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .gitlab-ci.yml | 6 +++--- .travis.yml| 8 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index e099da0fec..81a2960b1a 100644 --- a/.cirrus.yml

[PULL 12/22] meson.build: don't condition iconv detection on library detection

2020-10-16 Thread Paolo Bonzini
From: Bruce Rogers It isn't necessarily the case that use of iconv requires an additional library. For that reason we shouldn't conditionalize iconv detection on libiconv.found. Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw by convert them to meson) Signed-off-by: B

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-16 Thread BALATON Zoltan via
On Fri, 16 Oct 2020, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to (target_u

Re: aio_poll() assertion fail on Windows

2020-10-16 Thread Howard Spoelstra
On Fri, Oct 16, 2020 at 1:32 PM Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > Whilst testing a Windows build of git master of qemu-system-ppc in > MSYS2/MingW64 I > noticed the following assertion message in the console after booting into > OpenBIOS > and then closing the GTK GUI wind

Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM)

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 11:58 AM, Mark Cave-Ayland wrote: On 16/10/2020 00:47, BALATON Zoltan via wrote: This is the cut down version of the earlier series omitting unfinished patches that I plan to rework later and rebased to Mark's qemu-macppc branch. Compared to v7 the only change is the cast to (target

Re: [PATCH v10 09/10] virtio-iommu: Set supported page size mask

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > From: Bharat Bhushan > > The virtio-iommu device can deal with arbitrary page sizes for virtual > endpoints, but for endpoints assigned with VFIO it must follow the page > granule used by the host IOMMU driver. > > Implement the interf

Re: [PATCH v10 00/10] virtio-iommu: VFIO integration

2020-10-16 Thread Auger Eric
Hi Jean, On 10/8/20 7:15 PM, Jean-Philippe Brucker wrote: > This series adds support for VFIO endpoints to virtio-iommu. > > Versions 1 to 9 were posted by Bharat Bhushan, but I am taking over for > now since he doesn't have much time to spend on it. Thanks again Bharat > for the work! > > Two m

Re: [PATCH 0/4] RfC: microvm: add second ioapic

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/16/20 1:43 PM, Gerd Hoffmann wrote: Add a second ioapic to microvm. Gives us more IRQ lines we can use for virtio-mmio devices. Bump number of possible virtio-mmio devices from 8 to 24. Gerd Hoffmann (4): microvm: make number of virtio transports runtime configurable microvm: make

Re: [PULL 18/22] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 7:48 PM Paolo Bonzini wrote: > > From: Yonggang Luo > > Signed-off-by: Yonggang Luo > Message-Id: <20201015220626.418-4-luoyongg...@gmail.com> > Signed-off-by: Paolo Bonzini > --- > configure | 59 --- > docs/meson.bui

Re: [PATCH v4 14/16] fuzz: add general-fuzz configs for oss-fuzz

2020-10-16 Thread Paolo Bonzini
On 15/10/20 15:41, Alexander Bulekov wrote: > +typedef struct general_fuzz_config { > +const char *name, *args, *objects; > +} general_fuzz_config; > + > +GArray *get_general_fuzz_configs(void); Can't it be even a "const struct general_fuzz_config general_fuzz_configs[] = ..." instead of a GAr

[RFC PATCH v3] target/mips: Increase number of TLB entries on the 34Kf core (16 -> 64)

2020-10-16 Thread Philippe Mathieu-Daudé
Per "MIPS32 34K Processor Core Family Software User's Manual, Revision 01.13" page 8 in "Joint TLB (JTLB)" section: "The JTLB is a fully associative TLB cache containing 16, 32, or 64-dual-entries mapping up to 128 virtual pages to their corresponding physical addresses." There is no part

Re: [PATCH v4 00/16] Add a General Virtual Device Fuzzer

2020-10-16 Thread Paolo Bonzini
If you have to do a v5, the correct word is generic not general. :) Otherwise looks great. Paolo On 15/10/20 15:41, Alexander Bulekov wrote: > v4: > - Replace yaml + c template-based oss-fuzz configs, with C code to > register a FuzzTarget for each config (as suggested by Paolo) >

Re: [PATCH v2 4/4] MAINTAINERS: Move MIPS GIC timer files to Boston board section

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/14/20 3:39 PM, Thomas Huth wrote: On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote: The MIPS GIC timer is only used by the Boston board. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

Re: [PATCH v2 0/4] MAINTAINERS: Update MIPS sections

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/13/20 12:16 PM, Philippe Mathieu-Daudé wrote: Volunteer to maintain MIPS TCG. As discussed on list, Huacai will likely send a similar patch. Few more adjustments (in particular around Boston board). Based-on: <1602103041-32017-1-git-send-email-aleksandar.qemu.de...@gmail.com> https://list

Re: [PATCH 0/2] hw/mips/malta: Minor housekeeping in mips_malta_init()

2020-10-16 Thread Philippe Mathieu-Daudé
On 10/12/20 6:05 PM, Philippe Mathieu-Daudé wrote: Move some code around to make this big function easier to review. Philippe Mathieu-Daudé (2): hw/mips/malta: Move gt64120 related code together hw/mips/malta: Use clearer qdev style hw/mips/malta.c | 21 ++--- 1 file ch

  1   2   3   >