[PATCH v5 6/7] meson: add spice dependency to core spice source files.

2020-10-14 Thread Gerd Hoffmann
Right now it happens to work by pure luck because the spice chardevs add the spice dependency to the softmmu source set. That'll change though once we start building spice chardevs as module, so lets fix it properly. Signed-off-by: Gerd Hoffmann --- ui/meson.build | 2 +- 1 file changed, 1 inse

[PATCH v5 5/7] meson: add spice_headers dependency.

2020-10-14 Thread Gerd Hoffmann
Used for files which (with CONFIG_SPICE=y) depend on spice header files to pick up some enum, but which do not depend on on the actual spice shared library. Signed-off-by: Gerd Hoffmann --- audio/meson.build | 2 +- meson.build | 2 ++ monitor/meson.build | 2 +- 3 files changed, 4 ins

RE: [PATCH 03/10] Reduce the time of checkpoint for COLO

2020-10-14 Thread Zhang, Chen
> -Original Message- > From: Zhang Chen > Sent: Wednesday, October 14, 2020 3:26 PM > To: Jason Wang ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen ; Rao, Lei ; > Zhang, Chen > Subject: [PATCH 03/10] Reduce the time of checkpoint for COLO > > From: "Rao, Lei" > > we should set ram_bu

Re: [PATCH v6 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-14 Thread Niklas Cassel
On Tue, Oct 13, 2020 at 05:50:34PM -0700, Keith Busch wrote: > On Wed, Oct 14, 2020 at 06:42:02AM +0900, Dmitry Fomichev wrote: > > +{ > > +NvmeEffectsLog log = {}; > > +uint32_t *dst_acs = log.acs, *dst_iocs = log.iocs; > > +uint32_t trans_len; > > +int i; > > + > > +trace_pci_

Re: [PATCH v4 5/7] nbd: Simplify qemu bitmap context name

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
10.10.2020 00:55, Eric Blake wrote: Each dirty bitmap already knows its name; by reducing the scope of the places where we construct "qemu:dirty-bitmap:NAME" strings, tracking the name is more localized, and there are fewer per-export fields to worry about. This in turn will make it easier for a

Re: [PATCH v4 4/7] nbd: Update qapi to support exporting multiple bitmaps

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
10.10.2020 00:55, Eric Blake wrote: Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit passing multiple bitmaps as distinct m

Re: [PATCH 3/9] util/vfio-helpers: Trace PCI BAR region info

2020-10-14 Thread Fam Zheng
On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote: > For debug purpose, trace BAR regions info. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/vfio-helpers.c | 8 > util/trace-events | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/util/vfio-helpers.c

Re: [PATCH v11 06/13] block: modify the comment for BDRV_REQ_PREFETCH flag

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to > use it alone and pass it to the COR-filter driver for further > processing. > > Signed-off-by: Andrey Shinkevich > --- > include/block/block.h | 7 --- > 1 file changed, 4 ins

Re: [PATCH v4 6/7] nbd: Refactor counting of metadata contexts

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
10.10.2020 00:55, Eric Blake wrote: Rather than open-code the count of negotiated contexts at several sites, embed it directly into the struct. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v11 07/13] block: include supported_read_flags into BDS structure

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > Add the new member supported_read_flags to BlockDriverState structure. > It will control the BDRV_REQ_PREFETCH flag set for copy-on-read > operations. > > Signed-off-by: Andrey Shinkevich > --- > include/block/block_int.h | 4 > 1 file changed,

Re: [PATCH 0/9] util/vfio-helpers: Improve debugging experience

2020-10-14 Thread Fam Zheng
On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote: > A bunch of boring patches that have been proven helpful > while debugging. > > Philippe Mathieu-Daudé (9): > util/vfio-helpers: Improve reporting unsupported IOMMU type > util/vfio-helpers: Trace PCI I/O config accesses > uti

Re: [PATCH for-5.1] hw/arm/netduino2, netduinoplus2: Set system_clock_scale

2020-10-14 Thread Peter Maydell
On Wed, 14 Oct 2020 at 01:42, Alistair Francis wrote: > > On Tue, Oct 13, 2020 at 5:29 PM Alistair Francis wrote: > > > > On Mon, Oct 12, 2020 at 8:45 AM Peter Maydell > > wrote: > > > > > > The netduino2 and netduinoplus2 boards forgot to set the > > > system_clock_scale > > > global, which m

Re: [PATCH v11 08/13] copy-on-read: add support for BDRV_REQ_PREFETCH to COR-filter

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > Add support for the BDRV_REQ_PREFETCH flag to the supported_write_flags s/write/read/ > of the COR-filter. > > Signed-off-by: Andrey Shinkevich > --- > block/copy-on-read.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/copy-on-rea

Re: [PATCH 3/9] util/vfio-helpers: Trace PCI BAR region info

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 2:23 PM, Fam Zheng wrote: On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote: For debug purpose, trace BAR regions info. Signed-off-by: Philippe Mathieu-Daudé --- util/vfio-helpers.c | 8 util/trace-events | 1 + 2 files changed, 9 insertions(+) diff --

Re: [PATCH 0/9] util/vfio-helpers: Improve debugging experience

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 2:34 PM, Fam Zheng wrote: On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote: A bunch of boring patches that have been proven helpful while debugging. Philippe Mathieu-Daudé (9): util/vfio-helpers: Improve reporting unsupported IOMMU type util/vfio-helpers: Trace

[Bug 1899728] Re: Qemu-5.1.0 build from source man entry not found

2020-10-14 Thread Peter Maydell
You probably don't have the necessary dependencies to build the manual pages. Since 5.0 we have required Sphinx to be installed to build the docs (see https://wiki.qemu.org/ChangeLog/5.0#Build_Dependencies). Pass --enable-docs to configure if you want to force the docs to be built (and then config

Re: [PATCH 0/9] util/vfio-helpers: Improve debugging experience

2020-10-14 Thread Fam Zheng
On Wed, 2020-10-14 at 14:42 +0200, Philippe Mathieu-Daudé wrote: > On 10/14/20 2:34 PM, Fam Zheng wrote: > > On Wed, 2020-10-14 at 13:52 +0200, Philippe Mathieu-Daudé wrote: > > > A bunch of boring patches that have been proven helpful > > > while debugging. > > > > > > Philippe Mathieu-Daudé (9):

Re: [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > If the flag BDRV_REQ_PREFETCH was set, pass it further to the > COR-driver to skip unneeded reading. It can be taken into account for > the COR-algorithms optimization. That check is being made during the > block stream job by the moment. > > Signed-of

Re: [PATCH v2 2/4] MAINTAINERS: Remove duplicated Malta test entries

2020-10-14 Thread Thomas Huth
On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote: > The Malta tests are already covered in the Malta section. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d59e5c05c10..2de5943e388 10064

Re: [PATCH v2 3/4] MAINTAINERS: Downgrade MIPS Boston to 'Odd Fixes', fix Paul Burton mail

2020-10-14 Thread Thomas Huth
On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote: > Paul's Wavecomp email has been bouncing for months. He told us > he "no longer has access to modern MIPS CPUs or Boston hardware, > and wouldn't currently have time to spend on them if he did." [1] > but "perhaps that might change in the future."

Re: [PATCH v6 03/11] hw/block/nvme: Add support for Namespace Types

2020-10-14 Thread Niklas Cassel
On Wed, Oct 14, 2020 at 06:42:04AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > Define the structures and constants required to implement > Namespace Types support. > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets

[PATCH 1/30] cryptodev: Fix Lesser GPL version number

2020-10-14 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- backends/cryptodev-builtin.c

Re: [PATCH v5 6/7] meson: add spice dependency to core spice source files.

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 2:11 PM, Gerd Hoffmann wrote: Right now it happens to work by pure luck because the spice chardevs add the spice dependency to the softmmu source set. That'll change though once we start building spice chardevs as module, so lets fix it properly. Signed-off-by: Gerd Hoffmann ---

Re: [PATCH v2 4/4] MAINTAINERS: Move MIPS GIC timer files to Boston board section

2020-10-14 Thread Thomas Huth
On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote: > The MIPS GIC timer is only used by the Boston board. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 702f73823fc..62d

Re: [PATCH] fuzz: Disable QEMU's signal handlers

2020-10-14 Thread Alexander Bulekov
On 201014 1009, Darren Kenny wrote: > On Tuesday, 2020-10-13 at 17:52:46 +01, Daniel P. Berrangé wrote: > > On Tue, Oct 13, 2020 at 05:50:37PM +0100, Darren Kenny wrote: > >> Hi Alex, > >> > >> This mentions the use of atexit() to perform some cleanup, but I'm not > >> seeing that being added here

[PATCH] cpus: Drop declaration of cpu_remove()

2020-10-14 Thread Greg Kurz
cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0, but its prototype wasn't removed. We could possibly keep the shorter cpu_remove() naming but it seems better to highligth that this blocks until the CPU thread is joined. Fixes: dbadee4ff4a0 ("cpus: join thread when removing

[PATCH 2/30] io: Fix Lesser GPL version number

2020-10-14 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- include/io/channel-buffer.h

[PATCH 3/30] crypt: Fix Lesser GPL version number

2020-10-14 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- tests/test-crypto-afsplit.c |

Re: [PATCH] cpus: Drop declaration of cpu_remove()

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 3:40 PM, Greg Kurz wrote: cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0, but its prototype wasn't removed. We could possibly keep the shorter cpu_remove() naming but it seems better to highligth that this blocks until the CPU thread is joined. Fixes: dbadee4

[PATCH 4/30] authz: Fix Lesser GPL version number

2020-10-14 Thread Chetan Pant
There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant --- authz/base.c|

[PATCH 3/7] tests: add missing generated sources to testqapi

2020-10-14 Thread Paolo Bonzini
Ninja notices them due to a different order in visiting the graph. Signed-off-by: Paolo Bonzini --- tests/include/meson.build | 8 tests/meson.build | 14 -- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/tests/include/meson.build b/tests/include/me

[PATCH 1/7] tests/Makefile.include: unbreak non-tcg builds

2020-10-14 Thread Paolo Bonzini
Remove from check-block the requirement that all TARGET_DIRS are built. Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5aca98e60c..4037490b69 100644 --- a/tests/Make

[PATCH 2/7] make: run shell with pipefail

2020-10-14 Thread Paolo Bonzini
Without pipefail, it is possible to miss failures if the recipes include pipes. Signed-off-by: Paolo Bonzini --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index c37e513431..5e51e61c3b 100644 --- a/Makefile +++ b/Makefile @@ -14,6 +14,8 @@ SRC_PATH=. # we

[PATCH 5/7] dockerfiles: enable Centos 8 PowerTools

2020-10-14 Thread Paolo Bonzini
ninja is included in the CentOS PowerTools repository. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/centos8.docker | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker index 0fc2697491..e31d366fc1 1

[PATCH 0/7] build: replace ninjatool with ninja

2020-10-14 Thread Paolo Bonzini
This pull request is the last build system change for 5.2 from me, and it is simple: similar to how we are invoking ROM or tests/tcg "make" from the main Makefile, we now invoke ninja to build QEMU. Unlike those cases, however, build.ninja targets are forwarded transparently. The advantages cover

[PATCH 6/7] add ninja to dockerfiles, CI configurations and test VMs

2020-10-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .cirrus.yml| 6 +++--- .travis.yml| 13 + tests/docker/dockerfiles/centos7.docker| 1 + tests/docker/dockerfiles/centos8.docker| 1 + tests/docker/dockerfiles/debian10.docker

[PATCH 4/7] configure: move QEMU_INCLUDES to meson

2020-10-14 Thread Paolo Bonzini
Confusingly, QEMU_INCLUDES is not used by configure tests. Moving it to meson.build ensures that Windows paths are specified instead of the msys paths like /c/Users/... Signed-off-by: Paolo Bonzini --- configure | 20 meson.build | 30 -- 2 fil

[PATCH 7/7] build: replace ninjatool with ninja

2020-10-14 Thread Paolo Bonzini
Now that the build is done entirely by Meson, there is no need to keep the Makefile conversion. Instead, we can ask Ninja about the targets it exposes and forward them. The main advantages are, from smallest to largest: - reducing the possible namespace pollution within the Makefile - removal o

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-14 Thread Peter Maydell
On Wed, 14 Oct 2020 at 14:54, Paolo Bonzini wrote: > > This pull request is the last build system change for 5.2 from > me, and it is simple: similar to how we are invoking > ROM or tests/tcg "make" from the main Makefile, we now invoke ninja > to build QEMU. Unlike those cases, however, build.ni

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-14 Thread Elena Afanasova
On Tue, 2020-10-13 at 16:32 +1100, David Gibson wrote: > On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > > On 12/10/20 12:44, Thomas Huth wrote: > > > I think this is one of the tasks from: > > > > > > > > > https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanup

[PATCH v2] fuzz: Disable QEMU's SIG{INT,HUP,TERM} handlers

2020-10-14 Thread Alexander Bulekov
Prior to this patch, the only way I found to terminate the fuzzer was either to: 1. Explicitly specify the number of fuzzer runs with the -runs= flag 2. SIGKILL the process with "pkill -9 qemu-fuzz-*" or similar In addition to being annoying to deal with, SIGKILLing the process skips over any ex

Re: [PULL 0/9] Ui 20201014 patches

2020-10-14 Thread Peter Maydell
00) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20201014-pull-request > > for you to fetch changes up to 41d004d8af59885da2c21460a73898b1aa09690f: > > ui: Fix default window_id value (2020-10-14 10:20:26 +0200) > > ---

Re: [PATCH v11 02/13] copy-on-read: add filter append/drop functions

2020-10-14 Thread Andrey Shinkevich
On 14.10.2020 13:44, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sement

[PATCH v2 00/15] python: create installable package

2020-10-14 Thread John Snow
Based-on: https://gitlab.com/jsnow/qemu/-/tree/python This series factors the python/qemu directory as an installable module. It does not yet actually change the mechanics of how any other python source in the tree actually consumes it (yet), beyond the import path. The point of this series is pr

[PATCH v2 06/15] python: add pylint exceptions to __init__.py

2020-10-14 Thread John Snow
Pylint 2.5.x and 2.6.x have regressions that make import checking inconsistent, see: https: //github.com/PyCQA/pylint/issues/3609 https: //github.com/PyCQA/pylint/issues/3624 https: //github.com/PyCQA/pylint/issues/3651 Signed-off-by: John Snow --- python/qemu/core/__init__.py | 3 +++ 1 file ch

[PATCH v2 02/15] python: add qemu package installer

2020-10-14 Thread John Snow
Add setup.cfg and setup.py, necessary for installing a package via pip. Add a rst document explaining the basics of what this package is for and who to contact for more information. This document will be used as the landing page for the package on PyPI. I am not yet using a pyproject.toml style pa

[PATCH v2 03/15] python: add VERSION file

2020-10-14 Thread John Snow
Python infrastructure as it exists today is not capable reliably of single-sourcing a package version from a parent directory. The authors of pip are working to correct this, but as of today this is not possible to my knowledge. The problem is that when using pip to build and install a python pack

[PATCH v2 01/15] python: create qemu.core package

2020-10-14 Thread John Snow
move python/qemu/*.py to python/qemu/core/*.py and update import directives across the tree. This is done to create a PEP420 namespace package, in which we may create subpackages. To do this, the namespace directory ("qemu") should not have any modules in it. Those files will go in a new 'core' su

[PATCH v2 09/15] python: move flake8 config to setup.cfg

2020-10-14 Thread John Snow
Signed-off-by: John Snow --- python/qemu/core/.flake8 | 2 -- python/setup.cfg | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) delete mode 100644 python/qemu/core/.flake8 diff --git a/python/qemu/core/.flake8 b/python/qemu/core/.flake8 deleted file mode 100644 index 45d8146f3f

[PATCH v2 15/15] python/qemu: add qemu package itself to pipenv

2020-10-14 Thread John Snow
This adds the python qemu packages themselves to the pipenv manifest. 'pipenv sync' will create a virtual environment sufficient to use the SDK. 'pipenv sync --dev' will create a virtual environment sufficient to use and test the SDK (with pylint, mypy, isort, flake8, etc.) The qemu packages are i

[PATCH v2 07/15] python: move pylintrc into setup.cfg

2020-10-14 Thread John Snow
Delete the empty settings now that it's sharing a home with settings for other tools. pylint can now be run from this folder as "pylint qemu". Signed-off-by: John Snow --- python/qemu/core/pylintrc | 58 --- python/setup.cfg | 29

[PATCH v2 04/15] python: add directory structure README.rst files

2020-10-14 Thread John Snow
Add short readmes to python/, python/qemu/, and python/qemu/core that explain the directory hierarchy. These readmes are visible when browsing the source on e.g. gitlab/github and are designed to help new developers/users quickly make sense of the source tree. They are not designed for inclusion i

[PATCH v2 13/15] python: move .isort.cfg into setup.cfg

2020-10-14 Thread John Snow
Signed-off-by: John Snow --- python/.isort.cfg | 7 --- python/setup.cfg | 8 2 files changed, 8 insertions(+), 7 deletions(-) delete mode 100644 python/.isort.cfg diff --git a/python/.isort.cfg b/python/.isort.cfg deleted file mode 100644 index 6d0fd6cc0d..00 --- a/python

[PULL 07/10] vga-pci: Register "big-endian-framebuffer" as class property

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Marc-André Lureau Message-Id: <20200921221045.699690-22-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/display/vga-pci.c | 12

[PATCH v2 05/15] python: Add pipenv support

2020-10-14 Thread John Snow
pipenv is a tool used for managing virtual environments with pinned, explicit dependencies. It is used for precisely recreating python virtual environments. pipenv uses two files to do this: (1) Pipfile, which is similar in purpose and scope to what setup.py lists. It specifies the requisite mini

[PATCH v2 08/15] python: add pylint to pipenv

2020-10-14 Thread John Snow
We are specifying >= pylint 2.6.x for two reasons: 1. For setup.cfg support, added in pylint 2.5.x 2. To clarify that we are using a version that has incompatibly dropped bad-whitespace checks. Signed-off-by: John Snow --- python/Pipfile | 1 + python/Pipfile.lock | 127 +

[PULL 02/10] rng-random: register "filename" as class property

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200921221045.699690-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/rng-random.c | 8

[PATCH v2 12/15] python: add mypy to pipenv

2020-10-14 Thread John Snow
0.730 appears to be about the oldest version that works with the features we want, including nice human readable output (to make sure iotest 297 passes), and type-parameterized Popen generics. 0.770, however, supports adding 'strict' to the config file, so require at least 0.770. mypy can be run

[PATCH v2 10/15] python: Add flake8 to pipenv

2020-10-14 Thread John Snow
flake8 3.5.x does not support the --extend-ignore syntax used in the .flake8 file to gracefully extend default ignores, so 3.6.x is our minimum requirement. There is no known upper bound. flake8 can be run from the python/ directory with no arguments. Signed-off-by: John Snow --- python/Pipfile

[PULL 04/10] input-linux: Register properties as class properties

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200921221045.699690-10-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- ui/input-linux.c | 27 +++

[PATCH v2 11/15] python: move mypy.ini into setup.cfg

2020-10-14 Thread John Snow
mypy supports reading its configuration values from a central project configuration file; do so. Signed-off-by: John Snow --- python/mypy.ini | 4 python/setup.cfg | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) delete mode 100644 python/mypy.ini diff --git a/python/mypy.ini

Re: [PATCH for-5.1] hw/arm/netduino2, netduinoplus2: Set system_clock_scale

2020-10-14 Thread Alistair Francis
On Wed, Oct 14, 2020 at 5:39 AM Peter Maydell wrote: > > On Wed, 14 Oct 2020 at 01:42, Alistair Francis wrote: > > > > On Tue, Oct 13, 2020 at 5:29 PM Alistair Francis > > wrote: > > > > > > On Mon, Oct 12, 2020 at 8:45 AM Peter Maydell > > > wrote: > > > > > > > > The netduino2 and netduinop

[PULL 05/10] input-barrier: Register properties as class properties

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200921221045.699690-11-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- ui/input-barrier.c | 44 +

[PATCH v2 14/15] python/qemu: add isort to pipenv

2020-10-14 Thread John Snow
isort 5.0.0 through 5.0.4 has a bug that causes it to misinterpret certain "from ..." clauses that are not related to imports. Require 5.0.5 or greater. isort can be run with 'isort -c qemu' from the python root. Signed-off-by: John Snow --- python/Pipfile | 1 + python/Pipfile.lock | 4 +

[PULL 01/10] rng-egd: Register "chardev" as class property

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200921221045.699690-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/rng-egd.c | 9 ++-

[PULL 10/10] can-host-socketcan: Fix crash when 'if' option is not set

2020-10-14 Thread Eduardo Habkost
Fix the following crash: $ qemu-system-x86_64 -object can-host-socketcan,id=obj0 Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang Acked-by: Pavel Pisa Message-Id: <20201008202713.1416823-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- net/ca

[PULL 00/10] machine + QOM queue, 2020-10-14

2020-10-14 Thread Eduardo Habkost
The following changes since commit 96292515c07e3a99f5a29540ed2f257b1ff75111: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging (2020-10-13 14:06:22 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/mach

[PULL 03/10] rng: Register "opened" as class property

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé Message-Id: <20200921221045.699690-8-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/rng.c | 8 ---

[PULL 09/10] authz-list-file: Fix crash when filename is not set

2020-10-14 Thread Eduardo Habkost
Fix the following crash: $ qemu-system-x86_64 -object authz-list-file,id=obj0 qemu-system-x86_64: -object authz-list-file,id=obj0: GLib: g_file_get_contents: assertion 'filename != NULL' failed Segmentation fault (core dumped) Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrangé

[PULL 06/10] i386: Register most CPU properties as class properties

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Message-Id: <20200921221045.699690-14-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 66 +++

[PULL 08/10] vhost-user: Register "chardev" as class property

2020-10-14 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost Reviewed-by: Marc-André Lureau Message-Id: <20200921221045.699690-6-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- backends/vhost-user.c | 6 +

[Bug 1899728] Re: Qemu-5.1.0 build from source man entry not found

2020-10-14 Thread Thomas Huth
There is only one shared man-page for all qemu-system-xxx binaries ... have you tried to simply run "man qemu" ? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [RFC PATCH v5 2/2] hw/riscv: sifive_u: Add backend drive support

2020-10-14 Thread Bin Meng
Hi Alistair, On Wed, Oct 14, 2020 at 10:46 PM Alistair Francis wrote: > > On Wed, Sep 30, 2020 at 12:10 AM Green Wan wrote: > > > > On Wed, Sep 30, 2020 at 1:08 AM Alistair Francis > > wrote: > > > > > > On Mon, Sep 28, 2020 at 2:18 AM Green Wan wrote: > > > > > > > > Hi Alistair, > > > > > >

Re: [PATCH v11 12/13] stream: remove unused backing-file name parameter

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > The 'backing-file' argument is not used by the block-stream job. It > designates a backing file name to set in QCOW2 image header after the > block-stream job finished. A backing file name of the node above base > is used instead. > > Signed-off-by: An

Re: [PATCH v11 11/13] stream: mark backing-file argument as deprecated

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > Whereas the block-stream job starts using a backing file name of the > base node overlay after the block-stream job completes, mark the QMP > 'backing-file' argument as deprecated. > > Signed-off-by: Andrey Shinkevich > --- > docs/system/deprecated.r

Re: [RFC PATCH 0/3] target/mips: Make the number of TLB entries a CPU property

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 9:14 AM, Richard Purdie wrote: On Wed, 2020-10-14 at 01:36 +, Victor Kamensky (kamensky) wrote: Thank you very much for looking at this. I gave a spin to your 3 patch series in original setup, and as expected with '-cpu 34Kf,tlb-entries=64' option it works great. If nobody objec

Re: [PATCH v4 7/7] nbd: Allow export of multiple bitmaps for one device

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
10.10.2020 00:55, Eric Blake wrote: With this, 'qemu-nbd -B b0 -B b1 -f qcow2 img.qcow2' can let you sniff out multiple bitmaps from one server. qemu-img as client can still only read one bitmap per client connection, but other NBD clients (hello libnbd) can now read multiple bitmaps in a single

Re: [RFC PATCH v5 2/2] hw/riscv: sifive_u: Add backend drive support

2020-10-14 Thread Alistair Francis
On Wed, Sep 30, 2020 at 12:10 AM Green Wan wrote: > > On Wed, Sep 30, 2020 at 1:08 AM Alistair Francis wrote: > > > > On Mon, Sep 28, 2020 at 2:18 AM Green Wan wrote: > > > > > > Hi Alistair, > > > > > > Thanks for the review. See the reply inline below. > > > > > > > > > On Sat, Sep 26, 2020 at

Re: [PATCH v2 1/4] MAINTAINERS: Put myself forward for MIPS target

2020-10-14 Thread Jiaxun Yang
在 2020/10/13 18:16, Philippe Mathieu-Daudé 写道: To avoid the MIPS target being orphan, volunteer to keep an eye on it and put together pull requests. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Thanks for stepping out! - Jiaxun --- MAINTAINERS | 6 -- 1 file c

Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 14:57, Max Reitz wrote: On 14.10.20 13:09, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: We are going to use the COR-filter for a block-stream job. To limit COR operations by the base node in the backing chain during stream job, pass the name of overlay base node to th

Re: [PATCH v11 10/13] stream: skip filters when writing backing file name to QCOW2 header

2020-10-14 Thread Max Reitz
On 12.10.20 19:43, Andrey Shinkevich wrote: > Avoid writing a filter JSON-name to QCOW2 image when the backing file > is changed after the block stream job. > > Signed-off-by: Andrey Shinkevich > --- > block/stream.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --gi

Re: [PATCH v11 06/13] block: modify the comment for BDRV_REQ_PREFETCH flag

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 15:22, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to use it alone and pass it to the COR-filter driver for further processing. Signed-off-by: Andrey Shinkevich --- include/block/block.h | 7 ---

[PATCH v4] sev: add sev-inject-launch-secret

2020-10-14 Thread tobin
From: Tobin Feldman-Fitzthum AMD SEV allows a guest owner to inject a secret blob into the memory of a virtual machine. The secret is encrypted with the SEV Transport Encryption Key and integrity is guaranteed with the Transport Integrity Key. Although QEMU facilitates the injection of the launch

Re: [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 15:51, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: If the flag BDRV_REQ_PREFETCH was set, pass it further to the COR-driver to skip unneeded reading. It can be taken into account for the COR-algorithms optimization. That check is being made during the block stream job

Re: [PATCH v4 08/12] tests/9pfs: change qtest name prefix to synth

2020-10-14 Thread Christian Schoenebeck
On Donnerstag, 8. Oktober 2020 20:34:56 CEST Christian Schoenebeck wrote: > All existing 9pfs test cases are using the 'synth' fs driver so far, which > means they are not accessing real files, but a purely simulated (in RAM > only) file system. > > Let's make this clear by changing the prefix of

Re: [PATCH v4] sev: add sev-inject-launch-secret

2020-10-14 Thread Daniel P . Berrangé
On Wed, Oct 14, 2020 at 11:17:39AM -0400, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with t

Re: [PATCH v11 10/13] stream: skip filters when writing backing file name to QCOW2 header

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 18:02, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: Avoid writing a filter JSON-name to QCOW2 image when the backing file is changed after the block stream job. Signed-off-by: Andrey Shinkevich --- block/stream.c | 9 + 1 file changed, 5 insertions(+), 4 d

Re: [PATCH v2 1/4] MAINTAINERS: Put myself forward for MIPS target

2020-10-14 Thread Philippe Mathieu-Daudé
On 10/14/20 5:13 PM, Jiaxun Yang wrote: 在 2020/10/13 18:16, Philippe Mathieu-Daudé 写道: To avoid the MIPS target being orphan, volunteer to keep an eye on it and put together pull requests. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jiaxun Yang Thanks for stepping out! 😥 in? -

Re: [PATCH v2 3/6] tools/virtiofsd: xattr name mappings: Add option

2020-10-14 Thread Dr. David Alan Gilbert
* Christophe de Dinechin (dinec...@redhat.com) wrote: > > On 2020-08-27 at 17:36 CEST, Dr. David Alan Gilbert (git) wrote... > > From: "Dr. David Alan Gilbert" > > > > Add an option to define mappings of xattr names so that > > the client and server filesystems see different views. > > This can b

Re: [PATCH V2 1/5] target/riscv: Add basic vmstate description of CPU

2020-10-14 Thread Richard Henderson
On 10/14/20 3:21 AM, Jiangyifei wrote: >> Would this be a good time to expand mstatus to uint64_t instead of >> target_ulong so that it can be saved as one unit and reduce some ifdefs in >> the >> code base? >> >> Similarly with some of the other status registers that are two halved for >> riscv32

Re: [PATCH v11 11/13] stream: mark backing-file argument as deprecated

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 18:03, Max Reitz wrote: On 12.10.20 19:43, Andrey Shinkevich wrote: Whereas the block-stream job starts using a backing file name of the base node overlay after the block-stream job completes, mark the QMP 'backing-file' argument as deprecated. Signed-off-by: Andrey Shinkevich ---

Re: [PATCH v4] sev: add sev-inject-launch-secret

2020-10-14 Thread Brijesh Singh
On 10/14/20 10:17 AM, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with the Transport Integr

Re: [PATCH 05/10] slirp: update for iOS resolv fix

2020-10-14 Thread Joelle van Dyne
Sorry, I was not aware of the rules for RFC. I will remove this one from the v2 patch set. If and when the libslirp changes are in, what are the procedures for sending the QEMU side changes? -j On Tue, Oct 13, 2020 at 7:59 AM Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Marc-André Lurea

[PATCH 01/15] block/nvme: Move nvme_poll_cb() earlier

2020-10-14 Thread Philippe Mathieu-Daudé
We are going to use this callback in nvme_add_io_queue() in few commits. To avoid forward-declaring it, move it before. No logical change. Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletion

[PATCH 06/15] block/nvme: Make nvme_identify() return boolean indicating error

2020-10-14 Thread Philippe Mathieu-Daudé
Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH 04/15] block/nvme: Improve nvme_free_req_queue_wait() trace information

2020-10-14 Thread Philippe Mathieu-Daudé
What we want to trace is the block driver state and the queue index. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- block/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index d84

[PATCH 02/15] block/nvme: Trace nvme_poll_queue() per queue

2020-10-14 Thread Philippe Mathieu-Daudé
As we want to enable multiple queues, report the event in each nvme_poll_queue() call, rather than once in the callback calling nvme_poll_queues(). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 2 +- block/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) di

Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2020 14:44, Chen Qun wrote: A default value is provided for the variable 'bitmap_name' to avoid compiler warning. The compiler show warning: migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_strlcpy(

[PATCH 09/15] block/nvme: Introduce Completion Queue definitions

2020-10-14 Thread Philippe Mathieu-Daudé
Rename Submission Queue flags with 'Sq' and introduce Completion Queue flag definitions. Signed-off-by: Philippe Mathieu-Daudé --- include/block/nvme.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/block/nvme.h b/include/block/nvme.h index 65e68a8

[PATCH 05/15] block/nvme: Trace queue pair creation/deletion

2020-10-14 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index e9410f2e0eb..95f19e12cd6 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -175,6 +175,7 @@ static void nvme_init_queue(B

<    1   2   3   4   >