Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

On Sun, 2020-10-11 at 01:26 -0400, harry harry wrote: > Hi QEMU/KVM developers, > > I am sorry if my email disturbs you. I did an experiment and found the > guest physical addresses (GPAs) are not the same as the corresponding > host virtual addresses (HVAs). I am curious about why; I think they >

[PATCH v4 6/7] qom: Add user_creatable_print_help_from_qdict()

From: Kevin Wolf This adds a function that, given a QDict of non-help options, prints help for user creatable objects. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- include/qom/object_interfaces.h | 21 ++--- qom/object_interfaces.c

[PATCH v4 7/7] qemu-storage-daemon: Remove QemuOpts from --object parser

From: Kevin Wolf The command line parser for --object parses the input twice: Once into QemuOpts just for detecting help options, and then again into a QDict using the keyval parser for actually creating the object. Now that the keyval parser can also detect help options, we can simplify this an

[PATCH v4 5/7] qom: Factor out helpers from user_creatable_print_help()

From: Kevin Wolf This creates separate helper functions for printing a list of user creatable object types and for printing a list of properties of a given type. This will allow using these parts without having a QemuOpts. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Markus A

[PATCH v4 2/7] test-keyval: Demonstrate misparse of ', ' with implied key

Add a test for "val,,ue" with implied key. Documentation says this should parse as implied key with value "val", then fail. The code parses it as implied key with value "val,ue", then succeeds. The next commit will fix it. Signed-off-by: Markus Armbruster --- tests/test-keyval.c | 7 +++

[PATCH v4 0/7] qemu-storage-daemon: Remove QemuOpts from --object

This replaces the QemuOpts-based help code for --object in the storage daemon with code based on the keyval parser. Review of v3 led me to preexisting issues. Instead of posting my fixes separately, then working with Kevin to rebase his work on top of mine, I did the rebase myself and am posting

[PATCH v4 4/7] keyval: Parse help options

From: Kevin Wolf This adds a special meaning for 'help' and '?' as options to the keyval parser. Instead of being an error (because of a missing value) or a value for an implied key, they now request help, which is a new boolean output of the parser in addition to the QDict. A new parameter 'p_h

[PATCH v4 1/7] keyval: Fix and clarify grammar

The grammar has a few issues: * key-fragment = / [^=,.]* / Prose restricts key fragments: they "must be valid QAPI names or consist only of decimal digits". Technically, '' consists only of decimal digits. The code rejects that. Fix the grammar. * val = { / [^,]* / | ',,' }

[PATCH v4 3/7] keyval: Fix parsing of ',' in value of implied key

The previous commit demonstrated documentation and code disagree on parsing of ',' in the value of an implied key. Fix the code to match the documentation. This breaks uses of keyval_parse() that pass an implied key and accept a value containing ','. None of the existing uses does: * audiodev:

[PATCH] sabre: increase number of PCI bus IRQs from 32 to 64

The rework of the sabre IRQs in commit 6864fa3897 "sun4u: update PCI topology to include simba PCI bridges" changed the IRQ routing so that both PCI and legacy OBIO IRQs are routed through the sabre PCI host bridge to the CPU. Unfortunately this commit failed to increase the number of PCI bus IRQs

[PATCH] pci: assert that irqnum is between 0 and bus->nirqs in pci_change_irq_level()

These assertions similar to those in the adjacent pci_bus_get_irq_level() function ensure that irqnum lies within the valid PCI bus IRQ range. Signed-off-by: Mark Cave-Ayland --- This would have immediately picked up on the sabre PCI bus IRQ overflow fixed by the patch I just posted. --- hw/p

Re: [PATCH] pci: assert that irqnum is between 0 and bus->nirqs in pci_change_irq_level()

On 11/10/2020 09:20, Mark Cave-Ayland wrote: > These assertions similar to those in the adjacent pci_bus_get_irq_level() > function > ensure that irqnum lies within the valid PCI bus IRQ range. > > Signed-off-by: Mark Cave-Ayland > --- > > This would have immediately picked up on the sabre PCI

Re: [PATCH] qcow2: cleanup created file when qcow2_co_create

On Tue, 2020-09-01 at 15:30 +0200, Alberto Garcia wrote: > On Thu 16 Jul 2020 01:33:59 PM CEST, Maxim Levitsky wrote: > > if (ret < 0) { > > + > > +Error *local_delete_err = NULL; > > +int r_del = bdrv_co_delete_file(bs, &local_delete_err); > > +/* > > + * ENOTS

[PATCH v2 0/2] qcow2: don't leave partially initialized file on image creation

Use the bdrv_co_delete_file interface to delete the underlying file if qcow2 initilization fails (e.g due to bad encryption secret) This gives the qcow2 the same treatment as to luks. V2: added a patch to fix a memory leak. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1845353 Maxim Levi

[PATCH v2 1/2] crypto: luks: fix tiny memory leak

In the case when underlying block device doesn't support the bdrv_co_delete_file interface, an 'Error' wasn't freed. Signed-off-by: Maxim Levitsky --- block/crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/crypto.c b/block/crypto.c index 0807557763..9b61fd4aa8 100644 --- a/bloc

[PATCH v2 2/2] block: qcow2: remove the created file on initialization error

If the qcow initialization fails after we created the storage file, we should remove it to avoid leaving stale files around. We already do this for luks raw images. Signed-off-by: Maxim Levitsky --- block/qcow2.c | 12 1 file changed, 12 insertions(+) diff --git a/block/qcow2.c b/

Re: [PATCH V13 6/9] target/mips: Add loongson-ext lsdc2 group of instructions

On 10/11/20 5:02 AM, Huacai Chen wrote: Hi, Philippe, On Sat, Oct 10, 2020 at 9:07 PM Philippe Mathieu-Daudé wrote: On 10/7/20 10:39 AM, Huacai Chen wrote: From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This

Re: [PULL v3 0/8] NBD patches through 2020-10-08

On Fri, 9 Oct 2020 at 21:15, Eric Blake wrote: > > The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' > into staging (2020-10-09 15:48:04 +0100) > > are available in the Git repository at: > >

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions(+), 10

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions(+), 10

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8 @

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b/migratio

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7 @@

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add sp

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7 @@

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b/mi

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8 @

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b/mi

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b/migr

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration/migra

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration/migra

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b/migr

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8 @

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7 @@

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add sp

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b/migratio

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add sp

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b/migr

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions(+), 10

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b/mi

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b/migratio

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration/migra

Re: [PATCH v1 0/8] Fix some style problems in migration

Patchew URL: https://patchew.org/QEMU/1602411429-12043-1-git-send-email-yubih...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602411429-12043-1-git-send-email-yubih...@huawei.com Subject: [PATCH v1 0/8]

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

Hi Maxim, Thanks much for your reply. On Sun, Oct 11, 2020 at 3:29 AM Maxim Levitsky wrote: > > On Sun, 2020-10-11 at 01:26 -0400, harry harry wrote: > > Hi QEMU/KVM developers, > > > > I am sorry if my email disturbs you. I did an experiment and found the > > guest physical addresses (GPAs) are

Re: [PATCH v1 0/8] Fix some style problems in migration

Patchew URL: https://patchew.org/QEMU/1602413321-22252-1-git-send-email-yubih...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602413321-22252-1-git-send-email-yubih...@huawei.com Subject: [PATCH v1 0/8]

Re: [PATCH v1 0/8] Fix some style problems in migration

Patchew URL: https://patchew.org/QEMU/1602413863-19513-1-git-send-email-yubih...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602413863-19513-1-git-send-email-yubih...@huawei.com Subject: [PATCH v1 0/8]

Re: [PATCH v3 02/16] fuzz: Add general virtual-device fuzzer

On 201008 0903, Paolo Bonzini wrote: > On 21/09/20 16:34, Alexander Bulekov wrote: > >> Can you fuzz writing "FUZZ" in memory? Like: > >> OP_WRITE(0x10, "UsingLibFUZZerString")? > > No.. Hopefully that's not a huge problem. > > > > Instead of always looking for a separator, can you: > > 1) s

Re: [PATCH v3 05/16] fuzz: Declare DMA Read callback function

On 201008 0939, Paolo Bonzini wrote: > On 21/09/20 04:24, Alexander Bulekov wrote: > > This patch declares the fuzz_dma_read_cb function and uses the > > preprocessor and linker(weak symbols) to handle these cases: > > > > When we build softmmu/all with --enable-fuzzing, there should be no > > str

Re: [PULL 00/22] acceptance regressions, testing, gitdm, plugins

On Fri, 9 Oct 2020 at 17:31, Alex Bennée wrote: > > The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' > into staging (2020-10-09 15:48:04 +0100) > > are available in the Git repository at: >

Re: [PATCH v1 2/8] migration: Don't use '#' flag of printf format

On Sun, 11 Oct 2020 at 14:52, Bihong Yu wrote: > @@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int > version_id) > (addr == 100) ? '\n' : '\r'); > fflush(stdout); > } else if (!(flags & BLK_MIG_FLAG_EOS)) { > -fprintf(st

Re: [PATCH v3 13/15] hw/misc/bcm2835_cprman: add sane reset values to the registers

On 18:18 Sat 10 Oct , Philippe Mathieu-Daudé wrote: > On 10/10/20 3:57 PM, Luc Michel wrote: > > Those reset values have been extracted from a Raspberry Pi 3 model B > > v1.2, using the 2020-08-20 version of raspios. The dump was done using > > the debugfs interface of the CPRMAN driver in Linu

Re: [PULL 00/10] migration queue

On Thu, 8 Oct 2020 at 20:13, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20201008' into > staging (2020-10-08 17:18:46 +0100)

Re: [PULL 00/30] Block patches

On Fri, 9 Oct 2020 at 20:35, Stefan Hajnoczi wrote: > > The following changes since commit 497d415d76b9f59fcae27f22df1ca2c3fa4df64e: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20201008-1' into staging (2020-10-08 > 21:41:20 +0100) > > are available in the Git rep

[PATCH] hw/pci-host/grackle: Verify PIC link is properly set

The Grackle PCI host model expects the interrupt controller being set, but does not verify it is present. Add a check to help developers using this model. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/pci-host/grackle.c

[PATCH 02/10] hw/isa: Add the ISA_IRQ_KBD_DEFAULT definition

The PS2 keyboard uses IRQ #1 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/sparc64/sun4u.c | 2 +- 2 files changed, 2 i

[PATCH 00/10] hw/isa: Introduce definitions for default IRQ values

Replace various magic values by definitions to make the code easier to read. This probably makes sense to merge this series via the 'PC chipset' tree, rather than qemu-trivial@. Regards, Phil. Philippe Mathieu-Daudé (10): hw/isa: Introduce IsaIrqNumber enum hw/isa: Add the ISA_IRQ_KBD_DEFAU

[PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/i386/acpi-build.c | 2 +- hw/ipmi/isa_ip

[PATCH 07/10] hw/isa: Add the ISA_IRQ_RTC_DEFAULT definition

The RTC time keep clock ses IRQ #8 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + include/hw/rtc/mc146818rtc.h | 1 -

[PATCH 01/10] hw/isa: Introduce IsaIrqNumber enum

We are going to list all default ISA IRQs. As all the definitions are related, introduce the IsaIrqNumber type to enumerate them. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/isa/isa.h b/include/h

[PATCH 06/10] hw/isa: Add the ISA_IRQ_PAR_DEFAULT definition

The parallel port uses IRQ #7 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/char/parallel.c | 2 +- hw/sparc64/sun4u.c

[PATCH 05/10] hw/isa: Add the ISA_IRQ_FDC_DEFAULT definition

The floppy disk controller uses IRQ #6 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/block/fdc.c | 4 ++-- hw/sparc

[PATCH 09/10] hw/isa: Add the ISA_IRQ_MOU_DEFAULT definition

The PS2 mouse uses IRQ #12 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/input/pckbd.c | 2 +- hw/sparc64/sun4u.c |

[PATCH 03/10] hw/isa: Add the ISA_IRQ_SER_DEFAULT definition

The first serial port uses IRQ #4 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/sparc64/sun4u.c | 2 +- 2 files changed

[PATCH 10/10] hw/isa: Add the ISA_IRQ_IDE_DEFAULT definition

The IDE controller uses IRQ #14 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/ide/isa.c | 2 +- 2 files changed,

[PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition

The network devices use IRQ #9 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 + hw/net/ne2000-isa.c | 2 +- 2 files changed, 2

[PATCH 1/4] hw: Replace magic value by PCI_NUM_PINS definition

Use self-explicit PCI_NUM_PINS definition instead of magic value. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 4 ++-- hw/mips/gt64xxx_pci.c | 2 +- hw/pci-host/versatile.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/

[PATCH] hw/scsi/megasas: Remove pointless parenthesis

Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/megasas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index e24c12d7eed..d57402c9b09 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -2384,8 +2384,8 @@ static void megasas

[PATCH 0/4] hw: Replace some magic by definitions

A bunch of trivial cleanups, replacing magic values by definitions to make the code easier to review. Expected to be merged via qemu-trivial@. Regards, Phil. Philippe Mathieu-Daudé (4): hw: Replace magic value by PCI_NUM_PINS definition hw/pci-host/pam: Use ARRAY_SIZE() instead of magic val

[PATCH 2/4] hw/pci-host/pam: Use ARRAY_SIZE() instead of magic value

Replace the magic '4' by ARRAY_SIZE(mem->alias) which is more explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/pam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c index a4962057833..4712260025a 100644 --- a/hw/pci-host/pa

[PATCH 3/4] hw/pci-host/versatile: Add WINDOW_COUNT definition to replace magic '3'

Use self-explicit WINDOW_COUNT definition instead of a magic value. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/versatile.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index b495102

[PATCH 4/4] tests/qtest: Replace magic value by NANOSECONDS_PER_SECOND definition

Use self-explicit NANOSECONDS_PER_SECOND definition instead of a magic value. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/rtc-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c index c7af34f6b1b..402ce2c6090 100644

[PATCH] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Commit 0b09be2b2f ("Nicer debug output for exceptions") added twice the same "Tag Overflow" entry, remove the extra one. Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/int32_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helpe

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h

[PoCv2 01/15] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

From: Marc-André Lureau Always put osdep.h first, and remove redundant stdlib.h include. Signed-off-by: Marc-André Lureau --- migration/dirtyrate.c | 3 ++- tests/test-bitmap.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c

[PoCv2 00/15] Rust binding for QAPI (qemu-ga only, for now)

From: Marc-André Lureau Hi, Among the QEMU developers, there is a desire to use Rust. (see previous thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm related projects and other experiments). Thanks to our QAPI type system and the associate code generator, it is relatively s

[PoCv2 02/15] scripts/qapi: teach c_param_type() to return const argument type

From: Marc-André Lureau As it should be, since the argument isn't owned by the callee, but a lot of code in QEMU rely on non-const arguments to tweak it. Since Rust types / bindings are derived from the C version, we have to be more accurate there to do correct ownership conversions. Signed-off

[PoCv2 03/15] build-sys: add --with-rust{-target} & basic build infrastructure

From: Marc-André Lureau Add the build-sys infrastructure to build Rust code. Introduce a top-level workspace, so various sub-projects (libraries, executables etc) can be developed together, sharing the dependencies and output directory. If not Tier 1, many of the platforms QEMU supports are cons

[PoCv2 08/15] qga/rust: generate QGA QAPI sys bindings

From: Marc-André Lureau Use qapi-gen to generate low-level C sys bindings for QAPI types, include them to the build. Signed-off-by: Marc-André Lureau --- qga/Cargo.toml | 4 qga/lib.rs | 1 + qga/meson.build | 11 +++ qga/qapi_sys.rs | 5 + 4 files changed, 21 inserti

[PoCv2 04/15] build-sys: add a cargo-wrapper script

From: Marc-André Lureau Introduce a script to help calling cargo from Rust. Cargo is the most convenient way to build Rust code, with various crates, and has many features that meson lacks in general for Rust. Trying to convert projects to meson automatically is an option I considered (see for e

[PoCv2 05/15] qga/rust: build and link an empty static library

From: Marc-André Lureau Meson doesn't integrate very smoothly with Cargo. Use the cargo-wrapper script as a custom_target() always stale to build the Rust code. The "build-lib" command will produce a static library in the meson expected output directory, as well as link flags that must be employe

[PoCv2 14/15] travis: add Rust

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .travis.yml | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1054ec5d29..b2835316bc 100644 --- a/.travis.yml +++ b/.travis.yml @@ -23,6 +23,8 @@ addons: apt:

[PoCv2 10/15] qga/rust: build Rust types

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qga/lib.rs | 1 + qga/meson.build | 1 + qga/qapi.rs | 6 ++ 3 files changed, 8 insertions(+) create mode 100644 qga/qapi.rs diff --git a/qga/lib.rs b/qga/lib.rs index 050a47e2a3..bff4107569 100644 --- a/qga/lib.rs +++

[PoCv2 06/15] rust: provide a common crate for QEMU

From: Marc-André Lureau This crates provides common bindings and facilities for QEMU C API shared by various projects. Most importantly, it defines the conversion traits used to convert from C to Rust types. Those traits are largely adapted from glib-rs, since those have prooven to be very flexi

[PoCv2 09/15] scripts/qapi: add generation of Rust bindings for types

From: Marc-André Lureau Generate high-level idiomatic Rust code for the QAPI types, with to/from translations for C FFI. - no conditional support yet - C FFI types are mapped to higher-level types (char*->String, Foo*->Foo, has_foo/foo->Option etc) - C enums are simply aliased - C structure

[PoCv2 11/15] qga: add qmp! macro helper

From: Marc-André Lureau Add a macro to help wrapping higher-level qmp handlers, by taking care of errors and return value pointer translation. Signed-off-by: Marc-André Lureau --- qga/lib.rs | 1 + qga/qmp/mod.rs | 36 2 files changed, 37 insertions(+)

[PoCv2 07/15] scripts/qapi: add Rust sys bindings generation

From: Marc-André Lureau Generate the C QAPI types in Rust, with a few common niceties to Debug/Clone/Copy the Rust type. An important question that remains unsolved to be usable with the QEMU schema in this version, is the handling of the 'if' compilation conditions. Since the 'if' value is a C

[PoCv2 13/15] qga: implement {get,set}-vcpus in Rust

From: Marc-André Lureau This is a rewrite of the C version (using the nix & winapi crates). The main difference is that Rust doesn't let you mix const/mut logic, the way transfer_vcpu in C does. The Rust version does introduce some duplication, but is also more strict and can prevent mistakes.

[PoCv2 12/15] qga: implement get-host-name in Rust

From: Marc-André Lureau Use the "hostname" crate (https://github.com/svartalf/hostname) (notice the wrong error message in our win32 implementation) Signed-off-by: Marc-André Lureau --- include/qemu/osdep.h | 10 -- qga/Cargo.toml | 1 + qga/commands.c | 20 --

Re: [PATCH 3/4] hw/pci-host/versatile: Add WINDOW_COUNT definition to replace magic '3'

On Sun, 11 Oct 2020 at 20:49, Philippe Mathieu-Daudé wrote: > > Use self-explicit WINDOW_COUNT definition instead of a magic value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/versatile.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > >

[PoCv2 15/15] rust: use vendored-sources

From: Marc-André Lureau Most likely, QEMU will want tighter control over the sources, rather than relying on crates.io downloading, use a git submodule with all the dependencies. "cargo vendor" makes that simple. Signed-off-by: Marc-André Lureau --- .cargo/config| 5 + .gitmod

Re: [PoCv2 01/15] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

Hi On Mon, Oct 12, 2020 at 12:35 AM wrote: > > From: Marc-André Lureau > > Always put osdep.h first, and remove redundant stdlib.h include. > > Signed-off-by: Marc-André Lureau (ignore this patch, which was already sent earlier) > --- > migration/dirtyrate.c | 3 ++- > tests/test-bitmap.c

Re: [PoCv2 00/15] Rust binding for QAPI (qemu-ga only, for now)

Patchew URL: https://patchew.org/QEMU/20201011203513.1621355-1-marcandre.lur...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201011203513.1621355-1-marcandre.lur...@redhat.com Subject: [PoCv2 00/15] Rus

[PATCH 0/3] hw/ssi: Rename SSI 'slave' as 'peripheral'

In order to use inclusive terminology, rename SSI 'slave' as 'peripheral', following the resolution Paolo pointed in [*]: https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/ Candidate to be merged via the ARM or Trivial trees. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/ms

[PATCH 1/3] hw/ssi/aspeed_smc: Rename max_slaves as max_devices

From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename max_slaves as max_peripherals. Patch generated using: $ sed -i s/slave/peripheral/ \ hw/ssi/aspeed_smc.c include/hw/ssi/aspeed_smc.h One line in aspeed_smc_read() has been manually tweaked to pass checkpatch.

Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition

On 10/11/20 10:28 PM, Stefan Berger wrote: On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote: The TPM TIS device uses IRQ #5 by default. Add this default definition to the IsaIrqNumber enum. Avoid magic values in the code, replace them by the newly introduced definition. Signed-off-by: Philipp

[PATCH 2/3] hw/ssi/ssi: Update coding style to make checkpatch.pl happy

To make the next commit easier to review, clean this code first. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ssi/ssi.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h index fe3028c39dc..c15548425a3 100644 -

[PATCH 3/3] hw/ssi: Rename SSI 'slave' as 'peripheral'

In order to use inclusive terminology, rename SSI 'slave' as 'peripheral', following the specification resolution: https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/ Patch created mechanically using: $ sed -i s/SSISlave/SSIPeripheral/ $(git grep -l SSISlave) $ sed -i s/SSI_SLAVE

  1   2   >