From: Marc-André Lureau <marcandre.lur...@redhat.com>
As it should be, since the argument isn't owned by the callee,
but a lot of code in QEMU rely on non-const arguments to tweak it.
Since Rust types / bindings are derived from the C version, we have to
be more accurate there to do correct ownership conversions.
Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
scripts/qapi/schema.py | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index d1307ec661..ca85c7273a 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -167,8 +167,14 @@ class QAPISchemaType(QAPISchemaEntity):
pass
# Return the C type to be used in a parameter list.
- def c_param_type(self):
- return self.c_type()
+ #
+ # The argument should be considered const, since no ownership is given to
the callee,
+ # but qemu C code frequently tweaks it. Set const=True for a stricter
declaration.
+ def c_param_type(self, const=False):
+ c_type = self.c_type()
+ if const and c_type.endswith(pointer_suffix):
+ c_type = 'const ' + c_type
+ return c_type
# Return the C type to be used where we suppress boxing.
def c_unboxed_type(self):
@@ -221,10 +227,10 @@ class QAPISchemaBuiltinType(QAPISchemaType):
def c_type(self):
return self._c_type_name
- def c_param_type(self):
+ def c_param_type(self, const=False):
if self.name == 'str':
return 'const ' + self._c_type_name
- return self._c_type_name
+ return super().c_param_type(const)
def json_type(self):
return self._json_type_name
--
2.28.0
