Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On Tue, 6 Oct 2020 10:36:37 -0400 Eduardo Habkost wrote: > On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote: > > On Mon, 5 Oct 2020 at 22:10, Eduardo Habkost wrote: > > > > > > The following changes since commit > > > 36d9c2883e55c863b622b99f0ebb5143f0001401: > > > > > > readth

Re: [PATCH v7 14/14] tests/acceptance: add reverse debugging test

On 06.10.2020 16:36, Cleber Rosa wrote: On Sat, Oct 03, 2020 at 08:14:06PM +0300, Pavel Dovgalyuk wrote: From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording sa

Re: [PATCH v5 02/36] qapi: modify docstrings to be sphinx-compatible

On 10/6/20 7:21 AM, Markus Armbruster wrote: John Snow writes: A precise style guide and a package-wide overhaul is forthcoming pending further discussion and consensus. At present, we are avoiding obvious errors that cause sphinx documentation build problems. A preliminary style guide is loo

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On Tue, 6 Oct 2020 17:04:18 +0200 Igor Mammedov wrote: > On Tue, 6 Oct 2020 10:36:37 -0400 > Eduardo Habkost wrote: > > > On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote: > > > On Mon, 5 Oct 2020 at 22:10, Eduardo Habkost wrote: > > > > > > > > > > > The following changes

Re: [PATCH] vhost: Ignore vrings in dirty log when using a vIOMMU

On Tue, 6 Oct 2020 06:49:28 -0400 "Michael S. Tsirkin" wrote: > On Tue, Oct 06, 2020 at 11:58:50AM +0200, Greg Kurz wrote: > > On Mon, 5 Oct 2020 10:18:03 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Sep 28, 2020 at 09:37:18AM +0200, Greg Kurz wrote: > > > > On Mon, 28 Sep 2020 16:23

Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x

On Fri, 2 Oct 2020 16:06:23 -0400 Matthew Rosato wrote: > Seems a more appropriate location for them. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-pci-bus.c | 4 +- > hw/s390x/s390-pci-bus.h | 372 > --- > hw/s390x/s390-pci-i

Re: [PATCH v2 2/9] MAINTAINERS: Update s390 PCI entry to include headers

On Fri, 2 Oct 2020 16:06:24 -0400 Matthew Rosato wrote: > Accomodate changes to file locations. > > Signed-off-by: Matthew Rosato > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b76fb31..dd4e0ea 100644 > --- a/MAINTAINERS > +++ b

Re: [PATCH v2 3/9] update-linux-headers: Add vfio_zdev.h

On Fri, 2 Oct 2020 16:06:25 -0400 Matthew Rosato wrote: > vfio_zdev.h is used by s390x zPCI support to pass device-specific > CLP information between host and userspace. > > Signed-off-by: Matthew Rosato > --- > scripts/update-linux-headers.sh | 2 +- > 1 file changed, 1 insertion(+), 1 delet

[PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

Attempt to fix the issue reported by Kevin. Since v2: - Rename function (lersek) Since RFC(v1): - Keep it local to hw/nvram (danpb) - Based on Meson cleanup Based-on: <20201006125602.2311423-1-phi...@redhat.com> Base is available in the Git repository at: https://gitlab.com/philmd/qemu.git b

Re: [RFC PATCH 1/2] contrib/gitdm: Add more academic contributors

Hi Pavel, On 10/5/20 7:01 AM, Pavel Dovgalyuk wrote: > On Sun, Oct 4, 2020 at 11:40 PM Philippe Mathieu-Daudé > wrote: > > These academic contributors have a number of contributions, > add them to the 'academic' group map. > > Cc: Pavel Dovgaluk

Re: [PATCH v2 4/9] linux-headers: update against 5.9-rc7

On Fri, 2 Oct 2020 16:06:26 -0400 Matthew Rosato wrote: > PLACEHOLDER as the kernel patch driving the need for this ("vfio-pci/zdev: > define the vfio_zdev header") isn't merged yet. > > Signed-off-by: Matthew Rosato > --- > .../drivers/infiniband/hw/vmw_pvrdma/pvrdma_ring.h | 14 > +

[PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed by a device only available using system-mode (fw_cfg), it is implemented by a crypto component (tls-cipher-suites) which is always available when crypto is used. Commit 69699f3055 introduced the following error in the qemu-storage-daemon b

Re: [PATCH v2 5/9] s390x/pci: create a header dedicated to PCI CLP

On Fri, 2 Oct 2020 16:06:27 -0400 Matthew Rosato wrote: > From: Pierre Morel > > To have a clean separation between s390-pci-bus.h and s390-pci-inst.h > headers we export the PCI CLP instructions in a dedicated header. > > Signed-off-by: Pierre Morel > Signed-off-by: Matthew Rosato > --- >

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On 06/10/20 17:23, Igor Mammedov wrote: > Looks like travis-ci lost previous authorizations to my github repo, > but giving a new one didn't help. > > Something wrong with current QEMU master, travis-ci doesn't recognize QEMU > repo a valid anymore. > Interesting, I use Travis->Gitlab integrati

[PATCH] hw/ide/ahci: silence a compiler warning

When built with -Og -ggdb with gcc 8.3 the compiler gets confused reporting: ../../hw/ide/ahci.c: In function ‘ahci_populate_sglist’: ../../hw/ide/ahci.c:965:58: error: ‘tbl_entry_size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] As prdtl being > 0 is a prerequis

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 06/10/20 17:36, Philippe Mathieu-Daudé wrote: > While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed > by a device only available using system-mode (fw_cfg), it is > implemented by a crypto component (tls-cipher-suites) which > is always available when crypto is used. > > Commit 69699f305

Re: [PATCH v2 4/9] linux-headers: update against 5.9-rc7

On 10/6/20 11:39 AM, Cornelia Huck wrote: On Fri, 2 Oct 2020 16:06:26 -0400 Matthew Rosato wrote: PLACEHOLDER as the kernel patch driving the need for this ("vfio-pci/zdev: define the vfio_zdev header") isn't merged yet. Signed-off-by: Matthew Rosato --- .../drivers/infiniband/hw/vmw_pvrd

Re: [PATCH v2 3/6] tools/virtiofsd: xattr name mappings: Add option

On 2020-08-27 at 17:36 CEST, Dr. David Alan Gilbert (git) wrote... > From: "Dr. David Alan Gilbert" > > Add an option to define mappings of xattr names so that > the client and server filesystems see different views. > This can be used to have different SELinux mappings as > seen by the guest, t

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: > +++ b/hw/nvram/fw_cfg-interface.c > @@ -0,0 +1,15 @@ > +#include "qemu/osdep.h" > +#include "hw/nvram/fw_cfg.h" License boilerplate missing. r~

Re: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

Patchew URL: https://patchew.org/QEMU/20201006153636.2383248-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201006153636.2383248-1-phi...@redhat.com Subject: [PATCH v3 0/1] qom: Fix missing inter

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/6/20 5:51 PM, Richard Henderson wrote: > On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >> +++ b/hw/nvram/fw_cfg-interface.c >> @@ -0,0 +1,15 @@ >> +#include "qemu/osdep.h" >> +#include "hw/nvram/fw_cfg.h" > > License boilerplate missing. Grr. Paolo since you queued this, do you mind fi

Re: [PATCH v2 5/6] tools/virtiofsd: xattr name mappings: Map server xattr names

On 2020-08-27 at 17:36 CEST, Dr. David Alan Gilbert (git) wrote... > From: "Dr. David Alan Gilbert" > > Map xattr names coming from the server, i.e. the host filesystem; > currently this is only from listxattr. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/06/20 17:51, Richard Henderson wrote: > On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >> +++ b/hw/nvram/fw_cfg-interface.c >> @@ -0,0 +1,15 @@ >> +#include "qemu/osdep.h" >> +#include "hw/nvram/fw_cfg.h" > > License boilerplate missing. > > r~ > Hrmpf, so easy to forget about that, e

[PATCH 04/12] contrib/gitdm: Add ByteDance to the domain map

There is a number of contributors from this domain, add its own entry to the gitdm domain map. Acked-by: Jiachen Zhang Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index

[PATCH 00/12] contrib/gitdm: First round of updates

Hi Alex, As requested, here as the first round of patches already reviewed. Regards, Phil. Philippe Mathieu-Daudé (12): contrib/gitdm: Add more academic domains contrib/gitdm: Add more individual contributors contrib/gitdm: Add Baidu to the domain map contrib/gitdm: Add ByteDance to the

[PATCH 01/12] contrib/gitdm: Add more academic domains

There is a number of contributions from these academic domains. Add the entries to the gitdm 'academic' domain map. Acked-by: Fan Yang Acked-by: Xinyu Li Reviewed-by: Alexander Bulekov Reviewed-by: Dayeol Lee Acked-by: Bastian Koppelmann Signed-off-by: Philippe Mathieu-Daudé --- contrib/git

[PATCH 02/12] contrib/gitdm: Add more individual contributors

These individual contributors have a number of contributions, add them to the 'individual' group map. Acked-by: Helge Deller Acked-by: Stefan Weil Acked-by: Niek Linnenbank Acked-by: David Carlier Acked-by: Paul Zimmerman Acked-by: Volker Rümelin Acked-by: Finn Thain Signed-off-by: Philippe

[PATCH 05/12] contrib/gitdm: Add Google to the domain map

There is a number of contributors from this domain, add its own entry to the gitdm domain map. Acked-by: Erik Kline Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/d

[PATCH 07/12] contrib/gitdm: Add Qualcomm to the domain map

There is a number of contributions from this domain, add its own entry to the gitdm domain map. Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map

[PATCH 08/12] contrib/gitdm: Add Nir Soffer to Red Hat domain

Acked-by: Nir Soffer Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/group-map-redhat | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-redhat b/contrib/gitdm/group-map-redhat index d15db2d35e..02507b7b53 100644 --- a/contrib/gitdm/group-map-redhat +++ b/contrib

[PATCH 03/12] contrib/gitdm: Add Baidu to the domain map

There is a number of contributors from this domain, add its own entry to the gitdm domain map. Reviewed-by: Chai Wen Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index d

[PATCH 10/12] contrib/gitdm: Add Yadro to the domain map

There is a number of contributions from this domain, add its own entry to the gitdm domain map. Reviewed-by: Roman Bolshakov Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map

[PATCH 09/12] contrib/gitdm: Add SUSE to the domain map

There is a number of contributors from this domain, add its own entry to the gitdm domain map. Acked-by: Bruce Rogers Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index

[PATCH 06/12] contrib/gitdm: Add Nuvia to the domain map

There is a number of contributions from this domain, add its own entry to the gitdm domain map. Reviewed-by: Graeme Gregory Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map

[PATCH 12/12] .mailmap: Fix more contributor entries

These authors have some incorrect author email field. For each of them, there is one commit with the replaced entry. Acked-by: Stefan Berger Acked-by: Erik Smit Signed-off-by: Philippe Mathieu-Daudé --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index b9

[PATCH 11/12] contrib/gitdm: Add Yandex to the domain map

There is a number of contributors from this domain, add its own entry to the gitdm domain map. Reviewed-by: Roman Kagan Signed-off-by: Philippe Mathieu-Daudé --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map inde

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/6/20 6:04 PM, Laszlo Ersek wrote: > On 10/06/20 17:51, Richard Henderson wrote: >> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>> +++ b/hw/nvram/fw_cfg-interface.c >>> @@ -0,0 +1,15 @@ >>> +#include "qemu/osdep.h" >>> +#include "hw/nvram/fw_cfg.h" >> >> License boilerplate missing. >>

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On Tue, 6 Oct 2020 17:42:28 +0200 Paolo Bonzini wrote: > On 06/10/20 17:23, Igor Mammedov wrote: > > Looks like travis-ci lost previous authorizations to my github repo, > > but giving a new one didn't help. > > > > Something wrong with current QEMU master, travis-ci doesn't recognize QEMU > >

Re: [PATCH] hw/ide/ahci: silence a compiler warning

On 10/6/20 5:42 PM, Alex Bennée wrote: > When built with -Og -ggdb with gcc 8.3 the compiler gets confused > reporting: > > ../../hw/ide/ahci.c: In function ‘ahci_populate_sglist’: > ../../hw/ide/ahci.c:965:58: error: ‘tbl_entry_size’ may be used > uninitialized in this function [-Werror=mayb

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 06/10/20 18:02, Philippe Mathieu-Daudé wrote: > On 10/6/20 5:51 PM, Richard Henderson wrote: >> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>> +++ b/hw/nvram/fw_cfg-interface.c >>> @@ -0,0 +1,15 @@ >>> +#include "qemu/osdep.h" >>> +#include "hw/nvram/fw_cfg.h" >> >> License boilerplate m

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/06/20 18:08, Philippe Mathieu-Daudé wrote: > On 10/6/20 6:04 PM, Laszlo Ersek wrote: >> On 10/06/20 17:51, Richard Henderson wrote: >>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: +++ b/hw/nvram/fw_cfg-interface.c @@ -0,0 +1,15 @@ +#include "qemu/osdep.h" +#include

Re: [PATCH v2 5/6] tools/virtiofsd: xattr name mappings: Map server xattr names

On 2020-08-27 at 17:36 CEST, Dr. David Alan Gilbert (git) wrote... > From: "Dr. David Alan Gilbert" > > Map xattr names coming from the server, i.e. the host filesystem; > currently this is only from listxattr. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c

Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

On 10/6/20 6:15 PM, Paolo Bonzini wrote: > On 06/10/20 18:02, Philippe Mathieu-Daudé wrote: >> On 10/6/20 5:51 PM, Richard Henderson wrote: >>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: +++ b/hw/nvram/fw_cfg-interface.c @@ -0,0 +1,15 @@ +#include "qemu/osdep.h" +#includ

Re: [PATCH v2 1/6] spapr/xive: Introduce a StoreEOI capability

On Mon, 5 Oct 2020 18:51:42 +0200 Cédric Le Goater wrote: > When an interrupt has been handled, the OS notifies the interrupt > controller with an EOI sequence. On the XIVE interrupt controller > (POWER9 and POWER10), this can be done with a load or a store > operation on the ESB interrupt manage

Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x

On 10/6/20 11:32 AM, Cornelia Huck wrote: On Fri, 2 Oct 2020 16:06:23 -0400 Matthew Rosato wrote: Seems a more appropriate location for them. Signed-off-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 4 +- hw/s390x/s390-pci-bus.h | 372 --

Re: [PATCH v5 03/36] qapi-gen: Separate arg-parsing from generation

On 10/6/20 7:51 AM, Markus Armbruster wrote: John Snow writes: This is a minor re-work of the entrypoint script. It isolates a generate() method from the actual command-line mechanism. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --

Re: [PATCH v2 2/6] spapr/xive: Add a warning when StoreEOI is activated on POWER8 CPUs

On Mon, 5 Oct 2020 18:51:43 +0200 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr_caps.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c > index 57c62c22e4cc..b0a9d0227db2 100644 > --- a/hw/ppc/spapr_caps

Re: [PATCH v2 3/6] spapr/xive: Add a warning when StoreEOI is activated on POWER9 CPUs

On Mon, 5 Oct 2020 18:51:44 +0200 Cédric Le Goater wrote: > StoreEOI on POWER9 CPUs is racy because load-after-store ordering is > not enforced. > > Signed-off-by: Cédric Le Goater > --- > hw/ppc/spapr_caps.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/ppc/spapr_caps.

Re: [PATCH v2 4/6] spapr/xive: Enforce load-after-store ordering

On Mon, 5 Oct 2020 18:51:45 +0200 Cédric Le Goater wrote: > The XIVE_ESB_SET_PQ_10 load operation is used to disable temporarily > an interrupt source. If StoreEOI is active, a source could be left > enabled if the load and store operations come out of order. > > QEMU makes use of this offset to

Re: [PATCH v2 3/6] spapr/xive: Add a warning when StoreEOI is activated on POWER9 CPUs

On 10/6/20 6:58 PM, Greg Kurz wrote: > On Mon, 5 Oct 2020 18:51:44 +0200 > Cédric Le Goater wrote: > >> StoreEOI on POWER9 CPUs is racy because load-after-store ordering is >> not enforced. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/ppc/spapr_caps.c | 9 + >> 1 file changed, 9 i

Re: [PATCH v2 5/6] spapr/xive: Activate StoreEOI at the source level

On Mon, 5 Oct 2020 18:51:46 +0200 Cédric Le Goater wrote: > When the StoreEOI capability is "on", the H_INT_GET_SOURCE_INFO will > set the StoreEOI flag for all sources. This could be an issue if > StoreEOI is not supported on a specific source, of a passthrough > device for instance. In that cas

Re: [PATCH 3/3] docs/devel/qtest: Include libqtest API reference

On 05/10/2020 22.52, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost --- docs/devel/qtest.rst | 6 ++ tests/qtest/libqos/libqtest.h | 20 ++-- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/docs/devel/qtest.rst b/docs/devel/qtest.rst inde

Re: [PATCH 0/3] docs: Include QTest protocol and libqtest API on documentation

On 05/10/2020 22.52, Eduardo Habkost wrote: This moves the QTest section of testing.rst to a separate document, and include the QTest Protocol specification and libqtest API reference in the document. Eduardo Habkost (3): docs: Move QTest documentation to its own document docs/devel/qtest:

Re: [PATCH 3/3] docs/devel/qtest: Include libqtest API reference

On Tue, Oct 06, 2020 at 07:12:17PM +0200, Thomas Huth wrote: > On 05/10/2020 22.52, Eduardo Habkost wrote: > > Signed-off-by: Eduardo Habkost > > --- > > docs/devel/qtest.rst | 6 ++ > > tests/qtest/libqos/libqtest.h | 20 ++-- > > 2 files changed, 16 insertions(+

[PATCH v10.5 0/1] tests/tcg/aarch64: Add bti mmap smoke test

Based-on: 20201002215955.254866-1-richard.hender...@linaro.org (linux-user: User support for AArch64 BTI) Adding a second smoke test, which both tests PROT_BTI via the syscall, as opposed to the ELF NOTE. r~ Richard Henderson (1): tests/tcg/aarch64: Add bti mmap smoke test tests/tcg/aarch6

[PATCH 1/1] tests/tcg/aarch64: Add bti mmap smoke test

This tests PROT_BTI, and also does not require special compiler support. Signed-off-by: Richard Henderson --- tests/tcg/aarch64/bti-2.c | 108 ++ tests/tcg/aarch64/Makefile.target | 7 +- 2 files changed, 113 insertions(+), 2 deletions(-) create mode 100644

Re: [PATCH v10.5 0/1] tests/tcg/aarch64: Add bti mmap smoke test

Patchew URL: https://patchew.org/QEMU/20201006172359.2998-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201006172359.2998-1-richard.hender...@linaro.org Subject: [PATCH v10.5 0/1] tes

Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x

On 10/6/20 11:43 AM, Matthew Rosato wrote: >> Looks good, but... >> >> Is there any way to coax out a more reviewable version of this >> via git mv? >> > > I tried git mv, but a diff between the old patch and the new patch looks the > same (other than the fact that I squashed the MAINTAINERS hit i

Re: [PATCH v5 10/10] migration: introduce snapshot-{save,load,delete} QMP commands

* Eric Blake (ebl...@redhat.com) wrote: > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote: > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The reasons for the lack of conversion are > > that they blocked execution of the event thread, and

Re: [PATCH v2 6/6] spapr/xive: Introduce a new CAS value for the StoreEOI capability

On Mon, 5 Oct 2020 18:51:47 +0200 Cédric Le Goater wrote: > When the StoreEOI capability is set to "cas", let CAS decide when > StoreEOI should be advertised. StoreEOI is safe to use with a P10 > compat machine because the OS enforces load-after-store ordering but > not with P9 compat. > > The q

Re: [PATCH v2 1/9] s390x/pci: Move header files to include/hw/s390x

On 10/6/20 1:33 PM, Richard Henderson wrote: On 10/6/20 11:43 AM, Matthew Rosato wrote: Looks good, but... Is there any way to coax out a more reviewable version of this via git mv? I tried git mv, but a diff between the old patch and the new patch looks the same (other than the fact that I

Re: [PATCH v2 5/6] spapr/xive: Activate StoreEOI at the source level

On 10/6/20 7:06 PM, Greg Kurz wrote: > On Mon, 5 Oct 2020 18:51:46 +0200 > Cédric Le Goater wrote: > >> When the StoreEOI capability is "on", the H_INT_GET_SOURCE_INFO will >> set the StoreEOI flag for all sources. This could be an issue if >> StoreEOI is not supported on a specific source, of a

[PATCH] tests/docker: Add genisoimage to the docker file

genisoimage is needed for running the tests/qtest/cdrom-test qtest. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/centos8.docker | 1 + tests/docker/dockerfiles/debian-amd64.docker | 1 + tests/docker/dockerfiles/fedora.docker | 1 + tests/docker/dockerfiles/ubuntu2004.docke

Re: [PATCH] tests/docker: Add genisoimage to the docker file

On 10/6/20 7:43 PM, Thomas Huth wrote: > genisoimage is needed for running the tests/qtest/cdrom-test qtest. > > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/centos8.docker | 1 + > tests/docker/dockerfiles/debian-amd64.docker | 1 + > tests/docker/dockerfiles/fedora.docker

Re: [PATCH v5 00/36] qapi: static typing conversion, pt1

On Mon, Oct 05, 2020 at 07:57:18PM -0400, John Snow wrote: > On 10/5/20 7:05 PM, Cleber Rosa wrote: > > Here on patches 08 an later, I've run: > > > >flake8 ./scripts/qapi > > > > And starting on patch 24 ("qapi/source.py: add type hint annotations") > > it complained about: > > > >/scri

Re: [PATCH v2 6/6] spapr/xive: Introduce a new CAS value for the StoreEOI capability

On 10/6/20 7:39 PM, Greg Kurz wrote: > On Mon, 5 Oct 2020 18:51:47 +0200 > Cédric Le Goater wrote: > >> When the StoreEOI capability is set to "cas", let CAS decide when >> StoreEOI should be advertised. StoreEOI is safe to use with a P10 >> compat machine because the OS enforces load-after-store

Fwd: Enable IOMMU Inside QEMU

How Can i i enable vIOMMU inside QEMU Have run the qemu with below parameters. root@beta-hp-p70:/home/fastlinq/alok/KVM-VM# ps -ef | grep qemu root 20347 1 2 06:06 ?00:00:36 /usr/bin/qemu-system-x86_64 -name guest=centos7_8_vm,debug-threads=on -S -object secret,id=masterKey0,forma

Re: [PATCH v2] elfload: use g_new/g_malloc and g_autofree

Since bsd user space emulation doesn't work for me I can only use 'gmake check'... But some tests don't seem to be supported. On Mon, 2020-10-05 at 10:55 +0100, Peter Maydell wrote: > On Sun, 4 Oct 2020 at 13:22, Elena Afanasova > wrote: > > Subject: [PATCH v2] elfload: use g_new/g_malloc and g_a

Re: [PATCH v4 3/4] pc-bios: s390x: Use reset PSW if avaliable

On 06/10/2020 11.42, Janosch Frank wrote: If a blob provides a reset PSW then we should use it instead of branching to the PSW address and using our own mask. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 6 -- pc-bios/s390-ccw/jump2ipl.c | 26

Re: [PATCH 01/16] hw/core/cpu: Let CPU object have a clock source

On 10/5/20 9:22 PM, Eduardo Habkost wrote: > On Mon, Oct 05, 2020 at 08:29:24PM +0200, Philippe Mathieu-Daudé wrote: >> On 10/5/20 8:09 PM, Philippe Mathieu-Daudé wrote: >>> On 10/5/20 7:44 PM, Eduardo Habkost wrote: On Mon, Oct 05, 2020 at 06:40:09PM +0200, Igor Mammedov wrote: > On Wed,

Re: [PATCH v7 14/14] tests/acceptance: add reverse debugging test

On Tue, Oct 06, 2020 at 06:09:55PM +0300, Pavel Dovgalyuk wrote: > On 06.10.2020 16:36, Cleber Rosa wrote: > > On Sat, Oct 03, 2020 at 08:14:06PM +0300, Pavel Dovgalyuk wrote: > > > From: Pavel Dovgalyuk > > > > > > This is a test for GDB reverse debugging commands: reverse step and > > > revers

Re: KVM call for agenda for 2020-10-06

Thank you everyone who joined the call. The meeting notes are below. Stefan --- *KVM Community Call - Tue Oct 6th *Topic: QEMU CLI QAPI conversion * John Snow's summary of command-line options: https://docs.google.com/spreadsheets/d/1OJvzDwLpo2XsGytNp9Pr-vYIrb0pWrFKBNPtOyH80ew/edit?usp=sharin

[PULL 04/16] pc-bios/s390-ccw: Move the inner logic of find_subch() to a separate function

Move the code to a separate function to be able to re-use it from a different spot later. Reviewed-by: Claudio Imbrenda Message-Id: <20200806105349.632-5-th...@redhat.com> Reviewed-by: Cornelia Huck Reviewed-by: Janosch Frank Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 99 +++

[PULL 01/16] pc-bios/s390-ccw/Makefile: Compile with -std=gnu99, -fwrapv and -fno-common

The main QEMU code is compiled with -std=gnu99, -fwrapv and -fno-common. We should use the same flags for the s390-ccw bios, too, to avoid that we get different behavior with different compiler versions that changed their default settings in the course of time (it happened at least with -std=... an

[PULL 00/16] s390-ccw bios update

Hi Peter, the following changes since commit d7c5b788295426c1ef48a9ffc3432c51220f69ba: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2020-10-06 12:15:59 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pul

[PULL 03/16] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others

Remove the "#ifndef E..." guards from the defines here - the header guard S390_CCW_H at the top of the file should avoid double definition, and if the error code is defined in a different file already, we're in trouble anyway, then it's better to see the error at compile time instead of hunting wei

[PULL 08/16] pc-bios/s390-ccw/main: Remove superfluous call to enable_subchannel()

enable_subchannel() is already done during is_dev_possibly_bootable() (which is called from find_boot_device() -> find_subch()), so there is no need to do this again in the main() function. Message-Id: <20200806105349.632-9-th...@redhat.com> Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth

[PULL 09/16] pc-bios/s390-ccw: fix off-by-one error

From: Marc Hartmayer This error takes effect when the magic value "zIPL" is located at the end of a block. For example if s2_cur_blk = 0x7fe18000 and the magic value "zIPL" is located at 0x7fe18ffc - 0x7fe18fff. Fixes: ba831b25262a ("s390-ccw: read stage2 boot loader data to find menu") Reviewed

[PULL 06/16] pc-bios/s390-ccw: Scan through all devices if no boot device specified

If no boot device has been specified (via "bootindex=..."), the s390-ccw bios scans through all devices to find a bootable device. But so far, it stops at the very first block device (including virtio-scsi controllers without attached devices) that it finds, no matter whether it is bootable or not.

[PULL 02/16] pc-bios/s390-ccw: Move ipl-related code from main() into a separate function

Let's move this part of the code into a separate function to be able to use it from multiple spots later. Reviewed-by: Claudio Imbrenda Reviewed-by: Cornelia Huck Reviewed-by: Janosch Frank Message-Id: <20200806105349.632-3-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/mai

[PULL 14/16] pc-bios: s390x: Go into disabled wait when encountering a PGM exception

From: Janosch Frank Let's setup a PGM PSW, so we won't load 0s when a program exception happens. Instead we'll load a disabled wait PSW. Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger Reviewed-by: Thomas Huth Message-Id: <20201006094249.50640-5-fran...@linux.ibm.com> Signed-o

[PULL 05/16] pc-bios/s390-ccw: Do not bail out early if not finding a SCSI disk

In case the user did not specify a boot device, we want to continue looking for other devices if there are no valid SCSI disks on a virtio- scsi controller. As a first step, do not panic in this case and let the control flow carry the error to the upper functions instead. Message-Id: <202008061053

[PULL 12/16] pc-bios: s390x: Save PSW rework

From: Janosch Frank We don't need to save the ipl_continue variable in lowcore and have it limited to 32 bits because of the lowcore layout. Let's move it to a new 64 bit variable and get rid of the reset info struct. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Message-Id: <202010060

[PULL 10/16] pc-bios/s390-ccw: break loop if a null block number is reached

From: Marc Hartmayer Break the loop if `cur_block_nr` is a null block number because this means that the end of chunk is reached. In this case we will try to boot the default entry. Fixes: ba831b25262a ("s390-ccw: read stage2 boot loader data to find menu") Reviewed-by: Collin Walling Signed-of

[PULL 11/16] pc-bios: s390x: Fix bootmap.c zipl component entry data handling

From: Janosch Frank The two main types of zipl component entries are execute and load/data. The last member of the component entry struct therefore denotes either a PSW or an address. Let's make this a bit more clear by introducing a union and cleaning up the code that uses that struct member. T

[PULL 16/16] tests/qtest/cdrom: Add more s390x-related boot tests

Let's add two new tests: 1) Booting with "bootindex" is the architected default behavior on the s390x target, so we should have at least one test that is using the "bootindex" property. 2) The s390-ccw bios used to fail when other unbootable devices have been specified before the bootable device

[PULL 13/16] pc-bios: s390x: Use reset PSW if avaliable

From: Janosch Frank If a blob provides a reset PSW then we should use it instead of branching to the PSW address and using our own mask. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Message-Id: <20201006094249.50640-4-fran...@linux.ibm.com> [thuth: Use Elvis operator to shorten long l

[PULL 07/16] pc-bios/s390-ccw: Allow booting in case the first virtio-blk disk is bad

If you try to boot with two virtio-blk disks (without bootindex), and only the second one is bootable, the s390-ccw bios currently stops at the first disk and does not continue booting from the second one. This is annoying - and all other major QEMU firmwares succeed to boot from the second disk in

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On 06/10/2020 18.14, Igor Mammedov wrote: On Tue, 6 Oct 2020 17:42:28 +0200 Paolo Bonzini wrote: On 06/10/20 17:23, Igor Mammedov wrote: Looks like travis-ci lost previous authorizations to my github repo, but giving a new one didn't help. Something wrong with current QEMU master, travis-ci

[PULL 15/16] pc-bios/s390: Update the s390-ccw bios binaries

Make sure that the binaries match the current state of the sources. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes pc-bios/s390-netboot.img | Bin 67232 -> 67232 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bi

Re: [RFC PATCH 1/2] contrib/gitdm: Add more academic contributors

On Tue, Oct 6, 2020 at 6:39 PM Philippe Mathieu-Daudé wrote: > Hi Pavel, > > On 10/5/20 7:01 AM, Pavel Dovgalyuk wrote: > > On Sun, Oct 4, 2020 at 11:40 PM Philippe Mathieu-Daudé > > wrote: > > > > These academic contributors have a number of contributions, > > ad

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

On 06/10/2020 16.42, Daniel P. Berrangé wrote: On Tue, Oct 06, 2020 at 03:38:56PM +0100, Peter Maydell wrote: On Tue, 6 Oct 2020 at 15:36, Eduardo Habkost wrote: On Tue, Oct 06, 2020 at 03:03:57PM +0100, Peter Maydell wrote: Compile failure on OSX: ../../hw/core/numa.c:429:20: error: format

Re: [PULL 00/21] machine + QOM queue, 2020-10-05

Il mar 6 ott 2020, 20:47 Thomas Huth ha scritto: > I think Cirrus-CI needs a github account? Is there a way to use Gitlab now > instead? (just like Travis recently added Gitlab support?) > It does only support GitHub. In theory you can set up an automatic push from Gitlab to GitHub but it doesn'

Re: [PATCH 01/16] hw/core/cpu: Let CPU object have a clock source

On 10/6/20 8:11 PM, Philippe Mathieu-Daudé wrote: > On 10/5/20 9:22 PM, Eduardo Habkost wrote: >> On Mon, Oct 05, 2020 at 08:29:24PM +0200, Philippe Mathieu-Daudé wrote: >>> On 10/5/20 8:09 PM, Philippe Mathieu-Daudé wrote: On 10/5/20 7:44 PM, Eduardo Habkost wrote: > On Mon, Oct 05, 2020

Re: [PATCH v7 14/14] tests/acceptance: add reverse debugging test

On 10/3/20 7:14 PM, Pavel Dovgalyuk wrote: > From: Pavel Dovgalyuk > > This is a test for GDB reverse debugging commands: reverse step and reverse > continue. > Every test in this suite consists of two phases: record and replay. > Recording saves the execution of some instructions and makes an i

Re: [PULL 00/37] Build system + accel + record/replay patches for 2020-10-06

On Tue, 6 Oct 2020 at 08:32, Paolo Bonzini wrote: > > The following changes since commit 0ac0b47c44b4be6cbce26777a1a5968cc8f025a5: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-10-05 13:12:55 +0100) > > are available in the Git repository at: >

Re: Fwd: Enable IOMMU Inside QEMU

On Tue, Oct 06, 2020 at 11:26:08PM +0530, Alok Prasad wrote: > root@beta-hp-p70:/home/fastlinq/alok/KVM-VM# /usr/bin/qemu-system-x86_64 > --version > QEMU emulator version 4.2.1 > Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers > > I am missing here something,? Is there sep

Re: [PATCH] qom: fix objects with improper parent type

On Tue, 2020-10-06 at 01:55 -0400, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 04:47:14PM -0700, Sergey Nizovtsev wrote: > > Some objects accidentally inherit ObjectClass instead of Object. > > They compile silently but may crash after downcasting. > > > > In this patch, we introduce a coc

[PATCH 1/1] docs: Clarify formatting for 'fmode' and 'dmode'

Explictly state that the 'fmode' and 'dmode' values for a fsdev/virtfs must be formatted with a preceeding 0 to be interpreted as base-8. Currently the code will parse a value like "644" as base-10 which leads to unexpected behavior. Signed-off-by: Brian Turek --- qemu-options.hx | 8 ++-- 1

<    1   2   3   4   5   >