Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

2020-10-01 Thread Cornelia Huck
On Mon, 28 Sep 2020 14:27:08 +0200 David Hildenbrand wrote: > With this patchset, I can boot a kernel compiled for z14 (requiring > Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max). > > I am currently working on "vector-enhancements facility 1", I have most > stuff in place exce

Re: [PULL 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob

2020-10-01 Thread Laszlo Ersek
On 09/29/20 17:46, Kevin Wolf wrote: > Am 04.07.2020 um 18:39 hat Philippe Mathieu-Daudé geschrieben: >> Since our format is consumable by the fw_cfg device, >> we can implement the FW_CFG_DATA_GENERATOR interface. >> >> Example of use to dump the cipher suites (if tracing enabled): >> >> $ qemu-

Re: [PATCH] ssi: Display chip select polarity in monitor 'info qtree'

2020-10-01 Thread Cédric Le Goater
On 9/27/20 11:19 AM, Philippe Mathieu-Daudé wrote: > It is sometime useful to verify a device chip select polarity > on a SPI bus. Since we have this information available, display > it in the 'info qtree' monitor output: > > $ qemu-system-arm -M lm3s6965evb -monitor stdio -S > (qemu) info qtr

Re: Outline for VHOST_USER_PROTOCOL_F_VDPA

2020-10-01 Thread Gerd Hoffmann
Hi, > > Architecturally, I think we can have 3 processes: > > > > VMM -- guest device emulation -- host backend > > > > to me this looks like increasing our defence in depth strength, > > as opposed to just shifting things around ... > > Cool idea. Isn't that exactly what we can do once the

Re: [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM

2020-10-01 Thread Paolo Bonzini
On 29/09/20 22:36, Philippe Mathieu-Daudé wrote: > Yes, the problem if I don't restrict to KVM, when > using the Xen accelerator odd things occur > (using configure --enable-xen --disable-tcg --disable-kvm): > > Compiling C object libqemu-i386-softmmu.fa.p/hw_cpu_a15mpcore.c.o > hw/cpu/a15mpcore.c

Re: [PATCH v6 11/15] iotests: add 298 to test new preallocate filter driver

2020-10-01 Thread Max Reitz
On 25.09.20 17:32, Vladimir Sementsov-Ogievskiy wrote: > 25.09.2020 18:11, Vladimir Sementsov-Ogievskiy wrote: >> 25.09.2020 12:11, Max Reitz wrote: >>> On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote: 25.09.2020 11:26, Max Reitz wrote: > On 18.09.20 20:19, Vladimir Sementsov-Ogievsk

Re: [RFC PATCH v4 27/29] Hexagon (linux-user/hexagon) Linux user emulation

2020-10-01 Thread Laurent Vivier
Le 30/09/2020 à 22:47, Taylor Simpson a écrit : > > >> -Original Message- >> From: Laurent Vivier >> Sent: Monday, September 28, 2020 3:03 PM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; phi...@redhat.com; riku.voi...@iki.fi; >> aleksandar.m.m...@gma

RE: [PATCH] xen-bus: reduce scope of backend watch

2020-10-01 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 30 September 2020 12:43 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Paul Durrant > ; Jerome > Leseinne ; Edwin Torok ; > Stefano Stabellini > > Subject: Re: [PATCH] xen-bus: reduce scope of backend

[PATCH v2] xen-bus: reduce scope of backend watch

2020-10-01 Thread Paul Durrant
From: Paul Durrant Currently a single watch on /local/domain/X/backend is registered by each QEMU process running in service domain X (where X is usually 0). The purpose of this watch is to ensure that QEMU is notified when the Xen toolstack creates a new device backend area. Such a backend area

Re: [PATCH v6 14/15] scripts/simplebench: improve ascii table: add difference line

2020-10-01 Thread Max Reitz
On 25.09.20 19:13, Vladimir Sementsov-Ogievskiy wrote: > 25.09.2020 13:24, Max Reitz wrote: >> On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: >>> Performance improvements / degradations are usually discussed in >>> percentage. Let's make the script calculate it for us. >>> >>> Signed-off-by

[PATCH v2 6/9] tests/acpi: add empty tests/data/acpi/microvm/DSDT.{usb, rtc} files

2020-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/data/acpi/microvm/DSDT.rtc | 0 tests/data/acpi/microvm/DSDT.usb | 0 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/data/acpi/microvm/DSDT.rtc create mode 100644 tests/data/acpi/microvm/DSDT.usb diff --git a/tests/data/acpi/mic

[PATCH v2 0/9] microvm: add usb support

2020-10-01 Thread Gerd Hoffmann
This depends on the pending microvm pull request. v2: - add some xhci cleanups. - move aml builder to sysbus-xhci. - add acpi testcase for usb=on (and while being at it rtc=on too). Gerd Hoffmann (9): acpi: add aml builder stubs usb/xhci: add include/hw/usb/xhci.h header file usb/xhci: a

[PATCH v2 7/9] tests/acpi: add microvm usb test

2020-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index edf672d26f0b..ed7aba69c9bd 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tab

[PATCH v2 5/9] tests/acpi: allow updates for expected data files

2020-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..afd6b04a475a 100644 --- a/tests/qtest/bios-tables-test-

[PATCH v2 9/9] tests/acpi: update expected data files

2020-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- tests/data/acpi/microvm/DSDT.rtc| Bin 0 -> 404 bytes tests/data/acpi/microvm/DSDT.usb| Bin 0 -> 414 bytes 3 files changed, 2 deletions(-) diff --git a/tests/qtest/bios-tables-test-all

[PATCH v2 1/9] acpi: add aml builder stubs

2020-10-01 Thread Gerd Hoffmann
Add stubs for aml_interrupt and aml_memory32_fixed, these will be needed by followup patches, Signed-off-by: Gerd Hoffmann --- hw/acpi/aml-build-stub.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/acpi/aml-build-stub.c b/hw/acpi/aml-build-stub.c index 58b2e162277f..8d8a

[PATCH v2 8/9] tests/acpi: add microvm rtc test

2020-10-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index ed7aba69c9bd..e62918a5f495 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tab

[PATCH v2 4/9] microvm: add usb support

2020-10-01 Thread Gerd Hoffmann
Wire up "usb=on" machine option, when enabled add a sysbus xhci controller with 8 ports. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 5 - hw/i386/acpi-microvm.c| 9 + hw/i386/microvm.c | 13 + 3 files changed, 26 insertions(+), 1 deletion(-)

[PATCH v2 2/9] usb/xhci: add include/hw/usb/xhci.h header file

2020-10-01 Thread Gerd Hoffmann
Move a bunch of defines which might be needed outside core xhci code to that place. Add XHCI_ prefixes to avoid name clashes. No functional change. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci-sysbus.h | 1 - hw/usb/hcd-xhci.h| 22 ++ include/hw/usb/xhci.h|

[PATCH v2 3/9] usb/xhci: add xhci_sysbus_build_aml() helper

2020-10-01 Thread Gerd Hoffmann
The helper generates an acpi dsdt device entry for the xhci sysbus device. Signed-off-by: Gerd Hoffmann --- include/hw/usb/xhci.h| 2 ++ hw/usb/hcd-xhci-sysbus.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/usb/xhci.h b/include/hw/usb/xhci.h index dc0c299

Re: [PATCH v6 11/15] iotests: add 298 to test new preallocate filter driver

2020-10-01 Thread Thomas Huth
On 25/09/2020 17.11, Vladimir Sementsov-Ogievskiy wrote: > 25.09.2020 12:11, Max Reitz wrote: >> On 25.09.20 10:49, Vladimir Sementsov-Ogievskiy wrote: >>> 25.09.2020 11:26, Max Reitz wrote: On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievski

Re: [PATCH 1/9] hw/block/nvme: remove pointless rw indirection

2020-10-01 Thread Klaus Jensen
On Oct 1 06:05, Klaus Jensen wrote: > On Sep 30 15:04, Keith Busch wrote: > > The code switches on the opcode to invoke a function specific to that > > opcode. There's no point in consolidating back to a common function that > > just switches on that same opcode without any actual common code. > >

Re: [RFC PATCH v4 22/29] Hexagon (target/hexagon) macros

2020-10-01 Thread Philippe Mathieu-Daudé
On 9/30/20 11:22 PM, Taylor Simpson wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé On >> Behalf Of Philippe Mathieu-Daudé >> Sent: Tuesday, September 29, 2020 6:34 AM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; laur...@vivier.eu; riku.vo

Re: [PATCH v4 04/46] qapi: modify docstrings to be sphinx-compatible

2020-10-01 Thread Markus Armbruster
John Snow writes: > On 9/30/20 4:47 AM, Markus Armbruster wrote: >> Sadly, the fact that start_if() and end_if() are functions isn't >> immediately obvious anymore. >> I've seen :func:`start_if` elsewhere. Is this something we should >> or >> want to use? > > Looks like `start_if()` works just f

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-10-01 Thread Julia Suvorova
On Thu, Sep 24, 2020 at 11:20 AM Michael S. Tsirkin wrote: > > On Thu, Sep 24, 2020 at 09:00:06AM +0200, Julia Suvorova wrote: > > The patch set consists of two parts: > > patches 1-4: introduce new feature > > 'acpi-pci-hotplug-with-bridge-support' on Q35 > > patches 5-7: make the fe

Re: [PATCH v4 04/46] qapi: modify docstrings to be sphinx-compatible

2020-10-01 Thread Markus Armbruster
John Snow writes: > On 9/30/20 4:47 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> I did not say "sphinx beautiful", just "sphinx compatible". They will >>> not throw errors when parsed and interpreted as ReST. >> "Bang on the keyboard until Sphinx doesn't throw errors anymore" >> mig

Re: io_uring possibly the culprit for qemu hang (linux-5.4.y)

2020-10-01 Thread Stefano Garzarella
+Cc: qemu-devel@nongnu.org Hi, On Thu, Oct 01, 2020 at 01:26:51AM +0900, Ju Hyung Park wrote: > Hi everyone. > > I have recently switched to a setup running QEMU 5.0(which supports > io_uring) for a Windows 10 guest on Linux v5.4.63. > The QEMU hosts /dev/nvme0n1p3 to the guest with virtio-blk w

Re: [PULL v4 00/48] virtio,pc,acpi: fixes, tests

2020-10-01 Thread Laszlo Ersek
On 09/29/20 13:13, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 12:07:01PM +0100, Peter Maydell wrote: >> On Tue, 29 Sep 2020 at 12:04, Michael S. Tsirkin wrote: >>> >>> On Tue, Sep 29, 2020 at 03:20:52AM -0400, Michael S. Tsirkin wrote: Changes from v3: - dropped reconnect tests

Re: [PATCH v1 03/15] meson: move libmpathpersist test

2020-10-01 Thread Alex Bennée
Paolo Bonzini writes: > On 30/09/20 12:54, Thomas Huth wrote: >> On 30/09/2020 12.51, Alex Bennée wrote: >>> >>> Paolo Bonzini writes: >>> On 25/09/20 17:40, Alex Bennée wrote: > From: Paolo Bonzini > > This is the first compiler/linker test that has been moved to Meson.

Re: [PATCH 9/9] hw/block/nvme: report actual LBA data shift in LBAF

2020-10-01 Thread Klaus Jensen
On Sep 30 15:04, Keith Busch wrote: > From: Dmitry Fomichev > > Calculate the data shift value to report based on the set value of > logical_block_size device property. > > In the process, use a local variable to calculate the LBA format > index instead of the hardcoded value 0. This makes the c

Re: [PATCH] block/nvme: Add driver statistics for access alignment and hw errors

2020-10-01 Thread Stefan Hajnoczi
On Wed, Sep 30, 2020 at 03:36:17PM +0200, Philippe Mathieu-Daudé wrote: > "return": [ > { > "device": "", > "node-name": "drive0", > "stats": { > "flush_total_time_ns": 6026948, > "wr_highest_offset": 3383991230464, >

Re: [PATCH v26 09/17] vfio: Add load state functions to SaveVMHandlers

2020-10-01 Thread Cornelia Huck
On Wed, 23 Sep 2020 04:54:11 +0530 Kirti Wankhede wrote: > Sequence during _RESUMING device state: > While data for this device is available, repeat below steps: > a. read data_offset from where user application should write data. > b. write data of data_size to migration region from data_offset

Re: [PATCH 2/9] hw/block/nvme: fix log page offset check

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 12:04 AM, Keith Busch wrote: > Return error if the requested offset starts after the size of the log > being returned. Also, move the check for earlier in the function so > we're not doing unnecessary calculations. > > Signed-off-by: Keith Busch > --- > hw/block/nvme.c | 22 ++

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-10-01 Thread Kevin Wolf
Am 30.09.2020 um 19:20 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > Am 30.09.2020 um 15:14 hat Markus Armbruster geschrieben: > > > Kevin Wolf writes: > > > > > > > Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben: > > > >> Kevin Wolf writes: > > >

Re: [PATCH v2] build-sys: fix git version from -version

2020-10-01 Thread Laszlo Ersek
On 09/29/20 16:36, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Typo introduced with the script. > > Fixes: 2c273f32d3 ("meson: generate qemu-version.h") > Signed-off-by: Marc-André Lureau > --- > scripts/qemu-version.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code

2020-10-01 Thread Philippe Mathieu-Daudé
+Igor On 10/1/20 7:04 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> In commit f68c01470b we restricted the query-uuid command to >> machine code, but it is incorrect, as it is also used by the >> tools. Therefore move this command again, but to block.json, >> which is share

Re: [PATCH v3 11/11] qapi: Restrict code generated for user-mode

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 7:09 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> A lot of QAPI generated code is never used by user-mode. >> >> Split out qapi_system_modules and qapi_system_or_tools_modules >> from the qapi_all_modules array. We now have 3 groups: >> - always used >> - use by s

hxtool-conv.pl doesn't used anymore, may us remove it now

2020-10-01 Thread Yonggang Luo
-- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] block/nvme: Add driver statistics for access alignment and hw errors

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 11:59 AM, Stefan Hajnoczi wrote: > On Wed, Sep 30, 2020 at 03:36:17PM +0200, Philippe Mathieu-Daudé wrote: >> "return": [ >> { >> "device": "", >> "node-name": "drive0", >> "stats": { >> "flush_total_time_ns": 6026948, >>

Re: [PATCH v2 1/4] keyval: Parse help options

2020-10-01 Thread Markus Armbruster
Kevin Wolf writes: > Am 30.09.2020 um 15:35 hat Eric Blake geschrieben: >> On 9/30/20 7:45 AM, Kevin Wolf wrote: >> > This adds a new parameter 'help' to keyval_parse() that enables parsing >> > of help options. If NULL is passed, the function behaves the same as >> > before. But if a bool pointe

Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread Markus Armbruster
We deprecated "?" more than eight years ago. We didn't have a deprecation process back then, but we did purge "?" from the documentation and from help texts. Can we finally drop it? I'm asking because there is a patch on the list that bypasses is_help_option() to not add deprecated "?" to a new

Re: About 'qemu-security' mailing list

2020-10-01 Thread P J P
Hello Darren, +-- On Wed, 30 Sep 2020, Darren Kenny wrote --+ | While that is true, some aliases have managed to do something here by having | a single key for the alias, and behind the scenes that re-encrypts the | e-mail for each member of that alias (trying to avoid the 'list' term a | lit

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread Thomas Huth
On 01/10/2020 12.35, Markus Armbruster wrote: > We deprecated "?" more than eight years ago. We didn't have a > deprecation process back then, but we did purge "?" from the > documentation and from help texts. Can we finally drop it? It's not mentioned in docs/system/deprecated.rst yet, so it is

Looking for exciting projects

2020-10-01 Thread Ani Sinha
Hey guys, I am looking for some exciting work around PCI/PCIE for either i440fx or q35 machines. Any pointers would be much appreciated. Ani

Re: [PATCH v6 05/14] qapi: introduce replay.json for record/replay-related stuff

2020-10-01 Thread Alex Bennée
Pavel Dovgalyuk writes: > From: Pavel Dovgalyuk > > This patch adds replay.json file. It will be > used for adding record/replay-related data structures and commands. > > Signed-off-by: Pavel Dovgalyuk > Reviewed-by: Markus Armbruster > Reviewed-by: Alex Bennée Just to note there are now s

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 11:35, Markus Armbruster wrote: > > We deprecated "?" more than eight years ago. We didn't have a > deprecation process back then, but we did purge "?" from the > documentation and from help texts. Can we finally drop it? Is it really that terrible a burden to support havi

Re: [PATCH v2] xen-bus: reduce scope of backend watch

2020-10-01 Thread Anthony PERARD via
On Thu, Oct 01, 2020 at 09:15:00AM +0100, Paul Durrant wrote: > From: Paul Durrant > > Currently a single watch on /local/domain/X/backend is registered by each > QEMU process running in service domain X (where X is usually 0). The purpose > of this watch is to ensure that QEMU is notified when t

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Niklas Cassel
On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detecti

Re: [PULL 00/17] Block patches

2020-10-01 Thread Peter Maydell
On Wed, 30 Sep 2020 at 11:13, Stefan Hajnoczi wrote: > > The following changes since commit b150cb8f67bf491a49a1cb1c7da151eeacbdbcc9: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-09-29 13:18:54 +0100) > > are available in the Git repository at: > > htt

Re: [PATCH v2 1/4] keyval: Parse help options

2020-10-01 Thread Kevin Wolf
Am 01.10.2020 um 12:34 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 30.09.2020 um 15:35 hat Eric Blake geschrieben: > >> On 9/30/20 7:45 AM, Kevin Wolf wrote: > >> > This adds a new parameter 'help' to keyval_parse() that enables parsing > >> > of help options. If NULL is pass

Re: About 'qemu-security' mailing list

2020-10-01 Thread Darren Kenny
On Thursday, 2020-10-01 at 16:05:58 +0530, P J P wrote: > Hello Darren, > > +-- On Wed, 30 Sep 2020, Darren Kenny wrote --+ > | While that is true, some aliases have managed to do something here by > having > | a single key for the alias, and behind the scenes that re-encrypts the > | e-mail f

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-10-01 Thread Christian Schoenebeck
On Montag, 28. September 2020 18:38:00 CEST Paolo Bonzini wrote: > On 28/09/20 15:35, Christian Schoenebeck wrote: > >> As I said, the first two patches make total sense. They would be useful > >> for testing both packed and split virtqueues, for example. However, I > >> think the (useful) featur

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-10-01 Thread Lee Yarwood
> @Christian Yes we can test this in OpenStack CI with PPAs if you > could provide Bionic based builds. I'm not sure what I was thinking here but we *can* use Focal based builds of QEMU in CI now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-10-01 Thread Michael S. Tsirkin
On Thu, Oct 01, 2020 at 10:55:35AM +0200, Julia Suvorova wrote: > On Thu, Sep 24, 2020 at 11:20 AM Michael S. Tsirkin wrote: > > > > On Thu, Sep 24, 2020 at 09:00:06AM +0200, Julia Suvorova wrote: > > > The patch set consists of two parts: > > > patches 1-4: introduce new feature > > >

[PATCH] cirrus.yml: Avoid base-devel group to speed up the build

2020-10-01 Thread Thomas Huth
The base-devel group pulls in a lot of stuff like various automake versions that we do not really need for building QEMU. Let's directly specify our requirements instead, then the job has to download way less files and finishes more quickly (at least 5 minutes for me). Signed-off-by: Thomas Huth

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-10-01 Thread Paolo Bonzini
On 01/10/20 13:34, Christian Schoenebeck wrote: > Paolo, I'm back at square one after changing to single-device model as you > suggested: > > GTest: run: /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/pci- > device/pci-device-tests/nop > Run QEMU with: '-M pc -device virtio-9p-pci' >

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-10-01 Thread Christian Schoenebeck
On Donnerstag, 1. Oktober 2020 13:56:42 CEST Paolo Bonzini wrote: > On 01/10/20 13:34, Christian Schoenebeck wrote: > > Paolo, I'm back at square one after changing to single-device model as you > > suggested: > > > > GTest: run: > > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-9p-pci/pci-

Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code

2020-10-01 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Igor > > On 10/1/20 7:04 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> In commit f68c01470b we restricted the query-uuid command to >>> machine code, but it is incorrect, as it is also used by the >>> tools. Therefore move this command

[PATCH] elfload: use g_new instead of malloc

2020-10-01 Thread Elena Afanasova
Signed-off-by: Elena Afanasova --- bsd-user/elfload.c | 92 +++--- 1 file changed, 30 insertions(+), 62 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 32378af7b2..e10ca54eb7 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/elfload.c

Re: [PATCH v1 01/20] softfloat: Implement float128_(min|minnum|minnummag|max|maxnum|maxnummag)

2020-10-01 Thread David Hildenbrand
On 30.09.20 18:10, Alex Bennée wrote: > > David Hildenbrand writes: > >> Implementation inspired by minmax_floats(). Unfortuantely, we don't have >> any tests we can simply adjust/unlock. >> >> Cc: Aurelien Jarno >> Cc: Peter Maydell >> Cc: "Alex Bennée" >> Signed-off-by: David Hildenbrand >

Re: [PATCH v2 0/2] vhost: Skip access checks on GIOVAs

2020-10-01 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 06:30:20PM +0200, Greg Kurz wrote: > This series addresses some misuse around vring addresses provided by > userspace when using an IOTLB device. The misuse cause failures of > the VHOST_SET_VRING_ADDR ioctl on POWER, which in turn causes QEMU > to crash at migration time. >

Re: [PATCH v6 03/14] qcow2: introduce icount field for snapshots

2020-10-01 Thread Alex Bennée
Pavel Dovgalyuk writes: > From: Pavel Dovgalyuk > > This patch introduces the icount field for saving within the snapshot. > It is required for navigation between the snapshots in record/replay mode. > > Signed-off-by: Pavel Dovgalyuk > Acked-by: Kevin Wolf > --- > block/qcow2-snapshot.c |

Re: [PATCH v3 00/11] user-mode: Prune build dependencies (part 3)

2020-10-01 Thread Philippe Mathieu-Daudé
On 9/30/20 7:27 PM, Eduardo Habkost wrote: > On Wed, Sep 30, 2020 at 07:24:24PM +0200, Paolo Bonzini wrote: >> On 30/09/20 19:15, Eduardo Habkost wrote: >>> On Wed, Sep 30, 2020 at 06:49:38PM +0200, Philippe Mathieu-Daudé wrote: This is the third part of a series reducing user-mode depend

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-10-01 Thread Ani Sinha
On Thu, Oct 1, 2020 at 17:10 Michael S. Tsirkin wrote: > On Thu, Oct 01, 2020 at 10:55:35AM +0200, Julia Suvorova wrote: > > On Thu, Sep 24, 2020 at 11:20 AM Michael S. Tsirkin > wrote: > > > > > > On Thu, Sep 24, 2020 at 09:00:06AM +0200, Julia Suvorova wrote: > > > > The patch set consists of

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread Eric Blake
On 10/1/20 5:35 AM, Markus Armbruster wrote: > We deprecated "?" more than eight years ago. We didn't have a > deprecation process back then, but we did purge "?" from the > documentation and from help texts. Can we finally drop it? > > I'm asking because there is a patch on the list that bypass

[PATCH] block/export: fix QAPI doc indentation style violation

2020-10-01 Thread Stefan Hajnoczi
Since commit a69a6d4b4d4fae2e3d2506241e22a78ff1732283 ("scripts/qapi/parser.py: improve doc comment indent handling") the QAPI generator emits an error when unindented text follows "Returns:". Fix block-export.json by moving the comment to make the QAPI generator happy. Signed-off-by: Stefan Hajn

Re: [PATCH] MAINTAINERS: Ignore bios-tables-test in the qtest section

2020-10-01 Thread Laszlo Ersek
On 10/01/20 06:27, Thomas Huth wrote: > I'm very often getting CC: on rather large patch series that > modify the ACPI stuff of either ARM or x86, just because the > bios-table-test is often slightly involved here. I can't say > much about ACPI, and the bios-table-test is already covered > by the A

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread Kevin Wolf
Am 01.10.2020 um 15:06 hat Eric Blake geschrieben: > On 10/1/20 5:35 AM, Markus Armbruster wrote: > > We deprecated "?" more than eight years ago. We didn't have a > > deprecation process back then, but we did purge "?" from the > > documentation and from help texts. Can we finally drop it? > >

Re: [PATCH v1 01/20] softfloat: Implement float128_(min|minnum|minnummag|max|maxnum|maxnummag)

2020-10-01 Thread Alex Bennée
David Hildenbrand writes: > On 30.09.20 18:10, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Implementation inspired by minmax_floats(). Unfortuantely, we don't have >>> any tests we can simply adjust/unlock. >>> >>> Cc: Aurelien Jarno >>> Cc: Peter Maydell >>> Cc: "Alex Bennée

Re: [PATCH] target/arm: Fix sve ldr/str

2020-10-01 Thread Peter Maydell
On Wed, 16 Sep 2020 at 02:41, Richard Henderson wrote: > > The mte update missed a bit when producing clean addresses. > > Fixes: b2aa8879b88 > Signed-off-by: Richard Henderson > --- Applied to target-arm.next, thanks. -- PMM

Re: [PATCH] target/arm: Fix SVE splice

2020-10-01 Thread Peter Maydell
On Fri, 18 Sep 2020 at 01:05, Richard Henderson wrote: > > While converting to gen_gvec_ool_zzzp, we lost passing > a->esz as the data argument to the function. > > Fixes: 36cbb7a8e71 > Cc: qemu-sta...@nongnu.org > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 2 +- > 1 f

Re: [PATCH 0/3] hw/arm/raspi: Remove ignore_memory_transaction_failures on the raspi2

2020-10-01 Thread Peter Maydell
On Mon, 21 Sep 2020 at 04:47, Philippe Mathieu-Daudé wrote: > > Patch 1 and 3 are review, patch 2 is new and trivial. > > Philippe Mathieu-Daudé (3): > hw/arm/raspi: Define various blocks base addresses > hw/arm/bcm2835: Add more unimplemented peripherals > hw/arm/raspi: Remove ignore_memory

Re: [PATCH v4 0/8] hw/arm/raspi: QOM housekeeping to be able to add more machines

2020-10-01 Thread Peter Maydell
On Thu, 24 Sep 2020 at 12:18, Philippe Mathieu-Daudé wrote: > > Machine-specific patches extracted from v2 [*] and rebased. > > Series now fully reviewed. > > Since v3: > - Fixed typos (Luc) > - Added Luc tags > > [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg680135.html > > Based-on:

Re: [PATCH] block/export: fix QAPI doc indentation style violation

2020-10-01 Thread Kevin Wolf
Am 01.10.2020 um 15:14 hat Stefan Hajnoczi geschrieben: > Since commit a69a6d4b4d4fae2e3d2506241e22a78ff1732283 > ("scripts/qapi/parser.py: improve doc comment indent handling") the QAPI > generator emits an error when unindented text follows "Returns:". > > Fix block-export.json by moving the com

Re: [PATCH] block/export: fix QAPI doc indentation style violation

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 3:14 PM, Stefan Hajnoczi wrote: > Since commit a69a6d4b4d4fae2e3d2506241e22a78ff1732283 > ("scripts/qapi/parser.py: improve doc comment indent handling") the QAPI > generator emits an error when unindented text follows "Returns:". > > Fix block-export.json by moving the comment to make

Re: [PATCH] block/export: fix QAPI doc indentation style violation

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 14:18, Stefan Hajnoczi wrote: > > Since commit a69a6d4b4d4fae2e3d2506241e22a78ff1732283 > ("scripts/qapi/parser.py: improve doc comment indent handling") the QAPI > generator emits an error when unindented text follows "Returns:". > -# @addr: Address on which to listen. > -#

Re: io_uring possibly the culprit for qemu hang (linux-5.4.y)

2020-10-01 Thread Jack Wang
Stefano Garzarella 于2020年10月1日周四 上午10:59写道: > > +Cc: qemu-devel@nongnu.org > > Hi, > > On Thu, Oct 01, 2020 at 01:26:51AM +0900, Ju Hyung Park wrote: > > Hi everyone. > > > > I have recently switched to a setup running QEMU 5.0(which supports > > io_uring) for a Windows 10 guest on Linux v5.4.63.

Re: [PULL 00/17] Block patches

2020-10-01 Thread Vladimir Sementsov-Ogievskiy
01.10.2020 14:23, Peter Maydell wrote: On Wed, 30 Sep 2020 at 11:13, Stefan Hajnoczi wrote: The following changes since commit b150cb8f67bf491a49a1cb1c7da151eeacbdbcc9: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-09-29 13:18:54 +0100) are available in

Re: About 'qemu-security' mailing list

2020-10-01 Thread Konrad Rzeszutek Wilk
. monster snip.. > > Maybe we could start with a moderated list and improvise as we go forward? > > I really think that encryption of the details of a vulnerability is > important, if somehow it gets intercepted - which is not that difficult > with e-mail - then there is the potential for a malici

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-10-01 Thread Lee Yarwood
While testing >=v5.0.0 on Fedora 32 I've stumbled across the following change in QEMU: https://github.com/qemu/qemu/commit/cce8944cc9efab47d4bf29cfffb3470371c3541b The change suggests that previously parallel requests to detach a PCIe device (such as virtio-blk) from QEMU would result in the orig

Re: Use of "?" for help has been deprecated for 8 years, can we drop it?

2020-10-01 Thread BALATON Zoltan via
On Thu, 1 Oct 2020, Eric Blake wrote: On 10/1/20 5:35 AM, Markus Armbruster wrote: We deprecated "?" more than eight years ago. We didn't have a deprecation process back then, but we did purge "?" from the documentation and from help texts. Can we finally drop it? I'm asking because there is

Re: qcow2 merge_cow() question

2020-10-01 Thread Vladimir Sementsov-Ogievskiy
29.09.2020 18:02, Alberto Garcia wrote: On Fri 21 Aug 2020 03:42:29 PM CEST, Vladimir Sementsov-Ogievskiy wrote: What are these ifs for? /* The data (middle) region must be immediately after the * start region */ if (l2meta_cow_start(m) + m->cow_start.nb_

Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices

2020-10-01 Thread Paolo Bonzini
On 01/10/20 14:15, Christian Schoenebeck wrote: > On Donnerstag, 1. Oktober 2020 13:56:42 CEST Paolo Bonzini wrote: >> On 01/10/20 13:34, Christian Schoenebeck wrote: >>> Paolo, I'm back at square one after changing to single-device model as you >>> suggested: >>> >>> GTest: run: >>> /x86_64/pc/i44

Re: [PATCH qemu 1/4] drive-mirror: add support for sync=bitmap mode=never

2020-10-01 Thread Max Reitz
On 22.09.20 11:14, Fabian Grünbichler wrote: > From: John Snow > > This patch adds support for the "BITMAP" sync mode to drive-mirror and > blockdev-mirror. It adds support only for the BitmapSyncMode "never," > because it's the simplest mode. > > This mode simply uses a user-provided bitmap as

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-10-01 Thread Lee Yarwood
Here's an example from QMP_requests_and_replies_from_libvirtd.log.gz attached earlier to the bug by Kashyap. We can see two device_del commands prior to only seeing a single event emitted by QEMU: http://paste.openstack.org/show/798607/ # zgrep 0x7f768806eaf0 QMP_requests_and_replies_from_libvirt

Re: [PATCH v4 04/46] qapi: modify docstrings to be sphinx-compatible

2020-10-01 Thread John Snow
On 10/1/20 4:54 AM, Markus Armbruster wrote: John Snow writes: On 9/30/20 4:47 AM, Markus Armbruster wrote: Sadly, the fact that start_if() and end_if() are functions isn't immediately obvious anymore. I've seen :func:`start_if` elsewhere. Is this something we should or want to use? Looks

scripts/gdb: issues when loading modules after lx-symbols

2020-10-01 Thread Stefano Garzarella
Hi, I had some issues with gdb scripts and kernel modules in Linux 5.9-rc7. If the modules are already loaded, and I do 'lx-symbols', all work fine. But, if I load a kernel module after 'lx-symbols', I had this issue: [ 5093.393940] invalid opcode: [#1] SMP PTI [ 5093.395134] CPU: 0 PID: 576

Re: [PULL v8 00/86] Misc QEMU patches for 2020-09-24

2020-10-01 Thread Peter Maydell
On Wed, 30 Sep 2020 at 21:04, Paolo Bonzini wrote: > > The following changes since commit cbba3dc6ea3fc9aa66e9f9eb41051536e3ad7cd0: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-09-30 11:40:38 +0100) > > are available in the Git repository at: > > https

[PATCH v4 1/3] target/i386/cpu: Trivial code movement

2020-10-01 Thread Philippe Mathieu-Daudé
Trivial code movement to reduce #ifdef'ry in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 3ffd877dd5..2eec53ca22 100644 --- a/ta

[PATCH v4 0/3] target/i386: Restrict 'feature-words' property to x86 machines

2020-10-01 Thread Philippe Mathieu-Daudé
This series restrict the 'feature-words' property to the x86 architecture (other archs don't have it), and to system-mode (user-mode doesn't use it). Extracted from "user-mode: Prune build dependencies (part 3)" v3: https://www.mail-archive.com/qemu-devel@nongnu.org/msg746423.html Philippe Mathie

[PATCH v4 2/3] target/i386/cpu: Restrict some of feature-words uses to system-mode

2020-10-01 Thread Philippe Mathieu-Daudé
The feature-words properties are not used in user-mode emulation, restrict it to system-mode. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2eec53ca22..9f72342506

[PATCH v4 3/3] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-10-01 Thread Philippe Mathieu-Daudé
Only qemu-system-FOO and qemu-storage-daemon provide QMP monitors, therefore such declarations and definitions are irrelevant for user-mode emulation. Restricting the x86-specific commands to machine-target.json pulls less QAPI-generated code into user-mode. Acked-by: Richard Henderson Signed-of

Re: [PATCH v4 2/3] target/i386/cpu: Restrict some of feature-words uses to system-mode

2020-10-01 Thread Philippe Mathieu-Daudé
On 10/1/20 4:41 PM, Philippe Mathieu-Daudé wrote: > The feature-words properties are not used in user-mode emulation, > restrict it to system-mode. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/cpu.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a

[PATCH 0/2] block/export: add vhost-user-blk multi-queue support

2020-10-01 Thread Stefan Hajnoczi
The vhost-user-blk server currently only supports 1 virtqueue. Add a 'num-queues' option for multi-queue. Both --device vhost-user-blk-pci,num-queues= and --export vhost-user-blk,num-queues= need to be set in order for multi-queue to work (otherwise it will fall back to 1 virtqueue). Based-on: 202

[PULL 02/18] target/arm: Move id_pfr0, id_pfr1 into ARMISARegisters

2020-10-01 Thread Peter Maydell
Move the id_pfr0 and id_pfr1 fields into the ARMISARegisters sub-struct. We're going to want id_pfr1 for an isar_features check, and moving both at the same time avoids an odd inconsistency. Changes other than the ones to cpu.h and kvm64.c made automatically with: perl -p -i -e 's/cpu->id_pfr/cp

[PULL 05/18] target/arm: Make isar_feature_aa32_fp16_arith() handle M-profile

2020-10-01 Thread Peter Maydell
The M-profile definition of the MVFR1 ID register differs slightly from the A-profile one, and in particular the check for "does the CPU support fp16 arithmetic" is not the same. We don't currently implement any M-profile CPUs with fp16 arithmetic, so this is not yet a visible bug, but correcting

[PATCH 1/2] block/export: add vhost-user-blk multi-queue support

2020-10-01 Thread Stefan Hajnoczi
Allow the number of queues to be configured using --export vhost-user-blk,num-queues=N. This setting should match the QEMU --device vhost-user-blk-pci,num-queues=N setting but QEMU vhost-user-blk.c lowers its own value if the vhost-user-blk backend offers fewer queues than QEMU. The vhost-user-blk

[PATCH 2/2] tests/qtest: add multi-queue test case to vhost-user-blk-test

2020-10-01 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 81 +-- 1 file changed, 76 insertions(+), 5 deletions(-) diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c index 42e4cfde82..b9f35191df 100644 --- a/tests/qtest/vh

[PULL 06/18] target/arm: Fix sve ldr/str

2020-10-01 Thread Peter Maydell
From: Richard Henderson The mte update missed a bit when producing clean addresses. Fixes: b2aa8879b88 Signed-off-by: Richard Henderson Message-id: 20200916014102.2446323-1-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 4

[PULL 08/18] hw/arm/raspi: Define various blocks base addresses

2020-10-01 Thread Peter Maydell
From: Philippe Mathieu-Daudé The Raspberry firmware is closed-source. While running it, it accesses various I/O registers. Logging these accesses as UNIMP (unimplemented) help to understand what the firmware is doing (ideally we want it able to boot a Linux kernel). Document various blocks we mi

  1   2   3   4   >