On 30/09/2020 00.43, Philippe Mathieu-Daudé wrote:
> Since the support of SYS_READC in commit 8de702cb67 the
> semihosting code is strongly depedent of the TCG accelerator
> via a call to cpu_loop_exit().
>
> Ideally we would only build semihosting support when TCG
> is available, but unfortunatel
On Wed, Sep 30, 2020 at 1:08 AM Alistair Francis wrote:
>
> On Mon, Sep 28, 2020 at 2:18 AM Green Wan wrote:
> >
> > Hi Alistair,
> >
> > Thanks for the review. See the reply inline below.
> >
> >
> > On Sat, Sep 26, 2020 at 5:52 AM Alistair Francis
> > wrote:
> > >
> > > On Tue, Sep 1, 2020 at
Marc-André Lureau writes:
> Hi
>
> On Tue, Sep 29, 2020 at 3:01 PM Paolo Bonzini wrote:
[...]
>> Marc-André, we are totally in agreement about that! The problem is that
>> you have already decided what the solution looks like, and that's what
>> I'm not sure about because your solution also imp
On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:
> On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin wrote:
> >
> > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:
> > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin
> > > wrote:
> > > >
> > > > On Tue, Sep 29, 2020 at
On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin wrote:
> On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:
>
> > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin
> wrote:
>
> > >
>
> > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:
>
> > > > On Tue, Sep 29, 2020 at 4:
On Mon, 28 Sep 2020 19:15:23 +0200
Philippe Mathieu-Daudé wrote:
> All the MIPS cores emulated by QEMU provides the Coproc#0
> 'Count' register which can be used as a free running timer.
>
> Since it's introduction in 2005 this timer uses a fixed
> frequency of 100 MHz (for a CPU freq of 200 MHz
On Mon, 28 Sep 2020 19:15:24 +0200
Philippe Mathieu-Daudé wrote:
> Let CPUState have a clock source (named 'clk') and CPUClass
> have a clock_update() callback. The clock can be optionally
> set Using qdev_connect_clock_in() from the Clock API.
> If the clock changes, the optional clock_update()
On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:
>
>
> On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin wrote:
>
> On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:
>
> > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin
> wrote:
>
> > >
>
> > > On
On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote:
> On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:
>
> >
>
> >
>
> > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin
> wrote:
>
> >
>
> > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:
>
> >
>
> > > On Tue
Hi
On Wed, Sep 30, 2020 at 11:34 AM Markus Armbruster
wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Tue, Sep 29, 2020 at 3:01 PM Paolo Bonzini
> wrote:
> [...]
> >> Marc-André, we are totally in agreement about that! The problem is that
> >> you have already decided what the solution
On Wed, 30 Sep 2020 00:43:43 +0200
Philippe Mathieu-Daudé wrote:
> Cover from Samuel Ortiz from (part 1) [1]:
>
> This patchset allows for building and running ARM targets with TCG
> disabled. [...]
>
> The rationale behind this work comes from the NEMU project where we're
> trying to o
On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote:
> KVM requires a cpu based on (at least) the ARMv7 architecture.
>
> Only enable the following ARMv4 CPUs when TCG is available:
>
> - StrongARM (SA1100/1110)
> - OMAP1510 (TI925T)
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/K
On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote:
>
>
> On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote:
>
> On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:
>
> >
>
> >
>
> > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin
> wrote:
>
>
On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin wrote:
>
> On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote:
> >
> >
> > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote:
> >
> > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:
> >
> > >
> >
> > >
> >
> >
On Tue, Sep 29, 2020 at 07:38:24PM +0100, Stefan Hajnoczi wrote:
> On Tue, Sep 29, 2020 at 06:04:34AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Sep 29, 2020 at 09:57:51AM +0100, Stefan Hajnoczi wrote:
> > > On Tue, Sep 29, 2020 at 02:09:55AM -0400, Michael S. Tsirkin wrote:
> > > > On Mon, Sep 2
On Sep 28 11:35, Dmitry Fomichev wrote:
> From: Niklas Cassel
>
> Define the structures and constants required to implement
> Namespace Types support.
>
> Signed-off-by: Niklas Cassel
> Signed-off-by: Dmitry Fomichev
> ---
> hw/block/nvme-ns.h | 2 ++
> hw/block/nvme.c | 2 +-
> incl
On Sep 28 11:35, Dmitry Fomichev wrote:
> From: Niklas Cassel
>
> Namespace Types introduce a new command set, "I/O Command Sets",
> that allows the host to retrieve the command sets associated with
> a namespace. Introduce support for the command set and enable
> detection for the NVM Command Se
Trying to connect using
novnc latest/stable:1.2.0 2020-07-31 (6) 18MB -
as-is failing to connect
Keeping VNC up and refreshing qemu.
Updating to the new qemu from focal proposed (by now resolved the archive
publishing issues we had before this morning).
Get:67 http://archive.ubuntu.c
On 24/09/2020 16:00, Laurent Vivier wrote:
> Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit :
>> On 9/16/20 4:50 AM, David Gibson wrote:
>>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote:
As the 'io_base' argument of m48t59_init() is unused (set to 0),
rem
On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote:
> As the 'io_base' argument of m48t59_init() is unused (set to 0),
> remove it to simplify.
> To create a device on the ISA bus, m48t59_init_isa() is the
> preferred function to use.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/
The following changes since commit f142e4ede72853aaa7d306bc79b099caed45769b:
tests/acpi: drop unnecessary files (2020-09-29 07:10:37 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to 42803552319
From: Ani Sinha
This change adds a unit test to exercise the case when hotplug is disabled
both for pci root bus and the pci bridges by passing the following two
switches to qemu:
-global PIIX4_PM.acpi-root-pci-hotplug=off
-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
bios-table
From: Ani Sinha
This change adds a new DSDT golden master table blob to test disabling
hotplug on both pci root bus and pci bridges. Also reverts the change
in file bios-tables-test-allowed-diff.h to make sure its now empty so that
future modifications to acpi tables can be caught.
The following
Hi Drew,
On 9/16/20 11:26 AM, Andrew Jones wrote:
> Move the KVM PMU setup part of fdt_add_pmu_nodes() to
> virt_cpu_post_init(), which is a more appropriate location. Now
> fdt_add_pmu_nodes() is also named more appropriately, because it
> no longer does anything but fdt node creation.
>
> No fu
Hi Drew,
On 9/16/20 11:26 AM, Andrew Jones wrote:
> ---
> linux-headers/linux/kvm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> index a28c3667370b..924672cca1f1 100644
> --- a/linux-headers/linux/kvm.h
> +++ b/linux-headers/lin
I understand that QSD is at an early stage of development and I'm sure
you have plans to fix these things. Nevertheless here are my comments
after trying to add an interop test with libnbd.
(1) Documentation! (Or complete lack of it ...) I had to ask Kevin
how to construct the command line beca
On Tue, Sep 29, 2020 at 10:38:30AM +0100, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
> > +Alex/Daniel
> >
> > On 9/28/20 10:33 PM, Willian Rampazzo wrote:
> >> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé
> >> wrote:
> >>>
> >>> Add a test for the mipssim machine, based
John Snow writes:
> I did not say "sphinx beautiful", just "sphinx compatible". They will
> not throw errors when parsed and interpreted as ReST.
"Bang on the keyboard until Sphinx doesn't throw errors anymore" might
be good enough for a certain kind of mathematician, but a constructive
solution
On Wed, Sep 30, 2020 at 09:40:59AM +0100, Richard W.M. Jones wrote:
> I understand that QSD is at an early stage of development and I'm sure
> you have plans to fix these things. Nevertheless here are my comments
> after trying to add an interop test with libnbd.
>
> (1) Documentation! (Or compl
On Tue, Sep 29, 2020 at 12:36:10PM -0500, Eric Blake wrote:
> On 9/29/20 7:55 AM, Stefan Hajnoczi wrote:
> > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd.
> > They are not used by other programs and are not otherwise needed in
> > libblock.
> >
> > Undo the recent move of b
Hi Drew,
On 9/16/20 11:26 AM, Andrew Jones wrote:
> We add the kvm-steal-time CPU property and implement it for machvirt.
> A tiny bit of refactoring was also done to allow pmu and pvtime to
> use the same vcpu device helper functions.
This needs a rebase. Besides this still looks good to me
Revi
On Wed, Sep 30, 2020 at 09:49:00AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 30, 2020 at 09:40:59AM +0100, Richard W.M. Jones wrote:
> > I understand that QSD is at an early stage of development and I'm sure
> > you have plans to fix these things. Nevertheless here are my comments
> > after
Hi
On Tue, Sep 29, 2020 at 10:23 PM Paolo Bonzini wrote:
> On 29/09/20 19:55, Marc-André Lureau wrote:
> > My understanding of what you propose is:
> > - ForeignConvert::with_foreign
> > - FromForeign::from_foreign (with implied into_native)
> > And:
> > - ForeignConvert::as_foreign (with the Bo
On Tue, Sep 29, 2020 at 09:44:48PM +0200, Auger Eric wrote:
> Hi Stefan,
>
> On 9/29/20 5:59 PM, Stefan Hajnoczi wrote:
> > On Tue, Sep 29, 2020 at 10:55:50AM +0200, Eric Auger wrote:
> >> diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
> >> index ba0ee6e21c..71145970f3 100644
> >> --- a/ut
On Tue, Sep 29, 2020 at 10:55:48AM +0200, Eric Auger wrote:
> The current IOVA allocator allocates within the [0x1, 1ULL << 39]
> window, without paying attention to the host IOVA reserved regions.
> This prevents NVMe passthtrough from working on ARM as the fixed
> IOVAs rapidly grow up to the
Kevin Wolf writes:
> Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf writes:
>> >>
>> >> > The correct way to set the current monitor for a coroutine handler will
>> >> > be diff
On Wed, Sep 30, 2020 at 1:37 PM Ani Sinha wrote:
> On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin wrote:
>
> >
>
> > On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote:
>
> > >
>
> > >
>
> > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin
> wrote:
>
> > >
>
> > > On Wed, Sep
On Wed, Sep 30, 2020 at 07:28:58AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > Use the new QAPI block exports API instead of defining our own QOM
> > objects.
> >
> > This is a large change because the lifecycle of VuBlockDev needs to
> > follow BlockExportDriver. QOM properti
The I/O hang feature is realized based on a rehandle mechanism.
Each block backend will have a list to store hanging block AIOs,
and a timer to regularly resend these aios. In order to issue
the AIOs again, each block AIOs also need to store its coroutine entry.
Signed-off-by: Jiahui Cen
Signed-o
A VM in the cloud environment may use a virutal disk as the backend storage,
and there are usually filesystems on the virtual block device. When backend
storage is temporarily down, any I/O issued to the virtual block device will
cause an error. For example, an error occurred in ext4 filesystem wou
When resetting virtio-blk, we have to drain all AIOs but do not care about the
results. So it is necessary to disable I/O hang before resetting virtio-blk,
and enable it after resetting.
Signed-off-by: Jiahui Cen
Signed-off-by: Ying Fang
---
hw/block/virtio-blk.c | 8
1 file changed, 8
Daniel P. Berrangé writes:
> On Tue, Sep 29, 2020 at 10:38:30AM +0100, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé writes:
>>
>> > +Alex/Daniel
>> >
>> > On 9/28/20 10:33 PM, Willian Rampazzo wrote:
>> >> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé
>> >> wrote:
>> >>>
>> >>>
When a backend device temporarily does not response, like a network disk down
due to some network faults, any IO to the coresponding virtual block device
in VM would return I/O error. If the hypervisor returns the error to VM, the
filesystem on this block device may not work as usual. And in many s
Sometimes hypervisor management tools like libvirt may need to monitor
I/O hang events. Let's report I/O hang and I/O hang timeout event via qapi.
Signed-off-by: Jiahui Cen
Signed-off-by: Ying Fang
---
block/block-backend.c | 3 +++
qapi/block-core.json | 26 ++
2 file
Sometimes there is no need to rehandle AIOs although I/O hang is enabled. For
example, when deleting a block backend, we have to wait AIO completed by calling
blk_drain(), but not care about the results. So a pause interface of I/O hang
is helpful to bypass the rehandle mechanism.
Signed-off-by: J
Not all errors would be fixed, so it is better to add a rehandle timeout
for I/O hang.
Signed-off-by: Jiahui Cen
Signed-off-by: Ying Fang
---
block/block-backend.c | 99 +-
include/sysemu/block-backend.h | 2 +
2 files changed, 100 insertions(+), 1 dele
Setting a non-zero timeout of I/O hang indicates I/O hang is enabled for the
block backend. And when the block backend is going to be deleted, we should
disable I/O hang.
Signed-off-by: Jiahui Cen
Signed-off-by: Ying Fang
---
block/block-backend.c | 40 +
I found that there are many spelling errors in the comments of qemu/target/cris.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/cris/helper.c| 6 +++---
target/cris/op_helper.c | 2 +-
target/cris/translate.c | 14
I found that there are many spelling errors in the comments of qemu/target/ppc.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/ppc/cpu.h| 6 +++---
target/ppc/excp_helper.c| 6 +++---
target/ppc/f
I/O hang timeout should be different under different situations. So it is
better to provide an option for user to determine I/O hang timeout for
each block device.
Signed-off-by: Jiahui Cen
Signed-off-by: Ying Fang
---
blockdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/
I found that there are many spelling errors in the comments of qemu/target/.
I used spellcheck to check the spelling errors and found some errors in the
folder.
The checkpatch.pl file in the Linux kernel can check spelling errors in patches.
I'm trying to add this function to the checkpatch.pl in
I found that there are many spelling errors in the comments of
qemu/target/riscv.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/riscv/cpu.c | 2 +-
target/riscv/cpu_bits.h | 2 +-
target/riscv/csr.c
I found that there are many spelling errors in the comments of qemu/target/rx.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/rx/op_helper.c | 2 +-
target/rx/translate.c | 2 +-
2 files changed, 2 insertions(+), 2 delet
I found that there are many spelling errors in the comments of qemu/target/arm.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/arm/cpu.h | 2 +-
target/arm/helper.c| 4 ++--
target/arm/m_helper.c |
I found that there are many spelling errors in the comments of
qemu/target/tricore.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/s390x/ioinst.c | 2 +-
target/tricore/csfr.def| 2 +-
target/tricore/translate.
I found that there are many spelling errors in the comments of
qemu/target/s390x.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/s390x/cpu_models.h | 4 ++--
target/s390x/excp_helper.c | 2 +-
target/s390x/fp
I found that there are many spelling errors in the comments of qemu/target/m68k.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/m68k/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
dif
I found that there are many spelling errors in the comments of qemu/target/mips.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/mips/internal.h | 2 +-
target/mips/translate.c | 10 +-
target/
I found that there are many spelling errors in the comments of qemu/target/sh4.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/sh4/cpu.h | 2 +-
target/sh4/op_helper.c | 2 +-
target/sh4/translate.c | 2 +-
3 files
I found that there are many spelling errors in the comments of qemu/target/i386.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/i386/cpu.c | 4 ++--
target/i386/hax-interface.h | 4 ++--
target/i386/hax-windows
I found that there are many spelling errors in the comments of qemu/target/avr.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/avr/helper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target
I found that there are many spelling errors in the comments of
qemu/target/alpha.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/alpha/cpu.h | 4 ++--
target/alpha/translate.c | 2 +-
2 files changed, 3 insertions
I found that there are many spelling errors in the comments of qemu/target.
I used spellcheck to check the spelling errors and found some errors in the
folder.
Signed-off-by: zhaolichang
---
target/openrisc/cpu.h| 2 +-
target/sparc/asi.h | 2 +-
target/unicore32/translate.c |
Previously we can only get a simple string "Triple fault" in qemu
log. Add detailed message for the two reasons to describe why qemu
has to reset the guest.
Signed-off-by: zhenwei pi
---
target/i386/helper.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff -
Introduce memory failure events for hyperviso/guest . Then uplayer
could know when/why/what happened during hitting a hardware memory
failure.
Suggested by Peter Maydell, rename events name&description to make
them architecture-neutral; and suggested by Paolo, add more info to
distinguish a mce is
v2->v3:
Use g_strdup_printf instead of snprintf.
Declear memory failure event as 3 parts: 'recipient', 'action', 'flags'.
Wrapper function emit_guest_memory_failure&emit_hypervisor_memory_failure.
v1->v2:
Suggested by Peter Maydell, rename events to make them
architecture-neutral:
'PC-RAM' -> 'gue
On 9/30/20 7:29 AM, Andrew Jeffery wrote:
>
>
> On Fri, 18 Sep 2020, at 02:33, Cédric Le Goater wrote:
>> On 9/17/20 6:57 PM, Philippe Mathieu-Daudé wrote:
>>> On 9/16/20 7:51 AM, Cédric Le Goater wrote:
On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote:
> ping?
It's reviewed :
Post memory failure event to uplayer to handle hardware memory
corrupted event. Rather than simple QEMU log, QEMU could report more
effective message to uplayer. For example, guest crashes by MCE,
selecting another host server is a better choice.
Signed-off-by: zhenwei pi
---
target/i386/helper.
From: Philippe Mathieu-Daudé
Pages are currently mapped READ/WRITE. To be able to use different
protections, add a new argument to qemu_vfio_pci_map_bar().
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200922083821.578519-2-phi...@redhat.com>
---
include/
The following changes since commit b150cb8f67bf491a49a1cb1c7da151eeacbdbcc9:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2020-09-29 13:18:54 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to
On 9/30/20 11:49 AM, Alex Bennée wrote:
>
> Daniel P. Berrangé writes:
>
>> On Tue, Sep 29, 2020 at 10:38:30AM +0100, Alex Bennée wrote:
>>>
>>> Philippe Mathieu-Daudé writes:
>>>
+Alex/Daniel
On 9/28/20 10:33 PM, Willian Rampazzo wrote:
> On Mon, Sep 28, 2020 at 2:31 PM Phil
From: Philippe Mathieu-Daudé
NVMeRegs only contains NvmeBar. Simplify the code by using NvmeBar
directly.
This triggers a checkpatch.pl error:
ERROR: Use of volatile is usually wrong, please add a comment
#30: FILE: block/nvme.c:691:
+volatile NvmeBar *regs;
This is a false positive
On 9/30/20 9:40 AM, Igor Mammedov wrote:
> On Mon, 28 Sep 2020 19:15:23 +0200
> Philippe Mathieu-Daudé wrote:
>
>> All the MIPS cores emulated by QEMU provides the Coproc#0
>> 'Count' register which can be used as a free running timer.
>>
>> Since it's introduction in 2005 this timer uses a fixed
From: Philippe Mathieu-Daudé
Per the datasheet sections 3.1.13/3.1.14:
"The host should not read the doorbell registers."
As we don't need read access, map the doorbells with write-only
permission. We keep a reference to this mapped address in the
BDRVNVMeState structure.
Signed-off-by: Phili
From: Philippe Mathieu-Daudé
Use self-explicit SCALE_MS definition instead of magic value
(missed in similar commit e4f310fe7f5).
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200922083821.578519-7-phi...@redhat.com>
---
block/nvme.c | 2 +-
1 file change
From: Vladimir Sementsov-Ogievskiy
We have a very frequent pattern of creating a coroutine from a function
with several arguments:
- create a structure to pack parameters
- create _entry function to call original function taking parameters
from struct
- do different magic to handle com
From: Philippe Mathieu-Daudé
We only access the I/O register in nvme_init().
Remove the reference in BDRVNVMeState and reduce its scope.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200922083821.578519-4-phi...@redhat.com>
---
block/nvme.c | 29 +
From: Philippe Mathieu-Daudé
Use the NVMe register definitions from "block/nvme.h" which
ease a bit reviewing the code while matching the datasheet.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200922083821.578519-6-phi...@redhat.com>
---
block/nvme.c |
From: Eric Auger
Introduce the qemu_vfio_find_fixed/temp_iova helpers which
respectively allocate IOVAs from the bottom/top parts of the
usable IOVA range, without picking within host IOVA reserved
windows. The allocation remains basic: if the size is too big
for the remaining of the current usab
From: Stefano Garzarella
When we added io_uring AIO engine, we forgot to update qemu-options.hx,
so qemu(1) man page and qemu help were outdated.
Signed-off-by: Stefano Garzarella
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Julia Suvorova
Reviewed-by: Pankaj Gupta
Message-Id: <20200924151511
From: Vladimir Sementsov-Ogievskiy
We are going to keep coroutine-wrappers code (structure-packing
parameters, BDRV_POLL wrapper functions) in separate auto-generated
files. So, we'll need a header with declaration of original _co_
functions, for those which are static now. As well, we'll need
de
From: Vladimir Sementsov-Ogievskiy
This is the only coroutine wrapper from block.c and block/io.c which
doesn't return a value, so let's convert it to the common behavior, to
simplify moving to generated coroutine wrappers in a further commit.
Also, bdrv_invalidate_cache is a void function, retu
From: Vladimir Sementsov-Ogievskiy
Most of our coroutine wrappers already follow this convention:
We have 'coroutine_fn bdrv_co_()' as
the core function, and a wrapper 'bdrv_()' which does parameter packing and calls bdrv_run_co().
The only outsiders are the bdrv_prwv_co and
bdrv_common_block_s
+-- On Wed, 30 Sep 2020, Igor Mammedov wrote --+
| 'dest' is offset into MemoryRegion, so far I don't see how it could break
| into QEMU stack. Do you have a simple reproducer?
Please see:
-> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Flsi_nullptr1
Thank you.
--
Prasad J Pandit
From: Vladimir Sementsov-Ogievskiy
Like for read/write in a previous commit, drop extra indirection layer,
generate directly bdrv_readv_vmstate() and bdrv_writev_vmstate().
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Stefan H
From: Vladimir Sementsov-Ogievskiy
Use code generation implemented in previous commit to generated
coroutine wrappers in block.c and block/io.c
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Message-Id: <2020092
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of qemu/target.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/open
From: Vladimir Sementsov-Ogievskiy
Now that we are not maintaining boilerplate code for coroutine
wrappers, there is no more sense in keeping the extra indirection layer
of bdrv_prwv(). Let's drop it and instead generate pure bdrv_preadv()
and bdrv_pwritev().
Currently, bdrv_pwritev() and bdrv_
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of qemu/target/rx.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/r
From: Eric Auger
The IOVA allocator currently ignores host reserved regions.
As a result some chosen IOVAs may collide with some of them,
resulting in VFIO MAP_DMA errors later on. This happens on ARM
where the MSI reserved window quickly is encountered:
[0x800, 0x810]. since 5.4 kernel,
On Wed, Sep 30, 2020 at 12:23 PM Philippe Mathieu-Daudé wrote:
>
> On 9/30/20 11:53 AM, zhaolichang wrote:
> > I found that there are many spelling errors in the comments of
> > qemu/target/mips.
> > I used spellcheck to check the spelling errors and found some errors in the
> > folder.
> >
> >
From: Vladimir Sementsov-Ogievskiy
This is the only non-ascii character in the file and it doesn't really
needed here. Let's use normal "'" symbol for consistency with the rest
11 occurrences of "'" in the file.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Signed-off-by:
+arm/ppc/riscv folks
On 9/30/20 9:43 AM, Igor Mammedov wrote:
> On Mon, 28 Sep 2020 19:15:24 +0200
> Philippe Mathieu-Daudé wrote:
>
>> Let CPUState have a clock source (named 'clk') and CPUClass
>> have a clock_update() callback. The clock can be optionally
>> set Using qdev_connect_clock_in()
On Tue, 29 Sep 2020 at 21:19, Markus Armbruster wrote:
>
> The following changes since commit b150cb8f67bf491a49a1cb1c7da151eeacbdbcc9:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2020-09-29 13:18:54 +0100)
>
> are available in the Git repository at:
>
> g
While processing a recent pullreq which updated the dockerfile
dependencies and thus provoked a rebuild, I noticed that we
use the 'apt' command in ways that provoke a warning:
#7 0.789 WARNING: apt does not have a stable CLI interface. Use with
caution in scripts.
The apt(8) manpage says:
SCRIP
On 9/30/20 10:35 AM, Mark Cave-Ayland wrote:
> On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote:
>
>> As the 'io_base' argument of m48t59_init() is unused (set to 0),
>> remove it to simplify.
>> To create a device on the ISA bus, m48t59_init_isa() is the
>> preferred function to use.
>>
>> Signe
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of qemu/target/.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> The checkpatch.pl file in the Linux kernel can check spelling errors in
> patches.
>
On 9/30/20 9:58 AM, Igor Mammedov wrote:
> On Wed, 30 Sep 2020 00:43:43 +0200
> Philippe Mathieu-Daudé wrote:
>
>> Cover from Samuel Ortiz from (part 1) [1]:
>>
>> This patchset allows for building and running ARM targets with TCG
>> disabled. [...]
>>
>> The rationale behind this work come
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of
> qemu/target/sh4.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
> ---
> target/sh4/cpu.h | 2 +-
> target/sh4
On 9/30/20 11:53 AM, zhaolichang wrote:
> I found that there are many spelling errors in the comments of
> qemu/target/avr.
> I used spellcheck to check the spelling errors and found some errors in the
> folder.
>
> Signed-off-by: zhaolichang
> ---
> target/avr/helper.c | 6 +++---
> 1 file ch
1 - 100 of 387 matches
Mail list logo
