Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py

2020-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2020 03:00, Eric Blake wrote: On 9/15/20 3:02 PM, Vladimir Sementsov-Ogievskiy wrote: 15.09.2020 19:44, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating coroutine from function with several arguments:    - create structure to pack parameters    - create _en

[RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-09-24 Thread Julia Suvorova
The patch set consists of two parts: patches 1-4: introduce new feature 'acpi-pci-hotplug-with-bridge-support' on Q35 patches 5-7: make the feature default along with changes in ACPI tables This way maintainers can decide which way to choose without breaking the patch set. With the f

[RFC PATCH v3 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

2020-09-24 Thread Julia Suvorova
All DSDT Q35 tables will be modified because ACPI hot-plug is enabled by default. Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-t

[RFC PATCH v3 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2020-09-24 Thread Julia Suvorova
PCI Express does not allow hot-plug on pcie.0. Check for Q35 in acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the 'acpi-root-pci-hotplug' flag. Signed-off-by: Julia Suvorova --- hw/acpi/pcihp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/pcih

[RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2020-09-24 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h| 4 include/hw/acpi/ich9.h | 2 ++ include/hw/acpi/pcihp.h | 3 ++- hw/acpi/pcihp.c | 8

[RFC PATCH v3 4/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2020-09-24 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm as part of 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 ++ hw/acpi/ich9.c | 67 ++ hw/acpi/pcihp.c

[RFC PATCH v3 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default

2020-09-24 Thread Julia Suvorova
Signed-off-by: Julia Suvorova --- hw/acpi/ich9.c | 2 +- hw/i386/pc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 987f23e388..c67c20de4e 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -425,7 +425,7 @@ void ich9_pm_add_propertie

[RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used

2020-09-24 Thread Julia Suvorova
Instead of changing the hot-plug type in _OSC register, do not initialize the slot capability or set the 'Slot Implemented' flag. This way guest will choose ACPI hot-plug if it is preferred and leave the option to use SHPC with pcie-pci-bridge. Signed-off-by: Julia Suvorova --- hw/i386/acpi-buil

[RFC PATCH v3 7/7] bios-tables-test: Update golden binaries

2020-09-24 Thread Julia Suvorova
Add ACPI hot-plug registers to DSDT Q35 tables. Changes in the tables: +Scope (_SB.PCI0) +{ +OperationRegion (PCST, SystemIO, 0x0CC4, 0x08) +Field (PCST, DWordAcc, NoLock, WriteAsZeros) +{ +PCIU, 32, +PCID, 32 +} + +Operat

Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py

2020-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2020 03:18, Eric Blake wrote: On 9/15/20 11:44 AM, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating coroutine from function with several arguments: +++ b/scripts/block-coroutine-wrapper.py @@ -0,0 +1,187 @@ +#!/usr/bin/env python3 +"""Generate coroutine w

Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py

2020-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2020 04:20, Eric Blake wrote: On 9/23/20 7:00 PM, Eric Blake wrote: Tested-by: Eric Blake There's enough grammar fixes, and the fact that John is working on python cleanups, to make me wonder if we need a v9, or if I should just stage it where it is with any other cleanups as followu

Re: [PATCH v6 00/11] x86: fix cpu hotplug with secure boot

2020-09-24 Thread Igor Mammedov
On Wed, 23 Sep 2020 18:44:50 +0200 Laszlo Ersek wrote: > On 09/23/20 11:46, Igor Mammedov wrote: > > v6: > > - [9/10] Add comment explaining why while_ctx2 restarts from the last > > processed CPU. > > - rebase on top of current master, due to non trivial conflict > > caused by microvm s

Re: [PATCH v3 2/3] hw/smbios: report error if table size is too large

2020-09-24 Thread Laszlo Ersek
On 09/23/20 15:38, Daniel P. Berrangé wrote: > The SMBIOS 2.1 entry point uses a uint16 data type for reporting the > total length of the tables. If the user passes -smbios configuration to > QEMU that causes the table size to exceed this limit then various bad > behaviours result, including > >

Re: [PATCH 1/3] virtio-net: Set mac address to hardware if the peer is vdpa

2020-09-24 Thread Jason Wang
On 2020/9/22 上午11:01, Cindy Lu wrote: On Tue, Sep 22, 2020 at 9:55 AM Jason Wang wrote: On 2020/9/17 下午11:58, Cindy Lu wrote: If the peer's type is vdpa,set the mac address to NIC in virtio_net_device_realize, Also sometime vdpa get an all 0 macaddress from the hardware, this will cause t

Re: [PATCH v3 1/3] hw/smbios: support loading OEM strings values from a file

2020-09-24 Thread Laszlo Ersek
On 09/23/20 15:38, Daniel P. Berrangé wrote: > Some applications want to pass quite large values for the OEM strings > entries. Rather than having huge strings on the command line, it would > be better to load them from a file, as supported with -fw_cfg. > > This introduces the "path" parameter al

Re: [PATCH v8 7/7] block/io: refactor save/load vmstate

2020-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2020 23:10, Eric Blake wrote: On 9/15/20 11:44 AM, Vladimir Sementsov-Ogievskiy wrote: Like for read/write in a previous commit, drop extra indirection layer, generate directly bdrv_readv_vmstate() and bdrv_writev_vmstate(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric B

Re: [PATCH v2 00/11] microvm: add pcie support

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 08:27:23AM +0200, Gerd Hoffmann wrote: > v2: > - move aml generator to gpex and have arm virt + microvm share it. > - add 64bit window. > - add testcase. Reviewed-by: Michael S. Tsirkin which tree is this for? Yours? > Gerd Hoffmann (11): > move MemMapEntry > acp

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-24 Thread Markus Armbruster
Marc-André Lureau writes: [...] > What does this freedom really gives us in exchange? We don't want to commit > to a stable API? It's not rocket science, everybody else does it with > interface version numbers. What makes QEMU/QMP so different? It's not rocket science, and we're so used to it th

Re: [PATCH 1/8] softfloat: Use mulu64 for mul64To128

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > Via host-utils.h, we use a host widening multiply for > 64-bit hosts, and a common subroutine for 32-bit hosts. > > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat-macros.h | 24 > 1 file changed, 4 insertions(

Re: [RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 09:00:09AM +0200, Julia Suvorova wrote: > Instead of changing the hot-plug type in _OSC register, do not > initialize the slot capability or set the 'Slot Implemented' flag. > This way guest will choose ACPI hot-plug if it is preferred and leave > the option to use SHPC with

[PATCH V11 1/8] linux-headers: Update MIPS KVM type defintition

2020-09-24 Thread Huacai Chen
Update MIPS KVM type defintition from Linux 5.9-rc6. Signed-off-by: Huacai Chen --- linux-headers/linux/kvm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a28c366737..36a480fd77 100644 --- a/linux-headers/lin

Re: [PATCH 2/8] softfloat: Use int128.h for some operations

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > Use our Int128, which wraps the compiler's __int128_t, > instead of open-coding left shifts and arithmetic. > We'd need to extend Int128 to have unsigned operations > to replace more than these three. > > Signed-off-by: Richard Henderson > --- > incl

[PATCH V11 0/8] mips: Add Loongson-3 machine support

2020-09-24 Thread Huacai Chen
Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we just define two CPU types: 1, "Loongson-3A100

[PATCH V11 2/8] target/mips: Fix PageMask with variable page size

2020-09-24 Thread Huacai Chen
From: Jiaxun Yang Our current code assumed the target page size is always 4k when handling PageMask and VPN2, however, variable page size was just added to mips target and that's no longer true. Fixes: ee3863b9d414 ("target/mips: Support variable page size") Signed-off-by: Huacai Chen Signed-of

Re: [PATCH 3/8] softfloat: Tidy a * b + inf return

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > No reason to set values in 'a', when we already > have float_class_inf in 'c', and can flip that sign. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fpu/sof

[PATCH V11 3/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1)

2020-09-24 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslq: load 16 bytes to GPR gssq: store 16 bytes from GPR gslqc1: load 16 bytes to FPR gssqc

[PATCH V11 6/8] hw/mips: Implement fw_cfg_arch_key_name()

2020-09-24 Thread Huacai Chen
Implement fw_cfg_arch_key_name(), which returns the name of a mips-specific key. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- hw/mips/fw_cfg.c| 35 +++ hw/mips/fw_cfg.h| 19 +++ hw/mips/m

[PATCH V11 4/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 2)

2020-09-24 Thread Huacai Chen
From: Jiaxun Yang LWC2 & SWC2 have been rewritten by Loongson EXT vendor ASE as "load/store quad word" and "shifted load/store" groups of instructions. This patch add implementation of these instructions: gslwlc1: similar to lwl but RT is FPR instead of GPR gslwrc1: similar to lwr but RT is FPR

[PATCH V11 5/8] target/mips: Add loongson-ext lsdc2 group of instructions

2020-09-24 Thread Huacai Chen
From: Jiaxun Yang LDC2/SDC2 opcodes have been rewritten as "load & store with offset" group of instructions by loongson-ext ASE. This patch add implementation of these instructions: gslbx: load 1 bytes to GPR gslhx: load 2 bytes to GPR gslwx: load 4 bytes to GPR gsldx: load 8 bytes to GPR gslwxc

Re: [RFC PATCH v3 4/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 09:00:10AM +0200, Julia Suvorova wrote: > Add acpi_pcihp to ich9_pm as part of > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > Signed-off-by: Julia Suvorova > --- > hw/i386/acpi-build.h | 1 + > include/hw/acpi/ich9.h | 3 ++ > hw/acpi/ich9.

Re: [PATCH 4/8] softfloat: Add float_cmask and constants

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > Testing more than one class at a time is better done with masks. > This reduces the static branch count. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 31 --- > 1 file changed, 24 insertions(+), 7 deletion

[PATCH V11 7/8] hw/mips: Add Loongson-3 machine support

2020-09-24 Thread Huacai Chen
Add Loongson-3 based machine support, it use liointc as the interrupt controler and use GPEX as the pci controller. Currently it can work with both TCG and KVM. As the machine model is not based on any exiting physical hardware, the name of the machine is "loongson3-virt". It may be superseded in

[PATCH V11 8/8] docs/system: Update MIPS machine documentation

2020-09-24 Thread Huacai Chen
Add Loongson-3A CPU models and Loongson-3 based machine description. Signed-off-by: Huacai Chen --- docs/system/cpu-models-mips.rst.inc | 10 -- docs/system/target-mips.rst | 10 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/docs/system/cpu-models-mip

Re: [PATCH 1/6] spapr: add spapr_machine_using_legacy_numa() helper

2020-09-24 Thread Greg Kurz
On Wed, 23 Sep 2020 16:34:53 -0300 Daniel Henrique Barboza wrote: > The changes to come to NUMA support are all guest visible. In > theory we could just create a new 5_1 class option flag to > avoid the changes to cascade to 5.1 and under. The reality is that > these changes are only relevant if

Re: [PATCH 5/8] softfloat: Inline pick_nan_muladd into its caller

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > Because of FloatParts, there will only ever be one caller. > Inlining allows us to re-use abc_mask for the snan test. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 75 +++-- > 1 file change

Re: [PATCH v9 14/20] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:25AM -0700, elena.ufimts...@oracle.com wrote: > +static void process_bar_read(QIOChannel *ioc, MPQemuMsg *msg, Error **errp) > +{ > +BarAccessMsg *bar_access = &msg->data.bar_access; > +MPQemuMsg ret = { 0 }; > +MPQemuRequest req = { 0 }; > +AddressSpac

Re: [PATCH V11 0/8] mips: Add Loongson-3 machine support

2020-09-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1600932956-11642-1-git-send-email-che...@lemote.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1600932956-11642-1-git-send-email-che...@lemote.com Subject: [PATCH V11 0/8] mip

Re: [PATCH] hw/pci/pci: Fix slot check for plugged devices

2020-09-24 Thread Michael S. Tsirkin
On Wed, Sep 23, 2020 at 05:57:19PM +0200, Julia Suvorova wrote: > On Wed, Sep 23, 2020 at 5:03 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 23, 2020 at 11:26:36AM +0200, Julia Suvorova wrote: > > > If devfn is assigned automatically, 'else' clauses will never be > > > executed. And if it does

Re: [PATCH 6/8] softfloat: Implement float128_muladd

2020-09-24 Thread David Hildenbrand
[...] > > /* > | Packs the sign `zSign', the exponent `zExp', and the significand formed > | by the concatenation of `zSig0' and `zSig1' into a quadruple-precision > @@ -7205,6 +7253,312 @@ float128 float128_mul(float1

Re: [PATCH 0/8] softfloat: Implement float128_muladd

2020-09-24 Thread David Hildenbrand
On 24.09.20 03:24, Richard Henderson wrote: > Plus assorted cleanups, passes tests/fp/fp-test. > I will eventually fill in ppc and s390x assembly bits. > Thanks for looking into this! Would have taken me ages to come up with that :) -- Thanks, David / dhildenb

Re: [PATCH 2/6] spapr_numa: forbid asymmetrical NUMA setups

2020-09-24 Thread Greg Kurz
On Wed, 23 Sep 2020 16:34:54 -0300 Daniel Henrique Barboza wrote: > The pSeries machine does not support asymmetrical NUMA > configurations. This doesn't make much of a different > since we're not using user input for pSeries NUMA setup, > but this will change in the next patches. > > To avoid b

Re: [PATCH 3/6] spapr_numa: translate regular NUMA distance to PAPR distance

2020-09-24 Thread Greg Kurz
On Wed, 23 Sep 2020 16:34:55 -0300 Daniel Henrique Barboza wrote: > QEMU allows the user to set NUMA distances in the command line. > For ACPI architectures like x86, this means that user input is > used to populate the SLIT table, and the guest perceives the > distances as the user chooses to. >

Re: [PATCH v4] introduce vfio-user protocol specification

2020-09-24 Thread Stefan Hajnoczi
On Tue, Sep 15, 2020 at 07:29:17AM -0700, Thanos Makatos wrote: > This patch introduces the vfio-user protocol specification (formerly > known as VFIO-over-socket), which is designed to allow devices to be > emulated outside QEMU, in a separate process. vfio-user reuses the > existing VFIO defines,

Re: [RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used

2020-09-24 Thread Julia Suvorova
On Thu, Sep 24, 2020 at 9:36 AM Michael S. Tsirkin wrote: > > On Thu, Sep 24, 2020 at 09:00:09AM +0200, Julia Suvorova wrote: > > Instead of changing the hot-plug type in _OSC register, do not > > initialize the slot capability or set the 'Slot Implemented' flag. > > This way guest will choose ACP

Re: [PATCH v8 1/7] block: return error-code from bdrv_invalidate_cache

2020-09-24 Thread Philippe Mathieu-Daudé
On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > This is the only coroutine wrapper from block.c and block/io.c which > doesn't return a value, so let's convert it to the common behavior, to > simplify moving to generated coroutine wrappers in a further commit. > > Also, bdrv_invalidate_c

Re: [PATCH v9 15/20] multi-process: Synchronize remote memory

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:26AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Add memory-listener object which is used to keep the view of the RAM > in sync between QEMU and remote process. > A MemoryListener is registered for system-memory AddressSpace. The > listener

Re: [PATCH v8 2/7] block/io: refactor coroutine wrappers

2020-09-24 Thread Philippe Mathieu-Daudé
On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > Most of our coroutine wrappers already follow this convention: > > We have 'coroutine_fn bdrv_co_()' as > the core function, and a wrapper 'bdrv_( list>)' which does parameters packing and call bdrv_run_co(). > > The only outsiders are the

Re: [PATCH v9 16/20] multi-process: create IOHUB object to handle irq

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:27AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD > ioctl to create irqfd to injecting PCI interrupts to the guest. > IOHUB object forwards the irqfd to the remote process. Remote p

Re: [PATCH v8 6/7] block: drop bdrv_prwv

2020-09-24 Thread Philippe Mathieu-Daudé
On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > Now that we are not maintaining boilerplate code for coroutine > wrappers, there is no more sense in keeping the extra indirection layer > of bdrv_prwv(). Let's drop it and instead generate pure bdrv_preadv() > and bdrv_pwritev(). > > Curr

Re: [PATCH v9 17/20] multi-process: Retrieve PCI info from remote process

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:28AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Retrieve PCI configuration info about the remote device and > configure the Proxy PCI object based on the returned information > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Joh

Re: [PATCH v9 19/20] multi-process: add the concept description to docs/devel/qemu-multiprocess

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:30AM -0700, elena.ufimts...@oracle.com wrote: > From: John G Johnson > > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > --- > MAINTAINERS | 1 + > docs/devel/index.rst | 1 + > docs

Re: [PATCH v9 18/20] multi-process: perform device reset in the remote process

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:29AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Perform device reset in the remote process when QEMU performs > device reset. This is required to reset the internal state > (like registers, etc...) of emulated devices > > Signed-off-by: Ele

Re: [PATCH v8 3/7] block: declare some coroutine functions in block/coroutines.h

2020-09-24 Thread Philippe Mathieu-Daudé
On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > We are going to keep coroutine-wrappers code (structure-packing > parameters, BDRV_POLL wrapper functions) in separate auto-generated > files. So, we'll need a header with declaration of original _co_ > functions, for those which are static

Re: [PATCH v9 20/20] multi-process: add configure and usage information

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:31AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > --- > MAINTAINERS| 2 ++ > docs/multi-process.rst | 67 +

Re: [PATCH v9 00/20] Initial support for multi-process Qemu

2020-09-24 Thread Stefan Hajnoczi
On Thu, Aug 27, 2020 at 11:12:11AM -0700, elena.ufimts...@oracle.com wrote: > The v9 has the following changes: > - Communication channel. Qemu side uses blocking call to send > and receive the message from the remote and cannot progress > further until the remote side replies. Enhanced the >

Re: [PATCH v10 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-09-24 Thread Zheng Chuan
On 2020/9/24 3:03, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 9/16/20 1:22 AM, Chuan Zheng wrote: >>> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be >>> called >>> >>> Signed-off-by: Chuan Zheng >>> --- >> >>> +++ b/qapi/migration

Re: [PATCH v2 2/2] vhost-vdpa: add trace-events

2020-09-24 Thread Laurent Vivier
On 22/09/2020 04:09, Jason Wang wrote: > > On 2020/9/21 下午9:04, Laurent Vivier wrote: >> Add trace functionis in vhost-vdpa.c. >> >> All traces from this file can be enabled with '-trace vhost_vdpa*'. >> >> Acked-by: Stefan Hajnoczi >> Signed-off-by: Laurent Vivier >> --- >>   hw/virtio/trace-ev

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-24 Thread Kele Huang
Got it. Thank you very much! I will resend the same v2 patch to v1 thread. On Wed, 23 Sep 2020 at 19:08, Philippe Mathieu-Daudé wrote: > Cc'ing the TCG MIPS maintainers, and also > Cc'ing Richard who made a comment in v1. > > On 9/23/20 11:38 AM, Kele Huang wrote: > > Detect mips store instructi

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-09-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200924070013.165026-1-jus...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH 1/3] pc-bios/s390-ccw: fix off-by-one error

2020-09-24 Thread Marc Hartmayer
This error takes effect when the magic value "zIPL" is located at the end of a block. For example if s2_cur_blk = 0x7fe18000 and the magic value "zIPL" is located at 0x7fe18ffc - 0x7fe18fff. Fixes: ba831b25262a ("s390-ccw: read stage2 boot loader data to find menu") Reviewed-by: Collin Walling Si

[PATCH 2/3] pc-bios/s390-ccw: break loop if a null block number is reached

2020-09-24 Thread Marc Hartmayer
Break the loop if `cur_block_nr` is a null block number because this means that the end of chunk is reached. In this case we will try to boot the default entry. Fixes: ba831b25262a ("s390-ccw: read stage2 boot loader data to find menu") Reviewed-by: Collin Walling Signed-off-by: Marc Hartmayer -

Re: [PATCH 1/1] accel/tcg: Fix computing is_write for mips

2020-09-24 Thread Kele Huang
Sorry for the late reply. We make a new version submit as below. Subject: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips Detect mips store instructions in cpu_signal_handler for all MIPS versions, and set is_write if encountering such store instructions. This fixed the error while

Re: [PATCH v4 0/6] *** Add Multifd support for TLS migration ***

2020-09-24 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > v3 -> v4: > still use MigrationState field and save hostname in > migration_tls_channel_connect > remove MigrationState from MultiFDSendParams > > v2 -> v3: > rebase patches on master > > v1 -> v2: > fix memoryleak of MigrationState

Re: [RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 10:23:13AM +0200, Julia Suvorova wrote: > On Thu, Sep 24, 2020 at 9:36 AM Michael S. Tsirkin wrote: > > > > On Thu, Sep 24, 2020 at 09:00:09AM +0200, Julia Suvorova wrote: > > > Instead of changing the hot-plug type in _OSC register, do not > > > initialize the slot capabil

[PATCH 0/3] pc-bios: s390x: fix corner cases in booting from ECKD

2020-09-24 Thread Marc Hartmayer
The first patch fixes the scan for the string "zIPL" (which is used to detect the start of the boot menu banner) in `find_zipl_boot_menu_banner`. The second patch fixes the bug of not booting the default entry if no zipl boot menu data was found. For everybody's convenience there is a branch: http

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-09-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200924070013.165026-1-jus...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH 3/3] pc-bios/s390-ccw: Update s390-ccw.img bios binary

2020-09-24 Thread Marc Hartmayer
Contains the fixes "pc-bios/s390-ccw: fix off-by-one error" and "pc-bios/s390-ccw: break loop if a null block number is reached". Signed-off-by: Marc Hartmayer --- pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img

[PATCH v4] Add a comment in bios-tables-test.c to clarify the reason behind approach

2020-09-24 Thread Ani Sinha
A comment is added in bios-tables-test.c that explains the reasoning behind the process of updating the ACPI table blobs when new tests are added or old tests are modified or code is committed that affect tests. The explanation would help future contributors follow the correct process when making c

Re: [PATCH v2 2/2] vhost-vdpa: add trace-events

2020-09-24 Thread Jason Wang
On 2020/9/24 下午4:42, Laurent Vivier wrote: On 22/09/2020 04:09, Jason Wang wrote: On 2020/9/21 下午9:04, Laurent Vivier wrote: Add trace functionis in vhost-vdpa.c. All traces from this file can be enabled with '-trace vhost_vdpa*'. Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --

[PATCH] numa: hmat: require parent cache description before the next level one

2020-09-24 Thread Igor Mammedov
Spec[1] defines 0 - 3 level memory side cache, however QEMU CLI allows to specify an intermediate cache level without specifying previous level. Such option(s) silently ignored when building HMAT table, which leads to incomplete cache information. Make sure that previous level exists and error out

Re: [PATCH v2] monitor: Use LOCK_GUARD macros

2020-09-24 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Use the lock guard macros in monitor/misc.c - saves > a lot of unlocks in error paths, and the occasional goto. > > Signed-off-by: Dr. David Alan Gilbert Queued > -- > v2: > The file changed qui

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-09-24 Thread Michael S. Tsirkin
On Thu, Sep 24, 2020 at 09:00:06AM +0200, Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > This way maintainer

Re: [PATCH] virtiofsd: document cache=auto default

2020-09-24 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > From: "Harry G. Coin" > > The virtiofsd --help output documents the cache=auto default value but > the man page does not. Fix this. > > Signed-off-by: Harry G. Coin > Signed-off-by: Stefan Hajnoczi Queued > --- > docs/tools/virtiofsd.rst | 1

[PULL 09/92] target/i386: support KVM_FEATURE_ASYNC_PF_INT

2020-09-24 Thread Paolo Bonzini
From: Vitaly Kuznetsov Linux-5.8 introduced interrupt based mechanism for 'page ready' events delivery and disabled the old, #PF based one (see commit 2635b5c4a0e4 "KVM: x86: interrupt based APF 'page ready' event delivery"). Linux guest switches to using in in 5.9 (see commit b1d405751cd5 "KVM:

[PULL 03/92] ninjatool: rebuild multi-output targets if outputs are missing

2020-09-24 Thread Paolo Bonzini
The "stamp file trick" used to group targets of a single multi-output rule prevents the user from deleting one such target in order to force its rebuild. Doing so will not touch the stamp file, and therefore only the dummy ":" command will be executed. With this patch, ninjatool writes rules that

[PULL 05/92] meson: error out if qemu_suffix starts with /

2020-09-24 Thread Paolo Bonzini
From: Marc-André Lureau Since the variable is used for path concatenation, the result would ignore the prefix directory altogether. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build

[PULL 02/92] meson: clean up build_by_default

2020-09-24 Thread Paolo Bonzini
Build all executables by default except for the known-broken ones. This also allows running qemu-iotests without manually building socket_scm_helper. Reported-by: Max Reitz Tested-by: Max Reitz Signed-off-by: Paolo Bonzini --- docs/devel/build-system.rst| 5 + tests/fp/meson.build

[PULL 06/92] WHPX: vmware cpuid leaf for tsc and apic frequency

2020-09-24 Thread Paolo Bonzini
From: Sunil Muthuswamy Newer versions of WHPX provide the capability to query the tsc and apic frequency. Expose these through the vmware cpuid leaf. This patch doesnt support setting the tsc frequency; that will come as a separate fix. Signed-off-by: Sunil Muthuswamy Message-Id: Signed-off-b

[PULL 10/92] memory: Convert IOMMUMemoryRegionClass doc comment to kernel-doc

2020-09-24 Thread Paolo Bonzini
From: Eduardo Habkost Convert the existing documentation comments of IOMMUMemoryRegionClass to kernel-doc format so their contents will appear in the API reference at docs/devel/memory.html. Signed-off-by: Eduardo Habkost Message-Id: <20200908201129.3407568-1-ehabk...@redhat.com> Reviewed-by: P

[PULL 04/92] meson: fix MSI rule

2020-09-24 Thread Paolo Bonzini
From: Marc-André Lureau The environment variables can't be passed through an env: argument yet (meson#2723), use 'env' as suggested in: https://github.com/mesonbuild/meson/issues/2723#issuecomment-348630957 Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- qga/meson.build | 1

[PULL 00/92] Misc patches for 2020-09-24

2020-09-24 Thread Paolo Bonzini
The following changes since commit 0fc0142828b5bc965790a1c5c6e241897d3387cb: Merge remote-tracking branch 'remotes/kraxel/tags/input-20200921-pull-request' into staging (2020-09-22 21:11:10 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

[PULL 07/92] configure: Do not intent to build WHPX on 32-bit host

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Hyper-V is available on 64-bit versions of Windows, do not try to build its support on 32-bit versions. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200910054516.405777-1-f4...@amsat.org> Reviewed-by: Stefan Weil Signed-off-by: Paolo Bonzini --- configur

[PULL 12/92] acpi: i386: Move VMBus DSDT entry to SB

2020-09-24 Thread Paolo Bonzini
From: Jon Doron Signed-off-by: Jon Doron Reviewed-by: Igor Mammedov Message-Id: <20200715084326.678715-2-ari...@gmail.com> Signed-off-by: Paolo Bonzini --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi

[PULL 01/92] tests: add missing genh dependency

2020-09-24 Thread Paolo Bonzini
From: Claudio Fontana Fix high-parallelism builds by forcing all generated headers to be created before tests are compiled. Reported-by: Claudio Fontana Signed-off-by: Paolo Bonzini Tested-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé --- tests/meson.build | 4 ++-- 1 file changed

[PULL 08/92] MAINTAINERS: add Paolo Bonzini as RCU maintainer

2020-09-24 Thread Paolo Bonzini
From: Stefan Hajnoczi The RCU code that Paolo maintains is missing a MAINTAINERS file entry. Signed-off-by: Stefan Hajnoczi Message-Id: <20200909090851.14458-1-stefa...@redhat.com> Signed-off-by: Paolo Bonzini --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAI

[PULL 14/92] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text

2020-09-24 Thread Paolo Bonzini
From: Igor Mammedov it was actually removed in 5.0, commit 68a86dc15c (numa: remove deprecated -mem-path fallback to anonymous RAM) clean up forgotten remnants in docs. Signed-off-by: Igor Mammedov Message-Id: <20200911084410.788171-3-imamm...@redhat.com> Signed-off-by: Paolo Bonzini --- docs

[PULL 11/92] vhost-scsi: support inflight io track

2020-09-24 Thread Paolo Bonzini
From: Li Feng Qemu will send GET_INFLIGHT_FD and SET_INFLIGH_FD to backend, and the backend setup the inflight memory to track the io. Change-Id: I805d6189996f7a1b44c65f0b12ef7473b1789510 Signed-off-by: Li Feng Message-Id: <20200909122021.1055174-1-fen...@smartx.com> Signed-off-by: Paolo Bonzin

[PULL 15/92] numa: remove fixup numa_state->num_nodes to MAX_NODES

2020-09-24 Thread Paolo Bonzini
From: Igor Mammedov current code permits only nodeids in [0..MAX_NODES) range due to nodeid check in parse_numa_node() if (nodenr >= MAX_NODES) { error_setg(errp, "Max number of NUMA nodes reached: %" so subj fixup is not reachable, drop it. Signed-off-by: Igor Mammedov Mess

[PULL 17/92] hw/char/serial: Remove TYPE_SERIAL_IO

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé TYPE_SERIAL_IO is a subset of TYPE_SERIAL_MM, and it is not used anymore. Remove it. Suggested-by: Paolo Bonzini Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200907011538.818996-3-phi...@redhat.co

[PULL 23/92] hw/char/serial: Make 'wakeup' property boolean

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Make the "wakeup" property introduced in commit 9826fd597df ("suspend: make serial ports wakeup the guest") a boolean. As we want to reuse the generic serial properties in the ISA model (next commit), expose this property. Signed-off-by: Philippe Mathieu-Daudé Revi

[PULL 16/92] hw/mips/mipssim: Use MMIO serial device on fake ISA I/O

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The 'mipssim' is not a real hardware, it is a simulator. There is an ISA MMIO space mapped at 0x1fd0, however this is not a real ISA bus (no ISA IRQ). So can not use the TYPE_ISA_SERIAL device... Instead we have been using a plain MMIO device, but named it IO. T

[PULL 13/92] numa: drop support for '-numa node' (without memory specified)

2020-09-24 Thread Paolo Bonzini
From: Igor Mammedov it was deprecated since 4.1 commit 4bb4a2732e (numa: deprecate implict memory distribution between nodes) Users of existing VMs, wishing to preserve the same RAM distribution, should configure it explicitly using ``-numa node,memdev`` options. Current RAM distribution can be

[PULL 20/92] hw/char/serial: Replace commented DPRINTF() by trace event

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Convert the old debug PRINTF() call to display the UART baudrate to a trace event. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200907015535.827885-3-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- hw/char/serial.c | 4

[PULL 18/92] configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI

2020-09-24 Thread Paolo Bonzini
From: Stefan Hajnoczi The QEMU_GA_MSI_ENABLED config-host.mak variable is emitted by ./configure. meson.build actually checks for CONFIG_QGA_MSI_ENABLED: summary_info += {'QGA MSI support': config_host.has_key('CONFIG_QGA_MSI_ENABLED')} Rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI for cons

[PULL 22/92] hw/char/serial: Rename I/O read/write trace events

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The serial_mm_read/write() handlers from the TYPE_SERIAL_MM device call the serial_ioport_read/write() handlers with shifted offset. When looking at the trace events from this MMIO device, it is confusing to read the accesses as I/O. Simplify using generic trace even

[PULL 21/92] hw/char/serial: Remove old DEBUG_SERIAL commented code

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé All useful DPRINTF() calls have been converted to trace events. Remove a pointless one in the IOEventHandler, and drop the DEBUG_SERIAL ifdef'ry. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200907015535.827885-4-f4...@amsat.

[PULL 25/92] scsi-generic: Fix HM-zoned device scan

2020-09-24 Thread Paolo Bonzini
From: Dmitry Fomichev Several important steps during device scan depend on SCSI type of the device. For example, max_transfer property is only determined and assigned if the device has the type of TYPE_DISK. Host-managed ZBC disks retain most of the properties of regular SCSI drives, but they ha

[PULL 19/92] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes

2020-09-24 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The serial device has 8 registers, each 8-bit. The MemoryRegionOps 'serial_io_ops' is initialized with max_access_size=1, and all memory_region_init_io() callers correctly set the region size to 8 bytes: - serial_io_realize - serial_isa_realizefn - serial_pci_realize

[PULL 34/92] configure: move cocoa option to Meson

2020-09-24 Thread Paolo Bonzini
While detection of the framework was already there, moving the option allows for better error reporting. Reported-by: Christophe de Dinechin Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- configure | 17 +++-- meson.build | 9 +++-- meson_options

[PULL 30/92] meson: move libmpathpersist test

2020-09-24 Thread Paolo Bonzini
This is the first compiler/linker test that has been moved to Meson. Add more section headings to keep things clearer. This also fixes static linking to libmpathpersist, which has a dependency on libmultipath but no pkg-config file to describe it. Signed-off-by: Paolo Bonzini --- configure

  1   2   3   4   5   6   >