Patchew URL: https://patchew.org/QEMU/1600932956-11642-1-git-send-email-che...@lemote.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1600932956-11642-1-git-send-email-che...@lemote.com Subject: [PATCH V11 0/8] mips: Add Loongson-3 machine support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/1600932956-11642-1-git-send-email-che...@lemote.com -> patchew/1600932956-11642-1-git-send-email-che...@lemote.com Switched to a new branch 'test' cf89714 docs/system: Update MIPS machine documentation cabf51a hw/mips: Add Loongson-3 machine support fd67757 hw/mips: Implement fw_cfg_arch_key_name() dca18c2 target/mips: Add loongson-ext lsdc2 group of instructions d6d9a34 target/mips: Add loongson-ext lswc2 group of instructions (Part 2) 7832191 target/mips: Add loongson-ext lswc2 group of instructions (Part 1) 40a536a target/mips: Fix PageMask with variable page size 5fe85fa linux-headers: Update MIPS KVM type defintition === OUTPUT BEGIN === 1/8 Checking commit 5fe85fa02e96 (linux-headers: Update MIPS KVM type defintition) 2/8 Checking commit 40a536afdaaf (target/mips: Fix PageMask with variable page size) 3/8 Checking commit 7832191c4d37 (target/mips: Add loongson-ext lswc2 group of instructions (Part 1)) 4/8 Checking commit d6d9a344b00a (target/mips: Add loongson-ext lswc2 group of instructions (Part 2)) 5/8 Checking commit dca18c2e9cbe (target/mips: Add loongson-ext lsdc2 group of instructions) 6/8 Checking commit fd67757d7016 (hw/mips: Implement fw_cfg_arch_key_name()) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 60 lines checked Patch 6/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/8 Checking commit cabf51ae1224 (hw/mips: Add Loongson-3 machine support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 WARNING: line over 80 characters #226: FILE: hw/mips/loongson3_virt.c:142: +static void loongson3_pm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) ERROR: return is not a function, parentheses are not required #288: FILE: hw/mips/loongson3_virt.c:204: + return (freq * 2); WARNING: line over 80 characters #394: FILE: hw/mips/loongson3_virt.c:310: + lp->boarddev_table_offset = (uintptr_t)board_devices_info(p) - (uintptr_t)lp; WARNING: line over 80 characters #510: FILE: hw/mips/loongson3_virt.c:426: + fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)current_machine->smp.max_cpus); WARNING: line over 80 characters #558: FILE: hw/mips/loongson3_virt.c:474: + sprintf(highmemenv, "%ld", (unsigned long)(loaderparams.ram_size / MiB) - 256); WARNING: line over 80 characters #644: FILE: hw/mips/loongson3_virt.c:560: +static inline void loongson3_virt_devices_init(MachineState *machine, DeviceState *pic) WARNING: line over 80 characters #675: FILE: hw/mips/loongson3_virt.c:591: + get_system_io(), 0, virt_memmap[VIRT_PCIE_PIO].size); WARNING: line over 80 characters #781: FILE: hw/mips/loongson3_virt.c:697: + /* Allocate RAM/BIOS, 0x00000000~0x10000000 is alias of 0x80000000~0x90000000 */ total: 1 errors, 8 warnings, 994 lines checked Patch 7/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/8 Checking commit cf897144bf96 (docs/system: Update MIPS machine documentation) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1600932956-11642-1-git-send-email-che...@lemote.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
