Re: Python 3.5 EOL; when can require 3.6?

On 17/09/2020 17.30, Markus Armbruster wrote: > Thomas Huth writes: > >> On 16/09/2020 16.00, Thomas Huth wrote: >>> On 16/09/2020 14.30, Peter Maydell wrote: On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: > We require Python 3.5. It will reach its "end of life" at the end of >

Re: Python 3.5 EOL; when can require 3.6?

On 17/09/2020 17.39, Daniel P. Berrangé wrote: > On Thu, Sep 17, 2020 at 05:24:15PM +0200, Thomas Huth wrote: >> On 17/09/2020 16.55, Daniel P. Berrangé wrote: >>> On Thu, Sep 17, 2020 at 04:10:55PM +0200, Thomas Huth wrote: On 16/09/2020 16.00, Thomas Huth wrote: > On 16/09/2020 14.30, Pe

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 9:37 AM Markus Armbruster wrote: > Thomas Huth writes: > > > On 16/09/2020 16.00, Thomas Huth wrote: > >> On 16/09/2020 14.30, Peter Maydell wrote: > >>> On Wed, 16 Sep 2020 at 08:43, Markus Armbruster > wrote: > We require Python 3.5. It will reach its "end of lif

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On Thu, Sep 17, 2020 at 03:36:57PM +0800, Zhenyu Ye wrote: > When the hang occurs, the QEMU is blocked at: > > #0 0x95762b64 in ?? () from target:/usr/lib64/libpthread.so.0 > #1 0x9575bd88 in pthread_mutex_lock () from > target:/usr/lib64/libpthread.so.0 > #2

[PATCH] docs: simplify and clarify the platform support rules

The distinction between short life and long life Linux distributions turned out to be redundant. They can both be covered in a simple way by noting support will target the current release, and the previous release for a period of two years or until its EOL. This rule can also apply to the other UNI

Re: [PATCH v1] s390x/tcg: Implement MONITOR CALL

On 17.09.20 17:33, Richard Henderson wrote: > On 9/17/20 4:54 AM, David Hildenbrand wrote: >> Recent upstream Linux uses the MONITOR CALL instruction for things like >> BUG_ON() and WARN_ON(). We currently inject an operation exception when >> we hit a MONITOR CALL instruction - which is wrong, as

[PATCH 1/3] virtio-net: Set mac address to hardware if the peer is vdpa

If the peer's type is vdpa,set the mac address to NIC in virtio_net_device_realize, Also sometime vdpa get an all 0 macaddress from the hardware, this will cause the traffic down So we add the check for this part. if we get an 0 mac address we will use the default mac address instead Signed-off-

Re: [PATCH] docs: simplify and clarify the platform support rules

Patchew URL: https://patchew.org/QEMU/20200917155606.1623795-1-berra...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917155606.1623795-1-berra...@redhat.com/testing.FreeBSD/?type=me

[PATCH 2/3] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup

fix the bug that fd will still open after the cleanup Signed-off-by: Cindy Lu --- net/vhost-vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index bc0e0d2d35..0480b92102 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -144,6 +144,10 @@ st

Reminder: Outreachy open source internships initial application deadline Sept 20

Hi, QEMU is participating in the Outreachy December-March open source internship program. The internships are 12 weeks of full-time paid remote work contributing to QEMU/KVM. For more information about eligibility and what the internships are like, please see https://outreachy.org/. The initial ap

[PATCH 3/3] net: Add vhost-vdpa in show_netdevs()

Fix the bug that while Check qemu supported netdev, there is no vhost-vdpa Signed-off-by: Cindy Lu --- net/net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/net.c b/net/net.c index 7a2a0fb5ac..794c652282 100644 --- a/net/net.c +++ b/net/net.c @@ -1049,6 +1049,9 @@ static void show

Re: [PATCH v8 2/7] copy-on-read: add filter append/drop functions

On 04.09.2020 14:22, Max Reitz wrote: On 28.08.20 18:52, Andrey Shinkevich wrote: Provide API for the COR-filter insertion/removal. ... Also, drop the filter child permissions for an inactive state when the filter node is being removed. Do we need .active for that? Shouldn’t it be sufficie

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On 2020-09-17 16:44, Stefan Hajnoczi wrote: > On Thu, Sep 17, 2020 at 03:36:57PM +0800, Zhenyu Ye wrote: > > When the hang occurs, the QEMU is blocked at: > > > > #0 0x95762b64 in ?? () from target:/usr/lib64/libpthread.so.0 > > #1 0x9575bd88 in pthread_mutex_lock () from

Re: [PATCH v3 5/5] sev/i386: Enable an SEV-ES guest based on SEV policy

On 9/17/20 11:07 AM, Tom Lendacky wrote: On 9/17/20 10:34 AM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is e

Re: Python 3.5 EOL; when can require 3.6?

On Thu, 2020-09-17 at 17:30 +0200, Markus Armbruster wrote: > Thomas Huth writes: > > Sorry, I forgot to check Debian. If I got that right, Debian 9 still > > uses Python 3.5 by default. So I guess that means we can not deprecate > > Python 3.5 yet? > > Discussed before: > > Subject: Re: [PA

Re: [PATCH] docs: simplify and clarify the platform support rules

On 17/09/2020 17.56, Daniel P. Berrangé wrote: > The distinction between short life and long life Linux distributions > turned out to be redundant. They can both be covered in a simple way > by noting support will target the current release, and the previous > release for a period of two years or u

Re: Python 3.5 EOL; when can require 3.6?

On Wed, Sep 16, 2020 at 04:00:14PM +0200, Thomas Huth wrote: > On 16/09/2020 14.30, Peter Maydell wrote: > > On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: > >> We require Python 3.5. It will reach its "end of life" at the end of > >> September 2020[*]. Any reason not to require 3.6 for

Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

On Wed 09 Sep 2020 08:59:29 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 1. Drop extra error propagation > > 2. Set errp always on failure. Generic bdrv_open_driver supports driver > functions which can return negative value and forget to set errp. > That's a strange thing.. Let's improve qcow2

Re: [PATCH v3 5/5] sev/i386: Enable an SEV-ES guest based on SEV policy

On 9/17/20 10:34 AM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in

Re: [PATCH] docs: simplify and clarify the platform support rules

Patchew URL: https://patchew.org/QEMU/20200917155606.1623795-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/2020091715560

Re: [PATCH 14/14] block/qed: bdrv_qed_do_open: deal with errp

On Wed 09 Sep 2020 08:59:30 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > Set errp always on failure. Generic bdrv_open_driver supports driver > functions which can return negative value and forget to set errp. > That's a strange thing.. Let's improve bdrv_qed_do_open to not behave > this way. T

Re: [PATCH] docs: simplify and clarify the platform support rules

On Thu, Sep 17, 2020 at 04:56:06PM +0100, Daniel P. Berrangé wrote: > The distinction between short life and long life Linux distributions > turned out to be redundant. They can both be covered in a simple way > by noting support will target the current release, and the previous > release for a per

Re: [PATCH v2 09/10] disas: Enable capstone disassembly for s390x

On 15/09/2020 01.02, Richard Henderson wrote: > Enable s390x, aka SYSZ, in the git submodule build. > Set the capstone parameters for both s390x host and guest. > > Signed-off-by: Richard Henderson > --- > disas.c| 3 +++ > target/s390x/cpu.c | 4 > meson.build| 11 +++

[PATCH 0/4] qemu/bswap: Let cpu_to_endian() functions handle constant expressions

Stefan Hajnoczi suggested we can use __builtin_constant_p() in the cpu_to_ENDIAN()/ENDIAN_to_cpu() functions to check if expression is constant, and if so use the const_ENDIAN() macros. This series modifies cpu_to_ENDIAN() to use const_ENDIAN() when possible. Philippe Mathieu-Daudé (4): qemu/bs

[PATCH 1/4] qemu/bswap: Move const_le() definitions around

As we want the cpu_to_endian() macros use the const_le() macros, move them earlier, so they are defined when we use them. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/in

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On Thu, Sep 17, 2020 at 11:29 PM Thomas Huth wrote: > > On 17/09/2020 17.14, Peter Maydell wrote: > > On Wed, 16 Sep 2020 at 12:47, Thomas Huth wrote: > >> > >> * Fix "readlink -f" problem in iotests on macOS (to fix the Cirrus-CI t

[PATCH 4/4] qemu/bswap: Let cpu_to_endian() functions handle constant expressions

cpu_to_endian() and endian_to_cpu() can be extended to handle constant expressions. That way the programmer doesn't need to remember the const_X() API exists. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 8 ++-- 1 file changed, 6 insertions(

[PATCH 2/4] qemu/bswap: add const_be16() and const_be32()

From: Philippe Mathieu-Daudé We already have the const_le() macros for little endian. Implement the big-endian equivalent. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/qemu/bswap.h b/in

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 06:07:00PM +0200, Andrea Bolognani wrote: > On Thu, 2020-09-17 at 17:30 +0200, Markus Armbruster wrote: > > Thomas Huth writes: > > > Sorry, I forgot to check Debian. If I got that right, Debian 9 still > > > uses Python 3.5 by default. So I guess that means we can not depr

[PATCH 3/4] qemu/bswap: Add const_le64() and const_be64()

From: Philippe Mathieu-Daudé We already have the const_endian() macros for 16-bit and 32-bit values. Implement the 64-bit equivalent macros. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/bswap.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH v3 1/5] sev/i386: Add initial support for SEV-ES

* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > Provide initial support for SEV-ES. This includes creating a function to > indicate the guest is an SEV-ES guest (which will return false until all > support is in place), performing the proper SEV initialization and > ensur

Re: [PATCH v2 10/10] disas/capstone: Add skipdata hook for s390x

On 15/09/2020 01.02, Richard Henderson wrote: > It is always possible to tell the length of an insn, even if the > actual insn is unknown. Skip the correct number of bytes, so that > we stay in sync with the instruction stream. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Hen

Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

On Wed 09 Sep 2020 08:59:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > + * On success return true with bm_list set (probably to NULL, if no bitmaps), " probably " ? :-) > + * on failure return false with errp set. > */ > -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *

[PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

Armbian servers are not very reliable and confused the GitLab CI users a few times this month (path updated, archives moved, and now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired" error). Time to disable these tests. Users can still use the artifacts from the cache (or manually add th

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 12:19:19PM -0400, Eduardo Habkost wrote: > On Wed, Sep 16, 2020 at 04:00:14PM +0200, Thomas Huth wrote: > > On 16/09/2020 14.30, Peter Maydell wrote: > > > On Wed, 16 Sep 2020 at 08:43, Markus Armbruster wrote: > > >> We require Python 3.5. It will reach its "end of life"

Re: [PATCH] docs: simplify and clarify the platform support rules

On Thu, Sep 17, 2020 at 12:28:51PM -0400, Eduardo Habkost wrote: > On Thu, Sep 17, 2020 at 04:56:06PM +0100, Daniel P. Berrangé wrote: > > The distinction between short life and long life Linux distributions > > turned out to be redundant. They can both be covered in a simple way > > by noting supp

RE: [PATCH 1/2] file-posix: Correctly read max_segments of SG nodes

> -Original Message- > From: Maxim Levitsky > Sent: Thursday, September 17, 2020 9:24 AM > To: Max Reitz ; Dmitry Fomichev > ; Kevin Wolf ; Paolo > Bonzini ; Fam Zheng ; Philippe > Mathieu-Daudé > Cc: Alistair Francis ; Damien Le Moal > ; qemu-bl...@nongnu.org; qemu- > de...@nongnu.org >

Re: [PATCH v3 3/5] sev/i386: Allow AP booting under SEV-ES

* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > When SEV-ES is enabled, it is not possible modify the guests register > state after it has been initially created, encrypted and measured. > > Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the > hyper

Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

On Wed 09 Sep 2020 08:59:26 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > -/* qcow2_load_dirty_bitmaps() > - * Return value is a hint for caller: true means that the Qcow2 header was > - * updated. (false doesn't mean that the header should be updated by the > - * caller, it just means that upda

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

On 17/09/2020 18.33, 罗勇刚(Yonggang Luo) wrote: > > > On Thu, Sep 17, 2020 at 11:29 PM Thomas Huth > wrote: >> >> On 17/09/2020 17.14, Peter Maydell wrote: >> > On Wed, 16 Sep 2020 at 12:47, Thomas Huth > wrote: >> >> -

Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

Patchew URL: https://patchew.org/QEMU/20200917163954.50514-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200917163954.505

Re: Python 3.5 EOL; when can require 3.6?

On Thu, Sep 17, 2020 at 05:33:15PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 17, 2020 at 12:19:19PM -0400, Eduardo Habkost wrote: > > On Wed, Sep 16, 2020 at 04:00:14PM +0200, Thomas Huth wrote: > > > On 16/09/2020 14.30, Peter Maydell wrote: > > > > On Wed, 16 Sep 2020 at 08:43, Markus Armbru

Re: [PATCH] docker.py: always use --rm

Philippe Mathieu-Daudé writes: > On 9/17/20 12:44 PM, Paolo Bonzini wrote: >> Avoid that containers pile up. >> >> Signed-off-by: Paolo Bonzini >> --- >> tests/docker/Makefile.include | 1 - >> tests/docker/docker.py| 4 ++-- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >>

Re: [PATCH] docker.py: always use --rm

Il gio 17 set 2020, 18:53 Alex Bennée ha scritto: > > Philippe Mathieu-Daudé writes: > > > On 9/17/20 12:44 PM, Paolo Bonzini wrote: > >> Avoid that containers pile up. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> tests/docker/Makefile.include | 1 - > >> tests/docker/docker.py

Re: [PATCH 06/37] qapi: delint using flake8

On 9/17/20 3:54 AM, Markus Armbruster wrote: John Snow writes: On 9/16/20 8:12 AM, Markus Armbruster wrote: John Snow writes: Petty style guide fixes and line length enforcement. Not a big win, not a big loss, but flake8 passes 100% on the qapi module, which gives us an easy baseline to e

Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote: > Armbian servers are not very reliable and confused the GitLab CI > users a few times this month (path updated, archives moved, and > now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired" > error). Time to disable these tests. > Users c

Re: [PATCH v3 4/5] sev/i386: Don't allow a system reset under an SEV-ES guest

* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > An SEV-ES guest does not allow register state to be altered once it has > been measured. When a SEV-ES guest issues a reboot command, Qemu will > reset the vCPU state and resume the guest. This will cause failures under > SE

Re: [PATCH] hw/arm/aspeed: Map the UART5 device unconditionally

On 9/16/20 7:51 AM, Cédric Le Goater wrote: > On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote: >> ping? > > It's reviewed : > > > http://patchwork.ozlabs.org/project/qemu-devel/patch/20200905212415.760452-1-f4...@amsat.org/ > Yes I know :) This is part of my routine to check if a patch has

[PATCH] checkpatch: avoid error on cover letter files

Running checkpatch on a directory that contains a cover letter reports this error: Checking /tmp/tmpbnngauy3/-cover-letter.patch... ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 lines checked Let's skip cover letter as it is already done

Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

On 9/17/20 6:53 PM, Thomas Huth wrote: > On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote: >> Armbian servers are not very reliable and confused the GitLab CI >> users a few times this month (path updated, archives moved, and >> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired" >> e

Re: Python 3.5 EOL; when can require 3.6?

On Thu, 2020-09-17 at 17:35 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 17, 2020 at 06:07:00PM +0200, Andrea Bolognani wrote: > > It would be *fantastic* if we could keep the platform support policy > > used by QEMU and libvirt as aligned as reasonably possible. > > The current QEMU policy was

Re: [PATCH 07/37] qapi: add pylintrc

On 9/17/20 3:58 AM, Markus Armbruster wrote: We don't care if import statements are similar to those in other files. It's uninteresting entirely. (It matches on from typing import ... that exceed four lines, which I do regularly by the end of the series.) What about something like # Igno

Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com

Patchew URL: https://patchew.org/QEMU/20200917163954.50514-1-phi...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200917163954.50514-1-phi...@redhat.com/testing.FreeBSD/?type=message. --

Re: [PATCH] hw/arm/aspeed: Map the UART5 device unconditionally

On 9/17/20 6:57 PM, Philippe Mathieu-Daudé wrote: > On 9/16/20 7:51 AM, Cédric Le Goater wrote: >> On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote: >>> ping? >> >> It's reviewed : >> >> >> http://patchwork.ozlabs.org/project/qemu-devel/patch/20200905212415.760452-1-f4...@amsat.org/ >> > > Yes

Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization

Thomas Huth writes: > On 15/09/2020 01.02, Richard Henderson wrote: >> Rename several functions, dropping "generic" and making "host" >> vs "target" clearer. Make a bunch of functions static that are >> not used outside this file. Replace INIT_DISASSEMBLE_INFO with >> a trio of functions. >>

Re: [PATCH 09/37] qapi/common.py: Add indent manager

On 9/17/20 4:07 AM, Markus Armbruster wrote: John Snow writes: On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: Let's replace "the indent" by "the indentation" globally. They're both cromulent as nouns and one is shorter. I'll switch in good faith; do you prefer "Inde

Re: [PATCH] Fix video playback slowdown when spice client no audio enabled

> Hello Qi, > > your patch breaks audio playback with the dsoundaudio backend. > > I suggest you make the following changes: > > - Test for size == 0 first and leave the loop in that case. > - For buf == NULL drop size bytes. Don't leave the loop with break or return. > - Verify all audio backend

Re: [PATCH v2 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

On Thu, Sep 17, 2020 at 09:38:02AM +0200, Cédric Le Goater wrote: > On 9/17/20 4:49 AM, Eduardo Habkost wrote: > > Mechanical search/replace to use the new > > DECLARE_INTERFACE_CHECKER macro instead of manually defining > > macros using INTERFACE_CHECK. > > > > Acked-by: David Gibson > > Signed-

Re: [PATCH] configure: do not limit Hypervisor.framework test to Darwin

On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote: > Because the target/i386/hvf/meson.build rule culls hvf support > on non-Darwin systems, a --enable-hvf build is succeeding. > To fix this, just try the compilation test every time someone > passes --enable-hvf. > > Reported-by: Chris

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > This patch series provides support for launching an SEV-ES guest. > > Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the > SEV support to protect the guest register state from the hypervisor. See > "A

Re: [PATCH 0/2] qpm: Minor error value corrections

On Thu, Sep 17, 2020 at 02:55:38PM +0200, Markus Armbruster wrote: > Markus Armbruster (2): > qom: Clean up object_property_get_enum()'s error value > qom: Correct error values in two contracts Queued, thanks! -- Eduardo

Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

17.09.2020 19:23, Alberto Garcia wrote: On Wed 09 Sep 2020 08:59:29 PM CEST, Vladimir Sementsov-Ogievskiy wrote: 1. Drop extra error propagation 2. Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a s

Re: [PATCH] checkpatch: avoid error on cover letter files

On 9/17/20 7:02 PM, Stefano Garzarella wrote: > Running checkpatch on a directory that contains a cover letter reports > this error: > > Checking /tmp/tmpbnngauy3/-cover-letter.patch... > ERROR: Does not appear to be a unified-diff format patch > > total: 1 errors, 0 warnings, 0 l

Re: [PATCH] target/i386: always create kvmclock device

* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > >> Antoine Damhet writes: > >> > >> > On Thu, Sep 17, 2020 at 01:13:06PM +0200, Vitaly Kuznetsov wrote: > >> >> QEMU's kvmclock device is only created when

Re: [PATCH 10/37] qapi/common.py: delint with pylint

On 9/17/20 10:15 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/common.py | 16 +++- scripts/qapi/schema.py | 14 +++--- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/com

Re: [PATCH] configure: do not limit Hypervisor.framework test to Darwin

On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote: > Because the target/i386/hvf/meson.build rule culls hvf support > on non-Darwin systems, a --enable-hvf build is succeeding. > To fix this, just try the compilation test every time someone > passes --enable-hvf. > > Reported-by: Chris

Re: [PATCH 11/37] qapi/common.py: Replace one-letter 'c' variable

On 9/17/20 10:17 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/common.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index c665e67495..4c079755d3 100644 --- a/scripts/

[Bug 1896096] [NEW] Git version: Build process is broken in block_curl.c.o

Public bug reported: Gcc version: 10.2.0 Glusterfs: 8.1 Libguestfs: 1.42 Configure options used: configure \ --prefix=/usr \ --sysconfdir=/etc \ --localstatedir=/var \ --libexecdir=/usr/lib/qemu \ --extra-ldflags="$LDFLAGS" \ --smbd=/usr/bin/smbd \ --enable-modules \

Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote: > Going to obsolete Icelake-Client CPU models in the future. > > Signed-off-by: Robert Hoo > --- > Change log > v3: > Obsolete in v5.2 --> v5.3. > > target/i386/cpu.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) >

[Bug 1895703] Re: performance degradation in tcg since Meson switch

** Attachment added: "matmult_double-m68k" https://bugs.launchpad.net/qemu/+bug/1895703/+attachment/5411765/+files/matmult_double-m68k -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895703 Title:

Re: [PATCH v3 3/5] sev/i386: Allow AP booting under SEV-ES

On 9/17/20 11:46 AM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is

Re: [PATCH v3 4/5] sev/i386: Don't allow a system reset under an SEV-ES guest

On 9/17/20 12:01 PM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When a SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume th

Re: [PATCH 13/37] qapi/common.py: add notational type hints

On 9/17/20 10:32 AM, Markus Armbruster wrote: Question on the subject line: what makes a type hint notational? My cover letter explains that every time I use this phrase, I mean to state that "This patch adds exclusively type notations and makes no functional changes to the runtime operation

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

I think the patch looks better now, thanks! Just a few minor questions and suggestions: On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > Complement versioned CPU model framework with the ability of marking some > versions deprecated. When that CPU model is chosen, get some warning. T

Re: [PATCH V3 01/10] qemu/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the folder. > > Signed-off-by: zhaolichang > Reviewed-by: Alex Bennee > ---

Re: [PATCH V3 03/10] docs/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the docs folder. > > Signed-off-by: zhaolichang > Reviewed-by: Peter Maydell

Re: [PATCH V3 02/10] migration/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the migration folder. > > Signed-off-by: zhaolichang > Reviewed-by: Peter Ma

Re: [PATCH V3 04/10] scripts/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the scripts folder. > > Signed-off-by: zhaolichang > Reviewed-by: Peter Mayd

Re: [PATCH V3 06/10] linux-user/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the linux-user folder. > > Signed-off-by: zhaolichang > Reviewed-by: Alex Be

Re: [PATCH V3 05/10] util/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the util folder. > > Signed-off-by: zhaolichang > Reviewed-by: Alex Bennee

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

Le 17/09/2020 à 10:44, Alex Bennée a écrit : > > zhaolichang writes: > >> I found that there are many spelling errors in the comments of qemu, >> so I used the spellcheck tool to check the spelling errors >> and finally found some spelling errors in the disas folder. >> >> Signed-off-by: zhaolic

Re: [PATCH V3 09/10] qapi/: fix some comment spelling errors

Le 17/09/2020 à 09:50, zhaolichang a écrit : > I found that there are many spelling errors in the comments of qemu, > so I used the spellcheck tool to check the spelling errors > and finally found some spelling errors in the qapi folder. > > Signed-off-by: zhaolichang > Reviewed-by: Markus Armbru

Re: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

On Tue, Sep 15, 2020 at 05:46:33PM -0700, Richard Henderson wrote: > We do not need or want to be allocating page sized quanta. > > Signed-off-by: Richard Henderson Would it be safe to keep patches 2-6 applied in case this one gets dropped or reverted for any reason? I consider patches 2-6 bug

Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings

On 9/17/20 10:37 AM, Markus Armbruster wrote: John Snow writes: As docstrings, they'll show up in documentation and IDE help. Signed-off-by: John Snow --- scripts/qapi/common.py | 50 ++ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git

Re: [PATCH] docker.py: always use --rm

Got it. On Thu, 17 Sep 2020, 17:58 Paolo Bonzini, wrote: > > > Il gio 17 set 2020, 18:53 Alex Bennée ha scritto: > >> >> Philippe Mathieu-Daudé writes: >> >> > On 9/17/20 12:44 PM, Paolo Bonzini wrote: >> >> Avoid that containers pile up. >> >> >> >> Signed-off-by: Paolo Bonzini >> >> --- >>

Re: [PATCH 09/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

17.09.2020 19:32, Alberto Garcia wrote: On Wed 09 Sep 2020 08:59:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: + * On success return true with bm_list set (probably to NULL, if no bitmaps), " probably " ? :-) I note this as "set to NULL" is not obvious thing (is it "unset" ? :).. And by

Re: [PATCH 15/37] qapi/common.py: split build_params into new file

On 9/17/20 10:42 AM, Markus Armbruster wrote: John Snow writes: Including it in common.py creates a circular import dependency, because schema relies on common.py. To type build_params properly, it needs to be moved outside of the chain. Signed-off-by: John Snow --- scripts/qapi/commands.p

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: * Tom Lendacky (thomas.lenda...@amd.com) wrote: From: Tom Lendacky This patch series provides support for launching an SEV-ES guest. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest re

Re: [PATCH 10/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

17.09.2020 19:35, Alberto Garcia wrote: On Wed 09 Sep 2020 08:59:26 PM CEST, Vladimir Sementsov-Ogievskiy wrote: -/* qcow2_load_dirty_bitmaps() - * Return value is a hint for caller: true means that the Qcow2 header was - * updated. (false doesn't mean that the header should be updated by the

Re: [PATCH 0/6] misc: Some inclusive terminology changes

Le 10/09/2020 à 09:01, Philippe Mathieu-Daudé a écrit : > We don't have (yet?) inclusive terminology guidelines, > but the PCI hole memory is not "black", the DMA sources > don't stream to "slaves", and there isn't really a TSX > "black" list, we only check for broken fields. > > As this terms can

Re: Python docstrings and licensing/authorship

On 9/17/20 8:55 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Sep 16, 2020 at 12:22:37PM -0400, John Snow wrote: [...] The real question I have is if anyone thinks it would be "rude" to separate out any of the comment preambles (currently not visible at runtime or docs in a

Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings

On Thu, Sep 17, 2020 at 02:44:53PM -0400, John Snow wrote: [...] > Having said this, I have not found any tool to date that actually *checks* > these comments for consistency. The pycharm IDE interactively highlights > them when it senses that you have made a mistake, but that cannot be worked > in

Re: [PATCH 02/14] block: use return status of bdrv_append()

10.09.2020 19:10, Greg Kurz wrote: On Wed, 9 Sep 2020 21:59:18 +0300 Vladimir Sementsov-Ogievskiy wrote: Now bdrv_append returns status and we can drop all the local_err things around it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Reviewed-by: Greg Kurz Just one suggestion for a fo

Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings

On 9/17/20 3:14 PM, Eduardo Habkost wrote: On Thu, Sep 17, 2020 at 02:44:53PM -0400, John Snow wrote: [...] Having said this, I have not found any tool to date that actually *checks* these comments for consistency. The pycharm IDE interactively highlights them when it senses that you have made a

Re: [PULL 0/8] configure deprecation, linux-user and test fix

On Wed, 16 Sep 2020 at 13:26, Alex Bennée wrote: > > The following changes since commit de39a045bd8d2b49e4f3d07976622c29d58e0bac: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20200915-pull-request' into staging (2020-09-15 > 14:25:05 +0100) > > are available in the Git repositor

Re: [PATCH 15/37] qapi/common.py: split build_params into new file

On 9/17/20 10:42 AM, Markus Armbruster wrote: Ugh. Would moving it gen.py work? Done.

Re: [Qemu-arm] Assigning sd-card to specific SD-bus with Sabrelite Machine

On Thu, 17 Sep 2020 at 19:21, David Aghaian wrote: > Having a real difficult time determining whether or not I can use qemu (arm) > with the Sabrelite machine type to be able to assign an sd-card to one of the > 4 available sd-bus slots. Currently, no matter what combination of arguments > I pr

[PATCH v2 07/13] blockjob: return status from block_job_set_speed()

Better to return status together with setting errp. It allows to avoid error propagation in the caller. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- include/block/blockjob.h | 2 +- blockjob.c | 18 -- 2 files

[PATCH v2 02/13] block: use return status of bdrv_append()

Now bdrv_append returns status and we can drop all the local_err things around it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block.c | 5 + block/backup-top.c | 20 block/commit.c

[PATCH v2 00/13] block: deal with errp: part I

v2: 01-07: add Greg's and Alberto's r-bs 08: fix wording in commit message add Greg's r-b 09: fix header_updated logic, add comment, drop unrelated style-change [Alberto] 10: - fix commit header - add note about ERRP_GUARD in commit message - add Greg's r-b 11: add Greg's and Alberto's

<    1   2   3   4   5   >