Re: [PULL 00/16] Msys2 patches patches

2020-09-09 Thread Thomas Huth
On 08/09/2020 20.56, Eric Blake wrote: > On 9/8/20 1:49 PM, Yonggang Luo wrote: >> The following changes since commit >> 6779038537360e957dbded830f76b08ef5070161: >> >>    Merge remote-tracking branch >> 'remotes/armbru/tags/pull-qapi-2020-09-08' int= >> o staging (2020-09-08 17:23:31 +0100) >> >>

Re: [PATCH 05/16] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Thomas Huth
On 08/09/2020 21.48, Yonggang Luo wrote: > These tests are blocking test-char to be finished. > > Signed-off-by: Yonggang Luo > --- > tests/test-char.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/test-char.c b/tests/test-char.c > index d35cc839bc..80e5bac61a 100644 > ---

Re: [PATCH V2 for-5.2] hw/null-machine: Add the kvm_type() hook for MIPS

2020-09-09 Thread Thomas Huth
On 09/09/2020 04.57, chen huacai wrote: > Hi, all, > > On Wed, Sep 9, 2020 at 1:25 AM Thomas Huth wrote: >> >> On 24/08/2020 10.11, Huacai Chen wrote: >>> MIPS has two types of KVM: TE & VZ, and TE is the default type. Now, >>> libvirt uses a null-machine to detect the kvm capability. In the MIPS

Re: [PATCH] Simplify the .gitignore file

2020-09-09 Thread Markus Armbruster
Thomas Huth writes: > On 07/09/2020 21.43, Philippe Mathieu-Daudé wrote: >> On 9/7/20 7:42 PM, Thomas Huth wrote: >>> Now that we always do out-of-tree builds (and the in-tree builds are >>> faked via a "build" directory), we can simplify out .gitignore file >>> quite a bit. >>> >>> Signed-off-by

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Daniel P . Berrangé
On Tue, Sep 08, 2020 at 08:24:35PM +0200, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 9/8/20 6:54 PM, Daniel P. Berrangé wrote: > > Some applications want to pass quite large values for the OEM strings > > entries. Rather than having huge strings on the command line, it would > > be better t

Re: [PATCH 4/5] hw/smbios: use qapi for SMBIOS entry point type enum

2020-09-09 Thread Daniel P . Berrangé
On Tue, Sep 08, 2020 at 08:29:43PM +0200, Philippe Mathieu-Daudé wrote: > On 9/8/20 6:54 PM, Daniel P. Berrangé wrote: > > This refactoring prepares for exposing the SMBIOS entry point type as a > > machine property on x86. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > hw/arm/virt.c

Re: [PATCH 1/4] docs: lift block-core.json rST header into parents

2020-09-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 08.09.2020 um 14:03 hat Laszlo Ersek geschrieben: >> Hi Stefan, >> >> On 09/08/20 11:31, Stefan Hajnoczi wrote: >> > block-core.json is included from several places. It has no way of >> > knowing what header level (h1, h2, ...) is appropriate. Sphinx reports >> > errors w

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:16, Andrew Jones wrote: > > > This patch does much more than the summary "hw/arm/virt: spe: Add SPE fdt > binding for virt machine" says it does. Please revise the summary. > Will revise it in v3. Thanks, Haibo > On Tue, Sep 08, 2020 at 08:13:27AM +, Haibo Xu wrote:

Re: [PATCH 05/16] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 3:13 PM Thomas Huth wrote: > On 08/09/2020 21.48, Yonggang Luo wrote: > > These tests are blocking test-char to be finished. > > > > Signed-off-by: Yonggang Luo > > --- > > tests/test-char.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/test-cha

Re: [PATCH 1/4] docs: lift block-core.json rST header into parents

2020-09-09 Thread Kevin Wolf
Am 09.09.2020 um 09:38 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 08.09.2020 um 14:03 hat Laszlo Ersek geschrieben: > >> Hi Stefan, > >> > >> On 09/08/20 11:31, Stefan Hajnoczi wrote: > >> > block-core.json is included from several places. It has no way of > >> > knowing wh

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Christian Borntraeger
On 16.07.20 14:02, Cornelia Huck wrote: > On Wed, 15 Jul 2020 12:26:20 -0400 > Collin Walling wrote: > >> On 7/15/20 12:04 PM, Cornelia Huck wrote: >>> On Wed, 15 Jul 2020 11:36:35 -0400 >>> Collin Walling wrote: >>> Polite ping. Patches have been sitting on the list for a few weeks n

Re: [PATCH] Simplify the .gitignore file

2020-09-09 Thread Thomas Huth
On 08/09/2020 14.50, Eric Blake wrote: > On 9/7/20 12:42 PM, Thomas Huth wrote: >> Now that we always do out-of-tree builds (and the in-tree builds are >> faked via a "build" directory), we can simplify out .gitignore file > > s/out/our/ > >> quite a bit. >> >> Signed-off-by: Thomas Huth >> ---

[PATCH] vhost-scsi: support inflight io track

2020-09-09 Thread Li Feng
Qemu will send GET_INFLIGHT_FD and SET_INFLIGH_FD to backend, and the backend setup the inflight memory to track the io. Change-Id: I805d6189996f7a1b44c65f0b12ef7473b1789510 Signed-off-by: Li Feng --- hw/scsi/vhost-scsi-common.c | 27 +++ include/hw/virtio/vhost

[PATCH v2] Simplify the .gitignore file

2020-09-09 Thread Thomas Huth
Now that we always do out-of-tree builds (and the in-tree builds are faked via a "build" directory), we can simplify out .gitignore file quite a bit. Signed-off-by: Thomas Huth --- v2: Do not delete the .sdk, stgit and coccinelle lines .gitignore | 152

Re: [PATCH 1/4] docs: lift block-core.json rST header into parents

2020-09-09 Thread Kevin Wolf
Am 08.09.2020 um 11:31 hat Stefan Hajnoczi geschrieben: > block-core.json is included from several places. It has no way of > knowing what header level (h1, h2, ...) is appropriate. Sphinx reports > errors when it encounters an h2 header where it expects an h1 header. > This issue prevents the next

Re: [PATCH v4 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-09 Thread Dima Stepanov
On Tue, Sep 08, 2020 at 11:01:57PM -0400, Raphael Norwitz wrote: > On Fri, Sep 4, 2020 at 5:34 AM Dima Stepanov wrote: > > > > Add support for the vhost-user-blk-pci device. This node can be used by > > the vhost-user-blk tests. Tests for the vhost-user-blk device are added > > in the following pa

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Thomas Huth
On 08/09/2020 21.48, Yonggang Luo wrote: > Disable following tests on msys2/mingw > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', >tasn1, crypto], > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', > 'pkix_asn

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > Disable following tests on msys2/mingw > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', >tasn1, crypto], > 'test-crypto-tlssession': ['crypto-tls-x509-hel

Re: [PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw

2020-09-09 Thread Thomas Huth
On 08/09/2020 21.48, Yonggang Luo wrote: > The vmstate are valid on win32, just need generate tmp path properly > > Signed-off-by: Yonggang Luo > Reviewed-by: Philippe Mathieu-Daudé > --- > tests/test-vmstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test

Re: [PATCH v4 5/7] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-09-09 Thread Dima Stepanov
On Tue, Sep 08, 2020 at 11:03:56PM -0400, Raphael Norwitz wrote: > On Fri, Sep 4, 2020 at 5:35 AM Dima Stepanov wrote: > > > > Add vhost_user_ops structure for the vhost-user-blk device class. Add > > the test_reconnect and test_migrate tests for this device. > > > > Signed-off-by: Dima Stepanov

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

2020-09-09 Thread Thomas Huth
On 08/09/2020 21.48, Yonggang Luo wrote: > freebsd 1 hour limit not hit anymore Why is this faster again? How long did the build take for you? If it's still close to 1h, I think we should keep the two jobs, to avoid that it is occasionally failing when the builder machines are a little bit slower.

Re: [PATCH v4 6/9] scsi/scsi-bus: scsi_device_find: don't return unrealized devices

2020-09-09 Thread Maxim Levitsky
On Tue, 2020-09-08 at 16:00 +0100, Stefan Hajnoczi wrote: > On Mon, Aug 31, 2020 at 06:01:21PM +0300, Maxim Levitsky wrote: > > The device core first places a device on the bus and then realizes it. > > Make scsi_device_find avoid returing such devices to avoid > > races in drivers that use an ioth

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > Disable following tests on msys2/mingw > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', > >tasn1

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 03:48:18AM +0800, Yonggang Luo wrote: > freebsd 1 hour limit not hit anymore How long does the combined job take with this change ? If it is within 10 minutes of the limit, then we still want the split, as transient changes in the CI system can push it over the limit making

Re: [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c

2020-09-09 Thread Kevin Wolf
Am 08.09.2020 um 21:48 hat Yonggang Luo geschrieben: > Signed-off-by: Yonggang Luo > --- > block/file-win32.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) This is almost the same as my separately posted 'file-win32: Fix "locking" option', except that you chang

[PATCH] pci: advertise a page aligned ATS

2020-09-09 Thread Jason Wang
After Linux kernel commit 61363c1474b1 ("iommu/vt-d: Enable ATS only if the device uses page aligned address."), ATS will be only enabled if device advertises a page aligned request. Unfortunately, vhost-net is the only user and we don't advertise the aligned request capability in the past since b

Re: [PATCH v4 9/9] scsi/scsi_bus: fix races in REPORT LUNS

2020-09-09 Thread Maxim Levitsky
On Tue, 2020-09-08 at 16:27 +0100, Stefan Hajnoczi wrote: > On Mon, Aug 31, 2020 at 06:01:24PM +0300, Maxim Levitsky wrote: > > Currently scsi_target_emulate_report_luns iterates > > over child devices list twice, and there is guarantee, that > > it will not be changed meanwhile. > > > > This reas

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Laszlo Ersek
On 09/08/20 18:54, Daniel P. Berrangé wrote: > Some applications want to pass quite large values for the OEM strings > entries. Rather than having huge strings on the command line, it would > be better to load them from a file, as supported with -fw_cfg. > > This introduces the "valuefile" paramet

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > > Disable following tests on msys2/mingw > > > 'test-crypto-tlscredsx509': ['crypto-tls-x50

Re: [PATCH 07/16] tests: Trying fixes test-replication.c on msys2/mingw.

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 03:48:11AM +0800, Yonggang Luo wrote: > On Windows there is no path like /tmp/s_local_disk.XX > > Signed-off-by: Yonggang Luo > --- > tests/test-replication.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/tests/test-replicatio

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:17 PM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 03:48:18AM +0800, Yonggang Luo wrote: > > freebsd 1 hour limit not hit anymore > > How long does the combined job take with this change ? If it is > within 10 minutes of the limit, then we still want the split, as

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Laszlo Ersek
On 09/08/20 18:54, Daniel P. Berrangé wrote: > Some applications want to pass quite large values for the OEM strings > entries. Rather than having huge strings on the command line, it would > be better to load them from a file, as supported with -fw_cfg. > > This introduces the "valuefile" paramet

Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 03:48:10AM +0800, Yonggang Luo wrote: > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be > updated. > There is no need of --cross-prefix, open mingw64.

Re: [PATCH 5/5] hw/i386: expose a "smbios_ep" PC machine property

2020-09-09 Thread Laszlo Ersek
On 09/08/20 18:54, Daniel P. Berrangé wrote: > The i440fx and Q35 machine types are both hardcoded to use the legacy > SMBIOS 2.1 entry point. This is a sensible conservative choice because > SeaBIOS only supports SMBIOS 2.1 > > EDK2, however, can also support SMBIOS 3.0 and QEMU already uses this

Re: [PATCH v4 1/2] logging: Fixes memory leak in test-logging.c

2020-09-09 Thread Stefan Hajnoczi
On Tue, Sep 08, 2020 at 11:10:51PM +0800, Yonggang Luo wrote: > g_dir_make_tmp Returns the actual name used. This string should be > freed with g_free() when not needed any longer and is is in the GLib > file name encoding. In case of errors, NULL is returned and error will > be set. Use g_autofree

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:22 PM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé > > wrote: > > > > > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > > > Disable following tests o

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/9/20 9:35 AM, Daniel P. Berrangé wrote: > On Tue, Sep 08, 2020 at 08:24:35PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 9/8/20 6:54 PM, Daniel P. Berrangé wrote: >>> Some applications want to pass quite large values for the OEM strings >>> entries. Rather than having huge stri

Re: [PATCH v4 1/2] logging: Fixes memory leak in test-logging.c

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:30 PM Stefan Hajnoczi wrote: > On Tue, Sep 08, 2020 at 11:10:51PM +0800, Yonggang Luo wrote: > > g_dir_make_tmp Returns the actual name used. This string should be > > freed with g_free() when not needed any longer and is is in the GLib > > file name encoding. In case of

Re: [PATCH v2 10/12] target/arm/cpu: spe: Enable spe to work with host cpu

2020-09-09 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:33, Andrew Jones wrote: > > On Tue, Sep 08, 2020 at 08:13:28AM +, Haibo Xu wrote: > > Turn on the spe cpu property by default if host cpu > > support it, i.e. we can now do '-cpu max|host' to add > > the vSPE, and '-cpu max|host,spe=off' to remove it. > > > > Signed-of

[PATCH 1/2] hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw

2020-09-09 Thread Dov Murik
Fix compiler error about defined but not used functions when compiling with -DHPET_DEBUG by deleting the unused debug functions hpet_ram_readb and hpet_ram_readw. Signed-off-by: Dov Murik --- hw/timer/hpet.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/hw/timer/hpet.c b/hw/

[PATCH 2/2] hw/timer/hpet: Fix debug format strings

2020-09-09 Thread Dov Murik
Fix compiler errors when compiling with -DHPET_DEBUG due to mismatch between format string token "%x" and the argument type uint64_t. Also "%#x" is replaced by "0x%" PRIx64 according to the coding style. Signed-off-by: Dov Murik --- hw/timer/hpet.c | 13 +++-- 1 file changed, 7 insertio

Re: [RFC PATCH v5 2/4] util/vfio-helpers: Report error when IOMMU page size is not supported

2020-09-09 Thread Fam Zheng
On 2020-09-08 20:03, Philippe Mathieu-Daudé wrote: > This driver uses the host page size to align its memory regions, > but this size is not always compatible with the IOMMU. Add a > check if the size matches, and bails out with listing the sizes > the IOMMU supports. > > Example on Aarch64: > >

[PATCH 0/2] hw/timer/hpet: Fix compiler errors with -DHPET_DEBUG

2020-09-09 Thread Dov Murik
Fix several compiler errors when compiling withe -DHPET_DEBUG. Steps to reproduce the issue: mkdir build cd build ../configure --target-list=x86_64-softmmu --extra-cflags=-DHPET_DEBUG make Dov Murik (2): hw/timer/hpet: Remove unused functions hpet_ram_readb, hpet_ram_readw hw

Re: [PATCH 1/9] vhost-vdpa: remove the default devname

2020-09-09 Thread Laurent Vivier
On 31/08/2020 10:27, Jason Wang wrote: > The code doesn't have a default vhostdev, so remove the default > description in net.json. > > Signed-off-by: Jason Wang > --- > qapi/net.json | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qapi/net.json b/qapi/net.json > index ddb113e5e5..a2a94

Re: [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:19 PM Kevin Wolf wrote: > Am 08.09.2020 um 21:48 hat Yonggang Luo geschrieben: > > Signed-off-by: Yonggang Luo > > --- > > block/file-win32.c | 23 +-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > This is almost the same as my separately

Re: [PATCH v4 2/2] rcu: add uninit destructor for rcu

2020-09-09 Thread Stefan Hajnoczi
On Tue, Sep 08, 2020 at 11:10:52PM +0800, Yonggang Luo wrote: > This is necessary if the pending rcu calls are closing and removing > temp files. This also provide a function > void rcu_wait_finished(void); > to fixes test-logging.c test failure on msys2/mingw. > On windows if the file doesn't clo

Re: [PATCH 2/9] vhost-vdpa: mandate vhostdev

2020-09-09 Thread Laurent Vivier
On 31/08/2020 10:27, Jason Wang wrote: > vhost-dev is mandatory for vhost-vdpa to be initialized otherwise > net_vhost_vdpa_init will pass an uninitialized pointer to qemu_open() > which will lead a SIGSEV: > > #0 0x55c3a640 in strstart (str=str@entry=0x0, > val=val@entry=0x55dbcb65

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 04:30:26PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:22 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > > > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé > > > wrote: > > > > > > > On Wed, Sep

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 04:24:00PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:17 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:18AM +0800, Yonggang Luo wrote: > > > freebsd 1 hour limit not hit anymore > > > > How long does the combined job take with this chan

Re: [RFC PATCH v5 4/4] block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

2020-09-09 Thread Fam Zheng
On 2020-09-08 20:03, Philippe Mathieu-Daudé wrote: > Instead of initializing one MSIX IRQ with the generic > qemu_vfio_pci_init_irq() function, use the MSIX specific one which > ill allow us to use multiple IRQs. For now we provide an array of s/ill/will/ > a single IRQ. > > Signed-off-by: Phili

Re: [RFC PATCH v5 0/4] util/vfio-helpers: Add support for multiple IRQs

2020-09-09 Thread Fam Zheng
On 2020-09-08 20:03, Philippe Mathieu-Daudé wrote: > This series intends to setup the VFIO helper to allow > binding notifiers on different IRQs. > > For the NVMe use case, we only care about MSIX interrupts. > To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs > function to in

Re: [PATCH 2/2] vhost-vdpa: improve error reporting

2020-09-09 Thread Laurent Vivier
On 09/09/2020 03:53, Jason Wang wrote: > > On 2020/9/4 上午2:53, Laurent Vivier wrote: >> Use Error framework to report the id of the device and the details of >> the error (vhostdev name and errno). >> >> For instance: >> >>   qemu-system-x86_64 ... -netdev vhost-vdpa,id=hostnet1 ... >>   hostnet1:

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 09:54:40 +0200 Christian Borntraeger wrote: > On 16.07.20 14:02, Cornelia Huck wrote: > > On Wed, 15 Jul 2020 12:26:20 -0400 > > Collin Walling wrote: > > > >> On 7/15/20 12:04 PM, Cornelia Huck wrote: > >>> On Wed, 15 Jul 2020 11:36:35 -0400 > >>> Collin Walling wrote:

Re: [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c

2020-09-09 Thread Kevin Wolf
Am 09.09.2020 um 10:41 hat 罗勇刚(Yonggang Luo) geschrieben: > On Wed, Sep 9, 2020 at 4:19 PM Kevin Wolf wrote: > > > Am 08.09.2020 um 21:48 hat Yonggang Luo geschrieben: > > > Signed-off-by: Yonggang Luo > > > --- > > > block/file-win32.c | 23 +-- > > > 1 file changed, 21 ins

Re: [PATCH 3/4] docs: add qemu-storage-daemon(1) man page

2020-09-09 Thread Stefan Hajnoczi
On Tue, Sep 08, 2020 at 04:33:47PM +0200, Kevin Wolf wrote: > Am 08.09.2020 um 13:42 hat Kashyap Chamarthy geschrieben: > > On Tue, Sep 08, 2020 at 10:31:12AM +0100, Stefan Hajnoczi wrote: > > > Document the qemu-storage-daemon tool. Most of the command-line options > > > are identical to their QEM

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 10:18:47AM +0200, Laszlo Ersek wrote: > On 09/08/20 18:54, Daniel P. Berrangé wrote: > > Some applications want to pass quite large values for the OEM strings > > entries. Rather than having huge strings on the command line, it would > > be better to load them from a file, a

Re: [PATCH v4 2/2] rcu: add uninit destructor for rcu

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:41 PM Stefan Hajnoczi wrote: > On Tue, Sep 08, 2020 at 11:10:52PM +0800, Yonggang Luo wrote: > > This is necessary if the pending rcu calls are closing and removing > > temp files. This also provide a function > > void rcu_wait_finished(void); > > to fixes test-logging.c

[PATCH] MAINTAINERS: add Paolo Bonzini as RCU maintainer

2020-09-09 Thread Stefan Hajnoczi
The RCU code that Paolo maintains is missing a MAINTAINERS file entry. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7d0a5e91e4..50296caac4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2291,6 +2291,14

Re: [PATCH 1/5] hw/smbios: support loading OEM strings values from a file

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 10:18:47AM +0200, Laszlo Ersek wrote: > On 09/08/20 18:54, Daniel P. Berrangé wrote: > > Some applications want to pass quite large values for the OEM strings > > entries. Rather than having huge strings on the command line, it would > > be better to load them from a file, a

Re: Should we apply for GitLab's open source program?

2020-09-09 Thread Stefan Hajnoczi
On Fri, Sep 04, 2020 at 04:35:34PM +0100, Alex Bennée wrote: > Given our growing reliance on GitLab and the recent announcement about > free tier minutes: > > https://about.gitlab.com/pricing/faq-consumption-cicd/ > > is it time we officially apply for GitLab's Open Source Program: > > https

Re: [PATCH] MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer

2020-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2020 at 12:16:32PM +0100, Stefan Hajnoczi wrote: > Development of the userspace NVMe block driver picked up again recently. > After talking with Fam I am stepping up as block/nvme.c maintainer. > Patches will be merged through my 'block' tree. > > Cc: Kevin Wolf > Cc: Klaus Jensen

Re: [PATCH v4 1/7] vhost: recheck dev state in the vhost_migration_log routine

2020-09-09 Thread Stefan Hajnoczi
On Fri, Sep 04, 2020 at 12:31:13PM +0300, Dima Stepanov wrote: > vhost-user devices can get a disconnect in the middle of the VHOST-USER > handshake on the migration start. If disconnect event happened right > before sending next VHOST-USER command, then the vhost_dev_set_log() > call in the vhost_

Re: [RFC PATCH 00/12] hw: Forbid DMA write accesses to MMIO regions

2020-09-09 Thread Stefan Hajnoczi
On Thu, Sep 03, 2020 at 01:08:19PM +0200, Philippe Mathieu-Daudé wrote: > The main patch is: > "exec/memattrs: Introduce MemTxAttrs::direct_access field". > This way we can restrict accesses to ROM/RAM by setting the > 'direct_access' field. Illegal accesses return MEMTX_BUS_ERROR. QEMU needs to s

Re: [PATCH v2 0/2] MTE support for KVM guest

2020-09-09 Thread Steven Price
On 07/09/2020 16:28, Dr. David Alan Gilbert wrote: (cc'ing in Eric Auger) * Steven Price (steven.pr...@arm.com) wrote: Arm's Memory Tagging Extension (MTE) adds 4 bits of tag data to every 16 bytes of memory in the system. This along with stashing a tag within the high bit of virtual addresses

Re: [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-09 Thread Andrew Jones
On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote: > > > + > > > +if (spe) { > > > +assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON); > > > +if (kvm_irqchip_in_kernel()) { > > > +kvm_arm_spe_set_irq(cpu, PPI(VIRTUAL_SPE_IRQ)); >

Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus

2020-09-09 Thread Yonggang Luo
On Wed, Sep 9, 2020 at 4:27 PM Daniel P. Berrangé wrote: > On Wed, Sep 09, 2020 at 03:48:10AM +0800, Yonggang Luo wrote: > > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be

Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 05:36:49PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:27 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:10AM +0800, Yonggang Luo wrote: > > > Install msys2 in a proper way refer to > > https://github.com/cirruslabs/cirrus-ci-docs/issues/

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 10:46:23 +0200 Cornelia Huck wrote: > On Wed, 9 Sep 2020 09:54:40 +0200 > Christian Borntraeger wrote: > > > On 16.07.20 14:02, Cornelia Huck wrote: > > > On Wed, 15 Jul 2020 12:26:20 -0400 > > > Collin Walling wrote: > > > > > >> On 7/15/20 12:04 PM, Cornelia Huck wr

Re: [PATCH 0/5] Add support for loading SMBIOS OEM strings from a file

2020-09-09 Thread Laszlo Ersek
On 09/08/20 18:54, Daniel P. Berrangé wrote: > I previously added support for SMBIOS OEM strings tables but only > allowed for data to be passed inline. Potential users indicated they > wanted to pass some quite large data blobs which is inconvenient todo > inline. Thus I'm adding support for passi

[PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

2020-09-09 Thread Yonggang Luo
These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c: I

[PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32

2020-09-09 Thread Yonggang Luo
These tests are blocking test-char to be finished. Merge three #ifndef _WIN32 Signed-off-by: Yonggang Luo --- tests/test-char.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-char.c b/tests/test-char.c index d35cc839bc..ab037647bf 100644 --- a/tests/test-c

[PATCH v2 00/21] W32, W64 msys2/mingw patches

2020-09-09 Thread Yonggang Luo
It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and disable partial test-char tests. And then fixes all unit tests failure on msys2/mingw Yonggang Luo (21): block: Fixes nfs compiling error on msys2/mingw ci: fixes msys2 build by upgrading capstone to 4.0.2 configure: Fi

[PATCH v2 10/21] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-09 Thread Yonggang Luo
On windows, a difference in line endings causes testsuite failures complaining that every single line in files such as 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Signed-off-by: Yonggang Luo Reviewed-by: Eric Blake --- tests/qapi-schema/meson.build | 2 +- 1 file ch

[PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw.

2020-09-09 Thread Yonggang Luo
They cause failure on msys2/mingw, that's because file-win32.c not implement .bdrv_reopen_prepare/commit/abort yet. > $ ./tests/test-replication.exe > # random seed: R02S3f4d1c01af2b0a046990e0235c481faf > 1..13 > # Start of replication tests > # Start of primary tests > ok 1 /replication/primary/r

[PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-09 Thread Yonggang Luo
The mingw pkg-config are showing following absolute path and contains : as the separator, so we must handling : properly. -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw: -DNCURSES_WIDECHAR -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=

[PATCH v2 12/21] meson: remove empty else and duplicated gio deps

2020-09-09 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index 5421eca66a..0b1741557d 100644 --- a/meson.build +++ b/meson.build @@ -317,7 +317,6 @@ opengl = not_found if 'CONFIG_OPENGL' in config_host opengl = declare_depe

[PATCH v2 02/21] ci: fixes msys2 build by upgrading capstone to 4.0.2

2020-09-09 Thread Yonggang Luo
The currently random version capstone have the following compiling issue: CC /c/work/xemu/qemu/build/slirp/src/arp_table.o make[1]: *** No rule to make target “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1 are the tagged v

[PATCH v2 06/21] ci: Enable msys2 ci in cirrus

2020-09-09 Thread Yonggang Luo
Install msys2 in a proper way refer to https://github.com/cirruslabs/cirrus-ci-docs/issues/699 The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be updated. There is no need of --cross-prefix, open mingw64.exe instead of msys2.exe then we don't need the --cross-prefix, besides

[PATCH v2 09/21] osdep: These function are only available on Non-Win32 system.

2020-09-09 Thread Yonggang Luo
int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); int qemu_unlock_fd(int fd, int64_t start, int64_t len); int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); bool qemu_has_ofd_lock(void); Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 2 +- 1 fi

[PATCH v2 04/21] curses: Fixes curses compiling errors.

2020-09-09 Thread Yonggang Luo
This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~

[PATCH v2 16/21] rcu: add uninit destructor for rcu

2020-09-09 Thread Yonggang Luo
This is necessary if the pending rcu calls are closing and removing temp files. This also provide a function void rcu_wait_finished(void); to fixes test-logging.c test failure on msys2/mingw. On windows if the file doesn't closed, you can not remove it. Signed-off-by: Yonggang Luo --- include/q

[PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw.

2020-09-09 Thread Yonggang Luo
On Windows there is no path like /tmp/s_local_disk.XX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo --- tests/test-replication.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c b/tests/test-replication.c index

[PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw

2020-09-09 Thread Yonggang Luo
The vmstate are valid on win32, just need generate tmp path properly Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- tests/test-vmstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c

[PATCH v2 17/21] tests: Fixes test-io-channel-socket.c tests under msys2/mingw

2020-09-09 Thread Yonggang Luo
Currently test-io-channel-socket doesn't init with qemu_init_main_loop and that's cause the qemu_aio_context not inited, and the following is the stack when null pointer accessed: qemu_fd_register (c:\work\xemu\qemu\util\main-loop.c:336) qemu_try_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:

[PATCH v2 11/21] meson: disable crypto tests are empty under win32

2020-09-09 Thread Yonggang Luo
Disable following tests on msys2/mingw 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', tasn1, crypto], 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c',

[PATCH v2 15/21] tests: Convert g_free to g_autofree macro in test-logging.c

2020-09-09 Thread Yonggang Luo
g_autofree are prefer than g_free when possible. Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé --- tests/test-logging.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index 8a1161de1d..783fe09a27 100644 --- a/t

[PATCH v2 14/21] cirrus: Building freebsd in a single short

2020-09-09 Thread Yonggang Luo
freebsd 1 hour limit not hit anymore Signed-off-by: Yonggang Luo --- .cirrus.yml | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 49335e68c9..b0004273bb 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,38 +1,

[PATCH v2 21/21] tests: Fixes test-qdev-global-props.c

2020-09-09 Thread Yonggang Luo
On win32 the line ending are \r\n, so we skip the \n in function test_dynamic_globalprop Signed-off-by: Yonggang Luo --- tests/test-qdev-global-props.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index

[PATCH v2 19/21] tests: Fixes test-io-channel-file by mask only owner file state mask bits

2020-09-09 Thread Yonggang Luo
This is the error on msys2/mingw Running test test-io-channel-file ** ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) ERROR test-io-channel-file - Bail out! ERROR:../tests/test-io-channel-file.c:59:test_

[PATCH v2 18/21] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c

2020-09-09 Thread Yonggang Luo
This is a fixes for (C:\work\xemu\qemu\build\tests\test-aio-multithread.exe:19100): GLib-CRITICAL **: 23:03:24.965: g_source_remove_poll: assertion '!SOURCE_DESTROYED (source)' failed ERROR test-aio-multithread - Bail out! GLib-FATAL-CRITICAL: g_source_remove_poll: assertion '!SOURCE_DESTROYED (

Re: [PATCH 0/5] Add support for loading SMBIOS OEM strings from a file

2020-09-09 Thread Daniel P . Berrangé
On Wed, Sep 09, 2020 at 11:44:40AM +0200, Laszlo Ersek wrote: > On 09/08/20 18:54, Daniel P. Berrangé wrote: > > I previously added support for SMBIOS OEM strings tables but only > > allowed for data to be passed inline. Potential users indicated they > > wanted to pass some quite large data blobs

[PATCH v2 20/21] tests: fix test-util-sockets.c

2020-09-09 Thread Yonggang Luo
Fixes following errors: Running test test-util-sockets ERROR test-util-sockets - missing test plan # Start of name tests ** ERROR:../tests/test-util-sockets.c:93:test_socket_fd_pass_name_good: assertion failed (fd != -1): (-1 != -1) Bail out! ERROR:../tests/test-util-sockets.c:93:test_socket_fd_p

Re: [PATCH] tests/socket-helpers: Treat EAI_NONAME as EADDRNOTAVAIL

2020-09-09 Thread Daniel P . Berrangé
On Tue, Sep 08, 2020 at 02:15:43PM +0200, Thomas Huth wrote: > The tests/test-char test is currently always failing on my system since > the getaddrinfo() in socket_can_bind_connect() returns EAI_NONAME when > it is called from socket_check_protocol_support() to check for IPv6. > socket_check_proto

Re: [PATCH] hw/s390x/css: Remove double initialization

2020-09-09 Thread Cornelia Huck
On Mon, 7 Sep 2020 04:40:20 +0200 Philippe Mathieu-Daudé wrote: > Fix eventual copy/paste mistake introduced in commit bc994b74ea > ("s390x/css: Use static initialization for channel_subsys fields"). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/s390x/css.c | 1 - > 1 file changed, 1 d

[PATCH v3 14/21] cirrus: Building freebsd in a single short

2020-09-09 Thread Yonggang Luo
freebsd 1 hour limit not hit anymore I think we going to a wrong direction, I think there is some tests a stall the test runner, please look at https://cirrus-ci.com/task/5110577531977728 When its running properly, the consumed time are little, but when tests running too long, look at the cpu u

Re: [PATCH v3 5/8] meson: use meson datadir instead of qemu_datadir

2020-09-09 Thread Marc-André Lureau
Hi On Wed, Sep 9, 2020 at 1:51 PM Miroslav Rezanina wrote: > > On Wed, Aug 26, 2020 at 03:04:16PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > When cross-compiling, by default qemu_datadir is 'c:\Program > > Files\QEMU', which is not recognized as being an absolu

[PATCH 0/3] gitmodules: add qboot, meson, and vbootrom mirrors

2020-09-09 Thread Stefan Hajnoczi
This patch series adds qemu.org mirrors for qboot, meson, and vbootrom. vbootrom is not yet used by qemu.git/master so you may wish to hold off on applying the final patch. Stefan Hajnoczi (3): gitmodules: switch to qemu.org qboot mirror gitmodules: switch to qemu.org meson mirror gitmodule

[PATCH 1/3] gitmodules: switch to qemu.org qboot mirror

2020-09-09 Thread Stefan Hajnoczi
QEMU now hosts a mirror of qboot.git. QEMU mirrors third-party code to ensure that users can always build QEMU even if the dependency goes offline and so QEMU meets its responsibilities to provide full source code under software licenses. Suggested-by: Peter Maydell Cc: Paolo Bonzini Signed-off-

[PATCH 3/3] gitmodules: add qemu.org vbootrom submodule

2020-09-09 Thread Stefan Hajnoczi
The vbootrom module is needed for the new NPCM7xx ARM SoCs. The vbootrom.git repo is now mirrored on qemu.org. QEMU mirrors third-party code to ensure that users can always build QEMU even if the dependency goes offline and so QEMU meets its responsibilities to provide full source code under softwa

[PATCH 2/3] gitmodules: switch to qemu.org meson mirror

2020-09-09 Thread Stefan Hajnoczi
QEMU now hosts a mirror of meson.git. QEMU mirrors third-party code to ensure that users can always build QEMU even if the dependency goes offline and so QEMU meets its responsibilities to provide full source code under software licenses. Suggested-by: Peter Maydell Cc: Marc-André Lureau Cc: Pao

  1   2   3   4   >