On Tue, Sep 08, 2020 at 02:15:43PM +0200, Thomas Huth wrote: > The tests/test-char test is currently always failing on my system since > the getaddrinfo() in socket_can_bind_connect() returns EAI_NONAME when > it is called from socket_check_protocol_support() to check for IPv6. > socket_check_protocol_support() then returns -1 and thus the tests are > not run at all - even though IPv4 is working fine. > socket_can_bind_connect() connect should return EADDRNOTAVAIL in this > case instead, so that socket_check_protocol_support() does not fail. > > Suggested-by: Daniel P. Berrangé <berra...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > tests/socket-helpers.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
