[PULL 14/14] iotests: Test node/bitmap aliases during migration

From: Max Reitz Signed-off-by: Max Reitz Message-Id: <20200820150725.68687-4-mre...@redhat.com> Reviewed-by: Eric Blake Tested-by: Eric Blake [eblake: fold in python cleanups recommended by Vladimir] Signed-off-by: Eric Blake --- tests/qemu-iotests/300 | 593 +

[PATCH v5 00/10] preallocate filter

Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where allocation is relatively expensive operation. We have to workaround it in Qemu, so here is a new filter. v5: rewrite patch 08 as Nir suggested v4: 01-04

[PULL 09/14] qcow2_format.py: collect fields to dump in JSON format

From: Andrey Shinkevich As __dict__ is being extended with class members we do not want to print, add the to_json() method to classes that returns a json-dumpable object with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON output whi

[PATCH v5 03/10] block/io: split out bdrv_find_conflicting_request

To be reused in separate. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- block/io.c | 71 +++--- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/block/io.c b/block/io.c index b18680a842..5b96715058 100

[PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately. It's will be used in upcoming preallocate filter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 9 - block/io.c| 11 ++- 2 files

[PATCH v5 02/10] block/io.c: drop assertion on double waiting for request serialisation

The comments states, that on misaligned request we should have already been waiting. But for bdrv_padding_rmw_read, we called bdrv_mark_request_serialising with align = request_alignment, and now we serialise with align = cluster_size. So we may have to wait again with larger alignment. Note, that

[PULL 08/14] qcow2.py: Introduce '-j' key to dump in JSON format

From: Andrey Shinkevich Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Og

[PATCH v5 07/10] block: introduce preallocate filter

It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems with slow allocation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/system/qemu-block-drivers.rst.inc |

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

On 8/21/20 4:08 PM, Daniel Henrique Barboza wrote: > > > On 8/21/20 8:08 AM, Philippe Mathieu-Daudé wrote: >> Cc'ing Markus >> >> On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: >>> We do not implement hotplug in the vscsi bus, but we forgot to >>> tell qdev about it. The result is that users

[PATCH v5 04/10] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg

bs is linked in req, so no needs to pass it separately. Most of tracked-requests API doesn't have bs argument. Actually, after this patch only tracked_request_begin has it, but it's for purpose. While being here, also add a comment about what "_locked" is. Signed-off-by: Vladimir Sementsov-Ogievs

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

On Thu, Aug 20, 2020 at 10:28:00AM +0800, Jason Wang wrote: > > On 2020/8/19 下午11:50, Peter Xu wrote: > > On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > > > Yes, actually, I feel confused after reading the codes. Is notifier->start > > > IOVA or GPA? > > > > > > In vfio.c, we did:

[PATCH v5 08/10] iotests.py: add verify_o_direct helper

Add python notrun-helper similar to _check_o_direct for bash tests. To be used in the following commit. Suggested-by: Nir Soffer Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 12 1 file changed, 12 insertions(+) diff --git a/tests/qemu-iotests/iot

[PULL 13/14] iotests.py: Let wait_migration() return on failure

From: Max Reitz Let wait_migration() return on failure (with the return value indicating whether the migration was completed or has failed), so we can use it for migrations that are expected to fail, too. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievski

[PATCH v5 09/10] iotests.py: add filter_img_check

Add analog of bash _filter_qemu_img_check to python framework. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 7

[PATCH v5 10/10] iotests: add 298 to test new preallocate filter driver

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/298 | 50 ++ tests/qemu-iotests/298.out | 6 + tests/qemu-iotests/group | 1 + 3 files changed, 57 insertions(+) create mode 100644 tests/qemu-iotests/

[PATCH v5 05/10] block: bdrv_mark_request_serialising: split non-waiting function

We'll need a separate function, which will only "mark" request serialising with specified align but not wait for conflicting requests. So, it will be like old bdrv_mark_request_serialising(), before merging bdrv_wait_serialising_requests_locked() into it. To reduce the possible mess, let's do the

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

Hi Bin, On 8/21/20 2:54 AM, Bin Meng wrote: > Hi Philippe, > > On Fri, Aug 21, 2020 at 2:04 AM Philippe Mathieu-Daudé > wrote: >> >> Hi Sai Pavan, you said you were interested to test the first 2 >> patches. FYI I plan to queue them and send the pull request tomorrow >> or Saturday the latest.

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

Hi Philippe, On Fri, Aug 21, 2020 at 10:21 PM Philippe Mathieu-Daudé wrote: > > Hi Bin, > > On 8/21/20 2:54 AM, Bin Meng wrote: > > Hi Philippe, > > > > On Fri, Aug 21, 2020 at 2:04 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Sai Pavan, you said you were interested to test the first 2 > >

Re: [PATCH 0/7] hw/sd: Use sdbus_read_data/sdbus_write_data for multiple bytes access

On 8/14/20 11:23 AM, Philippe Mathieu-Daudé wrote: > Introduce sdbus_read_data() and sdbus_write_data() methods to > access multiple bytes on the data line of a SD bus. > > I haven't named then sdbus_access_block() because I expect a > block to be a power of 2, while there is no such restriction >

Re: ANNOUNCE: build system conversion to Meson has landed

On 8/21/20 8:49 AM, Peter Maydell wrote: Hi; we've just merged Paolo's patchset that converts the build system to use Meson. This should mostly be fairly seamless for the average developer (we hope) but there are a few things to be aware of: * you probably want to do a distclean or otherwise d

[PATCH v3 1/2] hw/sd: sd: Fix incorrect populated function switch status data structure

From: Bin Meng At present the function switch status data structure bit [399:376] are wrongly pupulated. These 3 bytes encode function switch status for the 6 function groups, with 4 bits per group, starting from function group 6 at bit 399, then followed by function group 5 at bit 395, and so on

[PATCH v3 2/2] hw/sd: sd: Correct the maximum size of a Standard Capacity SD Memory Card

From: Bin Meng Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports capacity up to and including 2 GiB. Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Sai Pavan Boddu --- Changes in v3: - add Reviewed-

Re: [PATCH 1/1] spapr_vscsi: do not allow device hotplug

On 8/21/20 11:12 AM, Philippe Mathieu-Daudé wrote: On 8/21/20 4:08 PM, Daniel Henrique Barboza wrote: On 8/21/20 8:08 AM, Philippe Mathieu-Daudé wrote: Cc'ing Markus On 8/20/20 9:06 PM, Daniel Henrique Barboza wrote: We do not implement hotplug in the vscsi bus, but we forgot to tell qde

Re: ANNOUNCE: build system conversion to Meson has landed

On 08/21/20 15:49, Peter Maydell wrote: > https://wiki.qemu.org/Features/Meson/Next has a summary of changes > and is worth a quick scan through. I'd like to propose a wording clarification: """ For bisection: incremental builds work fine in the forward direction. They probably don't work at all

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

On Fri, 21 Aug 2020 11:14:41 +0800 Jason Wang wrote: > On 2020/8/20 下午8:27, Cornelia Huck wrote: > > On Wed, 19 Aug 2020 17:28:38 +0800 > > Jason Wang wrote: > > > >> On 2020/8/19 下午4:13, Yan Zhao wrote: > >>> On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: > On 2020/8/19

[PATCH] configure: silence 'shift' error message in version_ge()

If there are less than 2 arguments in version_ge(), the second shift prints this error: ../configure: line 232: shift: shift count out of range Let's shut it up, since we're expecting this situation. Signed-off-by: Stefano Garzarella --- configure | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: ANNOUNCE: build system conversion to Meson has landed

On 21/08/20 16:50, Laszlo Ersek wrote: > On 08/21/20 15:49, Peter Maydell wrote: > >> https://wiki.qemu.org/Features/Meson/Next has a summary of changes >> and is worth a quick scan through. > > I'd like to propose a wording clarification: > > """ > For bisection: incremental builds work fine in

[PATCH] meson: Fix --disable-tools --enable-system builds

Fixes: $ ../configure --disable-tools --disable-user ../tests/qemu-iotests/meson.build:7:0: ERROR: Unknown variable "qemu_block_tools". Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mes

Re: [PATCH] meson: Fix --disable-tools --enable-system builds

On 21/08/20 17:05, Philippe Mathieu-Daudé wrote: > Fixes: > > $ ../configure --disable-tools --disable-user > ../tests/qemu-iotests/meson.build:7:0: ERROR: Unknown variable > "qemu_block_tools". > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 3

Re: [PATCH] configure: silence 'shift' error message in version_ge()

On 21/08/20 17:00, Stefano Garzarella wrote: > If there are less than 2 arguments in version_ge(), the second shift > prints this error: > ../configure: line 232: shift: shift count out of range > > Let's shut it up, since we're expecting this situation. > > Signed-off-by: Stefano Garzarella

[PATCH] configure: Silence shift warning in version_ge()

As we might expect less than 2 argument, only shift again if there is arguments to shift. This fixes: ../configure: line 232: shift: shift count out of range Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/

QEMU | Pipeline #180588871 has failed for master | 7fd51e68

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 7fd51e68 ( https://gitlab.com/qemu-project/qemu/-/commit/7fd51e68c34fcefdb4d6fd646ed3346f780f89f4 ) Commit Message: Merge remote-tr

Re: [PATCH] configure: silence 'shift' error message in version_ge()

On Fri, 21 Aug 2020 at 16:00, Stefano Garzarella wrote: > > If there are less than 2 arguments in version_ge(), the second shift > prints this error: > ../configure: line 232: shift: shift count out of range > > Let's shut it up, since we're expecting this situation. > > Signed-off-by: Stefano

Re: recursive locks (in general)

On Freitag, 21. August 2020 15:08:09 CEST Paolo Bonzini wrote: > On 21/08/20 13:12, Christian Schoenebeck wrote: > > There is a golden rule with recursive locks: You always have to preserve a > > clear hierarchy. Say you have the following recursive mutexes: > > > > RecursiveMutex mutex0; > > Recu

Re: [PATCH] configure: silence 'shift' error message in version_ge()

On Fri, Aug 21, 2020 at 04:21:10PM +0100, Peter Maydell wrote: > On Fri, 21 Aug 2020 at 16:00, Stefano Garzarella wrote: > > > > If there are less than 2 arguments in version_ge(), the second shift > > prints this error: > > ../configure: line 232: shift: shift count out of range > > > > Let's

Re: [PATCH v7 37/47] qemu-img: Use child access functions

Am 25.06.2020 um 17:22 hat Max Reitz geschrieben: > This changes iotest 204's output, because blkdebug on top of a COW node > used to make qemu-img map disregard the rest of the backing chain (the > backing chain was broken by the filter). With this patch, the > allocation in the base image is rep

[PATCH] meson: Do not consider qemu-keymap a 'tool'

We need qemu-keymap to generate the keymaps. This fixes when configuring with --disable-tools: Compiling C object qemu-keymap.p/qemu-keymap.c.o Compiling C object qemu-keymap.p/ui_input-keymap.c.o Compiling C object qemu-edid.p/qemu-edid.c.o ../ui/input-keymap.c:7:49: fatal error: ui/inp

[PATCH v2] meson: Do not consider qemu-keymap a 'tool'

We need qemu-keymap to generate the keymaps. This fixes when configuring with --disable-tools: Compiling C object qemu-keymap.p/qemu-keymap.c.o Compiling C object qemu-keymap.p/ui_input-keymap.c.o Compiling C object qemu-edid.p/qemu-edid.c.o ../ui/input-keymap.c:7:49: fatal error: ui/inp

Re: [PULL 0/2] Acceptance testing patches for 2020-08-12

On Wed, 12 Aug 2020 at 14:19, Philippe Mathieu-Daudé wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags

[PATCH] util/meson.build: fix fdmon-io_uring build

libqemuutil.a build fails with this error: /usr/bin/ld: libqemuutil.a(util_fdmon-io_uring.c.o): in function `get_sqe': qemu/build/../util/fdmon-io_uring.c:83: undefined reference to `io_uring_get_sqe' /usr/bin/ld: qemu/build/../util/fdmon-io_uring.c:92: undefined reference to `io_uring_sub

Re: [PATCH v7 39/47] blockdev: Fix active commit choice

Am 25.06.2020 um 17:22 hat Max Reitz geschrieben: > We have to perform an active commit whenever the top node has a parent > that has taken the WRITE permission on it. > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > blockdev.c | 24 +--- > 1

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

On Fri 21 Aug 2020 02:59:44 PM CEST, Brian Foster wrote: >> > Option 4 is described above as initial file preallocation whereas >> > option 1 is per 64k cluster prealloc. Prealloc mode mixup aside, Berto >> > is reporting that the initial file preallocation mode is slower than >> > the per cluster

[PATCH] target/s390x: fix meson.build issue

files() is needed to avoid ../meson.build:977:2: ERROR: File tcg-stub.c does not exist. Signed-off-by: Paolo Bonzini --- target/s390x/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/meson.build b/target/s390x/meson.build index d2a3315903..c42eadb7d2

Re: [PATCH v1 1/2] microblaze: petalogix-ml605: Add device-tree source

On Thu, Aug 20, 2020 at 12:47 PM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add a device-tree source for petalogix-ml605 and recompile > the DTB. > > Signed-off-by: Edgar E. Iglesias Acked-by: Alistair Francis Alistair > --- > pc-bios/petalogix-ml605.dtb | Bin 9982 -> 9882 b

Re: [PATCH v1 2/2] microblaze: petalogix-s3adsp1800: Add device-tree source

On Thu, Aug 20, 2020 at 12:44 PM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add a device-tree source for petalogix-s3adsp1800 and > recompile the DTB. > > This also removes the unused mpmc node which causes > compilation warnings. > > Signed-off-by: Edgar E. Iglesias Acked-by: A

[PATCH v3 2/2] meson: Do not consider qemu-keymap a 'tool'

We need qemu-keymap to generate the keymaps. This fixes when configuring with --disable-tools: Compiling C object qemu-keymap.p/qemu-keymap.c.o Compiling C object qemu-keymap.p/ui_input-keymap.c.o Compiling C object qemu-edid.p/qemu-edid.c.o ../ui/input-keymap.c:7:49: fatal error: ui/inp

[PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini Tested-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- Makefile| 8 -- pc-bios/keymaps/Makefile| 56 - pc-bios/keymaps/m

[PATCH v3 0/2] meson: Build qemu-keymap when configured using --disable-tools

Fix --enable-system --disable-tools builds. Marc-André Lureau (1): meson: convert pc-bios/keymaps/Makefile Philippe Mathieu-Daudé (1): meson: Do not consider qemu-keymap a 'tool' Makefile| 8 -- meson.build | 11 pc-bios/keymaps/Makefile

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

On Thu 20 Aug 2020 11:58:11 PM CEST, Dave Chinner wrote: >> The virtual drive (/dev/vdb) is a freshly created qcow2 file stored on >> the host (on an xfs or ext4 filesystem as the table above shows), and >> it is attached to QEMU using a virtio-blk-pci device: >> >>-drive if=virtio,file=image.

Re: [PULL v7 000/151] Meson-based build system

> How are you executing ldd? I cross built a mingw executable from Fedora > and it was definitely using system DLLs. > > This is what I see in Fedora 32 before moving executable and dlls to Windows: [hsp@localhost build]$ uname -a Linux localhost.localdomain 5.7.14-200.fc32.x86_64 #1 SMP Fri Aug

Re: [PATCH] util/meson.build: fix fdmon-io_uring build

Hi Stefano, On 8/21/20 5:48 PM, Stefano Garzarella wrote: > libqemuutil.a build fails with this error: > > /usr/bin/ld: libqemuutil.a(util_fdmon-io_uring.c.o): in function `get_sqe': > qemu/build/../util/fdmon-io_uring.c:83: undefined reference to > `io_uring_get_sqe' > /usr/bin/ld: qemu/b

[PATCH] meson: convert pc-bios/keymaps/Makefile

From: Marc-André Lureau Note that sl and sv keymaps were not created by qemu-keymap. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 8 -- meson.build | 11 pc-bios/keymaps/.gitignore | 1 + pc-bios/keymaps/Makefi

Re: [PATCH] configure: Silence shift warning in version_ge()

On 8/21/20 5:14 PM, Philippe Mathieu-Daudé wrote: > As we might expect less than 2 argument, only shift again > if there is arguments to shift. > > This fixes: > > ../configure: line 232: shift: shift count out of range > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 2 +- >

Re: [PULL v7 000/151] Meson-based build system

On 21/08/20 18:11, Howard Spoelstra wrote: > > > Found ninjatool-1.8 at /home/hsp/src/qemu-master/build/ninjatool > WARNING: custom_target 'shared QAPI source files' has more than one > output! Using the first one. > WARNING: custom_target 'QGA QAPI files' has more than one output! Using > the fi

Re: [PATCH] configure: silence 'shift' error message in version_ge()

On 8/21/20 5:26 PM, Stefano Garzarella wrote: > On Fri, Aug 21, 2020 at 04:21:10PM +0100, Peter Maydell wrote: >> On Fri, 21 Aug 2020 at 16:00, Stefano Garzarella wrote: >>> >>> If there are less than 2 arguments in version_ge(), the second shift >>> prints this error: >>> ../configure: line 2

Re: Suspicious QOM types without instance/class size

On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > > T

Re: [PATCH] meson: convert pc-bios/keymaps/Makefile

On 8/21/20 6:14 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Note that sl and sv keymaps were not created by qemu-keymap. Ah this is the same content (without this note) that I sent split as 2 patches, series "meson: Build qemu-keymap when configured using --disable-tools". Whichever

Re: [PATCH] util/meson.build: fix fdmon-io_uring build

On Fri, Aug 21, 2020 at 06:12:45PM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefano, > > On 8/21/20 5:48 PM, Stefano Garzarella wrote: > > libqemuutil.a build fails with this error: > > > > /usr/bin/ld: libqemuutil.a(util_fdmon-io_uring.c.o): in function > > `get_sqe': > > qemu/build/../ut

Re: [PULL 00/14] Linux user for 5.2 patches

On Thu, 13 Aug 2020 at 07:51, Laurent Vivier wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-use

Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

Hi On Wed, Aug 19, 2020 at 7:52 AM Gerd Hoffmann wrote: > > Hi, > > > > > Have another small question. Do you know how force show cursor working > > > > in this case? > > > > > > Which display and which vga do you use? > > > > -vga std \ > > So stdvga (has no hardware cursor support). > > disp

Re: [PULL 00/24] target/xtensa updates for 5.2

On Thu, 13 Aug 2020 at 00:24, Max Filippov wrote: > > Hi Peter, > > please pull the following batch of updates for target/xtensa. > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available i

Re: [PULL 0/9] Tracing patches

On Thu, 13 Aug 2020 at 08:44, Stefan Hajnoczi wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/trac

Re: [PATCH] configure: silence 'shift' error message in version_ge()

On Fri, Aug 21, 2020 at 06:14:25PM +0200, Philippe Mathieu-Daudé wrote: > On 8/21/20 5:26 PM, Stefano Garzarella wrote: > > On Fri, Aug 21, 2020 at 04:21:10PM +0100, Peter Maydell wrote: > >> On Fri, 21 Aug 2020 at 16:00, Stefano Garzarella > >> wrote: > >>> > >>> If there are less than 2 argume

Re: [PULL v2 00/20] riscv-to-apply queue

On Fri, 14 Aug 2020 at 16:18, Alistair Francis wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

On Mon, Jul 27, 2020 at 04:08:37PM +0100, Daniel P. Berrangé wrote: > A followup to: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html snip > HELP NEEDED: this series starts to implement the approach that Kevin > suggested wrto use of generic jobs. > > When I try to

[PATCH 0/5] virtio-iommu: Built-in topology and x86 support

Add a topology description to the virtio-iommu config space, allowing to create a virtio-iommu device on platforms without device-tree. Our long-term plan is to add an ACPI table that describes this topology, but it will take a while to ratify. This built-in topology is needed anyway for platforms

[PATCH 1/5] virtio-iommu: Default to bypass during boot

When a virtio-iommu is present, we currently require the guest to configure it before it can use DMA in any other PCI device. This prevents, for example, a bootloader that doesn't know how to drive virtio-iommu from loading an OS from storage. Add the "boot-bypass" option, defaulting to true, to l

[PATCH 3/5] virtio-iommu: Declare topology in config space

When requested on the command-line, by adding topology=on to the virtio-iommu device, provide the IOMMU topology in the virtio config space. It describes which endpoints are managed by the IOMMU - all PCI devices - and allows to support: * virtio-iommu for platforms without ACPI or DT (e.g. microvm

[PATCH 5/5] hw/i386/pc: Add support for virtio-iommu-pci

From: Eric Auger The virtio-iommu-pci is instantiated through the -device QEMU option. Declare the [0xfee0 - 0xfeef] MSI reserved region so that it gets bypassed by the IOMMU. Signed-off-by: Eric Auger Signed-off-by: Jean-Philippe Brucker --- hw/i386/pc.c | 9 - 1 file changed

[PATCH 2/5] linux headers: Import virtio-iommu header from Linux

Import virtio-iommu topology definitions from Linux. These changes haven't been upstreamed yet. Signed-off-by: Jean-Philippe Brucker --- include/standard-headers/linux/virtio_iommu.h | 44 +++ 1 file changed, 44 insertions(+) diff --git a/include/standard-headers/linux/virtio_io

[PATCH 4/5] hw/arm/virt: Remove device-tree restriction on virtio-iommu

Now that the virtio-iommu has a built-in topology mechanism, it can be used without a device tree. Remove the restriction on !ACPI or !firmware. Signed-off-by: Jean-Philippe Brucker --- hw/arm/virt.c| 10 ++ hw/virtio/virtio-iommu-pci.c | 2 -- 2 files changed, 2 inserti

Re: Suspicious QOM types without instance/class size

On Fri, Aug 21, 2020 at 09:06:51AM -0700, Alistair Francis wrote: > On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost wrote: > > > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is n

[PATCH v2] configure: silence 'shift' error message in version_ge()

If there are less than 2 arguments in version_ge(), the second 'shift' prints this error: ../configure: line 232: shift: shift count out of range Let's skip it if there are no more arguments. Signed-off-by: Stefano Garzarella --- v2: - do not shift if there are no more arguments [Peter] ---

Re: [PATCH v2] configure: silence 'shift' error message in version_ge()

On 8/21/20 6:33 PM, Stefano Garzarella wrote: > If there are less than 2 arguments in version_ge(), the second > 'shift' prints this error: > ../configure: line 232: shift: shift count out of range > > Let's skip it if there are no more arguments. > > Signed-off-by: Stefano Garzarella > ---

Re: [PATCH] util/meson.build: fix fdmon-io_uring build

On 8/21/20 6:23 PM, Stefano Garzarella wrote: > On Fri, Aug 21, 2020 at 06:12:45PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Stefano, >> >> On 8/21/20 5:48 PM, Stefano Garzarella wrote: >>> libqemuutil.a build fails with this error: >>> >>> /usr/bin/ld: libqemuutil.a(util_fdmon-io_uring.c.o):

Re: [PATCH] util/meson.build: fix fdmon-io_uring build

On Fri, Aug 21, 2020 at 06:46:15PM +0200, Philippe Mathieu-Daudé wrote: > On 8/21/20 6:23 PM, Stefano Garzarella wrote: > > On Fri, Aug 21, 2020 at 06:12:45PM +0200, Philippe Mathieu-Daudé wrote: > >> Hi Stefano, > >> > >> On 8/21/20 5:48 PM, Stefano Garzarella wrote: > >>> libqemuutil.a build f

[PATCH V8] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. This feature is targetted mostly towards Windows VMs. I

[PATCH] tests/docker: add liburing-devel to the Fedora image

Install liburing-devel dependencies to get better coverage on io-uring stuff (block/io_uring.c and util/fdmon-io_uring.c). Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Stefano Garzarella --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

On Fri, Aug 21, 2020 at 02:12:32PM +0200, Alberto Garcia wrote: > On Fri 21 Aug 2020 01:42:52 PM CEST, Alberto Garcia wrote: > > On Fri 21 Aug 2020 01:05:06 PM CEST, Brian Foster > > wrote: > >>> > 1) off: for every write request QEMU initializes the cluster (64KB) > >>> > with fallocate(

[PATCH v4 0/6] block: improve error reporting for unsupported O_DIRECT

v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00589.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07098.html See patch commit messages for rationale Ideally we would convert other callers of

[PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

This simple refactoring prepares for future patches. The variadic args handling is split from the main bulk of the open logic. The duplicated calls to open() are removed in favour of updating the "flags" variable to have O_CLOEXEC. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 40

[PATCH v4 1/6] util: rename qemu_open() to qemu_open_old()

We want to introduce a new version of qemu_open() that uses an Error object for reporting problems and make this it the preferred interface. Rename the existing method to release the namespace for the new impl. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P.

[PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

Instead of relying on the limited information from errno, we can now also provide detailed error messages. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index 9ff92551e7..9

[PATCH v4 5/6] util: give a specific error message when O_DIRECT doesn't work

A common error scenario is to tell QEMU to use O_DIRECT in combination with a filesystem that doesn't support it. To aid users to diagnosing their mistake we want to provide a clear error message when this happens. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 13

[PATCH v4 4/6] util: introduce qemu_open and qemu_create with error reporting

qemu_open_old() works like open(): set errno and return -1 on failure. It has even more failure modes, though. Reporting the error clearly to users is basically impossible for many of them. Our standard cure for "errno is too coarse" is the Error object. Introduce two new helper methods: int q

[PATCH v4 6/6] block/fileb: switch to use qemu_open/qemu_create for improved errors

Currently at startup if using cache=none on a filesystem lacking O_DIRECT such as tmpfs, at startup QEMU prints qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not support O_DIRECT qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: Could not open '/tmp/foo.img': In

[PULL 01/23] hw/sd/pxa2xx_mmci: Do not create SD card within the SD host controller

SD/MMC host controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) The machine/board object is where the SD cards are created. Since the PXA2xx is not qdevified, for now create the cards in pxa270_init() which is the SoC model. In the future we will move this to t

[PULL 00/23] SD/MMC patches for 2020-08-21

it tags/sd-next-20200821 for you to fetch changes up to 6d2d4069c47e23b9e3913f9c8204fd0edcb99fb3: hw/sd: Correct the maximum size of a Standard Capacity SD Memory Card (2020= -08-21 16:49:22 +0200) SD/MMC patches - Convert lega

[PULL 02/23] hw/sd/pxa2xx_mmci: Trivial simplification

Avoid declaring PXA2xxMMCIState local variable, return it directly. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Laurent Vivier Acked-by: Peter Maydell Message-Id: <20200705213350.24725-3-f4...@amsat.org> --- hw/sd/pxa2xx_mmci.c | 4 +--- 1 file changed, 1

[PULL 03/23] hw/lm32/milkymist: Un-inline milkymist_memcard_create()

As we will modify milkymist_memcard_create(), move it first to the source file where it is used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200705211016.15241-2-f4...@amsat.org> --- hw/lm32/milkymist-hw.h | 11 --- hw/lm32/milkymist.c| 11

Re: [PATCH v5 08/10] iotests.py: add verify_o_direct helper

On Fri, Aug 21, 2020 at 5:12 PM Vladimir Sementsov-Ogievskiy wrote: > > Add python notrun-helper similar to _check_o_direct for bash tests. > To be used in the following commit. > > Suggested-by: Nir Soffer > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 12

[PULL 04/23] hw/sd/milkymist: Create the SDBus at init()

We don't need to wait until realize() to create the SDBus, create it in init() directly. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200705211016.15241-4-f4...@amsat.org> --- hw/sd/milkymist-memcard.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PULL 05/23] hw/sd/milkymist: Do not create SD card within the SD host controller

SD/MMC host controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) Let the machine/board model create and plug the SD cards when required. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20200705211016.15241-5-f4...@amsat.org> --

[PULL 08/23] hw/sd/pl181: Add TODO to use Fifo32 API

Add TODO to use Fifo32 API from "qemu/fifo32.h". Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20200705204630.4133-4-f4...@amsat.org> --- hw/sd/pl181.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c index 3fc2cdd71a

[PULL 06/23] hw/sd/pl181: Replace fprintf(stderr, "*\n") with error_report()

From: Alistair Francis Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\))

[PULL 13/23] hw/sd/sdcard: Make sd_data_ready() static

sd_data_ready() belongs to the legacy API. As its last user has been converted to the SDBus API, make it static. Reviewed-by: Alistair Francis Message-Id: <20180216022933.10945-7-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell --- include/hw/sd/sd.h | 1 - hw/sd/

Re: [PATCH v8 1/1] audio/jack: fix use after free segfault

On Freitag, 21. August 2020 15:45:54 CEST Geoffrey McRae wrote: > This change registers a bottom handler to close the JACK client > connection when a server shutdown signal is recieved. Without this > libjack2 attempts to "clean up" old clients and causes a use after free > segfault. > > Signed-of

[PULL 11/23] hw/sd/pl181: Do not create SD card within the SD host controller

SD/MMC host controllers provide a SD Bus to plug SD cards, but don't come with SD card plugged in :) Let the machine/board model create and plug the SD cards when required. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Acked-by: Peter Maydell Me

[PULL 07/23] hw/sd/pl181: Rename pl181_send_command() as pl181_do_command()

pl181_send_command() do a bus transaction (send or receive), rename it as pl181_do_command(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Acked-by: Peter Maydell Message-Id: <20200705204630.4133-3-f4...@amsat.org> --- hw/sd/pl181.c | 4 ++-- 1 file changed, 2 insertions

[Bug 1892533] [NEW] Meson: Missing config-host.mak

Public bug reported: Wanted to give a try to the new build system, but a simple "meson build" gives that error: meson.build:15:0: ERROR: Failed to load /home/xclaesse/programmation/qemu/build/config-host.mak: [Errno 2] No such file or directory: '/home/xclaesse/programmation/qemu/build/config- ho

<    1   2   3   4   5   6   >