This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu7.31
---
qemu (1:2.11+dfsg-1ubuntu7.31) bionic-security; urgency=medium
* SECURITY UPDATE: out-of-bounds read in slirp networking
- debian/patches/CVE-2020-10756.patch: drop bogus IPv6 messages in
slirp/src/ip6_in
Am 25.06.2020 um 17:22 hat Max Reitz geschrieben:
> This includes some permission limiting (for example, we only need to
> take the RESIZE permission for active commits where the base is smaller
> than the top).
>
> Use this opportunity to rename qmp_drive_mirror()'s "source" BDS to
> "target_back
If you're in need of the tools then the package name needs to be gettext-tools.
On August 19, 2020 4:06:32 a.m. Paolo Bonzini wrote:
On 19/08/20 03:56, Brad Smith wrote:
This last part is redundant. If glib2 and/or gtk+3 is installed then
gettext
is installed.
The package name is wrong as
On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> This makes secondary_cpu_reset() unnecessary, so remove it.
>
> Also r
On Wed, 19 Aug 2020 18:03:17 +0200
Philippe Mathieu-Daudé wrote:
> qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ,
> but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is
> specific to MSIX IRQ type, and allow us to use multiple IRQs
> (thus passing multiple eventfd no
** Changed in: kunpeng920/ubuntu-18.04
Status: Fix Committed => Fix Released
** No longer affects: kunpeng920/ubuntu-18.04-hwe
** Changed in: kunpeng920
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On Wed, Aug 19, 2020 at 6:40 PM Peter Xu wrote:
>
> On Tue, Aug 18, 2020 at 03:01:51PM +0200, Eugenio Pérez wrote:
> > Signed-off-by: Eugenio Pérez
>
> The changes on the callers of memory_region_notify_one_iommu() seems to be
> still missing (and, to embed the type into the notification process)
On Wed, 19 Aug 2020 11:30:35 +0800
Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> > Hi Cornelia,
> >
> > > From: Cornelia Huck
> > > Sent: Tuesday, August 18, 2020 3:07 PM
> > > To: Daniel P. Berrangé
> > > Cc: Jason Wang ; Yan Zhao
> > > ; k...@vger.kernel
On 8/12/20 9:52 AM, Vladimir Sementsov-Ogievskiy wrote:
This make nbd connection_co to yield during reconnects, so that
reconnect doesn't hang up the main thread. This is very important in
case of unavailable nbd server host: connect() call may take a long
time, blocking the main thread (and due
On Wed, Aug 19, 2020 at 7:47 PM Eugenio Perez Martin
wrote:
>
> On Wed, Aug 19, 2020 at 6:40 PM Peter Xu wrote:
> >
> > On Tue, Aug 18, 2020 at 03:01:51PM +0200, Eugenio Pérez wrote:
> > > Signed-off-by: Eugenio Pérez
> >
> > The changes on the callers of memory_region_notify_one_iommu() seems t
Am 25.06.2020 um 17:22 hat Max Reitz geschrieben:
> This includes some permission limiting (for example, we only need to
> take the RESIZE permission if the base is smaller than the top).
>
> Signed-off-by: Max Reitz
> ---
> block/block-backend.c | 9 +++-
> block/commit.c
On Wed, 19 Aug 2020 at 15:36, Paolo Bonzini wrote:
>
> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>
> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git tags/for-ups
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
---
include/block/nbd.h | 2 --
nbd/server.c| 5 -
2 files changed, 7 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu
On Wed, 19 Aug 2020 at 19:12, Peter Maydell wrote:
>
> On Wed, 19 Aug 2020 at 15:36, Paolo Bonzini wrote:
> >
> > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
> >
> > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
> >
> > are available in the Git r
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Move all block export related types and commands from block-core to the
new QAPI module block-export.
Signed-off-by: Kevin Wolf
---
+++ b/qapi/block-export.json
@@ -0,0 +1,172 @@
+##
+# == Block device exports
+##
+
+{ 'include': 'sockets.json' }
+
+
On 8/13/20 11:29 AM, Kevin Wolf wrote:
The name BlockExport will be used for the struct containing the runtime
state of block exports, so change the name of export creation options.
Signed-off-by: Kevin Wolf
---
qapi/block-export.json | 12 ++--
block/monitor/block-hmp-cmds.c
On Wed, Aug 19, 2020 at 07:47:32PM +0200, Eugenio Perez Martin wrote:
> On Wed, Aug 19, 2020 at 6:40 PM Peter Xu wrote:
> >
> > On Tue, Aug 18, 2020 at 03:01:51PM +0200, Eugenio Pérez wrote:
> > > Signed-off-by: Eugenio Pérez
> >
> > The changes on the callers of memory_region_notify_one_iommu()
The purpose of this change is to set the groundwork
so that an arch could move towards removing
the BQL from the cpu_handle_interrupt/exception paths.
The BQL is a bottleneck in scaling to more cores.
And this cpu_handle_interrupt/exception path is one of
the key BQL users as measured by the QEMU
The rename of all *_cpu_exec_interrupt functions to
*_cpu_exec_interrupt_locked is preparation for pushing the BQL lock
around these functions down into the per-arch implementation of
*_cpu_exec_interrupt. In a later patch, which pushes down the lock,
we will add a new *_cpu_exec_interrupt functio
Adding ->do_interrupt_locked to ARMCPUClass is preparation for
pushing the BQL down into the per-arch implementation of ->do_interrupt.
This is needed since ARM's *_cpu_exec_interrupt calls to *_do_interrupt.
With the push down of the BQL into *_cpu_exec_interrupt and
*_do_interrupt, *_cpu_exec_in
The rename of all *_do_interrupt functions to *_do_interrupt_locked
is preparation for pushing the BQL lock around these functions
down into the per-arch implementation of *_do_interrupt.
In a later patch which pushes down the lock, we will add
a new *_do_interrupt function which grabs the BQL and
Adding ->do_interrupt_locked to CRISCPUClass is preparation for
pushing the BQL down into the per-arch implementation of ->do_interrupt.
This is needed since Cris's *_cpu_exec_interrupt calls to *_do_interrupt.
With the push down of the BQL into *_cpu_exec_interrupt and
*_do_interrupt, *_cpu_exec_
We are changing the critical section from being around
the majority of the cpu_handle_interrupt to instead
be around just the call to ->cpu_exec_interrupt.
This is in preparation for pushing down the BQL into the
per arch implementation.
We should mention that we discussed these changes as well a
On 8/13/20 11:29 AM, Kevin Wolf wrote:
We want to have a common set of commands for all types of block exports.
Currently, this is only NBD, but we're going to add more types.
This patch adds the basic BlockExport and BlockExportDriver structs and
a QMP command block-export-add that creates a ne
As part of pushing the BQL down into the per-arch implementation,
the first change is to remove the holding of BQL from
cpu_handle_exception. Next, we made changes per-arch to
re-add a new *_do_interrupt function, which gets the BQL and then
calls to *_do_interrupt_locked. We also pointed the per
Push the BQL on ->cpu_exec_interrupt down into per-arch implementation.
The first step is to remove the BQL from cpu_handle_interrupt, which
currently calls ->cpu_exec_interrupt. We then added the *_cpu_exec_interrupt
functions, which get the BQL and then call to *_cpu_exec_interrupt_locked.
We al
19.08.2020 21:12, Peter Maydell wrote:
...
> Also one of my random "just test linux-user" setups fails
> because the build doesn't seem to have put the final binaries
> in the right place:
...
> I can live with the .o files moving around (though I would have
> preferred it if they did not), but the
On Wed, 19 Aug 2020 at 19:57, Michael Tokarev wrote:
>
> 19.08.2020 21:12, Peter Maydell wrote:
> ...
> > Also one of my random "just test linux-user" setups fails
> > because the build doesn't seem to have put the final binaries
> > in the right place:
> ...
> > I can live with the .o files movin
On Wed, 19 Aug 2020 at 19:16, Peter Maydell wrote:
> Spoke too soon; "make --output-sync -C build/all-linux-static check-tcg"
> failed with:
>
> BUILD TCG tests for mips-linux-user
> CHECK debian10
> CHECK debian-mips-cross
> BUILD mips-linux-user guest-tests with docker qemu/debia
On 8/13/20 11:29 AM, Kevin Wolf wrote:
No reason to duplicate the functionality locally, we can now just reuse
the QMP command block-export-add for --export.
Signed-off-by: Kevin Wolf
---
qemu-storage-daemon.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
Reviewed-by
We're trying our first nvme pull request from a dedicated development
tree containing various fixes, cleanups, spec compliance, and welcoming
Klaus Jensen to maintaining the emulated nvme device development.
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update ver
I can certainly add symlinks (that would be broken until make completes)
but moving the build outputs is not possible since there's no recursive
make anymore.
Paolo
Il mer 19 ago 2020, 21:06 Peter Maydell ha
scritto:
> On Wed, 19 Aug 2020 at 19:16, Peter Maydell
> wrote:
> > Spoke too soon; "m
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Instead of implementing qemu-nbd --offset in the NBD code, just put a
raw block node with the requested offset on top of the user image and
rely on that doing the job.
This does not only simplify the nbd_export_new() interface and bring it
closer to the set
On 19/08/20 21:04, Peter Maydell wrote:
>> is it really that important? We've changed single target build
>> rules already (from subdir-x86_64-softmmu to x86_64-softmmu/all
>> for one), which broke quite some mostly automatic build
>> systems which needed some fixing. Moving executables isn't a
>>
cc: Peter Krempa
On 8/13/20 11:29 AM, Kevin Wolf wrote:
nbd-server-add tries to be convenient and adds two questionable
features that we don't want to share in block-export-add, even for NBD
exports:
1. When requesting a writable export of a read-only device, the export
is silently downgrad
On 8/13/20 11:29 AM, Kevin Wolf wrote:
This is a QMP equivalent of qemu-nbd's --share option, limiting the
maximum number of clients that can attach at the same time.
Signed-off-by: Kevin Wolf
---
qapi/block-export.json | 10 --
include/block/nbd.h| 3 ++-
block
On 8/17/20 7:56 AM, Max Reitz wrote:
On 13.08.20 18:29, Kevin Wolf wrote:
qemu-nbd allows use of writethrough cache modes, which mean that write
requests made through NBD will cause a flush before they complete.
Expose the same functionality in block-export-add.
Signed-off-by: Kevin Wolf
---
On 8/19/20 8:16 PM, Peter Maydell wrote:
> On Wed, 19 Aug 2020 at 19:12, Peter Maydell wrote:
>>
>> On Wed, 19 Aug 2020 at 15:36, Paolo Bonzini wrote:
>>>
>>> The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
>>>
>>> Update version for v5.1.0 release (2020-08-11 17:07
On 8/13/20 11:29 AM, Kevin Wolf wrote:
qemu-nbd allows use of writethrough cache modes, which mean that write
requests made through NBD will cause a flush before they complete.
Expose the same functionality in block-export-add.
Signed-off-by: Kevin Wolf
---
qapi/block-export.json | 7 ++-
On 19/08/20 20:12, Peter Maydell wrote:
> make: *** No rule to make target 'check-block', needed by 'check'. Stop.
> make: *** Waiting for unfinished jobs
> [various other output from other parallel jobs snipped]
That's because no tests are available with --disable-system, but I can
certainly
On 8/13/20 11:29 AM, Kevin Wolf wrote:
The export close callback is unused by the built-in NBD server. qemu-nbd
uses it only during shutdown to wait for the unrefed export to actually
go away. It can just use nbd_export_close_all() instead and do without
the callback.
This removes the close call
On 8/13/20 11:29 AM, Kevin Wolf wrote:
With this change, NBD exports are only created through the BlockExport
interface any more. This allows us finally to move things from the NBD
s/are only/are now only/; s/any more //
layer to the BlockExport layer if they make sense for other export
types
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Closing export is somewhat convoluted because nbd_export_close() and
nbd_export_put() call each other and the ways they actually end up being
nested is not necessarily obvious.
You are in a maze of twisty little passages, all alike.
Yes, I've always hated
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Having a refcount makes sense for all types of block exports. It is also
a prerequisite for keeping a list of all exports at the BlockExport
level.
Signed-off-by: Kevin Wolf
---
+++ b/include/block/export.h
@@ -21,14 +21,24 @@ typedef struct BlockExport
On Wed, 19 Aug 2020 at 20:44, Paolo Bonzini wrote:
> On 19/08/20 21:04, Peter Maydell wrote:
> >> is it really that important? We've changed single target build
> >> rules already (from subdir-x86_64-softmmu to x86_64-softmmu/all
> >> for one), which broke quite some mostly automatic build
> >> sy
On 8/13/20 11:29 AM, Kevin Wolf wrote:
Every block export needs a block node to export, so move the 'device'
option from BlockExportOptionsNbd to BlockExportOptions.
To maintain compatibility in nbd-server-add, BlockExportOptionsNbd needs
to be wrapped by a new type NbdServerAddOptions that adds
On 8/9/2020 11:50 PM, Jason Zeng wrote:
> On Fri, Aug 07, 2020 at 04:38:12PM -0400, Steven Sistare wrote:
>> On 8/6/2020 6:22 AM, Jason Zeng wrote:
>>> Hi Steve,
>>>
>>> On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sistare wrote:
@@ -3182,6 +3207,51 @@ static Property vfio_pci_dev_propertie
On Wed, Aug 19, 2020 at 05:07:11PM +0200, Kevin Wolf wrote:
> Am 19.08.2020 um 16:25 hat Alberto Garcia geschrieben:
> > On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote:
> > >> > Or are you saying that ZERO_RANGE + pwrite on a sparse file (=
> > >> > cluster allocation) is faster for you than
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Host Memory : 15.49 GB
Start Time (UTC) : 2020-08-19 21:00:01
End Time (UTC) : 2020-08-19 21:32:15
Execution Time : 0:32:14.021998
Status : SUCCESS
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 2eddb3c65821dce76433d5da6f3
On 19/08/20 18:22, Alexander Bulekov wrote:
>
> For the issue in question, there are already some trace points.
> If I run the repro with -trace 'pci*' -trace 'megasas*' -trace 'scsi*' :
> Reformat the trace somewhat and add some annotations for the data that
> comes from DMA:
>
> # megasas_init
On 19/08/20 16:15, Li Qiang wrote:
> Currently the device fuzzer find a more and more issues.
> For every fuzz case, we need not only the fixes but also
> the coressponding test case. We can analysis the reproducer
> for every case and find what happened in where and write
> a beautiful test case.
On 8/17/2020 10:42 PM, Alex Williamson wrote:
> On Mon, 17 Aug 2020 15:44:03 -0600
> Alex Williamson wrote:
>
>> On Mon, 17 Aug 2020 17:20:57 -0400
>> Steven Sistare wrote:
>>
>>> On 8/17/2020 4:48 PM, Alex Williamson wrote:
On Mon, 17 Aug 2020 14:30:51 -0400
Steven Sistare wrote:
>
On 8/19/20 4:32 PM, Paolo Bonzini wrote:
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
Unrelated to
On 19/08/20 23:59, Eric Blake wrote:
> On 8/19/20 4:32 PM, Paolo Bonzini wrote:
>> The following changes since commit
>> d0ed6a69d399ae193959225cdeaa9382746c91cc:
>>
>> Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
>>
>> are available in the Git repository at:
>>
>> https://gi
> -Original Message-
> From: Igor Mammedov
> Sent: Wednesday, August 19, 2020 6:26 AM
> To: Moger, Babu
> Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com;
> m...@redhat.com; marcel.apfelb...@gmail.com; qemu-devel@nongnu.org
> Subject: Re: [PATCH v4 2/3] hw/i386: Update t
On 19/08/20 22:07, Philippe Mathieu-Daudé wrote:
> Probably not the cause, but I'm seeing now docker images are built in
> parallel (before it was sequential, I run make with -j8).
I think it's always been parallel, and in fact nothing at all is changed
by this series in that area.
In any case it
On 8/19/20 7:18 AM, Igor Mammedov wrote:
> On Fri, 14 Aug 2020 16:39:40 -0500
> Babu Moger wrote:
>
>> Remove node_id, nr_nodes and nodes_per_pkg from topology. Use
>> die_id, nr_dies and dies_per_pkg which is already available.
>> Removes the confusion over two variables.
>>
>> With node_id r
On 19/08/20 23:11, Peter Maydell wrote:
> On Wed, 19 Aug 2020 at 20:44, Paolo Bonzini wrote:
>> However, this change was already in the first series that was posted
>> like a year ago...
>
> It's a hundred-and-fifty patch series, and I can't review everything.
> I took it on trust that it would b
Philippe Mathieu-Daudé writes:
> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> This makes secondary_cpu_rese
Some of the enum constant names conflict with the QOM type check
macros (SIFIVE_U_OTP, SIFIVE_U_PRCI). This needs to be addressed
to allow us to transform the QOM type check macros into functions
generated by OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_U_DEV_*, to avoid conflicts.
Rename the MEGASAS_DEVICE_CLASS() and MEGASAS_DEVICE_GET_CLASS()
macros to be consistent with the MEGASAS() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 ->
Rename the E1000_DEVICE_CLASS() and E1000_DEVICE_GET_CLASS()
macros to be consistent with the E1000() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: no
Some of the enum constant names conflict with the QOM type check
macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to
allow us to transform the QOM type check macros into functions
generated by OBJECT_DECLARE_TYPE().
Rename all the constants to AW_H3_DEV_*, to avoid conflicts.
Review
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzi
The PL110 enum value name will conflict with the PL110 type cast
checker, when we replace the existing macro with an inline
function. Add a VERSION_ prefix to all pl110_version enum
values, to avoid conflicts.
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Fixed typo on commit message
*
Some of the enum constant names conflict with the QOM type check
macros:
ASPEED_GPIO
ASPEED_I2C
ASPEED_RTC
ASPEED_SCU
ASPEED_SDHCI
ASPEED_SDMC
ASPEED_VIC
ASPEED_WDT
ASPEED_XDMA
This needs to be addressed to allow us to transform the QOM type
check macros into functions generated by OBJECT_DECLARE
Some of the enum constant names conflict with a QOM type check
macro (SIFIVE_E_PRCI). This needs to be addressed to allow us to
transform the QOM type check macros into functions generated by
OBJECT_DECLARE_TYPE().
Rename all the constants to SIFIVE_E_DEV_*, to avoid conflicts.
Reviewed-by: Alis
Rename the PVSCSI_DEVICE_CLASS() and PVSCSI_DEVICE_GET_CLASS()
macros to be consistent with the PVSCSI() instance cast macro.
This will allow us to register the type cast macros using
OBJECT_DECLARE_TYPE later.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Thomas Huth
Cc: Jason Wang
Cc: qemu-devel@nongnu.org
---
include/hw/m68
The macro definition had an extra semicolon. This was never
noticed because the macro was only being used where it didn't
make a difference.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: "Cédric Le Goater"
Some of the enum constant names conflict with the QOM type check
macros (IBEX_PLIC, IBEX_UART). This needs to be addressed to
allow us to transform the QOM type check macros into functions
generated by OBJECT_DECLARE_TYPE().
Rename all the constants to IBEX_DEV_*, to avoid conflicts.
Reviewed-by
PlatformBusDeviceClass doesn't exist. This will break when we
automatically convert the code to use OBJECT_DEFINE_TYPE().
Delete the macros that reference the non-existing typedef.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: qemu-devel@nong
The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME
macro. This will be necessary to allow us to use OBJECT_DEFINE*()
for TYPE_HVF_ACCEL.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Roman Bolshakov
Signed-off-by: Eduardo Habkost
---
Changes v1 ->
This is an extension of the series previously submitted by
Daniel[1], including a script that will convert existing type
checker macros automatically.
Changes from series v1 to v2:
* Don't skip TypeCheckMacro conversion if typedefs
are found in typedefs.h
* Don't look for typedefs if type check
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: qemu-devel@nongnu.org
---
Move the typedef from spapr_irq.h to spapr.h, and use "struct
SpaprMachineState" in the spapr_*.h headers (to avoid circular
header dependencies).
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: D
The macro never worked because the NubusBridge typedef doesn't
exist. Delete it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Laurent Vivier
Cc: qemu-devel@nongnu.org
---
include/hw/nubus/nubus.h | 1 -
Fixes: cd93dbf375bd ("versatile_pci: Update to realize and instance init
functions")
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Peter Maydell
Cc: qemu-...@nongnu.org
Cc: qemu-devel@nongnu.org
---
hw/pc
The macro was incorrectly defined using OBJECT_CHECK.
Acked-by: Cornelia Huck
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: "Michael S. Tsirkin"
Cc: Cornelia Huck
Cc: Halil Pasic
Cc: Christian Borntraeger
Cc: Richard Henderson
Cc: David
Rename the DWC2_CLASS to DWC2_USB_CLASS and DWC2_GET_CLASS to
DWC2_USB_GET_CLASS, for consistency with the DWC2_USB macro.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Gerd Hoffmann
Cc: qemu-devel@nongnu.
Rename TYPE_ARMSSE to TYPE_ARM_SSE, and ARMSSE*() type checking
macros to ARM_SSE*().
This will avoid a future conflict between an ARM_SSE() type
checking macro and the ARMSSE typedef name.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Peter Maydell
Cc:
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Sven Schnelle
Cc: Jason Wang
Cc: qe
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: "Hervé Poussineau"
Cc: "Philippe Mathieu-Daudé"
Cc: Aleksandar Markovic
Cc: Aurelien Jarno
Cc: qe
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Alberto Garcia
Cc: Kevin Wolf
Cc: M
Move the ALLWINNER_AHCI macro close to the TYPE_ALLWINNER_AHCI
define.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: John Snow
Cc: qemu-bl...@nongnu.org
Cc: qemu-devel@nongnu.org
---
include/h
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Cameron Esfahani
Cc: Roman Bolshakov
Cc: Paolo Bonzini
Cc: Richard Hend
Move QOM macros close to the KVMState typedef.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Paolo Bonzini
Cc: k...@vger.kernel.org
Cc: qemu-devel@nongnu.org
---
include/sysemu/kvm.h | 6 +
Move typedef closer to the type check macros, to make it easier
to convert the code to OBJECT_DEFINE_TYPE() in the future.
Acked-by: Cornelia Huck
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
Cc: Cornelia Huck
Cc: Thomas Huth
Cc: Halil Pasic
CanBusClass doesn't exist. This will break when we automatically
convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros
that reference the non-existing typedef.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: no
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Alex Williamson
Cc: qemu-devel@nongnu.org
---
hw/vfio/pci.h | 3 +++
hw/vfio/pci.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: qemu-devel@nongnu.org
---
include/hw/misc/auxbus.h | 3 +++
hw/misc/auxbus.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff
From: Daniel P. Berrangé
The object_ref/unref methods are intended for use with any subclass of
the base Object. Using "Object *" in the signature is not adding any
meaningful level of type safety, since callers simply use "OBJECT(ptr)"
and this expands to an unchecked cast "(Object *)".
By usin
This will make future conversion to OBJECT_DECLARE* easier.
In sclp.h, use "struct SCLPEventFacility" to avoid introducing
unnecessary header dependencies.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Cornelia Huck
Cc: Halil Pasic
Cc: Christian Borntr
The typedef was used in the XENBACKEND_DEVICE macro, but it was
never defined. Define the typedef close to the type checking
macro.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: xen-de...@
Sometimes the typedefs are buried inside another header, but
we want to benefit from the automatic definition of type cast
functions. Introduce macros that will let type checkers be
defined when typedefs are already available.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
C
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Paolo Bonzini
Cc: Fam Zheng
Cc: qemu-devel@nongnu.org
---
hw/scsi/mptsas.h | 6 +-
hw/scsi/mptsas.c | 5 -
2 files changed, 5 insertions(+
Move the VHOST_USER_GPU type checking macro to virtio-gpu.h,
close to the TYPE_VHOST_USER_GPU #define.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: "Michael S. Tsirkin"
Cc: "Marc-André Lureau"
Move the I8257 macro to i8257.h, close to the TYPE_I8257 define.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: qemu-devel@nongnu.org
---
include/hw/
Separate run of the TypeCheckMacro converter using the --force
flag, for the cases where typedefs weren't found in the same
header nor in typedefs.h.
Generated initially using:
$ ./scripts/codeconverter/converter.py --force -i \
--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
Then eac
201 - 300 of 370 matches
Mail list logo
