[PATCH v3 08/12] iotests.py: add verify_o_direct helper

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
Add python notrun-helper similar to _check_o_direct for bash tests. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotes

[PATCH v3 09/12] iotests.py: add filter_img_check

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
Add analog of bash _filter_qemu_img_check to python framework. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 369e9918b4..ef3da4ee61 100644 -

[PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
vstorage has slow allocation, so this patch detect vstorage (I hope, we don't use other FUSE filesystems) and inserts preallocate filter between qcow2 node and its file child. The following test executes more than 10 times faster (43.2s -> 3.9s for me) with this patch. (/newssd3 is mount point of

Re: [PATCH 10/12] block/file-posix: fix a possible undefined behavior

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 18:02 hat Pan Nengyuan geschrieben: > local_err is not initialized to NULL, it will cause a assert error as below: > qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed. > > Fixes: c6447510690 > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by:

Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 18:02 hat Pan Nengyuan geschrieben: > 'local_err' seems forgot to propagate in error path, it'll cause > a memleak. Fix it. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan I wonder if using ERRP_GUARD() wouldn't simplify this. Anyway, the fix looks correct: Reviewed

Re: [PATCH v3 00/12] preallocate filter

2020-08-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [PATCH v3 00/12] preallocate filter

2020-08-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BE

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-17 Thread Bin Meng
On Sat, Aug 15, 2020 at 1:56 AM Philippe Mathieu-Daudé wrote: > > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > Some of the enum constant names conflict with the QOM type check > > macros. This needs to be addressed to allow us to transform the > > QOM type check macros into functions generated

Re: [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > We want to have a common set of commands for all types of block exports. > Currently, this is only NBD, but we're going to add more types. > > This patch adds the basic BlockExport and BlockExportDriver structs and > a QMP command block-export-add that create

[PATCH v2 1/3] hw/sd: sd: Fix incorrect populated function switch status data structure

2020-08-17 Thread Bin Meng
At present the function switch status data structure bit [399:376] are wrongly pupulated. These 3 bytes encode function switch status for the 6 function groups, with 4 bits per group, starting from function group 6 at bit 399, then followed by function group 5 at bit 395, and so on. However the co

[PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-17 Thread Bin Meng
This series is spun off from the following series as it is hw/sd centric, so that it can be picked up separately by Philippe. http://patchwork.ozlabs.org/project/qemu-devel/list/?series=195648 This series fixed 2 SD card issues, and added a new model for Cadence SDHCI controller. Patch "[09/18]

[PATCH v2 2/3] hw/sd: sd: Correct the maximum size of a Standard Capacity SD Memory Card

2020-08-17 Thread Bin Meng
Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports capacity up to and including 2 GiB. Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards") Signed-off-by: Bin Meng --- Changes in v2: - fix SDSC size check in sd_set_csd() too hw/sd/sd.c | 6 -- 1 file changed, 4 insertions(+

[PATCH v2 2/3] hw/sd: sd: Correct the maximum size of a Standard Capacity SD Memory Card

2020-08-17 Thread Bin Meng
Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports capacity up to and including 2 GiB. Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards") Signed-off-by: Bin Meng --- Changes in v2: - fix SDSC size check in sd_set_csd() too hw/sd/sd.c | 6 -- 1 file changed, 4 insertions(+

[PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-17 Thread Bin Meng
This series is spun off from the following series as it is hw/sd centric, so that it can be picked up separately by Philippe. http://patchwork.ozlabs.org/project/qemu-devel/list/?series=195648 This series fixed 2 SD card issues, and added a new model for Cadence SDHCI controller. Patch "[09/18]

[PATCH v2 1/3] hw/sd: sd: Fix incorrect populated function switch status data structure

2020-08-17 Thread Bin Meng
At present the function switch status data structure bit [399:376] are wrongly pupulated. These 3 bytes encode function switch status for the 6 function groups, with 4 bits per group, starting from function group 6 at bit 399, then followed by function group 5 at bit 395, and so on. However the co

[PATCH v2 3/3] hw/sd: Add Cadence SDHCI emulation

2020-08-17 Thread Bin Meng
Cadence SD/SDIO/eMMC Host Controller (SD4HC) is an SDHCI compatible controller. The SDHCI compatible registers start from offset 0x200, which are called Slot Register Set (SRS) in its datasheet. This creates a Cadence SDHCI model built on top of the existing generic SDHCI model. Cadence specific H

Re: [PATCH v2 2/3] hw/sd: sd: Correct the maximum size of a Standard Capacity SD Memory Card

2020-08-17 Thread Philippe Mathieu-Daudé
On 8/17/20 12:03 PM, Bin Meng wrote: > Per the SD spec, Standard Capacity SD Memory Card (SDSC) supports > capacity up to and including 2 GiB. > > Fixes: 2d7adea4fe ("hw/sd: Support SDHC size cards") > Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé > --- > > Changes in v2: > - fi

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 16:57 hat Alberto Garcia geschrieben: > Hi, > > the patch is self-explanatory, but I'm using the cover letter to raise > a couple of related questions. > > Since commit c8bb23cbdbe / QEMU 4.1.0 (and if the storage backend > allows it) writing to an image created with preallocatio

Re: [RFC PATCH 05/22] qemu-storage-daemon: Use qmp_block_export_add()

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > No reason to duplicate the functionality locally, we can now just reuse > the QMP command block-export-add for --export. > > Signed-off-by: Kevin Wolf > --- > qemu-storage-daemon.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) Revie

[Bug 1882851] Re: [PATCH] drm/virtio: fix unblank

2020-08-17 Thread Gerd Hoffmann
On Mon, Aug 17, 2020 at 11:03:42AM +0200, Gerd Hoffmann wrote: > Hi, > > > > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > > > @@ -100,6 +100,7 @@ static void virtio_gpu_crtc_atomic_enable(struct > > > drm_crtc *crtc, > > > struct virtio

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-17 Thread Cornelia Huck
On Thu, 13 Aug 2020 14:04:15 +0200 Stefano Garzarella wrote: > On Thu, Aug 13, 2020 at 12:37:37PM +0200, Cornelia Huck wrote: > > On Thu, 13 Aug 2020 12:24:30 +0200 > > Stefano Garzarella wrote: > > > > > On Thu, Aug 13, 2020 at 11:28:20AM +0200, Cornelia Huck wrote: > > > > We basically ha

[REPORT] [GSoC - TCG Continuous Benchmarking] [#8] QEMU Nightly Performance Tests

2020-08-17 Thread Ahmed Karaman
Hi everyone, QEMU currently lacks a system for measuring the performance of targets automatically. The previous reports introduced different tools and methods for locating performance regressions, but all of them had to be manually executed by the user when needed. This report devises a new night

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-17 Thread Bin Meng
Hi Anup, On Sat, Aug 15, 2020 at 1:44 AM Anup Patel wrote: > > On Fri, Aug 14, 2020 at 10:12 PM Bin Meng wrote: > > > > From: Bin Meng > > > > This adds support for Microchip PolarFire SoC Icicle Kit board. > > The Icicle Kit board integrates a PolarFire SoC, with one SiFive's > > E51 plus four

Re: [PATCH v3 00/12] preallocate filter

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
Aha, if we want commit 11, we'll need also a stub function for win32. 17.08.2020 12:45, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing com

Re: [PATCH v3 00/12] preallocate filter

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
Hmm strange. Probably need to check #ifdef FUSE_SUPER_MAGIC But again, it's a problem of patch 12, which is just an rfc not to be merged. 17.08.2020 12:48, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200817091553.283155-1-vsement...@virtuozzo.com/ Hi, This series fa

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Instead of implementing qemu-nbd --offset in the NBD code, just put a > raw block node with the requested offset on top of the user image and > rely on that doing the job. > > This does not only simplify the nbd_export_new() interface and bring it > closer to

[PATCH] qemu-img: Explicit number replaced by a constant

2020-08-17 Thread Yi Li
Signed-off-by: Yi Li --- qemu-img.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5308773811..a0fbc2757c 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1181,7 +1181,7 @@ static int64_t find_nonzero(const uint8_t *buf, int64_t n) }

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Roman Bolshakov
On Fri, Aug 14, 2020 at 05:10:56AM -0400, Paolo Bonzini wrote: > News since v1: > * automatically generate dependencies for sphinx manuals [Peter] > * fixes for ARM KVM build [Peter] > * work around old libiscsi in vhost-user-scsi.c [Peter] > * hack to support default c:/Program Files/QEMU prefix o

Re: [PATCH 1/7] block/null: Make more explicit the driver default size is 1GiB

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben: > As it is not obvious the default size for the null block driver > is 1 GiB, replace the obfuscated '1 << 30' magic value by a > definition using IEC binary prefixes. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/null.c

Re: [PATCH 025/150] libqemuutil, qapi, trace: convert to meson

2020-08-17 Thread Roman Bolshakov
On Fri, Aug 14, 2020 at 05:11:21AM -0400, Paolo Bonzini wrote: > This shows how to do some "computations" in meson.build using its array > and dictionary data structures, and also a basic usage of the sourceset > module for conditional compilation. > > [...] > diff --git a/trace/meson.build b/trac

Re: [PATCH 2/7] hw/ide/core: Trivial typo fix

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf

Re: [PATCH 3/7] hw/ide/core: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben: > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé BDRV_SECTOR_SIZE is the arbitrary unit in which some block layer functions and variables work (such as bs->total_sectors). It h

Re: [PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben: > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé In this patch, BDRV_SECTOR_SIZE actually looks correct to me. The values have already been converted from s->qdev.blocksize in

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Paolo Bonzini
On 17/08/20 13:02, Roman Bolshakov wrote: > > Tested-by: Roman Bolshakov > > On the next step, it might be good to drop configure in favor of meson > configuration, so configure, build and test commands would be similar to > libvirt: > > meson build > ninja -C build > meson test -C build Well,

Re: [PATCH] memory: Initialize MemoryRegionOps for RAM memory regions

2020-08-17 Thread P J P
+-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ | On 8/16/20 8:26 PM, Philippe Mathieu-Daudé wrote: | > There is an issue when using memory_region_dispatch_read() or | > memory_region_dispatch_write() on RAM memory regions. | > | > RAM memory regions are initialized as: | > | > memory

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > nbd-server-add tries to be convenient and adds two questionable > features that we don't want to share in block-export-add, even for NBD > exports: > > 1. When requesting a writable export of a read-only device, the export >is silently downgraded to read-

Re: [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Instead of implementing qemu-nbd --offset in the NBD code, just put a > raw block node with the requested offset on top of the user image and > rely on that doing the job. > > This does not only simplify the nbd_export_new() interface and bring it > closer to

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Roman Bolshakov
On Mon, Aug 17, 2020 at 01:24:50PM +0200, Paolo Bonzini wrote: > On 17/08/20 13:02, Roman Bolshakov wrote: > > > > Tested-by: Roman Bolshakov > > > > On the next step, it might be good to drop configure in favor of meson > > configuration, so configure, build and test commands would be similar t

[PATCH 2/4] ui: add getter for UIInfo

2020-08-17 Thread marcandre . lureau
From: Marc-André Lureau The following patch is going to introduce extra fields / details to UIInfo. Add a getter and keep the current values, instead of memset(0) Signed-off-by: Marc-André Lureau --- ui/console.c | 7 +++ ui/spice-display.c | 2 +- 2 files changed, 8 insertions(+), 1

[PATCH 0/4] WIP: add physical display dimensions to spice/virtio-gpu

2020-08-17 Thread marcandre . lureau
From: Marc-André Lureau Hi, In order to improve support for HiDPI, I proposed some new Spice messages to inform the guest of the display physical dimensions. See spice-protocol proposal and related server & spice-gtk changes: https://gitlab.freedesktop.org/spice/spice-protocol/-/merge_requests/

[PATCH 1/4] edid: use physical dimensions if available

2020-08-17 Thread marcandre . lureau
From: Marc-André Lureau Add width_mm/height_mm to qemu_edid_info, and use it if it is set (non-zero) to generate the EDID. Signed-off-by: Marc-André Lureau --- hw/display/edid-generate.c | 21 + include/hw/display/edid.h | 2 ++ 2 files changed, 15 insertions(+), 8 deleti

[PATCH 4/4] virtio-gpu: set physical dimensions for EDID

2020-08-17 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 1 + 3 files changed, 5 insertions(+) diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index 79613

[PATCH 3/4] spice: get monitors physical dimension

2020-08-17 Thread marcandre . lureau
From: Marc-André Lureau Note that for consistency, we use the same logic as MonitorsConfig to figure out the associated monitor. However, I can't find traces of the discussion/patches about the "new spice-server" behaviour: it still uses the multiple-configurations path in git master. Signed-off

Re: [PATCH] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs

2020-08-17 Thread Pankaj Gupta
> If error occurs while processing the virtio request we should call > 'virtqueue_detach_element' to detach the element from the virtqueue > before free the elem. > > Signed-off-by: Li Qiang > --- > hw/virtio/virtio-pmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/virtio/virtio-

Re: [PATCH 1/4] edid: use physical dimensions if available

2020-08-17 Thread Gerd Hoffmann
On Mon, Aug 17, 2020 at 04:00:53PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add width_mm/height_mm to qemu_edid_info, and use it if it is > set (non-zero) to generate the EDID. Any specific reason why you switch from dpi to xmm/ymm? take care, Gerd

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Cornelia Huck
On Fri, 14 Aug 2020 05:10:56 -0400 Paolo Bonzini wrote: > News since v1: > * automatically generate dependencies for sphinx manuals [Peter] > * fixes for ARM KVM build [Peter] > * work around old libiscsi in vhost-user-scsi.c [Peter] > * hack to support default c:/Program Files/QEMU prefix on min

Re: [PATCH] memory: Initialize MemoryRegionOps for RAM memory regions

2020-08-17 Thread Philippe Mathieu-Daudé
On 8/17/20 1:25 PM, P J P wrote: > +-- On Mon, 17 Aug 2020, Philippe Mathieu-Daudé wrote --+ > | On 8/16/20 8:26 PM, Philippe Mathieu-Daudé wrote: > | > There is an issue when using memory_region_dispatch_read() or > | > memory_region_dispatch_write() on RAM memory regions. > | > > | > RAM memory

Re: [PATCH v9 4/5] vhost-user block device backend server

2020-08-17 Thread Coiby Xu
On Thu, Jun 18, 2020 at 05:57:40PM +0200, Kevin Wolf wrote: Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben: By making use of libvhost-user, block device drive can be shared to the connected vhost-user client. Only one client can connect to the server one time. Since vhost-user-server needs a b

Re: [PATCH v5 10/14] cpus: add handle_interrupt to the CpusAccel interface

2020-08-17 Thread Roman Bolshakov
On Fri, Aug 14, 2020 at 02:01:01PM -0700, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: > > +static void generic_handle_interrupt(CPUState *cpu, int mask) > > +{ > > +cpu->interrupt_request |= mask; > > + > > +if (!qemu_cpu_is_self(cpu)) { > > +qemu_cpu_kick

Re: [RFC PATCH 08/22] nbd: Add max-connections to nbd-server-start

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > This is a QMP equivalent of qemu-nbd's --share option, limiting the *--shared > maximum number of clients that can attach at the same time. > > Signed-off-by: Kevin Wolf > --- > qapi/block-export.json | 10 -- > include/block/nbd.h

Re: [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 12:03 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > We want to have a common set of commands for all types of block exports. > > Currently, this is only NBD, but we're going to add more types. > > > > This patch adds the basic BlockExport and BlockExportDri

Re: [PATCH 2/6] vhost-user-server: drop unused #include

2020-08-17 Thread Coiby Xu
On Fri, Jun 19, 2020 at 01:00:42PM +0100, Stefan Hajnoczi wrote: Signed-off-by: Stefan Hajnoczi --- util/vhost-user-server.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c index e94a8d8a83..49ada8bc78 100644 --- a/util/vhost-user-server.c ++

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 13:41 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > nbd-server-add tries to be convenient and adds two questionable > > features that we don't want to share in block-export-add, even for NBD > > exports: > > > > 1. When requesting a writable export of a rea

Re: [RFC PATCH 09/22] nbd: Add writethrough to block-export-add

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > qemu-nbd allows use of writethrough cache modes, which mean that write > requests made through NBD will cause a flush before they complete. > Expose the same functionality in block-export-add. > > Signed-off-by: Kevin Wolf > --- > qapi/block-export.json | 7

Re: [PATCH 1/4] edid: use physical dimensions if available

2020-08-17 Thread Marc-André Lureau
Hi On Mon, Aug 17, 2020 at 4:21 PM Gerd Hoffmann wrote: > > On Mon, Aug 17, 2020 at 04:00:53PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add width_mm/height_mm to qemu_edid_info, and use it if it is > > set (non-zero) to generate the EDID. > > Any specific rea

Re: [RFC PATCH 08/22] nbd: Add max-connections to nbd-server-start

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 14:37 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > This is a QMP equivalent of qemu-nbd's --share option, limiting the > > *--shared > > > maximum number of clients that can attach at the same time. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/bl

RE: [PATCH 08/11] tcg/optimize: Remove redundant statement in tcg_optimize()

2020-08-17 Thread Chenqun (kuhn)
> > diff --git a/tcg/optimize.c b/tcg/optimize.c index > > 53aa8e5329..d5bea37290 100644 > > --- a/tcg/optimize.c > > +++ b/tcg/optimize.c > > @@ -1264,7 +1264,6 @@ void tcg_optimize(TCGContext *s) > > op->opc = opc = (opc == INDEX_op_movcond_i32 > >

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-17 Thread Stefano Garzarella
On Mon, Aug 17, 2020 at 12:27:46PM +0200, Cornelia Huck wrote: > On Thu, 13 Aug 2020 14:04:15 +0200 > Stefano Garzarella wrote: > > > On Thu, Aug 13, 2020 at 12:37:37PM +0200, Cornelia Huck wrote: > > > On Thu, 13 Aug 2020 12:24:30 +0200 > > > Stefano Garzarella wrote: > > > > > > > On Thu, A

Should I delete created coroutines manually?

2020-08-17 Thread Coiby Xu
Hi, I'm working on vhost-user block device backend [1]. When I tested my patches on the latest version of QEMU (commit d0ed6a69d399ae193959225cdeaa9382746c91cc) with --enable-sanitizer turned on, the follow error will be thrown out, ==46631==ERROR: LeakSanitizer: detected memory leaks D

Re: [RFC PATCH 09/22] nbd: Add writethrough to block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 14:56 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > qemu-nbd allows use of writethrough cache modes, which mean that write > > requests made through NBD will cause a flush before they complete. > > Expose the same functionality in block-export-add. > > > >

Re: [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add

2020-08-17 Thread Max Reitz
On 17.08.20 14:45, Kevin Wolf wrote: > Am 17.08.2020 um 12:03 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> We want to have a common set of commands for all types of block exports. >>> Currently, this is only NBD, but we're going to add more types. >>> >>> This patch adds t

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-17 Thread Max Reitz
On 17.08.20 14:49, Kevin Wolf wrote: > Am 17.08.2020 um 13:41 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> nbd-server-add tries to be convenient and adds two questionable >>> features that we don't want to share in block-export-add, even for NBD >>> exports: >>> >>> 1. Whe

Re: [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 15:19 hat Max Reitz geschrieben: > On 17.08.20 14:45, Kevin Wolf wrote: > > Am 17.08.2020 um 12:03 hat Max Reitz geschrieben: > >> On 13.08.20 18:29, Kevin Wolf wrote: > >>> We want to have a common set of commands for all types of block exports. > >>> Currently, this is only NBD,

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Philippe Mathieu-Daudé
On 8/17/20 1:24 PM, Paolo Bonzini wrote: > On 17/08/20 13:02, Roman Bolshakov wrote: >> >> Tested-by: Roman Bolshakov >> >> On the next step, it might be good to drop configure in favor of meson >> configuration, so configure, build and test commands would be similar to >> libvirt: >> >> meson bui

Re: [PATCH 025/150] libqemuutil, qapi, trace: convert to meson

2020-08-17 Thread Philippe Mathieu-Daudé
On 8/17/20 1:10 PM, Roman Bolshakov wrote: > On Fri, Aug 14, 2020 at 05:11:21AM -0400, Paolo Bonzini wrote: >> This shows how to do some "computations" in meson.build using its array >> and dictionary data structures, and also a basic usage of the sourceset >> module for conditional compilation. >>

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Paolo Bonzini
On 17/08/20 15:36, Philippe Mathieu-Daudé wrote: >> They also include a conversion of the ROM build. > > There was a discussion last year, IIRC QEMU isn't supposed to build > ROMs, the repositories are provided for the source code and licenses. > > QEMU might provide a compiled ROM and describe in

Re: [PATCH 025/150] libqemuutil, qapi, trace: convert to meson

2020-08-17 Thread Paolo Bonzini
On 17/08/20 13:10, Roman Bolshakov wrote: > The patch conflicts with the latest tracing PULL request, object files > shouldn't be generated on darwin: > > https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg02493.html I'm afraid conflicting pull requests will have to be respun. I don't real

Re: [RFC PATCH 09/22] nbd: Add writethrough to block-export-add

2020-08-17 Thread Max Reitz
On 17.08.20 15:13, Kevin Wolf wrote: > Am 17.08.2020 um 14:56 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> qemu-nbd allows use of writethrough cache modes, which mean that write >>> requests made through NBD will cause a flush before they complete. >>> Expose the same func

Re: [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add

2020-08-17 Thread Max Reitz
On 17.08.20 15:29, Kevin Wolf wrote: > Am 17.08.2020 um 15:19 hat Max Reitz geschrieben: >> On 17.08.20 14:45, Kevin Wolf wrote: >>> Am 17.08.2020 um 12:03 hat Max Reitz geschrieben: On 13.08.20 18:29, Kevin Wolf wrote: > We want to have a common set of commands for all types of block expo

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Paolo Bonzini
On 17/08/20 14:26, Cornelia Huck wrote: > > The bad news: The build on the s390x system with Fedora 30 (yes, I > know) seems to be lacking various devices. The output of > 'qemu-system-s390x -device ?' misses all of the > -transitional/-non-transitional varieties for virtio-pci devices, as > well

[PATCH v1 2/5] target/microblaze: mbar: Move LOG_DIS to before sleep

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Move LOG_DIS log to before sleeping handling so that it logs for sleep instructions aswell. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/

[PATCH v1 3/5] target/microblaze: mbar: Add support for data-access barriers

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for data-access barriers. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index c1be76d4c8..c58f334a0f 100644 --- a/ta

[PATCH v1 0/5] target/microblaze: Enable MTTCG

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series adds translation for memory barrier instructions and changes the store-exclusive implementation to use cmpxhg rather than relying on single-threaded TCG. This is primarily in preparation for future AMP machines. Cheers, Edgar Edgar E. Iglesias (5): targe

[PATCH v1 5/5] configure: microblaze: Enable mttcg

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 2acc4d1465..2f7adaa6ae 100755 --- a/configure +++ b/configure @@ -8162,6 +8162,7 @@ case "$target_name" in microblaze|microblazeel) TA

[PATCH v1 1/5] target/microblaze: mbar: Transfer dc->rd to mbar_imm

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Transfer dc->rd to mbar_imm to improve the readability when comparing to the specs. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/microblaze/tr

[PATCH v1 4/5] target/microblaze: swx: Use atomic_cmpxchg

2020-08-17 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use atomic_cmpxchg to implement the atomic cmpxchg sequence. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze

Re: [PATCH] hw/net/xilinx_axienet: Remove unused code

2020-08-17 Thread Edgar E. Iglesias
On Fri, Aug 14, 2020 at 03:30:07PM +0200, Philippe Mathieu-Daudé wrote: > Most of the MDIOBus fields are unused. The ADVERTISE_10HALF > definition is unused. Remove unused code. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/xilinx_axienet.c | 23 --

Re: [RFC PATCH 10/22] nbd: Remove NBDExport.close callback

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > The export close callback is unused by the built-in NBD server. qemu-nbd > uses it only during shutdown to wait for the unrefed export to actually > go away. It can just use nbd_export_close_all() instead and do without > the callback. > > This removes the cl

Re: [PATCH v9 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-08-17 Thread Edgar E. Iglesias
On Fri, Aug 14, 2020 at 04:20:11PM +0100, Francisco Iglesias wrote: > On Wed, Aug 12, 2020 at 05:31:05PM -0700, Vikram Garhwal wrote: > > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN > > bus > > implementation. Bus connection and socketCAN connection for each CAN modu

[PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-17 Thread Jason J. Herne
The POP states that the IPLB location is only written to 0x14 for list-directed IPL. Some operating systems expect 0x14 to not change on boot and will fail IPL if it does change. Fixes: 9bfc04f9ef6802fff0 Signed-off-by: Jason J. Herne Reviewed-by: Janosch Frank --- pc-bios/s390-ccw/jump2ipl.c |

Re: [RFC PATCH 11/22] qemu-nbd: Use blk_exp_add() to create the export

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > With this change, NBD exports are only created through the BlockExport > interface any more. This allows us finally to move things from the NBD > layer to the BlockExport layer if they make sense for other export > types, too. I see. > blk_exp_add() returns

Re: [RFC PATCH 09/22] nbd: Add writethrough to block-export-add

2020-08-17 Thread Kevin Wolf
Am 17.08.2020 um 15:51 hat Max Reitz geschrieben: > On 17.08.20 15:13, Kevin Wolf wrote: > > Am 17.08.2020 um 14:56 hat Max Reitz geschrieben: > >> On 13.08.20 18:29, Kevin Wolf wrote: > >>> qemu-nbd allows use of writethrough cache modes, which mean that write > >>> requests made through NBD will

Re: [RFC PATCH 12/22] nbd/server: Simplify export shutdown

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Closing export is somewhat convoluted because nbd_export_close() and > nbd_export_put() call each other and the ways they actually end up being > nested is not necessarily obvious. > > However, it is not really necessary to call nbd_export_close() from > nbd_

Re: [PATCH v2 000/150] Meson integration for 5.2

2020-08-17 Thread Cornelia Huck
On Mon, 17 Aug 2020 15:57:19 +0200 Paolo Bonzini wrote: > On 17/08/20 14:26, Cornelia Huck wrote: > > > > The bad news: The build on the s390x system with Fedora 30 (yes, I > > know) seems to be lacking various devices. The output of > > 'qemu-system-s390x -device ?' misses all of the > > -trans

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-17 Thread Cornelia Huck
On Mon, 17 Aug 2020 15:11:28 +0200 Stefano Garzarella wrote: > On Mon, Aug 17, 2020 at 12:27:46PM +0200, Cornelia Huck wrote: > > Speaking of tests: do you have a quick way to test vhost-vsock at hand? > > Maybe I should add it to my manual repertoire... > > > > Sure, maybe the quickest way

[PATCH 003/150] pc-bios/s390-ccw: do not use rules.mak

2020-08-17 Thread Paolo Bonzini
From: Thomas Huth Signed-off-by: Paolo Bonzini --- pc-bios/s390-ccw/Makefile | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile index 50bc880272..cc0f77baa6 100644 --- a/pc-bios/s390-ccw/Makefile +++ b/pc-

[PATCH 007/150] tests/vm: do not pollute configure with --efi-aarch64

2020-08-17 Thread Paolo Bonzini
Just make EFI_AARCH64 a variable in the makefile that defaults to the efi firmware included with QEMU. It can be redefined on the "make" command line. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 19 --- tests/vm/Makefile.incl

[PATCH 002/150] optionrom: simplify Makefile

2020-08-17 Thread Paolo Bonzini
From: Marc-André Lureau Make it independent from the rules.mak, and clean up to use pattern rules. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- pc-bios/optionrom/Makefile | 67 +++--- 1 file changed, 41 insertions(+), 26 deletions(-) diff

[PATCH 001/150] oss-fuzz/build: remove LIB_FUZZING_ENGINE

2020-08-17 Thread Paolo Bonzini
Meson build scripts will only include qemu-fuzz-TARGET rules if configured with --enable-fuzzing, and that takes care of adding -fsanitize=fuzzer. Therefore we can just specify the configure option and stop modifying the CFLAGS and CONFIG_FUZZ options in the "make" invocation. Signed-off-by: Paolo

[PATCH 004/150] trace: switch position of headers to what Meson requires

2020-08-17 Thread Paolo Bonzini
Meson doesn't enjoy the same flexibility we have with Make in choosing the include path. In particular the tracing headers are using $(build_root)/$( --- .gitignore | 1 - Makefile | 46 ++-- Makefile.objs

[PATCH v3 000/150] Meson integration for 5.2

2020-08-17 Thread Paolo Bonzini
- Simplified/rewrote handling of the modules variable [Howard] - Fixed access to gdb-xml files [Howard] - Fixed cross-compilation failure due to mingw prefix [Howard] - Fixed SDL2 detection on cross compiles [Howard] - Fixed sub-makefiles that include config-host.mak You can find it at the usual p

[PATCH 008/150] tests/vm: check for Python YAML parser in the Makefile

2020-08-17 Thread Paolo Bonzini
No need to do it in the configure file if it is only used for a help message. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 9 - tests/vm/Makefile.include | 4 +++- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/configu

[PATCH 009/150] tests/docker: add test script for static linux-user builds

2020-08-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/docker/test-static | 24 1 file changed, 24 insertions(+) create mode 100755 tests/docker/test-static diff --git a/tests/docker/test-static b/tests/docker/test-static new file mode 100755 index 00..372ef6fac7 --- /dev/null

[PATCH 010/150] nsis: use "make DESTDIR=" instead of "make prefix="

2020-08-17 Thread Paolo Bonzini
The next patch will prevent modifying the prefix on "make install". Adjust the creation of the installer. Signed-off-by: Paolo Bonzini --- Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index f237ff899d..9d9478205c 100644 --- a/Make

[PATCH 006/150] build-sys hack: ensure target directory is there

2020-08-17 Thread Paolo Bonzini
From: Marc-André Lureau By removing some unnest-vars calls, we miss some directory creation that may be required by some/dir/object.d. This will go away once everything is converted to Meson. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- rules.mak | 1 + 1 file changed, 1

[PATCH 005/150] meson: rename .inc.c files to .inc

2020-08-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitignore| 4 +- Makefile | 36 - ...{atomic_common.inc.c => atomic_common.inc} | 0 accel/tcg/cputlb.c| 2 +- accel/tcg/user-exec.c

[PATCH 013/150] configure: prepare CFLAGS/CXXFLAGS/LDFLAGS for Meson

2020-08-17 Thread Paolo Bonzini
Split between CFLAGS/QEMU_CFLAGS and CXXFLAGS/QEMU_CXXFLAGS so that we will use CFLAGS and CXXFLAGS for flags that we do not want to pass to add_project_arguments. Signed-off-by: Paolo Bonzini --- configure | 78 --- rules.mak | 4

[PATCH 011/150] configure: do not include $(...) variables in config-host.mak

2020-08-17 Thread Paolo Bonzini
This ensures that Meson will be able to reuse the results of the tests that are performed in the configure script. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 018/150] build-sys: add meson submodule

2020-08-17 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- .gitmodules | 3 ++ configure | 73 ++- meson | 1 + scripts/archive-source.sh | 3 +- 4 files changed, 71 insertio

[PATCH 017/150] build-sys hack: link with whole .fa archives

2020-08-17 Thread Paolo Bonzini
From: Marc-André Lureau In order to link the *-obj-y files into tests, we will make static libraries of them in Meson, and then link them as whole archives into the tests. To separate regular static libraries from link-whole libraries, give them a different file extension. Signed-off-by: Marc-A

<    1   2   3   4   5   6   >