Re: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence

2020-08-11 Thread Cédric Le Goater
On 8/11/20 1:20 AM, Joel Stanley wrote: > On Mon, 10 Aug 2020 at 17:16, Cédric Le Goater wrote: >> >> On 8/7/20 1:42 AM, Joel Stanley wrote: >>> On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater wrote: BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until the bit is cl

Re: [PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-11 Thread Cornelia Huck
On Mon, 10 Aug 2020 11:51:47 +0100 Alex Bennée wrote: > Mention a few of the more common naming conventions we follow in the > code base including common variable names and function prefix and > suffix examples. > > Signed-off-by: Alex Bennée > > --- > v2 > - punctuation fixes suggested by C

[PATCH v2 0/8] fcntl, sockopt, and ioctl options

2020-08-11 Thread Shu-Chun Weng
Hi Laurent, This is a series of 8 patches in 4 groups, putting into a single thread for easier tracking. [PATCH v2 1/8] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls An incidental follow up on https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg01925.html [PATCH v2 2/8] linu

[PATCH v2 4/8] linux-user: Add IPv6 options to do_print_sockopt()

2020-08-11 Thread Shu-Chun Weng
Signed-off-by: Shu-Chun Weng --- v1 -> v2: New: Add all IPV6 options to do_print_sockopt(), including the newly supported IPV6_ADDR_PREFERENCES. linux-user/strace.c | 108 1 file changed, 108 insertions(+) diff --git a/linux-user/strace.c b/linux

[PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option

2020-08-11 Thread Shu-Chun Weng
SOL_UDP manipulate options at UDP level. All six options currently defined in linux source include/uapi/linux/udp.h take integer values. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier --- v1 -> v2: Split out SOL_UDP into own patch. Updated do_print_sockopt(). linux-user/strace.c

[PATCH v2 3/8] linux-user: add missing IPv6 get/setsockopt option

2020-08-11 Thread Shu-Chun Weng
IPV6_ADDR_PREFERENCES (RFC5014: Source address selection) was not supported. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier --- v1 -> v2: Split out IPV6 options into own patch. do_print_sockopt() changes added in a separate patch since a large number of unrelated changes are invo

[PATCH v2 1/8] linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls

2020-08-11 Thread Shu-Chun Weng
Also reorder blocks so that they are all in the same order everywhere. Signed-off-by: Shu-Chun Weng --- v1 -> v2: Updated print_fcntl(). linux-user/strace.c | 55 --- linux-user/syscall.c | 10 +++ linux-user/syscall_defs.h | 14 +- 3

[PATCH v2 7/8] thunk: supports flexible arrays

2020-08-11 Thread Shu-Chun Weng
Flexible arrays may appear in the last field of a struct and are heavily used in the ioctl(SIOCETHTOOL) system call on Linux. E.g. struct ethtool_regs { __u32 cmd; __u32 version; /* driver-specific, indicates different chips/revs */ __u32 len; /* bytes */ __u8da

[PATCH v2 5/8] linux-user: Update SO_TIMESTAMP to SO_TIMESTAMP_OLD/NEW

2020-08-11 Thread Shu-Chun Weng
Both guest options map to host SO_TIMESTAMP while keeping a global bit to remember if the guest expects the old or the new format. Don't support programs mixing two formats. Added a multiarch test to verify. Signed-off-by: Shu-Chun Weng --- v1 -> v2: Only keep track of old or new format global

[PATCH v2 6/8] linux-user: setsockopt() SO_TIMESTAMPNS and SO_TIMESTAMPING

2020-08-11 Thread Shu-Chun Weng
This change supports SO_TIMESTAMPNS_OLD/NEW and SO_TIMESTAMPING_OLD/NEW for setsocketopt() with SOL_SOCKET. Based on the SO_TIMESTAMP_OLD/NEW framework. The three pairs share the same flag `SOCK_TSTAMP_NEW` in linux kernel for deciding if the old or the new format is used. Signed-off-by: Shu-Chun

[PATCH v2 8/8] linux-user: Add support for SIOCETHTOOL ioctl

2020-08-11 Thread Shu-Chun Weng
The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h in Linux kernel source code: #define SIOCETHTOOL 0x8946 These ioctls get (or set) various structures pointed by the field ifr_data in the structure ifreq depending on the first 4 bytes of

[PATCH] iotests/259: Fix reference output

2020-08-11 Thread Max Reitz
The error message has changed recently, breaking the test. Fix it. Fixes: a2b333c01880f56056d50c238834d62e32001e54 ("block: nbd: Fix convert qcow2 compressed to nbd") Signed-off-by: Max Reitz --- tests/qemu-iotests/259.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC v3] checkpatch: detect missing changes to trace-events

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- scripts/checkpatch.pl | 48 1 file changed, 36 insertions(+), 12 deletions(-) v2 -> v3 : * move the check for missing changes to MAINTAINERS and trace-events later on, as otherwise the check for in_commit_log

[Bug 1366363] Re: qemu-git gravis ultrasound not working

2020-08-11 Thread Dominik Danieluk
The problem seems to exist for a long time. I have tried it today with both: qemu-system-i386 ./msdos.disk -device gus,irq=5 -parallel none and qemu-system-x86_64 ./msdos.disk -device gus,irq=5 -parallel none with and without providing the irq parameter and gus does not install with conscan showi

[Bug 1366363] Re: qemu-git gravis ultrasound not working

2020-08-11 Thread Dominik Danieluk
The conscan screenshot for my previous post ... ** Attachment added: "conscan.png" https://bugs.launchpad.net/qemu/+bug/1366363/+attachment/5400606/+files/conscan.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [PATCH v7 07/13] hw/arm: Load -bios image as a boot ROM for npcm7xx

2020-08-11 Thread Philippe Mathieu-Daudé
Hi Havard, On 8/11/20 2:46 AM, Havard Skinnemoen wrote: > If a -bios option is specified on the command line, load the image into > the internal ROM memory region, which contains the first instructions > run by the CPU after reset. > > If -bios is not specified, the vbootrom included with qemu is

Re: [Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-11 Thread Alex Bennée
Tony.LI <1890...@bugs.launchpad.net> writes: > Hi,Alex.May be you are right.I don't understand what you want to express. > I don't know what causes traps. > Is it caused by software, or qemu executes CPU-sensitive instruction > simulation. Does it work if you run: taskset 1 qemu-x86_64 goog

[PATCH] iotests/059: Fix reference output

2020-08-11 Thread Max Reitz
As of the patch to flush qemu-img's "Formatting" message before the error message, 059 has been broken for vmdk. Fix it. Fixes: 4e2f4418784da09cb106264340241856cd2846df ("qemu-img: Flush stdout before before potential stderr messages") Signed-off-by: Max Reitz --- tests/qemu-iotests/059.

Re: [RFC PATCH 5/8] migration/dirtyrate: Compare hash results for recorded ramblock

2020-08-11 Thread Zheng Chuan
On 2020/8/5 1:29, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> From: Zheng Chuan >> >> Compare hash results for recorded ramblock. >> >> Signed-off-by: Zheng Chuan >> Signed-off-by: YanYing Zhang >> --- >> migration/dirtyrate.c | 77 >>

Re: [PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-08-11 Thread Philippe Mathieu-Daudé
Hi Havard, On 8/11/20 2:46 AM, Havard Skinnemoen wrote: > This adds two acceptance tests for the quanta-gsj machine. > > One test downloads a lightly patched openbmc flash image from github and > verifies that it boots all the way to the login prompt. > > The other test downloads a kernel, initr

Re: [RFC v3 2/8] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-11 Thread Roman Bolshakov
On Mon, Aug 03, 2020 at 11:05:27AM +0200, Claudio Fontana wrote: > The new interface starts unused, will start being used by the > next patches. > > It provides methods for each accelerator to start a vcpu, kick a vcpu, > synchronize state, get cpu virtual clock and elapsed ticks. > > Signed-off-

[PATCH 3/3] target/riscv: support 'x-k' in cpu option

2020-08-11 Thread Chih-Min Chao
zfh extension is still a draft and is not included in master spec. The related field, 'k', in MISA is also undecided but has been discussed in reference link. ref: zfh spec: https://github.com/riscv/riscv-isa-manual/tree/zfh misa field: https://github.com/riscv/riscv-isa-manual/issues/

[PATCH 0/3] RFC: target/riscv: add half-precision floating-point extension

2020-08-11 Thread Chih-Min Chao
The spec is a draft but required by vector extension. The reference is availabe at https://github.com/riscv/riscv-isa-manual/tree/zfh The patch depends two unmerged patch set 1. extend softfloat to support int8 and alternative NaN probagapation 2. NaNBox fix Based-on: <1596102747-20226-1

[PATCH 2/3] target/riscv: Implement zfh extension

2020-08-11 Thread Chih-Min Chao
From: Kito Cheng All of instructions listed in spec has been implemented. The spec is still under discussion and not included master branch. ref: https://github.com/riscv/riscv-isa-manual/tree/zfh Signed-off-by: Kito Cheng Signed-off-by: Chih-Min Chao --- target/riscv/cpu.h

Re: [RFC v3 8/8] cpus: extract out hvf-specific code to target/i386/hvf/

2020-08-11 Thread Roman Bolshakov
On Mon, Aug 03, 2020 at 11:05:33AM +0200, Claudio Fontana wrote: > register a "CpusAccel" interface for HVF as well. > > Signed-off-by: Claudio Fontana > --- > softmmu/cpus.c| 63 > target/i386/hvf/Makefile.objs | 2 +- > target/i386/hvf/hvf-cpus.c| 13

[PATCH 1/3] target/riscv: add NaN-Boxing helper for half-float

2020-08-11 Thread Chih-Min Chao
When writing, box the 16bit value with all ones in high part[63:16] When reading, unbox the 16bit value from 64bit storage and validate it Signed-off-by: Chih-Min Chao --- target/riscv/internals.h | 16 target/riscv/translate.c | 15 +++ 2 files changed, 31 insertion

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-11 Thread Tony.LI
Hi,Alex.It can't work.And I find some thing: $ glxinfo | grep -i open radeon: Failed to get PCI ID, error number -38 libGL error: failed to create dri screen libGL error: failed to load driver: radeonsi libGL error: failed to get magic libGL error: failed to load driver: radeonsi OpenGL vendor st

Re: [PATCH 135/147] meson: sphinx-build

2020-08-11 Thread Paolo Bonzini
On 10/08/20 21:06, Paolo Bonzini wrote: >>> diff --git a/configure b/configure >>> index 21b9ed2..7e7b4d8 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -7768,7 +7768,6 @@ echo "INSTALL_PROG=$install -c -m 0755" >> >>> $config_host_mak >>> echo "INSTALL_LIB=$install -c -m 0644" >> $config_

Re: [PATCH] target/ppc: Integrate icount to purr, vtb, and tbu40

2020-08-11 Thread Peter Maydell
On Tue, 11 Aug 2020 at 02:29, Gustavo Romero wrote: > > Currently if option '-icount auto' is passed to the QEMU TCG to enable > counting instructions the VM crashes with the following error report when > Linux runs on it: > > qemu-system-ppc64: Bad icount read > > This happens because read/write

[PULL 0/2] Block patches for 5.1.0-rc4

2020-08-11 Thread Max Reitz
Hi, There is a bug in the backup job that breaks backups from images whose size is not aligned to the job's cluster size (i.e., qemu crashes because of a failed assertion). If this bug makes it into the release, it would be a regression from 5.0. On one hand, this is probably a rare configuratio

[PULL 1/2] block/block-copy: always align copied region to cluster size

2020-08-11 Thread Max Reitz
From: Stefan Reiter Since commit 42ac214406e0 (block/block-copy: refactor task creation) block_copy_task_create calculates the area to be copied via bdrv_dirty_bitmap_next_dirty_area, but that can return an unaligned byte count if the image's last cluster end is not aligned to the bitmap's granul

[PULL 2/2] iotests: add test for unaligned granularity bitmap backup

2020-08-11 Thread Max Reitz
From: Stefan Reiter Start a VM with a 4097 byte image attached, add a 4096 byte granularity dirty bitmap, mark it dirty, and then do a backup. This used to run into an assert and fail, check that it works as expected and also check the created image to ensure that misaligned backups in general w

Re: [PULL 0/2] Block patches for 5.1.0-rc4

2020-08-11 Thread Peter Maydell
On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote: > > Hi, > > There is a bug in the backup job that breaks backups from images whose > size is not aligned to the job's cluster size (i.e., qemu crashes > because of a failed assertion). If this bug makes it into the release, > it would be a regression

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Cornelia Huck
On Mon, 10 Aug 2020 19:06:38 +0200 Paolo Bonzini wrote: > This version is substantially less "draft-like", and the diffstat > is actually quite large with Thursday's draft. > > The changes are as follows: > - updated oss-fuzz build script > - various cases fixed that broke depending on present/a

Re: [PATCH 003/147] pc-bios/s390-ccw: do not use rules.mak

2020-08-11 Thread Cornelia Huck
On Mon, 10 Aug 2020 19:06:41 +0200 Paolo Bonzini wrote: > From: Thomas Huth > > Signed-off-by: Paolo Bonzini ...this one probably needs signoffs from both of you? > --- > pc-bios/s390-ccw/Makefile | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) Anyway, with this

Re: [PULL 0/2] Block patches for 5.1.0-rc4

2020-08-11 Thread Max Reitz
On 11.08.20 11:39, Peter Maydell wrote: > On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote: >> >> Hi, >> >> There is a bug in the backup job that breaks backups from images whose >> size is not aligned to the job's cluster size (i.e., qemu crashes >> because of a failed assertion). If this bug makes

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-11 Thread Tony.LI
And I can get some infomation by "qemu-x86_64-static -d strace". 17344 getdents(8,274880624768,32768,115,274880624899,39) = 0 17344 close(8) = 0 17344 ioctl(7,0xc0406400,0x297330) = 0 17344 ioctl(7,0xc0406400,0x297330) = 0 17344 fstat(7,0x004001a0b660) = 0 17344 fcntl(7,F_DUPFD_CLOEXEC,3)

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-11 Thread Tony.LI
$ lspci 00:00.0 PCI bridge: Cadence Design Systems, Inc. Device dc16 00:01.0 PCI bridge: Cadence Design Systems, Inc. Device dc08 00:02.0 PCI bridge: Cadence Design Systems, Inc. Device dc01 00:03.0 PCI bridge: Cadence Design Systems, Inc. Device dc16 00:04.0 PCI bridge: Cadence Design Systems, Inc

Reminder: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Martin Wilck
On Wed, 2020-07-15 at 15:32 +0200, mwi...@suse.com wrote: > From: Martin Wilck > > If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and > non-blocking read() to retrieve random data, it ends up in a tight > loop with poll() always returning POLLIN and read() returning EAGAIN. > This

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Philippe Mathieu-Daudé
You Cc'ed qemu-devel, so Cc'ing the virtio-rng maintainers. On 7/15/20 3:32 PM, mwi...@suse.com wrote: > From: Martin Wilck > > If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and > non-blocking read() to retrieve random data, it ends up in a tight > loop with poll() always returni

[PATCH] docs/system: clarify deprecation scheduled

2020-08-11 Thread Stefan Hajnoczi
The sentence explaining the deprecation schedule is ambiguous. Make it clear that a feature deprecated in the Nth release is guaranteed to remain available in the N+1th release. Removal can occur in the N+2nd release or later. As an example of this in action, see commit 25956af3fe5dd0385ad8017bc76

Re: [PATCH-for-5.2] hw/i386/q35: Remove unreachable Xen code on Q35 machine

2020-08-11 Thread Anthony PERARD via
On Wed, Jul 22, 2020 at 10:25:17AM +0200, Philippe Mathieu-Daudé wrote: > Xen accelerator requires specific changes to a machine to be able > to use it. See for example the 'Xen PC' machine configure its PCI > bus calling pc_xen_hvm_init_pci(). There is no 'Xen Q35' machine > declared. This code wa

Re: [RFC v3 2/8] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-11 Thread Claudio Fontana
On 8/11/20 10:59 AM, Roman Bolshakov wrote: > On Mon, Aug 03, 2020 at 11:05:27AM +0200, Claudio Fontana wrote: >> The new interface starts unused, will start being used by the >> next patches. >> >> It provides methods for each accelerator to start a vcpu, kick a vcpu, >> synchronize state, get cpu

[PATCH v2 00/14] Reverse debugging

2020-08-11 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[PATCH v2 01/14] replay: don't record interrupt poll

2020-08-11 Thread Pavel Dovgalyuk
Interrupt poll is not a real interrupt event. It is needed only for thread safety. This interrupt is used for i386 and converted to hardware interrupt by cpu_handle_interrupt function. Therefore it is not needed to be recorded, because hardware interrupt will be recorded after converting. Signed-o

[PATCH v2 07/14] replay: introduce info hmp/qmp command

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the r

[PATCH v2 03/14] qcow2: introduce icount field for snapshots

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- block/qcow2-snapshot.c |7 +++ block/qcow2.h |3

[PATCH v2 02/14] replay: provide an accessor for rr filename

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alex Bennée --- include/

[PATCH v2 09/14] replay: implement replay-seek command

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by

[PATCH v2 04/14] migration: introduce icount field for snapshots

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (

[PATCH v2 11/14] gdbstub: add reverse step support in replay mode

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. Bu

[PATCH v2 05/14] iotests: update snapshot test for new output format

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates iotests that verify qemu monitor output. New output format for snapshot listing include ICOUNT column. Signed-off-by: Pavel Dovgalyuk --- tests/qemu-iotests/267.out | 48 ++-- 1 file changed, 24 insertions(+), 2

[PATCH v2 14/14] tests/acceptance: add reverse debugging test

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording saves the execution of some instructions and makes an initial VM snapshot to allow reverse execution. Replay s

[PATCH v2 13/14] replay: describe reverse debugging in docs/replay.txt

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt ind

[PATCH v2 06/14] qapi: introduce replay.json for record/replay-related stuff

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster Reviewed-by: Alex Bennée --- MAINTAINERS |1 + include/sysemu/replay.h |1 +

[PATCH v2 08/14] replay: introduce breakpoint at the specified step

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - numb

[PATCH v2 10/14] replay: flush rr queue before loading the vmstate

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flus

Re: [RFC PATCH v3 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-11 Thread Cornelia Huck
On Thu, 30 Jul 2020 11:45:41 +0200 Cornelia Huck wrote: > On Tue, 28 Jul 2020 21:51:33 -0300 > Thiago Jung Bauermann wrote: > > > Hi, > > > > Cornelia Huck writes: > > > > > On Wed, 22 Jul 2020 23:56:57 -0300 > > > Thiago Jung Bauermann wrote: > > > > > >> Instead of setting CPUState:

[PATCH v2 12/14] gdbstub: add reverse continue support in replay mode

2020-08-11 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the b

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-11 Thread Peter Maydell
ioctl number 0xc0106467 is DRM_IOCTL_RADEON_INFO. QEMU doesn't support that ioctl (each ioctl needs individual handling to convert the data structures it uses between the guest and host architecture). If your guest binary is trying to make graphics-card specific ioctl calls like this then I'm afrai

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Michael S. Tsirkin
On Wed, Jul 15, 2020 at 03:32:55PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and > non-blocking read() to retrieve random data, it ends up in a tight > loop with poll() always returning POLLIN and read() returning EAGAIN.

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Cornelia Huck
On Tue, 11 Aug 2020 11:41:39 +0200 Cornelia Huck wrote: > On Mon, 10 Aug 2020 19:06:38 +0200 > Paolo Bonzini wrote: > > > This version is substantially less "draft-like", and the diffstat > > is actually quite large with Thursday's draft. > > > > The changes are as follows: > > - updated oss-f

[PATCH v4 1/9] hw/pci-host: add pci-intack write method

2020-08-11 Thread P J P
From: Prasad J Pandit Add pci-intack mmio write method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Signed-off-by: Prasad J Pandit --- hw/pci-host/prep.c | 8 1 file changed, 8 insertions(+) Update v4: add Reviewed-

[PATCH v4 4/9] prep: add ppc-parity write method

2020-08-11 Thread P J P
From: Prasad J Pandit Add ppc-parity mmio write method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Acked-by: David Gibson Signed-off-by: Prasad J Pandit --- hw/ppc/prep_systemio.c | 8 1 file changed, 8 insertions(+) Update v4: No change, v3 was acked -> https:/

[PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

2020-08-11 Thread P J P
From: Prasad J Pandit Hello, * This series asserts that MemoryRegionOps objects define read/write callback methods. Thus avoids potential NULL pointer dereference. ex. -> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2 * Also adds various undefined Memo

[PATCH v4 2/9] pci-host: designware: add pcie-msi read method

2020-08-11 Thread P J P
From: Prasad J Pandit Add pcie-msi mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Signed-off-by: Prasad J Pandit --- hw/pci-host/designware.c | 19 +++ 1 file changed, 19 insertions(+) Update v

[PATCH v4 3/9] vfio: add quirk device write method

2020-08-11 Thread P J P
From: Prasad J Pandit Add vfio quirk device mmio write method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Acked-by: Alex Williamson Signed-off-by: Prasad J Pandit --- hw/vfio/pci-quirks.c | 8 1 file changed, 8 ins

[PATCH v4 6/9] spapr_pci: add spapr msi read method

2020-08-11 Thread P J P
From: Prasad J Pandit Add spapr msi mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Acked-by: David Gibson Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/ppc/spapr_pci.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Update

[PATCH v4 5/9] nvram: add nrf51_soc flash read method

2020-08-11 Thread P J P
From: Prasad J Pandit Add nrf51_soc mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Reviewed-by: Peter Maydell Signed-off-by: Prasad J Pandit --- hw/nvram/nrf51_nvm.c | 10 ++ 1 file changed, 10 insertions(+) Update v4: add explanatory comment and Revi

[PATCH v4 8/9] imx7-ccm: add digprog mmio write method

2020-08-11 Thread P J P
From: Prasad J Pandit Add digprog mmio write method to avoid assert failure during initialisation. Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/misc/imx7_ccm.c | 8 1 file changed, 8 insertions(+) Update v4: revise log message to guest_error -> https://lists.nongnu.

[PATCH v4 9/9] memory: assert MemoryRegionOps callbacks are defined

2020-08-11 Thread P J P
From: Prasad J Pandit When registering a MemoryRegionOps object, assert that its read/write callback methods are defined. This avoids potential guest crash via a NULL pointer dereference. Suggested-by: Peter Maydell Reviewed-by: Li Qiang Reviewed-by: Peter Maydell Signed-off-by: Prasad J Pand

[PATCH v4 7/9] tz-ppc: add dummy read/write methods

2020-08-11 Thread P J P
From: Prasad J Pandit Add tz-ppc-dummy mmio read/write methods to avoid assert failure during initialisation. Reviewed-by: Peter Maydell Signed-off-by: Prasad J Pandit --- hw/misc/tz-ppc.c | 14 ++ 1 file changed, 14 insertions(+) Update v4: add Reviewed-by tag -> https://lists

[PATCH] linux-user: Fix 'utimensat()' implementation

2020-08-11 Thread Filip Bozuta
Implementation of syscall 'utimensat()' in 'syscall.c' uses functions target_to_host/host_to_target_timespec() to convert values of 'struct timespec' between host and target. However, the implementation doesn't check whether the conversion succeeds and thus can cause an inappropriate error or succe

Re: [PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-11 Thread Alex Bennée
Cornelia Huck writes: > On Mon, 10 Aug 2020 11:51:47 +0100 > Alex Bennée wrote: > >> Mention a few of the more common naming conventions we follow in the >> code base including common variable names and function prefix and >> suffix examples. >> >> Signed-off-by: Alex Bennée >> >> --- >> v2

Re: [PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-11 Thread Cornelia Huck
On Tue, 11 Aug 2020 12:48:38 +0100 Alex Bennée wrote: > If I re-arrange slightly we can roll from qemu_ to public functions: > > Function Naming Conventions > --- > > The ``qemu_`` prefix is used for utility functions that are widely > called from across the code

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Laurent Vivier
On 11/08/2020 12:37, Philippe Mathieu-Daudé wrote: > You Cc'ed qemu-devel, so Cc'ing the virtio-rng maintainers. > > On 7/15/20 3:32 PM, mwi...@suse.com wrote: >> From: Martin Wilck >> >> If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and >> non-blocking read() to retrieve random d

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Roman Bolshakov
On Mon, Aug 10, 2020 at 07:06:38PM +0200, Paolo Bonzini wrote: > This version is substantially less "draft-like", and the diffstat > is actually quite large with Thursday's draft. > > The changes are as follows: > - updated oss-fuzz build script > - various cases fixed that broke depending on pres

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Martin Wilck
On Tue, 2020-08-11 at 07:26 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 03:32:55PM +0200, mwi...@suse.com wrote: > > drivers/char/hw_random/virtio-rng.c | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/char/hw_random/virtio-rng.c > > b/drivers/

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Martin Wilck
On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: > > > > drivers/char/hw_random/virtio-rng.c | 14 ++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/drivers/char/hw_random/virtio-rng.c > > > b/drivers/char/hw_random/virtio-rng.c > > > index 79a6e47b5fbc..9847

Re: [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-11 Thread Mauro Matteo Cascella
On Mon, Aug 10, 2020 at 7:14 PM Cédric Le Goater wrote: > > On 8/10/20 3:43 PM, Mauro Matteo Cascella wrote: > > On Thu, Aug 6, 2020 at 3:21 PM Cédric Le Goater wrote: > >> > >> When inserting the VLAN tag in packets, memmove() can generate an > >> integer overflow for packets whose length is les

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Laurent Vivier
On 11/08/2020 14:22, Martin Wilck wrote: > On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: >> drivers/char/hw_random/virtio-rng.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio

Re: [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-11 Thread Peter Maydell
On Thu, 6 Aug 2020 at 14:21, Cédric Le Goater wrote: > > When inserting the VLAN tag in packets, memmove() can generate an > integer overflow for packets whose length is less than 12 bytes. > > Check length against the size of the ethernet header (14 bytes) to > avoid the crash and return FTGMAC10

Re: [PATCH] linux-user: Fix 'utimensat()' implementation

2020-08-11 Thread Laurent Vivier
Le 11/08/2020 à 13:31, Filip Bozuta a écrit : > Implementation of syscall 'utimensat()' in 'syscall.c' uses functions > target_to_host/host_to_target_timespec() to convert values of > 'struct timespec' between host and target. However, the implementation > doesn't check whether the conversion succe

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Martin Wilck
On Tue, 2020-08-11 at 14:39 +0200, Laurent Vivier wrote: > On 11/08/2020 14:22, Martin Wilck wrote: > > On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: > > > > > drivers/char/hw_random/virtio-rng.c | 14 ++ > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > diff -

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Michael S. Tsirkin
On Tue, Aug 11, 2020 at 02:07:23PM +0200, Martin Wilck wrote: > On Tue, 2020-08-11 at 07:26 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 03:32:55PM +0200, mwi...@suse.com wrote: > > > drivers/char/hw_random/virtio-rng.c | 14 ++ > > > 1 file changed, 14 insertions(+) >

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Paolo Bonzini
On 11/08/20 14:04, Roman Bolshakov wrote: > > The line in configure assumes that meson is a python program rather than > a wrapper: > > meson="$python $meson" Hmm, that means we will have to use the embedded meson if the user specifies --python. But it's probably a good idea anyway, and not p

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Laurent Vivier
On 11/08/2020 14:53, Martin Wilck wrote: > On Tue, 2020-08-11 at 14:39 +0200, Laurent Vivier wrote: >> On 11/08/2020 14:22, Martin Wilck wrote: >>> On Tue, 2020-08-11 at 14:02 +0200, Laurent Vivier wrote: >> drivers/char/hw_random/virtio-rng.c | 14 ++ >> 1 file changed, 14 ins

[PATCH] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-11 Thread Ani Sinha
We introduce a new global flag for PIIX with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. Signed-off-by: Ani Sinha --- hw/acpi/piix4.c | 3 +++ hw/i386/acpi-build

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-11 Thread Ani Sinha
On Mon, Aug 10, 2020 at 9:11 PM Ani Sinha wrote: > > > Ani > On Aug 10, 2020, 20:49 +0530, Michael S. Tsirkin , wrote: > > On Mon, Aug 10, 2020 at 08:35:56PM +0530, Ani Sinha wrote: > > > Ani > > On Aug 10, 2020, 20:30 +0530, Michael S. Tsirkin , wrote: > > > On Mon, Aug 10, 2020 at 08:24:53PM +05

Re: [PATCH] iotests/259: Fix reference output

2020-08-11 Thread Eric Blake
On 8/11/20 3:08 AM, Max Reitz wrote: The error message has changed recently, breaking the test. Fix it. Fixes: a2b333c01880f56056d50c238834d62e32001e54 ("block: nbd: Fix convert qcow2 compressed to nbd") Signed-off-by: Max Reitz --- tests/qemu-iotests/259.out | 2 +- 1 file changed,

[PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-11 Thread Ani Sinha
We introduce a new global flag for PIIX with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. Signed-off-by: Ani Sinha --- hw/acpi/piix4.c | 3 +++ hw/i386/acpi-build

Re: [PATCH] iotests/059: Fix reference output

2020-08-11 Thread Eric Blake
On 8/11/20 3:41 AM, Max Reitz wrote: As of the patch to flush qemu-img's "Formatting" message before the error message, 059 has been broken for vmdk. Fix it. Fixes: 4e2f4418784da09cb106264340241856cd2846df ("qemu-img: Flush stdout before before potential stderr messages") Signed-off-by:

[PATCH v5 1/4] Add the NVMM vcpu API

2020-08-11 Thread Kamil Rytarowski
From: Maxime Villard Adds support for the NetBSD Virtual Machine Monitor (NVMM) stubs and introduces the nvmm.h sysemu API for managing the vcpu scheduling and management. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Dau

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Michael S. Tsirkin
On Tue, Aug 11, 2020 at 03:00:14PM +0200, Laurent Vivier wrote: > No problem. This code is tricky and it took me several months to really > start to understand it ... Oh great, we actually have someone who understands the code! Maybe you can help me understand: virtio_read takes the buf pointer an

[PATCH v5 3/4] Introduce the NVMM impl

2020-08-11 Thread Kamil Rytarowski
From: Maxime Villard Implements the NetBSD Virtual Machine Monitor (NVMM) target. Which acts as a hypervisor accelerator for QEMU on the NetBSD platform. This enables QEMU much greater speed over the emulated x86_64 path's that are taken on NetBSD today. Signed-off-by: Maxime Villard Signed-off

[PATCH v5 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

2020-08-11 Thread Kamil Rytarowski
From: Maxime Villard Introduces the configure support for the new NetBSD Virtual Machine Monitor that allows for hypervisor acceleration from usermode components on the NetBSD platform. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez Reviewed-by: Philip

[PATCH v5 4/4] Add the NVMM acceleration enlightenments

2020-08-11 Thread Kamil Rytarowski
From: Maxime Villard Implements the NVMM accelerator cpu enlightenments to actually use the nvmm-all accelerator on NetBSD platforms. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Tested-by: Jared McNeill --- inc

Re: [RFC v3 8/8] cpus: extract out hvf-specific code to target/i386/hvf/

2020-08-11 Thread Claudio Fontana
On 8/11/20 11:00 AM, Roman Bolshakov wrote: > On Mon, Aug 03, 2020 at 11:05:33AM +0200, Claudio Fontana wrote: >> register a "CpusAccel" interface for HVF as well. >> >> Signed-off-by: Claudio Fontana >> --- >> softmmu/cpus.c| 63 >> target/i386/hvf/Makefile.

Re: [PATCH v2] virtio-rng: return available data with O_NONBLOCK

2020-08-11 Thread Laurent Vivier
On 11/08/2020 15:14, Michael S. Tsirkin wrote: > On Tue, Aug 11, 2020 at 03:00:14PM +0200, Laurent Vivier wrote: >> No problem. This code is tricky and it took me several months to really >> start to understand it ... > > Oh great, we actually have someone who understands the code! > Maybe you can

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-08-11 Thread Zhenyu Ye
Hi Kevin, On 2020/8/10 23:38, Kevin Wolf wrote: > Am 10.08.2020 um 16:52 hat Zhenyu Ye geschrieben: >> Before doing qmp actions, we need to lock the qemu_global_mutex, >> so the qmp actions should not take too long time. >> >> Unfortunately, some qmp actions need to acquire aio context and >> this

  1   2   3   >