Re: [PATCH RFCv3 6/9] s390x/diag: subcode to query device memory region

2020-07-28 Thread Cornelia Huck
On Mon, 27 Jul 2020 14:02:47 +0200 David Hildenbrand wrote: > On 27.07.20 13:15, Heiko Carstens wrote: > > On Mon, Jul 27, 2020 at 12:12:02PM +0200, David Hildenbrand wrote: > >> +#define DIAG500_DEVICE_MEMORY_REGION 4 > > > > Regardless what we end up with, this needs to be s

[PATCH 1/3] qemu-options: introduce functions to parse options

2020-07-28 Thread Hogan Wang
From: w00506750 All of the qemu options are parsed in qemu_init function, and make qemu_init function too long and nasty. Introduce 'parser' function pointer in QEMUOption struct to parse one option or a set of options. Signed-off-by: Hogan Wang --- qemu-options-wrapper.h | 10 +- qemu

[PATCH 3/3] qemu-options: introduce parse_virtfs

2020-07-28 Thread Hogan Wang
From: w00506750 introduce parse_virtfs to parse virtfs options. Signed-off-by: Hogan Wang --- qemu-options.hx | 2 +- softmmu/vl.c| 158 +--- 2 files changed, 82 insertions(+), 78 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx ind

[PATCH 2/3] qemu-options: introduce parse_net_client

2020-07-28 Thread Hogan Wang
From: w00506750 introduce parse_net_client to parse netdev/nic/net clients. Signed-off-by: Hogan Wang --- include/net/net.h | 1 - net/net.c | 9 - qemu-options.hx | 8 +--- softmmu/vl.c | 30 -- 4 files changed, 17 insertions(+), 31 de

Re: [PATCH for-5.1?] iotests: Adjust which tests are quick

2020-07-28 Thread Thomas Huth
On 27/07/2020 22.07, Vladimir Sementsov-Ogievskiy wrote: > 27.07.2020 22:51, Eric Blake wrote: >> A quick run of './check -qcow2 -g migration' shows that test 169 is >> NOT quick, but meanwhile several other tests ARE quick.  Let's adjust >> the test designations accordingly. >> >> Signed-off-by: E

Re: sysbus_create_simple Vs qdev_create

2020-07-28 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/07/20 08:00, Markus Armbruster wrote: >>> They are already mirrored as links, and guess what's the link >>> name: "child[...]". >> You're right, except for the link name: it's parent_bus. > > There's links in both directions. > >> So the qtree is actually embedded in

[Bug 1888923] Re: Configured Memory access latency and bandwidth not taking effect

2020-07-28 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888923 Title: Configured Memory access latency and bandwidth not taking effect Status in QEMU: In

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread Markus Armbruster
Greg Kurz writes: > On Mon, 20 Jul 2020 17:24:35 +0200 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > We have a dedicated error API for hints. Use it instead of embedding >> > the hint in the error message, as recommanded in the "qapi/error.h" >> > header file. >> > >> > Since spapr

[PATCH v2 1/4] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-28 Thread Thomas Huth
When using --enable-werror for the macOS builders in the Cirrus-CI, the atomic64 test is currently failing, and config.log shows a bunch of error messages like this: config-temp/qemu-conf.c:6:7: error: implicit declaration of function '__atomic_load_8' is invalid in C99 [-Werror,-Wimplicit-funct

[PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror

2020-07-28 Thread Thomas Huth
Compiler warnings currently go unnoticed in our macOS builds, since -Werror is only enabled for Linux and MinGW builds by default. So let's enable them here now, too. Unfortunately, the sasl header is marked as deprecated in the macOS headers and thus generates a lot of deprecation warnings. Thus w

[PATCH v2 0/4] Improve FreeBSD and macOS jobs in the Cirrus-CI

2020-07-28 Thread Thomas Huth
Our configure script does not enable -Werror on macOS and FreeBSD by default yet. That's bad in the CI, since we might miss compiler warnings and thus bugs this way. So after fixing a problem in the configure script in the first patch, we now turn on -Werror here in the second and third patch. The

[PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror

2020-07-28 Thread Thomas Huth
Compiler warnings currently go unnoticed in our FreeBSD builds, since -Werror is only enabled for Linux and MinGW builds by default. So let's enable them here now, too. Reviewed-by: Ed Maste Signed-off-by: Thomas Huth --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v2 4/4] cirrus.yml: Update the macOS jobs to Catalina

2020-07-28 Thread Thomas Huth
When looking at the CI jobs on cirrus-ci.com, it seems like the mojave-based images have been decomissioned a while ago already, since apparently all our jobs get automatically upgraded to catalina. So let's update our YML script accordingly to avoid confusion. Reviewed-by: Ed Maste Signed-off-by

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Since commit 510ef98dca5, qdev_realize() aborts if bus-less > device is realized on a bus. While commits 514db7710b..007d1dbf72 > took care of converting all mainstream uses, QEMU forks weren't > converted. > > These forks are usually maintained by hobbyist with i

Re: [PATCH v3] hw/core/qdev: Increase qdev_realize() kindness

2020-07-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/7/20 11:47 AM, Paolo Bonzini wrote: >> On 07/07/20 05:33, Philippe Mathieu-Daudé wrote: >>> Since commit 510ef98dca5, qdev_realize() aborts if bus-less device >>> is realized on a bus. While commits 514db7710b..007d1dbf72 took >>> care of converting all mains

Re: [PATCH v2 0/2] qmp: Expose MachineClass::default_ram_id

2020-07-28 Thread Michal Privoznik
On 7/27/20 8:41 PM, Eduardo Habkost wrote: Hi Michal, It looks like this has fallen through the cracks, my apologies. I'm queueing this for 5.2. I assume this is the latest version, correct? Yes. No worries, I forgot about it too :-) If I remembered, I would have pinged. Michal

Re: [PULL v2 0/6] virtio,pci: bugfixes

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 15:32, Michael S. Tsirkin wrote: > > v2 due to issues noticed by dgilbert in v1. > Changes from v1: > dropped a work around for pci migration for old machine types. > > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-trac

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 02:09, Bruce Rogers wrote: On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: On 7/20/20 8:24 PM, Claudio Fontana wrote: I have now been able to reproduce this on X86 as well. It happens much more rarely, about once every 10 times. I will sort out the data and try to make it

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-28 Thread Paolo Bonzini
On 28/07/20 09:44, Markus Armbruster wrote: >> -assert(!DEVICE_GET_CLASS(dev)->bus_type); >> +} else if (DEVICE_GET_CLASS(dev)->bus_type) { >> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'", >> + DEVICE_GET_CLASS(dev)->bus_type, >> +

[Bug 1888467] Re: qemu-img http convert bug

2020-07-28 Thread dunfeng zhang
hello, I have an other question。 Why does qemu-img support http reader mode but not http writer mode? think you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888467 Title: qemu-img http convert b

[PATCH v6 1/4] target/riscv: Fix the range of pmpcfg of CSR funcion table

2020-07-28 Thread Zong Li
The range of Physical Memory Protection should be from CSR_PMPCFG0 to CSR_PMPCFG3, not to CSR_PMPADDR9. Signed-off-by: Zong Li Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/tar

[PATCH v6 3/4] target/riscv: Fix the translation of physical address

2020-07-28 Thread Zong Li
The real physical address should add the 12 bits page offset. It also causes the PMP wrong checking due to the minimum granularity of PMP is 4 byte, but we always get the physical address which is 4KB alignment, that means, we always use the start address of the page to check PMP for all addresses

[PATCH v6 0/4] Fix some PMP implementations

2020-07-28 Thread Zong Li
This patch set contains the fixes for wrong index of pmpcfg CSR on rv64, and the pmp range in CSR function table. After 3rd version of this patch series, we also fix the PMP issues such as wrong physical address translation and wrong ignoring PMP checking. Changed in v6: - Mask low 12 bits of ret

[PATCH v6 2/4] target/riscv/pmp.c: Fix the index offset on RV64

2020-07-28 Thread Zong Li
On RV64, the reg_index is 2 (pmpcfg2 CSR) after the seventh pmp entry, it is not 1 (pmpcfg1 CSR) like RV32. In the original implementation, the second parameter of pmp_write_cfg is "reg_index * sizeof(target_ulong)", and we get the the result which is started from 16 if reg_index is 2, but we expec

[PATCH v6 4/4] target/riscv: Change the TLB page size depends on PMP entries.

2020-07-28 Thread Zong Li
The minimum granularity of PMP is 4 bytes, it is small than 4KB page size, therefore, the pmp checking would be ignored if its range doesn't start from the alignment of one page. This patch detects the pmp entries and sets the small page size to TLB if there is a PMP entry which cover the page size

[Bug 1390520] Re: virtual machine fails to start with connected audio cd

2020-07-28 Thread Thomas Huth
** Changed in: qemu Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1390520 Title: virtual machine fails to start with connected audio cd Status in QEMU: New S

Re: [RFC PATCH 1/2] hw/riscv: sifive_u: Add file-backed OTP. softmmu/vl: add otp-file to boot option

2020-07-28 Thread Paolo Bonzini
On 28/07/20 04:02, Green Wan wrote: > Hi Bin, > > Thanks for the reply. > > I think we can add property to sifive_u_otp_properties[] (something like > below) and remove generic code dependency. What do you think of it? > > @@ -243,6 +245,7 @@ static const MemoryRegionOps sifive_u_otp_ops = { >  

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Christian Schoenebeck
On Sonntag, 19. Juli 2020 14:29:13 CEST Christian Schoenebeck wrote: > The newly added function v9fs_co_readdir_many() retrieves multiple > directory entries with a single fs driver request. It is intended to > replace uses of v9fs_co_readdir(), the latter only retrives a single > directory entry p

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 02:09, Bruce Rogers wrote: On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: On 7/20/20 8:24 PM, Claudio Fontana wrote: I have now been able to reproduce this on X86 as well. It happens much more rarely, about once every 10 times. I will sort out the data and try to make it

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Greg Kurz
On Tue, 28 Jul 2020 10:33:42 +0200 Christian Schoenebeck wrote: > On Sonntag, 19. Juli 2020 14:29:13 CEST Christian Schoenebeck wrote: > > The newly added function v9fs_co_readdir_many() retrieves multiple > > directory entries with a single fs driver request. It is intended to > > replace uses o

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread Thomas Huth
On 27/07/2020 16.41, Peter Maydell wrote: > On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >> >> Avoid covering object refcount of qemu_irq, otherwise it may causes >> memory leak. >> >> Signed-off-by: Keqian Zhu >> --- >> hw/core/irq.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-28 Thread Niklas Schnelle
On 7/27/20 5:40 PM, Pierre Morel wrote: > > > On 2020-07-23 18:29, Alex Williamson wrote: >> On Thu, 23 Jul 2020 11:13:55 -0400 >> Matthew Rosato wrote: >> >>> I noticed that after kernel commit abafbc55 'vfio-pci: Invalidate mmaps >>> and block MMIO access on disabled memory' vfio-pci via qe

Re: [PULL 0/4] Net patches

2020-07-28 Thread Jason Wang
On 2020/7/28 下午1:57, Jason Wang wrote: The following changes since commit 9303ecb658a0194560d1eecde165a1511223c2d8: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200727' into staging (2020-07-27 17:25:06 +0100) are available in the git repository at: https://github.com/jas

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread zhukeqian
Hi Thomas, On 2020/7/28 16:48, Thomas Huth wrote: > On 27/07/2020 16.41, Peter Maydell wrote: >> On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >>> >>> Avoid covering object refcount of qemu_irq, otherwise it may causes >>> memory leak. >>> >>> Signed-off-by: Keqian Zhu >>> --- >>> hw/core/irq

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread Greg Kurz
On Tue, 28 Jul 2020 09:26:08 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Mon, 20 Jul 2020 17:24:35 +0200 > > Markus Armbruster wrote: > > > >> Greg Kurz writes: > >> > >> > We have a dedicated error API for hints. Use it instead of embedding > >> > the hint in the error messa

[PULL V2 0/3] Net patches

2020-07-28 Thread Jason Wang
The following changes since commit 93ea484375ab473379dd9c836261ef484bd71ab1: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-07-27 21:00:01 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to f

[PULL V2 2/3] virtio-net: check the existence of peer before accessing vDPA config

2020-07-28 Thread Jason Wang
We try to check whether a peer is VDPA in order to get config from there - with no peer, this leads to a NULL pointer dereference. Add a check before trying to access the peer type. No peer means not VDPA. Fixes: 108a64818e69b ("vhost-vdpa: introduce vhost-vdpa backend") Cc: Cindy Lu Tested-by: C

[PULL V2 1/3] virtio-pci: fix wrong index in virtio_pci_queue_enabled

2020-07-28 Thread Jason Wang
From: Yuri Benditovich We should use the index passed by the caller instead of the queue_sel when checking the enablement of a specific virtqueue. This is reported in https://bugzilla.redhat.com/show_bug.cgi?id=1702608 Fixes: f19bcdfedd53 ("virtio-pci: implement queue_enabled method") Signed-of

[PULL V2 3/3] net: forbid the reentrant RX

2020-07-28 Thread Jason Wang
The memory API allows DMA into NIC's MMIO area. This means the NIC's RX routine must be reentrant. Instead of auditing all the NIC, we can simply detect the reentrancy and return early. The queue->delivering is set and cleared by qemu_net_queue_deliver() for other queue helpers to know whether the

[PATCH for-5.2] spapr: Avoid some integer conversions in spapr_phb_realize()

2020-07-28 Thread Greg Kurz
Without this patch, the irq number gets converted uselessly from int to int32_t, back and forth. This doesn't fix an actual issue, it's just to make the code neater. Suggested-by: Markus Armbruster Signed-off-by: Greg Kurz --- This is a follow-up to my previous "spapr: Simplify error handling

[PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Paul Durrant
From: Paul Durrant The recent commit da278d58a092 "accel: Move Xen accelerator code under accel/xen/" introduced a subtle semantic change, making xen_enabled() always return false unless CONFIG_XEN is defined prior to inclusion of sysemu/xen.h, which appears to be the normal case. This causes var

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: > > From: Paul Durrant > > The recent commit da278d58a092 "accel: Move Xen accelerator code under > accel/xen/" introduced a subtle semantic change, making xen_enabled() always > return false unless CONFIG_XEN is defined prior to inclusion of syse

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-28 Thread Niklas Schnelle
On 7/27/20 6:47 PM, Alex Williamson wrote: > On Mon, 27 Jul 2020 17:40:39 +0200 > Pierre Morel wrote: > >> On 2020-07-23 18:29, Alex Williamson wrote: >>> On Thu, 23 Jul 2020 11:13:55 -0400 >>> Matthew Rosato wrote: >>> I noticed that after kernel commit abafbc55 'vfio-pci: Invalidate

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Christian Schoenebeck
On Dienstag, 28. Juli 2020 10:46:00 CEST Greg Kurz wrote: > > So I'll prepare a v8 with this patch here split into two. > > > > But this is it. I don't see another chunk in this patch set that could be > > split further down in an useful way. > > > > Best regards, > > Christian Schoenebeck > > Y

Re: [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to

Re: [PATCH v7 5/6] 9pfs: differentiate readdir lock between 9P2000.u vs. 9P2000.L

2020-07-28 Thread Christian Schoenebeck
On Sonntag, 19. Juli 2020 15:20:11 CEST Christian Schoenebeck wrote: > Previous patch suggests that it might make sense to use a different mutex > type now while handling readdir requests, depending on the precise > protocol variant, as v9fs_do_readdir_with_stat() (used by 9P2000.u) uses > a CoMute

Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()

2020-07-28 Thread Greg Kurz
On Tue, 28 Jul 2020 11:34:12 +0200 Christian Schoenebeck wrote: > On Dienstag, 28. Juli 2020 10:46:00 CEST Greg Kurz wrote: > > > So I'll prepare a v8 with this patch here split into two. > > > > > > But this is it. I don't see another chunk in this patch set that could be > > > split further do

[PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Cornelia Huck
Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13

[Bug 917645] Re: [Feature request] ia64-softmmu wanted

2020-07-28 Thread John Paul Adrian Glaubitz
Someone is working on it, see: https://github.com/XVilka/qemu-ia64 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/917645 Title: [Feature request] ia64-softmmu wanted Status in HelenOS branches: C

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 09:48, Thomas Huth wrote: > > On 27/07/2020 16.41, Peter Maydell wrote: > > On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: > >> > >> Avoid covering object refcount of qemu_irq, otherwise it may causes > >> memory leak. > >> > >> Signed-off-by: Keqian Zhu > >> --- > >> hw

Re: [PATCH v0 3/4] migration: add background snapshot

2020-07-28 Thread Denis Plotnikov
On 27.07.2020 19:48, Dr. David Alan Gilbert wrote: * Denis Plotnikov (dplotni...@virtuozzo.com) wrote: ... +static void page_fault_thread_stop(void) +{ +if (page_fault_fd) { +close(page_fault_fd); +page_fault_fd = 0; +} I think you need to do that after you've done t

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:27 AM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: >> >> From: Paul Durrant >> >> The recent commit da278d58a092 "accel: Move Xen accelerator code under >> accel/xen/" introduced a subtle semantic change, making xen_enabled() always >> return false unles

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé wrote: > I'd rather uninline xen_enabled() but I'm not sure this has perf > penalties. Paolo is that OK to uninline it? Can we just follow the same working pattern we already have for kvm_enabled() etc ? thanks -- PMM

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:53 AM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé > wrote: >> I'd rather uninline xen_enabled() but I'm not sure this has perf >> penalties. Paolo is that OK to uninline it? I suppose no because it is in various hot paths: exec.c:588:if (xen_en

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:56 AM, Philippe Mathieu-Daudé wrote: > On 7/28/20 11:53 AM, Peter Maydell wrote: >> On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé >> wrote: >>> I'd rather uninline xen_enabled() but I'm not sure this has perf >>> penalties. Paolo is that OK to uninline it? > > I suppose no b

Re: [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typeoffset size 0 serialized 4718592 65536 1 serialized 429

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 08:43:29AM +0200, Thomas Huth wrote: > On 27/07/2020 12.57, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote: > >> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > >> wrote: > >>> I guess we were expecting the distrib to upd

Re: [PATCH v2 4/4] cirrus.yml: Update the macOS jobs to Catalina

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:05AM +0200, Thomas Huth wrote: > When looking at the CI jobs on cirrus-ci.com, it seems like the mojave-based > images have been decomissioned a while ago already, since apparently all our > jobs get automatically upgraded to catalina. So let's update our YML script >

Re: [PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:04AM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our macOS builds, since -Werror > is only enabled for Linux and MinGW builds by default. So let's enable them > here now, too. > Unfortunately, the sasl header is marked as deprecated in the m

Re: [PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jul 28, 2020 at 09:44:03AM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our FreeBSD builds, since > -Werror is only enabled for Linux and MinGW builds by default. So let's > enable them here now, too. > > Reviewed-by: Ed Maste > Signed-off-by: Thomas Huth > ---

Re: [PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich --- tests/qem

[PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Philippe Mathieu-Daudé
CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema, definin

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 11:00, Philippe Mathieu-Daudé wrote: > Apparently kvm_enabled() checks CONFIG_KVM_IS_POSSIBLE instead > of CONFIG_KVM, I suppose to bypass this limitation (from osdep.h): > > 21 #ifdef NEED_CPU_H > 22 # ifdef CONFIG_KVM > 24 # define CONFIG_KVM_IS_POSSIBLE > 25 # endif

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200728100925.10454-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

2020-07-28 Thread Stefan Hajnoczi
On Thu, Jul 02, 2020 at 04:06:32PM +0300, Michael Tokarev wrote: > 01.07.2020 12:12, Christophe de Dinechin wrote: > .. > >>> # Build libraries > >>> > >>> +libqemuutil.a-libs += $(call extract-libs, $(util-obj-y) $(trace-obj-y) > >>> $(stub-obj-y)) > >>> +libvhost-user.a-libs += $(call extract-l

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

2020-07-28 Thread David Gibson
On Tue, Jul 28, 2020 at 11:07:26AM +0200, Greg Kurz wrote: > On Tue, 28 Jul 2020 09:26:08 +0200 > Markus Armbruster wrote: > > > Greg Kurz writes: > > > > > On Mon, 20 Jul 2020 17:24:35 +0200 > > > Markus Armbruster wrote: > > > > > >> Greg Kurz writes: > > >> > > >> > We have a dedicated er

Re: [PULL 0/3] Block patches for 5.1

2020-07-28 Thread Peter Maydell
On Mon, 27 Jul 2020 at 15:38, Max Reitz wrote: > > The following changes since commit 4215d3413272ad6d1c6c9d0234450b602e46a74c: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.1-20200727' > into staging (2020-07-27 09:33:04 +0100) > > are available in the Git repository at: > >

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Thomas Huth
On 28/07/2020 11.46, Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_piix.c | 14 ++

[PATCH] virtio-ccw-input: fix description

2020-07-28 Thread Cornelia Huck
Fix a copy/paste error. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/virtio-ccw-input.c b/hw/s390x/virtio-ccw-input.c index 5601e25deed8..83136fbba15c 100644 --- a/hw/s390x/virtio-ccw-input.c +++ b/hw/s3

Re: [PATCH v5 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-07-28 Thread Stefan Hajnoczi
On Tue, Jun 23, 2020 at 04:42:30PM +0200, Lukas Straub wrote: > In many cases, if qemu has a network connection (qmp, migration, chardev, > etc.) > to some other server and that server dies or hangs, qemu hangs too. > These patches introduce the new 'yank' out-of-band qmp command to recover from >

[PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Thursday, July 16, 2020, Ahmed Karaman wrote: > Python script that prints executed helpers of a QEMU invocation. > > Hi, Ahmed. You outlined the envisioned user workflow regarding this script in your report. As I understand it, it generally goes like this: 1) The user first discovers helpers

Re: [PATCH] virtio-ccw-input: fix description

2020-07-28 Thread Thomas Huth
On 28/07/2020 12.28, Cornelia Huck wrote: > Fix a copy/paste error. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw-input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw-input.c b/hw/s390x/virtio-ccw-input.c > index 5601e25deed8..83136

Re: [RFC v2 1/3] virtio: add vhost-user-fs-ccw device

2020-07-28 Thread Cornelia Huck
On Fri, 17 Jul 2020 11:29:27 +0200 Marc Hartmayer wrote: > From: Halil Pasic > > Wire up the CCW device for vhost-user-fs. > > Signed-off-by: Halil Pasic > --- > hw/s390x/Makefile.objs | 1 + > hw/s390x/vhost-user-fs-ccw.c | 73 > 2 files changed,

Re: Qemu installation error from source

2020-07-28 Thread Stefan Hajnoczi
On Wed, Jul 01, 2020 at 06:04:33AM +0530, Asmita Jha wrote: > Thanks for your response. I am not sure I compiled libbz2. > Because while installing qemu from source , I just followed the steps as > mentioned in wiki. > I am noob in this field. > > I tried using ./configure --static, it gave an er

[PATCH for-5.1? 3/3] msf2-soc, stellaris: Don't wire up SYSRESETREQ

2020-07-28 Thread Peter Maydell
The MSF2 SoC model and the Stellaris board code both wire SYSRESETREQ up to a function that just invokes qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); This is now the default action that the NVIC does if the line is not connected, so we can delete the handling code. Signed-off-by: Pet

[PATCH for-5.1? 0/3] Fix AIRCR.SYSRESETREQ for most M-profile boards

2020-07-28 Thread Peter Maydell
QEMU's NVIC device provides an outbound qemu_irq "SYSRESETREQ" which it signals when the guest sets the SYSRESETREQ bit in the AIRCR register. This matches the hardware design (where the CPU has a signal of this name and it is up to the SoC to connect that up to an actual reset mechanism), but in

[PATCH for-5.1? 2/3] hw/intc/armv7m_nvic: Provide default "reset the system" behaviour for SYSRESETREQ

2020-07-28 Thread Peter Maydell
The NVIC provides an outbound qemu_irq "SYSRESETREQ" which it signals when the guest sets the SYSRESETREQ bit in the AIRCR register. This matches the hardware design (where the CPU has a signal of this name and it is up to the SoC to connect that up to an actual reset mechanism), but in QEMU it mo

[PATCH for-5.1? 1/3] include/hw/irq.h: New function qemu_irq_is_connected()

2020-07-28 Thread Peter Maydell
Mostly devices don't need to care whether one of their output qemu_irq lines is connected, because functions like qemu_set_irq() silently do nothing if there is nothing on the other end. However sometimes a device might want to implement default behaviour for the case where the machine hasn't wire

Re: [PATCH] hw: add compat machines for 5.2

2020-07-28 Thread Andrew Jones
On Tue, Jul 28, 2020 at 11:46:45AM +0200, Cornelia Huck wrote: > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/pc_pi

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Thursday, July 16, 2020, Ahmed Karaman > wrote: > >> Python script that prints executed helpers of a QEMU invocation. >> >> > Hi, Ahmed. > > You outlined the envisioned user workflow regarding this s

Re: [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-28 Thread Cornelia Huck
On Tue, 21 Jul 2020 18:44:56 +0200 Halil Pasic wrote: > On Tue, 21 Jul 2020 09:40:10 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote: > > > Since virtio existed even before it got standardized, the virtio > > > standard defines the foll

[Bug 1888923] Re: Configured Memory access latency and bandwidth not taking effect

2020-07-28 Thread Vishnu Dixit
It indeed was a non NUMA machine -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888923 Title: Configured Memory access latency and bandwidth not taking effect Status in QEMU: Invalid Bug descri

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Tuesday, July 28, 2020, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> >> On Thursday, July 16, 2020, Ahmed Karaman >> wrote: >> >>> Python script that prints executed helper

Re: [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-28 Thread Marc Hartmayer
On Tue, Jul 21, 2020 at 06:44 PM +0200, Halil Pasic wrote: > On Tue, 21 Jul 2020 09:40:10 -0400 > "Michael S. Tsirkin" wrote: > >> On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote: >> > Since virtio existed even before it got standardized, the virtio >> > standard defines the follow

Re: [PATCH v11 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON o

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Max Reitz
On 28.07.20 01:09, Bruce Rogers wrote: > On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: >> On 7/20/20 8:24 PM, Claudio Fontana wrote: >>> I have now been able to reproduce this on X86 as well. >>> >>> It happens much more rarely, about once every 10 times. >>> >>> I will sort out the dat

Re: Qemu installation error from source

2020-07-28 Thread Asmita Jha
Thanks for the information. Yes this helps. Regards Asmita On Tue, Jul 28, 2020, 4:07 PM Stefan Hajnoczi wrote: > On Wed, Jul 01, 2020 at 06:04:33AM +0530, Asmita Jha wrote: > > Thanks for your response. I am not sure I compiled libbz2. > > Because while installing qemu from source , I just fo

Re: [RFC v2 1/3] virtio: add vhost-user-fs-ccw device

2020-07-28 Thread Halil Pasic
On Tue, 28 Jul 2020 12:31:51 +0200 Cornelia Huck wrote: > On Fri, 17 Jul 2020 11:29:27 +0200 > Marc Hartmayer wrote: > > > From: Halil Pasic > > > > Wire up the CCW device for vhost-user-fs. > > > > Signed-off-by: Halil Pasic > > --- > > hw/s390x/Makefile.objs | 1 + > > hw/s390x/vh

Re: [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-28 Thread Halil Pasic
On Tue, 28 Jul 2020 12:48:50 +0200 Cornelia Huck wrote: > On Tue, 21 Jul 2020 18:44:56 +0200 > Halil Pasic wrote: > > > On Tue, 21 Jul 2020 09:40:10 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jul 17, 2020 at 11:29:28AM +0200, Marc Hartmayer wrote: > > > > Since virtio existed e

Re: [RFC v2 1/3] virtio: add vhost-user-fs-ccw device

2020-07-28 Thread Cornelia Huck
On Tue, 28 Jul 2020 13:25:57 +0200 Halil Pasic wrote: > On Tue, 28 Jul 2020 12:31:51 +0200 > Cornelia Huck wrote: > > > On Fri, 17 Jul 2020 11:29:27 +0200 > > Marc Hartmayer wrote: > > > > > From: Halil Pasic > > > > > > Wire up the CCW device for vhost-user-fs. > > > > > > Signed-off-by

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 14:10, Max Reitz wrote: On 28.07.20 01:09, Bruce Rogers wrote: On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: On 7/20/20 8:24 PM, Claudio Fontana wrote: I have now been able to reproduce this on X86 as well. It happens much more rarely, about once every 10 times. I will

Re: [PATCH v5 1/7] Introduce yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:41PM +0200, Lukas Straub wrote: > The yank feature allows to recover from hanging qemu by "yanking" > at various parts. Other qemu systems can register themselves and > multiple yank functions. Then all yank functions for selected > instances can be called by the 'yank

Re: [PATCH v5 2/7] block/nbd.c: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:45PM +0200, Lukas Straub wrote: > Register a yank function which shuts down the socket and sets > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > error occured. > > Signed-off-by: Lukas Straub > --- > block/nbd.c | 101 +

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Paolo Bonzini
On 28/07/20 13:33, Vladimir Sementsov-Ogievskiy wrote: >> Thanks for both your investigation.  Does the attached patch help? > > For me, the reproducer is fixed with your patch. Is it possible to make a quick testcase using qemu-io? Paolo

Re: [PATCH v5 3/7] chardev/char-socket.c: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:48PM +0200, Lukas Straub wrote: > Register a yank function to shutdown the socket on yank. > > Signed-off-by: Lukas Straub > --- > chardev/char-socket.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Da

Re: [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class

2020-07-28 Thread Vladimir Sementsov-Ogievskiy
17.07.2020 11:14, Andrey Shinkevich wrote: Per original script design, QcowHeader class may dump the QCOW2 header info separately from the QCOW2 extensions info. To implement the to_dict() method for dumping extensions, let us introduce the class Qcow2HeaderExtensionsDoc. I think, when dumping

RE: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 28 July 2020 11:09 > To: qemu-devel@nongnu.org > Cc: Paul Durrant ; Paolo Bonzini ; > xen-de...@lists.xenproject.org; > Stefano Stabellini ; Anthony Perard > ; Philippe > Mathieu-Daudé ; Paul Durrant ; Peter > Maydell > > Subj

Re: [PATCH v5 4/7] migration: Add yank feature

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:52PM +0200, Lukas Straub wrote: > Register yank functions on sockets to shut them down. > > Signed-off-by: Lukas Straub > --- > migration/channel.c | 12 > migration/migration.c | 18 +- > migration/multifd.c

Re: [PATCH v5 6/7] io: Document thread-safety of qio_channel_shutdown

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:59PM +0200, Lukas Straub wrote: > Migration and yank code assume that qio_channel_shutdown is thread > -safe. Document this after checking the code. > > Signed-off-by: Lukas Straub > --- > include/io/channel.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by:

Re: [PATCH v5 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

2020-07-28 Thread Daniel P . Berrangé
On Tue, Jun 23, 2020 at 04:42:56PM +0200, Lukas Straub wrote: > Make qio_channel_tls_shutdown thread-safe by using atomics when > accessing tioc->shutdown. > > Signed-off-by: Lukas Straub > --- > io/channel-tls.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel

  1   2   3   4   >